Le 05/02/2016 15:13, Andrew F. Davis a écrit : > The TI TLK10x Ethernet PHYs are similar in the interrupt relevant > registers and so are compatible with the DP83848x devices already > supported. Add these and re-order code to support additional PHYs.
This looks fine, but this could also be broken down into 3 commits: - one which adds the macro to add new PHY entries - one which renames DP83848_PHY_ID to DP83848C_PHY_ID - one which factors out the interrupt enable mask > > Signed-off-by: Andrew F. Davis <a...@ti.com> > --- > drivers/net/phy/dp83848.c | 89 > ++++++++++++++++++++++++++++------------------- > 1 file changed, 53 insertions(+), 36 deletions(-) > > diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c > index 5e14e62..bc88259 100644 > --- a/drivers/net/phy/dp83848.c > +++ b/drivers/net/phy/dp83848.c > @@ -1,7 +1,8 @@ > /* > * Driver for the Texas Instruments DP83848 PHY > * > - * Copyright (C) 2015 Texas Instruments Inc. > + * Copyright (C) 2015-2016 Texas Instruments Incorporated - > http://www.ti.com/ > + * Andrew F. Davis <a...@ti.com> We have the git changelog to know who added changes to the driver, you can drop that specific change and just bump the copyright year.-- -- Florian
