[PATCH net-next 4/4] dtb: xgene: Add irqs to support multi queue

2016-02-02 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 8 +++- arch/arm64/boot/dts/apm/apm-storm.dtsi | 8 +++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/a

[PATCH net-next 1/4] drivers: net: xgene: Add support for Classifier engine

2016-02-02 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/Makefile | 3 +- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 357 +++ drivers/net/ethernet/apm/xgene/xgene_ene

[PATCH net-next 3/4] drivers: net: xgene: Add support for multiple queues

2016-02-02 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 11 +- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 452 ++- drivers/net/ethernet/apm/xgene/xgene_ene

[PATCH net-next 2/4] drivers: net: xgene: Add support for RSS

2016-02-02 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 386 +++- drivers/net/ethernet/apm/xgene/xgene_enet_cle.h | 52 2 files changed, 433 insertions(+), 5 d

[PATCH net-next 0/4] Add support for Classifier and RSS

2016-02-02 Thread Iyappan Subramanian
This patch series enables (i) Classifier engine that is used for parsing through the packet and extracting a search string that is then used to search a database to find associative data. (ii) Receive Side Scaling (RSS) that does dynamic load balancing of the CPUs by controlling the number of me

[RESEND PATCH 0/9] Namespaceify more of the tcp sysctl knobs

2016-02-02 Thread Nikolay Borisov
This patch series continues making more of the tcp-related sysctl knobs be per net-namespace. Most of these apply per socket and have global defaults so should be safe and I don't expect any breakages. Having those per net-namespace is useful when multiple containers are hosted and it is requir

[RESEND PATCH 2/9] ipv4: Namespaceify tcp synack retries sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h| 1 + include/net/tcp.h | 1 - net/ipv4/inet_connection_sock.c | 7 ++- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c | 1 + net/ipv4/tcp_timer.c| 3 +-- 6

[RESEND PATCH 1/9] ipv4: Namespaceify tcp syn retries sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 2 ++ include/net/tcp.h | 1 - net/ipv4/sysctl_net_ipv4.c | 18 +- net/ipv4/tcp.c | 3 ++- net/ipv4/tcp_ipv4.c| 2 ++ net/ipv4/tcp_timer.c | 4 ++-- 6 files changed, 17 insertio

[RESEND PATCH 4/9] ipv4: Namespaceify tcp reordering sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 2 +- include/net/tcp.h | 4 +++- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp.c | 2 +- net/ipv4/tcp_input.c | 12 ++-- net/ipv4/tcp_ipv4.c| 2 +- net/ipv4/tcp_metrics.c

[RESEND PATCH 3/9] ipv4: Namespaceify tcp syncookies sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 2 ++ include/net/tcp.h | 1 - net/ipv4/syncookies.c | 4 +--- net/ipv4/sysctl_net_ipv4.c | 18 +- net/ipv4/tcp_input.c | 10 ++ net/ipv4/tcp_ipv4.c| 3 ++- net/ipv4/tcp_minisoc

[RESEND PATCH 5/9] ipv4: Namespaceify tcp_retries1 sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 1 - net/ipv4/sysctl_net_ipv4.c | 16 net/ipv4/tcp_ipv4.c| 1 + net/ipv4/tcp_timer.c | 8 5 files changed, 14 insertions(+), 13 deletions(-) diff --git a/

[RESEND PATCH 6/9] ipv4: Namespaceify tcp_retries2 sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 1 - net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c| 1 + net/ipv4/tcp_output.c | 3 ++- net/ipv4/tcp_timer.c | 5 ++--- 6 files changed, 13 insertions(+)

[RESEND PATCH 9/9] ipv4: Namespaceify tcp_notsent_lowat sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 4 ++-- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c| 1 + net/ipv4/tcp_output.c | 3 --- 5 files changed, 11 insertions(+), 12 deletions(-) diff --git a/incl

[RESEND PATCH 7/9] ipv4: Namespaceify tcp_orphan_retries sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 1 - net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp_ipv4.c| 1 + net/ipv4/tcp_timer.c | 3 +-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/include

[RESEND PATCH 8/9] ipv4: Namespaceify tcp_fin_timeout sysctl knob

2016-02-02 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- include/net/netns/ipv4.h | 1 + include/net/tcp.h | 3 +-- net/ipv4/sysctl_net_ipv4.c | 14 +++--- net/ipv4/tcp.c | 7 +++ net/ipv4/tcp_ipv4.c| 1 + 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/i

Re: [PATCH net-next 2/4] net: dev: add batching to net_device notifiers

2016-02-02 Thread Salam Noureddine
On Tue, Feb 2, 2016 at 12:55 PM, Julian Anastasov wrote: > > Hello, > > On Mon, 1 Feb 2016, Salam Noureddine wrote: > >> @@ -1572,8 +1582,12 @@ rollback: >> call_netdevice_notifier(nb, NETDEV_UNREGISTER, dev); >> + call_netdevice_notifier(nb, NETD

[net] bonding: use return instead of goto

2016-02-02 Thread Zhang Shengju
Replace 'goto' with 'return' to remove unnecessary check at label: err_undo_flags. Signed-off-by: Zhang Shengju --- drivers/net/bonding/bond_main.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index

Re: [PATCH] rtlwifi: fix semicolon.cocci warnings

2016-02-02 Thread Larry Finger
On 02/02/2016 09:40 PM, kbuild test robot wrote: drivers/net/wireless/realtek/rtlwifi/core.c:59:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Byeoungwook Kim Signed-off-by: Fengguang Wu --- Acked-by: Larry Finger Thanks,

[PATCH v3] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-02 Thread Byeoungwook Kim
Conditional codes in rtl_addr_delay() were improved in readability and performance by using switch codes. Reviewed-by: Julian Calaby Signed-off-by: Byeoungwook Kim Signed-off-by: Fengguang Wu --- V3 remove unneeded semicolon. V2 split in separate patchs. drivers/net/wireless/realtek/rtlwifi/co

[PATCH v2 net-next 2/8] be2net: check for INSUFFICIENT_PRIVILEGES error

2016-02-02 Thread Sriharsha Basavapatna
From: Suresh Reddy The driver currently logs the message "VF is not privileged to issue opcode" by checking only the base_status field for UNAUTHORIZED_REQUEST. Add check to look for INSUFFICIENT_PRIVILEGES in the additional status field also as not all cmds fail with that base status. Signed-of

[PATCH v2 net-next 4/8] be2net: SRIOV Queue distribution should factor in EQ-count of VFs

2016-02-02 Thread Sriharsha Basavapatna
The SRIOV resource distribution logic for RX/TX queue counts is not optimal when a small number of VFs are enabled. It does not take into account the VF's EQ count while computing the queue counts. Because of this, the VF gets a large number of queues, though it doesn't have sufficient EQs, resulti

[PATCH v2 net-next 8/8] be2net: Fix interval calculation in interrupt moderation

2016-02-02 Thread Sriharsha Basavapatna
From: Padmanabh Ratnakar Interrupt moderation parameters need to be recalculated only after a time interval of 1 ms. Interval calculation is wrong when there is a rollover of jiffies. Using recommended way of interval calculation using jiffies to fix this. Signed-off-by: Padmanabh Ratnakar Sign

[PATCH v2 net-next 6/8] be2net: Fix Lancer error recovery

2016-02-02 Thread Sriharsha Basavapatna
From: Padmanabh Ratnakar After error is detected, wait for adapter to move to ready state before destroying queues and cleanup of other resources. Also skip performing any cleanup for non-Lancer chips and move debug messages to correct routine. Signed-off-by: Padmanabh Ratnakar Signed-off-by: S

[PATCH v2 net-next 1/8] be2net: return error status from be_set_phys_id()

2016-02-02 Thread Sriharsha Basavapatna
From: Suresh Reddy be_set_phys_id() returns 0 to ethtool when the command fails in the FW. This patch fixes the set_phys_id() to return -EIO in case the FW cmd fails. Signed-off-by: Suresh Reddy Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_ethtool.c | 23

[PATCH v2 net-next 7/8] be2net: Add retry in case of error recovery failure

2016-02-02 Thread Sriharsha Basavapatna
From: Padmanabh Ratnakar Retry error recovery MAX_ERR_RECOVERY_RETRY_COUNT times in case of failure during error recovery. Signed-off-by: Padmanabh Ratnakar Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be.h | 5 + drivers/net/ethernet/emulex/benet/be_ma

[PATCH v2 net-next 3/8] be2net: Fix be_vlan_rem_vid() to check vlan id being removed

2016-02-02 Thread Sriharsha Basavapatna
The driver decrements its vlan count without checking if it is really present in its list. This results in an invalid vlan count and impacts subsequent vlan add/rem ops. The function be_vlan_rem_vid() should be updated to fix this. Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/em

[PATCH v2 net-next 5/8] be2net: Don't run ethtool self-tests for VFs

2016-02-02 Thread Sriharsha Basavapatna
From: Somnath Kotur The CMD_SUBSYSTEM_LOWLEVEL cmds need DEV_CFG Privilege to run which VFs don't have by default. Self-tests need to be issued only for PFs. Signed-off-by: Somnath Kotur Signed-off-by: Sriharsha Basavapatna --- drivers/net/ethernet/emulex/benet/be_cmds.c | 29

[PATCH v2 net-next 0/8] be2net patch-set

2016-02-02 Thread Sriharsha Basavapatna
v2 changes: Patch-4:Changed a tab to space in be.h Patches-6,7,8: Updated commit log summary line: benet --> be2net Hi David, The following patch set contains a few non-critical bug fixes. Please consider applying this to the net-next tree. Thanks. Patch-1 fixes be_set_p

Re: [PATCH v2 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-02 Thread kbuild test robot
Hi Byeoungwook, [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on v4.5-rc2 next-20160202] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Byeoungwook-Kim

[PATCH] rtlwifi: fix semicolon.cocci warnings

2016-02-02 Thread kbuild test robot
drivers/net/wireless/realtek/rtlwifi/core.c:59:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Byeoungwook Kim Signed-off-by: Fengguang Wu --- core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wir

[PATCH net] tcp: do not drop syn_recv on all icmp reports

2016-02-02 Thread Eric Dumazet
From: Eric Dumazet Petr Novopashenniy reported that ICMP redirects on SYN_RECV sockets were leading to RST. This is of course incorrect. A specific list of ICMP messages should be able to drop a SYN_RECV. For instance, a REDIRECT on SYN_RECV shall be ignored, as we do not hold a dst per SYN_RE

[PATCH net-next v5 2/2] virtio_net: add ethtool support for set and get of settings

2016-02-02 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch allows the user to set and retrieve speed and duplex of the virtio_net device via ethtool. Having this functionality is very helpful for simulating different environments and also enables the virtio_net device to participate in operations where proper speed an

[PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions

2016-02-02 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add functions which check if the speed/duplex are defined. Signed-off-by: Nikolay Aleksandrov Acked-by: Michael S. Tsirkin --- v2: new patch v3: added Michael's ack v4, v5: no change include/uapi/linux/ethtool.h | 34 ++ 1 file change

[PATCH net-next v5 0/2] virtio_net: add ethtool get/set settings support

2016-02-02 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, Patch 1 adds ethtool speed/duplex validation functions which check if the value is defined. Patch 2 adds support for ethtool (get|set)_settings and uses the validation functions to check the user-supplied values. v2: split in 2 patches to allow everyone to make use

[PATCH 06/16] batman-adv: Fix kerneldoc parsing of return description

2016-02-02 Thread Antonio Quartulli
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_iv_ogm.c| 18 +++ net/batman-adv/bitarray.c | 2 +- net/batman-adv/bitarray.h | 11 +++-- net/batman-adv/bridge_lo

[PATCH 15/16] batman-adv: update copyright years for 2016

2016-02-02 Thread Antonio Quartulli
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/Makefile| 2 +- net/batman-adv/bat_algo.h | 2 +- net/batman-adv/bat_iv_ogm.c| 2 +- net/batman-adv/bitarray.c

[PATCH 07/16] batman-adv: Fix kerneldoc of main functions

2016-02-02 Thread Antonio Quartulli
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bitarray.c | 12 +--- net/batman-adv/bitarray.h | 11 +-- net/batman-adv/debugfs.c| 6 ++ net/batman-adv/main.c

[PATCH 04/16] batman-adv: Drop invalid kerneldoc for variable batadv_vlan_attrs

2016-02-02 Thread Antonio Quartulli
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/sysfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/batman-adv/sysfs.c b/net/batman-adv/sysfs.c index fe8fda8a..33772d9bd613 1

pull request: batman-adv 20160203

2016-02-02 Thread Antonio Quartulli
Hello David, Here you have our first pull request intended for net-next. This batch of patches includes a number of corrections and improvements for our kernel-doc. These changes also make sure that our doc is now properly processed by the kernel-doc parsing tool. Other than that you have a patc

[PATCH 01/16] batman-adv: Fix kerneldoc parsing of structs/enums

2016-02-02 Thread Antonio Quartulli
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/multicast.h | 2 +- net/batman-adv/packet.h| 8 net/batman-adv/types.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ne

[PATCH 02/16] batman-adv: Remove kerneldoc for missing parameters

2016-02-02 Thread Antonio Quartulli
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/fragmentation.c | 1 - net/batman-adv/packet.h| 1 - net/batman-adv/routing.c | 1 - net/batman-adv/translation-table.c | 4 4 fil

[PATCH 03/16] batman-adv: Fix names in kerneldoc of functions

2016-02-02 Thread Antonio Quartulli
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/originator.c| 4 ++-- net/batman-adv/packet.h| 2 +- net/batman-adv/send.c | 2 +- net/batman-adv/soft-interface.c| 2 +- ne

[PATCH 09/16] batman-adv: Update/repair bridge loop avoidance kerneldoc

2016-02-02 Thread Antonio Quartulli
From: Simon Wunderlich Signed-off-by: Simon Wunderlich Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bridge_loop_avoidance.c | 178 - 1 file changed, 130 insertions(+), 48 deletions(-) diff --git a/net/batman-adv/bridge_loop_

[PATCH 08/16] batman-adv: Fix kerneldoc of network-coding functions

2016-02-02 Thread Antonio Quartulli
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/network-coding.c | 13 + 1 file changed, 13 insertions(+) diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c index 1a75d

[PATCH 10/16] batman-adv: fix kerneldoc for DAT functions

2016-02-02 Thread Antonio Quartulli
Signed-off-by: Antonio Quartulli --- net/batman-adv/distributed-arp-table.c | 4 1 file changed, 4 insertions(+) diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c index 2f13429ce5d3..60df82385495 100644 --- a/net/batman-adv/distributed-arp-table.c

[PATCH 05/16] batman-adv: kernel doc readability updates

2016-02-02 Thread Antonio Quartulli
From: Marek Lindner Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/types.h | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h index 8c3dda36d9ec..7f7a0f1eaf75 100644 -

[PATCH 11/16] batman-adv: fix kerneldoc for TT functions

2016-02-02 Thread Antonio Quartulli
Signed-off-by: Antonio Quartulli --- net/batman-adv/translation-table.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index af1d24ce420f..9fcf6bf9fa11 100644 --- a/net

[PATCH 16/16] batman-adv: Switch to HTTPS version of links

2016-02-02 Thread Antonio Quartulli
From: Sven Eckelmann open-mesh.org and its subdomains can only be accessed via HTTPS. HTTP-only requests are currently redirected automatically to HTTPS but references in the source code should be only https. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Qua

[PATCH 14/16] batman-adv: Fix kernel-doc for batadv_claim_free_ref

2016-02-02 Thread Antonio Quartulli
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bridge_loop_avoidance.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loo

[PATCH 13/16] batman-adv: add kerneldoc for batadv_iv_ogm_aggr_packet

2016-02-02 Thread Antonio Quartulli
From: Simon Wunderlich Signed-off-by: Simon Wunderlich Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/bat_iv_ogm.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/net/batman-adv/bat_iv_ogm.c b/net/batman-adv/bat_iv_ogm.c index a6d3

[PATCH 12/16] batman-adv: add kernel doc for AP isolation attributes in bat_priv

2016-02-02 Thread Antonio Quartulli
Signed-off-by: Antonio Quartulli --- net/batman-adv/types.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h index 7f7a0f1eaf75..5e8c8df4c4ac 100644 --- a/net/batman-adv/types.h +++ b/net/batman-adv/types.h @@ -772,6 +772,9 @@ struct batadv_so

Re: Fw: [Bug 111751] New: Kernel send tcp reset when receive icmp redirect

2016-02-02 Thread Eric Dumazet
On Wed, 2016-02-03 at 11:56 +1100, Stephen Hemminger wrote: > > Begin forwarded message: > > Date: Tue, 2 Feb 2016 11:42:41 + > From: "bugzilla-dae...@bugzilla.kernel.org" > > To: "shemmin...@linux-foundation.org" > Subject: [Bug 111751] New: Kernel send tcp reset when receive icmp redirec

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

2016-02-02 Thread ByeoungWook Kim
Hi Julian, I sent to modify the patch again. Thanks for your assists! Regards, Byeoungwook 2016-02-03 11:06 GMT+09:00 Julian Calaby : > Hi Byeoungwook, > > On Wed, Feb 3, 2016 at 1:01 PM, Byeoungwook Kim wrote: >> rtl_*_delay() functions were reused same codes about addr variable. >> So i have

[PATCH v2 2/2] rtlwifi: Fix reusable codes in core.c

2016-02-02 Thread Byeoungwook Kim
rtl_*_delay() functions were reused same codes about addr variable. So i have converted to rtl_addr_delay() from code about addr variable. Signed-off-by: Byeoungwook Kim Reviewed-by: Julian Calaby --- V2 split in separate patchs. drivers/net/wireless/realtek/rtlwifi/core.c | 28

[PATCH v2 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-02 Thread Byeoungwook Kim
Conditional codes in rtl_addr_delay() were improved in readability and performance by using switch codes. Signed-off-by: Byeoungwook Kim Reviewed-by: Julian Calaby --- V2 split in separate patchs. drivers/net/wireless/realtek/rtlwifi/core.c | 20 ++-- 1 file changed, 14 insertio

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

2016-02-02 Thread Julian Calaby
Hi Byeoungwook, On Wed, Feb 3, 2016 at 1:01 PM, Byeoungwook Kim wrote: > rtl_*_delay() functions were reused same codes about addr variable. > So i have converted to rtl_addr_delay() from code about addr variable. > > Signed-off-by: Byeoungwook Kim > Reviewed-by: Julian Calaby Just a note for

Re: [PATCH 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-02 Thread Julian Calaby
Hi Byeounwook, On Wed, Feb 3, 2016 at 12:59 PM, Byeoungwook Kim wrote: > Conditional codes in rtl_addr_delay() were improved in readability and > performance by using switch codes. > > Signed-off-by: Byeoungwook Kim > Reported-by: Julian Calaby Reviewed-by: Julian Calaby Thanks, Julian Cala

[PATCH 2/2] rtlwifi: Fix reusable codes in core.c

2016-02-02 Thread Byeoungwook Kim
rtl_*_delay() functions were reused same codes about addr variable. So i have converted to rtl_addr_delay() from code about addr variable. Signed-off-by: Byeoungwook Kim Reviewed-by: Julian Calaby --- drivers/net/wireless/realtek/rtlwifi/core.c | 28 1 file changed,

[net] bonding: trivial: style fixes

2016-02-02 Thread Zhang Shengju
remove some redudant brackets, use sizeof(*) instead of sizeof(struct x). Signed-off-by: Zhang Shengju --- drivers/net/bonding/bond_main.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index fb4c52

[PATCH 1/2] rtlwifi: Fix improve function 'rtl_addr_delay()' in core.c

2016-02-02 Thread Byeoungwook Kim
Conditional codes in rtl_addr_delay() were improved in readability and performance by using switch codes. Signed-off-by: Byeoungwook Kim Reported-by: Julian Calaby --- drivers/net/wireless/realtek/rtlwifi/core.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff -

[PATCH stable v2 1/1] net/ipv6: add sysctl option accept_ra_min_hop_limit

2016-02-02 Thread Yuki Machida
Please apply the following patch to v4.1.x. By commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") that have been added in the 4.0-rc7, it no longer comply with RFC4861. This problem has been fixed in the commit 8013d1d7eafb ("net/ipv6: add sysctl option accept_ra_min_hop_limit"

[PATCH net] ipv6: fix a lockdep splat

2016-02-02 Thread Eric Dumazet
From: Eric Dumazet Silence lockdep false positive about rcu_dereference() being used in the wrong context. First one should use rcu_dereference_protected() as we own the spinlock. Second one should be a normal assignation, as no barrier is needed. Fixes: 18367681a10bd ("ipv6 flowlabel: Convert

Re: Keystone 2 boards boot failure

2016-02-02 Thread Franklin S Cooper Jr.
On 02/02/2016 05:26 PM, Arnd Bergmann wrote: > On Tuesday 02 February 2016 16:59:34 Franklin Cooper wrote: >> On 02/02/2016 03:26 PM, Arnd Bergmann wrote: >>> On Tuesday 02 February 2016 15:01:33 Franklin S Cooper Jr. wrote: Yes. Here is a boot log on the latest master with the below th

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

2016-02-02 Thread Hannes Frederic Sowa
On 03.02.2016 01:57, Hannes Frederic Sowa wrote: On 02.02.2016 23:11, Linus Torvalds wrote: But I'm OK with that patch as is if you prefer it that way (maybe you want to use the cred to then test for root separately etc, out maybe there already was done use of cred as cred that I just missed whe

[PATCH net] unix: correctly track in-flight fds in sending process user_struct

2016-02-02 Thread Hannes Frederic Sowa
The commit referenced in the Fixes tag incorrectly accounted the number of in-flight fds over a unix domain socket to the original opener of the file-descriptor. This allows another process to arbitrary deplete the original file-openers resource limit for the maximum of open files. Instead the send

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

2016-02-02 Thread Hannes Frederic Sowa
On 02.02.2016 23:11, Linus Torvalds wrote: [ sorry for the html mail, I'm out grocery shopping ] On Feb 2, 2016 13:55, "Hannes Frederic Sowa" wrote: I slightly tested the attached patch. Looks fine. I do wonder: if the only thing we use that "struct cred" for is to do that ->user lookup, ma

Fw: [Bug 111751] New: Kernel send tcp reset when receive icmp redirect

2016-02-02 Thread Stephen Hemminger
Begin forwarded message: Date: Tue, 2 Feb 2016 11:42:41 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 111751] New: Kernel send tcp reset when receive icmp redirect https://urldefense.proofpoint.com/v2/url?u=https-3A__bugzilla.kernel.or

Re: [PATCH] rtlwifi: Fix reusable codes in core.c

2016-02-02 Thread Julian Calaby
Hi ByeoungWook, On Wed, Feb 3, 2016 at 11:52 AM, ByeoungWook Kim wrote: > Hi Julian, > > 0xfe and 0xfb was not same codes. > 0xfe is udelay(50). and 0xfb is mdelay(50). > It same code like udelay((n) * 1000). I'm clearly blind! Sorry about that! > but i agree with your answers of some parts. I

[PATCH iproute2] ipmonitor: match user option 'all' before 'all-nsid'

2016-02-02 Thread Roopa Prabhu
From: Roopa Prabhu 'ip monitor all' is broken on older kernels. This patch fixes 'ip monitor all' to match 'all' and not 'all-nsid'. It moves parsing arg 'all-nsid' to after parsing 'all'. Before: $ip monitor all NETLINK_LISTEN_ALL_NSID: Protocol not available After: $ip monitor all [NEIGH]Del

Re: [net-next PATCH 04/11] net: bulk alloc and reuse of SKBs in NAPI context

2016-02-02 Thread Alexei Starovoitov
On Tue, Feb 02, 2016 at 10:12:01PM +0100, Jesper Dangaard Brouer wrote: > Think twice before applying > - This patch can potentially introduce added latency in some workloads > > This patch introduce bulk alloc of SKBs and allow reuse of SKBs > free'ed in same softirq cycle. SKBs are normally fr

Fw: [Bug 111771] New: deadlock in ppp/l2tp

2016-02-02 Thread Stephen Hemminger
Please excuse URL mangling, my bugzilla address appears to route through stupid corporate firewall. Begin forwarded message: Date: Tue, 2 Feb 2016 18:38:41 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 111771] New: deadlock in ppp/l2tp

bnx2x commits needed to use 7.51.10 firmware?

2016-02-02 Thread Dan Streetman
Hi Ariel, I'm trying to update the bnx2x driver in Ubuntu trusty (3.13 kernel) release to use the 7.51.10 firmware; can you help me determine which commits need to be backported? Some reference is in Launchpad bug 1454286: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1454286 basically, t

Re: [PATCH net-next 1/4] net: add event_list to struct net and provide utility functions

2016-02-02 Thread Salam Noureddine
On Tue, Feb 2, 2016 at 12:01 PM, Julian Anastasov wrote: >> +#ifdef CONFIG_NET_NS >> +static inline void net_add_event_list(struct list_head *head, struct net >> *net) >> +{ >> + if (!list_empty(&net->event_list)) > > Above check looks inverted, it works may be > because INIT_LIST_HE

[PATCH net-next v4 1/2] ethtool: add speed/duplex validation functions

2016-02-02 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add functions which check if the speed/duplex are defined. Signed-off-by: Nikolay Aleksandrov Acked-by: Michael S. Tsirkin --- v2: new patch v3: added Michael's ack v4: no change include/uapi/linux/ethtool.h | 34 ++ 1 file changed, 3

[PATCH net-next v4 2/2] virtio_net: add ethtool support for set and get of settings

2016-02-02 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This patch allows the user to set and retrieve speed and duplex of the virtio_net device via ethtool. Having this functionality is very helpful for simulating different environments and also enables the virtio_net device to participate in operations where proper speed an

[PATCH net-next v4 0/2] virtio_net: add ethtool get/set settings support

2016-02-02 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, Patch 1 adds ethtool speed/duplex validation functions which check if the value is defined. Patch 2 adds support for ethtool (get|set)_settings and uses the validation functions to check the user-supplied values. v2: split in 2 patches to allow everyone to make use

Re: [PATCH net-next 1/7] tcp: apply Kern's check on RTTs used for congestion control

2016-02-02 Thread Yuchung Cheng
On Tue, Feb 2, 2016 at 11:30 AM, Kenneth Klette Jonassen wrote: > > On Sat, Oct 17, 2015 at 6:57 AM, Yuchung Cheng wrote: > > Currently ca_seq_rtt_us does not use Kern's check. Fix that by > > checking if any packet acked is a retransmit, for both RTT used > > for RTT estimation and congestion co

Re: Keystone 2 boards boot failure

2016-02-02 Thread Arnd Bergmann
On Tuesday 02 February 2016 16:59:34 Franklin Cooper wrote: > On 02/02/2016 03:26 PM, Arnd Bergmann wrote: > > On Tuesday 02 February 2016 15:01:33 Franklin S Cooper Jr. wrote: > >> > >> Yes. Here is a boot log on the latest master with the below > >> three patches reverted. > >> http://pastebin.co

[PATCH] ethtool: add dynamic flag to {SG}RXFH

2016-02-02 Thread Jacob Keller
This patch series proposes the addition of a dynamic flag to the ethtool {SG}RXFH operations. The primary reasoning for this is so that drivers may indicate when they destroyed configured RSS settings, and can determine when they have more liberty to remove user's settings. The default mode shall b

[PATCH 2/2] fm10k: support dynamic mode for RSS table control

2016-02-02 Thread Jacob Keller
Add support for the new dynamic flag from set_rxfh and get_rxfh. For now the only known dynamic reason to change RSS is when number of queues is changed. The default mode for the driver will be dynamic, indicating that the driver is free to change its own default setting as it sees fit. Since the c

[PATCH] ethtool: add support for dynamic mode in {SG}RXFH commands

2016-02-02 Thread Jacob Keller
Signed-off-by: Jacob Keller --- ethtool-copy.h | 8 +++- ethtool.c | 36 +++- 2 files changed, 42 insertions(+), 2 deletions(-) diff --git a/ethtool-copy.h b/ethtool-copy.h index d23ffc4c38b4..620dcea06d25 100644 --- a/ethtool-copy.h +++ b/ethtool-copy.h

[PATCH 1/2] ethtool: add dynamic flag to ETHTOOL_{GS}RXFH commands

2016-02-02 Thread Jacob Keller
Ethtool supports a few operations for modifying and controlling a device's RSS table. Sometimes, changes in other features of the device may require (or desire) changes to the RSS table. Currently there is no method to indicate to the driver whether the current RSS table settings should be maintain

Re: Keystone 2 boards boot failure

2016-02-02 Thread Franklin Cooper
On 02/02/2016 03:26 PM, Arnd Bergmann wrote: > On Tuesday 02 February 2016 15:01:33 Franklin S Cooper Jr. wrote: >> >> Yes. Here is a boot log on the latest master with the below >> three patches reverted. >> http://pastebin.com/W7RWSHpE (Working) >> >> I reverted these three patches. The two lates

[RFC] Inverse of flowi{4,6}_oif: flowi{4,6}_not_oif

2016-02-02 Thread Jason A. Donenfeld
Hi folks, Sometimes it is useful to ask, "what is the route for 1.2.3.4/32 if we *exclude* routes that go out through eth8?" Currently, the only way of doing this is to read the entire routing table in userspace, and then reimplement all of the logic for the various tables and metrics and complex

[PATCH net-next] hv_netvsc: Increase delay for RNDIS_STATUS_NETWORK_CHANGE

2016-02-02 Thread Haiyang Zhang
We simulates a link down period for RNDIS_STATUS_NETWORK_CHANGE message to trigger DHCP renew. User daemons may need multiple seconds to trigger the link down event. (e.g. ifplugd: 5sec, network-manager: 4sec.) So update this link down period to 10 sec to properly trigger DHCP renew. Signed-off-by

Re: [net-next PATCH 07/11] net: introduce napi_alloc_skb_hint() for more use-cases

2016-02-02 Thread kbuild test robot
Hi Jesper, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/net-mitigating-kmem_cache-slowpath-and-BoF-discussion-patches/20160203-051706 reproduce: make htmldocs All warnings (new ones prefixed by >>): include/linux/skbuff

Re: [PATCH] rtlwifi: Fix reusable codes in core.c

2016-02-02 Thread Julian Calaby
Hi Byeoungwook, On Wed, Feb 3, 2016 at 2:48 AM, Byeoungwook Kim wrote: > rtl_*_delay() functions were reused same codes about addr variable. > So i have converted to rtl_addr_delay() from code about addr variable. > > Conditional codes in rtl_addr_delay() were improved in readability and > perfor

Re: [RFC PATCH 3/7] net: sched: add cls_u32 offload hooks for netdevs

2016-02-02 Thread Or Gerlitz
On Tue, Feb 2, 2016 at 6:42 PM, John Fastabend > [..] I added > flower support to the driver with about 100lines of code fwiw I'll > send the patch out later today, that would be very helpful, would appreciate if you post the code that supports flower to the list or @ your github > sure I skippe

Re: [PATCH v2] unix: properly account for FDs passed over unix sockets

2016-02-02 Thread Hannes Frederic Sowa
Hi Willy, On 02.02.2016 21:39, Willy Tarreau wrote: On Tue, Feb 02, 2016 at 09:32:56PM +0100, Hannes Frederic Sowa wrote: But "struct pid *" in unix_skb_parms should be enough to get us to corresponding "struct cred *" so we can decrement the correct counter during skb destruction. So: We inc

[PATCH net v2] bonding: Fix ARP monitor validation

2016-02-02 Thread Jay Vosburgh
The current logic in bond_arp_rcv will accept an incoming ARP for validation if (a) the receiving slave is either "active" (which includes the currently active slave, or the current ARP slave) or, (b) there is a currently active slave, and it has received an ARP since it became active. For

Re: [PATCH net-next 6/6] e1000e: call ndo_stop() instead of dev_close() when running offline selftest

2016-02-02 Thread David Miller
Always, when sending an updated version of a patch which is part of a series, always resubmit the entire series rather than just the patch which is changing. Thanks.

Re: Keystone 2 boards boot failure

2016-02-02 Thread Arnd Bergmann
On Tuesday 02 February 2016 15:01:33 Franklin S Cooper Jr. wrote: > > Yes. Here is a boot log on the latest master with the below > three patches reverted. > http://pastebin.com/W7RWSHpE (Working) > > I reverted these three patches. The two latest patches seem > to be trying to correct/expand upo

[net-next PATCH 11/11] RFC: net: RPS bulk enqueue to backlog

2016-02-02 Thread Jesper Dangaard Brouer
NEED TO CLEAN UP PATCH (likely still contains bugs...) When enabling Receive Packet Steering (RPS) like : echo 32768 > /proc/sys/net/core/rps_sock_flow_entries for N in $(seq 0 7) ; do echo 4096 > /sys/class/net/${DEV}/queues/rx-$N/rps_flow_cnt echo f > /sys/class/net/${DEV}/queues/rx

[net-next PATCH 10/11] RFC: net: API for RX handover of multiple SKBs to stack

2016-02-02 Thread Jesper Dangaard Brouer
Introduce napi_gro_receive_list() which takes a full SKB-list for processing by the stack. It also take over invoking eth_type_trans(). One purpose is to disconnect the icache usage/sharing between driver level RX (NAPI loop) and upper RX network stack. Another advantage is that the stack now kn

[net-next PATCH 09/11] RFC: dummy: bulk free SKBs

2016-02-02 Thread Jesper Dangaard Brouer
Normal TX completion uses napi_consume_skb(), thus also make dummy driver use this, as it make it easier to see the effect of bulk freeing SKBs. --- drivers/net/dummy.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c index 69fc840

[net-next PATCH 07/11] net: introduce napi_alloc_skb_hint() for more use-cases

2016-02-02 Thread Jesper Dangaard Brouer
The default bulk alloc size arbitrarily choosen (to be 8) might not suit all use-cases, this introduce a function napi_alloc_skb_hint() that allow the caller to specify a bulk size hint they are expecting. It is a hint because __napi_alloc_skb() limits the bulk size to the array size. One user is

[net-next PATCH 08/11] mlx5: hint the NAPI alloc skb API about the expected bulk size

2016-02-02 Thread Jesper Dangaard Brouer
Use the newly introduced napi_alloc_skb_hint() API, to get the underlying slab bulk allocation sizes to align with what mlx5 driver need for refilling its RX ring queue. Signed-off-by: Jesper Dangaard Brouer --- drivers/net/ethernet/mellanox/mlx5/core/en.h |3 ++- drivers/net/ethernet/m

[net-next PATCH 06/11] RFC: mlx5: RX bulking or bundling of packets before calling network stack

2016-02-02 Thread Jesper Dangaard Brouer
There are several techniques/concepts combined in this optimization. It is both a data-cache and instruction-cache optimization. First of all, this is primarily about delaying touching packet-data, which happend in eth_type_trans, until the prefetch have had time to fetch. Thus, hopefully avoidin

[net-next PATCH 05/11] mlx5: use napi_*_skb APIs to get bulk alloc and free

2016-02-02 Thread Jesper Dangaard Brouer
Bulk alloc and free of SKBs happen transparently by the API calls napi_alloc_skb() and napi_consume_skb(). The mlx5 driver have an extra high benefit of these changes, because it already have a loop refilling its RX ring queue. I considered if the alloc API should be allowed to request larger all

[net-next PATCH 03/11] ixgbe: bulk free SKBs during TX completion cleanup cycle

2016-02-02 Thread Jesper Dangaard Brouer
There is an opportunity to bulk free SKBs during reclaiming of resources after DMA transmit completes in ixgbe_clean_tx_irq. Thus, bulk freeing at this point does not introduce any added latency. Simply use napi_consume_skb() which were recently introduced. The napi_budget parameter is needed by

  1   2   3   >