[PATCH] rt2x00pci: Disable memory-write-invalidate when the driver exits

2016-01-03 Thread Jia-Ju Bai
The driver calls pci_set_mwi to enable memory-write-invalidate when it is initialized, but does not call pci_clear_mwi when it is removed. Many other drivers calls pci_clear_mwi when pci_set_mwi is called, such as r8169, 8139cp and e1000. This patch adds pci_clear_mwi in error handling and removal

Re: [RFC v4 0/5] Add virtio transport for AF_VSOCK

2016-01-03 Thread Jason Wang
On 12/22/2015 05:07 PM, Stefan Hajnoczi wrote: > This series is based on v4.4-rc2 and the "virtio: make find_vqs() > checkpatch.pl-friendly" patch I recently submitted. > > v4: > * Addressed code review comments from Alex Bennee > * MAINTAINERS file entries for new files > * Trace events inste

[Linux-v4.4-LTS] ppp: Backport of rtnetlink device handling

2016-01-03 Thread Sedat Dilek
Hi Guillaume, which patches do I need to backport "ppp: rtnetlink device handling" to Linux v4.4 which will be a LongTerm-Supported (LTS) Linux-kernel [0]? I tried [1] and [2] on top of recent net-next Git tree which will be in Linux v4.5. Currently, your patches are not included in net-next.git#

Re: [net-next] l2tp: rely on ppp layer for skb scrubbing

2016-01-03 Thread Sedat Dilek
Built up and ran successfully on my Ubuntu/precise AMD64 box on top of net-next.git#master up to ("c07f30ad6805: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net") and with... Guillaume Nault (2): ppp: define reusable device creation functions ppp: implement rtnetlink devi

Re: [2/2] ppp: implement rtnetlink device handling

2016-01-03 Thread Sedat Dilek
Built up and ran successfully on my Ubuntu/precise AMD64 box on top of net-next.git#master up to ("c07f30ad6805: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net"). Feel free to add my... Tested-by: Sedat Dilek - Sedat - [1] https://patchwork.ozlabs.org/patch/560703/ -- To unsubsc

Re: [1/2] ppp: define reusable device creation functions

2016-01-03 Thread Sedat Dilek
Built up and ran successfully on my Ubuntu/precise AMD64 box on top of net-next.git#master up to ("c07f30ad6805: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net"). Feel free to add my... Tested-by: Sedat Dilek - Sedat - [1] https://patchwork.ozlabs.org/patch/560702/ -- To unsubsc

[PATCH net] r8152: add reset_resume function

2016-01-03 Thread Hayes Wang
When the reset_resume() is called, the flag of SELECTIVE_SUSPEND should be cleared and reinitialize the device, whether the SELECTIVE_SUSPEND is set or not. If reset_resume() is called, it means the power supply is cut or the device is reset. That is, the device wouldn't be in runtime suspend state

Re: [PATCH RFC] vhost: basic device IOTLB support

2016-01-03 Thread Jason Wang
On 01/04/2016 09:39 AM, Yang Zhang wrote: > On 2015/12/31 15:13, Jason Wang wrote: >> This patch tries to implement an device IOTLB for vhost. This could be >> used with for co-operation with userspace(qemu) implementation of >> iommu for a secure DMA environment in guest. >> >> The idea is simpl

Fwd: [PATCH stable-3.14] usb: gadget: f_ncm: fix skb_clone memleak on error

2016-01-03 Thread pavi1729
Fixed skb_clone pointer memleak on error path. Since the newly cloned skb is still not added to the list, hence purge list wont free the cloned skb. stable-3.14.y: 5d7b0fcc26 Signed-off-by: Pavitrakumar Managutte --- drivers/usb/gadget/f_ncm.c | 2 ++ 1 file changed, 2 insertions(+) diff --gi

Re: [PATCH RFC] vhost: basic device IOTLB support

2016-01-03 Thread Jason Wang
On 12/31/2015 07:17 PM, Michael S. Tsirkin wrote: > On Thu, Dec 31, 2015 at 03:13:45PM +0800, Jason Wang wrote: >> This patch tries to implement an device IOTLB for vhost. This could be >> used with for co-operation with userspace(qemu) implementation of >> iommu for a secure DMA environment in g

Re: 4.4-rc crash (af_unix)

2016-01-03 Thread Mika Penttilä
Just got other one with rc8 (random, not easily reproducable): [ 1254.780923] Unable to handle kernel NULL pointer dereference at virtual address [ 1254.789308] pgd = a920 [ 1254.789320] [] *pgd=39120831, *pte=, *ppte= [ 1254.789331] Internal error: Oops: 817 [

Re: [iproute PATCH v3 2/2] ss: support closing inet sockets via SOCK_DESTROY.

2016-01-03 Thread Lorenzo Colitti
On Thu, Dec 31, 2015 at 5:34 AM, Stephen Hemminger wrote: >> + req.nlh.nlmsg_type = SOCK_DESTROY; >> + req.nlh.nlmsg_flags = NLM_F_REQUEST | NLM_F_ACK; >> + req.nlh.nlmsg_seq = ++rth->seq; >> + req.r.sdiag_family = d->idiag_family; >> + req.r.sdiag_protocol = diag_arg->protocol

Re: [PATCH RFC] vhost: basic device IOTLB support

2016-01-03 Thread Yang Zhang
On 2015/12/31 15:13, Jason Wang wrote: This patch tries to implement an device IOTLB for vhost. This could be used with for co-operation with userspace(qemu) implementation of iommu for a secure DMA environment in guest. The idea is simple. When vhost meets an IOTLB miss, it will request the ass

Re: Q: bad routing table cache entries

2016-01-03 Thread Stas Sergeev
04.01.2016 04:05, Sowmini Varadhan пишет: On (12/30/15 15:42), Stas Sergeev wrote: 29.12.2015 18:22, Sowmini Varadhan пишет: Do you have admin control over the ubuntu router? If yes, you might want to check the shared_media [#] setting on that router for the interfaces with overlapping subnets.

Re: Q: bad routing table cache entries

2016-01-03 Thread Sowmini Varadhan
On (12/30/15 15:42), Stas Sergeev wrote: > 29.12.2015 18:22, Sowmini Varadhan пишет: > > Do you have admin control over the ubuntu router? > > If yes, you might want to check the shared_media [#] setting > > on that router for the interfaces with overlapping subnets. > > (it is on by default, I wo

[PATCH net-next] net: Implement fast csum_partial for x86_64

2016-01-03 Thread Tom Herbert
Implement assembly routine for csum_partial for 64 bit x86. This primarily speeds up checksum calculation for smaller lengths such as those that are present when doing skb_postpull_rcsum when getting CHECKSUM_COMPLETE from device or after CHECKSUM_UNNECESSARY conversion. This implementation is sim

Re: [PATCH iproute2 1/2] Avoid in6_addr redefinition

2016-01-03 Thread Stephen Hemminger
On Sun, 3 Jan 2016 21:10:28 +0100 Felix Janda wrote: > On 2015-11-19 22:32:50 GMT Stephen Hemminger > wrote: > > This header file comes from iptables. Please fix there, otherwise > > on next time someone does merge from there it will break. > > It is already fixed in iptables: > > https://git

Re: [PATCH iproute2 v2 2/2] arpd: fix parsing of unlikely long comments

2016-01-03 Thread Stephen Hemminger
On Sun, 3 Jan 2016 19:44:29 +0100 Andreas Henriksson wrote: > Hello Stephen Hemminger. > > Please beware that this has been compile-tested only. > Submitting it like this was what I was trying to avoid > by just throwing in a FIXME comment in the initial submission. > Sorry in advance if I manag

Re: [Patch net] nfc: check sock state in llcp_sock_getname()

2016-01-03 Thread Cong Wang
On Sat, Jan 2, 2016 at 12:03 AM, Dmitry Vyukov wrote: > On Sat, Jan 2, 2016 at 1:34 AM, Cong Wang wrote: >> llcp_sock_getname() checks llcp_sock->dev to make sure >> llcp_sock is already connected or bound, however, we could >> be in the middle of llcp_sock_bind() where llcp_sock->dev >> is bound

Re: [PATCH iproute2 1/2] Avoid in6_addr redefinition

2016-01-03 Thread Felix Janda
On 2015-11-19 22:32:50 GMT Stephen Hemminger wrote: > This header file comes from iptables. Please fix there, otherwise > on next time someone does merge from there it will break. It is already fixed in iptables: https://git.netfilter.org/iptables/commit/include/libiptc/ipt_kernel_headers.h?id=0

Re: [RFC PATCH 06/12] net: sched: support qdisc_reset on NOLOCK qdisc

2016-01-03 Thread John Fastabend
On 15-12-31 06:30 PM, Alexei Starovoitov wrote: > On Wed, Dec 30, 2015 at 09:53:13AM -0800, John Fastabend wrote: >> The qdisc_reset operation depends on the qdisc lock at the moment >> to halt any additions to gso_skb and statistics while the list is >> free'd and the stats zeroed. >> >> Without t

Re: [PATCH 05/12] net-next: mediatek: add switch driver for mt7621

2016-01-03 Thread Joe Perches
On Sun, 2016-01-03 at 16:26 +0100, John Crispin wrote: > This driver is very basic and only provides basic init and irq support. > The SoC and switch core both have support for a special tag making DSA > support possible. trivia: > diff --git a/drivers/net/ethernet/mediatek/gsw_mt7621.c > b/driv

Re: [PATCH] af_unix: Fix splice-bind deadlock

2016-01-03 Thread Rainer Weikusat
On 2015/11/06, Dmitry Vyukov reported a deadlock involving the splice system call and AF_UNIX sockets, http://lists.openwall.net/netdev/2015/11/06/24 The situation was analyzed as (a while ago) A: socketpair() B: splice() from a pipe to /mnt/regular_file does sb_start_write() on /mnt C:

Re: [PATCH iproute2 v2 2/2] arpd: fix parsing of unlikely long comments

2016-01-03 Thread Andreas Henriksson
Hello Stephen Hemminger. Please beware that this has been compile-tested only. Submitting it like this was what I was trying to avoid by just throwing in a FIXME comment in the initial submission. Sorry in advance if I managed to screw something up, but hopefully I didn't... Regards, Andreas Henr

[PATCH iproute2 v2 1/2] arpd: drop unnecessary explicit null termination

2016-01-03 Thread Andreas Henriksson
This is a followup to a previous commit 61170fd88d264c "get rid of unnecessary fgets() buffer size limitation". If fgets guarantees buffer will be null terminated in the given size, then we can also drop the explicit termination. Signed-off-by: Andreas Henriksson --- misc/arpd.c | 1 - 1 file c

[PATCH iproute2 v2 2/2] arpd: fix parsing of unlikely long comments

2016-01-03 Thread Andreas Henriksson
In case the commented out line was longer than the buffer size, the remaining part was previously not properly skipped. With this fix we should now continue ignoring lines starting with # until we find a newline character. Signed-off-by: Andreas Henriksson --- misc/arpd.c | 14 +- 1

Re: [PATCH] af_unix: Fix splice-bind deadlock

2016-01-03 Thread Rainer Weikusat
Rainer Weikusat writes: [...] > + dentry = NULL; > + if (sun_path[0]) { > + /* Get the parent directory, calculate the hash for last > + * component. > + */ > + dentry = kern_path_create(AT_FDCWD, sun_path, &path, 0); > + > +

Re: [PATCH] af_unix: Fix splice-bind deadlock

2016-01-03 Thread Rainer Weikusat
Rainer Weikusat writes: > Hannes Frederic Sowa writes: >> On 27.12.2015 21:13, Rainer Weikusat wrote: >>> -static int unix_mknod(const char *sun_path, umode_t mode, struct path *res) >>> +static int unix_mknod(struct dentry *dentry, struct path *path, umode_t >>> mode, >>> + str

Re: [PATCH iproute2] arpd: drop unnecessary explicit null termination

2016-01-03 Thread Stephen Hemminger
On Sun, 3 Jan 2016 17:09:44 +0100 Andreas Henriksson wrote: > This is a followup to a previous commit 61170fd88d264c > "get rid of unnecessary fgets() buffer size limitation". > > If fgets guarantees buffer will be null terminated in the > given size, then we can also drop the explicit terminat

Re: Disable "received packet with own address as source" check

2016-01-03 Thread David Ahern
On 1/2/16 9:25 AM, Luca Dionisi wrote: My linux box has a duty. It has to forward IP packets for a "private" network which it doesn't belong to. The network is "private" has the meaning that the hosts that belong to the network have IP addresses that are unique only between them. Say that the n

[PATCH iproute2] arpd: drop unnecessary explicit null termination

2016-01-03 Thread Andreas Henriksson
This is a followup to a previous commit 61170fd88d264c "get rid of unnecessary fgets() buffer size limitation". If fgets guarantees buffer will be null terminated in the given size, then we can also drop the explicit termination. While at it, also add an unrelated FIXME comment about potential un

[PATCH 12/12] net-next: mediatek: add an entry to MAINTAINERS

2016-01-03 Thread John Crispin
Signed-off-by: John Crispin --- MAINTAINERS |7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ea17512..767f108 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6897,6 +6897,13 @@ F: include/uapi/linux/meye.h F: include/uapi/linux/ivtv* F:

[PATCH 03/12] net-next: mediatek: add switch driver for rt3050

2016-01-03 Thread John Crispin
This driver is very basic and only provides basic init and irq support. The SoC and switch core both have support for a special tag making DSA support possible. Signed-off-by: John Crispin --- drivers/net/ethernet/mediatek/esw_rt3050.c | 621 drivers/net/ethernet/me

[PATCH 07/12] net-next: mediatek: add support for rt3050

2016-01-03 Thread John Crispin
Add support for SoCs from the rt3050 family. This include rt3050, rt3052, rt3352 and rt5350. These all have a builtin 5 port 100mbit switch. Signed-off-by: John Crispin Signed-off-by: Felix Fietkau Signed-off-by: Michael Lee --- drivers/net/ethernet/mediatek/soc_rt3050.c | 154 +++

[PATCH 02/12] net-next: mediatek: add the drivers core files

2016-01-03 Thread John Crispin
This patch adds the main chunk of the driver. The ethernet core is used in all of the Mediatek/Ralink Wireless SoCs. Over the years we have seen various changes to * the register layout * the type of ports (single/dual gbit, internal FE/Gbit switch) * dma engine (PDMA/QDMA) and new offloading feat

[PATCH 11/12] net-next: mediatek: add Kconfig and Makefile

2016-01-03 Thread John Crispin
This patch adds the Makefile and Kconfig required to make the driver build. Signed-off-by: John Crispin Signed-off-by: Felix Fietkau Signed-off-by: Michael Lee --- drivers/net/ethernet/Kconfig |1 + drivers/net/ethernet/Makefile |1 + drivers/net/ethernet/mediatek/Kc

[PATCH 09/12] net-next: mediatek: add support for mt7620

2016-01-03 Thread John Crispin
Add support for SoCs from the mt7620 family. These all have one dedicated external gbit port and a builtin 5 port 100mbit switch. Additionally one of the 5 switch ports can be changed to become an additional gbit port that we can attach a phy to. Signed-off-by: John Crispin Signed-off-by: Felix F

[PATCH 08/12] net-next: mediatek: add support for rt3883

2016-01-03 Thread John Crispin
Add support for rt3883 and its smaller version rt3662. They both have a single gBit port that will normally be attached to an external phy or switch. Signed-off-by: John Crispin Signed-off-by: Felix Fietkau Signed-off-by: Michael Lee --- drivers/net/ethernet/mediatek/soc_rt3883.c | 77 ++

[PATCH 04/12] net-next: mediatek: add switch driver for mt7620

2016-01-03 Thread John Crispin
This driver is very basic and only provides basic init and irq support. The SoC and switch core both have support for a special tag making DSA support possible. Signed-off-by: John Crispin --- drivers/net/ethernet/mediatek/gsw_mt7620.c | 256 drivers/net/ethernet/me

[PATCH 06/12] net-next: mediatek: add support for rt2880

2016-01-03 Thread John Crispin
rt2880 is the oldest SoC with this core. It has a single gBit port that will normally be attached to an external phy or switch. The patch also adds the code required to drive the mdio bus. Signed-off-by: John Crispin Signed-off-by: Felix Fietkau Signed-off-by: Michael Lee --- drivers/net/ether

[PATCH 05/12] net-next: mediatek: add switch driver for mt7621

2016-01-03 Thread John Crispin
This driver is very basic and only provides basic init and irq support. The SoC and switch core both have support for a special tag making DSA support possible. Signed-off-by: John Crispin --- drivers/net/ethernet/mediatek/gsw_mt7621.c | 283 1 file changed, 283 ins

[PATCH 10/12] net-next: mediatek: add support for mt7621

2016-01-03 Thread John Crispin
Add support for SoCs from the mt7621 family. These all have 2 GMAC ports, both of which are attached to the same internal 1000MBit switch. Currently we only support GMAC1 as the sole CPU port. Signed-off-by: John Crispin Signed-off-by: Felix Fietkau Signed-off-by: Michael Lee --- drivers/net/e

[PATCH 01/12] Documentation: DT: net: add docs for ralink/mediatek SoC ethernet binding

2016-01-03 Thread John Crispin
Add three files. ralink,rt2880-net.txt descibes the actual frame engine and the other two describe the switch forntend bindings. Signed-off-by: John Crispin Signed-off-by: Felix Fietkau Signed-off-by: Michael Lee Cc: devicet...@vger.kernel.org --- .../bindings/net/mediatek,mt7620-gsw.txt

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

2016-01-03 Thread Rafał Miłecki
On 3 January 2016 at 10:36, Arend van Spriel wrote: > On 02-01-16 12:21, SF Markus Elfring wrote: >>> Did you look at the resulting assembly code for different target >>> architectures? >> >> Not yet. - Which execution system variants would you recommend for >> further comparisons? > > Guess x86{

Re: [PATCH] stmmac: Don't exit mdio registration when mdio subnode is not found in the DTS

2016-01-03 Thread Romain Perier
Hi, 2016-01-02 18:52 GMT+01:00 Florian Fainelli : > >>> This looks reasonable, does it work if we just assign mdio_node to the >>> pdev->dev.of_node to be backwards compatible with DTSes which have not yet >>> been updated? >>> >> >> I don't understand what you mean. Instead of defining mdio_nod

[PATCH] chelsio: constify cphy_ops structures

2016-01-03 Thread Julia Lawall
The cphy_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/net/ethernet/chelsio/cxgb/cphy.h |2 +- drivers/net/ethernet/chelsio/cxgb/mv88e1xxx.c |2 +- drivers/net/ethernet/chelsio/cxgb/mv88x201x.

[PATCH] Net: irda: actisys-sir: fixed coding style issue

2016-01-03 Thread hmsjwzb
fixed trail white space Signed-off-by: ZhengboWang --- drivers/net/irda/actisys-sir.c | 44 ++ 1 file changed, 19 insertions(+), 25 deletions(-) diff --git a/drivers/net/irda/actisys-sir.c b/drivers/net/irda/actisys-sir.c index e224b8b..c201361 100644 ---

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

2016-01-03 Thread SF Markus Elfring
>>> What the patch tries to do is avoid the extra 'if (err)'. >> >> Yes. - I propose to look at related consequences together with the usage >> of a popular short jump label once more. > > When I read a subject saying "Better exception handling" it sounds like > a functional improvement. Your chan

RE: [PATCH V5 4/9] Drivers: hv: ring_buffer: enhance hv_ringbuffer_read() to support hvsock

2016-01-03 Thread Dexuan Cui
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Saturday, January 2, 2016 12:30 > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; step...@networkplumber.org; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o

RE: [PATCH linux-firmware] qed: Add firmware 8.7.3.0.

2016-01-03 Thread Yuval Mintz
> > This patch pushes the next firmware for the QED module. > > Hi, any news about this one? Once more - any news here? [I'm assuming someone was out for the holidays; Although this Is merely a guess due to the fact I'm not actually subscribed to `linux-firmware'] -- To unsubscribe from this li

Re: [PATCH linux-firmware] qed: Add firmware 8.7.3.0.

2016-01-03 Thread Ben Hutchings
On Sun, 2016-01-03 at 09:51 +, Yuval Mintz wrote: > > > This patch pushes the next firmware for the QED module. > > > > Hi, any news about this one? > > Once more - any news here? > > [I'm assuming someone was out for the holidays; Although this > Is merely a guess due to the fact I'm not ac

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

2016-01-03 Thread Arend van Spriel
On 02-01-16 12:21, SF Markus Elfring wrote: >> I have never seen much evolution going on in this area. > > I can get an other impression from a specific document for example. > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/Documentation/CodingStyle > > >> What the patch