This is a followup to a previous commit 61170fd88d264c
"get rid of unnecessary fgets() buffer size limitation".
If fgets guarantees buffer will be null terminated in the
given size, then we can also drop the explicit termination.
While at it, also add an unrelated FIXME comment about
potential unlikely long comment handling bug spotted in
nearby code.
Signed-off-by: Andreas Henriksson <andr...@fatal.se>
---
misc/arpd.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/misc/arpd.c b/misc/arpd.c
index 6bb9bd1..3be700d 100644
--- a/misc/arpd.c
+++ b/misc/arpd.c
@@ -702,12 +702,16 @@ int main(int argc, char **argv)
goto do_abort;
}
- buf[sizeof(buf)-1] = 0;
while (fgets(buf, sizeof(buf), fp)) {
__u8 b1[6];
char ipbuf[128];
char macbuf[128];
+ /* FIXME: this does not properly handle the case where
+ * the comment line is longer than sizeof(buf).
+ * Should check if buf contains '\n' or skip upcoming
+ * bufs until '\n' is found.
+ */
if (buf[0] == '#')
continue;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
