On Sat, 17 Oct 2015, Dinh Nguyen wrote:
> On Sat, 17 Oct 2015, Andrew Lunn wrote:
>
> > > Sure, will try to debug. It looks like phydev->attached_dev is valid, but
> > > phydev->attached_dev->dev.of_node is NULL.
> >
> > Humm
> >
> > phydev->attached_dev is a net_device, so should be the mac.
On 10/17/15 5:28 AM, Daniel Borkmann wrote:
Anyway, another idea I've been brainstorming with Hannes today a
bit is about the following:
We register two major numbers, one for eBPF maps (X), one for eBPF
progs (Y). A user can either via cmdline call something like ...
mknod /dev/bpf/maps/map_pk
On Sat, 17 Oct 2015, Andrew Lunn wrote:
> > Sure, will try to debug. It looks like phydev->attached_dev is valid, but
> > phydev->attached_dev->dev.of_node is NULL.
>
> Humm
>
> phydev->attached_dev is a net_device, so should be the mac. What
> device is phydev->attached_dev->dev? Is it not the
On Sat, Oct 10, 2015 at 04:00:52PM -0400, Peter Hurley wrote:
>
> Note: The ASYNC_CLOSING flag state is still maintained since several
> bitrotting drivers use it for (dubious) other purposes.
I think we should drop it, it's pointless and no one ever actually does
anything with it.
thanks,
greg
Hi guys,
Coming back to this crash, I see something interesting in the
conntrack code in linux 3.4.109 (a supported kernel version). I see
that the hash table manipulations are protected by a spinlock. Also
lookups/reads are protected by RCU. However allocation and
deallocation of conntrack object
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/op
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double nested encap attributes to represent double
tagged vlan. Inner TPID encoded along with ctci in nested attributes.
Signed-off-by: Thomas F H
V17,V16: Implement reviewer's comments.
V15: Implement reviewer comments.
V14: Add outer tpid to flow_key
V13: Fix incorrect encoding and decoding of netlink to/from key
attributes.
V12: Fix some problems and issues pointed out by reviewers. When parsing
netlink attributes Ether types other the
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 16
1 file changed, 16 insertions(+)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 67ce5bd..d2494b5 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -627,6 +627,22 @@ static
These lines could be aggregated to one line because fib6_new_table() calls
fib6_get_table() inside on both cases CONFIG_IPV6_MULTIPLE_TABLES is enabled or
not.
Signed-off-by: Masashi Honma
---
net/ipv6/route.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/net/ip
On Mon, Oct 12, 2015 at 12:58:09PM +0200, Jason A. Donenfeld wrote:
>
> On Oct 12, 2015 8:59 AM, "Avargil, Raanan" wrote:
> >
> > Your analysis is correct.
> > Commit 37b12910dd11d9ab969f2c310dc9160b7f3e3405 fixes the lockup issue, and
> according to my last check it is in 4.3-rc5.
>
> Cool okay
On Mon, Oct 05, 2015 at 10:29:28AM -0700, Roland Dreier wrote:
> From: Roland Dreier
>
> Backports of 41fc014332d9 ("fib_rules: fix fib rule dumps across
> multiple skbs") introduced a regression in "ip rule show" - it ends up
> dumping the first rule over and over and never exiting, because 3.19
On Sat, Oct 03, 2015 at 09:14:16PM +0200, Thomas D. wrote:
> Hi,
>
> Holger Hoffstätte wrote:
> > Greg, any chance you can drop this into the pending 4.1.10? Otherwise people
> > will get another broken release.
>
> For me it looks like the request was too late, the patch is not included
> in 4.1
Moved around pointer to avoid ERROR
Signed-off-by: Paul McQuade
---
drivers/net/wireless/b43/dma.h | 14 +++---
drivers/net/wireless/b43/main.c | 6 +++---
drivers/net/wireless/b43/main.h | 2 +-
drivers/net/wireless/b43/xmit.h | 2 +-
4 files changed, 12 insertions(+), 12 deletions(
Removed space before that ','
Signed-off-by: Paul McQuade
---
drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 2 +-
drivers/net/wireless/rsi/rsi_mgmt.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio_ops.c
b/drivers/net/wirele
Don't turn statics to 0 or NULL
Signed-off-by: Paul McQuade
---
drivers/net/wireless/b43/main.c | 2 +-
drivers/net/wireless/b43/phy_lp.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index 040caa4..2b50
From: Florian Fainelli
Link interrupts are enabled in init_umac(), which is too early for us to
process them since we do not yet have a valid PHY device pointer. On
BCM7425 chips for instance, we will crash calling phy_mac_interrupt()
because phydev is NULL.
Fix this by moving the link interrupt
Space needed before open parenthesis
Signed-off-by: Paul McQuade
---
drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c
b/drivers/net/wireless/rt2x00/rt2x00debug.c
index 90fdb02..25ee3cb 100
Code Style: pointer is declared wrong
Signed-off-by: Paul McQuade
---
drivers/net/wireless/rt2x00/rt2x00.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00.h
b/drivers/net/wireless/rt2x00/rt2x00.h
index 6f8310a..b052e87 100644
--- a/driv
Space needed before open parenthesis
Signed-off-by: Paul McQuade #
---
drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c
b/drivers/net/wireless/rt2x00/rt2x00debug.c
index 90fdb02..25ee3cb 10
Removed empty spaces before/after parenthesis
Signed-off-by: Paul McQuade
---
drivers/net/wireless/rt2x00/rt2x00.h | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00.h
b/drivers/net/wireless/rt2x00/rt2x00.h
index 328
This code is pretty confused. The variable name 'bytes_not_copied'
clearly indicates that the programmer knew the semantics of
copy_{to,from}_user, but then the return value is checked for being
negative and used as a -Exxx return value.
I'm not sure this is the proper fix, but at least we get rid
> Sure, will try to debug. It looks like phydev->attached_dev is valid, but
> phydev->attached_dev->dev.of_node is NULL.
Humm
phydev->attached_dev is a net_device, so should be the mac. What
device is phydev->attached_dev->dev? Is it not the dev embedded in the
platform_device passed to socfpga_
Do not initialise statics to 0 or NULL
Also use tabs where possible
Signed-off-by: Paul McQuade
---
drivers/net/wireless/rt2x00/rt61pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt61pci.c
b/drivers/net/wireless/rt2x00/rt61pci.c
index c
commit 6aafeef03b9d9ecf
("netfilter: push reasm skb through instead of original frag skbs")
changed ipv6 defrag to not use the original skbs anymore.
So rather than keeping the original skbs around just to discard them
afterwards just use the original skbs directly for the fraglist of
the newly as
The previous patch changed nf_ct_frag6_gather() to morph reassembled skb
with the previous one.
This means that the return value is always NULL or the skb argument.
So change it to an err value.
Instead of invoking NF_HOOK recursively with threshold to skip already-called
hooks
we can now just r
[ CC netdev since patch #2 isn't nf-specific. Dave, if you want
I can resubmit that one after the next nf-pull request; let me know if
you would prefer that ].
Openvswitch seems broken wrt. to defragmentation, it doesn't call
nf_ct_frag6_consume_orig to free the original fragments.
Moreover,
The only user was removed in preceeding commit.
Signed-off-by: Florian Westphal
---
include/net/inet_frag.h | 1 -
net/ieee802154/6lowpan/reassembly.c | 1 -
net/ipv4/inet_fragment.c| 10 +-
net/ipv4/ip_fragment.c | 1 -
net/ipv6/reassembly.c
openvswitch attempts to morph the reassembled skb with the currently
processed one. But this looks broken -- the currently processed skb
is part of the reassembled skbs frag_list.
IOW, we morph an element of reasms frag_list into reasm itself, then
free said frag_list element.
This allows caller
Removed empty spaces before/after parenthesis
Signed-off-by: Paul McQuade
---
drivers/net/wireless/rt2x00/rt61pci.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt61pci.h
b/drivers/net/wireless/rt2x00/rt61pci.h
index 1442
On 10/17/2015 2:54 AM, Andrew Lunn wrote:
Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not
the bus' parent." broke finding PHY properties in the MAC device tree
You probably forgot to run checkpatch.pl on this patch, else it
would have complained about the commit citi
On 10/17/2015 2:54 AM, Andrew Lunn wrote:
Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not
the bus' parent." broke finding PHY properties in the MAC device tree
You probably forgot to run checkpatch.pl on this patch, else it
would have complained about the commit citi
2015-10-17 8:06 GMT-07:00 Dinh Nguyen :
> On Sat, 17 Oct 2015, Dinh Nguyen wrote:
>
>> On Fri, 16 Oct 2015, Andrew Lunn wrote:
>>
>> > On Fri, Oct 16, 2015 at 05:58:41PM -0500, Dinh Nguyen wrote:
>> > > On Fri, 16 Oct 2015, Andrew Lunn wrote:
>> > >
>> > > > Commit "8b63ec1837fa phylib: Make PHYs c
On Sat, 2015-10-17 at 05:02 -0700, David Miller wrote:
> Sorry I've been meaning to go back and apply it properly. I'll do that right
> now...
>
> There, done and properly queued up for -stable too. :)
>
Perfect, thanks a lot David.
--
To unsubscribe from this list: send the line "unsubscrib
> I've also tried creating a separate phy node in the DTS and have the EMAC
> point the PHY with a 'phy = <&phy0>;', but that also didn't seem to work with
> your patch.
Do you have the phy node as a child of the mdio node?
Picking a random example arch/arm/boot/dts/kirkwood-rd88f6192.dts
&mdio
On Sat, 17 Oct 2015, Dinh Nguyen wrote:
> On Fri, 16 Oct 2015, Andrew Lunn wrote:
>
> > On Fri, Oct 16, 2015 at 05:58:41PM -0500, Dinh Nguyen wrote:
> > > On Fri, 16 Oct 2015, Andrew Lunn wrote:
> > >
> > > > Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not
> > > > the bus'
On Fri, 16 Oct 2015, Andrew Lunn wrote:
> On Fri, Oct 16, 2015 at 05:58:41PM -0500, Dinh Nguyen wrote:
> > On Fri, 16 Oct 2015, Andrew Lunn wrote:
> >
> > > Commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not
> > > the bus' parent." broke finding PHY properties in the MAC devic
Hi David,
This is exactly the same pull request, including the conflict resolution for
net/bridge/br_netfilter_hooks.c.
-o-
The following patchset contains Netfilter/IPVS updates for your net-next
tree. Most relevantly, updates for the nfnetlink_log to integrate with
conntrack, fixes for cttimeo
On Sat, Oct 17, 2015 at 06:07:43AM -0700, David Miller wrote:
> From: Pablo Neira Ayuso
> Date: Sat, 17 Oct 2015 13:32:35 +0200
>
> > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git HEAD
>
> Pablo, this gives merge conflicts.
>
> This is the second or third time in the past fe
From: Pablo Neira Ayuso
Date: Sat, 17 Oct 2015 13:32:35 +0200
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git HEAD
Pablo, this gives merge conflicts.
This is the second or third time in the past few pulls from you that
there have been merge conflicts, even when I haven't mad
From: Jeff Kirsher
Date: Fri, 16 Oct 2015 22:28:15 -0700
>
> + WARN(!spin_is_locked(&vsi->mac_filter_list_lock),
> + "Missing mac_filter_list_lock\n");
> +
spin_is_locked() is, generally speaking, completely inappropriate to
use in assertions.
Because, on uniprocessor builds, it
On 10/17/2015 04:43 AM, Alexei Starovoitov wrote:
On 10/16/15 4:44 PM, Eric W. Biederman wrote:
Alexei Starovoitov writes:
We can argue about api for 2nd, whether it's mount with fd=1234 string
or else, but for the first mount style doesn't make sense.
Why does mount not make sense? It is
From: Eric Dumazet
Date: Fri, 16 Oct 2015 08:38:38 -0700
> On Tue, 2015-09-29 at 21:56 -0700, David Miller wrote:
>> From: Eric Dumazet
>> Date: Tue, 29 Sep 2015 18:52:25 -0700
>>
>> > From: Eric Dumazet
>> >
>> > Greg reported crashes hitting the following check in __sk_backlog_rcv()
>> >
>
On 10/16/2015 10:13 PM, Santosh Shilimkar wrote:
But because of above recursive lock hang with RDS TCP,
the send work from rds_send_pong() needs to deferred to
worker to avoid lock up. Given RDS ping is more of connectivity
test than performance critical path, its should be ok even
for transpor
From: "Eric W. Biederman"
I arranged the code so that the compiler can remove the unecessary bits
in ip_vs_leave when CONFIG_SYSCTL is unset, and removed an explicit
CONFIG_SYSCTL.
Unfortunately when rebasing my work on top of that of Alex Gartrell I
missed the fact that the newly added function
Hi David,
The following patchset contains Netfilter/IPVS updates for your net-next
tree. Most relevantly, updates for the nfnetlink_log to integrate with
conntrack, fixes for cttimeout and improvements for nf_queue core, they are:
1) Remove useless ifdef around static inline function in IPVS, fro
From: Simon Horman
If CONFIG_PROC_FS is undefined then the arguments of proc_create()
and remove_proc_entry() are unused. As a result the net variables of
ip_vs_conn_net_{init,cleanup} are unused.
net/netfilter/ipvs//ip_vs_conn.c: In function ‘ip_vs_conn_net_init’:
net/netfilter/ipvs//ip_vs_conn
The original intention was to avoid dependencies between nfnetlink_queue and
conntrack without ifdef pollution. However, we can achieve this by moving the
conntrack dependent code into ctnetlink and keep some glue code to access the
nfq_ct indirection from nfqueue.
After this patch, the nfq_ct ind
The __build_packet_message function fills a nfulnl_msg_packet_timestamp
structure that uses 64-bit seconds and is therefore y2038 safe, but
it uses an intermediate 'struct timespec' which is not.
This trivially changes the code to use 'struct timespec64' instead,
to correct the result on 32-bit ar
From: Flavio Leitner
Remove __nf_conntrack_find() from headers.
Fixes: dcd93ed4cd1 ("netfilter: nf_conntrack: remove dead code")
Signed-off-by: Flavio Leitner
Signed-off-by: Pablo Neira Ayuso
---
include/net/netfilter/nf_conntrack.h | 4
1 file changed, 4 deletions(-)
diff --git a/inclu
From: Ian Morris
Use tabs instead of spaces to indent second line of parameters in
function definitions.
No changes detected by objdiff.
Signed-off-by: Ian Morris
Signed-off-by: Pablo Neira Ayuso
---
net/ipv6/netfilter/ip6_tables.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From: Ken-ichirou MATSUZAWA
This patch enables to include the conntrack information together
with the packet that is sent to user-space via NFLOG, then a
user-space program can acquire NATed information by this NFULA_CT
attribute.
Including the conntrack information is optional, you can set it
v
From: Florian Westphal
All verdict handlers make use of the nfnetlink .call_rcu callback
so rcu readlock is already held.
Signed-off-by: Florian Westphal
Signed-off-by: Pablo Neira Ayuso
---
net/netfilter/nf_queue.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff
From: Ian Morris
Correct whitespace layout of if statements.
No changes detected by objdiff.
Signed-off-by: Ian Morris
Signed-off-by: Pablo Neira Ayuso
---
net/ipv6/netfilter/ip6_tables.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/ipv6/netfilter/ip6_tables.
From: Ken-ichirou MATSUZAWA
get_ct as is and will not update its skb argument, and users of
nfnl_ct_hook is currently only nfqueue, we can add const qualifier.
Signed-off-by: Ken-ichirou MATSUZAWA
---
include/linux/netfilter.h| 2 +-
net/netfilter/nf_conntrack_netlink.c | 2 +-
2 f
From: Ken-ichirou MATSUZAWA
Conntrack information attaching infrastructure is now generic and
update it's name to use `glue' in previous patch. This patch updates
Kconfig symbol name and adding NF_CT_NETLINK dependency.
Signed-off-by: Ken-ichirou MATSUZAWA
Signed-off-by: Pablo Neira Ayuso
---
From: Ken-ichirou MATSUZAWA
This patch enables to load nf_conntrack_netlink module if
NFULNL_CFG_F_CONNTRACK config flag is specified.
Signed-off-by: Ken-ichirou MATSUZAWA
Signed-off-by: Pablo Neira Ayuso
---
net/netfilter/nfnetlink_log.c | 11 ++-
1 file changed, 10 insertions(+), 1
From: Pablo Neira
Check that dependencies are fulfilled before updating the logger
instance, otherwise we can leave things in intermediate state on errors
in nfulnl_recv_config().
[ Ken-ichirou reports that this is also fixing missing instance refcnt drop
on error introduced in his patch 914ee
From: Ken-ichirou MATSUZAWA
The idea of this series of patch is to attach conntrack information to
nflog like nfqueue has already done. nfqueue conntrack info attaching
basis is generic, rename those names to generic one, glue.
Signed-off-by: Ken-ichirou MATSUZAWA
Signed-off-by: Pablo Neira Ayu
The object and module refcounts are updated for each conntrack template,
however, if we delete the iptables rules and we flush the timeout
database, we may end up with invalid references to timeout object that
are just gone.
Resolve this problem by setting the timeout reference to NULL when the
cu
From: Arnd Bergmann
With the ARM mini2440_defconfig, the bridge netfilter code gets
built with both CONFIG_NF_DEFRAG_IPV4 and CONFIG_NF_DEFRAG_IPV6
disabled, which leads to a harmless gcc warning:
net/bridge/br_netfilter_hooks.c: In function 'br_nf_dev_queue_xmit':
net/bridge/br_netfilter_hooks.
From: Ian Morris
Correct whitespace layout of ternary operators in the netfilter-ipv4
code.
No changes detected by objdiff.
Signed-off-by: Ian Morris
Signed-off-by: Pablo Neira Ayuso
---
net/ipv4/netfilter/arp_tables.c | 4 ++--
net/ipv4/netfilter/ip_tables.c | 6 +++---
2 files changed, 5
From: Florian Westphal
Usage of -prev seems buggy. While packet was out our hook cannot be
removed but we have no way to know if the previous one is still valid.
So better not use ->prev at all. Since NF_REPEAT just asks to invoke
same hook function again, just do so, and continue with nf_inte
This patch consolidates the check for valid logger instance once we have
passed the command handling:
The config message that we receive may contain the following info:
1) Command only: We always get a valid instance pointer if we just
created it. In case that the instance is being destroyed o
Make sure kfree_rcu() released objects before leaving the module removal
exit path.
Signed-off-by: Pablo Neira Ayuso
---
net/netfilter/nfnetlink_cttimeout.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/netfilter/nfnetlink_cttimeout.c
b/net/netfilter/nfnetlink_cttimeout.c
index 5bda64
From: Ian Morris
Correct whitespace layout of a pointer casting.
No changes detected by objdiff.
Signed-off-by: Ian Morris
Signed-off-by: Pablo Neira Ayuso
---
net/ipv6/netfilter/nf_conntrack_reasm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/netfilter/nf_co
On success, this shouldn't put back the timeout policy object, otherwise
we may have module refcount overflow and we allow deletion of timeout
that are still in use.
Signed-off-by: Pablo Neira Ayuso
---
net/netfilter/xt_CT.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/netfilter/xt
From: David Ahern
Eric's net namespace changes in 1b75097dd7a26 leaves net unreferenced if
CONFIG_IP_VS_IPV6 is not enabled:
../net/netfilter/ipvs/ip_vs_core.c: In function ‘ip_vs_out’:
../net/netfilter/ipvs/ip_vs_core.c:1177:14: warning: unused variable ‘net’
[-Wunused-variable]
After the net
From: Ian Morris
Correct whitespace layout of ternary operators in the netfilter-ipv6
code.
No changes detected by objdiff.
Signed-off-by: Ian Morris
Signed-off-by: Pablo Neira Ayuso
---
net/ipv6/netfilter/ip6_tables.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/n
From: Ian Morris
This patch cleanses whitespace around arithmetical operators.
No changes detected by objdiff.
Signed-off-by: Ian Morris
Signed-off-by: Pablo Neira Ayuso
---
net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c | 4 ++--
net/ipv6/netfilter/nf_conntrack_reasm.c| 2 +-
net/ip
Now that we have integrated the ct glue code into nfnetlink_queue without
introducing dependencies with the conntrack code.
Signed-off-by: Pablo Neira Ayuso
---
net/netfilter/Makefile | 1 -
net/netfilter/{nfnetlink_queue_core.c => nfnetlink_queue.c} | 0
2 f
From: Ian Morris
Use tabs instead of spaces to indent code.
No changes detected by objdiff.
Signed-off-by: Ian Morris
Signed-off-by: Pablo Neira Ayuso
---
net/ipv4/netfilter/ip_tables.c| 6 +++---
net/ipv4/netfilter/ipt_SYNPROXY.c | 2 +-
net/ipv4/netfilter/iptable_security.c | 2
From: Ian Morris
Use tabs instead of spaces to indent second line of parameters in
function definitions.
No changes detected by objdiff.
Signed-off-by: Ian Morris
Signed-off-by: Pablo Neira Ayuso
---
net/ipv4/netfilter/arp_tables.c | 6 +++---
net/ipv4/netfilter/ip_tables.c | 6 +++---
2 fi
From: Florian Westphal
since commit 8405a8fff3f8 ("netfilter: nf_qeueue: Drop queue entries on
nf_unregister_hook") all pending queued entries are discarded.
So we can simply remove all of the owner handling -- when module is
removed it also needs to unregister all its hooks.
Signed-off-by: Flo
From: Ian Morris
Whitespace cleansing: Labels should not be indented.
No changes detected by objdiff.
Signed-off-by: Ian Morris
Signed-off-by: Pablo Neira Ayuso
---
net/ipv4/netfilter/arp_tables.c | 2 +-
net/ipv4/netfilter/ip_tables.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-
From: Florian Westphal
We don't care if module is being unloaded anymore since hook unregister
handling will destroy queue entries using that hook.
Signed-off-by: Florian Westphal
Signed-off-by: Pablo Neira Ayuso
---
include/net/netfilter/nf_queue.h | 2 +-
net/netfilter/core.c |
From: Ian Morris
This patch cleanses whitespace around arithmetical operators.
No changes detected by objdiff.
Signed-off-by: Ian Morris
Signed-off-by: Pablo Neira Ayuso
---
net/ipv4/netfilter/ipt_CLUSTERIP.c | 8
net/ipv4/netfilter/ipt_ah.c| 2 +-
net/ipv4/netfilter
From: Ian Morris
Use tabs instead of spaces to indent code.
No changes detected by objdiff.
Signed-off-by: Ian Morris
Signed-off-by: Pablo Neira Ayuso
---
net/ipv6/netfilter/ip6_tables.c | 4 ++--
net/ipv6/netfilter/ip6t_SYNPROXY.c| 2 +-
net/ipv6/netfilter/nft_chain_route_
From: Ian Morris
Whitespace cleansing: Labels should not be indented.
No changes detected by objdiff.
Signed-off-by: Ian Morris
Signed-off-by: Pablo Neira Ayuso
---
net/ipv6/netfilter/ip6_tables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/netfilter/ip6_tabl
From: Arnd Bergmann
A recent change to the dst_output handling caused a new warning
when the call to NF_HOOK() is the only used of a local variable
passed as 'dev', and CONFIG_NETFILTER is disabled:
net/ipv6/ip6_output.c: In function 'ip6_output':
net/ipv6/ip6_output.c:135:21: warning: unused va
On Fri, Oct 16, 2015 at 01:58:55PM +0200, Jozsef Kadlecsik wrote:
> The patch is applied in the ipset package tree. Thanks!
Applied to the nf tree, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info
The exit label performs device_unlock(&dev->dev);, which will fail when dev
is NULL, and nfc_put_device(dev);, which is not useful when dev is NULL, so
just exit the function immediately.
Problem found using scripts/coccinelle/null/deref_null.cocci
Signed-off-by: Julia Lawall
---
net/nfc/netli
These patches delete NULL dereferences, as detected by
scripts/coccinelle/null/deref_null.cocci.
---
drivers/media/pci/netup_unidvb/netup_unidvb_spi.c |6 ++
net/nfc/netlink.c |6 ++
2 files changed, 4 insertions(+), 8 deletions(-)
--
To unsubscrib
On 10/16/15 at 11:08am, Joe Stringer wrote:
> If OVS receives a packet from another namespace, then the packet should
> be scrubbed. However, people have already begun to rely on the behaviour
> that skb->mark is preserved across namespaces, so retain this one field.
>
> This is mainly to address
On 10/16/15 at 11:08am, Joe Stringer wrote:
> If userspace provides a ct action with no nested mark or label, then the
> storage for these fields is zeroed. Later when actions are requested,
> such zeroed fields are serialized even though userspace didn't
> originally specify them. Fix the behaviou
On 10/16/15 at 11:08am, Joe Stringer wrote:
> New, related connections are marked as such as part of ovs_ct_lookup(),
> but they are not marked as "new" if the commit flag is used. Make this
> consistent by treating IP_CT_RELATED as new as well.
>
> Reported-by: Jarno Rajahalme
> Signed-off-by: J
On 10/16/15 at 04:36pm, Jesse Gross wrote:
> Before lightweight tunnels existed, it really didn't make sense to
> create a tunnel that was not fully specified, such as without a
> destination IP address - the resulting packets would go nowhere.
> However, with lightweight tunnels, the opposite is t
On 10/16/15 at 11:08am, Joe Stringer wrote:
> Currently, 0-bits are generated in ct_state where the bit position is
> undefined, and matches are accepted on these bit-positions. If userspace
> requests to match the 0-value for this bit then it may expect only a
> subset of traffic to match this val
88 matches
Mail list logo
