Re: [patch net-next v4 6/7] rocker: remove nowait from switchdev callbacks.

2015-10-12 Thread Scott Feldman
On Mon, Oct 12, 2015 at 11:25 PM, Jiri Pirko wrote: > Tue, Oct 13, 2015 at 06:02:28AM CEST, sfel...@gmail.com wrote: >>On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> No need to avoid sleeping in switchdev callbacks now, as the switchdev >>> core allows it. >>> >

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

2015-10-12 Thread Scott Feldman
On Mon, Oct 12, 2015 at 11:21 PM, Jiri Pirko wrote: > Tue, Oct 13, 2015 at 08:03:46AM CEST, john.fastab...@gmail.com wrote: >>On 15-10-12 10:44 PM, Jiri Pirko wrote: >>> Tue, Oct 13, 2015 at 04:52:42AM CEST, sfel...@gmail.com wrote: On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: > F

Re: [PATCH net-next V15 0/3] openvswitch: Add support for 802.1ad

2015-10-12 Thread Pravin Shelar
On Mon, Oct 12, 2015 at 7:58 PM, David Miller wrote: > From: Thomas F Herbert > Date: Sat, 10 Oct 2015 19:40:30 -0400 > >> Thomas F Herbert (3): >> openvswitch: 802.1ad uapi changes. >> Check for vlan ethernet types for 8021.q or 802.1ad >> 802.1AD: Flow handling, actions, vlan parsing and

Some ICMP-Reply messages don't arrive in User Space in recent Kernels

2015-10-12 Thread Jörg Pommnitz
Hello all, I'm moving an application from 2.6.23 (yes, it's ancient; that's why we are moving) to 3.18LTS. The application monitors multiple network links to the same target with ping packets. The different links are selected either by their next hop router (Ethernet) or the network interface (Poin

Re: [PATCH net-next V15 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-12 Thread Pravin Shelar
On Sat, Oct 10, 2015 at 4:40 PM, Thomas F Herbert wrote: > Add support for 802.1ad including the ability to push and pop double > tagged vlans. Add support for 802.1ad to netlink parsing and flow > conversion. Uses double nested encap attributes to represent double > tagged vlan. Inner TPID encode

Re: [patch net-next v4 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn

2015-10-12 Thread Scott Feldman
On Mon, Oct 12, 2015 at 11:05 PM, Jiri Pirko wrote: > Tue, Oct 13, 2015 at 05:28:20AM CEST, sfel...@gmail.com wrote: >>On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Since spinlock is held here, defer the switchdev operation. >>> >>> Signed-off-by: Jiri Pirko >

Re: [PATCH net-next 4/4] bridge: vlan: combine (br|nbp)_vlan_flush into one

2015-10-12 Thread Scott Feldman
On Mon, Oct 12, 2015 at 10:51 AM, Ido Schimmel wrote: > Mon, Oct 12, 2015 at 02:41:09PM IDT, ra...@blackwall.org wrote: >>From: Nikolay Aleksandrov >> >>As Ido Schimmel pointed out the vlan_vid_del() loop in nbp_vlan_flush is >>unnecessary (and is actually a remnant of the old vlan code) so we ca

Re: e1000_driver_checkpatch_remove_errors_warnings_checks

2015-10-12 Thread Jeff Kirsher
On Sun, 2015-10-11 at 21:11 +0200, Janusz Wolak wrote: > From daf0a1f5100c21f10b9e08829433258267748c44 Mon Sep 17 00:00:00 > 2001 > From: Janusz Wolak > Date: Tue, 6 Oct 2015 21:03:19 +0200 > Subject: [PATCH 1/6] Remove checkpatch warnings and checks. > > Signed-off-by: Janusz Wolak > --- > d

Re: [patch net-next v4 6/7] rocker: remove nowait from switchdev callbacks.

2015-10-12 Thread Jiri Pirko
Tue, Oct 13, 2015 at 06:02:28AM CEST, sfel...@gmail.com wrote: >On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> No need to avoid sleeping in switchdev callbacks now, as the switchdev >> core allows it. >> >> Signed-off-by: Jiri Pirko >> --- >> drivers/net/ethernet/

Re: [PATCH net-next] bridge: fix gc_timer mod/del race condition

2015-10-12 Thread Scott Feldman
On Mon, Oct 12, 2015 at 8:55 AM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > commit c62987bbd8a1 ("bridge: push bridge setting ageing_time down to > switchdev") introduced a timer race condition because the gc_timer can > get rearmed after it's supposedly stopped and flushed in br_

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

2015-10-12 Thread Jiri Pirko
Tue, Oct 13, 2015 at 08:03:46AM CEST, john.fastab...@gmail.com wrote: >On 15-10-12 10:44 PM, Jiri Pirko wrote: >> Tue, Oct 13, 2015 at 04:52:42AM CEST, sfel...@gmail.com wrote: >>> On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: From: Jiri Pirko Caller should know if he can cal

Re: [PATCH] i40evf: fix 32 bit build warnings

2015-10-12 Thread Jeff Kirsher
On Wed, 2015-10-07 at 22:13 +0200, Arnd Bergmann wrote: > Jesse Brandeburg fixed a bug for 32-bit systems in the i40e driver > in commit 9c70d7cebfec5 ("i40e: fix 32 bit build warnings"), but the > same code still exists in the i40evf driver and causes compilation > warnings in ARM and x86 allmodco

Re: [PATCH net-next] switchdev: enforce no pvid flag in vlan ranges

2015-10-12 Thread Scott Feldman
On Mon, Oct 12, 2015 at 10:36 AM, Vivien Didelot wrote: > Hi guys, > > On Oct. Monday 12 (42) 02:01 PM, Nikolay Aleksandrov wrote: >> From: Nikolay Aleksandrov >> >> We shouldn't allow BRIDGE_VLAN_INFO_PVID flag in VLAN ranges. >> >> Signed-off-by: Nikolay Aleksandrov >> --- >> net/switchdev/sw

Re: [PATCH v3] igb: improve handling of disconnected adapters

2015-10-12 Thread Jeff Kirsher
On Wed, 2015-10-07 at 09:21 -0400, Jarod Wilson wrote: > Some pci changes upcoming in 4.3 seem to cause additional > disconnects, > which can happen at unfortuitous times for igb, leading to issues > such as > this: > > [ 414.440115] igb :15:00.0: enabling device ( -> 0002) > [ 414.47493

Re: [patch net-next v4 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn

2015-10-12 Thread Jiri Pirko
Tue, Oct 13, 2015 at 05:28:20AM CEST, sfel...@gmail.com wrote: >On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Since spinlock is held here, defer the switchdev operation. >> >> Signed-off-by: Jiri Pirko >> --- >> net/bridge/br_fdb.c | 5 - >> net/bridge/br_if.

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

2015-10-12 Thread John Fastabend
On 15-10-12 10:44 PM, Jiri Pirko wrote: > Tue, Oct 13, 2015 at 04:52:42AM CEST, sfel...@gmail.com wrote: >> On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Caller should know if he can call attr_set directly (when holding RTNL) >>> or if he has to defer the att_se

[net-next 06/17] i40e: Convert CEE App TLV selector to IEEE selector

2015-10-12 Thread Jeff Kirsher
From: Greg Bowers Changes the parsing of CEE App TLVs to fill in the App selector in struct i40e_dcbx_config with the IEEE App selector so the caller doesn't have to consider whether the App came from a CEE or IEEE DCBX negotiation. Change-ID: Ia7d9d664cde04d2ebcc9822fd22e4929c6edab3a Signed-off

[net-next 12/17] i40e/i40evf: Add module_types and update_link_info

2015-10-12 Thread Jeff Kirsher
From: Catherine Sullivan Add a module_types variable to the link_info struct to save the module information from get_phy_capabilities. This information can be used to determine which speeds the module supports. Also add a new function update_link_info which updates the module_types parameter and

[net-next 09/17] i40e: update fw version text string per previous product formats

2015-10-12 Thread Jeff Kirsher
From: Carolyn Wyborny This patch moves the internal fw version and fw api version info to be output in probe. The nvm version, etrack and oem version info are now configured for output via ethtool -i. Change-ID: I05d490093a7137dbefcdef263d014d1e5c9e83d0 Signed-off-by: Carolyn Wyborny Tested-by

[net-next 05/17] i40e/i40evf: Add info to nvm info struct for OEM version data

2015-10-12 Thread Jeff Kirsher
From: Carolyn Wyborny This patch adds a member to the nvm_info struct for oem_ver info to be output either by OID or ethtool. Change-ID: I1e5d513ae67622e2af17042924fdb4b5d6d85366 Signed-off-by: Carolyn Wyborny Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/inte

[net-next 03/17] i40e: Use BIT() macro for priority map parsing

2015-10-12 Thread Jeff Kirsher
From: Neerav Parikh Replace one left over (1 << up) in the i40e_dcb.c file with the BIT() macro. Change-ID: I39492a400a2cee5ac566143a5b436cc478bea0db Signed-off-by: Neerav Parikh Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_dcb.c | 2 +- 1 fil

[net-next 15/17] ixgbe: add flow control ethertype to the anti-spoofing filter

2015-10-12 Thread Jeff Kirsher
From: Emil Tantilov This patch makes sure that flow control packets initiated by the VF are dropped and reported as spoofed. Flow control packets can be used to limit the throughput or as DOS attack when generated from a VF. Flow control is not supported per VF hence any pause frames generated f

[net-next 02/17] i40e: Make it clear a parameter is never used

2015-10-12 Thread Jeff Kirsher
From: Carolyn Wyborny Flag the filter_mask parameter as __always_unused in the ndo_bridge_getlink function. Change-ID: Ifc1e99c7fb84bcbf81cf7b0ac891ad8ca956ffb2 Signed-off-by: Carolyn Wyborny Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c

[net-next 11/17] i40e: Add promiscuous on VLAN support

2015-10-12 Thread Jeff Kirsher
From: Greg Rose NFV use cases require the ability to steer packets to VSIs by VLAN tag alone while being in promiscuous mode for multicast and unicast MAC addresses. These two new functions support that ability. Change-ID: Ifef704b07e0ee8a39d3c351dbd5dc83bb2f63c45 Signed-off-by: Greg Rose Test

[net-next 00/17][pull request] Intel Wired LAN Driver Updates 2015-10-12

2015-10-12 Thread Jeff Kirsher
This series contains updates to i40e, i40evf, ixgbe and fm10k. Carolyn cleans up ndo_bridge_getlink() by flagging a parameter as __always_unused, since it is never used. Adds a member to the nvm_info struct to store OEM version info to be output either by OID or ethtool. Neerav cleans up a remai

[net-next 10/17] i40e/i40evf: split device ids into a separate file

2015-10-12 Thread Jeff Kirsher
From: Shannon Nelson Due to desires to write userland drivers, and other requests, without needing the rest of the include files, the device ids are pulled out into a standalone file. Change-ID: Ic0b047dbf9d4b0891892309c1f2079f56d9b60e8 Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Si

[net-next 17/17] fm10k: do not use enum as boolean

2015-10-12 Thread Jeff Kirsher
From: Jacob Keller Check for actual value NETREG_UNINITIALIZED in case it ever changes from the current value of zero. Signed-off-by: Jacob Keller Signed-off-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +- 1 fi

[net-next 01/17] i40e/i40evf: Add new link status defines

2015-10-12 Thread Jeff Kirsher
From: Shannon Nelson Add the new Port link status bit and rename the link status to function link status. Change-ID: I71289327ae62638ce967b6ad40114caf998b6dab Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_adminq_cm

[net-next 14/17] i40e/i40evf: Bump i40e version to 1.3.25 and i40evf to 1.3.17

2015-10-12 Thread Jeff Kirsher
From: Catherine Sullivan Bump. Change-ID: If3cd42f6c1b9546beed60faf9c79faab35216f58 Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 2 fil

[net-next 08/17] i40e: don't panic on VSI allocation failure

2015-10-12 Thread Jeff Kirsher
From: Mitch Williams In some circumstances, the firmware may fail to allocate a VSI for a VF. When this happens, the driver does not react well to the bad news and has a panic attack. To fix this problem, check the return value from i40e_alloc_vf_res and don't try to configure the device further

[net-next 04/17] i40evf: properly handle ndo_set_mac_address calls

2015-10-12 Thread Jeff Kirsher
From: Mitch Williams The driver was not correctly handling calls to its ndo_set_mac_address method. It did not properly check to see if the override would be allowed by the PF driver, and never removed the old address from its filter list. Add a new flag to the adapter struct which is set if the

[net-next 16/17] fm10k: use snprintf() instead of sprintf() to avoid buffer overflow

2015-10-12 Thread Jeff Kirsher
From: Jacob Keller Signed-off-by: Jacob Keller Signed-off-by: Bruce Allan Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c | 6 +++--- drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 8 2 files changed, 7 insertions(+), 7

[net-next 13/17] i40e/i40evf: Refactor PHY structure and add phy_capabilities enum

2015-10-12 Thread Jeff Kirsher
From: Catherine Sullivan Remove unused members in the PHY structure and add a new member to store all the capabilities the PHY has as reported by the FW. This information will help us determine what speeds the device is capable of when link is down. Also add an enum to decode the PHY types the N

[net-next 07/17] i40e: remove redundant call

2015-10-12 Thread Jeff Kirsher
From: Mitch Williams This function call isn't needed here; the same function is already called by i40e_reset_vf. Change-ID: I96ccbf91b752965c9e28fe895d4c7d4c46e3ba44 Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_vi

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

2015-10-12 Thread John Fastabend
On 15-10-12 10:45 PM, Jiri Pirko wrote: > Tue, Oct 13, 2015 at 06:40:25AM CEST, john.fastab...@gmail.com wrote: >> On 15-10-12 07:52 PM, Scott Feldman wrote: >>> On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: From: Jiri Pirko Caller should know if he can call attr_set directly

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

2015-10-12 Thread Jiri Pirko
Tue, Oct 13, 2015 at 06:40:25AM CEST, john.fastab...@gmail.com wrote: >On 15-10-12 07:52 PM, Scott Feldman wrote: >> On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Caller should know if he can call attr_set directly (when holding RTNL) >>> or if he has to defer t

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

2015-10-12 Thread Jiri Pirko
Tue, Oct 13, 2015 at 04:52:42AM CEST, sfel...@gmail.com wrote: >On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Caller should know if he can call attr_set directly (when holding RTNL) >> or if he has to defer the att_set processing for later. >> >> This also allows d

Re: [PATCH net] switchdev: check if the vlan id is in the proper vlan range

2015-10-12 Thread Scott Feldman
On Mon, Oct 12, 2015 at 5:31 AM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > VLANs 0 and 4095 are reserved and shouldn't be used, add checks to > switchdev similar to the bridge. Also make sure ids above 4095 cannot > be passed either. > > Fixes: 47f8328bb1a4 ("switchdev: add new s

Re: [PATCH net-next v3 3/4] bridge: push bridge setting ageing_time down to switchdev

2015-10-12 Thread Scott Feldman
On Sat, Oct 10, 2015 at 8:56 AM, Vivien Didelot wrote: > Scott, didn't you have a plan to add a struct device for the parent of > switchdev ports? I had sent out a rough RFC for a switch device in the last window. I have continued working on it, and I plan to send it very soon, probably again a

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-12 Thread Richard Cochran
On Mon, Oct 12, 2015 at 11:45:19AM -0700, Christopher S. Hall wrote: > +int get_correlated_timestamp(struct correlated_ts *crt, > + struct correlated_cs *crs) > +{ > + struct timekeeper *tk = &tk_core.timekeeper; > + unsigned long seq; > + cycles_t cycles, cycle

Re: [patch net-next v4 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn

2015-10-12 Thread John Fastabend
On 15-10-12 09:19 PM, Scott Feldman wrote: > On Mon, Oct 12, 2015 at 8:31 PM, John Fastabend > wrote: >> On 15-10-12 08:28 PM, Scott Feldman wrote: >>> On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: From: Jiri Pirko Since spinlock is held here, defer the switchdev operation.

Re: Issue with /proc/sys/net/ipv4/tcp_mem

2015-10-12 Thread Eric W. Biederman
Eric Dumazet writes: > On Mon, 2015-10-12 at 11:37 -0500, Eric W. Biederman wrote: >> wangyufen writes: >> >> > Hi, >> > >> > I tried on linux-4.1: >> > linux:~# cat /proc/sys/net/ipv4/tcp_mem >> > 83886081258291216777216 >> > linux:~# echo 1234 >/proc/sys/net/ipv4/

Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

2015-10-12 Thread Alexei Starovoitov
On 10/12/15 9:34 PM, Wangnan (F) wrote: On 2015/10/13 12:16, Alexei Starovoitov wrote: On 10/12/15 8:51 PM, Wangnan (F) wrote: why 'set disable' is needed ? the example given in cover letter shows the use case where you want to receive samples only within sys_write() syscall. The example make

[PATCH] net: phy: smsc: disable energy detect mode

2015-10-12 Thread Heiko Schocher
On some boards the energy enable detect mode leads in trouble with some switches, so make the enabling of this mode configurable through DT. Signed-off-by: Heiko Schocher --- .../devicetree/bindings/net/smsc-lan87xx.txt | 19 + drivers/net/phy/smsc.c

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-12 Thread Richard Cochran
On Mon, Oct 12, 2015 at 11:45:19AM -0700, Christopher S. Hall wrote: > Another representative use case of time sync and the correlated > clocksource (in addition to PTP noted above) is PTP synchronized > audio. The added explanations of the audio use case do help. However, you did not address my

Re: [patch net-next v4 3/7] switchdev: remove pointers from switchdev objects

2015-10-12 Thread John Fastabend
On 15-10-12 08:01 PM, Scott Feldman wrote: > On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> When object is used in deferred work, we cannot use pointers in >> switchdev object structures because the memory they point at may be already >> used by someone else. So rat

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

2015-10-12 Thread John Fastabend
On 15-10-12 07:52 PM, Scott Feldman wrote: > On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Caller should know if he can call attr_set directly (when holding RTNL) >> or if he has to defer the att_set processing for later. >> >> This also allows drivers to sleep ins

Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

2015-10-12 Thread Wangnan (F)
On 2015/10/13 12:16, Alexei Starovoitov wrote: On 10/12/15 8:51 PM, Wangnan (F) wrote: why 'set disable' is needed ? the example given in cover letter shows the use case where you want to receive samples only within sys_write() syscall. The example makes sense, but sys_write() is running on th

Re: [patch net-next v4 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn

2015-10-12 Thread Scott Feldman
On Mon, Oct 12, 2015 at 8:31 PM, John Fastabend wrote: > On 15-10-12 08:28 PM, Scott Feldman wrote: >> On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Since spinlock is held here, defer the switchdev operation. >>> >>> Signed-off-by: Jiri Pirko >>> --- >>> net/

Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

2015-10-12 Thread Alexei Starovoitov
On 10/12/15 8:51 PM, Wangnan (F) wrote: why 'set disable' is needed ? the example given in cover letter shows the use case where you want to receive samples only within sys_write() syscall. The example makes sense, but sys_write() is running on this cpu, so just disabling it on the current one is

RE: [PATCH net-next v5 01/10] qed: Add module with basic common support

2015-10-12 Thread Yuval Mintz
> 500 ko of a basic something is mildly reviewable for mere mortals. Undertood, obviously. Thanks for the time you've put into this. > [...] > > +/* forward */ > > +struct qed_ptt_pool; > > +struct qed_spq; > > +struct qed_sb_info; > > +struct qed_sb_attn_info; > > +struct qed_cxt_mngr; > > +struc

Re: [patch net-next v4 6/7] rocker: remove nowait from switchdev callbacks.

2015-10-12 Thread Scott Feldman
On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > No need to avoid sleeping in switchdev callbacks now, as the switchdev > core allows it. > > Signed-off-by: Jiri Pirko > --- > drivers/net/ethernet/rocker/rocker.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deleti

Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

2015-10-12 Thread Wangnan (F)
On 2015/10/13 11:39, Alexei Starovoitov wrote: On 10/12/15 8:27 PM, Wangnan (F) wrote: Then how to avoid racing? For example, when one core disabling all events in a map, another core is enabling all of them. This racing may causes sereval perf events in a map dump samples while other events

RE: [PATCH] qlcnic: constify qlcnic_mbx_ops structure

2015-10-12 Thread Sony Chacko
> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Julia Lawall > Sent: Sunday, October 11, 2015 4:48 AM > To: Dept-GE Linux NIC Dev > Cc: kernel-janit...@vger.kernel.org; netdev ; linux- > kernel > Subject: [PATCH] qlcnic: constify qlcnic_mbx_o

Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

2015-10-12 Thread Alexei Starovoitov
On 10/12/15 8:27 PM, Wangnan (F) wrote: Then how to avoid racing? For example, when one core disabling all events in a map, another core is enabling all of them. This racing may causes sereval perf events in a map dump samples while other events not. To avoid such racing I think some locking must

Re: [patch net-next v4 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn

2015-10-12 Thread John Fastabend
On 15-10-12 08:28 PM, Scott Feldman wrote: > On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Since spinlock is held here, defer the switchdev operation. >> >> Signed-off-by: Jiri Pirko >> --- >> net/bridge/br_fdb.c | 5 - >> net/bridge/br_if.c | 3 +++ >> 2 fi

Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers

2015-10-12 Thread Wangnan (F)
On 2015/10/13 3:29, Alexei Starovoitov wrote: On 10/12/15 2:02 AM, Kaixu Xia wrote: +extern const struct bpf_func_proto bpf_perf_event_sample_enable_proto; +extern const struct bpf_func_proto bpf_perf_event_sample_disable_proto; externs are unnecessary. Just make them static. Also I prefer s

Re: [patch net-next v4 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn

2015-10-12 Thread Scott Feldman
On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Since spinlock is held here, defer the switchdev operation. > > Signed-off-by: Jiri Pirko > --- > net/bridge/br_fdb.c | 5 - > net/bridge/br_if.c | 3 +++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff -

Re: [RFC PATCH 1/2] perf: Add the flag sample_disable not to output data on samples

2015-10-12 Thread Alexei Starovoitov
On 10/12/15 7:30 PM, xiakaixu wrote: The proper perf_event_enable/disable are so heavy that another >mechanism needed? cpu_function_call is probably too much to do >from bpf program, but that can be simplified? >Based on the use case from cover letter, sounds like you want >something like soft_di

Re: [patch net-next v4 4/7] switchdev: introduce possibility to defer obj_add/del

2015-10-12 Thread Scott Feldman
On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Similar to the attr usecase, the caller knows if he is holding RTNL and is > in atomic section. So let the called to decide the correct call variant. > > This allows drivers to sleep inside their ops and wait for hw to get

Re: [patch net-next v4 3/7] switchdev: remove pointers from switchdev objects

2015-10-12 Thread Scott Feldman
On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > When object is used in deferred work, we cannot use pointers in > switchdev object structures because the memory they point at may be already > used by someone else. So rather do local copy of the value. > > Signed-off-by:

Re: [patch net-next v4 1/7] switchdev: introduce switchdev workqueue

2015-10-12 Thread Scott Feldman
On Mon, Oct 12, 2015 at 10:54 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This is going to be used for deferred operations. > > Signed-off-by: Jiri Pirko Acked-by: Scott Feldman -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.ker

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

2015-10-12 Thread Scott Feldman
On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Caller should know if he can call attr_set directly (when holding RTNL) > or if he has to defer the att_set processing for later. > > This also allows drivers to sleep inside attr_set and report operation > status back to

Re: [PATCH net-next] bridge: vlan: enforce no pvid flag in vlan ranges

2015-10-12 Thread David Miller
From: Nikolay Aleksandrov Date: Sun, 11 Oct 2015 12:49:56 +0200 > From: Nikolay Aleksandrov > > Currently it's possible for someone to send a vlan range to the kernel > with the pvid flag set which will result in the pvid bouncing from a > vlan to vlan and isn't correct, it also introduces prob

Re: [PATCH net-next V15 0/3] openvswitch: Add support for 802.1ad

2015-10-12 Thread David Miller
From: Thomas F Herbert Date: Sat, 10 Oct 2015 19:40:30 -0400 > Thomas F Herbert (3): > openvswitch: 802.1ad uapi changes. > Check for vlan ethernet types for 8021.q or 802.1ad > 802.1AD: Flow handling, actions, vlan parsing and netlink attributes I think this patch series has gone long eno

Re: [PATCH 1/2] atm: iphase: return -ENOMEM instead of -1 in case of failed kmalloc()

2015-10-12 Thread David Miller
From: Tillmann Heidsieck Date: Sat, 10 Oct 2015 21:47:18 +0200 > Smatch complains about returning hard coded error codes, silence this > warning. > > drivers/atm/iphase.c:115 ia_enque_rtn_q() warn: returning -1 instead of > -ENOMEM is sloppy > > Signed-off-by: Tillmann Heidsieck Applied to n

Re: [PATCH 2/2] atm: iphase: fix misleading indention

2015-10-12 Thread David Miller
From: Tillmann Heidsieck Date: Sat, 10 Oct 2015 21:47:19 +0200 > Fix a smatch warning: > drivers/atm/iphase.c:1178 rx_pkt() warn: curly braces intended? > > The code is correct, the indention is misleading. In case the allocation > of skb fails, we want to skip to the end. > > Signed-off-by: Ti

Re: [PATCH net-next v2] ipv6 route: use err pointers instead of returning pointer by reference

2015-10-12 Thread David Miller
From: Roopa Prabhu Date: Sat, 10 Oct 2015 08:26:36 -0700 > From: Roopa Prabhu > > This patch makes ip6_route_info_create return err pointer instead of > returning the rt pointer by reference as suggested by Dave > > Signed-off-by: Roopa Prabhu > --- > v1 - v2: remove unnecessary NULL initial

Re: [PATCH net-next] net: hns: fix the unknown phy_nterface_t type error

2015-10-12 Thread David Miller
From: huangdaode Date: Sat, 10 Oct 2015 17:20:38 +0800 > This patch fix the building error reported by Jiri Pirko > > drivers/net/ethernet/hisilicon/hns/hnae.h:465:2: error: unknown type > name 'phy_interface_t' > phy_interface_t phy_if; > ^ > the full build log is on https://list

Re: [RFC PATCH 1/2] perf: Add the flag sample_disable not to output data on samples

2015-10-12 Thread xiakaixu
于 2015/10/13 3:20, Alexei Starovoitov 写道: > On 10/12/15 2:02 AM, Kaixu Xia wrote: >> diff --git a/include/linux/bpf.h b/include/linux/bpf.h >> index f57d7fe..25e073d 100644 >> --- a/include/linux/bpf.h >> +++ b/include/linux/bpf.h >> @@ -39,6 +39,7 @@ struct bpf_map { >> u32 max_entries; >>

Re: [PATCH net-next] tun: use sk_fullsock() before reading sk->sk_tsflags

2015-10-12 Thread David Miller
From: Eric Dumazet Date: Fri, 09 Oct 2015 15:42:21 -0700 > From: Eric Dumazet > > timewait or request sockets are small and do not contain sk->sk_tsflags > > Without this fix, we might read garbage, and crash later in > > __skb_complete_tx_timestamp() > -> sock_queue_err_skb() > > (These ps

Re: [PATCH net-next 0/3] net: Pass net into defragmentation

2015-10-12 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Fri, 09 Oct 2015 13:42:20 -0500 > > This is the next installment of my work to pass struct net through the > output path so the code does not need to guess how to figure out which > network namespace it is in, and ultimately routes can have ou

Re: [PATCH net-next] packet: fix match_fanout_group()

2015-10-12 Thread David Miller
From: Eric Dumazet Date: Fri, 09 Oct 2015 11:29:32 -0700 > From: Eric Dumazet > > Recent TCP listener patches exposed a prior af_packet bug : > match_fanout_group() blindly assumes it is always safe > to cast sk to a packet socket to compare fanout with af_packet_priv > > But SYNACK packets ca

Re: [PATCH] rtnetlink: fix gcc -Wconversion warning

2015-10-12 Thread David Miller
From: Ronen Arad Date: Fri, 9 Oct 2015 10:35:47 -0700 > RTA_ALIGNTO is currently define as 4. It has to be 4U to prevent warning > for RTA_ALIGN and RTA_DATA expansions when -Wconversion gcc option is > enabled. > This follows NLMSG_ALIGNTO definition in . > > Signed-off-by: Ronen Arad Applie

Re: pull-request: wireless-drivers-next 2015-10-09

2015-10-12 Thread David Miller
From: Kalle Valo Date: Fri, 09 Oct 2015 18:13:22 +0300 > here's first wireless-drivers pull request for 4.4. New features and > bugfixes but not really anything out of ordinary. Please let me know if > there are any problems. Pulled, thanks Kalle. -- To unsubscribe from this list: send the line

Re: [PATCH net] ipv4/icmp: redirect messages can use the ingress daddr as source

2015-10-12 Thread David Miller
From: Paolo Abeni Date: Fri, 9 Oct 2015 14:34:31 +0200 > This patch allows configuring how the source address of ICMP > redirect messages is selected; by default the old behaviour is > retained, while setting icmp_redirects_use_orig_daddr force the > usage of the destination address of the packe

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

2015-10-12 Thread David Miller
From: Jiri Pirko Date: Fri, 9 Oct 2015 13:54:11 +0200 > From: Jiri Pirko > > Some drivers need to implement both switchdev vlan ops and > vid_add/kill ndos. For that to work in bridge code, we need to try > switchdev op first when adding/deleting vlan id. > > Signed-off-by: Jiri Pirko > Sign

Re: [PATCH net-next] BNX2: free temp_stats_blk on error path

2015-10-12 Thread David Miller
From: Weidong Wang Date: Tue, 13 Oct 2015 10:05:19 +0800 > In bnx2_init_board, missing free temp_stats_blk on error path when > some operations do failed. Just add the 'kfree' operation. > > Signed-off-by: Wang Weidong Applied, thanks. -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH v4 4/4] Adds hardware supported cross timestamp

2015-10-12 Thread David Miller
From: "Christopher S. Hall" Date: Mon, 12 Oct 2015 11:45:22 -0700 > @@ -25,6 +25,8 @@ > */ > > #include "e1000.h" > +#include You cannot include an architecture specific header file in a driver that's compiled on several architectures. -- To unsubscribe from this list: send the line "unsub

Re: [PATCH net] ppp: don't override sk->sk_state in pppoe_flush_dev()

2015-10-12 Thread Denys Fedoryshchenko
On 2015-10-07 15:12, Guillaume Nault wrote: On Mon, Oct 05, 2015 at 02:08:44PM +0200, Guillaume Nault wrote: if (po) { struct sock *sk = sk_pppox(po); - bh_lock_sock(sk); - - /* If the user has locked the socket, just ignore -*

Re: [PATCH v3 net-next 0/4] tcp: better smp listener behavior

2015-10-12 Thread David Miller
From: Eric Dumazet Date: Thu, 8 Oct 2015 19:33:20 -0700 > As promised in last patch series, we implement a better SO_REUSEPORT > strategy, based on cpu affinities if selected by the application. > > We also moved sk_refcnt out of the cache line containing the lookup > keys, as it was considerab

Re: [PATCH v4 4/4] Adds hardware supported cross timestamp

2015-10-12 Thread kbuild test robot
Hi Christopher, [auto build test ERROR on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Christopher-S-Hall/Patchset-enabling-hardware-based-cross-timestamps-for-next-gen-Intel-platforms/20151

Re: [PATCH v2 net-next 0/4] tcp: better smp listener behavior

2015-10-12 Thread David Miller
From: Eric Dumazet Date: Thu, 8 Oct 2015 14:58:53 -0700 > As promised in last patch series, we implement a better SO_REUSEPORT > strategy, based on cpu hints if given by the application. > > We also moved sk_refcnt out of the cache line containing the lookup > keys, as it was considerably slowi

Re: [PATCH v4 4/4] Adds hardware supported cross timestamp

2015-10-12 Thread kbuild test robot
Hi Christopher, [auto build test ERROR on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Christopher-S-Hall/Patchset-enabling-hardware-based-cross-timestamps-for-next-gen-Intel-platforms/20151

Re: [PATCH net-next 1/2] sock: support per-packet fwmark

2015-10-12 Thread David Miller
From: Edward Hyunkoo Jee Date: Thu, 8 Oct 2015 14:56:48 -0700 > It's useful to allow users to set fwmark for an individual packet, > without changing the socket state. The function this patch adds in > sock layer can be used by the protocols that need such a feature. > > Signed-off-by: Edward H

Re: [PATCH net-next 2/2] packet: support per-packet fwmark for af_packet sendmsg

2015-10-12 Thread David Miller
From: Edward Hyunkoo Jee Date: Thu, 8 Oct 2015 14:56:49 -0700 > Signed-off-by: Edward Hyunkoo Jee > Signed-off-by: Eric Dumazet Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg

Re: [PATCH v2 net-next 0/3] bpf: unprivileged

2015-10-12 Thread David Miller
From: Alexei Starovoitov Date: Wed, 7 Oct 2015 22:23:20 -0700 > v1-v2: > - this set logically depends on cb patch > "bpf: fix cb access in socket filter programs": > http://patchwork.ozlabs.org/patch/527391/ > which is must have to allow unprivileged programs. > Thanks Daniel for finding

[PATCH net-next] BNX2: free temp_stats_blk on error path

2015-10-12 Thread Weidong Wang
In bnx2_init_board, missing free temp_stats_blk on error path when some operations do failed. Just add the 'kfree' operation. Signed-off-by: Wang Weidong --- drivers/net/ethernet/broadcom/bnx2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers

Re: [PATCH v4 2/4] Always running timer correlated clocksource

2015-10-12 Thread kbuild test robot
Hi Christopher, [auto build test ERROR on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Christopher-S-Hall/Patchset-enabling-hardware-based-cross-timestamps-for-next-gen-Intel-platforms/20151

[PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-12 Thread Christopher S. Hall
From: Thomas Gleixner Modern Intel hardware provides the so called Always Running Timer (ART). The TSC which is usually used for timekeeping is derived from ART and runs with a fixed frequency ratio to it. ART is routed to devices and allows to take atomic timestamp samples from the device clock

[PATCH v4 0/4] Patchset enabling hardware based cross-timestamps for next gen Intel platforms

2015-10-12 Thread Christopher S. Hall
Modern Intel hardware adds an Always Running Timer (ART) that allows the network and audio device clocks to precisely cross timestamp the device clock with the system clock. This allows a precise correlation of the device time and system time. v4 adds a history which enables the audio DSP (a "slow

[PATCH v4 3/4] Add PTP_SYS_OFFSET_PRECISE for driver crosstimestamping

2015-10-12 Thread Christopher S. Hall
Currently, network /system cross-timestamping is performed in the PTP_SYS_OFFSET ioctl. The PTP clock driver reads gettimeofday() and the gettime64() callback provided by the driver. The cross-timestamp is best effort where the latency between the capture of system time (getnstimeofday()) and the d

[PATCH v4 4/4] Adds hardware supported cross timestamp

2015-10-12 Thread Christopher S. Hall
Modern Intel systems supports cross timestamping of the network device clock and Always Running Timer (ART) in hardware. This allows the device time and system time to be precisely correlated. The timestamp pair is exposed through the *_get_ts callback used by get_correlated_timestamp(). The hardw

[PATCH v4 2/4] Always running timer correlated clocksource

2015-10-12 Thread Christopher S. Hall
On modern Intel systems TSC is derived from the new Always Running Timer (ART). In addition, ART can be captured simultaneous to the capture of audio and network device clocks, allowing a correlation between timebases to be constructed. Upon capture, the driver converts the captured ART value to th

Re: Issue with /proc/sys/net/ipv4/tcp_mem

2015-10-12 Thread Eric Dumazet
On Mon, 2015-10-12 at 11:37 -0500, Eric W. Biederman wrote: > wangyufen writes: > > > Hi, > > > > I tried on linux-4.1: > > linux:~# cat /proc/sys/net/ipv4/tcp_mem > > 8388608 1258291216777216 > > linux:~# echo 1234 >/proc/sys/net/ipv4/tcp_mem > > -bash: echo: write erro

[PATCH net-next] net:hisilicon: supports promisc mode

2015-10-12 Thread yankejian
this patch adds support to set promisc mode. it configs the queue on init seq when it is on promisc mode.and being enabled or disabled promisc mode by upper level user. Signed-off-by: yankejian Signed-off-by: Yisen Zhuang --- drivers/net/ethernet/hisilicon/hns/hnae.h | 1 + drivers

Re: [PATCH] - gre: add eth_p_teb gro-handler for OVS with gre tunnels

2015-10-12 Thread David Miller
From: Ramu Ramamurthy Date: Mon, 12 Oct 2015 17:49:13 -0700 > We are using the 3.x kernels and thats why I could not see your fix in > my tests. It is inappropriate to submit patches not targetted and tested against the current sources. -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH v4 0/3] net: unix: fix use-after-free

2015-10-12 Thread David Miller
From: Jason Baron Date: Mon, 12 Oct 2015 15:50:30 -0400 > I'm happy to re-post the series or whatever makes things easiest for > you. This is what you should always do, reposting a single patch within a series is not sufficient. Thanks. -- To unsubscribe from this list: send the line "unsubscri

[PATCH] netlink: trim skb to exact size to avoid MSG_TRUNC

2015-10-12 Thread Ronen Arad
The available room in the skb allocated in netlink_dump for iproute2 show requests (e.g. "ip link [show]", "bridge [-c] vlan show") should be trimmed to the exact size requested in order to avoid MSG_TRUNC flag set in netlink_recvmg. This was handled properly for small skb allocated when no interfa

Re: [PATCH] - gre: add eth_p_teb gro-handler for OVS with gre tunnels

2015-10-12 Thread Ramu Ramamurthy
On 2015-10-12 16:47, Jesse Gross wrote: On Mon, Oct 12, 2015 at 3:26 PM, Ramu Ramamurthy wrote: Problem: When using OVS with GRE tunnels, and GRO is enabled on the nic, We find that GRO doesnt really take effect. As a result, TCP stream performance on a 10G nic is around 2-3Gbps. Ro

  1   2   3   >