On Mon, Oct 12, 2015 at 11:25 PM, Jiri Pirko <j...@resnulli.us> wrote: > Tue, Oct 13, 2015 at 06:02:28AM CEST, sfel...@gmail.com wrote: >>On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko <j...@resnulli.us> wrote: >>> From: Jiri Pirko <j...@mellanox.com> >>> >>> No need to avoid sleeping in switchdev callbacks now, as the switchdev >>> core allows it. >>> >>> Signed-off-by: Jiri Pirko <j...@mellanox.com> >>> --- >>> drivers/net/ethernet/rocker/rocker.c | 7 +++---- >>> 1 file changed, 3 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/net/ethernet/rocker/rocker.c >>> b/drivers/net/ethernet/rocker/rocker.c >>> index bb956a5..9629c5b5 100644 >>> --- a/drivers/net/ethernet/rocker/rocker.c >>> +++ b/drivers/net/ethernet/rocker/rocker.c >>> @@ -3672,7 +3672,7 @@ static int rocker_port_fdb_flush(struct rocker_port >>> *rocker_port, >>> rocker_port->stp_state == BR_STATE_FORWARDING) >>> return 0; >>> >>> - flags |= ROCKER_OP_FLAG_REMOVE; >>> + flags |= ROCKER_OP_FLAG_NOWAIT | ROCKER_OP_FLAG_REMOVE; >> >>I understand the two changes below where you're removing NOWAIT, but >>here you're adding NOWAIT which I'm not sure how that is related to >>the switchdev core changes. Is this two patches? > > I removed ROCKER_OP_FLAG_NOWAIT from attr_set. But here in > rocker_port_fdb_flush, which is called from attr_set, we call > rocker_port_fdb_learn with spin lock. Therefore I had to put > ROCKER_OP_FLAG_NOWAIT here. Before ROCKER_OP_FLAG_NOWAIT removal from > attr_set this was there already.
Gotcha. Acked-by: Scott Feldman <sfel...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
