Hello David,
At Mon, 5 Oct 2015 08:32:51 -0600,
David Ahern wrote:
>
> diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c
> index 30caa289c5db..5cedfda4b241 100644
> --- a/net/ipv6/xfrm6_policy.c
> +++ b/net/ipv6/xfrm6_policy.c
> @@ -37,6 +37,7 @@ static struct dst_entry *xfrm6_dst
Fri, Oct 09, 2015 at 06:39:41AM CEST, sfel...@gmail.com wrote:
>On Thu, Oct 8, 2015 at 1:26 AM, Jiri Pirko wrote:
>> Thu, Oct 08, 2015 at 08:03:35AM CEST, sfel...@gmail.com wrote:
>>>On Wed, Oct 7, 2015 at 10:39 PM, Jiri Pirko wrote:
Thu, Oct 08, 2015 at 06:27:07AM CEST, sfel...@gmail.com wr
Fri, Oct 09, 2015 at 06:38:10AM CEST, pjonn...@broadcom.com wrote:
>
>
>> -Original Message-
>> From: sfel...@gmail.com [mailto:sfel...@gmail.com]
>> Sent: Friday, October 09, 2015 7:53 AM
>> To: netdev@vger.kernel.org
>> Cc: da...@davemloft.net; j...@resnulli.us; siva.mannem@gmail.com;
Neil Brown wrote:
> Kosuke Tatsukawa writes:
>
>> There are several places in net/sunrpc/svcsock.c which calls
>> waitqueue_active() without calling a memory barrier. Add a memory
>> barrier just as in wq_has_sleeper().
>>
>> I found this issue when I was looking through the linux source code
>>
Dear Sir or Madam
How are you doing?
Attached pls kindly find some of our new design.
Looking forward to work with you at an ealry date！
Best whishes
TomN�Р骒r��yb�X�肚�v�^�)藓{.n�+�阀z�^�)��骅w* jg�报 �茛j/�赇z罐���2���ㄨ��&�)摺�a囤�� �G���h��j:+v���w��佶
Kosuke Tatsukawa writes:
> There are several places in net/sunrpc/svcsock.c which calls
> waitqueue_active() without calling a memory barrier. Add a memory
> barrier just as in wq_has_sleeper().
>
> I found this issue when I was looking through the linux source code
> for places calling waitqueu
On 2015/10/9 4:20, Andrew Morton wrote:
> On Wed, 19 Aug 2015 17:18:15 -0700 (PDT) David Rientjes
> wrote:
>
>> On Wed, 19 Aug 2015, Patil, Kiran wrote:
>>
>>> Acked-by: Kiran Patil
>>
>> Where's the call to preempt_disable() to prevent kernels with preemption
>> from making numa_node_id() inv
On Thu, Oct 8, 2015 at 1:26 AM, Jiri Pirko wrote:
> Thu, Oct 08, 2015 at 08:03:35AM CEST, sfel...@gmail.com wrote:
>>On Wed, Oct 7, 2015 at 10:39 PM, Jiri Pirko wrote:
>>> Thu, Oct 08, 2015 at 06:27:07AM CEST, sfel...@gmail.com wrote:
On Wed, Oct 7, 2015 at 11:30 AM, Jiri Pirko wrote:
>
> -Original Message-
> From: sfel...@gmail.com [mailto:sfel...@gmail.com]
> Sent: Friday, October 09, 2015 7:53 AM
> To: netdev@vger.kernel.org
> Cc: da...@davemloft.net; j...@resnulli.us; siva.mannem@gmail.com;
> Premkumar Jonnala; step...@networkplumber.org;
> ro...@cumulusnetworks.
Hi Jason,
[auto build test ERROR on v4.3-rc3 -- if it's inappropriate base, please ignore]
config: x86_64-randconfig-i0-201540 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
net/unix/af_
Fri, Oct 09, 2015 at 04:23:16AM CEST, sfel...@gmail.com wrote:
>From: Scott Feldman
>
>Push bridge-level attributes down to switchdev drivers. This patchset
>adds the infrastructure and then pushes, as an example, ageing_time attribute
>down from bridge to switchdev (rocker) driver. Add some ran
Fri, Oct 09, 2015 at 04:23:20AM CEST, sfel...@gmail.com wrote:
>From: Scott Feldman
>
>The FDB cleanup timer will get rescheduled to re-evaluate FDB entries
>based on new ageing_time.
>
>Signed-off-by: Scott Feldman
Acked-by: Jiri Pirko
--
To unsubscribe from this list: send the line "unsubscr
Fri, Oct 09, 2015 at 04:23:19AM CEST, sfel...@gmail.com wrote:
>From: Scott Feldman
>
>Use SWITCHDEV_F_SKIP_EOPNOTSUPP to skip over ports in bridge that don't
>support setting ageing_time (or setting bridge attrs in general).
>
>If push fails, don't update ageing_time in bridge and return err to u
Fri, Oct 09, 2015 at 04:23:18AM CEST, sfel...@gmail.com wrote:
>From: Scott Feldman
>
>This allows us to recurse over all the ports, skipping over unsupporting
>ports. Without the change, the recursion would stop at first unsupported
>port.
>
>Signed-off-by: Scott Feldman
Acked-by: Jiri Pirko
Fri, Oct 09, 2015 at 04:23:17AM CEST, sfel...@gmail.com wrote:
>From: Scott Feldman
>
>Setting the stage to push bridge-level attributes down to port driver so
>hardware can be programmed accordingly. Bridge-level attribute example is
>ageing_time. This is a per-bridge attribute, not a per-bridg
The unix_dgram_poll() routine calls sock_poll_wait() not only for the wait
queue associated with the socket s that we are poll'ing against, but also calls
sock_poll_wait() for a remote peer socket p, if it is connected. Thus,
if we call poll()/select()/epoll() for the socket s, there are then
a cou
Now that connect() permanently registers a callback routine, we can induce
extra overhead in unix_dgram_recvmsg(), which unconditionally wakes up
its peer_wait queue on every receive. This patch makes the wakeup there
conditional on there being waiters.
Tested using: http://www.spinics.net/lists/n
Hi,
These patches are against mainline, I can re-base to net-next, please
let me know.
They have been tested against: https://lkml.org/lkml/2015/9/13/195,
which causes the use-after-free quite quickly and here:
https://lkml.org/lkml/2015/10/2/693.
Thanks,
-Jason
v4:
-set UNIX_NOSPACE only if t
Convert gc_flags to flags in perparation for the subsequent patch, which will
make use of a flag bit for a non-gc purpose.
Signed-off-by: Jason Baron
---
include/net/af_unix.h | 2 +-
net/unix/garbage.c| 12 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include
On 08/10/2015 19:33, Eric Dumazet wrote:
As promised in last patch series, we implement a better SO_REUSEPORT
strategy, based on cpu affinities if selected by the application.
We also moved sk_refcnt out of the cache line containing the lookup
keys, as it was considerably slowing down smp oper
On Thu, Oct 8, 2015 at 8:37 AM, Eric Dumazet wrote:
> As promised in last patch series, we implement a better SO_REUSEPORT
> strategy, based on cpu affinities if selected by the application.
>
> We also moved sk_refcnt out of the cache line containing the lookup
> keys, as it was considerably slow
On Thu, Oct 8, 2015 at 7:33 PM, Eric Dumazet wrote:
> SO_INCOMING_CPU as added in commit 2c8c56e15df3 was a getsockopt() command
> to fetch incoming cpu handling a particular TCP flow after accept()
>
> This commits adds setsockopt() support and extends SO_REUSEPORT selection
> logic : If a TCP li
On Thu, Oct 8, 2015 at 7:40 PM, Florian Fainelli wrote:
> 2015-10-08 19:23 GMT-07:00 :
>> From: Scott Feldman
>>
>> Use SWITCHDEV_F_SKIP_EOPNOTSUPP to skip over ports in bridge that don't
>> support setting ageing_time (or setting bridge attrs in general).
>>
>> If push fails, don't update agein
On Thu, Oct 8, 2015 at 2:44 AM, yzhu1 wrote:
> Hi, Miller
>
> Would you like to check this patch?
I explained to you way back in June what some of the biggest oversights
were, here with your work. And you have changed nothing but yet expect
a reply from maintainers who are extremely busy, simply
Fix these compiler warnings by declaring test_exit() and test_main()
regardless of whether TEST_NO_WRAPPERS is defined:
test-cmdline.c: In function ‘send_ioctl’:
test-cmdline.c:268:2: warning: implicit declaration of function ‘test_exit’
[-Wimplicit-function-declaration]
test_exit(0);
^
test-
The return type should be void, consistent with the definition and
with the standard free() function.
Signed-off-by: Ben Hutchings
---
I've applied this post-4.2.
Ben.
internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/internal.h b/internal.h
index 156770c..b5ef646
ethtool version 4.2 has been released.
Home page: https://www.kernel.org/pub/software/network/ethtool/
Download link:
https://www.kernel.org/pub/software/network/ethtool/ethtool-4.2.tar.xz
Release notes:
* Feature: Support soldered-on modules in module EEPROM dump (-m option)
* F
2015-10-08 19:23 GMT-07:00 :
> From: Scott Feldman
>
> Push bridge-level attributes down to switchdev drivers. This patchset
> adds the infrastructure and then pushes, as an example, ageing_time attribute
> down from bridge to switchdev (rocker) driver. Add some range-checking
> for ageing_time
2015-10-08 19:23 GMT-07:00 :
> From: Scott Feldman
>
> Use SWITCHDEV_F_SKIP_EOPNOTSUPP to skip over ports in bridge that don't
> support setting ageing_time (or setting bridge attrs in general).
>
> If push fails, don't update ageing_time in bridge and return err to user.
>
> If push succeeds, up
On 10/8/15 5:50 PM, Devon H. O'Dell wrote:
with the amount of skb_sender_cpu_clear() all over the code base
>I wonder whether there is a better solution to all of these.
I think there is. We found that splitting the union of sender_cpu and
napi_id solved the issue for us. In general, I think thi
SO_INCOMING_CPU as added in commit 2c8c56e15df3 was a getsockopt() command
to fetch incoming cpu handling a particular TCP flow after accept()
This commits adds setsockopt() support and extends SO_REUSEPORT selection
logic : If a TCP listener or UDP socket has this option set, a packet is
delivere
Reducing tcp_timewait_sock from 280 bytes to 272 bytes
allows SLAB to pack 15 objects per page instead of 14 (on x86)
Signed-off-by: Eric Dumazet
---
include/linux/tcp.h | 4 ++--
include/net/sock.h | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/linux/tcp.h b/inc
One 32bit hole is following skc_refcnt, use it.
skc_incoming_cpu can also be an union for request_sock rcv_wnd.
Signed-off-by: Eric Dumazet
---
include/net/request_sock.h | 5 ++---
include/net/sock.h | 14 +-
net/ipv4/syncookies.c | 4 ++--
net/ipv4/tcp_input.c
As promised in last patch series, we implement a better SO_REUSEPORT
strategy, based on cpu affinities if selected by the application.
We also moved sk_refcnt out of the cache line containing the lookup
keys, as it was considerably slowing down smp operations because
of false sharing. This was sim
sk->sk_refcnt is dirtied for every TCP/UDP incoming packet.
This is a performance issue if multiple cpus hit a common socket,
or multiple sockets are chained due to SO_REUSEPORT.
By moving sk_refcnt 8 bytes further, first 128 bytes of sockets
are mostly read. As they contain the lookup keys, this
On Fri, 2015-09-25 at 08:15 +0400, Ivan Mikhaylov wrote:
> * add new version of emac_regs struct from driver structure perspective
> and passing size from actual struct size, not from memory area variable
> which set in dts file.
> * add three types of network chips for new struct : emac, emac4
On Tue, 2015-10-06 at 10:07 +0200, Ivan Vecera wrote:
> Signed-off-by: Ivan Vecera
> ---
> ethtool.8.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ethtool.8.in b/ethtool.8.in
> index ae56293..eeffa70 100644
> --- a/ethtool.8.in
> +++ b/ethtool.8.in
> @@ -872,7 +872,
From: Scott Feldman
Push bridge-level attributes down to switchdev drivers. This patchset
adds the infrastructure and then pushes, as an example, ageing_time attribute
down from bridge to switchdev (rocker) driver. Add some range-checking
for ageing_time.
# ip link set dev br0 type bridge agei
On Thu, Oct 8, 2015 at 1:39 AM, Jiri Pirko wrote:
> Thu, Oct 08, 2015 at 08:04:40AM CEST, sfel...@gmail.com wrote:
>>From: Scott Feldman
>>
>>Setting the stage to push bridge-level attributes down to port driver so
>>hardware can be programmed accordingly. Bridge-level attribute example is
>>age
On Wed, 2015-09-23 at 15:19 -0700, Shrikrishna Khare wrote:
> This adds support for dumping vmxnet3 registers in a readable format.
>
> Signed-off-by: Shrikrishna Khare
> Signed-off-by: Bhavesh Davda
> Acked-by: Srividya Murali
[...]
Applied, thanks.
Ben.
--
Ben Hutchings
If the facts do no
From: Scott Feldman
Use SWITCHDEV_F_SKIP_EOPNOTSUPP to skip over ports in bridge that don't
support setting ageing_time (or setting bridge attrs in general).
If push fails, don't update ageing_time in bridge and return err to user.
If push succeeds, update ageing_time in bridge and run gc_timer
From: Scott Feldman
The FDB cleanup timer will get rescheduled to re-evaluate FDB entries
based on new ageing_time.
Signed-off-by: Scott Feldman
---
drivers/net/ethernet/rocker/rocker.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/net/ethernet/rocker/rocker.c
From: Scott Feldman
This allows us to recurse over all the ports, skipping over unsupporting
ports. Without the change, the recursion would stop at first unsupported
port.
Signed-off-by: Scott Feldman
---
include/net/switchdev.h |1 +
net/switchdev/switchdev.c |9 -
2 files
From: Scott Feldman
Setting the stage to push bridge-level attributes down to port driver so
hardware can be programmed accordingly. Bridge-level attribute example is
ageing_time. This is a per-bridge attribute, not a per-bridge-port attr.
Signed-off-by: Scott Feldman
---
include/net/switchd
There are several places in net/sunrpc/svcsock.c which calls
waitqueue_active() without calling a memory barrier. Add a memory
barrier just as in wq_has_sleeper().
I found this issue when I was looking through the linux source code
for places calling waitqueue_active() before wake_up*(), but with
From: Jesse Brandeburg
I found a code indent that was avoidable because a whole function is inside
an if block, reverse the if and move the code back a tab.
Change-ID: I9989c8750ee61678fbf96a3b0fd7bf7cc7ef300a
Signed-off-by: Jesse Brandeburg
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
From: Jesse Brandeburg
Add missings spaces after declarations, remove another __func__ use,
remove uncessary braces, remove unneeded breaks, and useless returns,
and generally fix up some code.
Change-ID: Ie715d6b64976c50e1c21531685fe0a2bd38c4244
Signed-off-by: Jesse Brandeburg
Signed-off-by: S
From: Mitch Williams
Use the capabilities passed to us by the PF driver to control VF driver
behavior. In the process, clean up the VLAN add/remove code so it's not
a horrible morass of ifdefs.
Change-ID: I1050eaf12b658a26fea6813047c9964163c70a73
Signed-off-by: Mitch Williams
Tested-by: Andrew
From: Jesse Brandeburg
The driver was issuing a WARN_ON during ring size changes
because the code was cloning the rx_ring struct but
not zeroing out the pointers before allocating new memory.
Zero out the pointers in the cloned copy before allocating
new memory for them. In this case the code w
From: Neerav Parikh
This patch adds parsing for CEE DCBX TLVs from the LLDP MIB.
While the driver gets the DCB CEE operational configuration from Firmware
using the "Get CEE DCBX Oper Config" AQ command there is a need to get
the CEE DesiredCfg Tx by firmware and DCB configuration Rx from peer;
From: Mitch Williams
Under certain circumstances, the device may not have enough resources to
enable all of the VFs that it advertises in config space. Although the
number of supported VFs is reported upon driver init, it is not obvious
when this is different from the number reported in config sp
From: Carolyn Wyborny
This patch fixes a problem where the PF's fdir filter table would have an
entry that the hw was unable to add. This notification happens in the hot
path, so instead of trying to fix it then, we note the location in the
failure case and delete it during regular fdir subtask c
From: Greg Bowers
Changes parsing of AQ command Get CEE DCBX OPER CFG (0x0A07). Change is
required because FW creates the oper_prio_tc nibbles reversed from those
in the CEE Priority Group sub-TLV.
Change-ID: I7d9d8641bb430d30e286fc3fac909866ef8a0de8
Signed-off-by: Greg Bowers
Tested-by: Andrew
From: Neerav Parikh
This patch adds capability to query and store the CEE DCBX DesiredCfg
and RemoteCfg data from the LLDP MIB.
Added new member "desired_dcbx_config" in the i40e_hw data structure
to hold CEE only DesiredCfg data.
Change-ID: I19c550369594384eaff4cc63e690ca740231195d
Signed-off-b
From: Mitch Williams
The VF really doesn't care about the QOS handle but it will in the
future. Since the VF only uses TC0, send it that handle. On the VF
side, save the handle and use it to populate the QOS params when we call
into the client interface.
Change-ID: I76f41b070baeaa09b19383e9168bc
From: Shannon Nelson
There's been some need for controlling the periodic link polling for
debugging link issues. This patch enables switching it off and on
through an ethtool private flag. The link poll remains on by default,
but can be turned off with
ethtool --set-priv-flags p261p1 Li
From: Matt Jared
This patch addresses an issue where multiple link up messages can be logged
resulting from aq link status timing when link properties are changed (fc,
speed, etc.); solved by using a single function to handle status printing
and adding a mechanism to track whether link state (up
From: Jesse Brandeburg
The interrupt enable function can be inlined by moving it to the header
file, which decreases the function call overhead for a frequently called
function.
Change-ID: I3214cc99593725768642680e7b8ce7e9bba7e44d
Signed-off-by: Jesse Brandeburg
Tested-by: Andrew Bowers
Signed
From: Jesse Brandeburg
To help users and developers know what compile options
and hardware features are enabled at compile time, print
VxLAN is available.
Change-ID: I3162f3b7678dc725a597f964217920eb218b480b
Signed-off-by: Jesse Brandeburg
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
From: Mitch Williams
Using VFGEN_RSTAT to detect a VF reset is an endeavor that is fraught
with peril. It's entirely too easy to miss a reset because none of the
bits are sticky. By the time the VF driver reads the register, the reset
may have been processed and cleaned up by the PF driver, leavi
This series contains updates to i40e and i40evf only (again).
Jesse fixes an issue where the driver was issuing a WARN_ON during ring
size changes because the code was cloning the rx_ring struct but not
zeroing out the pointers before allocating new memory, so simply zero
out the pointers. Also r
From: Serey Kong
Ran into an issue where PF's VSI type list was different from VF's,
which was resulted in different enum index. The VSI type list can
be different depending on what build flag is used for PF and VF.
The change is to explicitly assign enum index for each VSI type
so that PF and V
Hi Kosuke,
[auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please
ignore]
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> net/sunrpc/svcsock.c:417:28: spa
Hi Kosuke,
[auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please
ignore]
config: x86_64-randconfig-x002-201540 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In f
Hi Kosuke,
[auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please
ignore]
config: xtensa-allyesconfig (attached as .config)
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bi
The alive parameter of tcp_orphan_retries, indicates
whether the connection is assumed alive or not.
In the function and all places calling it is used as a boolean value.
Therefore this changes the type of alive to bool in the function
definition and all calling locations.
Since tcp_orphan_tries
On Wed, Oct 7, 2015 at 8:46 AM, Alexei Starovoitov wrote:
> On 10/7/15 1:16 AM, Daniel Borkmann wrote:
>>
>> Similar to commit c29390c6dfee ("xps: must clear sender_cpu before
>> forwarding"), we also need to clear the skb->sender_cpu when moving
>> from RX to TX via skb_do_redirect() due to the s
There are several places in net/sunrpc/svcsock.c which calls
waitqueue_active() without calling a memory barrier. Change the code
to call wq_has_sleeper() instead, which other networking code uses in
similar places.
I found this issue when I was looking through the linux source code
for places ca
brcmf_msgbuf_ioctl_resp_wake() seems to be missing a memory barrier
which might cause the waker to not notice the waiter and miss sending a
wake_up as in the following figure.
brcmf_msgbuf_ioctl_resp_wake brcmf_msgbuf_ioctl_resp_wait
-
On Wed, Oct 7, 2015 at 10:47 AM, Jarno Rajahalme wrote:
>
>> On Oct 6, 2015, at 6:01 PM, Jesse Gross wrote:
>>
>> On Mon, Oct 5, 2015 at 1:25 PM, Alexander Duyck
>> wrote:
>>> On 10/05/2015 06:59 AM, Vlastimil Babka wrote:
On 10/02/2015 12:18 PM, Konstantin Khlebnikov wrote:
>
[Re: [PATCH-next v2 3/4] net/sched: make sch_blackhole.c explicitly
non-modular] On 07/10/2015 (Wed 14:47) Cong Wang wrote:
> On Wed, Oct 7, 2015 at 2:27 PM, Paul Gortmaker
> wrote:
> > The Kconfig currently controlling compilation of this code is:
> >
> > net/sched/Kconfig:menuconfig NET_SCHED
On Thu, Oct 8, 2015 at 6:53 AM, Jiri Benc wrote:
> Allow the user space to query what features are supported by the openvswitch
> module. This will be used to allow or disallow certain configurations and/or
> switch between newer and older APIs depending on what the kernel supports.
>
> Two featur
On Fri, 2015-10-09 at 06:14 +0800, kbuild test robot wrote:
> Hi Eric,
>
> [auto build test WARNING on net-next/master -- if it's inappropriate base,
> please ignore]
>
> config: sh-titan_defconfig (attached as .config)
> reproduce:
> wget
> https://git.kernel.org/cgit/linux/kernel/git/
Hi Eric,
[auto build test WARNING on net-next/master -- if it's inappropriate base,
please ignore]
config: sh-titan_defconfig (attached as .config)
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x
On Thu, Oct 8, 2015 at 2:26 PM, Maxime Bizon wrote:
>
> On Thu, 2015-10-08 at 14:09 -0700, Tom Herbert wrote:
>
>> I think inet_proto_csum_replace16 should be called here.
>
> inet_proto_csum_replace16() wants a non NULL checksum pointer to update,
> and there is no such thing here.
>
> I could pa
On 10/8/15 11:20 AM, Hannes Frederic Sowa wrote:
Hi Alexei,
On Thu, Oct 8, 2015, at 07:23, Alexei Starovoitov wrote:
The feature is controlled by sysctl kernel.unprivileged_bpf_disabled.
This toggle defaults to off (0), but can be set true (1). Once true,
bpf programs and maps cannot be access
On Wed, 2015-06-10 at 13:40 +0300, Konstantin Khlebnikov wrote:
> Two patches from 3.11 which are missing in 3.10.y
>
> I've just seen livelock in 3.10.69+ where all cpus are stuck in
> fib6_run_gc()
[...]
These also looked applicable to 3.2, so I've queued them up too.
Ben.
--
Ben Hutchings
SO_INCOMING_CPU as added in commit 2c8c56e15df3 was a getsockopt() command
to fetch incoming cpu handling a particular TCP flow after accept()
This commits adds setsockopt() support and extends SO_REUSEPORT selection
logic : If a TCP listener or UDP socket has this option set, a packet is
delivere
One 32bit hole is following skc_refcnt, use it.
skc_incoming_cpu can also be an union for request_sock rcv_wnd.
Signed-off-by: Eric Dumazet
---
include/net/request_sock.h | 5 ++---
include/net/sock.h | 14 +-
net/ipv4/syncookies.c | 4 ++--
net/ipv4/tcp_input.c
Reducing tcp_timewait_sock from 280 bytes to 272 bytes
allows SLAB to pack 15 objects per page instead of 14 (on x86)
Signed-off-by: Eric Dumazet
---
include/linux/tcp.h | 4 ++--
include/net/sock.h | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/linux/tcp.h b/inc
sk->sk_refcnt is dirtied for every TCP/UDP incoming packet.
This is a performance issue if multiple cpus hit a common socket,
or multiple sockets are chained due to SO_REUSEPORT.
By moving sk_refcnt 8 bytes further, first 128 bytes of sockets
are mostly read. As they contain the lookup keys, this
As promised in last patch series, we implement a better SO_REUSEPORT
strategy, based on cpu hints if given by the application.
We also moved sk_refcnt out of the cache line containing the lookup
keys, as it was considerably slowing down smp operations because
of false sharing. This was simpler tha
It's useful to allow users to set fwmark for an individual packet,
without changing the socket state. The function this patch adds in
sock layer can be used by the protocols that need such a feature.
Signed-off-by: Edward Hyunkoo Jee
Signed-off-by: Eric Dumazet
Cc: Willem de Bruijn
---
include
Signed-off-by: Edward Hyunkoo Jee
Signed-off-by: Eric Dumazet
Cc: Willem de Bruijn
---
net/packet/af_packet.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 81c900f..9d8c7fa 100644
--- a/net/packet/af_packet.c
On Wed, Oct 7, 2015 at 9:07 PM, Tom Herbert wrote:
> On Wed, Oct 7, 2015 at 8:41 AM, Or Gerlitz wrote:
>> On 10/6/2015 2:39 AM, Tom Herbert wrote:
>>> +static const struct skb_csum_offl_spec csum_offl_spec = {
>>> + .ipv4_okay = 1,
>>> + .ipv6_okay = 1,
>>> + .encap_okay = 1,
On Thu, 2015-10-08 at 14:09 -0700, Tom Herbert wrote:
> I think inet_proto_csum_replace16 should be called here.
inet_proto_csum_replace16() wants a non NULL checksum pointer to update,
and there is no such thing here.
I could pass a dummy value, but inet_proto_csum_replace16() will do
twice mo
On Thu, 2015-10-08 at 13:53 -0700, Tom Herbert wrote:
> If the incoming CPU is set for a connected UDP via
> sk_incoming_cpu_update, wouldn't this check subsequently _only_ allow
> packets for that socket to come from the same CPU?
>
Hmm, I thought the SO_REUSEPORT path would be taken only for n
On Thu, Oct 8, 2015 at 11:16 AM, Eric Dumazet wrote:
> From: Eric Dumazet
>
> Before recent TCP listener patches, we were updating listener
> sk->sk_rxhash before the cloning of master socket.
>
> children sk_rxhash was therefore correct after the normal 3WHS.
>
> But with lockless listener, we n
On Thu, Oct 8, 2015 at 1:26 PM, Maxime Bizon wrote:
>
> With this setup:
>
> * non IPv6 checksumming capable network hardware
> * GRO off
> * IPv6 SNAT
>
> I get this when I receive an UDPv6 reply: ": hw csum failure"
>
> Call trace:
>
> * nf_ip6_checksum() calls __skb_checksum_complete()
> * nf_n
On Thu, Oct 8, 2015 at 8:37 AM, Eric Dumazet wrote:
> SO_INCOMING_CPU as added in commit 2c8c56e15df3 was a getsockopt() command
> to fetch incoming cpu handling a particular TCP flow after accept()
>
> This commits adds setsockopt() support and extends SO_REUSEPORT selection
> logic : If a TCP li
On Thu, 2015-10-08 at 11:56 -0400, Paul Moore wrote:
> Acked-by: Paul Moore
Thanks for reviewing Paul.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
With this setup:
* non IPv6 checksumming capable network hardware
* GRO off
* IPv6 SNAT
I get this when I receive an UDPv6 reply: ": hw csum failure"
Call trace:
* nf_ip6_checksum() calls __skb_checksum_complete()
* nf_nat_ipv6_csum_update() & nf_nat_ipv6_manip_pkt()
* __udp6_lib_rcv() => udp6
On Wed, 19 Aug 2015 17:18:15 -0700 (PDT) David Rientjes
wrote:
> On Wed, 19 Aug 2015, Patil, Kiran wrote:
>
> > Acked-by: Kiran Patil
>
> Where's the call to preempt_disable() to prevent kernels with preemption
> from making numa_node_id() invalid during this iteration?
David asked this que
On Tue, 2015-10-06 at 16:23 +0200, Maxime Bizon wrote:
> + if (maniptype == NF_NAT_MANIP_SRC) {
> + from = ipv6h->saddr.s6_addr32;
> + to = target->src.u3.in6.s6_addr32;
> + } else {
> + from = ipv6h->daddr.s6_addr32;
> + to = target->src.u3
Hi David,
David Ahern writes:
> On 10/8/15 1:25 PM, Hannes Frederic Sowa wrote:
>>> diff --git a/include/net/if_inet6.h b/include/net/if_inet6.h
>>> index 1c8b6820b694..f190a14148ab 100644
>>> --- a/include/net/if_inet6.h
>>> +++ b/include/net/if_inet6.h
>>> @@ -72,6 +72,7 @@ struct inet6_ifaddr
Hi Hannes:
On 10/8/15 1:25 PM, Hannes Frederic Sowa wrote:
diff --git a/include/net/if_inet6.h b/include/net/if_inet6.h
index 1c8b6820b694..f190a14148ab 100644
--- a/include/net/if_inet6.h
+++ b/include/net/if_inet6.h
@@ -72,6 +72,7 @@ struct inet6_ifaddr {
int regen_
Hi David,
David Ahern writes:
> Currently, all ipv6 addresses are flushed when the interface is configured
> down, including global, static addresses:
>
> $ ip -6 addr add dev eth1 2000:11:1:1::1/64
> $ ip addr show dev eth1
> 3: eth1: mtu 1500 qdisc noop state DOWN group
> default
Hello.
On 10/08/2015 01:47 AM, Jeff Kirsher wrote:
From: Shannon Nelson
i40e_init_pf_fcoe() didn't return anything except 0, it prints enough
error info already, and no driver logic depends on the return value,
so this can be void.
Change-ID: Ie6afad849857d87a7064c42c3cce14c74c2f29d8
Signed-
Hi Alexei,
On Thu, Oct 8, 2015, at 07:23, Alexei Starovoitov wrote:
> The feature is controlled by sysctl kernel.unprivileged_bpf_disabled.
> This toggle defaults to off (0), but can be set true (1). Once true,
> bpf programs and maps cannot be accessed from unprivileged process,
> and the toggle
From: Eric Dumazet
Before recent TCP listener patches, we were updating listener
sk->sk_rxhash before the cloning of master socket.
children sk_rxhash was therefore correct after the normal 3WHS.
But with lockless listener, we no longer dirty/change listener sk_rxhash
as it would be racy.
We n
1 - 100 of 243 matches
Mail list logo
