Fri, Oct 09, 2015 at 04:23:16AM CEST, sfel...@gmail.com wrote: >From: Scott Feldman <sfel...@gmail.com> > >Push bridge-level attributes down to switchdev drivers. This patchset >adds the infrastructure and then pushes, as an example, ageing_time attribute >down from bridge to switchdev (rocker) driver. Add some range-checking >for ageing_time. > ># ip link set dev br0 type bridge ageing_time 1000 > ># ip link set dev br0 type bridge ageing_time 999 >RTNETLINK answers: Numerical result out of range > >Up until now, switchdev attrs where port-level attrs, so the netdev used in >switchdev_attr_set() would be a switch port or bond of switch ports. With >bridge-level attrs, the netdev passed to switchdev_attr_set() is the bridge >netdev. The same recusive algo is used to visit the leaves of the stacked >drivers to set the attr, it's just in this case we start one layer higher in >the stack. One note is not all ports in the bridge may support setting a >bridge-level attribute, so rather than failing the entire set, we'll skip over >those ports returning -EOPNOTSUPP. > >v2->v3: Per Jiri review: push only ageing_time attr down at this time, and >don't pass raw bridge IFLA_BR_* values; rather use new switchdev attr ID for >ageing_time.
Looks fine now. Thanks Scott! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
