Tue, Sep 08, 2015 at 10:47:52PM CEST, vivien.dide...@savoirfairelinux.com wrote:
>Hi!
>
>Current implementations of .switchdev_port_obj_add and .switchdev_port_obj_dump
>must pass the generic switchdev_obj structure instead of a specific one (e.g.
>switchdev_obj_fdb) to the related driver accessors
Petr Cvek writes:
> Dne 8.9.2015 v 22:24 Petr Cvek napsal(a):
>>
>> Did you defined resources somewhere? Actual resources are in
>> "pxa_ir_resources" variable at:
I have them in patch [1], which is exactly the patch you have made yourself.
> I tried to add following patch for new resources, bu
From: Daniel Borkmann
Date: Mon, 07 Sep 2015 16:54:46 +0200
> On 08/17/2015 11:02 PM, David Miller wrote:
> ...
>> I would seriously rather see us do an expensive full copy of the SKB
>> than to have traffic which is unexpectedly invisible to taps.
>
> I've been looking into this issue a bit fur
From: Kolmakov Dmitriy
Date: Mon, 7 Sep 2015 09:05:48 +
> If an attempt to wake up users of broadcast link is made when there is
> no enough place in send queue than it may hang up inside the
> tipc_sk_rcv() function since the loop breaks only after the wake up
> queue becomes empty. This can
From: Barry Song <21cn...@gmail.com>
Date: Mon, 7 Sep 2015 03:15:20 +
> From: Barry Song
>
> Signed-off-by: Barry Song
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http:/
From: Sjoerd Simons
Date: Sun, 6 Sep 2015 17:50:59 +0200
> @@ -161,11 +161,16 @@ int stmmac_mdio_reset(struct mii_bus *bus)
>
> if (!gpio_request(reset_gpio, "mdio-reset")) {
> gpio_direction_output(reset_gpio, active_low ? 1 : 0);
> - ud
From: David Miller
Date: Tue, 08 Sep 2015 22:37:05 -0700 (PDT)
> Applied, thanks.
Actually, reverted, this doesn't even compile.
net/core/fib_rules.c:47:12: error: static declaration of
‘fib_default_rule_pref’ follows non-static declaration
static u32 fib_default_rule_pref(struct fib_rules_op
From: Phil Sutter
Date: Sun, 6 Sep 2015 12:20:58 +0200
> This switches IPv6 policy routing to use the shared
> fib_default_rule_pref() function of IPv4 and DECnet. It is also used in
> multicast routing for IPv4 as well as IPv6.
>
> The motivation for this patch is a complaint about iproute2 be
From: Vivien Didelot
Date: Sat, 5 Sep 2015 21:49:41 -0400
> Remove the unnecessary switchdev.h include from br_netlink.c.
>
> Signed-off-by: Vivien Didelot
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More
From: Vivien Didelot
Date: Sat, 5 Sep 2015 21:27:57 -0400
> Since __vlan_del can return an error code, change its inner function
> __vlan_vid_del to return an eventual error from switchdev_port_obj_del.
>
> Signed-off-by: Vivien Didelot
Applied, thanks.
--
To unsubscribe from this list: send
From: Florian Fainelli
Date: Sat, 5 Sep 2015 13:07:27 -0700
> The comparison check between cur_hw_state and hw_state is currently
> invalid because cur_hw_state is right shifted by G_MISTP_SHIFT, while
> hw_state is not, so we end-up comparing bits 2:0 with bits 7:5, which is
> going to cause an
From: Florian Fainelli Sent: Wednesday, September 09,
2015 11:38 AM
> To: Duan Fugang-B38611; da...@davemloft.net
> Cc: netdev@vger.kernel.org; bhutchi...@solarflare.com
> Subject: Re: [PATCH net-next 1/1] net: fec: add netif status check before
> set mac address
>
> Le 09/08/15 19:42, Fugang Du
Le 09/08/15 19:42, Fugang Duan a écrit :
> There exist one issue by below case that case system hang:
> ifconfig eth0 down
> ifconfig eth0 hw ether 00:10:19:19:81:19
>
> After eth0 down, all fec clocks are gated off. In the .fec_set_mac_address()
> function, it will set new MAC address to register
On Sep. Tuesday 08 (37) 08:06 PM, Florian Fainelli wrote:
> The macro to write 64-bits quantities to the 32-bits register swapped
> the value and offsets arguments, we want to preserve the ordering of the
> arguments with respect to how writel() is implemented for instance:
> value first, offset/ba
The macro to write 64-bits quantities to the 32-bits register swapped
the value and offsets arguments, we want to preserve the ordering of the
arguments with respect to how writel() is implemented for instance:
value first, offset/base second.
Fixes: 246d7f773c13 ("net: dsa: add Broadcom SF2 switc
There exist one issue by below case that case system hang:
ifconfig eth0 down
ifconfig eth0 hw ether 00:10:19:19:81:19
After eth0 down, all fec clocks are gated off. In the .fec_set_mac_address()
function, it will set new MAC address to registers, which causes system hang.
So it needs to add neti
On Tue, Sep 8, 2015 at 10:14 PM, Konrad Rzeszutek Wilk
wrote:
>
> (Removed Linus and Andrew from the To, added Corinna ..)
and resending again without HTML (sorry, thought I had HTML-emails
disabled by default)
>
> On Thu, Sep 3, 2015 at 1:35 AM, David Miller wrote:
>>
>>
>> Another merge window
>On Fri, 2015-09-04 at 09:55 +0200, Sébastien Bocahu wrote:
>> Hi,
>>
>> Any chance this behaviour gets fixed, with either a new firmware or a
>> workaround in the kernel ?
>>
>
>As I said earlier, when we call bnx2_shutdown_chip(), we inform the
>firmware that the driver is shutting down. The
After commit:
atomics: add acquire/release/relaxed variants of some atomic operations
Architectures may only provide {cmp,}xchg_relaxed definitions in
asm/cmpxchg.h. Other variants, such as {cmp,}xchg, may be built in
linux/atomic.h, which means simply including asm/cmpxchg.h may not get
the defi
Dne 8.9.2015 v 22:24 Petr Cvek napsal(a):
>
> Did you defined resources somewhere? Actual resources are in
> "pxa_ir_resources" variable at:
>
> http://lxr.free-electrons.com/source/arch/arm/mach-pxa/devices.c#L386
>
> or this pdata should be moved into specific machine files?
>
I tried
On Tue, Sep 8, 2015 at 6:40 AM, Tycho Andersen
wrote:
> On Sat, Sep 05, 2015 at 09:13:02AM +0200, Michael Kerrisk (man-pages) wrote:
>> On 09/04/2015 10:41 PM, Kees Cook wrote:
>> > On Fri, Sep 4, 2015 at 9:04 AM, Tycho Andersen
>> > wrote:
>> >> This is the final bit needed to support seccomp fi
Corinna Vinschen :
[...]
> - Alternatively I can still reproduce the SEGV in rtl_remove_one
> when trying to rmmod the module, I just don't have the stack dump
> handy while writing this mail. I can show it if needed.
I see it too.
> I debugged this on and off the entire day (tweaking, com
Adding the second 10GbE dt node for APM X-Gene SoC device tree
Signed-off-by: Iyappan Subramanian
---
arch/arm64/boot/dts/apm/apm-storm.dtsi | 28
1 file changed, 28 insertions(+)
diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi
b/arch/arm64/boot/dts/apm/apm-sto
This patch adds support for 2nd 10GbE on APM X-Gene SoC
---
Iyappan Subramanian (2):
driver: net: xgene: Add support for 2nd 10GbE port
dtb: xgene: Add 2nd 10GbE node
arch/arm64/boot/dts/apm/apm-storm.dtsi | 28
drivers/net/ethernet/apm/xgene/xgene_enet_hw.
Adding support for the second 10GbE port on APM X-Gene SoC
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 3 ++-
drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 16
drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 5 +
3 file
> +/* SWITCHDEV_OBJ_PORT_VLAN */
> +struct switchdev_obj_vlan {
> + struct switchdev_obj obj; /* must be first */
> + u16 flags;
> + u16 vid_begin;
> + u16 vid_end;
> +};
I know you give a few examples for where this is done in network code,
but i think container_of() is used
From: Jesper Dangaard Brouer
Date: Fri, 04 Sep 2015 19:00:53 +0200
> +/**
> + * kfree_skb_bulk - bulk free SKBs when refcnt allows to
> + * @skbs: array of SKBs to free
> + * @size: number of SKBs in array
> + *
> + * If SKB refcnt allows for free, then release any auxiliary data
> + *
On 09/08/2015 10:40 PM, Alexei Starovoitov wrote:
when the verifier log is enabled the print_bpf_insn() is doing
bpf_alu_string[BPF_OP(insn->code) >> 4]
and
bpf_jmp_string[BPF_OP(insn->code) >> 4]
where BPF_OP is a 4-bit instruction opcode.
Malformed insns can cause out of bounds access.
Fix it b
Hi!
Current implementations of .switchdev_port_obj_add and .switchdev_port_obj_dump
must pass the generic switchdev_obj structure instead of a specific one (e.g.
switchdev_obj_fdb) to the related driver accessors, because it contains the
object transaction and callback. This is not very convenient
Move the switchdev_obj_ipv4_fib structure out of the switchdev_obj
union.
This lightens the switchdev_obj structure and allows drivers to access
the object transaction and callback directly from a
switchdev_obj_ipv4_fib. This is more consistent and convenient for add
and dump operations.
The patc
Move the switchdev_obj_vlan structure out of the switchdev_obj union.
This lightens the switchdev_obj structure and allows drivers to access
the object transaction and callback directly from a switchdev_obj_vlan.
This is more consistent and convenient for add and dump operations.
The patch update
Move the switchdev_obj_fdb structure out of the switchdev_obj union.
This lightens the switchdev_obj structure and allows drivers to access
the object transaction and callback directly from a switchdev_obj_fdb.
This is more consistent and convenient for add and dump operations.
The patch updates
From: Julien Grall
Date: Thu, 3 Sep 2015 23:59:50 +0100
> The function device_get_mac_address is trying different property names
> in order to get the mac address. To check the return value, the variable
> addr (which contain the buffer pass by the caller) will be re-used. This
> means that if th
when the verifier log is enabled the print_bpf_insn() is doing
bpf_alu_string[BPF_OP(insn->code) >> 4]
and
bpf_jmp_string[BPF_OP(insn->code) >> 4]
where BPF_OP is a 4-bit instruction opcode.
Malformed insns can cause out of bounds access.
Fix it by sizing arrays appropriately.
The bug was found by
Hello,
On Tue, 23 Jun 2015, Andy Gospodarek wrote:
> Add a fib flag called RTNH_F_LINKDOWN to any ipv4 nexthops that are
> reachable via an interface where carrier is off. No action is taken,
> but additional flags are passed to userspace to indicate carrier status.
>
> This also inclu
From: David Ahern
Date: Mon, 31 Aug 2015 14:44:46 -0600
> If anything I should be going straight to fib_table_lookup in the VRF
> driver for this new lookup to get the source address. It knows the
> exact table that should be used and hence can avoid the rules walk +
> local table miss which happ
On Sep 8 02:02, Francois Romieu wrote:
> Francois Romieu :
> [...]
> > Updated patch is on the way.
>
> Fixed memcpy in patch 0001, moved counters allocation from open()
> to probe(), returned open() to its original state but something is
> still wrong: the link does not come up.
I tested and
Dne 3.9.2015 v 08:20 Robert Jarzmik napsal(a):
> Convert the pxa IRDA driver to readl and writel primitives, and remove
> another set of direct registers access. This leaves only the DMA
> registers access, which will be dealt with dmaengine conversion.
Test on magician (nonvanilla, but there shou
From: Eugene Shatokhin
Date: Tue, 1 Sep 2015 17:05:33 +0300
> The race may happen when a device (e.g. YOTA 4G LTE Modem) is
> unplugged while the system is downloading a large file from the Net.
>
> Hardware breakpoints and Kprobes with delays were used to confirm that
> the race does actually
* Mugunthan V N [150907 02:50]:
> In DRA72x EVM, by default slave 1 is connected to the onboard
> phy, but slave 2 pins are also muxed with video input module
> which is controlled by pcf857x gpio and currently to select slave
> 0 to connect to phy gpio hogging is used, but with
> omap2plus_defcon
On 09/08/2015 07:53 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> Problem:
> The ecmp route replace support for ipv6 in the kernel, deletes the
> existing ecmp route too early, ie when it installs the first nexthop.
> If there is an error in installing the subsequent nexthops, its too late
> t
Hello.
On 09/08/2015 03:46 PM, Alexey Brodkin wrote:
Current check of phydev with IS_ERR(phydev) may make not much sense
because of_phy_connect() returns NULL on failure instead of error value.
Still for checking result of phy_connect() IS_ERR() makes perfect sense.
So let's use combined chec
From: Roopa Prabhu
Problem:
The ecmp route replace support for ipv6 in the kernel, deletes the
existing ecmp route too early, ie when it installs the first nexthop.
If there is an error in installing the subsequent nexthops, its too late
to recover the already deleted existing route leaving the f
On Sat, 5 Sep 2015, Jesper Dangaard Brouer wrote:
> The double_cmpxchg without lock prefix still cost 9 cycles, which is
> very fast but still a cost (add approx 19 cycles for a lock prefix).
>
> It is slower than local_irq_disable + local_irq_enable that only cost
> 7 cycles, which the bulking ca
On Tue, 8 Sep 2015, Jesper Dangaard Brouer wrote:
> This test was a single CPU benchmark with no congestion or concurrency.
> But the code was compiled with CONFIG_NUMA=y.
>
> I don't know the slAb code very well, but the kmem_cache_node->list_lock
> looks like a scalability issue. I guess that i
On 09/05/2015 01:00 PM, Jon Masters wrote:
Following up on this thread after finally seeing it...figured I would
send something just for the archive mainly (we discussed this in person
recently at a few different events and I think are aligned already).
On 08/07/2015 08:28 PM, Rafael J. Wysocki
From: BenPope
Signed-off-by: BenPope
---
drivers/net/ethernet/atheros/alx/main.c | 2 ++
drivers/net/ethernet/atheros/alx/reg.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/atheros/alx/main.c
b/drivers/net/ethernet/atheros/alx/main.c
index c8af3ce..bd377a6 100644
> On Sep 7, 2015, at 4:02 AM, David Laight wrote:
>
> Feed:
> int bar(int (*f)[10]) { return sizeof *f; }
> into cc -O2 -S and look at the generated code - returns 40 not 4.
Yes, indeed it does. And with clang too. I guess I was too easily discouraged
when looking for a workable syntax some yea
On Tue, 8 Sep 2015 10:22:32 -0500 (CDT)
Christoph Lameter wrote:
> On Tue, 8 Sep 2015, Jesper Dangaard Brouer wrote:
>
> > Also notice how well bulking maintains the performance when the bulk
> > size increases (which is a soar spot for the slub allocator).
>
> Well you are not actually complet
We may already have gotten a proper fd struct through fdget(), so
whenever we return at the end of an map operation, we need to call
fdput(). However, each map operation from syscall side first probes
CHECK_ATTR() to verify that unused fields in the bpf_attr union are
zero.
In case of malformed in
On Tue, 8 Sep 2015, Jesper Dangaard Brouer wrote:
> Also notice how well bulking maintains the performance when the bulk
> size increases (which is a soar spot for the slub allocator).
Well you are not actually completing the free action in SLAB. This is
simply queueing the item to be freed later
On 09/07/15 22:21, Stephen Rothwell wrote:
> Hi all,
>
> Please do not add material for v4.4 until after v4.3-rc1 is out.
>
> Changes since 20150903:
>
on i386:
net/built-in.o: In function `nf_dup_ipv6':
(.text+0x16dfba): undefined reference to `nf_conntrack_untracked'
net/built-in.o: In funct
There was no verification that an underlying transport exists when creating
a connection, this would cause dereferencing a NULL ptr.
It might happen on sockets that weren't properly bound before attempting to
send a message, which will cause a NULL ptr deref:
[135546.047719] kasan: GPF could be c
Implement a basic approach of bulking in the slab allocator. Simply
use local_irq_{disable,enable} and call single alloc/free in a loop.
This simple implementation approach is surprising fast.
Notice the normal slab fastpath is: 96 cycles (24.119 ns). Below table
show that single object bulking on
Using netlink.h's NLMSG_OK correctly will cause GCC to issue a warning
on systems with 32-bit userland. The definition can easily be changed
to avoid this.
GCC's warning is to flag comparisons where C's implicit "Usual
Arithmetic Conversions" could lead to a surprising result.
Consider this cont
On 9/8/15, 2:55 AM, Nicolas Dichtel wrote:
Le 08/09/2015 02:42, roopa a écrit :
On 9/6/15, 1:46 PM, Roopa Prabhu wrote:
From: Roopa Prabhu
Problem:
The ecmp route replace support for ipv6 in the kernel, deletes the
existing ecmp route too early, ie when it installs the first nexthop.
If there
On Sat, Sep 05, 2015 at 09:13:02AM +0200, Michael Kerrisk (man-pages) wrote:
> On 09/04/2015 10:41 PM, Kees Cook wrote:
> > On Fri, Sep 4, 2015 at 9:04 AM, Tycho Andersen
> > wrote:
> >> This is the final bit needed to support seccomp filters created via the bpf
> >> syscall.
>
> Hmm. Thanks Kees
Commit f48da8b14d04ca87ffcffe68829afd45f926ec6a (xen-netback: fix
unlimited guest Rx internal queue and carrier flapping) introduced a
regression.
The PV frontend in IPXE only places 4 requests on the guest Rx ring.
Since netback required at least (MAX_SKB_FRAGS + 1) slots, IPXE could
not receive
Hi Sergei,
On Tue, 2015-09-08 at 14:20 +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 9/8/2015 11:43 AM, Alexey Brodkin wrote:
>
> > Current check of phydev with IS_ERR(phydev) may make not much sense
> > because of_phy_connect() returns NULL on failure instead of error value.
> >
> > Still for
Hello.
On 9/8/2015 11:43 AM, Alexey Brodkin wrote:
Current check of phydev with IS_ERR(phydev) may make not much sense
because of_phy_connect() returns NULL on failure instead of error value.
Still for checking result of phy_connect() IS_ERR() makes perfect sense.
So let's use combined check
On Tue, Sep 08, 2015 at 12:07:31PM +0100, Julien Grall wrote:
> Hi Wei,
>
> On 07/09/15 17:57, Wei Liu wrote:
> > You might need to rebase you patch. A patch to netback went it recently.
>
> Do you mean 210c34dcd8d912dcc740f1f17625a7293af5cb56 "xen-netback: add
> support for multicast control"?
>
Hi Wei,
On 07/09/15 17:57, Wei Liu wrote:
> You might need to rebase you patch. A patch to netback went it recently.
Do you mean 210c34dcd8d912dcc740f1f17625a7293af5cb56 "xen-netback: add
support for multicast control"?
If so I didn't see any specific issue while rebasing on the latest
linus' ma
The write-combining configuration register SGE_STAT_CFG_A needs to
be configured after FW initializes the adapter, else FW will reset
the configuration
Signed-off-by: Hariprasad Shenai
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-
In commit 0aac3f56d4a63f04 ("cxgb4: Add comment for calculate tx flits
and sge length code") introduced a regression where tx flit calculation
is going wrong, which can lead to data corruption, hang, stall and
write-combining failure. Fixing it.
Signed-off-by: Hariprasad Shenai
---
drivers/net/e
Hi,
This patch series fixes the following:
Patch 1/2 fixes tx flit calculation, which if wrong can lead to
stall, hang, data corrpution, write combining failure. Patch 2/2 fixes
PCI-E write combining stats configuration.
This patch series has been created against net tree and includes
patches o
Le 08/09/2015 02:42, roopa a écrit :
On 9/6/15, 1:46 PM, Roopa Prabhu wrote:
From: Roopa Prabhu
Problem:
The ecmp route replace support for ipv6 in the kernel, deletes the
existing ecmp route too early, ie when it installs the first nexthop.
If there is an error in installing the subsequent ne
Le 08/09/2015 02:01, roopa a écrit :
On 9/7/15, 5:03 AM, Nicolas Dichtel wrote:
[snip]
yes, i had submitted the patch you mention above to fix a slightly different
problem that existed then..which
was introduced by "51ebd3181572 ("ipv6: add support of equal cost multipath
(ECMP)")".
Commit "35f
Call netif_carrier_off() prior to register_netdev(), otherwise
userspace can see incorrect link state.
Signed-off-by: Atsushi Nemoto
---
drivers/net/ethernet/altera/altera_tse_main.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/altera/altera_tse_main.c
b/drivers/n
Current check of phydev with IS_ERR(phydev) may make not much sense
because of_phy_connect() returns NULL on failure instead of error value.
Still for checking result of phy_connect() IS_ERR() makes perfect sense.
So let's use combined check IS_ERR_OR_NULL() that covers both cases.
Cc: Sergei Sh
On Sep 7 23:52, Francois Romieu wrote:
> Corinna Vinschen :
> [...]
> > I have a bit of a problem with this patch. It crashes when loading the
> > driver manually w/ modprobe. For some reason dev_get_stats is called
> > during rtl_init_one and at that time the counters pointer is NULL, so
> > t
Hi David,
On Sep 7 17:00, David Miller wrote:
> From: Corinna Vinschen
> Date: Mon, 7 Sep 2015 11:29:49 +0200
>
> > Still wondering though. Given that the driver never failed before if
> > the counter values couldn't be updated, and given that these counter
> > values only have statistical rel
On Tue, 2015-09-08 at 09:37 +0200, Bjørn Mork wrote:
> Eugene Shatokhin writes:
>
> > I resent the patch to make it separate. What is the status of this now?
>
> One of the many nice features of patchwork is that you don't need to ask
> those questions :)
>
> See http://patchwork.ozlabs.org/pat
Eugene Shatokhin writes:
> I resent the patch to make it separate. What is the status of this now?
One of the many nice features of patchwork is that you don't need to ask
those questions :)
See http://patchwork.ozlabs.org/patch/512856/
I really don't think it's appropriate for me to ack this,
01.09.2015 17:05, Eugene Shatokhin пишет:
The race may happen when a device (e.g. YOTA 4G LTE Modem) is
unplugged while the system is downloading a large file from the Net.
Hardware breakpoints and Kprobes with delays were used to confirm that
the race does actually happen.
The race is on skb_q
74 matches
Mail list logo
