Tue, Sep 08, 2015 at 10:47:52PM CEST, vivien.dide...@savoirfairelinux.com wrote: >Hi! > >Current implementations of .switchdev_port_obj_add and .switchdev_port_obj_dump >must pass the generic switchdev_obj structure instead of a specific one (e.g. >switchdev_obj_fdb) to the related driver accessors, because it contains the >object transaction and callback. This is not very convenient for drivers. > >Instead of having all specific structures included into a switchdev_obj union, >it would be simpler to embed a switchdev_obj structure as the first member of >the more specific ones. That way, a driver can cast the switchdev_obj pointer >to the specific structure and have access to all the information from it. > >As an example, this allows Rocker to change its two FDB accessors: > > rocker_port_fdb_add(rocker_port, obj->trans, &obj->u.fdb); > rocker_port_fdb_dump(rocker_port, obj); > >for these most consistent ones: > > fdb = (struct switchdev_obj_fdb *) obj; > rocker_port_fdb_add(rocker_port, fdb); > rocker_port_fdb_dump(rocker_port, fdb); > >This is what struct netdev_notifier_info and its specific supersets (e.g. >struct netdev_notifier_changeupper_info) do in include/linux/netdevice.h. > >This patchset does that and updates bridge, Rocker and DSA accordingly. > >Note that this patchset was sent as an RFC not to bother David with new >net-next stuffs, but if the changes look good, it is ready to merge. > >Also, please take note that the change sits on top of: >http://patchwork.ozlabs.org/patch/514894/ > >Vivien Didelot (3): > net: switchdev: extract switchdev_obj_vlan > net: switchdev: extract switchdev_obj_ipv4_fib > net: switchdev: extract switchdev_obj_fdb
I like this patchset a lot! I think it is the right way. Thanks for doing this. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
