[PATCH iproute2] ip-link: fix a typo in help message

2015-08-11 Thread Zhang Shengju
fix a typo: "noarp" -> "arp" Signed-off-by: Zhang Shengju --- ip/iplink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iplink.c b/ip/iplink.c index 7e5c466..fa8aa47 100644 --- a/ip/iplink.c +++ b/ip/iplink.c @@ -507,7 +507,7 @@ int iplink_parse(int argc, char **argv, st

[PATCH net-next] net: atl1c: add BQL support

2015-08-11 Thread Ron Angeles
This BQL implementation is mostly derived from its related driver, alx. Tested on AR8131 (rev c0) [1969:1063]. Saturated a 100mbps link with 5 concurrent runs of netperf. Ping latency dropped from 14ms to 3ms. Signed-off-by: Ron Angeles --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 10 ++

[PATCH iproute2 1/3] iplink: add missing link type

2015-08-11 Thread Zhang Shengju
Add missing link type "bridge_slave". Signed-off-by: Zhang Shengju --- ip/iplink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iplink.c b/ip/iplink.c index de5a3c9..7e5c466 100644 --- a/ip/iplink.c +++ b/ip/iplink.c @@ -93,7 +93,7 @@ void iplink_usage(void)

[PATCH iproute2 2/3] iplink: use the short format to print help info

2015-08-11 Thread Zhang Shengju
Allow to print link type usage by: ip link help bridge Signed-off-by: Zhang Shengju --- ip/iplink_bridge.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c index 297160c..1e69960 100644 --- a/ip/iplink_bridge.c +++ b/ip

[PATCH iproute2 0/3] iplink: shortify printing the usage of bridge

2015-08-11 Thread Zhang Shengju
This patch set enables bridge related links to print usage with short format. Or else it is needed to use the following way: ip link { add | del | set } type TYPE help Zhang Shengju (3): iplink: add missing link type iplink: use the short format to print help info iplink: shor

[PATCH iproute2 3/3] iplink: shortify printing the usage of link type

2015-08-11 Thread Zhang Shengju
Allow to print link type usage by: ip link help bridge_slave Signed-off-by: Zhang Shengju --- ip/iplink_bridge_slave.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/ip/iplink_bridge_slave.c b/ip/iplink_bridge_slave.c index a285185..4593872 100644 --- a/ip/

[PATCH net-next 6/6] geneve: Remove duplicate dev list

2015-08-11 Thread Pravin B Shelar
Geneve driver maintains list and hash table of Geneve devices. Following patch removes the duplicate Geneve list and iterate hash table when it is needed. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 28 1 file changed, 16 insertions(+), 12 deletions(-)

[PATCH net-next 4/6] openvswitch: Use Geneve device.

2015-08-11 Thread Pravin B Shelar
With help of tunnel metadata mode OVS can directly use Geneve devices to implement Geneve tunnels. This patch removes all of the OVS specific Geneve code and make OVS use a Geneve net_device. Basic geneve vport is still there to handle compatibility with current userspace application. Signed-off-b

[PATCH net-next 5/6] geneve: Consolidate Geneve functionality in single module.

2015-08-11 Thread Pravin B Shelar
geneve_core module handles send and receive functionality. This way OVS could use the Geneve API. Now with use of tunnel meatadata mode OVS can directly use Geneve netdevice. So there is no need for separate module for Geneve. Following patch consolidates Geneve protocol processing in single module

[PATCH net-next 0/6] Geneve: Add support for tunnel metadata.

2015-08-11 Thread Pravin B Shelar
Following patches adds spport for Geneve tunnel metadata mode. OVS can make use of Geneve net-device with tunnel metadata API from kernel. This also allows us to consolidate Geneve implementation from two kernel modules geneve_core and geneve to single geneve module. geneve_core module was targete

[PATCH net-next 3/6] geneve: Add support to collect tunnel metadata.

2015-08-11 Thread Pravin B Shelar
Following patch create new tunnel flag which enable tunnel metadata collection on given device. These devices can be used by tunnel metadata based routing or by OVS. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 350 --- include/net/gen

[PATCH net-next 1/6] tunnel: introduce udp_tun_rx_dst()

2015-08-11 Thread Pravin B Shelar
Introduce function udp_tun_rx_dst() to initialize tunnel dst on receive path. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c| 18 ++ include/net/dst_metadata.h | 27 +++ include/net/udp_tunnel.h | 3 +++ net/ipv4/ip_gre.c | 21 +

[PATCH net-next 2/6] geneve: Make dst-port configurable.

2015-08-11 Thread Pravin B Shelar
Add netlink interface to configure Geneve UDP port number. So that user can configure it for a Gevene device. Signed-off-by: Pravin B Shelar --- drivers/net/geneve.c | 14 -- include/uapi/linux/if_link.h | 1 + 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/

Re: ipv6_mc_check_mld - kernel BUG at net/core/skbuff.c:1128

2015-08-11 Thread David Miller
From: Linus Lüssing Date: Tue, 11 Aug 2015 23:47:25 +0200 > On Tue, Aug 11, 2015 at 10:51:40PM +0200, Linus Lüssing wrote: >> On Mon, Aug 10, 2015 at 02:56:12PM -0700, Brenden Blanco wrote: >> > Doing some code reading with Alexei, we found a suspect commit, which >> > introduces an skb_get and s

[PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem

2015-08-11 Thread Calvin Owens
Commit 8133534c760d4083 ("net: limit tcp/udp rmem/wmem to SOCK_{RCV,SND}BUF_MIN") modified four sysctls to enforce that the values written to them are not less than SOCK_MIN_{RCV,SND}BUF. That change causes 4096 (or SK_MEM_QUANTUM) to no longer be accepted as a valid value for 'min' in tcp_wmem an

Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp()

2015-08-11 Thread Jonathan Maxwell
> I personally think that drivers need to synchronize such things > internally. They are the only entity which knows when it's "OK" > to do whatever the netpoll method does, and they are also the only > entity which can properly synchronize such checks. Thanks agreed. I am testing the following i

Re: [PATCH v7 5/5] samples/bpf: example of get selected PMU counter value

2015-08-11 Thread Alexei Starovoitov
On 8/6/15 12:02 AM, Kaixu Xia wrote: This is a simple example and shows how to use the new ability to get the selected Hardware PMU counter value. Signed-off-by: Kaixu Xia --- samples/bpf/Makefile | 4 +++ samples/bpf/bpf_helpers.h | 2 ++ samples/bpf/tracex6_kern.c | 26 ++

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-08-11 Thread Alexei Starovoitov
On Tue, Aug 11, 2015 at 06:23:35PM +0200, Phil Sutter wrote: > > I have an unfinished solution in the oven, but being kept busy with > other things for now. The action plan is as follows: > > 1) Introduce IFF_NO_QUEUE net_device->priv_flag. > 2) Have attach_default_qdiscs() and attach_one_default

Re: ipv6_mc_check_mld - kernel BUG at net/core/skbuff.c:1128

2015-08-11 Thread Alexei Starovoitov
On Tue, Aug 11, 2015 at 11:47:25PM +0200, Linus Lüssing wrote: > On Tue, Aug 11, 2015 at 10:51:40PM +0200, Linus Lüssing wrote: > > On Mon, Aug 10, 2015 at 02:56:12PM -0700, Brenden Blanco wrote: > > > Doing some code reading with Alexei, we found a suspect commit, which > > > introduces an skb_get

[PATCHv2 0/3] gianfar: filer changes

2015-08-11 Thread Jakub Kicinski
From: Jakub Kicinski Hi, respinning with examples as requested. Jakub Kicinski (3): gianfar: correct filer table writing gianfar: correct list membership accounting gianfar: remove faulty filer optimizer drivers/net/ethernet/freescale/gianfar_ethtool.c | 345 +-- 1 f

[PATCHv2 3/3] gianfar: remove faulty filer optimizer

2015-08-11 Thread Jakub Kicinski
From: Jakub Kicinski Current filer rule optimization is broken in several ways: (1) Can perform reads/writes beyond end of allocated tables. (gianfar_ethtool.c:1326). (2) It breaks badly for rules with more than 2 specifiers (e.g. matching ip, port, tos). Example: # ethtool -N eth2 f

[PATCHv2 2/3] gianfar: correct list membership accounting

2015-08-11 Thread Jakub Kicinski
From: Jakub Kicinski At a cost of one line let's make sure .count is correct when calling gfar_process_filer_changes(). Signed-off-by: Jakub Kicinski --- v2: no change --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dri

[PATCHv2 1/3] gianfar: correct filer table writing

2015-08-11 Thread Jakub Kicinski
From: Jakub Kicinski MAX_FILER_IDX is the last usable index. Using less-than will already guarantee that one entry for catch-all rule will be left, no need to subtract 1 here. Signed-off-by: Jakub Kicinski --- v2: no change --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 5 ++--- 1 fil

[PATCH net-next 2/2] hv_netvsc: Implement set_channels ethtool op

2015-08-11 Thread Andrew Schwartzmeyer
This enables the use of ethtool --set-channels devname combined N to change the number of vRSS queues. Separate rx, tx, and other parameters are not supported. The maximum is rsscap.num_recv_que. It passes the given value to rndis_filter_device_add through the device_info->num_chn field. If the pr

[PATCH net-next 1/2] hv_netvsc: Set vRSS with num_chn in RNDIS filter

2015-08-11 Thread Andrew Schwartzmeyer
Uses device_info->num_chn to pass user provided number of vRSS queues (from ethtool --set-channels) to rndis_filter_device_add. If nonzero and less than the maximum, set net_device->num_chn to the given value; else default to prior algorithm. Always initialize struct device_info to 0, otherwise no

[PATCHv3 net-next 03/10] ipv6: Export nf_ct_frag6_gather()

2015-08-11 Thread Joe Stringer
Signed-off-by: Joe Stringer Acked-by: Thomas Graf --- net/ipv6/netfilter/nf_conntrack_reasm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c index 6d02498..701cd2b 100644 --- a/net/ipv6/netfilter/nf_conntrack

[PATCHv3 net-next 02/10] openvswitch: Move MASKED* macros to datapath.h

2015-08-11 Thread Joe Stringer
This will allow the ovs-conntrack code to reuse these macros. Signed-off-by: Joe Stringer Acked-by: Thomas Graf --- net/openvswitch/actions.c | 52 ++ net/openvswitch/datapath.h | 4 2 files changed, 29 insertions(+), 27 deletions(-) diff --gi

[PATCHv3 net-next 01/10] openvswitch: Serialize acts with original netlink len

2015-08-11 Thread Joe Stringer
Previously, we used the kernel-internal netlink actions length to calculate the size of messages to serialize back to userspace. However,the sw_flow_actions may not be formatted exactly the same as the actions on the wire, so store the original actions length when de-serializing and re-use the orig

[PATCHv3 net-next 04/10] dst: Add __skb_dst_copy() variation

2015-08-11 Thread Joe Stringer
This variation on skb_dst_copy() doesn't require two skbs. Signed-off-by: Joe Stringer --- include/net/dst.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/include/net/dst.h b/include/net/dst.h index 2578811..0539940 100644 --- a/include/net/dst.h +++ b/include/net/

[PATCHv3 net-next 00/10] OVS conntrack support

2015-08-11 Thread Joe Stringer
The goal of this series is to allow OVS to send packets through the Linux kernel connection tracker, and subsequently match on fields populated by conntrack. This version addresses the feedback from v2, mostly going over the dst reference taking and skb metadata to check that they are restored cor

[PATCHv3 net-next 08/10] netfilter: connlabels: Export setting connlabel length

2015-08-11 Thread Joe Stringer
Add functions to change connlabel length into nf_conntrack_labels.c so they may be reused by other modules like OVS and nftables without needing to jump through xt_match_check() hoops. Suggested-by: Florian Westphal Signed-off-by: Joe Stringer --- v2: Protect connlabel modification with spinlock

[PATCHv3 net-next 07/10] netfilter: Always export nf_connlabels_replace()

2015-08-11 Thread Joe Stringer
The following patches will reuse this code from OVS. Signed-off-by: Joe Stringer --- net/netfilter/nf_conntrack_labels.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/netfilter/nf_conntrack_labels.c b/net/netfilter/nf_conntrack_labels.c index bb53f12..daa7c13 100644 --- a/net/netfilt

[PATCHv3 net-next 05/10] openvswitch: Add conntrack action

2015-08-11 Thread Joe Stringer
Expose the kernel connection tracker via OVS. Userspace components can make use of the "ct()" action, followed by "recirculate", to populate the conntracking state in the OVS flow key, and subsequently match on that state. Example ODP flows allowing traffic from 1->2, only replies from 2->1: in_po

[PATCHv3 net-next 06/10] openvswitch: Allow matching on conntrack mark

2015-08-11 Thread Joe Stringer
From: Justin Pettit Allow matching and setting the conntrack mark field. As with conntrack state and zone, these are populated by executing the ct() action. Unlike these, the ct_mark is also a writable field. The set_field() action may be used to modify the mark, which will take effect on the mos

[PATCHv3 net-next 10/10] openvswitch: Allow attaching helpers to ct action

2015-08-11 Thread Joe Stringer
Add support for using conntrack helpers to assist protocol detection. The new OVS_CT_ATTR_HELPER attribute of the ct action specifies a helper to be used for this connection. Example ODP flows allowing FTP connections from ports 1->2: in_port=1,tcp,action=ct(helper=ftp,commit),2 in_port=2,tcp,ct_s

[PATCHv3 net-next 09/10] openvswitch: Allow matching on conntrack label

2015-08-11 Thread Joe Stringer
Allow matching and setting the conntrack label field. As with ct_mark, this is populated by executing the ct() action, and is a writable field. The set_field() action may be used to modify the label, which will take effect on the most recent conntrack entry. E.g.: actions:ct(zone=1),set_field(1->c

[PATCH 4/6] dlm: use sctp 1-to-1 API

2015-08-11 Thread Marcelo Ricardo Leitner
DLM is using 1-to-many API but in a 1-to-1 fashion. That is, it's not needed but this causes it to use sctp_do_peeloff() to mimic an kernel_accept() and this causes a symbol dependency on sctp module. By switching it to 1-to-1 API we can avoid this dependency and also reduce quite a lot of SCTP-sp

[PATCH 1/6] dlm: fix connection stealing if using SCTP

2015-08-11 Thread Marcelo Ricardo Leitner
When using SCTP and accepting a new connection, DLM currently validates if the peer trying to connect to it is one of the cluster nodes, but it doesn't check if it already has a connection to it or not. If it already had a connection, it will be overwritten, and the new one will be used for writes

[PATCH 3/6] dlm: fix not reconnecting on connecting error handling

2015-08-11 Thread Marcelo Ricardo Leitner
If we don't clear that bit, lowcomms_connect_sock() will not schedule another attempt, and no further attempt will be done. Signed-off-by: Marcelo Ricardo Leitner --- fs/dlm/lowcomms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 749deb3b69b293

[PATCH 0/6] use sctp 1-to-1 API

2015-08-11 Thread Marcelo Ricardo Leitner
Cc'ing netdev and sctp maintainers so we keep everyone in the loop. This series will be handled via dlm tree now. Currently, loading dlm module will require loading sctp module too and this is not wanted. This link is caused only by the usage of sctp_do_peeloff(), and just it. Previously this ope

[PATCH 2/6] dlm: fix race while closing connections

2015-08-11 Thread Marcelo Ricardo Leitner
When a connection have issues DLM may need to close it. Therefore we should also cancel pending workqueues for such connection at that time, and not just when dlm is not willing to use this connection anymore. Also, if we don't clear CF_CONNECT_PENDING flag, the error handling routines won't be a

[PATCH 5/6] dlm: replace BUG_ON with a less severe handling

2015-08-11 Thread Marcelo Ricardo Leitner
BUG_ON() is a severe action for this case, specially now that DLM with SCTP will use 1 socket per association. Instead, we can just close the socket on this error condition and return from the function. Also move the check to an earlier stage as it won't change and thus we can abort as soon as pos

[PATCH 6/6] dlm: fix reconnecting but not sending data

2015-08-11 Thread Marcelo Ricardo Leitner
There are cases on which lowcomms_connect_sock() is called directly, which caused the CF_WRITE_PENDING flag to not bet set upon reconnect, specially on send_to_sock() error handling. On this last, the flag was already cleared and no further attempt on transmitting would be done. As dlm tends to co

Re: [PATCH net-next] documentation: bring vxlan documentation more up-to-date

2015-08-11 Thread Rick Jones
On 08/11/2015 03:09 PM, Stephen Hemminger wrote: On Tue, 11 Aug 2015 13:47:16 -0700 (PDT) r...@tardy.usa.hp.com (Rick Jones) wrote: + # ip link add vxlan0 type vxlan id 42 group 239.1.1.1 dev eth1 + +This creates a new device named vxlan0. The device uses the +multicast group 239.1.1.1 over e

Re: [PATCH net-next] documentation: bring vxlan documentation more up-to-date

2015-08-11 Thread Stephen Hemminger
On Tue, 11 Aug 2015 13:47:16 -0700 (PDT) r...@tardy.usa.hp.com (Rick Jones) wrote: > + # ip link add vxlan0 type vxlan id 42 group 239.1.1.1 dev eth1 > + > +This creates a new device named vxlan0. The device uses the > +multicast group 239.1.1.1 over eth1 to handle traffic for which there > +is

Re: ipv6_mc_check_mld - kernel BUG at net/core/skbuff.c:1128

2015-08-11 Thread Linus Lüssing
On Tue, Aug 11, 2015 at 10:51:40PM +0200, Linus Lüssing wrote: > On Mon, Aug 10, 2015 at 02:56:12PM -0700, Brenden Blanco wrote: > > Doing some code reading with Alexei, we found a suspect commit, which > > introduces an skb_get and skb_may_pull of the same skb, which leads to the > > BUG > > when

[PATCH net-next 2/3] mpls: consistently use u8 to store number of labels

2015-08-11 Thread Roopa Prabhu
From: Roopa Prabhu change all types representing number of labels to u8 to be consistent. This also changes labels to u8 in the light weight mpls_tunnel_encap structure. This is because the light weight mpls iptunnel code shares some of the label encoding functions like nla_get/put_labels with t

[PATCH net-next 1/3] mpls: move mpls_route nexthop fields to a new nhlfe struct

2015-08-11 Thread Roopa Prabhu
From: Roopa Prabhu moves mpls_route nexthop fields to a new mpls_nhlfe struct. mpls_nhlfe represents a mpls nexthop label forwarding entry. It prepares mpls route structure for multipath support. In the process moves mpls_route structure into internal.h. Moves some of the code from mpls_route_ad

[PATCH net-next 0/3] mpls: multipath support

2015-08-11 Thread Roopa Prabhu
From: Roopa Prabhu This patch series adds multipath support to mpls routes. resembles ipv4 multipath support. The multipath route nexthop selection algorithm is the same code as in ipv4 fib code. I understand that the multipath algorithm in ipv4 is undergoing some changes and will move mpls to

[PATCH net-next 3/3] mpls: add multipath route support

2015-08-11 Thread Roopa Prabhu
From: Roopa Prabhu Adds support for MPLS multipath routes. supports parse/fill of RTA_MULTIPATH netlink attribute for multipath routes similar to ipv4 fib. Mostly based on multipath handling in ipv4 fib code. The multipath route nexthop selection algorithm is the same code as in ipv4 fib. This

Re: pull request: bluetooth 2015-08-11

2015-08-11 Thread David Miller
From: Johan Hedberg Date: Tue, 11 Aug 2015 23:04:06 +0300 > Here's an important regression fix for the 4.2-rc series that ensures > user space isn't given invalid LTK values. The bug essentially prevents > the encryption of subsequent LE connections, i.e. makes it impossible to > pair devices ove

Re: [BUG] net/ipv4: inconsistent routing table

2015-08-11 Thread David Miller
From: Alexander Duyck Date: Tue, 11 Aug 2015 13:52:27 -0700 > On 08/10/2015 04:50 AM, Hannes Frederic Sowa wrote: >>> 4. document it >> I prefer that one :) > > Yeah, me too. The fact is things have worked this way up until now > and I suspect the reason why this hasn't been reported until now

Re: ipv6_mc_check_mld - kernel BUG at net/core/skbuff.c:1128

2015-08-11 Thread Linus Lüssing
On Mon, Aug 10, 2015 at 02:56:12PM -0700, Brenden Blanco wrote: > Doing some code reading with Alexei, we found a suspect commit, which > introduces an skb_get and skb_may_pull of the same skb, which leads to the BUG > when skb->len == len. Urgh, didn't know that pskb_may_pull() doesn't like an sk

Re: [BUG] net/ipv4: inconsistent routing table

2015-08-11 Thread Alexander Duyck
On 08/10/2015 04:50 AM, Hannes Frederic Sowa wrote: Hello, Zang MingJie writes: Here comes several options: 1. reject local next hop w/ EINVAL 2. delete route when local next hop removed Will also cause some people to complain. 3. transition between RT_SCOPE_HOST amd RT_SCOPE_LINK I don'

Re: [net-next PATCH] net: Document xfrm4_gc_thresh and xfrm6_gc_thresh

2015-08-11 Thread David Miller
From: Alexander Duyck Date: Tue, 11 Aug 2015 13:35:01 -0700 > This change adds documentation for xfrm4_gc_thresh and xfrm6_gc_thresh > based on the comments in commit eeb1b73378b56 ("xfrm: Increase the garbage > collector threshold"). > > Signed-off-by: Alexander Duyck Thanks, I'll let Steffen

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-11 Thread David Miller
From: Robert Richter Date: Tue, 11 Aug 2015 22:12:37 +0200 > On 11.08.15 13:04:55, David Daney wrote: >> >In the future it might be better structured to try and get the OF >> >node, and if that fails then try and use the ACPI method to obtain >> >these values. >> >> Our current approach, as you

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-11 Thread David Miller
From: David Daney Date: Tue, 11 Aug 2015 13:04:55 -0700 > You seem to be recommending precedence for OF. It should be > consistent across all drivers/sub-systems, so do you really think > that OF before ACPI is the way to go? I just think it's more hackish to test acpi_disabled than to simply s

[PATCH net-next] documentation: bring vxlan documentation more up-to-date

2015-08-11 Thread Rick Jones
From: Rick Jones A few things have changed since the previous version of the vxlan documentation was written, so update it and correct some grammer and such while we are at it. Signed-off-by: Rick Jones diff --git a/Documentation/networking/vxlan.txt b/Documentation/networking/vxlan.txt index

[net-next PATCH] net: Document xfrm4_gc_thresh and xfrm6_gc_thresh

2015-08-11 Thread Alexander Duyck
This change adds documentation for xfrm4_gc_thresh and xfrm6_gc_thresh based on the comments in commit eeb1b73378b56 ("xfrm: Increase the garbage collector threshold"). Signed-off-by: Alexander Duyck --- Documentation/networking/ip-sysctl.txt | 10 ++ 1 file changed, 10 insertions(+)

Re: Question on behavior of tg3_self_test() (ethtool -t on tg3 driver)

2015-08-11 Thread Michael Chan
On Tue, 2015-08-11 at 14:24 -0500, Douglas Miller wrote: > Yes, the "wrap plugs" are the loopback cables/plugs. It is my > understanding that the "offline" tests do not require anything to be > plugged into the ports, as they do not in any way touch the "external" > port. They perform an "inter

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-11 Thread Robert Richter
On 11.08.15 13:04:55, David Daney wrote: > >In the future it might be better structured to try and get the OF > >node, and if that fails then try and use the ACPI method to obtain > >these values. > > Our current approach, as you can see in the patch, is the opposite. If ACPI > is being used, pre

Re: [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects

2015-08-11 Thread Vivien Didelot
Hi David, On 15-08-11 12:05:18, David Miller wrote: > From: David Miller > Date: Tue, 11 Aug 2015 12:00:27 -0700 (PDT) > > > Ok, if you guys really want me to I'll do the revert-reapply thing. > > Done. Thank you, this is much appreciated. -v -- To unsubscribe from this list: send the line "u

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-11 Thread David Daney
On 08/11/2015 11:49 AM, David Miller wrote: From: David Daney Date: Mon, 10 Aug 2015 17:58:35 -0700 Change from v1: Drop PHY binding part, use fwnode_property* APIs. The first patch (1/2) rearranges the existing code a little with no functional change to get ready for the second. The second

pull request: bluetooth 2015-08-11

2015-08-11 Thread Johan Hedberg
Hi Dave, Here's an important regression fix for the 4.2-rc series that ensures user space isn't given invalid LTK values. The bug essentially prevents the encryption of subsequent LE connections, i.e. makes it impossible to pair devices over LE. Let me know if there are any issues pulling. Thanks

Re: [PATCH 04/10] batman-adv: Make NC capability changes atomic

2015-08-11 Thread Sergei Shtylyov
On 08/11/2015 07:35 PM, Antonio Quartulli wrote: From: Linus Lüssing Bitwise OR/AND assignments in C aren't guaranteed to be atomic. One OGM handler might undo the set/clear of a specific bit from another handler run in between. Fix this by using the atomic set_bit()/clear_bit()/test_bit() fu

Re: [PATCH 03/10] batman-adv: Make DAT capability changes atomic

2015-08-11 Thread Sergei Shtylyov
Hello. On 08/11/2015 07:35 PM, Antonio Quartulli wrote: From: Linus Lüssing Bitwise OR/AND assignments in C aren't guaranteed to be atomic. One OGM handler might undo the set/clear of a specific bit from another handler run in between. Fix this by using the atomic set_bit()/clear_bit()/t

Re: Question on behavior of tg3_self_test() (ethtool -t on tg3 driver)

2015-08-11 Thread Douglas Miller
Thanks Michael for getting back to me. Yes, the "wrap plugs" are the loopback cables/plugs. It is my understanding that the "offline" tests do not require anything to be plugged into the ports, as they do not in any way touch the "external" port. They perform an "internal loopback" test which

Re: [PATCH] iproute2: Add support for VRF device

2015-08-11 Thread Nikolay Aleksandrov
Hi, Since there will be another version a few minor nits below, > On Aug 10, 2015, at 8:50 PM, David Ahern wrote: > > Allow user to create a vrf device and specify its table binding. > Based on the iplink_vlan implementation. > > Signed-off-by: Shrijeet Mukherjee > Signed-off-by: David Ahern

Re: [PATCH] net: fs_enet: mask interrupts for TX partial frames.

2015-08-11 Thread David Miller
From: Christophe Leroy Date: Tue, 11 Aug 2015 12:11:03 +0200 (CEST) > We are not interested in interrupts for partially transmitted frames. > Unlike SCC and FCC, the FEC doesn't handle the I bit in buffer > descriptors, instead it defines two interrupt bits, TXB and TXF. > > We have to mask TXB

Re: [PATCH] net: fs_enet: explicitly remove I flag on TX partial frames

2015-08-11 Thread David Miller
From: Christophe Leroy Date: Tue, 11 Aug 2015 12:11:00 +0200 (CEST) > We are not interested in interrupts for partially transmitted frames, > we have to clear BD_ENET_TX_INTR explicitly otherwise it may remain > from a previously used descriptor. > > Signed-off-by: Christophe Leroy Applied. --

Re: [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects

2015-08-11 Thread David Miller
From: David Miller Date: Tue, 11 Aug 2015 12:00:27 -0700 (PDT) > Ok, if you guys really want me to I'll do the revert-reapply thing. Done. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

RE: [Intel-wired-lan] [PATCH v2 1/2] igb: Teardown SR-IOV before unregister_netdev()

2015-08-11 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alex Williamson > Sent: Wednesday, July 29, 2015 1:38 PM > To: intel-wired-...@lists.osuosl.org; da...@davemloft.net; Kirsher, > Jeffrey T > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: [

Re: [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects

2015-08-11 Thread David Miller
From: David Miller Date: Tue, 11 Aug 2015 11:52:49 -0700 (PDT) > From: Vivien Didelot > Date: Tue, 11 Aug 2015 14:18:42 -0400 (EDT) > >> On Aug 11, 2015, at 2:07 PM, David da...@davemloft.net wrote: >> >>> From: Florian Fainelli >>> Date: Tue, 11 Aug 2015 11:03:35 -0700 >>> Put differen

Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad

2015-08-11 Thread Sergei Shtylyov
Hello. On 08/11/2015 05:35 PM, Liviu Dudau wrote: On some embedded systems the EEPROM does not contain a valid MAC address. In that case it is better to fallback to a generated mac address and let init scripts fix the value later. Reported-by: Liviu Dudau Signed-off-by: Stephen Hemminger [

Re: [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects

2015-08-11 Thread David Miller
From: Vivien Didelot Date: Tue, 11 Aug 2015 14:18:42 -0400 (EDT) > On Aug 11, 2015, at 2:07 PM, David da...@davemloft.net wrote: > >> From: Florian Fainelli >> Date: Tue, 11 Aug 2015 11:03:35 -0700 >> >>> Put differently, my question is how do you value not rewriting >>> history vs. breaking b

Re: [PATCH net-next 6/9] net: Fix up inet_addr_type checks

2015-08-11 Thread David Miller
From: David Ahern Date: Tue, 11 Aug 2015 12:18:20 -0600 > The intent here was to default to current behavior and to keep the > details of that in one place. If you prefer table id to always enter > with the right value I can make that happen. I think it looks better that way. People reading ind

Re: [PATCH v3 net-next] bpf: s390: Fix build error caused by the struct bpf_array member name changed

2015-08-11 Thread David Miller
From: Kaixu Xia Date: Tue, 11 Aug 2015 08:56:51 + > There is a build error that "'struct bpf_array' has no member > named 'prog'" on s390. In commit 2a36f0b92eb6 ("bpf: Make the > bpf_prog_array_map more generic"), the member 'prog' of struct > bpf_array is replaced by 'ptrs'. So this patch f

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-11 Thread David Miller
From: David Daney Date: Mon, 10 Aug 2015 17:58:35 -0700 > Change from v1: Drop PHY binding part, use fwnode_property* APIs. > > The first patch (1/2) rearranges the existing code a little with no > functional change to get ready for the second. The second (2/2) does > the actual work of adding

Re: [PATCH 3/3] gianfar: remove faulty filer optimizer

2015-08-11 Thread David Miller
From: Jakub Kiciński Date: Tue, 11 Aug 2015 16:51:09 +0200 > On Tue, 11 Aug 2015 14:00:23 +, Manoil Claudiu wrote: >> >-Original Message- >> >From: Jakub Kicinski [mailto:moorr...@wp.pl] >> >Sent: Monday, August 10, 2015 11:12 PM >> >To: David S. Miller; Manoil Claudiu-B08782 >> >Cc:

Re: [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects

2015-08-11 Thread Vivien Didelot
Hi David, On Aug 11, 2015, at 2:07 PM, David da...@davemloft.net wrote: > From: Florian Fainelli > Date: Tue, 11 Aug 2015 11:03:35 -0700 > >> Put differently, my question is how do you value not rewriting >> history vs. breaking bisectability (by accident of course)? > > I never will rewrite h

Re: [PATCH net-next 6/9] net: Fix up inet_addr_type checks

2015-08-11 Thread David Ahern
On 8/11/15 12:14 PM, David Miller wrote: From: David Ahern Date: Mon, 10 Aug 2015 11:50:33 -0600 @@ -427,6 +428,7 @@ int inet_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) struct net *net = sock_net(sk); unsigned short snum; int chk_addr_ret; +

Re: [PATCH net-next 6/9] net: Fix up inet_addr_type checks

2015-08-11 Thread David Miller
From: David Ahern Date: Mon, 10 Aug 2015 11:50:33 -0600 > @@ -427,6 +428,7 @@ int inet_bind(struct socket *sock, struct sockaddr > *uaddr, int addr_len) > struct net *net = sock_net(sk); > unsigned short snum; > int chk_addr_ret; > + int tb_id = 0; > int err; > >

Re: [PATCH net-next 1/9] net: Introduce VRF related flags and helpers

2015-08-11 Thread David Miller
From: David Ahern Date: Mon, 10 Aug 2015 11:50:28 -0600 > +static inline int vrf_dev_table(const struct net_device *dev) > +{ > + int tb_id = 0; > + > + rcu_read_lock(); > + tb_id = vrf_dev_table_rcu(dev); > + rcu_read_unlock(); > + > + return tb_id; > +} The initialization o

Re: [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects

2015-08-11 Thread David Miller
From: Florian Fainelli Date: Tue, 11 Aug 2015 11:03:35 -0700 > Put differently, my question is how do you value not rewriting > history vs. breaking bisectability (by accident of course)? I never will rewrite history, ever. Too many people clone my tree and depend upon it. -- To unsubscribe fr

Re: [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects

2015-08-11 Thread Florian Fainelli
On 11/08/15 10:38, David Miller wrote: > From: Vivien Didelot > Date: Tue, 11 Aug 2015 12:25:06 -0400 (EDT) > >> I can work on fixup patches to restore v3 changes on top of v2, but this >> won't fix the bisectability issue. >> >> Instead of fixing individual portions, reverting the merge commit >

RE: VxLAN support question

2015-08-11 Thread Andrew Qu
Hi Alexei, I support using mcast group for all VNIs in control plane/data plane. But in case there is no mcast routing enabled, I need to support P2P vxlan underlay, hence use of the configuration I showed. Thanks for the confirmation. By the way, any informational doc I can read to know about t

REDIRECT and UDP in client

2015-08-11 Thread Madhan
Hi All , I am trying to redirect the udp packet to particular port where I run my proxy (SOCKS) . I am supposed to obtain the original destination ipaddress of the client to add to the data field of socks message as per the RFC . However , when I use REDIRECT chain as it sets the dest addr to the

Re: [PATCH net-next v2] tcp: reduce cpu usage under tcp memory pressure when SO_SNDBUF is set

2015-08-11 Thread Jason Baron
On 08/11/2015 12:12 PM, Eric Dumazet wrote: > On Tue, 2015-08-11 at 11:03 -0400, Jason Baron wrote: > >> >> Yes, so the test case I'm using to test against is somewhat contrived. >> In that I am simply allocating around 40,000 sockets that are idle to >> create a 'permanent' memory pressure in t

Re: Question on behavior of tg3_self_test() (ethtool -t on tg3 driver)

2015-08-11 Thread Michael Chan
On Tue, 2015-08-11 at 10:59 -0500, Douglas Miller wrote: > (Sorry if you got several duplicates, am trying to work through rejected > messages due to supposed HTML content) > > The following behavior is being observed when running "ethtool -t > offline" on ports on the Broadcom BCM5719 adapter

Re: [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects

2015-08-11 Thread David Miller
From: Vivien Didelot Date: Tue, 11 Aug 2015 12:25:06 -0400 (EDT) > I can work on fixup patches to restore v3 changes on top of v2, but this > won't fix the bisectability issue. > > Instead of fixing individual portions, reverting the merge commit > f1d5ca4: "Merge branch 'mv88e6xxx-switchdev-fdb

Re: [Xen-devel] [PATCH v3 0/9] Use correctly the Xen memory terminologies

2015-08-11 Thread David Vrabel
On 07/08/15 17:34, Julien Grall wrote: > Hi all, > > This patch series aims to use the memory terminologies described in > include/xen/mm.h [1] for Linux xen code. Applied to for-linus-4.3, thanks. David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messag

Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp()

2015-08-11 Thread David Miller
From: Jonathan Maxwell Date: Tue, 11 Aug 2015 15:53:18 +1000 >> What if the carrier check passes, and then the chip reset starts on >> another cpu? You'll have the same problem. > > Okay, let me see if I can come up with a better way to mitigate this. I personally think that drivers need to sy

[iproute PATCH] ip-link: fix minor typo in manpage

2015-08-11 Thread Phil Sutter
Change '-human-readble' to '-human-readable'. Signed-off-by: Phil Sutter --- man/man8/ip-link.8.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index c123fcc..1c312af 100644 --- a/man/man8/ip-link.8.in +++ b/man/man8/ip-link.8.

Re: [PATCH v2 net-next] sky2: use random address if EEPROM is bad

2015-08-11 Thread Stephen Hemminger
On Tue, 11 Aug 2015 15:35:56 +0100 Liviu Dudau wrote: > On some embedded systems the EEPROM does not contain a valid MAC address. > In that case it is better to fallback to a generated mac address and > let init scripts fix the value later. > > Reported-by: Liviu Dudau > Signed-off-by: Stephen

Re: [PATCH 0/2] of: fsl/fman: reuse the fixed node parsing code

2015-08-11 Thread Stas Sergeev
11.08.2015 19:33, Madalin-Cristian Bucur пишет: + Joakim, Shaohui -Original Message- From: Stas Sergeev [mailto:s...@list.ru] 08.08.2015 20:32, Florian Fainelli пишет: CC'ing Stas, Hi. Le 08/05/15 07:42, Madalin Bucur a écrit : The FMan MAC configuration code needs the speed and d

Re: [PATCH 2/4] batman-adv: fix kernel crash due to missing NULL checks

2015-08-11 Thread Antonio Quartulli
On 05/08/15 15:15, David Laight wrote: > So is this test just hiding anoter bug somewhere?? Hi David and thanks for your feedback. The point is that we got several bug reports of kernel crashes due to NULL pointer deferences in these lines and fter having debugged this problem for quite a while w

[PATCH 10/10] batman-adv: Fix potentially broken skb network header access

2015-08-11 Thread Antonio Quartulli
From: Linus Lüssing The two commits noted below added calls to ip_hdr() and ipv6_hdr(). They need a correctly set skb network header. Unfortunately we cannot rely on the device drivers to set it for us. Therefore setting it in the beginning of the according ndo_start_xmit handler. Fixes: 1d8ab8

[PATCH 09/10] batman-adv: remove broadcast packets scheduled for purged outgoing if

2015-08-11 Thread Antonio Quartulli
From: Simon Wunderlich When an interface is purged, the broadcast packets scheduled for this interface should get purged as well. Signed-off-by: Simon Wunderlich Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- net/batman-adv/send.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH 02/10] batman-adv: Avoid u32 overflow during gateway select

2015-08-11 Thread Antonio Quartulli
From: Ruben Wisniewski The gateway selection based on fast connections is using a single value calculated from the average tq (0-255) and the download bandwidth (in 100Kibit). The formula for the first step (tq ** 2 * 1 * bandwidth) tends to overflow a u32 with low bandwidth settings like 50

[PATCH 04/10] batman-adv: Make NC capability changes atomic

2015-08-11 Thread Antonio Quartulli
From: Linus Lüssing Bitwise OR/AND assignments in C aren't guaranteed to be atomic. One OGM handler might undo the set/clear of a specific bit from another handler run in between. Fix this by using the atomic set_bit()/clear_bit()/test_bit() functions. Fixes: 3f4841ffb336 ("batman-adv: tvlv - a

  1   2   >