Re: [PATCH net] net: thunderx: remove effective "default y" from Kconfig if ARCH_THUNDER=y

2015-08-06 Thread David Miller
From: Ian Campbell Date: Tue, 4 Aug 2015 20:25:55 +0100 > As well as for kernels built only for ThunderX ARCH_THUNDERX is also enabled > for kernels which support multiple platforms (such as distro kernels). Thus > "default ARCH_THUNDER" is inappropriate. > > I believe default m is equally frow

Re: [PATCH net 1/2] bridge: netlink: account for the IFLA_BRPORT_PROXYARP attribute size and policy

2015-08-06 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 4 Aug 2015 19:06:32 +0200 > From: Nikolay Aleksandrov > > The attribute size wasn't accounted for in the get_slave_size() callback > (br_port_get_slave_size) when it was introduced, so fix it now. Also add > a policy entry for it in br_port_policy. > > Sig

Re: [PATCH net 2/2] bridge: netlink: account for the IFLA_BRPORT_PROXYARP_WIFI attribute size and policy

2015-08-06 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 4 Aug 2015 19:06:33 +0200 > From: Nikolay Aleksandrov > > The attribute size wasn't accounted for in the get_slave_size() callback > (br_port_get_slave_size) when it was introduced, so fix it now. Also add > a policy entry for it in br_port_policy. > > Sig

Re: pull-request: wireless-drivers 2015-08-04

2015-08-06 Thread David Miller
From: Kalle Valo Date: Tue, 04 Aug 2015 19:54:09 +0300 > here are few small fixes I would like to get to 4.2. Please let me know > if there are any problems. Pulled, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] net: pktgen: don't abuse current->state in pktgen_thread_worker()

2015-08-06 Thread David Miller
From: Oleg Nesterov Date: Tue, 4 Aug 2015 18:33:34 +0200 > Commit 1fbe4b46caca "net: pktgen: kill the Wait for kthread_stop > code in pktgen_thread_worker()" removed (in particular) the final > __set_current_state(TASK_RUNNING) and I didn't notice the previous > set_current_state(TASK_INTERRUPTIB

Re: [PATCH v3] net_dbg_ratelimited: turn into no-op when !DEBUG

2015-08-06 Thread David Miller
From: "Jason A. Donenfeld" Date: Tue, 4 Aug 2015 18:26:19 +0200 > The pr_debug family of functions turns into a no-op when -DDEBUG is not > specified, opting instead to call "no_printk", which gets compiled to a > no-op (but retains gcc's nice warnings about printf-style arguments). > > The pro

Re: [PATCH v2] xen/netback: Wake dealloc thread after completing zerocopy work

2015-08-06 Thread David Miller
From: Ross Lagerwall Date: Tue, 4 Aug 2015 15:40:59 +0100 > Waking the dealloc thread before decrementing inflight_packets is racy > because it means the thread may go to sleep before inflight_packets is > decremented. If kthread_stop() has already been called, the dealloc > thread may wait forev

[RFC PATCH] net: ipv4: increase dhcp inter device timeout

2015-08-06 Thread Mugunthan V N
When a system has multiple ethernet devices and during DHCP request (for using NFS), the system waits only for HZ/2 which is 500mS before switching to another interface for DHCP. There are some routers (Ex: Trendnet routers) which responds to DHCP request at about 560mS. When the system has only o

[PATCH net-next] net: fec: fix the race between xmit and bdp reclaiming path

2015-08-06 Thread Kevin Hao
When we transmit a fragmented skb, we may run into a race like the following scenario (assume txq->cur_tx is next to txq->dirty_tx): cpu 0 cpu 1 fec_enet_txq_submit_skb reserve a bdp for the first fragment fec_enet_txq_submit_frag_skb

[PULL] vhost: fix for 4.2

2015-08-06 Thread Michael S. Tsirkin
The following changes since commit 74d33293e467df61de1b1d8b2fbe29e550dec33b: Linux 4.2-rc5 (2015-08-02 18:34:55 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to df4198b1e0c4a7d1adde1e5c2c

Re: [PATCH net-next v2] af_mpls: add null dev check in find_outdev

2015-08-06 Thread David Miller
From: Roopa Prabhu Date: Tue, 4 Aug 2015 06:36:24 -0700 > From: Roopa Prabhu > > This patch adds null dev check for the 'cfg->rc_via_table == > NEIGH_LINK_TABLE or dev_get_by_index() failed' case > > Reported-by: Dan Carpenter > Signed-off-by: Roopa Prabhu > --- > v1-v2 : fixed patch versio

Re: [PATCH V2 net-next 0/6] test_bpf improvements

2015-08-06 Thread David Miller
From: Nicolas Schichan Date: Tue, 4 Aug 2015 15:19:06 +0200 > Please find below the patch series with my latest changes to test_bpf. Series applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH net-next 0/8] net/mlx5e: Driver updates 04-Aug-2015

2015-08-06 Thread David Miller
From: Amir Vadai Date: Tue, 4 Aug 2015 14:05:39 +0300 > This patchset introduces two features to the ConnectX-4 driver: Patch 8/8 > ("Support physical port counters") exposes some hardware counters through > ethtool. Rest of the patches are preparation and usage of what we call > light-weight ne

Re: [net-next PATCH v2 0/3] CPSW interrupt handling cleanup and performance improvement

2015-08-06 Thread David Miller
From: Mugunthan V N Date: Tue, 4 Aug 2015 16:06:17 +0530 > This patch series removes the irq controller disable interrupt and > adding a napi for tx event handling which improves the performance by > ~180Mbps on dra7-evm > > [ 5] local 192.168.10.116 port 5001 connected with 192.168.10.165 port

Re: [patch] mpls: small cleanup in inet/inet6_fib_lookup_dev()

2015-08-06 Thread David Miller
From: Dan Carpenter Date: Tue, 4 Aug 2015 10:44:22 +0300 > We recently changed this code from returning NULL to returning ERR_PTR. > There are some left over NULL assignments which we can remove. We can > preserve the error code from ip_route_output() instead of always > returning -ENODEV. Also

Re: net: Fix skb_set_peeked use-after-free bug

2015-08-06 Thread David Miller
From: Herbert Xu Date: Tue, 4 Aug 2015 15:42:47 +0800 > The commit 738ac1ebb96d02e0d23bc320302a6ea94c612dec ("net: Clone > skb before setting peeked flag") introduced a use-after-free bug > in skb_recv_datagram. This is because skb_set_peeked may create > a new skb and free the existing one. As

Re: [PATCH v2 net-next 0/4] bnx2x, cnic, bnx2fc: add support for BD

2015-08-06 Thread David Miller
From: Yuval Mintz Date: Tue, 4 Aug 2015 09:37:26 +0300 > Commit 230d00eb4bfe ("bnx2x: new Multi-function mode - BD") added support > for a new multi-function mode, but it added only the support required by > bnx2x for L2 interfaces. > > This adds the required changes to support the new multi-fun

Re: [PATCH net-next 2/2] rocker: use netdev_err after register_netdev

2015-08-06 Thread David Miller
From: sfel...@gmail.com Date: Mon, 3 Aug 2015 22:31:18 -0700 > From: Scott Feldman > > After successful register_netdev, we can use netdev_err rather the more > generic dev_err. > > Signed-off-by: Scott Feldman Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH net-next 1/2] rocker: NULL port if port probe fails

2015-08-06 Thread David Miller
From: sfel...@gmail.com Date: Mon, 3 Aug 2015 22:31:17 -0700 > From: Scott Feldman > > Set port to NULL if port probe fails so we don't try to remove partially > initialized port on port probe err cleanup path. > > Signed-off-by: Scott Feldman Applied. -- To unsubscribe from this list: send

Re: [PATCH v2 net-next 0/4] gro: Fixes for tunnels and GRO

2015-08-06 Thread David Miller
From: Tom Herbert Date: Mon, 3 Aug 2015 10:11:14 -0700 > This patch set addresses some issue related to tunneling and GRO: As others have mentioned, the SIT GRO support was explicitly reverted because it is broken and there were bug reports against it. Until those are resolved you cannot put th

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-06 Thread David Miller
From: Lucas Stach Date: Mon, 3 Aug 2015 17:50:11 +0200 > The clocks are initially active and thus the device is marked active. > This still keeps the PM refcount at 0, the pm_runtime_put_autosuspend() > call at the end of probe then leaves us with an invalid refcount of -1, > which in turn leads

[PATCH 1/2] net: thunder: Factor out DT specific code in BGX

2015-08-06 Thread David Daney
From: Robert Richter Separate DT code in preparation for follow-on ACPI integration. Based on code from: Tomasz Nowicki Signed-off-by: Robert Richter Signed-off-by: David Daney --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 48 +-- 1 file changed, 35 insertions(

[PATCH 2/2] net, thunder, bgx: Add support for ACPI binding.

2015-08-06 Thread David Daney
From: David Daney Find out which PHYs belong to which BGX instance in the ACPI way. Set the MAC address of the device as provided by ACPI tables. This is similar to the implementation for devicetree in of_get_mac_address(). The table is searched for the device property entries "mac-address", "lo

[PATCH 0/2] net: thunder: Add ACPI support.

2015-08-06 Thread David Daney
From: David Daney Hook up PHYs, and get MAC address from ACPI for the thunder driver. The first patch (1/2) rearranges the existing code a little with no functional change to get ready for the second. The second (2/2) does the actual work of adding support to extract the needed information from

Re: [PATCH v2 net-next 3/4] ipv6: Add gro functions to sit_offloads

2015-08-06 Thread Jesse Gross
On Mon, Aug 3, 2015 at 10:11 AM, Tom Herbert wrote: > For GRO to work with sit we need gro_receive and gro_complete populated > in the sit_offload structure. > > Signed-off-by: Tom Herbert You might want to checkout the recent history on this file unless there's something that's changed in the l

Re: rtnl_mutex deadlock?

2015-08-06 Thread Herbert Xu
On Fri, Aug 07, 2015 at 01:58:15AM +0200, Daniel Borkmann wrote: > > Looks like we had a WARN_ON() in rhashtable_insert_rehash() before, but > was removed in a87b9ebf1709 ("rhashtable: Do not schedule more than one > rehash if we can't grow further"). Do you want to re-add a WARN_ON_ONCE()? I thin

Re: rtnl_mutex deadlock?

2015-08-06 Thread Daniel Borkmann
On 08/07/2015 01:41 AM, Herbert Xu wrote: On Thu, Aug 06, 2015 at 04:50:39PM +0200, Daniel Borkmann wrote: Then, in __rhashtable_insert_fast(), I could trigger an -EBUSY when I'm really unlucky and exceed the ht->elasticity limit of 16. I would then end up in rhashtable_insert_rehash() to find

Re: [PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-08-06 Thread Herbert Xu
On Fri, Aug 07, 2015 at 12:26:41AM +0200, Daniel Borkmann wrote: > > Reference: http://thread.gmane.org/gmane.linux.network/372676 > Reported-by: Linus Torvalds > Signed-off-by: Daniel Borkmann Acked-by: Herbert Xu But as I said earlier, this should not happen and if it does, then our rhashtab

Re: rtnl_mutex deadlock?

2015-08-06 Thread Herbert Xu
On Fri, Aug 07, 2015 at 12:39:47AM +0200, Daniel Borkmann wrote: > > window was too small to trigger an error. I think in any case, remapping > seems okay. Oh there is no doubt that we need your EBUSY remapping patch. It's just that it's very unlikely for this to be responsible for the dead-lock t

Re: rtnl_mutex deadlock?

2015-08-06 Thread Herbert Xu
On Thu, Aug 06, 2015 at 04:50:39PM +0200, Daniel Borkmann wrote: > > Then, in __rhashtable_insert_fast(), I could trigger an -EBUSY when I'm > really unlucky and exceed the ht->elasticity limit of 16. I would then > end up in rhashtable_insert_rehash() to find out there's already one > ongoing and

Re: [PATCH net V2] virtio-net: drop NETIF_F_FRAGLIST

2015-08-06 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 6 Aug 2015 16:13:11 +0300 > On Wed, Aug 05, 2015 at 10:34:04AM +0800, Jason Wang wrote: >> virtio declares support for NETIF_F_FRAGLIST, but assumes >> that there are at most MAX_SKB_FRAGS + 2 fragments which isn't >> always true with a fraglist. >> >> A lon

Re: rtnl_mutex deadlock?

2015-08-06 Thread Daniel Borkmann
On 08/06/2015 04:50 PM, Daniel Borkmann wrote: On 08/06/2015 02:30 AM, Herbert Xu wrote: On Wed, Aug 05, 2015 at 08:59:07PM +0200, Daniel Borkmann wrote: Here's a theory and patch below. Herbert, Thomas, does this make any sense to you resp. sound plausible? ;) It's certainly possible. Whet

Re: [BUG] net/ipv4: inconsistent routing table

2015-08-06 Thread Alexander Duyck
On 08/06/2015 03:13 AM, Zang MingJie wrote: On Thu, Aug 6, 2015 at 1:45 AM, Alexander Duyck wrote: On 08/05/2015 02:06 AM, Daniel Borkmann wrote: [ please cc netdev ] On 08/05/2015 10:56 AM, Zang MingJie wrote: Hi: I found a bug when remove an ip address which is referenced by a routing e

[PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-08-06 Thread Daniel Borkmann
Linus reports the following deadlock on rtnl_mutex; triggered only once so far (extract): [12236.694209] NetworkManager D 00013b80 0 1047 1 0x [12236.694218] 88003f902640 815d15a9 0018 [12236.694224] 880119538000 88003f

Re: [PATCHv2 net-next 5/9] openvswitch: Add conntrack action

2015-08-06 Thread Pravin Shelar
On Thu, Aug 6, 2015 at 11:07 AM, Joe Stringer wrote: > On 5 August 2015 at 15:31, Pravin Shelar wrote: >> On Tue, Aug 4, 2015 at 9:49 PM, Joe Stringer wrote: >> I got sparse warning: >> >> net/openvswitch/actions.c:634:1: warning: symbol 'ovs_dst_get_mtu' was >> not declared. Should it be static

Re: [PATCH] net: netcp: fix unused interface rx buffer size configuration

2015-08-06 Thread Murali Karicheri
On 08/04/2015 04:56 PM, WingMan Kwok wrote: Prior to this patch, rx buffer size for each rx queue of an interface is configurable through dts bindings. But for an interface, the first rx queue's rx buffer size is always the usual MTU size (plus usual overhead) and page size for the remaining rx q

[PATCH net] bna: fix interrupts storm caused by erroneous packets

2015-08-06 Thread Ivan Vecera
The commit "e29aa33 bna: Enable Multi Buffer RX" moved packets counter increment from the beginning of the NAPI processing loop after the check for erroneous packets so they are never accounted. This counter is used to inform firmware about number of processed completions (packets). As these packet

RE: [PATCH V4 4/7] Drivers: hv: vmbus: add APIs to register callbacks to process hvsock connection

2015-08-06 Thread KY Srinivasan
> -Original Message- > From: Dexuan Cui > Sent: Wednesday, August 5, 2015 9:54 PM > To: David Miller ; KY Srinivasan > > Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com; > driverdev-de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; > step...@networkplumber.o

RE: [PATCH V4 7/7] Drivers: hv: vmbus: disable local interrupt when hvsock's callback is running

2015-08-06 Thread KY Srinivasan
> -Original Message- > From: Dexuan Cui > Sent: Wednesday, August 5, 2015 9:44 PM > To: David Miller ; KY Srinivasan > > Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com; > driverdev-de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; > step...@networkplumber.o

Re: [PATCHv2 net-next 5/9] openvswitch: Add conntrack action

2015-08-06 Thread Joe Stringer
On 5 August 2015 at 15:31, Pravin Shelar wrote: > On Tue, Aug 4, 2015 at 9:49 PM, Joe Stringer wrote: > I got sparse warning: > > net/openvswitch/actions.c:634:1: warning: symbol 'ovs_dst_get_mtu' was > not declared. Should it be static? > > net/openvswitch/actions.c:703:17: warning: cast from re

RE: [Intel-wired-lan] [PATCH] igbvf: clear buffer_info->dma after dma_unmap_single()

2015-08-06 Thread Brandeburg, Jesse
On Thu, 6 Aug 2015 09:32:17 +0200 Stefan Assmann wrote: > The driver doesn't clear buffer_info->dma after calling > dma_unmap_single() in all cases. This has been discovered by changing > the mtu twice, which caused the following backtrace. should be for NET? Looks good, thanks Stefan! Acked-b

[PATCH 1/3] net: mvpp2: remove excessive spinlocks from driver initialization

2015-08-06 Thread Marcin Wojtas
Using spinlocks protection during one-time driver initialization is not necessary. Moreover it resulted in invalid GFP_KERNEL allocation under the lock. This commit removes redundant spinlocks from buffer manager part of mvpp2 initialization. Signed-off-by: Marcin Wojtas Reported-by: Alexandre F

[PATCH 3/3] net: mvpp2: replace TX coalescing interrupts with hrtimer

2015-08-06 Thread Marcin Wojtas
The PP2 controller is capable of per-CPU TX processing, which means there are per-CPU banked register sets and queues. Current version of the driver supports TX packet coalescing - once on given CPU sent packets amount reaches a threshold value, an IRQ occurs. However, there is a single interrupt l

[PATCH 0/3] Fixes for the network driver of Marvell Armada 375 SoC

2015-08-06 Thread Marcin Wojtas
Hello, This is a set of three patches that fix long-lasting problems implemented in the initial support for the Armada 375 network controller. Due to an inappropriate concept of handling the per-CPU sent packets' processing on TX path the driver numerous problems occured, such as RCU stalls. Thos

[PATCH 2/3] net: mvpp2: enable proper per-CPU TX buffers unmapping

2015-08-06 Thread Marcin Wojtas
mvpp2 driver allows usage of per-CPU TX processing. Once the packets are prepared independetly on each CPU, the hardware enqueues the descriptors in common TX queue. After they are sent, the buffers and associated sk_buffs should be released on the corresponding CPU. This is why a special index is

Re: [PATCH net-next v2 2/7] net: switchdev: support static FDB addresses

2015-08-06 Thread Scott Feldman
On Thu, Aug 6, 2015 at 7:19 AM, Vivien Didelot wrote: > On 15-08-05 23:28:15, Scott Feldman wrote: >> On Wed, Aug 5, 2015 at 10:44 PM, Vivien Didelot >> wrote: >> > This patch adds a is_static boolean to the switchdev_obj_fdb structure, >> > in order to set the ndm_state to either NUD_NOARP or NU

[PATCH v2] xen-apic: Enable on domU as well

2015-08-06 Thread Jason A. Donenfeld
It turns out that domU also requires the Xen APIC driver. Otherwise we get stuck in busy loops that never exit, such as in this stack trace: (gdb) target remote localhost: Remote debugging using localhost: __xapic_wait_icr_idle () at ./arch/x86/include/asm/ipi.h:56 56 while (n

[PATCH] xen-apic: Enable on domU as well

2015-08-06 Thread Jason A. Donenfeld
It turns out that domU also requires the Xen APIC driver. Otherwise we get stuck in busy loops that never exit, such as in this stack trace: (gdb) target remote localhost: Remote debugging using localhost: __xapic_wait_icr_idle () at ./arch/x86/include/asm/ipi.h:56 56 while (n

Re: [Xen-devel] printk from softirq on xen: hard lockup

2015-08-06 Thread Jason A. Donenfeld
In that case, it doesn't compile. arch/x86/xen/apic.c:204:13: error: redefinition of ‘xen_init_apic’ void __init xen_init_apic(void) ^ In file included from arch/x86/xen/apic.c:9:0: arch/x86/xen/xen-ops.h:110:27: note: previous definition of ‘xen_init_apic’ was here static inline vo

Re: [Xen-devel] printk from softirq on xen: hard lockup

2015-08-06 Thread David Vrabel
On 06/08/15 16:58, Jason A. Donenfeld wrote: > On Thu, Aug 6, 2015 at 12:02 PM, David Vrabel wrote: >> Linux PV guests must use the "Xen PV" APIC driver. You need to >> investigate why your PV guest is not using this (although I'm surprised >> it works at all with the wrong one). > > Actually it

Re: [Xen-devel] printk from softirq on xen: hard lockup

2015-08-06 Thread Jason A. Donenfeld
On Thu, Aug 6, 2015 at 12:02 PM, David Vrabel wrote: > Linux PV guests must use the "Xen PV" APIC driver. You need to > investigate why your PV guest is not using this (although I'm surprised > it works at all with the wrong one). Actually it appears this PV Guest is using the "flat" APIC driver

[PATCH net-next 2/2] net: ipv6 sysctl option to ignore routes when nexthop link is down

2015-08-06 Thread Andy Gospodarek
Like the ipv4 patch with a similar title, this adds a sysctl to allow the user to change routing behavior based on whether or not the interface associated with the nexthop was an up or down link. The default setting preserves the current behavior, but anyone that enables it will notice that nextho

[PATCH net-next 1/2] net: track link status of ipv6 nexthops

2015-08-06 Thread Andy Gospodarek
Add support to track current link status of ipv6 nexthops to match recent changes that added support for ipv4 nexthops. There was not a field already available that could track these and no space available in the existing rt6i_flags field, so this patch adds rt6i_nhflags to struct rt6_info. Signe

Re: [net-next 07/15] i40e/i40evf: Add TX/RX outer UDP checksum support for X722

2015-08-06 Thread Tom Herbert
On Wed, Aug 5, 2015 at 5:38 PM, Jesse Brandeburg wrote: > On Wed, 5 Aug 2015 17:13:21 -0700 > Tom Herbert wrote: > >> On Wed, Aug 5, 2015 at 4:52 PM, Jeff Kirsher >> wrote: >> > From: Anjali Singhai Jain >> > if (vsi->back->flags & I40E_FLAG_WB_ON_ITR_CAPABLE) >> >

Re: [PATCH net-next v2 3/7] net: dsa: add support for switchdev FDB objects

2015-08-06 Thread Vivien Didelot
On 15-08-06 16:04:32, Andrew Lunn wrote: > Hi Vivien > > Thanks for splitting up the big patch. This it is much easier to > review now. > > Is this patch git bisectable? In terms of compilation, yes. > Clearly after this patch, but before all the other patches are in, we > will not be programmi

Re: rtnl_mutex deadlock?

2015-08-06 Thread Daniel Borkmann
On 08/06/2015 02:30 AM, Herbert Xu wrote: On Wed, Aug 05, 2015 at 08:59:07PM +0200, Daniel Borkmann wrote: Here's a theory and patch below. Herbert, Thomas, does this make any sense to you resp. sound plausible? ;) It's certainly possible. Whether it's plausible I'm not so sure. The netlink

[patch net-next 5/7] mlxsw: Simplify mlxsw_sx_port_xmit function

2015-08-06 Thread Jiri Pirko
From: Ido Schimmel Previously we only checked if the transmission queue is not full in the middle of the xmit function. This lead to complex logic due to the fact that sometimes we need to reallocate the headroom for our Tx header. Allow the switch driver to know if the transmission queue is not

[patch net-next 3/7] mlxsw: Make pci module dependent on HAS_DMA and HAS_IOMEM

2015-08-06 Thread Jiri Pirko
From: Jiri Pirko This resolves compile errors on um-allyesconfig. Note that there are many other drivers which have the same issue. Reported-by: kbuild test robot Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/Kconfig | 2 +- 1 file changed, 1

[patch net-next 0/7] mlxsw: Couple of fixes/adjustments

2015-08-06 Thread Jiri Pirko
From: Jiri Pirko Ido Schimmel (5): mlxsw: Call free_netdev when removing port mlxsw: Make system port to local port mapping explicit mlxsw: Simplify mlxsw_sx_port_xmit function mlxsw: Use correct skb length when dumping payload mlxsw: Fix use-after-free bug in mlxsw_sx_port_xmit Jiri P

[patch net-next 4/7] mlxsw: Strip FCS from incoming packets

2015-08-06 Thread Jiri Pirko
From: Jiri Pirko FCS of incoming packets is already checked by HW. Just strip it out. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/pci.c | 6 +- drivers/net/ethernet/mellanox/mlxsw/pci.h | 6 ++ 2 files changed, 11 insertions(+), 1 dele

[patch net-next 1/7] mlxsw: Call free_netdev when removing port

2015-08-06 Thread Jiri Pirko
From: Ido Schimmel When removing a port's netdevice we should also free the memory allocated by alloc_etherdev(). Do this by calling free_netdev() at the end of the teardown sequence. Reported-by: Or Gerlitz Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mella

[patch net-next 6/7] mlxsw: Use correct skb length when dumping payload

2015-08-06 Thread Jiri Pirko
From: Ido Schimmel Do not use the length of the transmitted skb (which was freed), but that of the response skb. This issue was discovered using the Kernel Address sanitizer (KASan). Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/core.c | 2 +-

[patch net-next 2/7] mlxsw: Make system port to local port mapping explicit

2015-08-06 Thread Jiri Pirko
From: Ido Schimmel System ports are unique identifiers in a multi-ASIC environment that represent all the available ports in the system. Local ports on the other hand, are unique only within the local ASIC. Since system port to local port mapping is not part of the HW-SW contract and since only

[patch net-next 7/7] mlxsw: Fix use-after-free bug in mlxsw_sx_port_xmit

2015-08-06 Thread Jiri Pirko
From: Ido Schimmel Store the length of the skb before transmitting it and use it for stats instead of skb->len, since skb might have been freed already. This issue was discovered using the Kernel Address sanitizer (KASan). Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net

Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-06 Thread Stefano Stabellini
On Thu, 6 Aug 2015, Julien Grall wrote: > On 06/08/15 12:06, Stefano Stabellini wrote: > > On Thu, 6 Aug 2015, Julien Grall wrote: > >> Hi, > >> > >> > >> On 04/08/15 19:12, Julien Grall wrote: > >>> diff --git a/include/xen/page.h b/include/xen/page.h > >>> index c5ed20b..e7e1425 100644 > >>> ---

Re: [PATCH net-next v2 2/7] net: switchdev: support static FDB addresses

2015-08-06 Thread Vivien Didelot
On 15-08-05 23:28:15, Scott Feldman wrote: > On Wed, Aug 5, 2015 at 10:44 PM, Vivien Didelot > wrote: > > This patch adds a is_static boolean to the switchdev_obj_fdb structure, > > in order to set the ndm_state to either NUD_NOARP or NUD_REACHABLE. > > > > Signed-off-by: Vivien Didelot > > --- >

Re: [PATCH net-next v2 3/7] net: dsa: add support for switchdev FDB objects

2015-08-06 Thread Andrew Lunn
Hi Vivien Thanks for splitting up the big patch. This it is much easier to review now. Is this patch git bisectable? Clearly after this patch, but before all the other patches are in, we will not be programming the hardware. The call into the driver is removed here, but the replacement is added

Re: [PATCH net V2] virtio-net: drop NETIF_F_FRAGLIST

2015-08-06 Thread Michael S. Tsirkin
On Wed, Aug 05, 2015 at 10:34:04AM +0800, Jason Wang wrote: > virtio declares support for NETIF_F_FRAGLIST, but assumes > that there are at most MAX_SKB_FRAGS + 2 fragments which isn't > always true with a fraglist. > > A longer fraglist in the skb will make the call to skb_to_sgvec overflow > the

[PATCH 1/2] netfilter: ip6t_SYNPROXY: fix NULL pointer dereference

2015-08-06 Thread Phil Sutter
This happens when networking namespaces are enabled. Suggested-by: Patrick McHardy Signed-off-by: Phil Sutter --- net/ipv6/netfilter/ip6t_SYNPROXY.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/net/ipv6/netfilter/ip6t_SYNPROXY.c b/net/ipv6/netfilter/ip6

[PATCH 2/2] netfilter: ip6t_SYNPROXY: fix sending window update to client

2015-08-06 Thread Phil Sutter
This is the identical fix as "netfilter: ipt_SYNPROXY: fix sending window update to client" but for the IPv6 variant which obviously suffers from the same issue. Signed-off-by: Phil Sutter --- net/ipv6/netfilter/ip6t_SYNPROXY.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH] [trivial] net: ethernet: Fix double word "the the" in eth.c

2015-08-06 Thread Masanari Iida
This patch fix double word "the the" in Documentation/DocBook/networking/API-eth-get-headlen.html Documentation/DocBook/networking/netdev.html Documentation/DocBook/networking.xml These files are generated from comment in source, so I have to fix comment in net/ethernet/eth.c. Signed-off-by: Masa

[PATCH 2/6] misc/ss: avoid NULL pointer dereference

2015-08-06 Thread Phil Sutter
This was working before, but only if realloc a) succeeded and b) did not move the buffer to a different location. ''**buf = **new_buf' then writes the value of *new_buf's first field into that of *buf. Signed-off-by: Phil Sutter --- misc/ss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 1/6] ip/ipnetns: prevent potential string buffer overflow

2015-08-06 Thread Phil Sutter
Signed-off-by: Phil Sutter --- ip/ipnetns.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ip/ipnetns.c b/ip/ipnetns.c index 3b704a4..32b0f51 100644 --- a/ip/ipnetns.c +++ b/ip/ipnetns.c @@ -178,7 +178,8 @@ static int netns_map_add(int nsid, char *name) retu

[PATCH 5/6] lib/namespace: don't leak fd in error case

2015-08-06 Thread Phil Sutter
Signed-off-by: Phil Sutter --- lib/namespace.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/namespace.c b/lib/namespace.c index a61feb6..8197165 100644 --- a/lib/namespace.c +++ b/lib/namespace.c @@ -58,32 +58,35 @@ int netns_switch(char *name) if

[PATCH 4/6] misc/ss: add missing fclose() calls

2015-08-06 Thread Phil Sutter
Signed-off-by: Phil Sutter --- misc/ss.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index e77655a..0c7c6d7 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -3025,6 +3025,7 @@ static int packet_show_line(char *buf, const struct filter *f, int fam) s

[PATCH 3/6] misc/ss: simplify buffer realloc, fix checking realloc failure

2015-08-06 Thread Phil Sutter
Signed-off-by: Phil Sutter --- misc/ss.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index af5a3c2..e77655a 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -550,7 +550,7 @@ static int find_entry(unsigned ino, char **buf, int type) struct user_

[PATCH 6/6] misc/ss: fix memory leak in user_ent_hash_build()

2015-08-06 Thread Phil Sutter
Signed-off-by: Phil Sutter --- misc/ss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index 0c7c6d7..bba7009 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -483,8 +483,10 @@ static void user_ent_hash_build(void) sprintf(name + nameoff,

Re: [PATCH 2/5] net: rfkill: add rfkill_find_type function

2015-08-06 Thread Sergei Shtylyov
Hello. On 8/5/2015 4:39 PM, Heikki Krogerus wrote: Helper for finding the type based on name. Useful if the type needs to be determined based on device property. Signed-off-by: Heikki Krogerus --- include/linux/rfkill.h | 15 + net/rfkill/core.c | 57

Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-06 Thread Julien Grall
On 06/08/15 12:06, Stefano Stabellini wrote: > On Thu, 6 Aug 2015, Julien Grall wrote: >> Hi, >> >> >> On 04/08/15 19:12, Julien Grall wrote: >>> diff --git a/include/xen/page.h b/include/xen/page.h >>> index c5ed20b..e7e1425 100644 >>> --- a/include/xen/page.h >>> +++ b/include/xen/page.h >>> @@ -

Re: [PATCH net-next] net/mlx5_core: Set log_uar_page_sz for non 4K page size architecture

2015-08-06 Thread Amir Vadai
On 8/5/2015 7:05 PM, cls...@linux.vnet.ibm.com wrote: > From: Carol L Soto > > failed to configure the page size for architectures with page size > different than 4K. > > Signed-off-by: Carol L Soto > --- Please pull this patch into kernel 4.2 Fixes: 938fe83 ("net/mlx5_core: New device capabi

[PATCH] net: phy: add RealTek RTL8211DN phy id

2015-08-06 Thread shh.xie
From: Shaohui Xie RTL8211DN is compatible with RTL8211E. Signed-off-by: Shaohui Xie --- drivers/net/phy/realtek.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c index 4535361..43ab691 100644 --- a/drivers/net/phy/realte

Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-06 Thread Stefano Stabellini
On Thu, 6 Aug 2015, Julien Grall wrote: > Hi, > > > On 04/08/15 19:12, Julien Grall wrote: > > diff --git a/include/xen/page.h b/include/xen/page.h > > index c5ed20b..e7e1425 100644 > > --- a/include/xen/page.h > > +++ b/include/xen/page.h > > @@ -3,9 +3,9 @@ > > > > #include > > > > -stati

Re: [Xen-devel] [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-06 Thread Julien Grall
Hi, On 04/08/15 19:12, Julien Grall wrote: > diff --git a/include/xen/page.h b/include/xen/page.h > index c5ed20b..e7e1425 100644 > --- a/include/xen/page.h > +++ b/include/xen/page.h > @@ -3,9 +3,9 @@ > > #include > > -static inline unsigned long page_to_mfn(struct page *page) > +static in

Re: [PATCH] sky2: Add module parameter for passing the MAC address

2015-08-06 Thread Liviu Dudau
On Thu, Aug 06, 2015 at 01:32:33AM +0100, David Miller wrote: > From: Liviu Dudau > Date: Wed, 5 Aug 2015 16:50:54 +0100 > > > For designs where EEPROMs are not connected to PCI Yukon2 > > chips we need to get the MAC address from the firmware. > > Add a module parameter called 'mac_address' for

Re: [BUG] net/ipv4: inconsistent routing table

2015-08-06 Thread Zang MingJie
On Thu, Aug 6, 2015 at 1:45 AM, Alexander Duyck wrote: > On 08/05/2015 02:06 AM, Daniel Borkmann wrote: >> >> [ please cc netdev ] >> >> On 08/05/2015 10:56 AM, Zang MingJie wrote: >>> >>> Hi: >>> >>> I found a bug when remove an ip address which is referenced by a routing >>> entry. >>> >>> step

[PATCH net-next] mpls: Enforce payload type of traffic sent using explicit NULL

2015-08-06 Thread Robert Shearman
RFC 4182 s2 states that if an IPv4 Explicit NULL label is the only label on the stack, then after popping the resulting packet must be treated as a IPv4 packet and forwarded based on the IPv4 header. The same is true for IPv6 Explicit NULL with an IPv6 packet following. Therefore, when installing

Re: [Xen-devel] printk from softirq on xen: hard lockup

2015-08-06 Thread David Vrabel
On 05/08/15 00:01, Jason A. Donenfeld wrote: > Hey David, > > Sorry for the premature response on my phone earlier. Real reply follows. >>> rcu_read_lock, when using Xen PV. Relevant excerpts of the >> ^^ PV guest? > > Yes. The lockup occurs on a PV guest. Nothing

Re: [PATCH 2/5] net: rfkill: add rfkill_find_type function

2015-08-06 Thread Andy Shevchenko
On Thu, 2015-08-06 at 11:30 +0300, Heikki Krogerus wrote: > > > > On Wed, Aug 05, 2015 at 05:07:29PM +0300, Andy Shevchenko wrote: > > On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote: > > > +static inline enum rfkill_type rfkill_find_type(const char > > > *name) > > > +{ > > > + return

Re: [PATCH 2/5] net: rfkill: add rfkill_find_type function

2015-08-06 Thread Heikki Krogerus
On Wed, Aug 05, 2015 at 05:07:29PM +0300, Andy Shevchenko wrote: > On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote: > > Helper for finding the type based on name. Useful if the > > type needs to be determined based on device property. > > > > Signed-off-by: Heikki Krogerus > > --- > > i

Re: [Xen-devel] printk from softirq on xen: hard lockup

2015-08-06 Thread Ian Campbell
On Tue, 2015-08-04 at 18:12 +0100, David Vrabel wrote: > On 04/08/15 17:41, Jason A. Donenfeld wrote: > > Hi folks, > > > > Paul McKenney and I had an offline discussion about some rcu questions > > that eventually lead into me investigating a strange full lock-up I'm > > experiencing as a consequ

Re: veths often slow to come up

2015-08-06 Thread Shaun Crampton
> Take a look at linkwatch_urgent_event at net/core/link_watch.c, and all >of > link_watch.c in general. That's where the 1s delay comes from. Thanks for the diagnosis, I¹ll take a look. -Shaun -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to major

Re: [PATCH 1/5] device property: helper macros for property entry creation

2015-08-06 Thread Heikki Krogerus
On Wed, Aug 05, 2015 at 05:02:18PM +0300, Andy Shevchenko wrote: > On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote: > > Marcos for easier creation of build-in property entries. > > > > Signed-off-by: Heikki Krogerus > > --- > > include/linux/property.h | 35 +

[PATCH] igbvf: clear buffer_info->dma after dma_unmap_single()

2015-08-06 Thread Stefan Assmann
The driver doesn't clear buffer_info->dma after calling dma_unmap_single() in all cases. This has been discovered by changing the mtu twice, which caused the following backtrace. [ 68.569280] WARNING: CPU: 2 PID: 1860 at drivers/iommu/intel-iommu.c:3517 intel_unmap+0x20c/0x220() [ 68.579392]

Re: [PATCH 5/5] net: rfkill: gpio: remove rfkill_gpio_platform_data

2015-08-06 Thread Heikki Krogerus
On Wed, Aug 05, 2015 at 05:15:28PM +0300, Andy Shevchenko wrote: > On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote: > > No more users for it. > > > > Signed-off-by: Heikki Krogerus > > --- > > include/linux/rfkill-gpio.h | 37 --- > > -- > > net/rfkill/Kc

[PATCH v7 0/5] bpf: Introduce the new ability of eBPF programs to access hardware PMU counter

2015-08-06 Thread Kaixu Xia
This patchset is base on the net-next: git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git commit 9dc20a649609c95ce7c5ac4282656ba627b67d49. Previous patch v6 url: https://lkml.org/lkml/2015/8/4/188 changes in V7: - rebase the whole patch set to net-next tree(9dc20a64); - split out the c

[PATCH v7 1/5] perf: add the necessary core perf APIs when accessing events counters in eBPF programs

2015-08-06 Thread Kaixu Xia
This patch add three core perf APIs: - perf_event_attrs(): export the struct perf_event_attr from struct perf_event; - perf_event_get(): get the struct perf_event from the given fd; - perf_event_read_local(): read the events counters active on the current CPU; These APIs are needed when ac

[PATCH v7 2/5] bpf: Make the bpf_prog_array_map more generic

2015-08-06 Thread Kaixu Xia
From: Wang Nan All the map backends are of generic nature. In order to avoid adding much special code into the eBPF core, rewrite part of the bpf_prog_array map code and make it more generic. So the new perf_event_array map type can reuse most of code with bpf_prog_array map and add fewer lines o

[PATCH v7 5/5] samples/bpf: example of get selected PMU counter value

2015-08-06 Thread Kaixu Xia
This is a simple example and shows how to use the new ability to get the selected Hardware PMU counter value. Signed-off-by: Kaixu Xia --- samples/bpf/Makefile | 4 +++ samples/bpf/bpf_helpers.h | 2 ++ samples/bpf/tracex6_kern.c | 26 ++ samples/bpf/tracex6_user.c | 68

[PATCH v7 4/5] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter

2015-08-06 Thread Kaixu Xia
According to the perf_event_map_fd and index, the function bpf_perf_event_read() can convert the corresponding map value to the pointer to struct perf_event and return the Hardware PMU counter value. Signed-off-by: Kaixu Xia --- include/linux/bpf.h | 1 + include/uapi/linux/bpf.h | 1 + k

[PATCH v7 3/5] bpf: Add new bpf map type to store the pointer to struct perf_event

2015-08-06 Thread Kaixu Xia
Introduce a new bpf map type 'BPF_MAP_TYPE_PERF_EVENT_ARRAY'. This map only stores the pointer to struct perf_event. The user space event FDs from perf_event_open() syscall are converted to the pointer to struct perf_event and stored in map. Signed-off-by: Kaixu Xia --- include/linux/bpf.h

  1   2   >