On Thu, Aug 06, 2015 at 01:32:33AM +0100, David Miller wrote: > From: Liviu Dudau <liviu.du...@arm.com> > Date: Wed, 5 Aug 2015 16:50:54 +0100 > > > For designs where EEPROMs are not connected to PCI Yukon2 > > chips we need to get the MAC address from the firmware. > > Add a module parameter called 'mac_address' for this. It > > will be used if no DT node can be found and the B2_MAC > > register holds an invalid value. > > > > Signed-off-by: Liviu Dudau <liviu.du...@arm.com> > > Sorry, such module options are absolutely not allowed.
Please clarify if this is a drivers/net/ethernet policy or that is true for the larger subsystem. There are a few networking drivers that have a mac_addr module parameter. I personally used drivers/net/ethernet/8390/pcnet_cs.c as inspiration for my patch. > > If an invalid MAC is present, it should be set to a random > one via eth_random_addr(). > Understood. Stephen Hemminger has provided a patch that I can try and I will report back with the results. Best regards, Liviu -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html