[PATCH] net/ipv6: add sysctl option min_hop_limit

2015-07-28 Thread Hangbin Liu
Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") disabled accept hop limit from RA if it is higher than the current hop limit for security stuff. But this behavior kind of break the RFC definition. RFC 4861, 6.3.4. Processing Received Router Advertisements A Router Adverti

Re: [PATCH net] arp: filter NOARP neighbours for SIOCGARP

2015-07-28 Thread David Miller
From: Eric Dumazet Date: Mon, 27 Jul 2015 11:33:50 +0200 > From: Eric Dumazet > > When arp is off on a device, and ioctl(SIOCGARP) is queried, > a buggy answer is given with MAC address of the device, instead > of the mac address of the destination/gateway. > > We filter out NUD_NOARP neighbou

Re: [PATCH] net/ipv4: suppress NETDEV_UP notification on address lifetime update

2015-07-28 Thread David Miller
From: David Ward Date: Sun, 26 Jul 2015 12:18:58 -0400 > This notification causes the FIB to be updated, which is not needed > because the address already exists, and more importantly it may undo > intentional changes that were made to the FIB after the address was > originally added. (As a point

Re: [PATCH net v2] bridge: stp: when using userspace stp stop kernel hello and hold timers

2015-07-28 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 23 Jul 2015 11:01:05 -0700 > From: Nikolay Aleksandrov > > These should be handled only by the respective STP which is in control. > They become problematic for devices with limited resources with many > ports because the hold_timer is per port and fires eac

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-28 Thread David Miller
From: Michal Kubecek Date: Wed, 29 Jul 2015 08:11:48 +0200 > Having both sysctl and per-route attribute would be perfect, of > course. +1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-28 Thread Michal Kubecek
On Tue, Jul 28, 2015 at 09:20:02PM +, Richard Laing wrote: > >> diff --git a/include/net/flow.h b/include/net/flow.h > >> index 8109a15..d1d933d 100644 > >> --- a/include/net/flow.h > >> +++ b/include/net/flow.h > >> @@ -79,6 +79,10 @@ struct flowi4 { > >>#define fl4_ipsec_spiuli.sp

Re: [PATCH] packet: Allow packets with only a header (but no payload)

2015-07-28 Thread Willem de Bruijn
On Mon, Jul 27, 2015 at 6:35 PM, Martin Blumenstingl wrote: > Hi Johann, > > On Tue, Jul 21, 2015 at 6:51 PM, Willem de Bruijn wrote: >> I don't see a simple way of verifying the safety of allowing packets >> without data short of a code audit, which would be huge, especially >> when taking devic

[PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-28 Thread Scott Wood
As part of defconfig consolidation using fragments, we'd like to be able to have the same drivers enabled on 32-bit and 64-bit. Gianfar happens to only exist on 32-bit systems, and when building the resulting 64-bit kernel warnings were produced. A couple of the warnings are trivial, but the rfbp

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-28 Thread Mugunthan V N
On Wednesday 29 July 2015 04:00 AM, Francois Romieu wrote: > Mugunthan V N : >> On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: >>> Mugunthan V N : > [...] @@ -752,13 +753,22 @@ static irqreturn_t cpsw_tx_interrupt(int irq, void *dev_id) struct cpsw_priv *priv = dev_id

Re: [PATCH net-next 2/5] s390/bpf: Fix multiple macro expansions

2015-07-28 Thread Joe Perches
On Tue, 2015-07-28 at 16:09 +0200, Michael Holzheu wrote: > The EMIT6_DISP_LH macro passes the "disp" parameter to the _EMIT6_DISP_LH > macro. The _EMIT6_DISP_LH macro uses the "disp" parameter twice: > > unsigned int __disp_h = ((u32)disp) & 0xff000; > unsigned int __disp_l = ((u32)disp) & 0x00

Re: [PATCHv2] net/ipv6: add sysctl option accept_ra_hop_limit

2015-07-28 Thread YOSHIFUJI Hideaki
Hangbin Liu wrote: > 2015-07-28 11:58 GMT+08:00 YOSHIFUJI Hideaki > : >> Hi, >> >> Hangbin Liu wrote: >>> 2015-07-28 7:50 GMT+08:00 YOSHIFUJI Hideaki/吉藤英明 >>> : Hi, Hangbin Liu wrote: > Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") > disabled accept ho

RE: [PATCH net v2 2/2] r8152: reset device when tx timeout

2015-07-28 Thread Hayes Wang
Oliver Neukum [mailto:oneu...@suse.com] > Sent: Tuesday, July 28, 2015 8:59 PM [...] > > > > static void rtl8152_tx_timeout(struct net_device *netdev) { > > > > struct r8152 *tp = netdev_priv(netdev); > > > > - int i; > > > > > > > > netif_warn(tp, tx_err, netdev, "Tx timeo

RE: [PATCH 3/5] Add calls to translate Always Running Timer (ART) to system time

2015-07-28 Thread Hall, Christopher S
> -Original Message- > From: John Stultz [mailto:john.stu...@linaro.org] > Sent: Monday, July 27, 2015 9:11 PM > To: Hall, Christopher S > Cc: Thomas Gleixner; Richard Cochran; Ingo Molnar; Kirsher, Jeffrey T; > Ronciak, John; H. Peter Anvin; x...@kernel.org; lkml; > netdev@vger.kernel.or

Re: [PATCHv2] net/ipv6: add sysctl option accept_ra_hop_limit

2015-07-28 Thread Hangbin Liu
2015-07-28 11:58 GMT+08:00 YOSHIFUJI Hideaki : > Hi, > > Hangbin Liu wrote: >> 2015-07-28 7:50 GMT+08:00 YOSHIFUJI Hideaki/吉藤英明 >> : >>> Hi, >>> >>> Hangbin Liu wrote: Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") disabled accept hop limit from RA if it is higher t

Re: [PATCH 3/5] Add calls to translate Always Running Timer (ART) to system time

2015-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2015 at 6:18 PM, Hall, Christopher S wrote: > > >> -Original Message- >> From: Andy Lutomirski [mailto:l...@kernel.org] >> Sent: Monday, July 27, 2015 6:32 PM >> To: Hall, Christopher S; john.stu...@linaro.org; t...@linutronix.de; >> richardcoch...@gmail.com; mi...@redhat.c

RE: [PATCH 1/5] Add functions producing system time given a backing counter value

2015-07-28 Thread Hall, Christopher S
> -Original Message- > From: John Stultz [mailto:john.stu...@linaro.org] > Sent: Monday, July 27, 2015 8:44 PM > To: Hall, Christopher S > Cc: Thomas Gleixner; Richard Cochran; Ingo Molnar; Kirsher, Jeffrey T; > Ronciak, John; H. Peter Anvin; x...@kernel.org; lkml; > netdev@vger.kernel.org

RE: [PATCH 3/5] Add calls to translate Always Running Timer (ART) to system time

2015-07-28 Thread Hall, Christopher S
> -Original Message- > From: Andy Lutomirski [mailto:l...@kernel.org] > Sent: Monday, July 27, 2015 6:32 PM > To: Hall, Christopher S; john.stu...@linaro.org; t...@linutronix.de; > richardcoch...@gmail.com; mi...@redhat.com; Kirsher, Jeffrey T; Ronciak, > John; h...@zytor.com; x...@kernel

Re: [PATCH iproute2 net-next] bridge: mdb: add support for vlans

2015-07-28 Thread Stephen Hemminger
On Tue, 28 Jul 2015 13:17:35 +0200 Nikolay Aleksandrov wrote: > On 07/15/2015 05:45 PM, Nikolay Aleksandrov wrote: > > This patch allows the user to specify the vlan of the mdb group being > > added or deleted and adds support for displaying the vlan when > > dumping mdb information or monitoring

Re: [PATCH iproute2 v7 4/4] ip link: proto_down config and display.

2015-07-28 Thread Stephen Hemminger
On Tue, 14 Jul 2015 13:43:22 -0700 anurad...@cumulusnetworks.com wrote: > From: Anuradha Karuppiah > > This patch adds support to set and display protodown on a switch port. The > switch driver can handle this error state by doing a phys down on the port. > > One example user space application

[PATCH net-next 2/2] net: Recompute sk_txhash on negative routing advice

2015-07-28 Thread Tom Herbert
When a connection is failing a transport protocol calls dst_negative_advice to try to get a better route. This patch includes changing the sk_txhash in that function. This provides a rudimentary method to try to find a different path in the network since sk_txhash affects ECMP on the local host and

[PATCH net-next 0/2] net: Initialize sk_hash to random value and reset for failing cnxs

2015-07-28 Thread Tom Herbert
This patch set implements a common function to simply set sk_txhash to a random number instead of going through the trouble to call flow dissector. From dst_negative_advice we now reset the sk_txhash in hopes of finding a better ECMP path through the network. Changing sk_txhash affects: - IPv6 fl

[PATCH net-next 1/2] net: Set sk_txhash from a random number

2015-07-28 Thread Tom Herbert
This patch creates sk_set_txhash and eliminates protocol specific inet_set_txhash and ip6_set_txhash. sk_set_txhash simply sets a random number instead of performing flow dissection. sk_set_txash is also allowed to be called multiple times for the same socket, we'll need this when redoing the hash

Re: [PATCH net] bridge: mdb: fix delmdb state in the notification

2015-07-28 Thread Nikolay Aleksandrov
On 07/29/2015 12:38 AM, Cong Wang wrote: > On Tue, Jul 28, 2015 at 4:10 AM, Nikolay Aleksandrov > wrote: >> From: Nikolay Aleksandrov >> >> Since mdb states were introduced when deleting an entry the state was >> left as it was set in the delete request from the user which leads to >> the followi

Re: [PATCH net] bridge: mdb: fix delmdb state in the notification

2015-07-28 Thread Cong Wang
On Tue, Jul 28, 2015 at 4:10 AM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > Since mdb states were introduced when deleting an entry the state was > left as it was set in the delete request from the user which leads to > the following output when doing a monitor (for example): > $

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread roopa
On 7/28/15, 3:22 PM, Hannes Frederic Sowa wrote: Hi roopa, On Tue, Jul 28, 2015, at 21:28, roopa wrote: ipv6_stub_impl.ipv6_dst_lookup seems to require sk today. But it only needs it to get 'net' in the beginning and sk is optional afterwards. I will submit a patch to add 'net' as an arg to

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-28 Thread Francois Romieu
Mugunthan V N : > On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: > > Mugunthan V N : [...] > >> @@ -752,13 +753,22 @@ static irqreturn_t cpsw_tx_interrupt(int irq, void > >> *dev_id) > >>struct cpsw_priv *priv = dev_id; > >> > >>cpdma_ctlr_eoi(priv->dma, CPDMA_EOI_TX); > >> -

[PATCH net-next v5 0/2] af_mpls: fix undefined reference to ip6_route_output with CONFIG_IPV6=n

2015-07-28 Thread Roopa Prabhu
From: Roopa Prabhu This patch series uses ipv6_stub_impl.ipv6_dst_lookup instead of ip6_route_output. Follows the vxlan drivers usage of ipv6_stub_impl.ipv6_dst_lookup. There is no sk in the af_mpls context from where ipv6_stub_impl.ipv6_dst_lookup is used. sk appears to be needed to get the na

[PATCH net-next v5 1/2] ipv6: change ipv6_stub_impl.ipv6_dst_lookup to take net argument

2015-07-28 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds net argument to ipv6_stub_impl.ipv6_dst_lookup for use cases where sk is not available (like mpls). sk appears to be needed to get the namespace 'net' and is optional otherwise. This patch series changes ipv6_stub_impl.ipv6_dst_lookup to take net argument. sk re

[PATCH net-next v5 2/2] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread Roopa Prabhu
From: Roopa Prabhu Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch uses ipv6_stub_impl.ipv6_dst_lookup instead of ip6_route_output. And wraps affected code under IS_ENABLED(CONFIG_INET) and IS_ENABLED(CONFIG_IPV6). Report

[PATCH 3/3] net: netcp: ethss: cleanup gbe_probe() and gbe_remove() functions

2015-07-28 Thread Murali Karicheri
This patch clean up error handle code to use goto label properly. In some cases, the code unnecessarily use goto instead of just returning the error code. Code also make explicit calls to devm_* APIs on error which is not necessary. In the gbe_remove() also it makes similar calls which is also unn

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread Hannes Frederic Sowa
Hi roopa, On Tue, Jul 28, 2015, at 21:28, roopa wrote: > On 7/28/15, 6:04 AM, Hannes Frederic Sowa wrote: > > Can't you simply use ipv6_stub_impl.ipv6_dst_lookup with sk=NULL to do > > that and don't have a run-time dependency on IPv6 at all (for the cost > > of a function pointer). > ipv6_stub_

[PATCH 1/3] net: netcp: fix cleanup interface list in netcp_remove()

2015-07-28 Thread Murali Karicheri
Currently if user do rmmod keystone_netcp.ko following warning is seen :- [ 59.035891] [ cut here ] [ 59.040535] WARNING: CPU: 2 PID: 1619 at drivers/net/ethernet/ti/ netcp_core.c:2127 netcp_remove) This is because the interface list is not cleaned up in netcp_remove.

[PATCH 2/3] net: netcp: ethss: fix up incorrect use of list api

2015-07-28 Thread Murali Karicheri
The code seems to assume a null is returned when the list is empty from first_sec_slave() to break the loop which is incorrect. Fix the code by using list_empty(). Signed-off-by: Murali Karicheri --- drivers/net/ethernet/ti/netcp_ethss.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[PATCH 0/3] net: netcp: bug fixes for dynamic module support

2015-07-28 Thread Murali Karicheri
This series fixes few bugs to allow keystone netcp modules to be dynamically loaded and removed. Currently it allows following sequence multiple times insmod cpsw_ale.ko insmod davinci_mdio.ko insmod keystone_netcp.ko insmod keystone_netcp_ethss.ko ifup eth0 ifup eth1 ping ping ifdown

[PATCH v2 0/3] Add MDIO support to ThunderX NIC driver

2015-07-28 Thread mohun106
From: Radha Mohan Chintakuntla This patch series adds MDIO support to ThunderX NIC driver by making use of existing mdio-octeon driver. In the process modified the mdio-octeon driver to work on both Octeon and ThunderX platforms. * From v1: - Removed default selection in Kconfig for MDIO_OCTEO

[PATCH v2 1/3] net: mdio-octeon: Modify driver to work on both ThunderX and Octeon

2015-07-28 Thread mohun106
From: Radha Mohan Chintakuntla This patch modifies the mdio-octeon driver to work on both ThunderX and Octeon SoCs from Cavium Inc. Signed-off-by: Sunil Goutham Signed-off-by: Radha Mohan Chintakuntla Signed-off-by: David Daney --- drivers/net/phy/Kconfig | 10 ++-- drivers/net/phy/m

[PATCH v2 2/3] net: mdio-octeon: Fix octeon_mdiobus_probe function for return values

2015-07-28 Thread mohun106
From: Radha Mohan Chintakuntla This patch fixes a possible crash in the octeon_mdiobus_probe function if the return values are not handled properly. Signed-off-by: Radha Mohan Chintakuntla Signed-off-by: Tomasz Nowicki --- drivers/net/phy/mdio-octeon.c | 14 +- 1 files changed,

[PATCH v2 3/3] net: thunderx: Select CONFIG_MDIO_OCTEON for ThunderX NIC

2015-07-28 Thread mohun106
From: Radha Mohan Chintakuntla The CONFIG_MDIO_OCTEON is required so that the ThunderX NIC driver can talk to the PHY drivers. Signed-off-by: Radha Mohan Chintakuntla --- drivers/net/ethernet/cavium/Kconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/e

[PATCH net-next 05/17] stmmac: dwmac-socfpga: turn setup callback into a probe function

2015-07-28 Thread Joachim Eastwood
By using a few functions from stmmac_platform a proper probe function can be created from the setup glue callback. This makes it look more like a standard driver and the OF match data can also be dropped. Signed-off-by: Joachim Eastwood --- .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c| 40

[PATCH net-next 12/17] stmmac: dwmac-sti: use custom of match structure

2015-07-28 Thread Joachim Eastwood
Create a new private structure for OF match data in the dwmac-sti driver. This enables us to eventually drop the common OF match data structure which contains a lot of unused fields. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 11 --- 1 file chan

[PATCH net-next 10/17] stmmac: move stmmac_pltfr_probe into dwmac-generic

2015-07-28 Thread Joachim Eastwood
As all dwmac-* drivers now have their own probe function move the common one into dwmac-generic driver and drop the EXPORT. Signed-off-by: Joachim Eastwood --- .../net/ethernet/stmicro/stmmac/dwmac-generic.c| 49 ++- .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 55 ---

[PATCH net-next 09/17] stmmac: dwmac-rk: create a new probe function

2015-07-28 Thread Joachim Eastwood
Create a new probe functions that call the necessary setup functions. This is done in preparation for a code refactor in this driver and dropping the common probe function in stmmac_platform.c. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 40 ++

[PATCH net-next 06/17] stmmac: dwmac-sunxi: move sun7i_gmac_setup function

2015-07-28 Thread Joachim Eastwood
Move sun7i_gmac_setup in preparation for turning it into a proper probe function. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 58 +++ 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmma

[PATCH net-next 08/17] stmmac: dwmac-sti: turn setup callback into a probe function

2015-07-28 Thread Joachim Eastwood
By using a few functions from stmmac_platform a proper probe function can be created from the setup glue callback. This makes it look more like a standard driver and prepares the driver for further clean ups. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 3

[PATCH net-next 04/17] stmmac: dwmac-socfpga: move socfpga_dwmac_probe function

2015-07-28 Thread Joachim Eastwood
Move socfpga_dwmac_probe in preparation for turning it into a proper probe function. Signed-off-by: Joachim Eastwood --- .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c| 50 +++--- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/net/ethernet/stmicro/st

[PATCH net-next 03/17] stmmac: dwmac-ipq806x: turn setup callback into a probe function

2015-07-28 Thread Joachim Eastwood
By using a few functions from stmmac_platform a proper probe function can be created from the setup glue callback. This makes it look more like a standard driver and the OF match data can also be dropped. Signed-off-by: Joachim Eastwood --- .../net/ethernet/stmicro/stmmac/dwmac-ipq806x.c| 38

[PATCH net-next 17/17] stmmac: dwmac-sti: refactor the init glue callbacks

2015-07-28 Thread Joachim Eastwood
Remove the two platform specific init callbacks and make them use a common one by creating a function member in the internal data structure. This allow us to remove the layer of indirection and simplify the code a bit. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac

[PATCH net-next 14/17] stmmac: dwmac-rk: use rk_gmac_ops as of match data

2015-07-28 Thread Joachim Eastwood
Remove the setup glue callback and use rk_gmac_ops as OF match data so it can used directly when calling rk_gmac_setup. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 27 -- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git

[PATCH net-next 02/17] stmmac: dwmac-ipq806x: move ipq806x_gmac_fix_mac_speed function

2015-07-28 Thread Joachim Eastwood
Move ipq806x_gmac_fix_mac_speed in preparation for turning the setup glue callback in a proper probe function. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/et

[PATCH net-next 15/17] stmmac: remove unused stmmac_of_data struct

2015-07-28 Thread Joachim Eastwood
As dwmac-* drivers that need OF match have been converted to use their own internal OF match data structure this can now be removed. Signed-off-by: Joachim Eastwood --- Documentation/networking/stmmac.txt | 2 -- include/linux/stmmac.h | 18 -- 2 files changed, 20 d

[PATCH net-next 16/17] stmmac: remove setup/free glue callbacks

2015-07-28 Thread Joachim Eastwood
As all dwmac-* drivers have been converted to have a proper probe function the setup callback can now be removed. Also remove the free callback that wasn't used by any driver. New dwmac-* drivers should implement standard probe and remove functions to preform any needed setup and teardown. Signed

[PATCH net-next 11/17] stmmac: let dwmac-* drivers handle their own match data

2015-07-28 Thread Joachim Eastwood
Since only a few of the dwmac-* drivers actually need to use the OF match move handling into the dwmac-* drivers that need it. This will also allow dwmac-* drivers to use their own custom match data structure. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c

[PATCH net-next 13/17] stmmac: dwmac-rk: make rk_gmac_ops structs static const

2015-07-28 Thread Joachim Eastwood
Mark the rk_gmac_ops structures as static const as they should be. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet

[PATCH net-next 00/17] stmmac clean up for 4.3 part2

2015-07-28 Thread Joachim Eastwood
This patch set creates proper probe functions in the remaining dwmac-* drivers, lets the drivers manage their own of match data structure, and cleans up some of the drivers a bit. Note that should be no functional change in any of the drivers. First patch from Fengguang fixes a Coccinelle that was

[PATCH net-next 01/17] stmmac: fix ptr_ret.cocci warning

2015-07-28 Thread Joachim Eastwood
From: Fengguang Wu drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:304:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Fengguang Wu [je: rebase and insert newline befor

[PATCH net-next 07/17] stmmac: dwmac-sunxi: turn setup callback into a probe function

2015-07-28 Thread Joachim Eastwood
By using a few functions from stmmac_platform a proper probe function can be created from the setup glue callback. This makes it look more like a standard driver and the OF match data can also be dropped. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 49

Re: [PATCH 1/3] net: mdio-octeon: Modify driver to work on both ThunderX and Octeon

2015-07-28 Thread Radha Mohan
On Tue, Jul 28, 2015 at 7:07 AM, David Daney wrote: > On 07/27/2015 07:14 PM, mohun...@gmail.com wrote: >> >> From: Radha Mohan Chintakuntla >> >> This patch modifies the mdio-octeon driver to work on both ThunderX and >> Octeon SoCs from Cavium Inc. >> >> Signed-off-by: Sunil Goutham >> Signed-

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-28 Thread Richard Laing
On 07/29/2015 09:15 AM, Tom Herbert wrote: > On Tue, Jul 28, 2015 at 2:02 PM, Tom Herbert wrote: >> On Mon, Jul 27, 2015 at 7:27 PM, Richard Laing >> wrote: >>> From: Richard Laing >>> >>> Enable flow-based ECMP. >>> >>> Currently if equal-cost multipath is enabled the kernel chooses between >

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-28 Thread Richard Laing
On 07/29/2015 09:02 AM, Tom Herbert wrote: > On Mon, Jul 27, 2015 at 7:27 PM, Richard Laing > wrote: >> From: Richard Laing >> >> Enable flow-based ECMP. >> >> Currently if equal-cost multipath is enabled the kernel chooses between >> equal cost paths for each matching packet, essentially packe

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-28 Thread Richard Laing
On 07/29/2015 07:51 AM, Stephen Hemminger wrote: > On Tue, 28 Jul 2015 02:27:57 + > Richard Laing wrote: > >> From: Richard Laing >> >> Enable flow-based ECMP. >> >> Currently if equal-cost multipath is enabled the kernel chooses between >> equal cost paths for each matching packet, essentia

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-28 Thread Tom Herbert
On Tue, Jul 28, 2015 at 2:02 PM, Tom Herbert wrote: > On Mon, Jul 27, 2015 at 7:27 PM, Richard Laing > wrote: >> From: Richard Laing >> >> Enable flow-based ECMP. >> >> Currently if equal-cost multipath is enabled the kernel chooses between >> equal cost paths for each matching packet, essential

Re: [Xen-devel] [PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-28 Thread Andrew Cooper
On 28/07/15 22:06, H. Peter Anvin wrote: > On 07/28/2015 08:02 AM, Julien Grall wrote: >> Hi all, >> >> This patch series aims to use the memory terminologies described in >> include/linux/mm.h [1] for Linux xen code. >> >> Linux is using mistakenly MFN when GFN is meant, I suspect this is because

Re: [PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-28 Thread H. Peter Anvin
On 07/28/2015 08:02 AM, Julien Grall wrote: > Hi all, > > This patch series aims to use the memory terminologies described in > include/linux/mm.h [1] for Linux xen code. > > Linux is using mistakenly MFN when GFN is meant, I suspect this is because the > first support of Xen was for PV. This has

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-28 Thread Tom Herbert
On Mon, Jul 27, 2015 at 7:27 PM, Richard Laing wrote: > From: Richard Laing > > Enable flow-based ECMP. > > Currently if equal-cost multipath is enabled the kernel chooses between > equal cost paths for each matching packet, essentially packets are > round-robined between the routes. This means t

[net-next PATCH] net: netcp: Fixes efuse mac addr swap on k2e and k2l

2015-07-28 Thread WingMan Kwok
On some of the K2E and K2L platforms, the two DWORDs in efuse occupied by the pre-programmed mac address for slave port 1 are swapped. To workaround this issue, this patch adds a new define NETCP_EFUSE_ADDR_SWAP (2) which signifies the occurrence of such swapping so that the driver can take proper

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-28 Thread Stephen Hemminger
On Tue, 28 Jul 2015 02:27:57 + Richard Laing wrote: > From: Richard Laing > > Enable flow-based ECMP. > > Currently if equal-cost multipath is enabled the kernel chooses between > equal cost paths for each matching packet, essentially packets are > round-robined between the routes. This me

RE: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread Chris (Christopher) Brand
> Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is > meant, > I suspect this is because the first support for Xen was for PV. This brough > some Typo : "brought" Perhaps "resulted in" would be better ? > misimplementation of helpers on ARM and make the developper confused

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread roopa
On 7/28/15, 6:04 AM, Hannes Frederic Sowa wrote: Can't you simply use ipv6_stub_impl.ipv6_dst_lookup with sk=NULL to do that and don't have a run-time dependency on IPv6 at all (for the cost of a function pointer). ipv6_stub_impl.ipv6_dst_lookup seems to require sk today. But it only needs it t

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread Boris Ostrovsky
On 07/28/2015 11:02 AM, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This brough some misimplementation of helpers on ARM and make the developper confused the expected behavior.

Re: [patch net-next 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC support

2015-07-28 Thread Jiri Pirko
Mon, Jul 27, 2015 at 08:17:22AM CEST, rami.ro...@intel.com wrote: >Hi, Jiri, > >Keep on the good work! > >The .func member of the mlxsw_rx_listener object has this prototype: >void (*func)(struct sk_buff *skb, u8 local_port, u16 trap_id, void *priv); > >Is the trap_id parameter needed ? >In the t

Re: [PATCH net-next 5/5] s390/bpf: recache skb->data/hlen for skb_vlan_push/pop

2015-07-28 Thread Alexei Starovoitov
On 7/28/15 7:10 AM, Michael Holzheu wrote: Allow eBPF programs attached to TC qdiscs call skb_vlan_push/pop via helper functions. These functions may change skb->data/hlen. This data is cached by s390 JIT to improve performance of ld_abs/ld_ind instructions. Therefore after a change we have to re

Re: [PATCH net] ebpf, x86: fix general protection fault when tail call is invoked

2015-07-28 Thread Daniel Borkmann
On 07/28/2015 07:02 PM, Alexei Starovoitov wrote: On 7/28/15 6:26 AM, Daniel Borkmann wrote: After patch, disassembly: [...] 9e: lea0x80(%rsi,%rdx,8),%rax <--- CONFIG_LOCKDEP/CONFIG_LOCK_STAT 48 8d 84 d6 80 00 00 00 a6: mov(%rax),%rax 48 8b 00 [...]

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread David Vrabel
On 28/07/15 16:02, Julien Grall wrote: > Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN > is meant, I suspect this is because the first support for Xen was for > PV. This brough some misimplementation of helpers on ARM and make the > developper confused the expected behavior.

Re: [net-next 0/16] Proposal for VRF-lite - v3

2015-07-28 Thread Eric W. Biederman
David Ahern writes: > On 7/27/15 2:30 PM, Eric W. Biederman wrote: >> This paragraph is false when it comes to sockets, as I have already >> pointed out. >> >> - VPN Routing and Forwarding (RFC4364 and it's kin) implies isolation >>strong enough to allow using the the same ip on different mac

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Tom Herbert
On Tue, Jul 28, 2015 at 9:11 AM, David Ahern wrote: > On 7/28/15 9:25 AM, Andy Lutomirski wrote: >> >> On Jul 27, 2015 11:33 AM, "David Ahern" wrote: >>> >>> >>> Allow tasks to have a default device index for binding sockets. If set >>> the value is passed to all AF_INET/AF_INET6 sockets when the

Re: [PATCH net] ebpf, x86: fix general protection fault when tail call is invoked

2015-07-28 Thread Alexei Starovoitov
On 7/28/15 6:26 AM, Daniel Borkmann wrote: After patch, disassembly: [...] 9e: lea0x80(%rsi,%rdx,8),%rax <--- CONFIG_LOCKDEP/CONFIG_LOCK_STAT 48 8d 84 d6 80 00 00 00 a6: mov(%rax),%rax 48 8b 00 [...] [...] 9e: lea0x50(%rsi,%rdx,8),%rax <

Please can I trust you?

2015-07-28 Thread Brice Adams
My Dear Friend, I am Mr. Brice Adams, staff and auditor of a Bank in Lome, Togo Republic. I am the Account Officer to (Late Mr. Daniel I. Glade) whose account is presently dormant, I advise you to keep this as a "top secret" as I am still in service and intend to retire from service after I conclu

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Eric Dumazet
On Tue, 2015-07-28 at 10:07 -0600, David Ahern wrote: > Problems with using network namespaces for VRFs has been discussed in > the past. e.g., > http://www.spinics.net/lists/netdev/msg298368.html Great. Are you suggesting to get rid of network namespaces ? If not, your proposal only incre

Re: [PATCH net-next 13/16] net: Introduce VRF device driver - v2

2015-07-28 Thread David Ahern
On 7/27/15 2:01 PM, Nikolay Aleksandrov wrote: + + if (!vrf_is_master(dev) || vrf_is_master(port_dev) || Hmm, this means that bonds won't be able to be VRF slaves. They have the IFF_MASTER flag set. Right, will change to the IFF_VRF_MASTER flag. + vrf_is_slave(port_dev)) +

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread roopa
On 7/28/15, 7:17 AM, Robert Shearman wrote: On 28/07/15 07:40, Roopa Prabhu wrote: From: Roopa Prabhu Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP to lookup nexthop device if us

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread David Ahern
On 7/28/15 9:25 AM, Andy Lutomirski wrote: On Jul 27, 2015 11:33 AM, "David Ahern" wrote: Allow tasks to have a default device index for binding sockets. If set the value is passed to all AF_INET/AF_INET6 sockets when they are created. This is not intended to be a review of the concept. I

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread David Ahern
On 7/28/15 10:01 AM, Eric Dumazet wrote: On Tue, 2015-07-28 at 14:19 +0200, Hannes Frederic Sowa wrote: Hello Eric, On Mon, 2015-07-27 at 15:33 -0500, Eric W. Biederman wrote: David Ahern writes: Allow tasks to have a default device index for binding sockets. If set the value is passed to a

Re: [net-next 0/16] Proposal for VRF-lite - v3

2015-07-28 Thread David Ahern
On 7/27/15 2:30 PM, Eric W. Biederman wrote: This paragraph is false when it comes to sockets, as I have already pointed out. - VPN Routing and Forwarding (RFC4364 and it's kin) implies isolation strong enough to allow using the the same ip on different machines in different VPN instances

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Eric Dumazet
On Tue, 2015-07-28 at 14:19 +0200, Hannes Frederic Sowa wrote: > Hello Eric, > > On Mon, 2015-07-27 at 15:33 -0500, Eric W. Biederman wrote: > > David Ahern writes: > > > > > Allow tasks to have a default device index for binding sockets. If > > > set > > > the value is passed to all AF_INET/AF

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread roopa
On 7/28/15, 6:04 AM, Hannes Frederic Sowa wrote: On Mon, 2015-07-27 at 23:40 -0700, Roopa Prabhu wrote: From: Roopa Prabhu Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP to lookup

Re: [PATCH 1/3] net: mdio-octeon: Modify driver to work on both ThunderX and Octeon

2015-07-28 Thread David Daney
On 07/27/2015 07:14 PM, mohun...@gmail.com wrote: From: Radha Mohan Chintakuntla This patch modifies the mdio-octeon driver to work on both ThunderX and Octeon SoCs from Cavium Inc. Signed-off-by: Sunil Goutham Signed-off-by: Radha Mohan Chintakuntla Signed-off-by: David Daney --- drivers

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Andy Lutomirski
On Jul 27, 2015 11:33 AM, "David Ahern" wrote: > > Allow tasks to have a default device index for binding sockets. If set > the value is passed to all AF_INET/AF_INET6 sockets when they are created. > This is not intended to be a review of the concept. I haven't thought about whether the concept

[PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-28 Thread Julien Grall
Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This brough some misimplementation of helpers on ARM and make the developper confused the expected behavior. For instance, with pfn_to_mfn, we expect to g

[PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-28 Thread Julien Grall
Hi all, This patch series aims to use the memory terminologies described in include/linux/mm.h [1] for Linux xen code. Linux is using mistakenly MFN when GFN is meant, I suspect this is because the first support of Xen was for PV. This has brought some misimplementation of memory helpers on ARM a

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Hannes Frederic Sowa
On Tue, 2015-07-28 at 08:54 -0500, Eric W. Biederman wrote: > Hannes Frederic Sowa writes: > > > Hello Eric, > > > > On Mon, 2015-07-27 at 15:33 -0500, Eric W. Biederman wrote: > > > David Ahern writes: > > > > > > > Allow tasks to have a default device index for binding sockets. > > > > If

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread Robert Shearman
On 28/07/15 07:40, Roopa Prabhu wrote: From: Roopa Prabhu Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP to lookup nexthop device if user has not specified it in RTA_OIF attribute.

[PATCH net] sctp: fix sockopt size check

2015-07-28 Thread Marcelo Ricardo Leitner
The problem is not on being bigger than what we want, but on being smaller, as it causes read of invalid memory. Note that the struct changes on commit 7e8616d8e773 didn't affect sctp_setsockopt_events one but that's where this check was flipped. Fixes: 7e8616d8e773 ("[SCTP]: Update AUTH structur

[PATCH net-next 0/5] s390/bpf: recache skb->data/hlen for skb_vlan_push/pop

2015-07-28 Thread Michael Holzheu
Hi Dave, Here the s390 backend for Alexei's patch 4e10df9a60d9 ("bpf: introduce bpf_skb_vlan_push/pop() helpers") plus two bugfixes and two minor improvements. The first patch "s390/bpf: clear correct BPF accumulator register" will also go upstream via Martin's "fixes" branch. Ok for you? Regar

[PATCH net-next 3/5] s390/bpf: increase BPF_SIZE_MAX

2015-07-28 Thread Michael Holzheu
Currently we have the restriction that jitted BPF programs can have a maximum size of one page. The reason is that we use short displacements for the literal pool. The 20 bit displacements are available since z990 and BPF requires z196 as minimum. Therefore we can remove this restriction and use e

[PATCH net-next 4/5] s390/bpf: Only clear A and X for converted BPF programs

2015-07-28 Thread Michael Holzheu
Only classic BPF programs that have been converted to eBPF need to clear the A and X registers. We can check for converted programs with: bpf_prog->type == BPF_PROG_TYPE_UNSPEC So add the check and skip initialization for real eBPF programs. Signed-off-by: Michael Holzheu --- arch/s390/net/b

[PATCH net-next 5/5] s390/bpf: recache skb->data/hlen for skb_vlan_push/pop

2015-07-28 Thread Michael Holzheu
Allow eBPF programs attached to TC qdiscs call skb_vlan_push/pop via helper functions. These functions may change skb->data/hlen. This data is cached by s390 JIT to improve performance of ld_abs/ld_ind instructions. Therefore after a change we have to reload the data. In case of usage of skb_vlan_

[PATCH net-next 2/5] s390/bpf: Fix multiple macro expansions

2015-07-28 Thread Michael Holzheu
The EMIT6_DISP_LH macro passes the "disp" parameter to the _EMIT6_DISP_LH macro. The _EMIT6_DISP_LH macro uses the "disp" parameter twice: unsigned int __disp_h = ((u32)disp) & 0xff000; unsigned int __disp_l = ((u32)disp) & 0x00fff; The EMIT6_DISP_LH is used several times with EMIT_CONST_U64()

[PATCH net-next 1/5] s390/bpf: clear correct BPF accumulator register

2015-07-28 Thread Michael Holzheu
Currently we assumed the following BPF to eBPF register mapping: - BPF_REG_A -> BPF_REG_7 - BPF_REG_X -> BPF_REG_8 Unfortunately this mapping is wrong. The correct mapping is: - BPF_REG_A -> BPF_REG_0 - BPF_REG_X -> BPF_REG_7 So clear the correct registers and use the BPF_REG_A and BPF_REG_

[PATCH] net: rfkill-regulator: fix compiler warning

2015-07-28 Thread Robert ABEL
pdata char* name => const char* name Signed-off-by: Robert ABEL --- include/linux/rfkill-regulator.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/rfkill-regulator.h b/include/linux/rfkill-regulator.h index aca36bc..594d8e7 100644 --- a/include/linux/rfkill-re

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Eric W. Biederman
Hannes Frederic Sowa writes: > Hello Eric, > > On Mon, 2015-07-27 at 15:33 -0500, Eric W. Biederman wrote: >> David Ahern writes: >> >> > Allow tasks to have a default device index for binding sockets. If >> > set >> > the value is passed to all AF_INET/AF_INET6 sockets when they are >> > crea

  1   2   >