[PATCH net-next] ipv6: Do not iterate over all interfaces when finding source address on specific interface.

2015-07-09 Thread YOSHIFUJI Hideaki/吉藤英明
If outgoing interface is specified and the candidate addresses are restricted to the outgoing interface, it is enough to iterate over that given interface only. Signed-off-by: YOSHIFUJI Hideaki --- net/ipv6/addrconf.c | 201 +--- 1 file changed, 11

Re: [PATCH net-next v2] ipv6: sysctl to restrict candidate source addresses

2015-07-09 Thread YOSHIFUJI Hideaki
David Miller wrote: > So we should look at a way at making the new behavior the default, and > in fact that makes sense and we can even optimize this piece of saddr > selection code to not do an iteration over all devices in the system > for no reason at all. It can just do a quick dev_get_by_ind

[PATCH nf-next] net-ipvs: Delete an unnecessary check before the function call "module_put"

2015-07-09 Thread Simon Horman
From: Markus Elfring The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Simon Horman --- net/netfilter/i

[GIT PULL nf-next] IPVS for v4.3

2015-07-09 Thread Simon Horman
please consider this cleanup from Markus Elfring which removes a redundant check before calling module_put(). Markus Elfring (1): net-ipvs: Delete an unnecessary check before the function call "module_put" net/netfilter/ipvs/ip_vs_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH] team: set IFF_SLAVE on team ports

2015-07-09 Thread Jiri Pirko
Thu, Jul 09, 2015 at 05:36:55PM CEST, jblu...@infradead.org wrote: >On Thu, Jul 9, 2015 at 12:07 PM, Jiri Pirko wrote: >> Thu, Jul 09, 2015 at 11:58:34AM CEST, jblu...@infradead.org wrote: >>>The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to >>>decide if it should start the

[PATCH] net: Drop owner assignment from platform_driver

2015-07-09 Thread Krzysztof Kozlowski
platform_driver does not need to set an owner because platform_driver_register() will set it. Signed-off-by: Krzysztof Kozlowski --- The coccinelle script which generated the patch was sent here: http://www.spinics.net/lists/kernel/msg2029903.html --- drivers/net/ethernet/hisilicon/hip04_eth.c

Re: [PATCH net] bridge: fix potential crash in __netdev_pick_tx()

2015-07-09 Thread David Miller
From: Eric Dumazet Date: Thu, 09 Jul 2015 18:56:07 +0200 > From: Eric Dumazet > > Commit c29390c6dfee ("xps: must clear sender_cpu before forwarding") > fixed an issue in normal forward path, caused by sender_cpu & napi_id > skb fields being an union. > > Bridge is another point where skb can

Re: [RFC net-next 0/6] Proposal for VRF-lite - v2

2015-07-09 Thread Scott Feldman
On Mon, Jul 6, 2015 at 8:03 AM, David Ahern wrote: > In the context of internet scale routing a requirement that always > comes up is the need to partition the available routing tables into > disjoint routing planes. A specific use case is the multi-tenancy > problem where each tenant has their ow

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread Eric W. Biederman
David Ahern writes: > On 7/9/15 9:55 PM, Eric W. Biederman wrote: >>> IP addresses are per interface and interfaces are uniquely assigned to >>> a VRF so why do you think IP addresses are not per VRF? >> >> I have read large swaths of the linux networking code over the years. >> >> Further I was

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-09 Thread Vineet Gupta
On Thursday 09 July 2015 11:55 PM, Arend van Spriel wrote: > On 07/09/2015 10:13 AM, Vineet Gupta wrote: >> > There's already a generic implementation so use that instead. > There is or there was? If there is now I am fine with this patch, but if > it already was there the author might have had a

Re: [PATCH net-next] tcp: do not export tcp_init_xmit_timers()

2015-07-09 Thread David Miller
From: Eric Dumazet Date: Thu, 09 Jul 2015 18:01:40 +0200 > From: Eric Dumazet > > After commit 900f65d361d3 ("tcp: move duplicate code from > tcp_v4_init_sock()/tcp_v6_init_sock()"), we no longer > need to export tcp_init_xmit_timers() > > Signed-off-by: Eric Dumazet > Cc: Neal Cardwell App

Re: [RFT PATCH] net: axienet: Fix devm_ioremap_resource return value check

2015-07-09 Thread David Miller
From: Krzysztof Kozlowski Date: Thu, 9 Jul 2015 22:21:20 +0900 > Value returned by devm_ioremap_resource() was checked for non-NULL but > devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of > error this could lead to dereference of ERR_PTR. > > Signed-off-by: Krzysztof Kozlowski

Re: [PATCH net-next] bridge: mdb: fill state in br_mdb_notify

2015-07-09 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 9 Jul 2015 03:11:10 -0700 > Fill also the port group state when sending notifications. > > Signed-off-by: Satish Ashok > Signed-off-by: Nikolay Aleksandrov This looks fine, applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netd

Re: [PATCH] route: remove unsed variable in __mkroute_input

2015-07-09 Thread David Miller
From: Masatake YAMATO Date: Thu, 9 Jul 2015 12:46:35 +0900 > flags local variable in __mkroute_input is not used as a variable. > > Signed-off-by: Masatake YAMATO Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vge

[PATCH] net: phy: Support setting polarity in marvell phy driver

2015-07-09 Thread David Thomson
Support manually setting the polarity to mdi or mdix Signed-off-by: David Thomson --- drivers/net/phy/marvell.c | 42 -- drivers/net/phy/phy.c | 1 + 2 files changed, 41 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/n

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread David Ahern
On 7/9/15 9:55 PM, Eric W. Biederman wrote: IP addresses are per interface and interfaces are uniquely assigned to a VRF so why do you think IP addresses are not per VRF? I have read large swaths of the linux networking code over the years. Further I was thinking more about non-local addresses

Re: [PATCH net] net: bcmgenet: fix accounting of packet drops vs errors

2015-07-09 Thread David Miller
From: Petri Gynther Date: Thu, 09 Jul 2015 01:55:02 + > bcmgenet driver needs to separate packet drops from packet errors. > > When the driver has to drop a *good* packet, due to lack of buffers or > replacement skbs, increment only dev->stats.[rx|tx]_dropped. > > When the driver encounters

Re: [PATCH net-next] ipv6: Nonlocal bind

2015-07-09 Thread David Miller
From: Tom Herbert Date: Wed, 8 Jul 2015 16:58:22 -0700 > Add support to allow non-local binds similar to how this was done for IPv4. > Non-local binds are very useful in emulating the Internet in a box, etc. > > This add the ip_nonlocal_bind sysctl under ipv6. > > Testing: > > Set up nonlocal

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread Eric W. Biederman
David Ahern writes: > On 7/9/15 7:36 PM, Eric W. Biederman wrote: >> Sowmini Varadhan writes: >> >>> On Thu, Jul 9, 2015 at 7:19 PM, David Ahern >>> wrote: >>> On the to-do list to use cmsg to specify a VRF for outbound packets using non-connected sockets. I do not believe it is goin

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread David Ahern
On 7/9/15 9:28 PM, Sowmini Varadhan wrote: On Fri, Jul 10, 2015 at 4:39 AM, David Ahern wrote: If I set the VRF context (ie., set the SO_BINDTODEVICE for all sockets) of any RDS, NFS or any other socket app it runs in that VRF context and works just fine What if the application wants to do S

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread Sowmini Varadhan
On Fri, Jul 10, 2015 at 4:39 AM, David Ahern wrote: > If I set the VRF context (ie., set the SO_BINDTODEVICE for all sockets) of > any RDS, NFS or any other socket app it runs in that VRF context and works > just fine What if the application wants to do SO_BINDTODEVICE? -- To unsubscribe from th

RE: [PATCH] bnx2:Make various functions to have a return type of void in the file bnx2.c

2015-07-09 Thread Sony Chacko
> -Original Message- > From: Nicholas Krause [mailto:xerofo...@gmail.com] > Sent: Wednesday, July 08, 2015 11:31 AM > To: Sony Chacko > Cc: Dept-GE Linux NIC Dev; netdev; linux-kernel > Subject: [PATCH] bnx2:Make various functions to have a return > type of void in the file bnx2.c > > This

Re: Fighting out-of-order reception with RPS?

2015-07-09 Thread Tom Herbert
On Wed, Jul 8, 2015 at 10:55 PM, Oliver Hartkopp wrote: > > On 08.07.2015 23:17, Tom Herbert wrote: >> >> On Wed, Jul 8, 2015 at 10:49 AM, Oliver Hartkopp >> wrote: > > (..) >>> >>> When receiving CAN frames from a specific CAN network interface (e.g. >>> can0) >>> the frames are sporadically out

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread David Ahern
On 7/9/15 11:28 AM, Sowmini Varadhan wrote: On Thu, Jul 9, 2015 at 7:19 PM, David Ahern wrote: On the to-do list to use cmsg to specify a VRF for outbound packets using non-connected sockets. I do not believe it is going to work, but need to look into it. What about setting ipsec policy for

Re: [PATCH] net: phy: Pass mdix ethtool setting through to phy driver

2015-07-09 Thread Florian Fainelli
Le 07/09/15 18:56, David Thomson a écrit : > Pass the mdix setting from ethtool down to the phy driver, to allow > driver specific implementations of manually setting the polarity. > > Signed-off-by: David Thomson Reviewed-by: Florian Fainelli Looking forwarding to see an user of this! > ---

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread David Ahern
On 7/9/15 7:36 PM, Eric W. Biederman wrote: Sowmini Varadhan writes: On Thu, Jul 9, 2015 at 7:19 PM, David Ahern wrote: On the to-do list to use cmsg to specify a VRF for outbound packets using non-connected sockets. I do not believe it is going to work, but need to look into it. What abo

[PATCH] net: phy: Pass mdix ethtool setting through to phy driver

2015-07-09 Thread David Thomson
Pass the mdix setting from ethtool down to the phy driver, to allow driver specific implementations of manually setting the polarity. Signed-off-by: David Thomson --- drivers/net/phy/phy.c | 2 ++ include/linux/phy.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/net/phy/phy.c

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread Eric W. Biederman
Sowmini Varadhan writes: > On Thu, Jul 9, 2015 at 7:19 PM, David Ahern wrote: > >> On the to-do list to use cmsg to specify a VRF for outbound packets using >> non-connected sockets. I do not believe it is going to work, but need to >> look into it. >> >>> What about setting ipsec policy for int

[PATCH] nf: IDLETIMER: fix lockdep warning

2015-07-09 Thread Dmitry Torokhov
Dynamically allocated sysfs attributes should be initialized with sysfs_attr_init() otherwise lockdep will be angry with us: [ 45.468653] BUG: key ffc030fad4e0 not in .data! [ 45.468655] [ cut here ] [ 45.468666] WARNING: CPU: 0 PID: 1176 at /mnt/host/source/src/

[PATCH net-next v5 3/4] rocker: Handle protodown notifications.

2015-07-09 Thread anuradhak
From: Anuradha Karuppiah protodown can be set by user space applications like MLAG on detecting errors on a switch port. This patch provides sample switch driver changes for handling protodown. Rocker PHYS disables the port in response to protodown. To test this unctionality I used the qemu-rock

[PATCH net-next v5 0/4] net: Introduce protodown flag.

2015-07-09 Thread anuradhak
From: Anuradha Karuppiah User space daemons can detect errors in the network that need to be notified to the switch device drivers. Drivers can react to this error state by doing a phy-down on the switch-port which would result in a carrier-off locally and on the directly connected switch. Doing

[PATCH net-next v5 2/4] netlink: changes for setting and clearing protodown via netlink.

2015-07-09 Thread anuradhak
From: Anuradha Karuppiah A nested attribute has been added allowing apps to update bits (IF_PROTOF_DOWN) in the proto_flags field. Signed-off-by: Anuradha Karuppiah Signed-off-by: Andy Gospodarek Signed-off-by: Roopa Prabhu Signed-off-by: Wilson Kok --- include/uapi/linux/if_link.h | 10 +

[PATCH net-next v5 4/4] ip link: proto_down config and display.

2015-07-09 Thread anuradhak
From: Anuradha Karuppiah This patch adds support to set and display the IF_PROTOF_DOWN proto_flag. One example user space application setting this flag is a multi-chassis LAG application to handle split-brain situation on peer-link failure. Example: root@net-next:~# ip link set eth1 protodown on

[PATCH net-next v5 1/4] net core: Add protodown support.

2015-07-09 Thread anuradhak
From: Anuradha Karuppiah This patch introduces the IF_PROTOF_DOWN flag via proto_flags that can be used by user space applications to notify switch drivers that errors have been detected on the device. The switch driver can react to protodown notification by doing a phys down on the associated s

Re: [patch iproute2] iproute2: ipa: show switch id

2015-07-09 Thread Stephen Hemminger
On Thu, 9 Jul 2015 08:09:18 +0200 Jiri Pirko wrote: > Thu, Jul 09, 2015 at 03:05:10AM CEST, step...@networkplumber.org wrote: > >On Wed, 8 Jul 2015 17:08:18 +0200 > >Jiri Pirko wrote: > > > >> > >> + if (tb[IFLA_PHYS_SWITCH_ID]) { > >> + SPRINT_BUF(b1); > >> + fprintf(fp, "

Re: [PATCH net-next 1/5] net: don't reforward packets already forwarded by offload device

2015-07-09 Thread David Miller
From: sfel...@gmail.com Date: Wed, 8 Jul 2015 16:16:39 -0700 > @@ -653,6 +654,9 @@ struct sk_buff { > #ifdef CONFIG_NETWORK_SECMARK > __u32 secmark; > #endif > +#ifdef CONFIG_NET_SWITCHDEV > + __u32 offload_fwd_mark; > +#endif May I humbly suggest:

Re: [net-next]Add Maximum Rx packet size supported(rx_buf_sz) variable on main structure

2015-07-09 Thread Francois Romieu
Marian Corcodel : > Variable rx_buf_sz have different values on rt8101/8102 is 16000 > bytes instead of 16383 and now is ready do set these. Where does this come from ? Datasheet ? Experimental evidence ? -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the bod

Re: Disable setting speed outside the ethtool

2015-07-09 Thread Francois Romieu
Marian Corcodel : > Set speed only on ethtool..Driver is r8169 . Why ? You should also elaborate why it's supposed to be regression-free. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: Disable executions commands outside net_device_ops structure

2015-07-09 Thread Francois Romieu
> diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 3df51fa..840a2ec 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c [...] > @@ -6881,7 +6881,7 @@ static void r8169_csum_workaround(struct > rtl8169_p

Re: [PATCH net-next 0/3] inet: timewait cleanups

2015-07-09 Thread David Miller
From: Eric Dumazet Date: Wed, 8 Jul 2015 14:28:27 -0700 > Another round of patches to make tw handling simpler. Looks good, applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [PATCH -next] ipv6: use flag instead of u16 for hop in inet6_skb_parm

2015-07-09 Thread David Miller
From: Florian Westphal Date: Wed, 8 Jul 2015 23:32:12 +0200 > Hop was always either 0 or sizeof(struct ipv6hdr). > > Signed-off-by: Florian Westphal Looks good, applied, thanks Florian. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@

Re: [PATCH 0/2] net: pktgen: fix race between pktgen_thread_worker() and kthread_stop()

2015-07-09 Thread David Miller
From: Oleg Nesterov Date: Wed, 8 Jul 2015 21:41:54 +0200 > I am not familiar with this code and I have no idea how to test > these changes, so 2/2 comes as a separate change. 1/2 looks like > the obvious bugfix, and probably candidate for -stable. These look fine to me, applied and patch #1 queu

Re: [PATCH v3] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-07-09 Thread David Miller
From: Christopher Hall Date: Wed, 8 Jul 2015 13:46:41 -0700 > This patch allows system and device time ("cross-timestamp") to be > performed by the driver. Currently, the cross-timestamping is performed > in the PTP_SYS_OFFSET ioctl. The PTP clock driver reads gettimeofday() > and the gettime64

Re: [PATCH V3] cdc_ncm: Add support for moving NDP to end of NCM frame

2015-07-09 Thread David Miller
From: Enrico Mioso Date: Wed, 8 Jul 2015 13:05:57 +0200 > NCM specs are not actually mandating a specific position in the frame for > the NDP (Network Datagram Pointer). However, some Huawei devices will > ignore our aggregates if it is not placed after the datagrams it points > to. Add support

Re: [net PATCH v2 1/1] drivers: net: cpsw: fix disabling of tx interrupt in rx isr

2015-07-09 Thread David Miller
From: Mugunthan V N Date: Wed, 8 Jul 2015 14:35:22 +0530 > In commit 'c03abd84634d ("net: ethernet: cpsw: don't requests > IRQs we don't use")', common isr is split into tx and rx, but > in rx isr tx interrupt is also disabledi in cpsw_disable_irq(). > So tx interrupts are not handled during rx i

Re: [PATCH] net: systemport: Use eth_hw_addr_random

2015-07-09 Thread David Miller
From: Vaishali Thakkar Date: Wed, 8 Jul 2015 10:49:30 +0530 > Use eth_hw_addr_random() instead of calling random_ether_addr(). > Here, this change is setting addr_assign_type to NET_ADDR_RANDOM. > > The Coccinelle semantic patch that performs this transformation > is as follows: > > @@ > identi

Re: [PATCH 1/2] of_mdio: add new DT property 'link' for fixed-link

2015-07-09 Thread Stas Sergeev
10.07.2015 00:15, Florian Fainelli пишет: On 09/07/15 13:43, Stas Sergeev wrote: 09.07.2015 21:24, Florian Fainelli пишет: (there is no such thing as linux-...@vger.kernel.org, please remove it from your future submissions). On 09/07/15 10:38, Stas Sergeev wrote: Currently for fixed-link the

Re: [PATCH] dsa: mv88e6352/mv88e6xxx: Add support for Marvell 88E6320 and 88E6321

2015-07-09 Thread David Miller
From: Guenter Roeck Date: Tue, 7 Jul 2015 20:38:15 -0700 > From: "Aleksey S. Kazantsev" > > MV88E6320 and MV88E6321 are largely compatible to MV886352, > but are members of a different chip family. > > Signed-off-by: Aleksey S. Kazantsev > Signed-off-by: Guenter Roeck Applied, thanks. -- T

Re: [PATCH] dsa: mv88e6352/mv88e6xxx: Add support for Marvell 88E6320 and 88E6321

2015-07-09 Thread David Miller
From: Andrew Lunn Date: Wed, 8 Jul 2015 16:52:34 +0200 > On Tue, Jul 07, 2015 at 08:38:15PM -0700, Guenter Roeck wrote: >> From: "Aleksey S. Kazantsev" >> >> MV88E6320 and MV88E6321 are largely compatible to MV886352, >> but are members of a different chip family. >> >> Signed-off-by: Aleksey

Re: [PATCH] net: systemport: Use eth_hw_addr_random

2015-07-09 Thread Florian Fainelli
On 07/07/15 22:19, Vaishali Thakkar wrote: > Use eth_hw_addr_random() instead of calling random_ether_addr(). > Here, this change is setting addr_assign_type to NET_ADDR_RANDOM. > > The Coccinelle semantic patch that performs this transformation > is as follows: > > @@ > identifier a,b; > @@ > >

Re: [PATCH 2/2] mvneta: use inband status only when link type is "auto"

2015-07-09 Thread Stas Sergeev
10.07.2015 00:14, Florian Fainelli пишет: On 09/07/15 13:26, Stas Sergeev wrote: 09.07.2015 21:18, Florian Fainelli пишет: On 09/07/15 10:41, Stas Sergeev wrote: The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link state signaling") implemented the link parameters auto-negotiat

Re: [PATCH net-next 0/3] tcp: fixes some congestion control corner cases

2015-07-09 Thread David Miller
From: Yuchung Cheng Date: Thu, 9 Jul 2015 13:16:28 -0700 > This patch series fixes corner cases of TCP congestion control. > First issue is to avoid continuing slow start when cwnd reaches ssthresh. > Second issue is incorrectly processing order of congestion state and > cwnd update when enterin

Re: [net-next PATCH] net: skb_defer_rx_timestamp should check for phydev before setting up classify

2015-07-09 Thread David Miller
From: Alexander Duyck Date: Thu, 09 Jul 2015 11:02:52 -0700 > This change makes it so that the call skb_defer_rx_timestamp will first > check for a phydev before going in and manipulating the skb->data and > skb->len values. By doing this we can avoid unnecessary work on network > devices that d

Re: [PATCH net-next] tcp: v1 always send a quick ack when quickacks are enabled

2015-07-09 Thread David Miller
From: Jon Maxwell Date: Wed, 8 Jul 2015 10:12:28 +1000 > V1 of this patch contains Eric Dumazet's suggestion to move the per > dst RTAX_QUICKACK check into tcp_in_quickack_mode(). Thanks Eric. > > I ran some tests and after setting the "ip route change quickack 1" > knob there were still many d

Re: [PATCH 1/2] of_mdio: add new DT property 'link' for fixed-link

2015-07-09 Thread Florian Fainelli
On 09/07/15 13:43, Stas Sergeev wrote: > 09.07.2015 21:24, Florian Fainelli пишет: >> (there is no such thing as linux-...@vger.kernel.org, please remove it >> from your future submissions). >> >> On 09/07/15 10:38, Stas Sergeev wrote: >>> Currently for fixed-link the link state is always set to UP

Re: [PATCH 2/2] mvneta: use inband status only when link type is "auto"

2015-07-09 Thread Florian Fainelli
On 09/07/15 13:26, Stas Sergeev wrote: > 09.07.2015 21:18, Florian Fainelli пишет: >> On 09/07/15 10:41, Stas Sergeev wrote: >>> The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link >>> state >>> signaling") implemented the link parameters auto-negotiation >>> unconditionally. >>> U

[PATCH v2] net: dsa: mv88e6xxx: add write access to debugfs regs file

2015-07-09 Thread Vivien Didelot
Allow write access to the regs file in the debugfs interface, with the following parameters: echo> regs Where "name" is the register name (as shown in the header row), "reg" is the register address (as shown in the first column) and "value" is the 16-bit value. e.g.: echo GLOBAL 1a 5

Re: [RFT PATCH] net: axienet: Fix devm_ioremap_resource return value check

2015-07-09 Thread Sören Brinkmann
On Thu, 2015-07-09 at 10:21PM +0900, Krzysztof Kozlowski wrote: > Value returned by devm_ioremap_resource() was checked for non-NULL but > devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of > error this could lead to dereference of ERR_PTR. > > Signed-off-by: Krzysztof Kozlowski

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-09 Thread Vivien Didelot
Hi David, - On Jul 9, 2015, at 2:01 PM, David da...@davemloft.net wrote: > From: Vivien Didelot > Date: Wed, 8 Jul 2015 13:13:16 -0400 (EDT) > >> You're right. There's a single operation to clear the STU and VTU. I >> will send a follow-up patch to send this command during the switch >> set

Re: [RFC net-next] net: Build IPv6 into kernel by default

2015-07-09 Thread Dave Jones
On Thu, Jul 09, 2015 at 01:42:29PM -0700, Tom Herbert wrote: >For general information about IPv6, see >. > - For Linux IPv6 development information, see > . > - For specific information about IPv6 under

[PATCH v2 08/20] net/xen-netback: xenvif_gop_frag_copy: move GSO check out of the loop

2015-07-09 Thread Julien Grall
The skb doesn't change within the function. Therefore it's only necessary to check if we need GSO once at the beginning. Signed-off-by: Julien Grall Cc: Ian Campbell Cc: Wei Liu Cc: netdev@vger.kernel.org --- Changes in v2: - Patch added --- drivers/net/xen-netback/netback.c | 14 +

[PATCH v2 17/20] net/xen-netfront: Make it running on 64KB page granularity

2015-07-09 Thread Julien Grall
The PV network protocol is using 4KB page granularity. The goal of this patch is to allow a Linux using 64KB page granularity using network device on a non-modified Xen. It's only necessary to adapt the ring size and break skb data in small chunk of 4KB. The rest of the code is relying on the gran

[PATCH v2 18/20] net/xen-netback: Make it running on 64KB page granularity

2015-07-09 Thread Julien Grall
The PV network protocol is using 4KB page granularity. The goal of this patch is to allow a Linux using 64KB page granularity working as a network backend on a non-modified Xen. It's only necessary to adapt the ring size and break skb data in small chunk of 4KB. The rest of the code is relying on

Re: [PATCH 1/2] of_mdio: add new DT property 'link' for fixed-link

2015-07-09 Thread Stas Sergeev
09.07.2015 21:24, Florian Fainelli пишет: (there is no such thing as linux-...@vger.kernel.org, please remove it from your future submissions). On 09/07/15 10:38, Stas Sergeev wrote: Currently for fixed-link the link state is always set to UP. Not quite true, this is always a driver decision t

[RFC net-next] net: Build IPv6 into kernel by default

2015-07-09 Thread Tom Herbert
This patch makes the default to build IPv6 into the kernel. IPv6 now has significant traction and any remaining vestiges of IPv6 not being provided parity with IPv4 should be swept away. IPv6 is now core to the Internet and kernel. Points on IPv6 adoption: - Per Google statistics, IPv6 usage has

[PATCH 07/11] soc/bman: Add debugfs support for the BMan driver

2015-07-09 Thread Roy Pledge
From: Geoff Thorpe Add debugfs support for querying the state of hardware based Buffer Manager pools used in DPAA 1.0. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/Kconfig|7 ++ drivers/soc/fsl/qbman/Makefile |

[PATCH 06/11] soc/qman: Add self-tester for QMan driver

2015-07-09 Thread Roy Pledge
From: Geoff Thorpe Add a self test for the DPAA 1.0 Queue Manager driver. The tests ensure that the driver can properly enqueue and dequeue from frame queues using the QMan portal infrastructure. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc/

[PATCH 00/11] Freescale DPAA QBMan Drivers

2015-07-09 Thread Roy Pledge
The Freescale Data Path Acceleration Architecture (DPAA) is a set of hardware components on specific QorIQ multicore processors. This architecture provides the infrastructure to support simplified sharing of networking interfaces and accelerators by multiple CPU cores and the accelerators. The

[PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-09 Thread Roy Pledge
From: Geoff Thorpe This driver enables the Freescale DPAA 1.0 Buffer Manager block. BMan is a hardware buffer pool manager that allows accelerators connected to the SoC datapath to acquire and release buffers during data processing. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-

[PATCH 10/11] soc/qman: Add HOTPLUG_CPU support to the QMan driver

2015-07-09 Thread Roy Pledge
From: Hai-Ying Wang Add support for CPU hotplug for the DPAA 1.0 Queue Manager driver. Signed-off-by: Hai-Ying Wang Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman_portal.c | 43 +++ 1 file changed, 43 insertions(+) diff -

[PATCH 05/11] soc/bman: Add self-tester for BMan driver

2015-07-09 Thread Roy Pledge
From: Geoff Thorpe Add a self test for the DPAA 1.0 Buffer Manager driver. This test ensures that the driver can properly acquire and release buffers using the BMan portal infrastructure. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbma

[PATCH 00/11] Freescale DPAA QBMan Drivers

2015-07-09 Thread Roy Pledge
The Freescale Data Path Acceleration Architecture (DPAA) is a set of hardware components on specific QorIQ multicore processors. This architecture provides the infrastructure to support simplified sharing of networking interfaces and accelerators by multiple CPU cores and the accelerators. The

Re: [PATCH 2/2] mvneta: use inband status only when link type is "auto"

2015-07-09 Thread Stas Sergeev
09.07.2015 21:18, Florian Fainelli пишет: On 09/07/15 10:41, Stas Sergeev wrote: The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link state signaling") implemented the link parameters auto-negotiation unconditionally. Unfortunately it appears that some HW that implements SGMII pr

[PATCH 09/11] soc/bman: Add HOTPLUG_CPU support to the BMan driver

2015-07-09 Thread Roy Pledge
From: Hai-Ying Wang Add support for CPU hotplug for the DPAA 1.0 Buffer Manager driver Signed-off-by: Hai-Ying Wang Signed-off-by: Emil Medve Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/bman_portal.c | 40 +++ drivers/soc/fsl/qbman/dpaa_sys.h|

[PATCH 08/11] soc/qman: Add debugfs support for the QMan driver

2015-07-09 Thread Roy Pledge
From: Geoff Thorpe Add debugfs sypport for querying the state of hardware based queues managed by the DPAA 1.0 Queue Manager. Signed-off-by: Geoff Thorpe Signed-off-by: Emil Medve Signed-off-by: Madalin Bucur Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/Kconfig|7 + drive

[PATCH 11/11] soc/qman: add qman_delete_cgr_safe()

2015-07-09 Thread Roy Pledge
From: Madalin Bucur Add qman_delete_cgr_safe() that can be called from any CPU. This in turn schedules qman_delete_cgr() on the proper CPU. Signed-off-by: Madalin Bucur Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/qman_api.c | 46 ++ 1 file changed

[PATCH 01/11] powerpc: re-add devm_ioremap_prot()

2015-07-09 Thread Roy Pledge
From: Emil Medve devm_ioremap_prot() was removed in commit dedd24a12, and was introduced in commit b41e5fffe8. This reverts commit dedd24a12fe6735898feeb06184ee346907abb5d. Signed-off-by: Emil Medve --- arch/powerpc/include/asm/io.h |3 +++ arch/powerpc/lib/Makefile |1 + arch/pow

[PATCH net-next 0/3] tcp: fixes some congestion control corner cases

2015-07-09 Thread Yuchung Cheng
This patch series fixes corner cases of TCP congestion control. First issue is to avoid continuing slow start when cwnd reaches ssthresh. Second issue is incorrectly processing order of congestion state and cwnd update when entering fast recovery or undoing cwnd. Yuchung Cheng (3): tcp: add tcp_

[PATCH net-next 2/3] tcp: do not slow start when cwnd equals ssthresh

2015-07-09 Thread Yuchung Cheng
In the original design slow start is only used to raise cwnd when cwnd is stricly below ssthresh. It makes little sense to slow start when cwnd == ssthresh: especially when hystart has set ssthresh in the initial ramp, or after recovery when cwnd resets to ssthresh. Not doing so will also help redu

[PATCH net-next 3/3] tcp: update congestion state first before raising cwnd

2015-07-09 Thread Yuchung Cheng
The congestion state and cwnd can be updated in the wrong order. For example, upon receiving a dubious ACK, we incorrectly raise the cwnd first (tcp_may_raise_cwnd()/tcp_cong_avoid()) because the state is still Open, then enter recovery state to reduce cwnd. For another example, if the ACK indicat

[PATCH net-next 1/3] tcp: add tcp_in_slow_start helper

2015-07-09 Thread Yuchung Cheng
Add a helper to test the slow start condition in various congestion control modules and other places. This is to prepare a slight improvement in policy as to exactly when to slow start. Signed-off-by: Yuchung Cheng Signed-off-by: Neal Cardwell Signed-off-by: Eric Dumazet Signed-off-by: Nandita

Re: [RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

2015-07-09 Thread Michael Tuexen
> On 09 Jul 2015, at 18:54, Marcelo Ricardo Leitner wrote: > > Cc'ing Michael too. I'm not familiar with the Linux kernel code, so I can't comment on it. But making sure to use a source address belonging to the emitting interface makes sense for me. Best regards Michael > > On Tue, Jul 07, 2015

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-09 Thread Peter Zijlstra
On Thu, Jul 09, 2015 at 08:31:16PM +0200, Arend van Spriel wrote: > >There is or there was? If there is now I am fine with this patch, but if > >it already was there the author might have had a reason for adding a > >local function and I would like to hear that reason. > > Nevermind. Just noticed

Re: [PATCH] KVM: Add Kconfig option to signal cross-endian guests

2015-07-09 Thread Thomas Huth
On Thu, 9 Jul 2015 16:07:47 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jul 09, 2015 at 02:57:33PM +0200, Paolo Bonzini wrote: > > > > > > On 09/07/2015 11:48, Laurent Vivier wrote: > > > > > > > > > On 09/07/2015 09:49, Thomas Huth wrote: > > >> The option for supporting cross-endianness leg

Re: [PATCH v2] brcmsmac: Use kstrdup to simplify code

2015-07-09 Thread Arend van Spriel
On 07/08/2015 10:22 PM, Christophe JAILLET wrote: Replace a kmalloc+strcpy by an equivalent kstrdup in order to improve readability. Not sure if readability is really the issue here. At most it is a small reduction of driver code by using kstrdup(). Anyway, the patch looks fine so Acked-by:

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-09 Thread Arend van Spriel
On 07/09/2015 08:25 PM, Arend van Spriel wrote: On 07/09/2015 10:13 AM, Vineet Gupta wrote: There's already a generic implementation so use that instead. There is or there was? If there is now I am fine with this patch, but if it already was there the author might have had a reason for adding

Re: [PATCH] dsa: mv88e6352/mv88e6xxx: Add support for Marvell 88E6320 and 88E6321

2015-07-09 Thread Guenter Roeck
On Thu, Jul 09, 2015 at 10:53:23AM +0200, Paul Bolle wrote: > On di, 2015-07-07 at 20:38 -0700, Guenter Roeck wrote: > > --- a/drivers/net/dsa/mv88e6352.c > > +++ b/drivers/net/dsa/mv88e6352.c > > > -MODULE_ALIAS("platform:mv88e6352"); > > MODULE_ALIAS("platform:mv88e6172"); > > +MODULE_ALIAS("p

Re: [PATCH 1/2] of_mdio: add new DT property 'link' for fixed-link

2015-07-09 Thread Florian Fainelli
(there is no such thing as linux-...@vger.kernel.org, please remove it from your future submissions). On 09/07/15 10:38, Stas Sergeev wrote: > > Currently for fixed-link the link state is always set to UP. Not quite true, this is always a driver decision to make. > This patch introduces the new

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-09 Thread Arend van Spriel
On 07/09/2015 10:13 AM, Vineet Gupta wrote: There's already a generic implementation so use that instead. There is or there was? If there is now I am fine with this patch, but if it already was there the author might have had a reason for adding a local function and I would like to hear that

Re: [PATCH 2/2] mvneta: use inband status only when link type is "auto"

2015-07-09 Thread Florian Fainelli
On 09/07/15 10:41, Stas Sergeev wrote: > > The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link state > signaling") implemented the link parameters auto-negotiation unconditionally. > Unfortunately it appears that some HW that implements SGMII protocol, > doesn't generate the inban

Re: net-next is OPEN

2015-07-09 Thread David Miller
From: Sergei Shtylyov Date: Thu, 09 Jul 2015 20:48:36 +0300 >I then don't quite understand why you close net-next during the >merge window and beyond. Because when 1700+ changes are committed from us to Linus's tree we should be focused on fixing regressions and fallout from that rather

Re: [PATCH v4 0/3] net: dsa: mv88e6xxx: add support for VLAN Table Unit

2015-07-09 Thread David Miller
From: Vivien Didelot Date: Wed, 8 Jul 2015 13:13:16 -0400 (EDT) > You're right. There's a single operation to clear the STU and VTU. I > will send a follow-up patch to send this command during the switch > setup. Fix known bugs in the patch series, within the patch series, since it hasn't been m

[net-next PATCH] net: skb_defer_rx_timestamp should check for phydev before setting up classify

2015-07-09 Thread Alexander Duyck
This change makes it so that the call skb_defer_rx_timestamp will first check for a phydev before going in and manipulating the skb->data and skb->len values. By doing this we can avoid unnecessary work on network devices that don't support phydev. As a result we reduce the total instruction coun

Re: net-next is OPEN

2015-07-09 Thread Sergei Shtylyov
On 07/09/2015 08:40 PM, David Miller wrote: Please feel free to bombard me with net-next changes, which some of you have been doing already ;-(, as net-next is now open. Hm, I pulled and didn't see 4.2-rc1 tag. Is it normal? Why does it have to be there? I thought your pause durin

[PATCH 2/2] mvneta: use inband status only when link type is "auto"

2015-07-09 Thread Stas Sergeev
The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link state signaling") implemented the link parameters auto-negotiation unconditionally. Unfortunately it appears that some HW that implements SGMII protocol, doesn't generate the inband status, so it is not possible to auto-negotiate

Re: net-next is OPEN

2015-07-09 Thread David Miller
From: Sergei Shtylyov Date: Thu, 9 Jul 2015 14:49:34 +0300 > Hello. > > On 7/8/2015 11:30 PM, David Miller wrote: > >> Please feel free to bombard me with net-next changes, which some of >> you >> have been doing already ;-(, as net-next is now open. > >Hm, I pulled and didn't see 4.2-rc1

[PATCH 1/2] of_mdio: add new DT property 'link' for fixed-link

2015-07-09 Thread Stas Sergeev
Currently for fixed-link the link state is always set to UP. This patch introduces the new property 'link' that accepts the following string arguments: "up", "down" and "auto". "down" may be needed if the link is physically unconnected. "auto" is needed to enable the link paramaters auto-negotiati

Re: [PATCH] net: inet_diag: always export IPV6_V6ONLY sockopt

2015-07-09 Thread Eric Dumazet
On Thu, 2015-07-09 at 18:38 +0200, Phil Sutter wrote: > Is it possible to select that in a generic way? If I didn't misread the > code, 'ss -l' filters them out locally. It looks like sk->sk_state can > be used to determine that, but it seems to be used for TCP states only? > Or is the value 10 (TC

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread Sowmini Varadhan
On Thu, Jul 9, 2015 at 7:19 PM, David Ahern wrote: > On the to-do list to use cmsg to specify a VRF for outbound packets using > non-connected sockets. I do not believe it is going to work, but need to > look into it. > >> What about setting ipsec policy for interfaces in the vrf? >From a purely

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-09 Thread David Ahern
Hi Sowmini: On 7/8/15 12:34 PM, Sowmini Varadhan wrote: Perhaps I misunderstand the design proposal here, but a switch's VRF is essentially just a separate routing table, whose input and output interfaces are exclusively bound to the VRF. yes, and this model follows that. Can an application

  1   2   >