> diff --git a/drivers/net/ethernet/realtek/r8169.c 
> b/drivers/net/ethernet/realtek/r8169.c
> index 3df51fa..840a2ec 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
[...]
> @@ -6881,7 +6881,7 @@ static void r8169_csum_workaround(struct 
> rtl8169_private *tp,
>                       nskb = segs;
>                       segs = segs->next;
>                       nskb->next = NULL;
> -                     rtl8169_start_xmit(nskb, tp->dev);
> +                     //rtl8169_start_xmit(nskb, tp->dev);
>               } while (segs);
>  
>               dev_consume_skb_any(skb);

The original code does its best to send the data.

The suggested change drops the packet on the floor.

> @@ -6889,7 +6889,7 @@ static void r8169_csum_workaround(struct 
> rtl8169_private *tp,
>               if (skb_checksum_help(skb) < 0)
>                       goto drop;
>  
> -             rtl8169_start_xmit(skb, tp->dev);
> +             //rtl8169_start_xmit(skb, tp->dev);

Same thing as above.

>       } else {
>               struct net_device_stats *stats;
>  
> @@ -7623,7 +7623,7 @@ static int rtl_open(struct net_device *dev)
>  
>       rtl8169_init_phy(dev, tp);
>  
> -     __rtl8169_set_features(dev, dev->features);
> +       //__rtl8169_set_features(dev, dev->features);

Did you notice the "if (features ^ dev->features)" part in
rtl8169_set_features ?

Did you check that the modified code can't miss some uninitialized bits
in CplusCmd ?

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to