Commit 6559a7e8296002b4 ("cxgb4: Cleanup macros so they follow the same
style and look consistent") introduced a regression where reading MC1
memory in adapters where MC0 isn't present or MC0 size is not equal to MC1
size caused the adapter to crash due to incorrect computation of memoffset.
Fix is
On Tue, Apr 28, 2015 at 1:35 PM, Anuradha Karuppiah
wrote:
> On Tue, Apr 28, 2015 at 12:48 PM, Scott Feldman wrote:
>> On Tue, Apr 28, 2015 at 8:49 AM, Anuradha Karuppiah
>> wrote:
>>> On Mon, Apr 27, 2015 at 10:51 PM, Scott Feldman wrote:
On Mon, Apr 27, 2015 at 10:38 AM, wrote:
> F
> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of K. Y. Srinivasan
> Sent: Wednesday, April 29, 2015 9:00
> To: da...@davemloft.net; netdev@vger.kernel.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
>-Original Message-
>From: roy.qing...@gmail.com [mailto:roy.qing...@gmail.com]
>Sent: Wednesday, April 29, 2015 8:43 AM
>To: netdev@vger.kernel.org
>Cc: Du, Fan; steffen.klass...@secunet.com
>Subject: [PATCH] xfrm: fix a race in xfrm_state_lookup_byspi
>
>From: Li RongQing
>
>The returne
On Tue, 2015-04-28 at 19:11 -0700, Alexei Starovoitov wrote:
> Hi,
>
> there were many requests for performance numbers in the past, but not
> everyone has access to 10/40G nics and we need a common way to talk
> about RX path performance without overhead of driver RX. That's
> especially importan
On Tue, 2015-04-28 at 21:27 -0700, Tom Herbert wrote:
> Some users of flow keys (well just sch_choke now) need to pass
> flow_keys in skbuff cb, and use them for exact comparisons of flows
> so that skb->hash is not sufficient. In order to increase size of
> the flow_keys structure, we introduce an
In a kdump environment interfaces might be re-loaded without a proper
unload sequence in the previous running kernel.
bnx2x management FW and driver maintains a `pulse' that notifies the FW
that the driver is still up and running.
Driver load on the kdump kernel should be performed only after the
From: Martin Zhang
Date: Wed, 29 Apr 2015 11:35:59 +0800
> 'if' and 'elseif' do the same operation,
> so merge then into a case.
>
> Signed-off-by: Martin Zhang
> ---
> net/ipv4/route.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/net/ipv4/route.c b/net/ipv4
Call make_flow_keys_digest to get a digest from flow keys and
use that to pass skbuff cb and for comparing flows.
Signed-off-by: Tom Herbert
---
net/sched/sch_choke.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/net/sched/sch_choke.c b/net/sched/sch_choke.c
Call qdisc_skb_get_hash instead of doing skb_flow_dissect and then
jhash by hand.
Signed-off-by: Tom Herbert
---
net/sched/sch_hhf.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/net/sched/sch_hhf.c b/net/sched/sch_hhf.c
index 15d3aab..9d15cb6 100644
---
Some users of flow keys (well just sch_choke now) need to pass
flow_keys in skbuff cb, and use them for exact comparisons of flows
so that skb->hash is not sufficient. In order to increase size of
the flow_keys structure, we introduce another structure for
the purpose of passing flow keys in skbuff
Call qdisc_skb_get_hash instead of doing skb_flow_dissect and then
jhash by hand.
Signed-off-by: Tom Herbert
---
net/sched/sch_sfq.c | 29 +++--
1 file changed, 3 insertions(+), 26 deletions(-)
diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c
index b877140..e7ed8a5
Call qdisc_skb_get_hash instead of doing skb_flow_dissect and then
jhash by hand.
Signed-off-by: Tom Herbert
---
net/sched/sch_sfb.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/net/sched/sch_sfb.c b/net/sched/sch_sfb.c
index 5819dd8..4b81519 1006
In this patch set we add skb_get_hash_perturb which gets the skbuff
hash for a packet and perturbs it using a provided key and jhash1.
This function is used in serveral qdiscs and eliminates many calls
to flow_dissector and jhash3 to get a perturbed hash for a packet.
To handle the sch_choke issue
Call qdisc_skb_get_hash instead of doing skb_flow_dissect and then
jhash by hand.
Signed-off-by: Tom Herbert
---
net/sched/sch_fq_codel.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c
index 1e52dec..a6fc53d 100
This is used to get the skb->hash and then perturb it for a local use.
Signed-off-by: Tom Herbert
---
include/linux/skbuff.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 66e374d..b706889 100644
--- a/include/linux/skbu
On Tue, 2015-04-28 at 19:11 -0700, Alexei Starovoitov wrote:
> + if (pkt_dev->flags & F_DO_RX) {
> + local_bh_disable();
> + atomic_add(burst, &pkt_dev->skb->users);
> + do {
> + ret = netif_receive_skb(pkt_dev->skb);
> +
From: Punnaiah Choudary Kalluri
Under heavy Rx load, observed that the Hw is updating the USED bit
and it is not updating the received frame status to the BD control
field. This could be lack of resources for processing the BDs at high
data rates. Driver drops the frame associated with this BD bu
Set hash type for ingress packets according to NIC
advanced receive descriptors RSS type part.
Signed-off-by: Fan Du
---
drivers/net/ethernet/intel/ixgbevf/defines.h | 12 +
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 27 +
2 files changed, 39 inserti
For two reasons I want to disable this:
1. Not any part actually check the report status(Alexander Duyck)
2. To report hash value of a packet to stack,
RSS -> 32bits hash value
Perfect match fdir filter -> 13bits hash value
Hashed-based fdir filter -> 31bits hash value
fdir filter migh
RSS could be leveraged by taking account L4 src/dst ports
as ingredients, thus ingress skb rx hash type should honor
such the real configuration.
Signed-off-by: Fan Du
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 25 +
1 files changed, 21 insertions(+), 4 deletio
This patchset provides RSS hash value for upper stack by indicating
whether it's a L3 or L4 hash. Thus other component of network
stack could utilize this hash value provided by NIC without caculating
by themselves.
Test:
* Simple iperf test using ixgbe for 82599ES
* Build test only for ixgbevf
*
Introduce 'RX' mode for pktgen which generates the packets
using familiar pktgen commands, but feeds them into netif_receive_skb()
instead of ndo_start_xmit().
It can be used to benchmark different kernel RX paths.
Sample script 'pktgen.sh':
!/bin/bash
function pgset() {
local result
echo $1
Hi,
there were many requests for performance numbers in the past, but not
everyone has access to 10/40G nics and we need a common way to talk
about RX path performance without overhead of driver RX. That's
especially important when making changes to netif_receive_skb.
One would think that using p
For a donation. Email me ( lhirtl...@outlook.com ) for more info.
This message may contain confidential information. If you are not the intended
recipient please inform the
sender
On Tue, Apr 28, 2015 at 7:23 PM, Eric Dumazet wrote:
> Some Congestion Control modules can provide per flow information,
> but current way to get this information is to use netlink.
>
> Like TCP_INFO, let's add TCP_CC_INFO so that applications can
> issue a getsockopt() if they have a socket file
On Tue, Apr 28, 2015 at 7:23 PM, Eric Dumazet wrote:
> We would like that optional info provided by Congestion Control
> modules using netlink can also be read using getsockopt()
>
> This patch changes get_info() to put this information in a buffer,
> instead of skb, like tcp_get_info(), so that f
From: Li RongQing
The returned xfrm_state should be hold before unlock xfrm_state_lock,
otherwise the returned xfrm_state maybe be released.
Fixes: c454997e6[{pktgen, xfrm} Introduce xfrm_state_lookup_byspi..]
Cc: Fan Du
Signed-off-by: Li RongQing
---
net/xfrm/xfrm_state.c | 2 +-
1 file chan
On Tue, Apr 28, 2015 at 1:04 PM, Anuradha Karuppiah
wrote:
> On Tue, Apr 28, 2015 at 12:37 PM, Scott Feldman wrote:
>> On Tue, Apr 28, 2015 at 8:39 AM, Anuradha Karuppiah
>> wrote:
>>>
>>>
>>> On Mon, Apr 27, 2015 at 10:45 PM, Scott Feldman wrote:
On Mon, Apr 27, 2015 at 10:38 AM, w
Commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated memory
allocation in the packet send path:
"hv_netvsc: Eliminate memory allocation in the packet send path
The network protocol used to communicate with the host is the remote ndis
(rndis)
protocol. We need to decorate each o
Hello, Webmail / Email,
This message is from our message center for all our webmail users. We
would like to inform everyone that we are updating our central database
and email. Therefore,
the elimination of all emails from inactive accounts not used to create
more space for new accounts. To pre
Instead of being forced to use netlink, we want to get (optional) CC
information using a getsockopt() on the socket file handle.
Signed-off-by: Eric Dumazet
Cc: Yuchung Cheng
Cc: Neal Cardwell
Eric Dumazet (2):
tcp: prepare CC get_info() access from getsockopt()
tcp: add TCP_CC_INFO socket
We would like that optional info provided by Congestion Control
modules using netlink can also be read using getsockopt()
This patch changes get_info() to put this information in a buffer,
instead of skb, like tcp_get_info(), so that following patch
can reuse this common infrastructure.
Signed-of
Some Congestion Control modules can provide per flow information,
but current way to get this information is to use netlink.
Like TCP_INFO, let's add TCP_CC_INFO so that applications can
issue a getsockopt() if they have a socket file descriptor,
instead of playing complex netlink games.
Sample u
On Tue, 2015-04-28 at 15:56 -0700, Yuchung Cheng wrote:
> Acked-by: Yuchung Cheng
>
Thanks !
> tho I slightly prefer to call tcp_rcv_nxt_update() when rcv_nxt is
> updated in TFO for consistency.
Right, but is the tp->rcv_nxt prior value even valid at this point ? :)
Anyway, this would need
On Tue, Apr 28, 2015 at 3:28 PM, Eric Dumazet wrote:
> This patch tracks total number of payload bytes received on a TCP socket.
> This is the sum of all changes done to tp->rcv_nxt
>
> RFC4898 named this : tcpEStatsAppHCThruOctetsReceived
>
> This is a 64bit field, and can be fetched both from TC
On 27/04/15 09:13, Stephen Hemminger wrote:
> On Sat, 25 Apr 2015 22:33:28 +0200
> Felix Janda wrote:
>
>> They are equivalent but the former is more common. PATH_MAX is
>> specified by POSIX and needs while MAXPATHLEN has BSD
>> origin and needs .
>>
>> PATH_MAX has already been in use in misc/
Add support for 802.1ad including the ability to push and pop double
tagged vlans.
Signed-off-by: Thomas F Herbert
---
net/openvswitch/actions.c | 6 ++-
net/openvswitch/flow.c | 83 +++---
net/openvswitch/flow.h | 1 +
net/openvswitch/f
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/op
Add support for 802.1AD to the openvswitch kernel module.
Although the Open Flow specification specified support for 802.1AD (qinq)
as well as push and pop vlan headers, So far Open vSwitch has only
supported a single tag header.
This accompanies version 7 of the patch submitted to openvswitch
From: Vlastimil Setka
Altera TSE MAC rx DMA transfer starts with the 2 additional bytes for IP
payload alignment. This patch fixes tse_rx() function loop which reads DMA
rx status and extracts packet length from it. Status signalises a whole DMA
transfer length, which is 2 bytes longer than the p
As discussed during Chris Rapier presentation in Ottawa / netdev0.1,
we add to tcp_info the first two fields are highly wanted.
Each field is added into a single patch for easy code review.
(Corresponding iproute2/ss patches will be sent)
Next fields will follow once consensus is reached.
v2: A
This patch tracks total number of payload bytes received on a TCP socket.
This is the sum of all changes done to tp->rcv_nxt
RFC4898 named this : tcpEStatsAppHCThruOctetsReceived
This is a 64bit field, and can be fetched both from TCP_INFO
getsockopt() if one has a handle on a TCP socket, or from
This patch tracks total number of bytes acked for a TCP socket.
This is the sum of all changes done to tp->snd_una, and allows
for precise tracking of delivered data.
RFC4898 named this : tcpEStatsAppHCThruOctetsAcked
This is a 64bit field, and can be fetched both from TCP_INFO
getsockopt() if on
On Tue, 2015-04-28 at 14:07 -0700, Yuchung Cheng wrote:
> Account for received syn-data when rcv_nxt is updated in tcp_fastopen.c?
Right, I'll send a v2 with the following FO part :
Note that I do not call the helper to keep it static and inline
candidate.
Thanks !
diff --git a/net/ipv4/tcp_fa
By default, the number of tx queues is limited by the number of online cpus
in mlx4_en_get_profile(). However, this limit no longer holds after the
ethtool .set_channels method has been called. In that situation, the driver
may access invalid bits of certain cpumask variables when queue_index >=
nr
On 04/28/2015 05:15 PM, Josh Boyer wrote:
> On Tue, Apr 28, 2015 at 4:27 PM, Joseph Salisbury
> wrote:
>> Hello,
>>
>> Please consider including mainline commit
>> 957f094f221f81e457133b1f4c4d95ffa49ff731 in the next v3.19.y release.
>> It was included in the mainline tree as of v4.0-rc1. It has
On Tue, Apr 28, 2015 at 4:27 PM, Joseph Salisbury
wrote:
> Hello,
>
> Please consider including mainline commit
> 957f094f221f81e457133b1f4c4d95ffa49ff731 in the next v3.19.y release.
> It was included in the mainline tree as of v4.0-rc1. It has been tested
> and confirmed to resolve:
> http://bu
This patch creates a RTF_CACHE routes only after encountering a pmtu
exception.
After ip6_rt_update_pmtu() has inserted the RTF_CACHE route to the fib6
tree, the rt->rt6i_node->fn_sernum is bumped which will fail the
ip6_dst_check() and trigger a relookup.
Signed-off-by: Martin KaFai Lau
Reviewe
This patch removes the assumptions that the returned rt is always
a RTF_CACHE entry with the rt6i_dst and rt6i_src containing the
destination and source address. The dst and src can be recovered from
the calling site.
We may consider to rename (rt6i_dst, rt6i_src) to
(rt6i_key_dst, rt6i_key_src)
After the patch
'ipv6: Only create RTF_CACHE routes after encountering pmtu exception',
we need to compensate the performance hit (bouncing dst->__refcnt).
Signed-off-by: Martin KaFai Lau
Reviewed-by: Hannes Frederic Sowa
Cc: Steffen Klassert
---
include/net/ip6_fib.h | 8 +++
incl
This patch breaks up ip6_rt_copy() into ip6_rt_copy_init() and
ip6_rt_cache_alloc().
In the later patch, we need to create a percpu rt6_info copy. Hence,
refactor the common rt6_info init codes to ip6_rt_copy_init().
Signed-off-by: Martin KaFai Lau
Reviewed-by: Hannes Frederic Sowa
Cc: Steffen
On Tue, Apr 28, 2015 at 10:32 AM, Eric Dumazet wrote:
> This patch tracks total number of payload bytes received on a TCP socket.
> This is the sum of all changes done to tp->rcv_nxt
>
> RFC4898 named this : tcpEStatsAppHCThruOctetsReceived
>
> This is a 64bit field, and can be fetched both from T
A prep work for creating RTF_CACHE on exception only. After this
patch, the same condition (rt->rt6i_flags & (RTF_NONEXTHOP | RTF_GATEWAY))
is checked twice. This redundancy will be removed in the later patch.
Signed-off-by: Martin KaFai Lau
Reviewed-by: Hannes Frederic Sowa
Cc: Steffen Klasser
When creating a RTF_CACHE route, RTF_ANYCAST is set based on rt6i_dst.
Also, rt6i_gateway is always set to the nexthop while the nexthop
could be a gateway or the rt6i_dst.addr.
After removing the rt6i_dst and rt6i_src dependency in the last patch,
we also need to stop the caller from depending on
v1 -> v2:
- Move the /128 route bug fixes to another series (posted).
- Create a function for checking (rt6i_flags & (RTF_NONEXTHOP | RTF_GATEWAY)).
- Avoid shuffling the skb network_header. Instead, change the function
signature to take iph instead of skb.
The perf numbers do not change much s
On Tue, Apr 28, 2015 at 10:32 AM, Eric Dumazet wrote:
>
> This patch tracks total number of bytes acked for a TCP socket.
> This is the sum of all changes done to tp->snd_una, and allows
> for precise tracking of delivered data.
>
> RFC4898 named this : tcpEStatsAppHCThruOctetsAcked
>
> This is a
Currently, we try to accumulate arrived packets in the links's
'deferred' queue during the parallel link syncronization phase.
This entails two problems:
- With an unlucky combination of arriving packets the algorithm
may go into a lockstep with the out-of-sequence handling function,
where th
On Tue, 2015-04-28 at 16:06 -0400, Toan Pham wrote:
> > We were able to reproduce this issue internally only with iommu enabled.
>
> My last test to collect lspci-info took about 5 hours over a gigabit
> network for the bug to show up. My setup was running 3 tx scp
> sessions, each transferring a
From: Jaeden Amero
Date: Tue, 28 Apr 2015 15:36:54 -0500
> On 04/27/2015 09:47 PM, David Miller wrote:
>> From: Jaeden Amero
>> Date: Mon, 27 Apr 2015 17:43:30 -0500
>>
>> A UDP checksum of zero, means "checksum not computed". And your
>> device isn't computing the checksum at all, but rather i
This is a preparatory patch for adding ethernet support for APM X-Gene
ethernet driver to work with ring manager v2.
Added xgene_ring_ops structure for storing chip specific ring manager
properties and functions.
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_h
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 1 -
drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 26 +++---
drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 1 -
drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c | 62
Adding ring manager v2 support for APM X-Gene ethernet driver.
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/Makefile | 2 +-
drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 1 +
drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2 +
drivers/net/ethe
Signed-off-by: Iyappan Subramanian
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 1 +
drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 141 ++
drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 17 +++
drivers/net/ethernet/apm/xgene/xgene_enet_xgmac.c | 1 -
Adding XFI based 10GbE and SGMII based 1GbE with ring manager v2 support
for APM X-Gene ethernet driver. The ring manager v2 is used by 2nd
generation SoC.
v1:
* Initial version
---
Iyappan Subramanian (4):
drivers: net: xgene: Change ring manager to use function pointers
drivers: net: xgene
On 4/28/15 4:37 AM, Daniel Borkmann wrote:
Currently, only on error we get a log dump, but I found it useful when
working with eBPF to have an option to also dump the log on success.
Also spotted a typo in a header comment, which is fixed here as well.
Signed-off-by: Daniel Borkmann
Cc: Alexei
On 04/27/2015 09:47 PM, David Miller wrote:
> From: Jaeden Amero
> Date: Mon, 27 Apr 2015 17:43:30 -0500
>
> A UDP checksum of zero, means "checksum not computed". And your
> device isn't computing the checksum at all, but rather is leaving it
> at zero.
The "zero" checksum is not what gets sent
On Tue, Apr 28, 2015 at 12:48 PM, Scott Feldman wrote:
> On Tue, Apr 28, 2015 at 8:49 AM, Anuradha Karuppiah
> wrote:
>> On Mon, Apr 27, 2015 at 10:51 PM, Scott Feldman wrote:
>>> On Mon, Apr 27, 2015 at 10:38 AM, wrote:
From: Anuradha Karuppiah
IFF_PROTODOWN can be set by user
Hello,
Please consider including mainline commit
957f094f221f81e457133b1f4c4d95ffa49ff731 in the next v3.19.y release.
It was included in the mainline tree as of v4.0-rc1. It has been tested
and confirmed to resolve:
http://bugs.launchpad.net/bugs/1448942
And upstream bug report:
https://bugzill
> We were able to reproduce this issue internally only with iommu enabled.
My last test to collect lspci-info took about 5 hours over a gigabit
network for the bug to show up. My setup was running 3 tx scp
sessions, each transferring a 1GB file outbound, and 1 rx scp session
copying another 1GB f
On Tue, Apr 28, 2015 at 12:37 PM, Scott Feldman wrote:
> On Tue, Apr 28, 2015 at 8:39 AM, Anuradha Karuppiah
> wrote:
>>
>>
>> On Mon, Apr 27, 2015 at 10:45 PM, Scott Feldman wrote:
>>>
>>> On Mon, Apr 27, 2015 at 10:38 AM, wrote:
>>> > From: Anuradha Karuppiah
>>> >
>>> > User space daemons
This patch is mostly from Steffen Klassert .
I only removed the (rt6->rt6i_dst.plen == 128) check from
ip6_rt_update_pmtu() because the (rt6->rt6i_flags & RTF_CACHE) test
has already implied it.
This patch:
1. Create RTF_CACHE route for /128 non local route
2. After (1), all routes that allow pmtu
From: Steffen Klassert
We search only for routes with highest priority metric in
find_rr_leaf(). However if one of these routes is marked
as invalid, we may fail to find a route even if there is
a appropriate route with lower priority. Then we loose
connectivity until the garbage collector delete
inet_peer is indexed by the dst address alone. However, the fib6 tree
could have multiple routing entries (rt6_info) for the same dst. For
example,
1. A /128 dst via multiple gateways.
2. A RTF_CACHE route cloned from a /128 route.
In the above cases, all of them will share the same metrics and
s
The series is separated from another patch series,
'ipv6: Only create RTF_CACHE route after encountering pmtu exception',
which can be found here:
http://thread.gmane.org/gmane.linux.network/359140
This series focus on fixing the /128 route issues. It is currently targeted
for net-next due to the
_rt6i_peer is no longer needed after the last patch,
'ipv6: Stop rt6_info from using inet_peer's metrics'.
DST_METRICS_FORCE_OVERWRITE is added by
commit e5fd387ad5b3 ("ipv6: do not overwrite inetpeer metrics prematurely").
Since inetpeer is no longer used for metrics, this bit is also not needed.
It is a prep work for the later bug-fix patch which will stop /128 route
from disappearing after pmtu update.
The later bug-fix patch will allow a /128 route and its RTF_CACHE clone
both exist at the same fib6_node. To do this, we need to prepare the
existing fib6 tree search to expect RTF_CACHE
On Tue, Apr 28, 2015 at 8:49 AM, Anuradha Karuppiah
wrote:
> On Mon, Apr 27, 2015 at 10:51 PM, Scott Feldman wrote:
>> On Mon, Apr 27, 2015 at 10:38 AM, wrote:
>>> From: Anuradha Karuppiah
>>>
>>> IFF_PROTODOWN can be set by user space applications like MLAG on detecting
>>> errors on a switch
The driver unlike other drivers does not log link state changes. It's
better for an user when asynchronous link states are logged in the
system log.
v3: Changes from v2 discarded as "not necessary"
Cc: Sathya Perla
Cc: Subbu Seetharaman
Cc: Ajit Khaparde
Signed-off-by: Ivan Vecera
---
dri
> -Original Message-
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On
> Behalf Of Hiroshi Shimamoto
> Sent: Thursday, April 09, 2015 6:08 PM
> To: Kirsher, Jeffrey T; Alexander Duyck; intel-wired-lan
> Cc: vyase...@redhat.com; e1000-de...@lists.sourceforge.net;
> -Original Message-
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On
> Behalf Of Hiroshi Shimamoto
> Sent: Thursday, April 09, 2015 6:04 PM
> To: Kirsher, Jeffrey T; Alexander Duyck; intel-wired-lan
> Cc: vyase...@redhat.com; e1000-de...@lists.sourceforge.net;
On Tue, Apr 28, 2015 at 8:39 AM, Anuradha Karuppiah
wrote:
>
>
> On Mon, Apr 27, 2015 at 10:45 PM, Scott Feldman wrote:
>>
>> On Mon, Apr 27, 2015 at 10:38 AM, wrote:
>> > From: Anuradha Karuppiah
>> >
>> > User space daemons can detect errors in the network that need to be
>> > notified to th
> -Original Message-
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On
> Behalf Of Hiroshi Shimamoto
> Sent: Thursday, April 09, 2015 6:05 PM
> To: Kirsher, Jeffrey T; Alexander Duyck; intel-wired-lan
> Cc: vyase...@redhat.com; e1000-de...@lists.sourceforge.net;
I saw your email address during the course of my research today. My
name is Bill William Groner my wife and I won a Jackpot Lottery of $50
Million Dollars in December 2013, we are donating the sum of $1
million Dollars to 6 lucky individual all over the world as part of
our charity project. D
On 04/28/2015 06:44 PM, David Miller wrote:
From: Ivan Vecera
Date: Tue, 28 Apr 2015 16:32:37 +0200
On 04/23/2015 08:31 AM, Sathya Perla wrote:
-Original Message-
From: Ivan Vecera [mailto:ivec...@redhat.com]
The driver unlike other drivers does not log link state changes.
v2: added
> -Original Message-
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
> Sent: Tuesday, April 28, 2015 11:27 AM
> To: KY Srinivasan; da...@davemloft.net; netdev@vger.kernel.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@canonic
On Tue, 2015-04-28 at 11:11 -0700, Michael Chan wrote:
> On Mon, 2015-04-27 at 22:10 +, Toan Pham wrote:
> > Michael,
> >
> >
> > Please see attach files.
> >
> > BTW, I have also tested this bug on at least 8 different HP 705 PCs
> > with the 5762 NIC, so it is probably not a manufacturer
> Do you have PCIE Advanced Error Reporting (CONFIG_PCIEAER) enabled in
your kernel?
Yes, it is enabled.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello.
On 04/28/2015 04:14 AM, K. Y. Srinivasan wrote:
Commit commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated memory
One "commit" is enough. :-)
And please also specify that commit's summary in parens.
allocation in the packet send path. This commit introduced a bug since i
On Fri, Apr 10, 2015 at 7:27 PM, Benjamin Poirier wrote:
> By default, the number of tx queues is limited by the number of online cpus in
> mlx4_en_get_profile(). However, this limit no longer holds after the ethtool
> .set_channels method has been called. In that situation, the driver may access
On Mon, 2015-04-27 at 22:10 +, Toan Pham wrote:
> Michael,
>
>
> Please see attach files.
>
> BTW, I have also tested this bug on at least 8 different HP 705 PCs
> with the 5762 NIC, so it is probably not a manufacturer defect. In
> addition, I can never replicate the same issue on the old
On Tue, Apr 28, 2015 at 07:19:02PM +0300, Kalle Valo wrote:
> Rasmus Villemoes writes:
>
> > Since these fmt_* variables are just const char*, and not const
> > char[], gcc (and smatch) doesn't to type checking of the arguments to
> > the printf functions. Since the linker knows perfectly well to
As discussed during Chris Rapier presentation in Ottawa / netdev0.1,
we add to tcp_info the first two fields are highly wanted.
Each field is added into a single patch for easy code review.
(Corresponding iproute2/ss patches will be sent)
Next fields will follow once consensus is reached.
Signe
This patch tracks total number of bytes acked for a TCP socket.
This is the sum of all changes done to tp->snd_una, and allows
for precise tracking of delivered data.
RFC4898 named this : tcpEStatsAppHCThruOctetsAcked
This is a 64bit field, and can be fetched both from TCP_INFO
getsockopt() if on
This patch tracks total number of payload bytes received on a TCP socket.
This is the sum of all changes done to tp->rcv_nxt
RFC4898 named this : tcpEStatsAppHCThruOctetsReceived
This is a 64bit field, and can be fetched both from TCP_INFO
getsockopt() if one has a handle on a TCP socket, or from
On Fri, 2015-04-24 at 21:53 +0300, Sergei Shtylyov wrote:
> On 04/23/2015 02:22 AM, Florian Fainelli wrote:
>
> [...]
>
> +if (ecmd->duplex == DUPLEX_FULL)
> +priv->duplex = 1;
> +else
> +priv->duplex = 0;
>
> >>> Why not use what priv->phydev->duplex
From: Ivan Vecera
Date: Tue, 28 Apr 2015 16:32:37 +0200
> On 04/23/2015 08:31 AM, Sathya Perla wrote:
>>> -Original Message-
>>> From: Ivan Vecera [mailto:ivec...@redhat.com]
>>>
>>> The driver unlike other drivers does not log link state changes.
>>>
>>> v2: added current link speed to l
NLM_F_MULTI must be used only when a NLMSG_DONE message is sent. In fact,
it is sent only at the end of a dump.
Libraries like libnl will wait forever for NLMSG_DONE.
Fixes: 35b9dd7607f0 ("tipc: add bearer get/dump to new netlink api")
Fixes: 7be57fc69184 ("tipc: add link get/dump to new netlink
The goal of this patch is to minimize copy and paste error. The flag
NLM_F_MULTI is often set in wrong cases because people copy and paste code
that uses this flag. When this flag is set, it means that it is a
multi-part netlink message which ends with a NLMSG_DONE.
In most of the cases, only a du
The first three patches fix a wrong use of this flag.
Because it's not the first time that this kind of bug happens, it could be
good to find something to help people.
The only idea that I have is in the last patch. It's just an example, if
people agrees on it, I will update all users and submit
1 - 100 of 136 matches
Mail list logo
