On Tue, Apr 28, 2015 at 8:49 AM, Anuradha Karuppiah
<anurad...@cumulusnetworks.com> wrote:
> On Mon, Apr 27, 2015 at 10:51 PM, Scott Feldman <sfel...@gmail.com> wrote:
>> On Mon, Apr 27, 2015 at 10:38 AM, <anurad...@cumulusnetworks.com> wrote:
>>> From: Anuradha Karuppiah <anurad...@cumulusnetworks.com>
>>>
>>> IFF_PROTODOWN can be set by user space applications like MLAG on detecting
>>> errors on a switch port. This patch provides sample switch driver changes
>>> for handling IFF_PROTODOWN. Rocker PHYS disables the port in response to
>>> protodown.
>>>
>>> Note: I understand Scott has some rocker changes on hold. I will re-spin
>>> this patch once his changes are in.
>>>
>>> Signed-off-by: Anuradha Karuppiah <anurad...@cumulusnetworks.com>
>>> Signed-off-by: Andy Gospodarek <go...@cumulusnetworks.com>
>>> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com>
>>> Signed-off-by: Wilson Kok <w...@cumulusnetworks.com>
>>> ---
>>> drivers/net/ethernet/rocker/rocker.c | 16 +++++++++++++++-
>>> 1 file changed, 15 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/rocker/rocker.c
>>> b/drivers/net/ethernet/rocker/rocker.c
>>> index a87b177..e3084e3 100644
>>> --- a/drivers/net/ethernet/rocker/rocker.c
>>> +++ b/drivers/net/ethernet/rocker/rocker.c
>>> @@ -3838,7 +3838,8 @@ static int rocker_port_open(struct net_device *dev)
>>>
>>> napi_enable(&rocker_port->napi_tx);
>>> napi_enable(&rocker_port->napi_rx);
>>> - rocker_port_set_enable(rocker_port, true);
>>> + if (!(dev->flags & IFF_PROTO_DOWN))
>>> + rocker_port_set_enable(rocker_port, true);
>>> netif_start_queue(dev);
>>> return 0;
>>>
>>> @@ -4238,6 +4239,18 @@ static int rocker_port_swdev_port_stp_update(struct
>>> net_device *dev, u8 state)
>>> return rocker_port_stp_update(rocker_port, state);
>>> }
>>>
>>> +static int rocker_port_swdev_port_phy_state_set(struct net_device *dev,
>>> + bool enable)
>>> +{
>>> + struct rocker_port *rocker_port = netdev_priv(dev);
>>> +
>>> + if (enable && (dev->flags & IFF_UP) && !(dev->flags &
>>> IFF_PROTO_DOWN))
>>> + rocker_port_set_enable(rocker_port, true);
>>> + else
>>> + rocker_port_set_enable(rocker_port, false);
>>
>> This isn't working like your expecting. PHY link is still up on the
>> rocker port, so the other end of the wire still sees link UP even when
>> IFF_PROTO_DOWN is set locally.
>
> I wanted to check with you first on the rocker handling; that is the main
> reason for posting this an RFC (thanks for the review).
>
> I used rocker_port_set_enable/PORT_PHYS_ENABLE for setting the phy state
> because I assumed that in the case of an offloaded switch driver it would be
> the equivalent of doing "sdk port N en=1|0". Is that not the case? If not,
> could you please point me in the right direction?
To put PHY link down, on PORT_PHYS_ENABLE true, rocker device (qemu)
would need to down the link state for the port so other end of wire
sees link down. I think I remember looking into that but didn't
implement it. In qemu monitor, you can manually set the link up/down
(set_link <dev> [on|off]). We'd need to call the same from within the
rocker device.
So if we want to be able to test this with rocker, we'll need a device
and driver change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
