On Thu, 17 Jan 2008 17:57:58 +1100 Rusty Russell <[EMAIL PROTECTED]> wrote:
> I assume that these ancient network drivers were trying to find out if
> an irq is available. eepro.c expecting +EBUSY was doubly wrong.
>
> I'm not sure that can_request_irq() is the right thing, but these drivers
> a
On Sun, Feb 03, 2008 at 12:37:19AM +, Al Viro wrote:
>
> This is still very odd... Where do you initialize ->seq.input? What
In xfrm_input.
> guarantees that async call of xfrm_input() will be always preceded by
> at least one non-async one?
OK I admit it isn't pretty. But the encap_type
Li Zefan wrote:
> Miguel Botón 写道:
>> Li Zefan wrote:
>>> Add CCs:
>>>
>>> CC: [EMAIL PROTECTED]
>>> CC: [EMAIL PROTECTED]
>>> CC: [EMAIL PROTECTED]
>>>
>>> Li Zefan wrote:
drivers/net/b44.c: In function 'b44_remove_one':
drivers/net/b44.c:2231: error: implicit declaration of function
>>
Miguel Botón 写道:
> Li Zefan wrote:
>> Add CCs:
>>
>> CC: [EMAIL PROTECTED]
>> CC: [EMAIL PROTECTED]
>> CC: [EMAIL PROTECTED]
>>
>> Li Zefan wrote:
>>> drivers/net/b44.c: In function 'b44_remove_one':
>>> drivers/net/b44.c:2231: error: implicit declaration of function
>>> 'ssb_pcihost_set_power_sta
In preparation for a future atl2 driver for the Atheros L2 10/100 chip,
we propose to move the existing atl1 driver to a new directory
(drivers/net/atlx), then split out functions and definitions that both
atl1 and atl2 can share. The final structure will look like this:
drivers/net/atl1
Make needlessly global functions static. In a couple of cases this
requires removing forward declarations and reordering functions.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 101
Rearrange functions to allow removal of some forward declarations.
Make certain global functions static along the way.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 1406 +++---
driver
Use netif_msg_* for console messages emitted by the driver. Add a
parameter to allow control of messaging at driver startup, and also
add the ability to control it with ethtool.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c |
Add some debug printks if we encounter a potentially bad receive
return descriptor.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 26 ++
1 files changed, 22 insertions(+), 4 deletions(-)
diff --git
Use skb->csum_start for tx checksum offload preparation. Also swap
the variables css and cso so they hold the intended values of csum
start and offset, respectively.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 11 ++-
The transmit packet descriptor consists of four 32-bit words, with word 3
upper bits overloaded depending upon the condition of its bits 3 and 4.
The driver currently duplicates all word 2 and some word 3 register bit
definitions unnecessarily and also uses a set of nested structures in its
definit
Add the ethtool register dump option to the atl1 driver.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
Acked-by: Chris Snook <[EMAIL PROTECTED]>
---
drivers/net/atlx/atl1.c | 53 +++
drivers/net/atlx/atl1.h |1 +
2 files changed, 54 insertions(+)
In preparation for a future Atheros L2 NIC driver (called atl2), relocate
the atl1 driver into a new /drivers/net/atlx directory that will ultimately
be shared with the future atl2 driver.
Signed-off-by: Chris Snook <[EMAIL PROTECTED]>
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/ne
The L1 tx packet descriptor expects TCP Header Length to be expressed as a
number of 32-bit dwords. The atl1 driver uses tcp_hdrlen() to populate the
field, but tcp_hdrlen() returns the header length in bytes, not in dwords.
Add a shift to convert tcp_hdrlen() to dwords when we write it to the tpd
I made a randconfig, and got the following error:
net/sched/cls_flow.c: In function 'flow_dump':
net/sched/cls_flow.c:598: error: 'struct tcf_ematch_tree' has no member named
'hdr'
make[2]: *** [net/sched/cls_flow.o] Error 1
make[1]: *** [net/sched] Error 2
make: *** [net] Error 2
seems it's ca
Stephen Hemminger wrote:
On Sat, 2 Feb 2008 11:52:43 +0100
Petr Vandrovec <[EMAIL PROTECTED]> wrote:
Hello,
since I synced my tree to Linus's one two days ago, sky2's packet receiption
dies almost instantly. Device still transmits packets, but no receive.
Fortunately fix is simple, unfortu
On Sun, Feb 03, 2008 at 11:20:19AM +1100, Herbert Xu wrote:
> Al Viro spotted a bogus use of u64 on the input sequence number which
> is big-endian. This patch fixes it by giving the input sequence number
> its own member in the xfrm_skb_cb structure.
This is still very odd... Where do you initi
On Sat, Feb 02, 2008 at 11:58:27PM +, Al Viro wrote:
> What's going on with XFRM_SKB_CB(skb)->seq? Almost all users
> expect it to be u32 (feeding it to htonl()), except xfrm_input().
> That one expects __be32 in there - check what it does to seq and
> you'll see. Moreover, it updates t
Patrick McHardy wrote:
> These patches add support for external classifiers to SFQ and add a
> new "flow" classifier, which can do hashing based on user-specified
> keys or deterministic mapping of keys to classes. Additionally there
> is a patch to make the SFQ queues visisble as classes to verify
Andi Kleen <[EMAIL PROTECTED]> wrote:
>
> Hmm, that would probably be possible for TBF, but I'm not sure this can be
> really done in a useful way for the more complicated qdiscs. Especially
> since they would likely need to turn on/off GSO regularly when dynamic
> circumstances change and there i
Andi Kleen <[EMAIL PROTECTED]> wrote:
>> Then change TBF to use skb_gso_segment? Be careful, the fact that
>
> That doesn't help because it wants to interleave packets
> from different streams to get everything fair and smooth. The only
> good way to handle that is to split it up and the simples
Jarek Poplawski wrote:
> Hi Corey!
>
> I've just had a look at your site, and see you're a bit disappointed about
> the reception of your patches here. I don't use nor know about your work
> (maybe some time...), and wish you better public here, but maybe you'll
> find this story interesting: a fe
On Sat, Feb 02, 2008 at 11:53:29PM +0200, Ilpo Järvinen wrote:
>
> Once again, one of this kind tries to creep in.
>
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
Heh, Adrian got there first :)
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROT
On Sat, Feb 02, 2008 at 11:16:35PM +0200, Adrian Bunk wrote:
> A bug every C programmer makes at some point in time...
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Good catch!
Acked-by: Herbert Xu <[EMAIL PROTECTED]>
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu
Corey Hickey wrote, On 02/02/2008 11:23 AM:
...
> I'd rather you were using my recent patches to SFQ instead of ESFQ. I
> was able to crash a 2.6.24 user-mode Linux with ESFQ as well; I don't
> know if that's what you encountered, but the SFQ patches should be
> better anyway.
>
> http://fatooh.
Once again, one of this kind tries to creep in.
Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
---
net/ipv4/xfrm4_mode_beet.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/xfrm4_mode_beet.c b/net/ipv4/xfrm4_mode_beet.c
index e093a7b..b47030b 100644
--- a/ne
On Saturday 02 February 2008 22:07:20 Pekka Enberg wrote:
> Hi,
>
> On Feb 2, 2008 8:25 PM, Ondrej Zary <[EMAIL PROTECTED]> wrote:
> > +//static __be16 el3_phys_addr[EL3_MAX_CARDS][3];
>
> [snip]
>
> > +//#if defined(CONFIG_MCA) || defined(CONFIG_EISA)
>
> [snip]
>
> > +// while (el3_probe(el3_
A bug every C programmer makes at some point in time...
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
3125760a05c6e97097882a810dc1c5342296aae9
diff --git a/net/ipv4/xfrm4_mode_beet.c b/net/ipv4/xfrm4_mode_beet.c
index e093a7b..b47030b 100644
--- a/net/ipv4/xfrm4_mode_beet.c
+++ b/net/ipv4/x
I do not claim to understand this code, but it doesn't seem to be
intentional that after commit 5ee31fc1ecdcbc234c8c56dcacef87c8e09909d8
inet6_hash_connect() now uses secure_ipv4_port_ephemeral() instead of
secure_ipv6_port_ephemeral() (inet6_sk_port_offset() is no longer
used and __inet_hash_c
This patch fixes a use-after-free introduced by
commit a79d8e93d300adb8438ac396cfb118c238ad and spotted by the
Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
20c51455b2faed63c3026fd4d7139e5a6a917d31
diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c
index 7
On Saturday 02 February 2008 21:50:25 Jeff Garzik wrote:
> Ondrej Zary wrote:
> > Hello,
> > this is second version of the patch. Autoloading using udev works fine
> > with PnP card. Hibernation now works both in PnP and ISA modes. The I/O
> > address used for non-pnp ISA card detection is now not
Hi,
On Feb 2, 2008 8:25 PM, Ondrej Zary <[EMAIL PROTECTED]> wrote:
> +//static __be16 el3_phys_addr[EL3_MAX_CARDS][3];
[snip]
> +//#if defined(CONFIG_MCA) || defined(CONFIG_EISA)
[snip]
> +// while (el3_probe(el3_cards) == 0) {
> +// if (irq[el3_cards] > 1)
> +//
Ondrej Zary wrote:
Hello,
this is second version of the patch. Autoloading using udev works fine with
PnP card. Hibernation now works both in PnP and ISA modes. The I/O address
used for non-pnp ISA card detection is now not released as it's needed to
wake up the card.
Manual irq and transcei
On Sat, 2 Feb 2008 11:52:43 +0100
Petr Vandrovec <[EMAIL PROTECTED]> wrote:
> Hello,
> since I synced my tree to Linus's one two days ago, sky2's packet receiption
> dies almost instantly. Device still transmits packets, but no receive.
> Fortunately fix is simple, unfortunately I do not know
Li Zefan wrote:
> Add CCs:
>
> CC: [EMAIL PROTECTED]
> CC: [EMAIL PROTECTED]
> CC: [EMAIL PROTECTED]
>
> Li Zefan wrote:
>> drivers/net/b44.c: In function 'b44_remove_one':
>> drivers/net/b44.c:2231: error: implicit declaration of function
>> 'ssb_pcihost_set_power_state'
>> make[2]: *** [driver
On Sat, Feb 02, 2008 at 12:56:08PM +0200, Julian Anastasov wrote:
>
> Hello,
Hi!
> On Tue, 29 Jan 2008, Jarek Poplawski wrote:
>
> > ...On the other hand, I wonder how bad would be switching these two
> > to avoid this error? After all "replace" with this "add or change"
> > meaning looks
Hello,
this is second version of the patch. Autoloading using udev works fine with
PnP card. Hibernation now works both in PnP and ISA modes. The I/O address
used for non-pnp ISA card detection is now not released as it's needed to
wake up the card.
Manual irq and transceiver settings aren't im
Hello
I already posted my problem and what I did to solve it on
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=461429 . In essence the
6.004.00-NAPI version from the Realtek site fixed it until now. My request is
only that you try to get this version included in the kernel.
_
On Sat, Feb 02, 2008 at 03:34:58PM +0100, Francois Romieu wrote:
> Li Zefan <[EMAIL PROTECTED]> :
> > Fix the following compile error:
>
> I am not sure that it is the right fix. Please read the archive of
> this week on l-k.
>
> I'll submit the patch below to Jeff once I have tested it with real
Li Zefan <[EMAIL PROTECTED]> :
> Fix the following compile error:
I am not sure that it is the right fix. Please read the archive of
this week on l-k.
I'll submit the patch below to Jeff once I have tested it with real
hardware (sunday evening entertainment). Sam, is it ok to add your
s-o-b to it
There are modification of NOTRACK netfilter target to avoid creating new
connection entries for packets, unrelated to any existing connection.
Best way to make new target (clone NOTRACK to NOTRACK-NEW and fix - to mix
both), but I have enough motivation to this work ;)
PS There are not same p
Hello,
since I synced my tree to Linus's one two days ago, sky2's packet receiption
dies almost instantly. Device still transmits packets, but no receive.
Fortunately fix is simple, unfortunately I do not know why fix works...
Commit f03b865491c2f30f2a4d77cdafc69c978ceb38a0 (sky2: align IP he
Chuck Ebbert wrote:
On 01/31/2008 01:03 PM, Chuck Ebbert wrote:
On 01/29/2008 12:18 PM, Patrick McHardy wrote:
Chuck Ebbert wrote:
nf_nat_move_storage():
/usr/src/debug/kernel-2.6.23/linux-2.6.23.i686/net/ipv4/netfilter/nf_nat_core.c:612
87: f7 47 64 80 01 00 00testl $0x180,0
Hello,
On Tue, 29 Jan 2008, Jarek Poplawski wrote:
> ...On the other hand, I wonder how bad would be switching these two
> to avoid this error? After all "replace" with this "add or change"
> meaning looks quite permissive, and after all it was used before with
> no such errors, so, even
Denys Fedoryshchenko wrote:
> Hi
>
> Probably bug related to ESFQ, now i will unload module and will test more.
> But probably not related, so if not difficult, please take a look.
>
> Feb 1 09:08:50 SERVER [12380.067104] BUG: unable to handle kernel NULL
> pointer dereference
> Feb 1 09:08:5
Chuck Ebbert wrote:
On 01/31/2008 01:03 PM, Chuck Ebbert wrote:
On 01/29/2008 12:18 PM, Patrick McHardy wrote:
Chuck Ebbert wrote:
nf_nat_move_storage():
/usr/src/debug/kernel-2.6.23/linux-2.6.23.i686/net/ipv4/netfilter/nf_nat_core.c:612
87: f7 47 64 80 01 00 00testl $0x180,0
YOSHIFUJI Hideaki / 吉藤英明 wrote, On 01/31/2008 08:57 PM:
> Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]>
> ---
> include/linux/if_addrlabel.h | 32 +
> ip/Makefile |2 +-
> ip/ip.c |5 +-
> ip/ip_common.h |4 +
> ip/ipadd
Denys Fedoryshchenko wrote, On 02/01/2008 02:25 PM:
> Hi
>
> Probably bug related to ESFQ, now i will unload module and will test more.
> But probably not related, so if not difficult, please take a look.
Hi,
The main break seems to take place in HTB. Do you use HTB on IFB, BTW?
If not, maybe
48 matches
Mail list logo
