Re: Assertions in latest kernels

2008-01-22 Thread David Miller
From: Krishna Kumar2 <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 13:22:05 +0530 > Sorry for the duplicate bug report, I just saw that Dave Young had already > reported three of the > 4 assertions that I was getting. The only different assert I am getting is: > > iperf with multiple threads almost

Re: Assertions in latest kernels

2008-01-22 Thread Krishna Kumar2
Sorry for the duplicate bug report, I just saw that Dave Young had already reported three of the 4 assertions that I was getting. The only different assert I am getting is: iperf with multiple threads almost always gets these 4, *especially* when I do some batching :). static void tcp_fastretrans

Re: [PATCH 10/12 net-2.6.25] [NETNS]: Correct namespace for connect-time routing.

2008-01-22 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 10:46:25 +0300 > ip_route_connect and ip_route_newports are a part of routing API presented to > the socket layer. The namespace is available inside them through a socket. > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Appl

Re: [PATCH 11/12 net-2.6.25] [NETNS]: Routing cache virtualization.

2008-01-22 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 10:46:26 +0300 > Basically, this piece looks relatively easy. Namespace is already available > on the dst entry via device and the device is safe to dereferrence. Compare > it with one of a searcher and skip entry if appropriate. >

Re: [PATCH 12/12 net-2.6.25] [NETNS]: Add namespace for ICMP replying code.

2008-01-22 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 10:46:27 +0300 > All needed API is done, the namespace is available when required from the > device on the DST entry from the incoming packet. So, just replace init_net > with proper namespace. > > Other protocols will follow. > >

[PATCH 11/12 net-2.6.25] [NETNS]: Routing cache virtualization.

2008-01-22 Thread Denis V. Lunev
Basically, this piece looks relatively easy. Namespace is already available on the dst entry via device and the device is safe to dereferrence. Compare it with one of a searcher and skip entry if appropriate. The only exception is ip_rt_frag_needed. So, add namespace parameter to it. Signed-off-b

[PATCH 12/12 net-2.6.25] [NETNS]: Add namespace for ICMP replying code.

2008-01-22 Thread Denis V. Lunev
All needed API is done, the namespace is available when required from the device on the DST entry from the incoming packet. So, just replace init_net with proper namespace. Other protocols will follow. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/icmp.c | 21

[PATCH 10/12 net-2.6.25] [NETNS]: Correct namespace for connect-time routing.

2008-01-22 Thread Denis V. Lunev
ip_route_connect and ip_route_newports are a part of routing API presented to the socket layer. The namespace is available inside them through a socket. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/route.h |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) dif

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-22 Thread Dave Young
On Jan 23, 2008 3:41 PM, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > > On Tue, 22 Jan 2008, David Miller wrote: > > > From: "Dave Young" <[EMAIL PROTECTED]> > > Date: Wed, 23 Jan 2008 09:44:30 +0800 > > > > > On Jan 22, 2008 6:47 PM, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > > > > [PATCH] [TCP]: de

Re: [PATCH] [IPV4] route: fix locking in rt_run_flush()

2008-01-22 Thread joonwpark81
On Mon, Jan 21, 2008 at 02:40:43AM -0800, David Miller wrote: > From: Joonwoo Park <[EMAIL PROTECTED]> > Date: Tue, 22 Jan 2008 00:08:57 +0900 > > > The rt_run_flush() can be stucked if it was called while netdev is on the > > high load. > > It's possible when pushing rtable to rt_hash is faster

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-22 Thread Ilpo Järvinen
On Tue, 22 Jan 2008, David Miller wrote: > From: "Dave Young" <[EMAIL PROTECTED]> > Date: Wed, 23 Jan 2008 09:44:30 +0800 > > > On Jan 22, 2008 6:47 PM, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > > > [PATCH] [TCP]: debug S+L > > > > Thanks, If there's new findings I will let you know. > > Thank

Assertions in latest kernels

2008-01-22 Thread Krishna Kumar2
Hi all, While running some simple iperf tests (multi-threaded using either E1000 or IPoIB), I started getting these two assertions starting about 3 weeks back (though it could be older to that since my earlier bits were not upto date). Bits are unmodified 2.6.24-rc7 bits downloaded today (Jan 23r

Re: [INET]: Fix truesize setting in ip_append_data

2008-01-22 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 17:41:31 +1100 > On Tue, Jan 22, 2008 at 09:47:19PM -0800, David Miller wrote: > > > > I already checked in the ip_append_page() fix to net-2.6 so > > I simply removed that hunk when adding your fix. > > > > Thanks again! > > Thank you

Re: [INET]: Fix truesize setting in ip_append_data

2008-01-22 Thread Herbert Xu
On Tue, Jan 22, 2008 at 09:47:19PM -0800, David Miller wrote: > > I already checked in the ip_append_page() fix to net-2.6 so > I simply removed that hunk when adding your fix. > > Thanks again! Thank you! I just received a message from Takahiro Yasui that my bug fix is buggy too :) So here is

[Bug 9750] [patch 2.6.24] dev: avoid a race that triggers assertion failure

2008-01-22 Thread Matti Linnanvuori
From: Matti Linnanvuori <[EMAIL PROTECTED]> There is a race in Linux kernel file net/core/dev.c, function dev_close. The function calls function dev_deactivate, which calls function dev_watchdog_down that deletes the watchdog timer. However, after that, a driver can call netif_carrier_ok, which ca

Re: [NET_SCHED 00/06]: Conversion to new netlink API

2008-01-22 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 15:56:08 +0100 (MET) > These patches convert the packet schedulers to the new netlink API. > This will allow to use the new features like automatic attribute > checking and gets rid of the largest rtnetlink.h user we still have. > Un

Re: [PATCH 0/12 net-2.6.25] [NETNS]: Routing namespacing on IP output path.

2008-01-22 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 18:58:54 +0300 > This set introduces namespacing in the IP output path. The namespace is > added to all routing API functions except ones with a valid socket. This > is very intrusive. > > Routing cache is virtualized as a part of

Re: [IPV4 0/9] TRIE performance patches

2008-01-22 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 15:37:33 -0800 > > Time to handle a full BGP load (163K of routes). > > Before: LoadDumpFlush > hash 3.5 0.50.7 > 2.6.23.14 3.4 19.3

Re: [PATCH 5/12 net-2.6.25] [NETNS]: Re-export init_net via EXPORT_SYMBOL.

2008-01-22 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 20:19:11 +0300 > Patrick McHardy wrote: > > Denis V. Lunev wrote: > >> init_net is used added as a parameter to a lot of old API calls, f.e. > >> ip_dev_find. These calls were exported as EXPORT_SYMBOL. So, export > >> init_net > >>

Re: [INET]: Fix truesize setting in ip_append_data

2008-01-22 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 14:39:42 +1100 > [INET]: Fix truesize setting in ip_append_data > > As it is ip_append_data only counts page fragments to the skb that > allocated it. As such it means that the first skb gets hit with a > 4K charge even though it might

[INET]: Fix truesize setting in ip_append_data

2008-01-22 Thread Herbert Xu
Hi Dave: [INET]: Fix truesize setting in ip_append_data As it is ip_append_data only counts page fragments to the skb that allocated it. As such it means that the first skb gets hit with a 4K charge even though it might have only used a fraction of it while all subsequent skb's that use the same

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-22 Thread Zhang, Yanmin
On Wed, 2008-01-23 at 08:42 +0800, Zhang, Yanmin wrote: > On Tue, 2008-01-22 at 10:36 -0800, Rick Jones wrote: > > When parsing the -P option in scan_socket_args() of src/nettest_bsd.c, > > netperf is using "break_args()" from src/netsh.c which indeed if the > > command line says "-P 12345" will

Re: [PATCH 0/6] PS3: gelic: gelic updates for 2.6.25

2008-01-22 Thread Geoff Levand
On 01/22/2008 04:58 PM, John W. Linville wrote: > On Wed, Jan 23, 2008 at 11:40:34AM +1100, Benjamin Herrenschmidt wrote: >> >> On Tue, 2008-01-22 at 16:12 -0500, John W. Linville wrote: >> > On Thu, Dec 13, 2007 at 07:38:28PM +0900, Masakazu Mokuno wrote: >> > >> > > Here is a set of updates for

Re: pull request: wireless-2.6 'upstream' 2008-01-22

2008-01-22 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 20:45:21 -0500 > git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git > upstream Pulled and pushed out to net-2.6.25, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: pull request: wireless-2.6 'fixes' 2008-01-22

2008-01-22 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 20:44:39 -0500 > git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git fixes I'll suck this into my tree, thanks John. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messa

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-22 Thread David Miller
From: "Dave Young" <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 09:44:30 +0800 > On Jan 22, 2008 6:47 PM, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > > [PATCH] [TCP]: debug S+L > > Thanks, If there's new findings I will let you know. Thanks for helping with this bug Dave. -- To unsubscribe from thi

Re: [PATCH 06/26] atl1: update initialization parameters

2008-01-22 Thread Chris Snook
Jay Cliburn wrote: On Tue, 22 Jan 2008 04:56:11 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: [EMAIL PROTECTED] wrote: From: Jay Cliburn <[EMAIL PROTECTED]> Update initialization parameters to match the current vendor driver version 1.2.40.2. [...] ACK without any better knowledge... but i

Re: [PATCH] [AF_X25]: constify function pointer tables

2008-01-22 Thread David Miller
From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 20:52:04 +0100 (CET) > Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.

Re: [PATCH] [IrDA] LMP discovery timer not started by default

2008-01-22 Thread David Miller
From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Wed, 23 Jan 2008 04:34:22 +0100 > By default, LMP sets up a 3 seconds timer for discovery. > We don't need it until discovery is set to 1. > > This patch is against your latest net-2.6.25 tree. > > From: Ross Burton <[EMAIL PROTECTED]> > Signed-off-by

Re: [PATCH 06/26] atl1: update initialization parameters

2008-01-22 Thread Jeff Garzik
Jay Cliburn wrote: On Tue, 22 Jan 2008 04:56:11 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: [EMAIL PROTECTED] wrote: From: Jay Cliburn <[EMAIL PROTECTED]> Update initialization parameters to match the current vendor driver version 1.2.40.2. [...] ACK without any better knowledge... but i

Re: [PATCH 06/26] atl1: update initialization parameters

2008-01-22 Thread Jay Cliburn
On Tue, 22 Jan 2008 04:56:11 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > From: Jay Cliburn <[EMAIL PROTECTED]> > > > > Update initialization parameters to match the current vendor driver > > version 1.2.40.2. [...] > ACK without any better knowledge... but is an

pull request: wireless-2.6 'fixes' 2008-01-22

2008-01-22 Thread John W. Linville
Dave, Here is a NULL pointer avoidance fix for iwlwifi that would be nice to have in 2.6.24 if possible. Thanks! John --- Individual patch available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/fixes --- The following changes since commit 889c94a14e38e7

Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-22 Thread Dave Young
On Jan 22, 2008 6:47 PM, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > > On Tue, 22 Jan 2008, Dave Young wrote: > > > On Jan 22, 2008 12:37 PM, Dave Young <[EMAIL PROTECTED]> wrote: > > > > > > On Jan 22, 2008 5:14 AM, Ilpo Järvinen <[EMAIL PROTECTED]> wrote: > > > > > > > > On Mon, 21 Jan 2008, Dave

Re: [PATCH net-2.6.25] Add packet filtering based on process\'s security context.

2008-01-22 Thread Tetsuo Handa
Hello. Casey Schaufler wrote: > Do you have a real situation where two user processes with different > security contexts share a socket? How do you get into that situation, > and is it appropriate to have that situation in your security scheme? > Can this occur without using privilege? I hope suc

Re: [PATCH 0/6] PS3: gelic: gelic updates for 2.6.25

2008-01-22 Thread John W. Linville
On Wed, Jan 23, 2008 at 11:40:34AM +1100, Benjamin Herrenschmidt wrote: > > On Tue, 2008-01-22 at 16:12 -0500, John W. Linville wrote: > > On Thu, Dec 13, 2007 at 07:38:28PM +0900, Masakazu Mokuno wrote: > > > > > Here is a set of updates for PS3 gelic network driver. > > > This patch set require

Re: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation

2008-01-22 Thread Jeff Garzik
Sreenivasa Honnur wrote: Multiqueue netwrok device support implementation. - Added a loadable parameter "multiq" to enable/disable multiqueue support, by default it is disabled. - skb->queue_mapping is not used for queue/fifo selection. FIFO iselection is based on IP-TOS value, 0x0-0xF TOS va

[PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation

2008-01-22 Thread Sreenivasa Honnur
Multiqueue netwrok device support implementation. - Added a loadable parameter "multiq" to enable/disable multiqueue support, by default it is disabled. - skb->queue_mapping is not used for queue/fifo selection. FIFO iselection is based on IP-TOS value, 0x0-0xF TOS values are mapped to 8 FIFOs.

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-22 Thread Zhang, Yanmin
On Tue, 2008-01-22 at 10:36 -0800, Rick Jones wrote: > When parsing the -P option in scan_socket_args() of src/nettest_bsd.c, > netperf is using "break_args()" from src/netsh.c which indeed if the > command line says "-P 12345" will set both the local and remote port > numbers to 12345. If inst

Re: [PATCH 0/6] PS3: gelic: gelic updates for 2.6.25

2008-01-22 Thread Benjamin Herrenschmidt
On Tue, 2008-01-22 at 16:12 -0500, John W. Linville wrote: > On Thu, Dec 13, 2007 at 07:38:28PM +0900, Masakazu Mokuno wrote: > > > Here is a set of updates for PS3 gelic network driver. > > This patch set requires other patches which were already submitted by > > Geert (http://marc.info/?l=linux

Re: [PATCH 09/26] atl1: refactor tx processing

2008-01-22 Thread Jay Cliburn
On Tue, 22 Jan 2008 04:58:17 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > From: Jay Cliburn <[EMAIL PROTECTED]> > > > > Refactor tx processing to use a less convoluted tx packet > > descriptor and to conform generally with the vendor's current > > version 1.2.40.2.

[IPV4 7/9] fib_trie: dump table in sorted order

2008-01-22 Thread Stephen Hemminger
It is easier with TRIE to dump the data traversal rather than interating over every possible prefix. This saves some time and makes the dump come out in sorted order. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-22 12:58:59.0 -0800 +++ b/net

[IPV4 2/9] fib_trie: style cleanup

2008-01-22 Thread Stephen Hemminger
Style cleanups: * make check_leaf return -1 or plen, rather than by reference * Get rid of #ifdef that is always set * split out embedded function calls in if statements. * checkpatch warnings Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c

[IPV4 9/9] fib_trie: avoid rescan on dump

2008-01-22 Thread Stephen Hemminger
This converts dumping (and flushing) of large route tables form O(N^2) to O(N). If the route dump took multiple pages then the dump routine gets called again. The old code kept track of location by counter, the new code instead uses the last key. This is a really big win ( 0.3 sec vs 12 sec) for b

[IPV4 6/9] fib_trie: iterator recode

2008-01-22 Thread Stephen Hemminger
Remove the complex loop structure of nextleaf() andreplace it with a simpler tree walker. This improves the performance and is much cleaner. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-22 09:52:46.0 -0800 +++ b/net/ipv4/fib_trie.c 20

[IPV4 4/9] fib_trie: use hash list

2008-01-22 Thread Stephen Hemminger
The code to dump can use the existing hash chain rather than doing repeated lookup. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-21 17:45:03.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-21 17:45:08.0 -0800 @@ -2396,31 +2396,30 @@

[IPV4 8/9] fib_trie: avoid extra search on delete

2008-01-22 Thread Stephen Hemminger
Get rid of extra search that made route deletion O(n). Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-22 15:24:41.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-22 15:25:32.0 -0800 @@ -1542,49 +1542,23 @@ found: return ret;

[IPV4 5/9] fib_trie: dump message multiple part flag

2008-01-22 Thread Stephen Hemminger
Match fib_hash, and set NLM_F_MULTI to handle multiple part messages. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-21 17:52:10.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-21 17:52:11.0 -0800 @@ -1895,7 +1895,7 @@ static int fn_t

[IPV4 3/9] fib_trie: compute size when needed

2008-01-22 Thread Stephen Hemminger
Compute the number of prefixes when needed, rather than doing bookeeping. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-21 17:45:03.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-21 17:45:03.0 -0800 @@ -143,12 +143,12 @@ struct trie

[IPV4 1/9] fib_trie: put leaf nodes in a slab cache

2008-01-22 Thread Stephen Hemminger
This improves locality for operations that touch all the leaves. Save space since these entries don't need to be hardware cache aligned. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-21 10:16:10.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-0

[IPV4 0/9] TRIE performance patches

2008-01-22 Thread Stephen Hemminger
Time to handle a full BGP load (163K of routes). Before: LoadDumpFlush hash3.5 0.50.7 2.6.23.14 3.4 19.310.3 net-2.6.25 3.4 18.79.8 After: kmem_cache 3.8

Re: [PATCH RESEND 3/3] RDMA/cxgb3: Mark qp as privileged based on user capabilities.

2008-01-22 Thread Roland Dreier
thanks, applied 1-3 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: WARNING, tcp_fastretrans_alert, rc6-git11

2008-01-22 Thread Ilpo Järvinen
On Tue, 22 Jan 2008, Denys Fedoryshchenko wrote: > Just got on one of proxies, under high load. > It is a bit old rc, so probably my report not interesting, but since it is > production machines, i cannot change too often. > Kernel is 2.6.24-rc6-git11 It's not at all useless, there hasn't been a

Re: [PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-22 Thread Herbert Xu
On Wed, Jan 23, 2008 at 09:06:14AM +1100, Rusty Russell wrote: > > > So this field is fine with me as long as it is named as such to > > avoid confusion since it really has nothing to do with GSO as you > > also need it for SG with large MTUs. > > Hmm, how about just "hdr_len" rather than "gso_hdr

Re: [PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-22 Thread Rusty Russell
On Tuesday 22 January 2008 21:36:30 Herbert Xu wrote: > On Wed, Jan 16, 2008 at 03:19:03PM +1100, Rusty Russell wrote: > > > > It's far easier to deal with GSO if we don't have to parse the packet > > > > to figure out the header length. Add the field to the virtio_net_hdr > > > > struct (and fix

Re: [PATCH 0/6] PS3: gelic: gelic updates for 2.6.25

2008-01-22 Thread John W. Linville
On Thu, Dec 13, 2007 at 07:38:28PM +0900, Masakazu Mokuno wrote: > Here is a set of updates for PS3 gelic network driver. > This patch set requires other patches which were already submitted by > Geert (http://marc.info/?l=linux-kernel&m=119626095605487). > > [1] PS3: gelic: Fix the wrong d

WARNING, tcp_fastretrans_alert, rc6-git11

2008-01-22 Thread Denys Fedoryshchenko
Just got on one of proxies, under high load. It is a bit old rc, so probably my report not interesting, but since it is production machines, i cannot change too often. Kernel is 2.6.24-rc6-git11 Some sysctl adjustments done. Please tell me if need more information. There is rules in iptables (if

Re: [PATCH 2.6.23+] ingress classify to [nf]mark

2008-01-22 Thread Dzianis Kahanovich
Too many pixels to smoke. Sorry. May be so? ;)) (if undefined classid not overwrited by random value tc_classify) Even "tc" say to classid=0 - "" --- 1/net/sched/sch_ingress.c 2008-01-12 17:27:05.0 +0200 +++ 2/net/sched/sch_ingress.c 2008-01-22 22:09:32.0 +0200 @@ -136,6

[PATCH] [AF_X25]: constify function pointer tables

2008-01-22 Thread Jan Engelhardt
Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> --- net/x25/x25_proc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/x25/x25_proc.c b/net/x25/x25_proc.c index 7d55e50..3faec8e 100644 --- a/net/x25/x25_proc.c +++ b/net/x25/x25_proc.c @@ -287,7 +287,7 @@ static cons

[PATCH] [AF_RXRPC]: constify function pointer tables

2008-01-22 Thread Jan Engelhardt
Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> --- net/rxrpc/ar-call.c |2 +- net/rxrpc/ar-internal.h |6 +++--- net/rxrpc/ar-proc.c |6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/net/rxrpc/ar-call.c b/net/rxrpc/ar-call.c index 3c04b00..d923124 100

[PATCH] NET: constify data and function pointer tables

2008-01-22 Thread Jan Engelhardt
Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> --- drivers/net/bonding/bond_main.c |2 +- drivers/net/hamradio/bpqether.c |2 +- drivers/net/hamradio/scc.c |2 +- drivers/net/hamradio/yam.c |2 +- drivers/net/ibmveth.c

[2/4] DST: Core distributed storage files.

2008-01-22 Thread Evgeniy Polyakov
Core distributed storage files. Include userspace interfaces, initialization, block layer bindings and other core functionality. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index b4c8319..ca6592d 100644 --- a/drivers/block/Kconf

[1/4] DST: Distributed storage documentation.

2008-01-22 Thread Evgeniy Polyakov
Distributed storage documentation. Algorithms used in the system, userspace interfaces (sysfs dirs and files), design and implementation details are described here. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/Documentation/dst/algorithms.txt b/Documentation/dst/algorithms.

[3/4] DST: Network state machine.

2008-01-22 Thread Evgeniy Polyakov
Network state machine. Includes network async processing state machine and related tasks. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/block/dst/kst.c b/drivers/block/dst/kst.c new file mode 100644 index 000..4ff14ce --- /dev/null +++ b/drivers/block/dst/kst.c @

[4/4] DST: Algorithms used in distributed storage.

2008-01-22 Thread Evgeniy Polyakov
Algorithms used in distributed storage. Mirror and linear mapping code. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/block/dst/alg_linear.c b/drivers/block/dst/alg_linear.c new file mode 100644 index 000..2f9ed65 --- /dev/null +++ b/drivers/block/dst/alg_linear.c

[0/4] DST: Distributed storage: Succumbed to live ant.

2008-01-22 Thread Evgeniy Polyakov
Distributed storage: Succumbed to live ant. I'm pleased to announce the 14'th release of the distributed storage subsystem (DST). DST allows to form a storage on top of local and remote nodes and combine them into linear or mirroring setup, which in turn can be exported to remote nodes. This is

[PATCH] [IrDA] LMP discovery timer not started by default

2008-01-22 Thread Samuel Ortiz
Hi Dave, By default, LMP sets up a 3 seconds timer for discovery. We don't need it until discovery is set to 1. This patch is against your latest net-2.6.25 tree. From: Ross Burton <[EMAIL PROTECTED]> Signed-off-by: Ross Burton <[EMAIL PROTECTED]> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]>

Re: forcedeth oops

2008-01-22 Thread Jeff Garzik
Andrew Brooks wrote: Hello I'm getting an oops in forcedeth whenever I shutdown, details below. I've tried kernel 2.6.16.59 and the latest forcedeth.c from nvidia.com which is package-1.23 version-0.62 date-2007/04/27. How can I download the latest forcedeth.c (including 2008-01-13 patches) ?

Re: [PATCH 1/3 v2][NET] gen_estimator: faster gen_kill_estimator

2008-01-22 Thread Jarek Poplawski
On Tue, Jan 22, 2008 at 08:54:28AM -0500, jamal wrote: > On Tue, 2008-22-01 at 13:29 +0100, Jarek Poplawski wrote: > > On Tue, Jan 22, 2008 at 06:42:07AM -0500, jamal wrote: > > ... > > > Jarek, > > > > > > That looks different from the suggestion from Dave. > > > > Hmm..., I'm not sure you mean

Re: [PATCH] PHYLIB: Locking fixes for PHY I/O potentially sleeping

2008-01-22 Thread David Hollis
On Thu, 2008-01-03 at 17:36 -0600, Nate Case wrote: > > PHY read/write functions can potentially sleep (e.g., a PHY accessed > via I2C). The following changes were made to account for this: > > * Change spin locks to mutex locks > * Add a BUG_ON() to phy_read() phy_write() to warn again

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-22 Thread Rick Jones
When parsing the -P option in scan_socket_args() of src/nettest_bsd.c, netperf is using "break_args()" from src/netsh.c which indeed if the command line says "-P 12345" will set both the local and remote port numbers to 12345. If instead you were to say "-P 12345," it will use 12345 only for

Re: [PATCH 5/12 net-2.6.25] [NETNS]: Re-export init_net via EXPORT_SYMBOL.

2008-01-22 Thread Denis V. Lunev
Patrick McHardy wrote: > Denis V. Lunev wrote: >> init_net is used added as a parameter to a lot of old API calls, f.e. >> ip_dev_find. These calls were exported as EXPORT_SYMBOL. So, export >> init_net >> as EXPORT_SYMBOL to keep networking API consistent. > > > I think this should go in 2.6.24

Re: [PATCH 5/5] netns netfilter: per-netns FILTER, MANGLE, RAW

2008-01-22 Thread Patrick McHardy
Alexey Dobriyan wrote: Now, iptables show and configure different set of rules in different netnss'. Filtering decisions are still made by consulting only init_net's set. Changes are identical except naming so no splitting. P.S.: one need to remove init_net checks in nf_sockopt.c and inet_creat

status inquiry (RE: [PATCH 01/03] ISATAP V2 (header file changes))

2008-01-22 Thread Templin, Fred L
Would appreciate a status update on this submission, posted 1/15/08. Thanks - Fred [EMAIL PROTECTED] > -Original Message- > From: Templin, Fred L > Sent: Tuesday, January 15, 2008 11:57 AM > To: netdev@vger.kernel.org > Cc: YOSHIFUJI Hideaki / 吉藤英明 > Subject: [PATCH 01/03] ISATAP V2 (hea

Re: [PATCH 5/12 net-2.6.25] [NETNS]: Re-export init_net via EXPORT_SYMBOL.

2008-01-22 Thread Patrick McHardy
Denis V. Lunev wrote: init_net is used added as a parameter to a lot of old API calls, f.e. ip_dev_find. These calls were exported as EXPORT_SYMBOL. So, export init_net as EXPORT_SYMBOL to keep networking API consistent. I think this should go in 2.6.24 if still possible so people don't have t

Re: [PATCH 3/5] netns netfilter: return new table from {arp,ip,ip6}t_register_table()

2008-01-22 Thread Patrick McHardy
Alexey Dobriyan wrote: Typical table module registers xt_table structure (i.e. packet_filter) and link it to list during it. We can't use one template for it because corresponding list_head will become corrupted. We also can't unregister with template because it wasn't changed at all and thus doe

Re: [PATCH 4/5] netns netfilter: propagate netns from userspace

2008-01-22 Thread Patrick McHardy
Alexey Dobriyan wrote: .. all the way down to table searching functions. Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. --- net/ipv4/netfilter/ip_tables.c | 46 - 1 file changed, 23 insertions(+), 23 deletions(-) What about ip6_table

Re: [PATCH net-2.6.25] Add packet filtering based on process's security context.

2008-01-22 Thread Casey Schaufler
--- Tetsuo Handa <[EMAIL PROTECTED]> wrote: > ... > > Currently, there is no way to directly map security context from incoming > packet to user process. This is because the creator or owner of a socket is > not always the receiver of an incoming packet. The userland process who > receives the i

Re: [PATCH 2/5] netns netfilter: per-netns xt_tables

2008-01-22 Thread Patrick McHardy
Alexey Dobriyan wrote: In fact all we want is per-netns set of rules, however doing that will unnecessary complicate routines such as ipt_hook()/ipt_do_table, so make full xt_table array per-netns. Every user stubbed with init_net for a while. Applied. -- To unsubscribe from this list: send

Re: [PATCH 1/5] netns netfilter: change xt_table_register() return value convention

2008-01-22 Thread Patrick McHardy
Alexey Dobriyan wrote: Switch from 0/-E to ptr/PTR_ERR convention. Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 9/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_route_output_key.

2008-01-22 Thread Denis V. Lunev
Needed to propagate it down to the ip_route_output_flow. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- drivers/infiniband/core/addr.c |4 ++-- drivers/net/bonding/bond_main.c |2 +- include/net/route.h |2 +- net/atm/clip.c |2 +- net/brid

[PATCH 7/12 net-2.6.25] [NETNS]: Add namespace parameter to __ip_route_output_key.

2008-01-22 Thread Denis V. Lunev
This is only required to propagate it down to the ip_route_output_slow. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/route.h |4 ++-- net/ipv4/icmp.c |4 ++-- net/ipv4/route.c|7 --- net/ipv4/xfrm4_policy.c |2 +- 4 files changed, 9 ins

[PATCH 8/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_route_output_flow.

2008-01-22 Thread Denis V. Lunev
Needed to propagate it down to the __ip_route_output_key. Signed_off_by: Denis V. Lunev <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_cm.c |2 +- include/net/route.h |6 +++--- net/dccp/ipv4.c |2 +- net/ipv4/af_inet.c

[PATCH 3/12 net-2.6.25] [NETNS]: Add netns parameter to fib_select_default.

2008-01-22 Thread Denis V. Lunev
Currently fib_select_default calls fib_get_table() with the init_net. Prepare it to provide a correct namespace to lookup default route. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/ip_fib.h|3 ++- net/ipv4/fib_frontend.c |5 +++-- net/ipv4/route.c|2 +

[PATCH 6/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_route_output_slow.

2008-01-22 Thread Denis V. Lunev
This function needs a net namespace to lookup devices, fib tables, etc. in, so pass it there. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/ipv4/route.c | 22 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c i

[PATCH 2/12 net-2.6.25] [IPV4]: Consolidate fib_select_default.

2008-01-22 Thread Denis V. Lunev
The difference in the implementation of the fib_select_default when CONFIG_IP_MULTIPLE_TABLES is (not) defined looks negligible. Consolidate it and place into fib_frontend.c. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/ip_fib.h| 10 +- net/ipv4/fib_frontend.c |

[PATCH 4/12 net-2.6.25] [NETNS]: Add namespace parameter to ip_dev_find.

2008-01-22 Thread Denis V. Lunev
in_dev_find() need a namespace to pass it to fib_get_table(), so add an argument. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- drivers/infiniband/core/addr.c |4 ++-- drivers/infiniband/core/cma.c |2 +- include/linux/inetdevice.h |2 +- net/ipv4/fib_frontend.c|

[PATCH 1/12 net-2.6.25] [IPV4]: Declarations cleanup in ip_fib.h.

2008-01-22 Thread Denis V. Lunev
Two small issues fixed: - fib_select_multipath is exported from fib_semantics.c rather than from fib_frontend.c. So, move the declaration below appropriate comment. - struct rt_entry declaration is not used. Drop it. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- include/net/ip_fib.h |

[PATCH 5/12 net-2.6.25] [NETNS]: Re-export init_net via EXPORT_SYMBOL.

2008-01-22 Thread Denis V. Lunev
init_net is used added as a parameter to a lot of old API calls, f.e. ip_dev_find. These calls were exported as EXPORT_SYMBOL. So, export init_net as EXPORT_SYMBOL to keep networking API consistent. Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> --- net/core/net_namespace.c |2 +- 1 files

[PATCH 0/12 net-2.6.25] [NETNS]: Routing namespacing on IP output path.

2008-01-22 Thread Denis V. Lunev
This set introduces namespacing in the IP output path. The namespace is added to all routing API functions except ones with a valid socket. This is very intrusive. Routing cache is virtualized as a part of this efforts, though the hash function is not tuned to use namespace id. This not required t

[PATCH net-2.6.25] Add packet filtering based on process's security context.

2008-01-22 Thread Tetsuo Handa
This patch modifies security_socket_post_accept() and introduces security_socket_post_recv_datagram() LSM hooks. Currently, security_socket_post_accept() is called *after* fd_install() at sys_accept(). This means that userland process might access accept()ed but not yet properly labeled socket. I

[NET_SCHED 06/06]: Convert actions from rtnetlink to new netlink API

2008-01-22 Thread Patrick McHardy
[NET_SCHED]: Convert actions from rtnetlink to new netlink API Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 9d8b9cf5c729a718df7861276e6f4c4868a89bd2 tree 64eca29283578c622c492013ec6562bd95f7a7cd parent 7798bc7f67ba5ffcfc542f5c88762b6db705992e author Patrick McHardy <[EMAIL PROTEC

[NET_SCHED 05/06]: Convert classifiers from rtnetlink to new netlink API

2008-01-22 Thread Patrick McHardy
[NET_SCHED]: Convert classifiers from rtnetlink to new netlink API Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 7798bc7f67ba5ffcfc542f5c88762b6db705992e tree 4a6d67ac7a5f1c667ed025a56264ecb35486118e parent 07a5a2c72eb790323d3e11bb2e1131f8fd43ae1d author Patrick McHardy <[EMAIL PR

[NETLINK 03/06]: Add nla_append()

2008-01-22 Thread Patrick McHardy
[NETLINK]: Add nla_append() Used to append data to a message without a header or padding. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 8a6648ddc22e03bbdf6675780c917e8c8519f205 tree 39c68f8b7aea4e94c227fe421031e0969dac92ef parent 4cf7dba2c890608fee47fe46487c79abf322dc82 author Pa

[NET_SCHED 02/06]: mark classifier ops __read_mostly

2008-01-22 Thread Patrick McHardy
[NET_SCHED]: mark classifier ops __read_mostly Additionally remove unnecessary NULL initilizations of the next pointer. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 4cf7dba2c890608fee47fe46487c79abf322dc82 tree 4f29f07adbaf0dfe78f6148205644b6b2dbd1717 parent 8b868a47c5bedb1daa85

[NET_SCHED 01/06]: Move EXPORT_SYMBOL next to exported symbol

2008-01-22 Thread Patrick McHardy
[NET_SCHED]: Move EXPORT_SYMBOL next to exported symbol Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 8b868a47c5bedb1daa8534ae60c2d89fcad26781 tree 93ba760730b3b3e74250c984e871840ace8317a3 parent bae4a7effd59ef0d521de2bc97902fa0a243b544 author Patrick McHardy <[EMAIL PROTECTED]> T

[NET_SCHED 00/06]: Conversion to new netlink API

2008-01-22 Thread Patrick McHardy
These patches convert the packet schedulers to the new netlink API. This will allow to use the new features like automatic attribute checking and gets rid of the largest rtnetlink.h user we still have. Unfortunately a gradual conversion is not really feasible, so the patches are quite large, but mo

[IPV4]: Add missing skb->truesize increment in ip_append_page().

2008-01-22 Thread David Miller
I just checked the following into net-2.6 [IPV4]: Add missing skb->truesize increment in ip_append_page(). Signed-off-by: David S. Miller <[EMAIL PROTECTED]> diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index fd99fbd..e582dba 100644 --- a/net/ipv4/ip_output.c +++ b/net/ipv4/ip_o

Re: [git patches] net driver updates

2008-01-22 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 06:02:31 -0500 > NOTE: This is the igb as Auke submitted it. It still needs a review > against ultra-recent Intel driver work. > > Please pull from 'upstream-davem' branch of > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netde

Re: [DST]: shrinks sizeof(struct rtable) by 64 bytes on x86_64

2008-01-22 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 11:50:06 +0100 > On x86_64, sizeof(struct rtable) is 0x148, which is rounded up to 0x180 > bytes by SLAB allocator. > > We can reduce this to exactly 0x140 bytes, without alignment overhead, > and store 12 struct rtable per PAGE instea

Re: [PATCH] SCTP: Fix kernel panic while received AUTH chunk with BAD shared key identifier

2008-01-22 Thread David Miller
From: Wei Yongjun <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 17:29:20 +0900 > If SCTP-AUTH is enabled, received AUTH chunk with BAD shared key > identifier will cause kernel panic. Vlad, please review this. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body

  1   2   >