Re: Packetlost when "tc qdisc del dev eth0 root"

2008-01-15 Thread Jarek Poplawski
On Wed, Jan 16, 2008 at 06:02:00AM +0100, Patrick McHardy wrote: ... > This would need support from the qdiscs to do it properly. Looks > non-trivial for HTB/HFSC/CBQ, but the others shouldn't be that hard. Yes. At first I've thought this would need quite a lot of work, but it seems, there could b

Re: [PATCH] net: NEWEMAC: Fix problem with mtu > 4080 on non TAH equipped 4xx PPC's

2008-01-15 Thread Benjamin Herrenschmidt
On Wed, 2008-01-16 at 08:11 +0100, Stefan Roese wrote: > Currently, all non TAH equipped 4xx PPC's call emac_start_xmit() upon > xmit. This routine doesn't check if the frame length exceeds the max. > MAL buffer size. > > This patch now changes the driver to call emac_start_xmit_sg() on all > Gig

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-15 Thread Zhang, Yanmin
On Wed, 2008-01-16 at 08:34 +0800, Zhang, Yanmin wrote: > On Mon, 2008-01-14 at 21:53 +1100, Herbert Xu wrote: > > On Mon, Jan 14, 2008 at 08:44:40AM +, Ilpo Jrvinen wrote: > > > > > > > > I tried to use bisect to locate the bad patch between 2.6.22 and > > > > > 2.6.23-rc1, > > > > > but the

[PATCH] net: NEWEMAC: Fix problem with mtu > 4080 on non TAH equipped 4xx PPC's

2008-01-15 Thread Stefan Roese
Currently, all non TAH equipped 4xx PPC's call emac_start_xmit() upon xmit. This routine doesn't check if the frame length exceeds the max. MAL buffer size. This patch now changes the driver to call emac_start_xmit_sg() on all GigE platforms and not only the TAH equipped ones (440GX). This enables

[PATCH] net: EMAC: Fix problem with mtu > 4080 on non TAH equipped 4xx PPC's

2008-01-15 Thread Stefan Roese
Currently, all non TAH equipped 4xx PPC's call emac_start_xmit() upon xmit. This routine doesn't check if the frame length exceeds the max. MAL buffer size. This patch now changes the driver to call emac_start_xmit_sg() on all GigE platforms and not only the TAH equipped ones (440GX). This enables

[IPV4] FIB_HASH: Reduce memory needs and speedup lookups

2008-01-15 Thread Eric Dumazet
Hi David CONFIG_FIB_HASH=y being default configuration, we can still work on it. Thank you [IPV4] FIB_HASH: Reduce memory needs and speedup lookups Currently, sizeof(struct fib_alias) is 24 or 48 bytes on 32/64 bits arches. Because of SLAB_HWCACHE_ALIGN requirement, these are rounded to 32 an

Re: questions on NAPI processing latency and dropped network packets

2008-01-15 Thread Jarek Poplawski
On Wed, Jan 16, 2008 at 11:17:08AM +1100, Herbert Xu wrote: ... > Well people are always going to operate on this model for commercial > reasons. FWIW I used to work for a company that stuck to a specific > version of the Linux kernel, and I suppose I still do even now :) > > But the important th

Re: [PATCH] net: EMAC: Fix problem with mtu > 4080 on non TAH equipped 4xx PPC's

2008-01-15 Thread Stefan Roese
On Tuesday 15 January 2008, Eugene Surovegin wrote: > > OK. But how do we detect GigE support? Seems like GigE enabled devices > > have CONFIG_IBM_EMAC4 defined. If nobody objects I'll fix up another > > version tomorrow. > > Look couple of lines down where I set MTU changing hook. If you cannot >

Re: [PATCH 1/4] bonding: Fix work initing and cancelling

2008-01-15 Thread Makito SHIOKAWA
I wonder why don't you use cancel_delayed_work_sync() here (and in a few other places), like in bond_work_cancel_all() from patch 2/4? In bond_close(), you can't use cancel_delayed_work_sync() because you can't unlock RTNL in it. (So, on current implementation, it becomes work cancel is not ensur

Re: Not understand some in htb_do_events function

2008-01-15 Thread Patrick McHardy
Martin Devera wrote: So this was meant to protect against endless loops? We want way to smooth big burst of events over more dequeue invocations in order to not slow dequeue too much. Constant 500 is max. allowed "slowdown" of dequeue. Any bright idea how to do it more elegant, Patrick ? Un

Re: Packetlost when "tc qdisc del dev eth0 root"

2008-01-15 Thread Patrick McHardy
[EMAIL PROTECTED] wrote: Good night! =) Sorry... i was wrong... I see that problem more serious Lets see to scheme Class 1 ---qdisc --- 10k classes Class 2 ---qdisc --- 10k classes All traffic go to class 2... class 1 qdisc not have packets and if we delete it - packets not lost.

Re: Not understand some in htb_do_events function

2008-01-15 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 15 Jan 2008 16:54:41 +0100 > Martin Devera wrote: > > to drain extra events asap. It the time of writing I was not able to > > come with better solution and there were more bugs related to this > > part of code than now. > > So this was meant t

Re: Packetlost when "tc qdisc del dev eth0 root"

2008-01-15 Thread Patrick McHardy
Jarek Poplawski wrote: Patrick McHardy wrote, On 01/15/2008 05:05 PM: Badalian Vyacheslav wrote: ... Yes, packets in the old qdisc are lost. Maybe if tc do changes - need create second queue (hash of rules or how you named it?) and do changes at it. Then replace old queue rules by create

Re: [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang

2008-01-15 Thread David Miller
From: "Brandeburg, Jesse" <[EMAIL PROTECTED]> Date: Tue, 15 Jan 2008 13:53:43 -0800 > The tx code has an "early exit" that tries to limit the amount of tx > packets handled in a single poll loop and requires napi or interrupt > rescheduling based on the return value from e1000_clean_tx_irq. That

Re: [Bugme-new] [Bug 9758] New: net_device refcnt bug when NFQUEUEing bridged packets

2008-01-15 Thread Patrick McHardy
Patrick McHardy wrote: Very nice catch, that explains quite a few bug reports about refcnt leaks. Your patch looks correct and performs the copying in the logically correct place, it would be nicer to keep this crap limited to bridge netfilter however. What should work is to perform the copying

Re: [Bugme-new] [Bug 9758] New: net_device refcnt bug when NFQUEUEing bridged packets

2008-01-15 Thread Patrick McHardy
Andrew Morton wrote: On Tue, 15 Jan 2008 15:28:31 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9758 The bug is probably around since the combination bridge+NFQUEUE is possible, and does not depend on distro or environment: Packets that are to be sent out ove

RE: [PATCH 1/3] drivers/misc :UCC based TDM driver for MPC83xx platforms.

2008-01-15 Thread Aggrwal Poonam
Thanks Morton for your comments, I shall incorporate them and reesnd the patch. With Regards Poonam -Original Message- From: Andrew Morton [mailto:[EMAIL PROTECTED] Sent: Tuesday, January 15, 2008 2:45 AM To: Aggrwal Poonam Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]

Re: [PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-15 Thread Rusty Russell
On Wednesday 16 January 2008 11:06:21 Herbert Xu wrote: > Rusty Russell <[EMAIL PROTECTED]> wrote: > > It's far easier to deal with GSO if we don't have to parse the packet > > to figure out the header length. Add the field to the virtio_net_hdr > > struct (and fix the spaces that somehow crept in

Re: [PATCH net-2.6.25 4/7][ATM]: [br2864] routed support

2008-01-15 Thread Chung-Chi Lo
On Dec 30, 2007 9:07 AM, chas williams - CONTRACTOR <[EMAIL PROTECTED]> wrote: > commit fea6b121bcc150fc91186e5012466c91944ce64d > Author: Eric Kinzie <[EMAIL PROTECTED]> > Date: Fri Oct 26 08:05:08 2007 -0400 > > [ATM]: [br2864] routed support > > From: Eric Kinzie <[EMAIL PROTECTED]> >

Re: [PATCH 3/4] bonding: Fix work rearming

2008-01-15 Thread Makito SHIOKAWA
> Though message in bonding_store_miimon() says miimon value 1-INT_MAX > rejected, but it looks like 0 can be accepted and monitor must be > stopped in that case. => miimon value *not in range* 1-INT_MAX -- Makito SHIOKAWA MIRACLE LINUX CORPORATION -- To unsubscribe from this list: send the line

Re: [PATCH 3/4] bonding: Fix work rearming

2008-01-15 Thread Makito SHIOKAWA
This patch is supposing a case that bond_mii_monitor() is invoked in bond_open(), and after that, 0 is set to miimon via sysfs (see same place on other monitors). Though message in bonding_store_miimon() says miimon value 1-INT_MAX rejected, but it looks like 0 can be accepted and monitor must b

[PATCH] ethtool: update license field in specfile to be correctly defined

2008-01-15 Thread Jesse Brandeburg
From: Jesse Brandeburg <[EMAIL PROTECTED]> The ethtool spec file needs to have the correct syntax license line. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> --- ethtool.spec.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ethtool.spec.in b/ethtool.spec.in ind

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-15 Thread Zhang, Yanmin
On Mon, 2008-01-14 at 21:53 +1100, Herbert Xu wrote: > On Mon, Jan 14, 2008 at 08:44:40AM +, Ilpo J�rvinen wrote: > > > > > > I tried to use bisect to locate the bad patch between 2.6.22 and > > > > 2.6.23-rc1, > > > > but the bisected kernel wasn't stable and went crazy. > > > > TCP work bet

Re: questions on NAPI processing latency and dropped network packets

2008-01-15 Thread Herbert Xu
Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > So, it was more a rhetorical trick (sorry!) to suggest, that such a > business model of being always late with kernels might be quite > practical and reasonable for many companies, but looks like the > worst possible development model for Linux. Well

Re: [PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-15 Thread Herbert Xu
Rusty Russell <[EMAIL PROTECTED]> wrote: > It's far easier to deal with GSO if we don't have to parse the packet > to figure out the header length. Add the field to the virtio_net_hdr > struct (and fix the spaces that somehow crept in there). > > Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> >

Re: [Bugme-new] [Bug 9758] New: net_device refcnt bug when NFQUEUEing bridged packets

2008-01-15 Thread Andrew Morton
On Tue, 15 Jan 2008 15:28:31 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9758 > >Summary: net_device refcnt bug when NFQUEUEing bridged packets >Product: Networking >Version: 2.5 > KernelVersion: 2.6.24-rc7 >

[PATCH] ne2k: add minimal ethtool setting support

2008-01-15 Thread Stephen Hemminger
Add minimal ethtool settings support for ne2k driver. This is needed for KVM/QEMU environment where ne2k seems to be the simplest stupid hardware used. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/ne2k-pci.c2008-01-15 11:21:02.0 -0800 +++ b/drivers/net/ne2k-p

Re: Packetlost when "tc qdisc del dev eth0 root"

2008-01-15 Thread Glen Turner
On Wed, 2008-01-16 at 00:46 +0300, [EMAIL PROTECTED] wrote: > But i have above 45 k classes and qdiscs After some time i will > need patch to up max qdisc and classes more then 65k (> 0xfffe) =))) > Also i have very bad TC commands performance then i have more then 10k rules. In contrast a

Re: [PATCH] IPv6 support for NFS server

2008-01-15 Thread J. Bruce Fields
Mostly just more trivial stuff for now, apologies: On Tue, Jan 15, 2008 at 05:32:21PM -0500, J. Bruce Fields wrote: > diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c > index cbbc594..e29b431 100644 > --- a/fs/nfsd/export.c > +++ b/fs/nfsd/export.c > @@ -35,6 +35,7 @@ > #include > #include

Re: Packetlost when "tc qdisc del dev eth0 root"

2008-01-15 Thread Jarek Poplawski
On Wed, Jan 16, 2008 at 01:04:59AM +0300, [EMAIL PROTECTED] wrote: > Good night! =) Good morning! ;) > > Sorry... i was wrong... > I see that problem more serious > > Lets see to scheme > > Class 1 > ---qdisc > --- 10k classes > Class 2 > ---qdisc > --- 10k classes > > All traffic go

Re: [PATCH] IPv6 support for NFS server

2008-01-15 Thread J. Bruce Fields
On Tue, Dec 11, 2007 at 07:00:08PM +0100, Aurélien Charbon wrote: > Brian Haley wrote: > >> In an email back on October 29th I sent-out a similar patch with a new >> ipv6_addr_set_v4mapped() inline - it might be useful to pull that >> piece into your patch since it cleans it up a bit to get rid

Re: Packetlost when "tc qdisc del dev eth0 root"

2008-01-15 Thread Jarek Poplawski
On Wed, Jan 16, 2008 at 12:46:02AM +0300, [EMAIL PROTECTED] wrote: ... > Hmmm... i found way to fix this for me... but its not look good > > Scheme look like: > Root - prio bands 3 priomap 0 0 0 0 > --- Class 1 > --- Class 2 > Copy of all table (Last this qdisc be root) > --- Class 3

[PATCH] 8390: fix CONFIG_LOCKDEP error, 2.6.24-rc7

2008-01-15 Thread Frank Rowand
From: Frank Rowand <[EMAIL PROTECTED]> Turning on CONFIG_LOCKDEP for CONFIG_PREEMPT invokes a path which may sleep with IRQs disabled. Change disable_irq_nosync_lockdep() to disable_irq_nosync(), etc. Note the comment near the top of drivers/net/lib8390.c, which is an lkml email from Alan Cox, p

Re: Packetlost when "tc qdisc del dev eth0 root"

2008-01-15 Thread slavon
Good night! =) Sorry... i was wrong... I see that problem more serious Lets see to scheme Class 1 ---qdisc --- 10k classes Class 2 ---qdisc --- 10k classes All traffic go to class 2... class 1 qdisc not have packets and if we delete it - packets not lost... in theory... lets try

Re: Not understand some in htb_do_events function

2008-01-15 Thread Martin Devera
So this was meant to protect against endless loops? We want way to smooth big burst of events over more dequeue invocations in order to not slow dequeue too much. Constant 500 is max. allowed "slowdown" of dequeue. Any bright idea how to do it more elegant, Patrick ? Unfortunately not, but I

RE: [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang

2008-01-15 Thread Brandeburg, Jesse
[EMAIL PROTECTED] wrote: > Quoting Frans Pop <[EMAIL PROTECTED]>: >>> (Note this isn't the final correct patch we should apply. There is >>> no reason why this revert back to the older ->poll() logic here >>> should have any effect on the TX hang triggering...) >> >> s/no reason/no obvious reas

Re: Packetlost when "tc qdisc del dev eth0 root"

2008-01-15 Thread slavon
Quoting Jarek Poplawski <[EMAIL PROTECTED]>: Patrick McHardy wrote, On 01/15/2008 05:05 PM: Badalian Vyacheslav wrote: ... Yes, packets in the old qdisc are lost. Maybe if tc do changes - need create second queue (hash of rules or how you named it?) and do changes at it. Then replace old

Re: [RFC 6/6] fib_trie: combine leaf and info

2008-01-15 Thread Eric Dumazet
Robert Olsson a écrit : Stephen Hemminger writes: > This is how I did it: Yes looks like an elegant solution. Did you even test it? Maybe we see some effects in just dumping a full table? Anyway lookup should be tested in some way. We can a lot of analyzing before getting to right entry,

Re: Packetlost when "tc qdisc del dev eth0 root"

2008-01-15 Thread Jarek Poplawski
Patrick McHardy wrote, On 01/15/2008 05:05 PM: > Badalian Vyacheslav wrote: ... > Yes, packets in the old qdisc are lost. > >> Maybe if tc do changes - need create second queue (hash of rules or how >> you named it?) and do changes at it. Then replace old queue rules by >> created new. >> Log

Is there an easy way for non-privileged users to determine an interface's speed?

2008-01-15 Thread Mark Seger
I think the current answer is they can't but I also wanted to confirm it with this list. I had hoped I might be able to find it in /proc, /sys or with a utility like ethtool or even ifconfig, but alas it's nowhere to be seen. So if I'm correct, that leads to the second question of why not? W

Re: [PATCH 1/3] skb_partial_csum_set

2008-01-15 Thread Rusty Russell
On Tuesday 15 January 2008 22:14:22 David Miller wrote: > From: Rusty Russell <[EMAIL PROTECTED]> > Date: Tue, 15 Jan 2008 21:41:55 +1100 > > > Implement skb_partial_csum_set, for setting partial csums on untrusted > > packets. > > > > Use it in virtio_net (replacing buggy version there), it's also

SO_RCVBUF doesn't change receiver advertised window

2008-01-15 Thread Ritesh Kumar
Hi, I am using linux 2.6.20 and am trying to limit the receiver window size for a TCP connection. However, it seems that auto tuning is not turning itself off even after I use the syscall rwin=65536 setsockopt(sock, SOL_SOCKET, SO_RCVBUF, &rwin, sizeof(rwin)); and verify using getsockopt(soc

[PATCH 02/03] ISATAP V2 (ndisc.c; route.c changes)

2008-01-15 Thread Templin, Fred L
This patch updates the Linux the Intra-Site Automatic Tunnel Addressing Protocol (ISATAP) implementation. It places the ISATAP potential router list (PRL) in the kernel and adds three new private ioctls for PRL management. The diffs are specific to the netdev net-2.6.25 development tree taken by "g

Re: questions on NAPI processing latency and dropped network packets

2008-01-15 Thread Jarek Poplawski
On Tue, Jan 15, 2008 at 08:47:07AM -0600, Chris Friesen wrote: > Jarek Poplawski wrote: > >> IMHO, checking this with a current stable, which probably you are going >> to do some day, anyway, should be 100% acceptable: giving some input to >> netdev, while still working for yourself. > > While I wo

Re: [RFC 6/6] fib_trie: combine leaf and info

2008-01-15 Thread Robert Olsson
Stephen Hemminger writes: > This is how I did it: Yes looks like an elegant solution. Did you even test it? Maybe we see some effects in just dumping a full table? Anyway lookup should be tested in some way. We can a lot of analyzing before getting to right entry, local_table backtracking

[PATCH 03/03] ISATAP V2 (sit.c changes)

2008-01-15 Thread Templin, Fred L
This patch updates the Linux the Intra-Site Automatic Tunnel Addressing Protocol (ISATAP) implementation. It places the ISATAP potential router list (PRL) in the kernel and adds three new private ioctls for PRL management. The diffs are specific to the netdev net-2.6.25 development tree taken by "g

Re: [PATCH] net: EMAC: Fix problem with mtu > 4080 on non TAH equipped 4xx PPC's

2008-01-15 Thread Eugene Surovegin
On Tue, Jan 15, 2008 at 08:46:01PM +0100, Stefan Roese wrote: > On Tuesday 15 January 2008, Eugene Surovegin wrote: > > On Tue, Jan 15, 2008 at 01:40:09PM +0100, Stefan Roese wrote: > > > Currently, all non TAH equipped 4xx PPC's call emac_start_xmit() upon > > > xmit. This routine doesn't check if

[PATCH 01/03] ISATAP V2 (header file changes)

2008-01-15 Thread Templin, Fred L
This patch updates the Linux the Intra-Site Automatic Tunnel Addressing Protocol (ISATAP) implementation. It places the ISATAP potential router list (PRL) in the kernel and adds three new private ioctls for PRL management. The diffs are specific to the netdev net-2.6.25 development tree taken by "g

Re: [PATCH] net: EMAC: Fix problem with mtu > 4080 on non TAH equipped 4xx PPC's

2008-01-15 Thread Stefan Roese
On Tuesday 15 January 2008, Eugene Surovegin wrote: > On Tue, Jan 15, 2008 at 01:40:09PM +0100, Stefan Roese wrote: > > Currently, all non TAH equipped 4xx PPC's call emac_start_xmit() upon > > xmit. This routine doesn't check if the frame length exceeds the max. > > MAL buffer size. > > > > This p

Re: sky2 patch in 2.6.24-rc7-git6 breaks POST - commit 84cd2dfb04d23a961c5f537baa243fa54d0987ac

2008-01-15 Thread Stephen Hemminger
On Tue, 15 Jan 2008 21:00:13 +0200 "Ioan Ionita" <[EMAIL PROTECTED]> wrote: > On Jan 15, 2008 8:09 PM, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > On Tue, 15 Jan 2008 13:01:47 +0200 > > "Ioan Ionita" <[EMAIL PROTECTED]> wrote: > > > > > > > Is Wake On Lan enabled in the BIOS? > > I don't ha

Re: sky2 patch in 2.6.24-rc7-git6 breaks POST - commit 84cd2dfb04d23a961c5f537baa243fa54d0987ac

2008-01-15 Thread Ioan Ionita
On Jan 15, 2008 8:09 PM, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > On Tue, 15 Jan 2008 13:01:47 +0200 > "Ioan Ionita" <[EMAIL PROTECTED]> wrote: > > > Is Wake On Lan enabled in the BIOS? I don't have a Wake on Lan option in BIOS, only wake on pci, i assume it's the same. It was disabled. I

Re: [RFC 6/6] fib_trie: combine leaf and info

2008-01-15 Thread Eric Dumazet
On Tue, 15 Jan 2008 10:15:43 -0800 Stephen Hemminger <[EMAIL PROTECTED]> wrote: > On Tue, 15 Jan 2008 19:10:31 +0100 > Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > On Tue, 15 Jan 2008 09:47:53 -0800 > > Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > > > > This is how I did it: > > > > > > --

Re: [RFC 6/6] fib_trie: combine leaf and info

2008-01-15 Thread Stephen Hemminger
On Tue, 15 Jan 2008 19:10:31 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > On Tue, 15 Jan 2008 09:47:53 -0800 > Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > > This is how I did it: > > > > --- a/net/ipv4/fib_trie.c 2008-01-15 09:14:53.0 -0800 > > +++ b/net/ipv4/fib_trie.c 2008-

Re: sky2 patch in 2.6.24-rc7-git6 breaks POST - commit 84cd2dfb04d23a961c5f537baa243fa54d0987ac

2008-01-15 Thread Stephen Hemminger
On Tue, 15 Jan 2008 13:01:47 +0200 "Ioan Ionita" <[EMAIL PROTECTED]> wrote: > Hi, > > I have an Asus Commando motherboard, p965 chipset with Marvell > 88E8056 and 88E8001 gigabit lan onboard. skge and sky2 are compiled > in. > When booting linux-2.6.24-rc7-git6, everything seemed fine, but when >

Re: [RFC 6/6] fib_trie: combine leaf and info

2008-01-15 Thread Eric Dumazet
On Tue, 15 Jan 2008 09:47:53 -0800 Stephen Hemminger <[EMAIL PROTECTED]> wrote: > This is how I did it: > > --- a/net/ipv4/fib_trie.c 2008-01-15 09:14:53.0 -0800 > +++ b/net/ipv4/fib_trie.c 2008-01-15 09:21:48.0 -0800 > @@ -101,13 +101,6 @@ struct node { > t_key key;

[PATCH 2/4] fib_trie style cleanup

2008-01-15 Thread Stephen Hemminger
Style cleanups: * make check_leaf return -1 or plen, rather than by reference * Get rid of #ifdef that is always set * split out embedded function calls in if statements. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-15 08:25:46.000

[PATCH 1/4] fib_trie: put leaf nodes in a slab cache

2008-01-15 Thread Stephen Hemminger
This improves locality for operations that touch all the leaves. Save space since these entries don't need to be hardware cache aligned. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-15 08:19:40.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-0

[PATCH 4/4] fib_trie: put first leaf_info with leaf

2008-01-15 Thread Stephen Hemminger
For locality, always allocate one leaf_info with the leaf. This method uses pointer arithmetic to identify this specially allocated leaf_info to avoid freeing it. It is possible to construct pathalogical cases where this ends up wasting a leaf_info, ie. construct a route with two prefixes then alw

[PATCH 0/4] fib_trie (day 3)

2008-01-15 Thread Stephen Hemminger
This is more cleanup followed by my version of the leaf_info cache. -- Stephen Hemminger <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/4] fib_trie: use hash list

2008-01-15 Thread Stephen Hemminger
The code to dump can use the existing hash chain rather than doing repeated lookup. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2008-01-15 09:48:10.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-15 09:48:21.0 -0800 @@ -879,11 +879,10 @@ n

Re: [RFC 6/6] fib_trie: combine leaf and info

2008-01-15 Thread Robert Olsson
Eric Dumazet writes: > > So you think that a leaf cannot have 2 infos, one 'embeded' and one in the > list ? Hello, The model I thought of is to have either: 1) One leaf_info embedded in leaf. A fast-path leaf. FP-leaf Or 2) The intct old leaf_info list with arbitrary number leaf

Re: [RFC 6/6] fib_trie: combine leaf and info

2008-01-15 Thread Stephen Hemminger
This is how I did it: --- a/net/ipv4/fib_trie.c 2008-01-15 09:14:53.0 -0800 +++ b/net/ipv4/fib_trie.c 2008-01-15 09:21:48.0 -0800 @@ -101,13 +101,6 @@ struct node { t_key key; }; -struct leaf { - unsigned long parent; - t_key key; - struct h

Re: [PATCH] net: EMAC: Fix problem with mtu > 4080 on non TAH equipped 4xx PPC's

2008-01-15 Thread Eugene Surovegin
On Tue, Jan 15, 2008 at 01:40:09PM +0100, Stefan Roese wrote: > Currently, all non TAH equipped 4xx PPC's call emac_start_xmit() upon > xmit. This routine doesn't check if the frame length exceeds the max. > MAL buffer size. > > This patch now changes the driver to call emac_start_xmit_sg() on all

Re: [RFC 6/6] fib_trie: combine leaf and info

2008-01-15 Thread Eric Dumazet
On Tue, 15 Jan 2008 17:44:47 +0100 Robert Olsson <[EMAIL PROTECTED]> wrote: > > Stephen Hemminger writes: > > > Okay, I would rather see the leaf_info explicit inside the leaf, also > > your scheme probably breaks if I add two prefixes and then delete the > first. > > Let me have a go at it.

Re: questions on NAPI processing latency and dropped network packets

2008-01-15 Thread Eric Dumazet
On Tue, 15 Jan 2008 11:14:25 -0600 "Chris Friesen" <[EMAIL PROTECTED]> wrote: > Radoslaw Szkodzinski (AstralStorm) wrote: > > On Tue, 15 Jan 2008 08:47:07 -0600 > > "Chris Friesen" <[EMAIL PROTECTED]> wrote: > > >>Some of our hardware is not supported on mainline, so we need per-kernel > >>versi

Re: questions on NAPI processing latency and dropped network packets

2008-01-15 Thread Chris Friesen
Radoslaw Szkodzinski (AstralStorm) wrote: On Tue, 15 Jan 2008 08:47:07 -0600 "Chris Friesen" <[EMAIL PROTECTED]> wrote: Some of our hardware is not supported on mainline, so we need per-kernel version patches to even bring up the blade. The blades netboot via a jumbo-frame network, so kernel

Re: [RFC 6/6] fib_trie: combine leaf and info

2008-01-15 Thread Robert Olsson
Stephen Hemminger writes: > Okay, I would rather see the leaf_info explicit inside the leaf, also > your scheme probably breaks if I add two prefixes and then delete the first. > Let me have a go at it. I took Eric's patch a bit further... Support for delete and dump is needed before any

Re: [RFC 6/6] fib_trie: combine leaf and info

2008-01-15 Thread Stephen Hemminger
On Tue, 15 Jan 2008 07:16:30 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > Eric Dumazet a écrit : > > Stephen Hemminger a écrit : > >> Combine the prefix information and the leaf together into one > >> allocation. This is furthur simplified by converting the hlist > >> into a simple bitfield. >

Re: Packetlost when "tc qdisc del dev eth0 root"

2008-01-15 Thread slavon
I understand. Thanks! Badalian Vyacheslav wrote: Hello all. Have packetlost when do "tc qdisc del dev eth0 root". look: slavon ~ # ping -f 87.255.1.134 PING 87.255.1.134 (87.255.1.134) 56(84) bytes of data. .

Re: [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang

2008-01-15 Thread slavon
Quoting Frans Pop <[EMAIL PROTECTED]>: On Tuesday 15 January 2008, David Miller wrote: From: Frans Pop <[EMAIL PROTECTED]> > kernel: e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang Does this make the problem go away? Yes, it very much looks like that solves it. I ran with the patch fo

Re: Packetlost when "tc qdisc del dev eth0 root"

2008-01-15 Thread Patrick McHardy
Badalian Vyacheslav wrote: Hello all. Have packetlost when do "tc qdisc del dev eth0 root". look: slavon ~ # ping -f 87.255.1.134 PING 87.255.1.134 (87.255.1.134) 56(84) bytes of data. .

Re: Not understand some in htb_do_events function

2008-01-15 Thread Patrick McHardy
Martin Devera wrote: Patrick McHardy wrote: Badalian Vyacheslav wrote: Hello all. I have many messages like "htb: too many events !" in dmesg. Try to see code and find that function try do 500 events at call. Hm... may anyone ask why 500? Why its not dynamic value based on performance of PC?

Re: [NETFILTER]: Supress some sparse warnings

2008-01-15 Thread Patrick McHardy
Eric Dumazet wrote: Hi Patrick Please find some sparse cleanups, against net-2.6.25 Thank you [NETFILTER]: Supress some sparse warnings CHECK net/netfilter/nf_conntrack_expect.c net/netfilter/nf_conntrack_expect.c:429:13: warning: context imbalance in 'exp_seq_start' - wrong count at exi

Re: questions on NAPI processing latency and dropped network packets

2008-01-15 Thread AstralStorm
On Tue, 15 Jan 2008 08:47:07 -0600 "Chris Friesen" <[EMAIL PROTECTED]> wrote: > Jarek Poplawski wrote: > > > IMHO, checking this with a current stable, which probably you are going > > to do some day, anyway, should be 100% acceptable: giving some input to > > netdev, while still working for your

Re: questions on NAPI processing latency and dropped network packets

2008-01-15 Thread Vlad Yasevich
Chris Friesen wrote: Eric Dumazet wrote: Chris Friesen a écrit : Based on the profiling information we're spending time in sctp_endpoint_lookup_assoc() which doesn't actually use hashes, so I can't see how the hash would be related. I'm pretty new to SCTP though, so I may be missing someth

[PATCH 1/4] [ROSE] simplified rose_get_route()

2008-01-15 Thread Bernard Pidoux
Hi, This patch is send to replace preceding commit : From fd66cc115e058b2fc63a0e26aa73f1d27113105a Mon Sep 17 00:00:00 2001 From: Bernard Pidoux <[EMAIL PROTECTED]> Date: Thu, 10 Jan 2008 23:10:44 +0100 Subject: [PATCH 1/4] [ROSE] new rose_get_route() function I removed unnecessary lines of co

Re: questions on NAPI processing latency and dropped network packets

2008-01-15 Thread Chris Friesen
Jarek Poplawski wrote: IMHO, checking this with a current stable, which probably you are going to do some day, anyway, should be 100% acceptable: giving some input to netdev, while still working for yourself. While I would love to do this, it's not that simple. Some of our hardware is not sup

Re: [PATCH 2/4] [ROSE] rose_get_route() template

2008-01-15 Thread Bernard Pidoux
Hi, I wrote a "simplified" get_route() function. It is declared as static following judicious Eric's remark. Then, the following patch of include/net/rose.h is no more necessary. A new commit for rose_get_route() will be presented in next message. Thank you Eric for pushing me to reexamine my

[patch v3] Documentation: add a guideline for hard_start_xmit method

2008-01-15 Thread Matti Linnanvuori
From: Matti Linnanvuori <[EMAIL PROTECTED]> Add a guideline not to modify SKBs. Signed-off-by: Matti Linnanvuori <[EMAIL PROTECTED]> --- --- a/Documentation/networking/driver.txt 2008-01-13 07:14:01.608291500 +0200 +++ b/Documentation/networking/driver.txt 2008-01-15 16:16:14.636054000 +0200 @@

Re: [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang

2008-01-15 Thread Frans Pop
On Tuesday 15 January 2008, David Miller wrote: > From: Frans Pop <[EMAIL PROTECTED]> > > kernel: e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang > > Does this make the problem go away? Yes, it very much looks like that solves it. I ran with the patch for 6 hours or so without any errors. I

Re: Not understand some in htb_do_events function

2008-01-15 Thread Martin Devera
Badalian Vyacheslav wrote: Martin Devera пишет: Patrick McHardy wrote: Badalian Vyacheslav wrote: Hello all. I have many messages like "htb: too many events !" in dmesg. Try to see code and find that function try do 500 events at call. Hm... may anyone ask why 500? Why its not dynamic value b

Re: Not understand some in htb_do_events function

2008-01-15 Thread Badalian Vyacheslav
Martin Devera пишет: Patrick McHardy wrote: Badalian Vyacheslav wrote: Hello all. I have many messages like "htb: too many events !" in dmesg. Try to see code and find that function try do 500 events at call. Hm... may anyone ask why 500? Why its not dynamic value based on performance of PC?

[PATCH] net: EMAC: Fix problem with mtu > 4080 on non TAH equipped 4xx PPC's

2008-01-15 Thread Stefan Roese
Currently, all non TAH equipped 4xx PPC's call emac_start_xmit() upon xmit. This routine doesn't check if the frame length exceeds the max. MAL buffer size. This patch now changes the driver to call emac_start_xmit_sg() on all platforms and not only the TAH equipped ones (440GX). This enables an M

Re: Not understand some in htb_do_events function

2008-01-15 Thread Martin Devera
Patrick McHardy wrote: Badalian Vyacheslav wrote: Hello all. I have many messages like "htb: too many events !" in dmesg. Try to see code and find that function try do 500 events at call. Hm... may anyone ask why 500? Why its not dynamic value based on performance of PC? Thats a good questi

RE: [PATCH 0/3] UCC TDM driver for MPC83xx platforms

2008-01-15 Thread Aggrwal Poonam
Thanks Kumar/Morton/Kim I shall make a small paragraph which describes the TDM driver architecture and the interfaces it exposes. As far as 8315 TDM is concerned it is a non QE driver and quite different from this except for the functionality and external interface it exposes. Right now TDM is n

Re: DM9000_IRQ_FLAGS

2008-01-15 Thread Daniel Mack
On Thu, Dec 20, 2007 at 10:54:34AM +0100, Remy Bohmer wrote: > > I did have a go at trying to get people to pass the information this > > way, but it seem to be ignored last time I sent it. I can dig out the > > code that converts resource->flags to IRQT_ flags. > > I thought this issue was alread

[NETFILTER]: Supress some sparse warnings

2008-01-15 Thread Eric Dumazet
Hi Patrick Please find some sparse cleanups, against net-2.6.25 Thank you [NETFILTER]: Supress some sparse warnings CHECK net/netfilter/nf_conntrack_expect.c net/netfilter/nf_conntrack_expect.c:429:13: warning: context imbalance in 'exp_seq_start' - wrong count at exit net/netfilter/nf_con

Re: [PATCH] enable SMC911X for ARCH_MX3

2008-01-15 Thread Daniel Mack
Hi, On Tue, Dec 11, 2007 at 08:12:33PM +0100, Daniel Mack wrote: > this patch enables SMX911X support for Freescale's MX3 platforms. Just wanted to know whether as this patch was accepted? Best regards, Daniel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH][IPV6]: Mischecked tw match in __inet6_check_established.

2008-01-15 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Tue, 15 Jan 2008 12:22:52 +0300 > When looking for a conflicting connection the !sk->sk_bound_dev_if > check is performed only for live sockets, but not for timewait-ed. > > This is not the case for ipv4, for __inet6_lookup_established in > both ipv

Re: [ROSE]: Supress sparse warnings

2008-01-15 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Tue, 15 Jan 2008 12:23:20 +0100 > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [ATM]: Suppress some sparse warnings

2008-01-15 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Tue, 15 Jan 2008 12:15:02 +0100 > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [APPLETALK]: Annotations to clear sparse warnings

2008-01-15 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Tue, 15 Jan 2008 12:10:20 +0100 > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> Applied, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vg

[ROSE]: Supress sparse warnings

2008-01-15 Thread Eric Dumazet
CHECK net/rose/af_rose.c net/rose/af_rose.c:125:11: warning: expensive signed divide net/rose/af_rose.c:976:46: warning: expensive signed divide net/rose/af_rose.c:1379:13: warning: context imbalance in 'rose_info_start' - wrong count at exit net/rose/af_rose.c:1406:13: warning: context imbala

[ATM]: Suppress some sparse warnings

2008-01-15 Thread Eric Dumazet
CHECK net/atm/br2684.c net/atm/br2684.c:665:13: warning: context imbalance in 'br2684_seq_start' - wrong count at exit net/atm/br2684.c:676:13: warning: context imbalance in 'br2684_seq_stop' - unexpected unlock CHECK net/atm/lec.c net/atm/lec.c:196:23: warning: expensive signed divide

Re: [PATCH 1/3] skb_partial_csum_set

2008-01-15 Thread David Miller
From: Rusty Russell <[EMAIL PROTECTED]> Date: Tue, 15 Jan 2008 21:41:55 +1100 > Implement skb_partial_csum_set, for setting partial csums on untrusted > packets. > > Use it in virtio_net (replacing buggy version there), it's also going > to be used by TAP for partial csum support. > > Signed-of

Packetlost when "tc qdisc del dev eth0 root"

2008-01-15 Thread Badalian Vyacheslav
Hello all. Have packetlost when do "tc qdisc del dev eth0 root". look: slavon ~ # ping -f 87.255.1.134 PING 87.255.1.134 (87.255.1.134) 56(84) bytes of data. .

[APPLETALK]: Annotations to clear sparse warnings

2008-01-15 Thread Eric Dumazet
CHECK net/appletalk/aarp.c net/appletalk/aarp.c:951:14: warning: context imbalance in 'aarp_seq_start' - wrong count at exit net/appletalk/aarp.c:977:13: warning: context imbalance in 'aarp_seq_stop' - unexpected unlock CHECK net/appletalk/atalk_proc.c net/appletalk/atalk_proc.c:34:11: wa

Re: [PATCH 1/4] bonding: Fix work initing and cancelling

2008-01-15 Thread Jarek Poplawski
On 15-01-2008 07:36, Makito SHIOKAWA wrote: ... > --- a/drivers/net/bonding/bond_sysfs.c > +++ b/drivers/net/bonding/bond_sysfs.c > @@ -643,10 +643,8 @@ static ssize_t bonding_store_arp_interva > "%s Disabling MII monitoring.\n", > bond->dev->name, bond->de

[PATCH 3/3] tun/tap GSO/partial csum support

2008-01-15 Thread Rusty Russell
This implements partial checksum and GSO support for tun/tap. We use the virtio_net_hdr: it is an ABI already and designed to encapsulate such metadata as GSO and partial checksums. lguest performance (160MB sendfile, worst/best/avg, 20 runs): Before: 5.06/3.39/3.82 After: 4.69/0

[PATCH 1/3] skb_partial_csum_set

2008-01-15 Thread Rusty Russell
Implement skb_partial_csum_set, for setting partial csums on untrusted packets. Use it in virtio_net (replacing buggy version there), it's also going to be used by TAP for partial csum support. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> --- drivers/net/virtio_net.c | 11 +-- incl

  1   2   >