From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 2 Jan 2008 18:16:20 +1100
> [IPSEC]: Return EOVERFLOW when output sequence number overflows
>
> Previously we made it an error on the output path if the sequence number
> overflowed. However we did not set the err variable accordingly. This
> patc
Hi Dave:
[IPSEC]: Return EOVERFLOW when output sequence number overflows
Previously we made it an error on the output path if the sequence number
overflowed. However we did not set the err variable accordingly. This
patch sets err to -EOVERFLOW in that case.
Signed-off-by: Herbert Xu <[EMAIL P
On Wed, Jan 02, 2008 at 07:13:08AM +0100, Andreas Mohr wrote:
> Hi,
>
> On Tue, Jan 01, 2008 at 10:00:06PM -0800, Greg KH wrote:
> > Ok, no, I didn't write that patch, I'm getting very confused here.
> >
> > In 2.6.24-rc6 there is no usage of debugfs in the ohci driver.
> >
> > In the -mm tree t
Hi,
> It's a pointer dereference assignment,
Sorry, I was wrong here !
> What automated tool showed this as useless to you?
> Please correct it's logic so it doesn't mark real side effects like
> this as superfluous.
I am not using any automated tool, only my eyes. And I
missed the intention here
Hi,
On Tue, Jan 01, 2008 at 10:00:06PM -0800, Greg KH wrote:
> Ok, no, I didn't write that patch, I'm getting very confused here.
>
> In 2.6.24-rc6 there is no usage of debugfs in the ohci driver.
>
> In the -mm tree there is a patch, from Tony Jones, that moves some debug
> code out of sysfs an
Hi,
On Sun, Dec 30, 2007 at 03:34:45PM -0500, Alan Stern wrote:
> It looks like Greg misused the debugfs API -- which is ironic, because
> he wrote debugfs in the first place! :-)
>
> Let me know if this patch fixes the problem. If it does, I'll submit
> it to Greg with all the proper accoutre
On Mon, Dec 31, 2007 at 11:26:43AM -0800, Greg KH wrote:
> On Mon, Dec 31, 2007 at 12:49:52PM -0500, Alan Stern wrote:
> > On Sun, 30 Dec 2007, Greg KH wrote:
> >
> > > > It looks like Greg misused the debugfs API -- which is ironic, because
> > > > he wrote debugfs in the first place! :-)
> > >
From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Wed, 02 Jan 2008 06:50:14 +0100
> Add __acquires() and __releases() annotations to suppress some sparse
> warnings.
>
> example of warnings :
>
> net/ipv4/udp.c:1555:14: warning: context imbalance in 'udp_seq_start' - wrong
> count at exit
> net/ipv
Add __acquires() and __releases() annotations to suppress some sparse warnings.
example of warnings :
net/ipv4/udp.c:1555:14: warning: context imbalance in 'udp_seq_start' - wrong
count at exit
net/ipv4/udp.c:1571:13: warning: context imbalance in 'udp_seq_stop' -
unexpected unlock
Signed-o
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Tue, 1 Jan 2008 15:48:51 +0200
> This patch removes IrPORT and the old dongle drivers (all off them
> have replacement drivers).
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
I'll let Sam make the call on this one.
--
To unsubscribe from this lis
From: "Rami Rosen" <[EMAIL PROTECTED]>
Date: Tue, 1 Jan 2008 12:48:14 +0200
> These following two commands in br_nf_forward_arp() achieve nothing and
> should be removed; the d variable is not used later in this method:
>
> ...
> struct net_device **d = (struct net_device **)(skb->cb)
From: "Rami Rosen" <[EMAIL PROTECTED]>
Date: Tue, 1 Jan 2008 11:19:49 +0200
> In include/net/ip_vs.h:
> - The ip_vs_secure_tcp_set() method is not implemented anywhere.
> - IP_VS_APP_TYPE_FTP is an unused definition.
>
> Signed-off-by: Rami Rosen <[EMAIL PROTECTED]>
Applied.
--
To unsubscribe fr
From: "Rami Rosen" <[EMAIL PROTECTED]>
Date: Tue, 1 Jan 2008 10:30:53 +0200
> These three declarations in include/net/ip.h are not implemented
> anywhere:
> ip_mc_dropsocket(), ip_mc_dropdevice() and ip_net_unreachable().
>
> Also, correct a comment to be "Functions provided by ip_fragment.c"
> (
From: Alan Cox <[EMAIL PROTECTED]>
Date: Tue, 1 Jan 2008 14:24:30 +
> On Tue, 1 Jan 2008 15:47:35 +0200
> Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > This patch contains the scheduled removal of the shaper driver.
> >
> > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
>
> Acked-by: Alan Co
From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Tue, 01 Jan 2008 16:33:33 +0100
> We use a percpu variable named flow_hash_info, which holds 12 bytes.
>
> It is currently marked as cacheline_aligned, which makes linker
> skip space to properly align this variable.
>
> Before :
> c065cc90 D per_
From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Tue, 01 Jan 2008 13:44:15 +0100
> Using __get_free_pages() has some drawbacks :
>
> 1) Not NUMA aware
>
> 2) 2^X page granularity :
> On arches with big PAGE_SIZE, we waste some ram for each cpu.
>
> (We currently use 1024 pointers, that is at most 8
From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Tue, 01 Jan 2008 19:46:21 +0100
> Instead of storing a pointer to a 'struct socket' and dereferencing ->sk
> to get "struct sock *" from it, just store a "struct sock *" pointer.
>
> This saves 75 bytes of text on x86
>
> Signed-off-by: Eric Dumazet <
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 2 Jan 2008 14:02:11 +1100
> [IPSEC]: Kill duplicate xfrm_policy_flush prototype
>
> For five years we had two xfrm_policy_flush prototypes and every time that
> function's signature changed people have been diligently updating both of
> them without
From: "Joonwoo Park" <[EMAIL PROTECTED]>
Date: Wed, 2 Jan 2008 11:56:36 +0900
> Since we had reached a consensus on fixing it without each drivers
> modifications, there is no best solution for that problem for
> now. I'm expecting Dave or others work for net-core.
> (http://lkml.org/lkml/2007/12/
Hi Dave:
[IPSEC]: Kill duplicate xfrm_policy_flush prototype
For five years we had two xfrm_policy_flush prototypes and every time that
function's signature changed people have been diligently updating both of
them without noticing :)
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
diff --git a/i
Hi Jay,
+ if ((work_done < budget) || !netif_running(poll_dev)) {
+quit_polling:
+ netif_rx_complete(poll_dev, napi);
+
+ if (!test_bit(__ATL1_DOWN, &adapter->flags))
+ atlx_irq_enable(adapter);
+ }
Not enough :)
If netif_running() is
Hello Patrick McHardy!
We have recently updated iproute in debian and have reports about the
new version breaking shorewall generated scripts.
The original bug-report can be found at:
http://bugs.debian.org/458539
Commands like "tc filter add dev ppp0 parent : protocol ip prio 50
u32 match
Hello all,
This is an announcement for a new beta release of a decently scalable L2TP
stack for Linux. It is based off of the Babylon PPP stack created by
SpellCaster back in the '98-'00 timeframe. Right now there are lots of
rough edges (especially in terms of documentation), but it works we
Hi,
On Sat, Dec 29, 2007 at 09:54:45PM -0800, Kok, Auke wrote:
> ok, barely glanced over the patch but it might just be fine. Can you split up
> this
> patch and send a separate patch for the spelling mistakes? I'll then have some
> quick testing done on the result and do a bit deeper review afte
Hi,
On Sat, Dec 29, 2007 at 09:54:45PM -0800, Kok, Auke wrote:
> ok, barely glanced over the patch but it might just be fine. Can you split up
> this
> patch and send a separate patch for the spelling mistakes? I'll then have some
> quick testing done on the result and do a bit deeper review afte
Instead of storing a pointer to a 'struct socket' and dereferencing ->sk
to get "struct sock *" from it, just store a "struct sock *" pointer.
This saves 75 bytes of text on x86
Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]>
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
index ccdef9a..fc66c8a
On Jan 1, 2008 1:59 PM, Torsten Kaiser <[EMAIL PROTECTED]> wrote:
> On Jan 1, 2008 1:04 PM, Herbert Xu <[EMAIL PROTECTED]> wrote:
> > On Mon, Dec 31, 2007 at 09:15:19PM +0100, Torsten Kaiser wrote:
> > >
> > > I then tried to "fix" it with this suspect.
> > > I changed "skb_release_all(dst);" back
Thanks for your comments Stephen and Joonwoo. Here's the revised
version of the atl1 NAPI patch.
>From 9c3a8944220287671f983557099bc329f02fda9b Mon Sep 17 00:00:00 2001
From: Jay Cliburn <[EMAIL PROTECTED]>
Date: Tue, 1 Jan 2008 11:55:24 -0600
Subject: [PATCH 25/26] atl1: add NAPI support
Add
On Tue, 1 Jan 2008 17:58:40 +
Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> On Mon, Dec 31, 2007 at 08:22:27PM -0600, Jay Cliburn wrote:
> > The first two patches submitted in this patchset accomplish the
> > relocation by movng the atl1 driver -- lock, stock, and barrel --
> > over to drive
On Mon, Dec 31, 2007 at 08:22:27PM -0600, Jay Cliburn wrote:
>
> [Neglected to cc netdev in the first wave.]
>
> Hello Jeff,
>
> Happy New Year to you and all.
>
> In preparation for a future atl2 driver for the Atheros L2 10/100 chip,
> we propose to move the existing atl1 driver to a new dire
Move the ip1000 driver into the expected place for gigabit cards
in the configuration menu structure. It should be under the gigabit
cards, not at the top level.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/drivers/net/Kconfig 2007-12-26 20:17:31.0 -0800
+++ b/drivers/
We use a percpu variable named flow_hash_info, which holds 12 bytes.
It is currently marked as cacheline_aligned, which makes linker
skip space to properly align this variable.
Before :
c065cc90 D per_cpu__softnet_data
c065cd00 d per_cpu__flow_tables
c065cd80 d per_cpu__flow_hash_info
c065
On Tue, 1 Jan 2008 15:47:35 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> This patch contains the scheduled removal of the shaper driver.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Alan Cox <[EMAIL PROTECTED]>
--
To unsubscribe from this list: send the line "unsubscribe netde
This patch contains the scheduled removal of the shaper driver.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
Documentation/feature-removal-schedule.txt |9
Documentation/networking/00-INDEX |2
Documentation/networking/shaper.txt| 48 -
drivers/net/Kconfig
On Jan 1, 2008 1:04 PM, Herbert Xu <[EMAIL PROTECTED]> wrote:
> On Mon, Dec 31, 2007 at 09:15:19PM +0100, Torsten Kaiser wrote:
> >
> > I then tried to "fix" it with this suspect.
> > I changed "skb_release_all(dst);" back to "skb_release_data(dst);" in
> > skb_morph() (net/core/skbuff.c).
>
> Chec
Using __get_free_pages() has some drawbacks :
1) Not NUMA aware
2) 2^X page granularity :
On arches with big PAGE_SIZE, we waste some ram for each cpu.
(We currently use 1024 pointers, that is at most 8192 bytes, but
PAGE_SIZE can be 65536 for example : With say 64 possible cpus,
thats about 56
On Mon, Dec 31, 2007 at 09:15:19PM +0100, Torsten Kaiser wrote:
>
> I then tried to "fix" it with this suspect.
> I changed "skb_release_all(dst);" back to "skb_release_data(dst);" in
> skb_morph() (net/core/skbuff.c).
Check /proc/net/snmp to see if you're getting any fragments, if not
then skb_m
Hi,
These following two commands in br_nf_forward_arp() achieve nothing and
should be removed; the d variable is not used later in this method:
...
struct net_device **d = (struct net_device **)(skb->cb);
...
*d = (struct net_device *)in;
...
Regards,
Rami
Hi,
In include/net/ip_vs.h:
- The ip_vs_secure_tcp_set() method is not implemented anywhere.
- IP_VS_APP_TYPE_FTP is an unused definition.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <[EMAIL PROTECTED]>
diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
index 8a7d59b..3de6d1e 100644
--- a
Hi,
These three declarations in include/net/ip.h are not implemented
anywhere:
ip_mc_dropsocket(), ip_mc_dropdevice() and ip_net_unreachable().
Also, correct a comment to be "Functions provided by ip_fragment.c"
(instead of by ip_fragment.o) in consistency with the other comments in this
header.
40 matches
Mail list logo
