Re: [RFC] net: napi fix

2007-12-12 Thread Joonwoo Park
2007/12/13, Kok, Auke <[EMAIL PROTECTED]>: > David Miller wrote: > > From: Andrew Gallatin <[EMAIL PROTECTED]> > > Date: Wed, 12 Dec 2007 12:29:23 -0500 > > > >> Is the netif_running() check even required? > > > > No, it is not. > > > > When a device is brought down, one of the first things > > tha

Re: [PATCH 2.6.25] IPv4: thresholds in fib_trie.c are not modified, make them const

2007-12-12 Thread Denis V. Lunev
David Miller wrote: > From: "Denis V. Lunev" <[EMAIL PROTECTED]> > Date: Wed, 12 Dec 2007 14:05:55 +0300 > >> -static int halve_threshold = 25; >> -static int inflate_threshold = 50; >> -static int halve_threshold_root = 15; >> -static int inflate_threshold_root = 25; > > halve_threshold_root and

Re: [PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of net_rx_action

2007-12-12 Thread Joonwoo Park
2007/12/13, David Miller <[EMAIL PROTECTED]>: > From: "Joonwoo Park" <[EMAIL PROTECTED]> > Date: Wed, 12 Dec 2007 13:01:27 +0900 > > > Any time your trying to make a caller "happy" by adjusting > a return value forcefully, it's a hack. > > And I stated this in another reply about this issue. > > Pl

Re: [RFC] ehea: kdump support using new shutdown hook

2007-12-12 Thread Michael Ellerman
On Wed, 2007-12-12 at 17:53 +0100, Thomas Klein wrote: > This patch adds kdump support using the new PPC crash shutdown hook to the > ehea driver. The driver now keeps a list of firmware handles which have to > be freed in case of a crash. The crash handler does the minimum required: it > frees the

Re: [RFC] ehea: kdump support using new shutdown hook

2007-12-12 Thread Michael Ellerman
On Wed, 2007-12-12 at 12:04 -0500, Dave Jones wrote: > On Wed, Dec 12, 2007 at 05:53:43PM +0100, Thomas Klein wrote: > > > +static void ehea_update_adapter_handles(struct ehea_adapter *adapter) > > +{ > > + int i, k; > > + int j = 0; > > + > > + memset(adapter->res_handles, sizeof(adapter

Re: [PATCH 4/4] [NETDEV] sky2: rtnl_lock out of loop will be faster

2007-12-12 Thread Wang Chen
Stephen Hemminger said the following on 2007-12-13 0:30: > Umm, okay but it doesn't matter really, there can only be 2 ports and > 90+% of the boards only have one port. So why bother?? > Thanks Stephen. David, please ignore all of the four patches. -- To unsubscribe from this list: send the li

net-2.6.235 warning

2007-12-12 Thread Andrew Morton
This is net-2.6.25 pulled ten hours ago. Top of tree was dc2d76df54c8211df766819749beb802f69733fc. Herbert's two ipsec patches are applied. Mac g5 acting as a distcc server had been running an hour or so. [ cut here ] Badness at net/ipv4/tcp_input.c:1280 NIP: c0

[PATCH] IPv6: Fix the return value of ipv6_getsockopt

2007-12-12 Thread Wei Yongjun
If CONFIG_NETFILTER if not selected when compile the kernel source code, ipv6_getsockopt will returen an EINVAL error if optname is not supported by the kernel. But if CONFIG_NETFILTER is selected, ENOPROTOOPT error will be return. This patch fix to always return ENOPROTOOPT error if optname argu

[DECNET]: Fix inverted wait flag in xfrm_lookup call

2007-12-12 Thread Herbert Xu
On Wed, Dec 12, 2007 at 06:49:19PM -0800, David Miller wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Thu, 13 Dec 2007 09:46:23 +0800 > > > [IPSEC]: Make callers of xfrm_lookup to use XFRM_LOOKUP_WAIT Sorry, I was too quick too :) I managed to invert the DECNet xfrm_lookup call. Here's a

Re: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice

2007-12-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 11:13:44 +0800 > Let's see who else is doing this: > > [NET]: Check RTNL status in unregister_netdevice > > The caller must hold the RTNL so let's check it in unregister_netdevice. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Goo

Re: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice

2007-12-12 Thread Herbert Xu
David Miller <[EMAIL PROTECTED]> wrote: > From: Wang Chen <[EMAIL PROTECTED]> > Date: Wed, 12 Dec 2007 10:35:56 +0800 > >> [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice > > Applied, thanks for finding and fixing this bug. Let's see who else is doing this: [NET]: Che

Re: [IPSEC]: Fix reversed ICMP6 policy check

2007-12-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 10:51:56 +0800 > You're too quick :) Before you ask for an incremental patch, here's > a preemptive strike :) Hehe :) > [IPSEC]: Do not let packets pass when ICMP flag is off > > This fixes a logical error in ICMP policy checks which l

Re: [IPSEC]: Fix reversed ICMP6 policy check

2007-12-12 Thread Herbert Xu
On Wed, Dec 12, 2007 at 06:48:30PM -0800, David Miller wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Thu, 13 Dec 2007 09:58:56 +0800 > > > [IPSEC]: Fix reversed ICMP6 policy check > > Applied, thanks Herbert. You're too quick :) Before you ask for an incremental patch, here's a preemptiv

Re: [IPSEC]: Fix reversed ICMP6 policy check

2007-12-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 10:49:18 +0800 > On Thu, Dec 13, 2007 at 09:58:56AM +0800, Herbert Xu wrote: > > > > [IPSEC]: Fix reversed ICMP6 policy check > > While that won't crash anymore, it's still logically wrong. > > Here's a more complete fix. I already app

Re: [IPSEC]: Fix reversed ICMP6 policy check

2007-12-12 Thread Herbert Xu
On Thu, Dec 13, 2007 at 09:58:56AM +0800, Herbert Xu wrote: > > [IPSEC]: Fix reversed ICMP6 policy check While that won't crash anymore, it's still logically wrong. Here's a more complete fix. [IPSEC]: Fix reversed ICMP6 policy check The policy check I added for ICMP on IPv6 is reversed. We we

Re: [IPSEC]: Make callers of xfrm_lookup to use XFRM_LOOKUP_WAIT

2007-12-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 09:46:23 +0800 > [IPSEC]: Make callers of xfrm_lookup to use XFRM_LOOKUP_WAIT > > This patch converts all callers of xfrm_lookup that used an > explicit value of 1 to indiciate blocking to use the new flag > XFRM_LOOKUP_WAIT. > > Signed

Re: [IPSEC]: Fix reversed ICMP6 policy check

2007-12-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 09:58:56 +0800 > [IPSEC]: Fix reversed ICMP6 policy check > > The policy check I added for ICMP on IPv6 is reversed. This > patch fixes that. > > It also adds an skb->sp check so that unprotected packets that > fail the policy check do

Re: Reproducible data corruption with sendfile+vsftp - splice regression?

2007-12-12 Thread Holger Hoffstaette
On Thu, 06 Dec 2007 19:44:26 +0100, Francois Romieu wrote: > Holger Hoffstaette <[EMAIL PROTECTED]> : [...] >> Maybe turning off sendfile or NAPI just lead to random success - so far >> it really looks like tso on the r8169 is the common cause. > > TSO on the r8169 is the magic switch but the reg

[IPSEC]: Fix reversed ICMP6 policy check

2007-12-12 Thread Herbert Xu
On Wed, Dec 12, 2007 at 05:39:51PM -0800, Andrew Morton wrote: > > Here's the screen-shot (actually more like a reen-hot): > http://userweb.kernel.org/~akpm/pc121694.jpg > > I'm awaiting a reoccurrence with the screen in 50-row mode. Sorry, I didn't test IPv6. [IPSEC]: Fix reversed ICMP6 policy

[IPSEC]: Make callers of xfrm_lookup to use XFRM_LOOKUP_WAIT

2007-12-12 Thread Herbert Xu
On Wed, Dec 12, 2007 at 10:43:42AM -0800, David Miller wrote: > > Begrudgingly, I've applied this, but only to make the merging of your > work easier. I think this flag is totally wrong and you need to > fix this up. Well I did do a grep to make sure it's safe. But yeah relying on ip_route_conne

Re: net-2.6.25 splat

2007-12-12 Thread Andrew Morton
On Wed, 12 Dec 2007 16:26:13 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Wed, 12 Dec 2007 16:21:40 -0800 > > > I don't know why it was doing ipv6 things at all. > > When you bring up any interface, with explicit IPV6 > addresses or not, t

[PATCH] ethtool: update license field in specfile to be correctly defined

2007-12-12 Thread Auke Kok
RPM uses "License" as field and not "Copyright". Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- ethtool.spec.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ethtool.spec.in b/ethtool.spec.in index 1705d7f..4ff736a

[PATCH] e100: free IRQ to remove warningwhenrebooting

2007-12-12 Thread Auke Kok
Adapted from Ian Wienand <[EMAIL PROTECTED]> Explicitly free the IRQ before removing the device to remove a warning "Destroying IRQ without calling free_irq" Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: Ian Wienand <[EMAIL PROTECTED]> --- drivers/net/e100.c |5 - 1 files changed, 4 i

Re: net-2.6.25 splat

2007-12-12 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 16:21:40 -0800 > I don't know why it was doing ipv6 things at all. When you bring up any interface, with explicit IPV6 addresses or not, the IPV6 stack seeks out local routers and whatnot using multicast and assigns the interface a li

net-2.6.25 splat

2007-12-12 Thread Andrew Morton
Pulled the tree a couple of hours ago. The machine was running the full -mm lineup, had been compiling kernels for an hour or so then oopsed in icmpv6_rcv+0x5b/0x832. I have a partial photo of the scrolled-off backtrace but the camera cable is at home. I don't know why it was doing ipv6 things

Re: [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one

2007-12-12 Thread Stephen Hemminger
On Wed, 12 Dec 2007 15:35:49 -0800 "Lachlan Andrew" <[EMAIL PROTECTED]> wrote: > Greetings Dave, > > On 12/12/2007, David Miller <[EMAIL PROTECTED]> wrote: > > From: "Lachlan Andrew" <[EMAIL PROTECTED]> > > Date: Tue, 11 Dec 2007 16:14:36 -0800 > > > > > This thread started because TCP processing

Re: [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one

2007-12-12 Thread David Miller
From: "Lachlan Andrew" <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 15:35:49 -0800 > I thought that a TSC read was fairly cheap. The TSC is cheap, but on the vast majority of systems it isn't usable as a stable time source, and we have to read the ACPI timer instead. -- To unsubscribe from this lis

Re: [RFC PATCH net-2.6.25 uncompilable] [TCP]: Avoid breaking GSOed skbs when SACKed one-by-one

2007-12-12 Thread Lachlan Andrew
Greetings Dave, On 12/12/2007, David Miller <[EMAIL PROTECTED]> wrote: > From: "Lachlan Andrew" <[EMAIL PROTECTED]> > Date: Tue, 11 Dec 2007 16:14:36 -0800 > > > This thread started because TCP processing interferes with RTT > > estimation. This problem would be eliminated if time-stamping were >

Re: [PATCH 0/2] netem: trace enhancement

2007-12-12 Thread Stephen Hemminger
On Mon, 10 Dec 2007 15:32:14 +0100 Ariane Keller <[EMAIL PROTECTED]> wrote: > I finally managed to rewrite the netem trace extension to use rtnetlink > communication for the data transfer for user space to kernel space. > > The kernel patch is available here: > http://www.tcn.hypert.net/tcn_kern

Re: [2.6 patch] drivers/net/sis190.c section fix

2007-12-12 Thread Francois Romieu
Adrian Bunk <[EMAIL PROTECTED]> : > This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: [...] > WARNING: vmlinux.o(.init.text.20+0x4cb25): Section mismatch: reference to > .exit.text:sis190_mii_remove (between 'sis190_init_one' and 'read_eeprom') Thanks. Applied at: git://git.

Re: [PATCH] r6040 various cleanups

2007-12-12 Thread Francois Romieu
Florian Fainelli <[EMAIL PROTECTED]> : [r6040 changes] > - remove unused private structure members > - functions to allocate/free TX and RX buffers > - recover from transmit timeout > - use netdev_alloc_skb instead of dev_alloc_skb > - do not use a private stats structure to store statistics > - br

Re: "ip neigh show" not showing arp cache entries?

2007-12-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 12 Dec 2007 15:57:08 -0600), "Chris Friesen" <[EMAIL PROTECTED]> says: > > You may try other versions of this command > > > > http://devresources.linux-foundation.org/dev/iproute2/download/ > > They appear to be numbered by kernel version, and the above v

[RFT] cpmac: napi fix

2007-12-12 Thread Stephen Hemminger
The NAPI changes for 2.6.24 would break this driver. It doesn't return correct value and has error if exactly "budget" packets are received. Don't have ARM so this is by inspection only. Please test. --- a/drivers/net/cpmac.c 2007-10-26 11:56:12.0 -0700 +++ b/drivers/net/cpmac.c

[RFT] tehuti: napi fix

2007-12-12 Thread Stephen Hemminger
This should fix the tehuti napi fence post problems by getting rid of priv->napi_stop, and setting weight to 32 (like other 10G). Also, used the wierd entry/exit macro's like rest of driver. --- a/drivers/net/tehuti.c 2007-11-13 22:19:14.0 -0800 +++ b/drivers/net/tehuti.c 2007-1

Re: "ip neigh show" not showing arp cache entries?

2007-12-12 Thread Chris Friesen
Eric Dumazet wrote: And what is the version of "ip" command you have on this machine ? ip -V iproute2-ss051107 You may try other versions of this command http://devresources.linux-foundation.org/dev/iproute2/download/ They appear to be numbered by kernel version, and the above version is

Re: [PATCH] XFRM: Display the audited SPI value in host byte order

2007-12-12 Thread Steve Grubb
On Wednesday 12 December 2007 14:05:42 Paul Moore wrote: > This patch corrects this inconsistency by writing the SPI values to the > audit record in host byte order. Looks OK, to me, too. -Steve -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMA

[PATCH] net: remove remaining fastcall occurances in drivers/net

2007-12-12 Thread Harvey Harrison
fastcall is always defined to empty, remove it Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/net/ns83820.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ns83820.c b/drivers/net/ns83820.c index 972acc3..5eed99e 100644 --- a/drivers/net

[PATCH] net: remove fastcall

2007-12-12 Thread Harvey Harrison
fastcall is always empty, remove it from net/ Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- net/bluetooth/rfcomm/core.c |4 ++-- net/core/dev.c |2 +- net/core/sock.c |4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/net/bluetoot

Re: [PATCH 3/4] [NETDEV] ixp2000: rtnl_lock out of loop will be faster

2007-12-12 Thread Lennert Buytenhek
On Wed, Dec 12, 2007 at 04:48:28PM +0800, Wang Chen wrote: > [PATCH 3/4] [NETDEV] ixp2000: rtnl_lock out of loop will be faster > > Before this patch, it gets and releases the lock at each > iteration of the loop. Changing unregister_netdev to > unregister_netdevice and locking outside of the loo

Re: [patch 1/1] Convert the semaphore to a mutex in net/tipc/socket.c

2007-12-12 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 11 Dec 2007 16:44:45 -0800 > So I'd propose this: I've applied this to net-2.6, thanks Andrew. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.

Re: 2.6.24-rc4-mm1

2007-12-12 Thread Cedric Le Goater
Ilpo Järvinen wrote: > On Wed, 5 Dec 2007, Andrew Morton wrote: > >> On Thu, 06 Dec 2007 17:59:37 +1100 Reuben Farrelly <[EMAIL PROTECTED]> wrote: >> >>> This non fatal oops which I have just noticed may be related to this change >>> then >>> - certainly looks networking related. >> yep, but it

Re: [PATCH 8/8][BNX2]: Update version to 1.6.9.

2007-12-12 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 11:00:22 -0800 > [BNX2]: Update version to 1.6.9. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED

Re: [PATCH 6/8][BNX2]: Add fast path code to handle RX pages.

2007-12-12 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 11:00:00 -0800 > [BNX2]: Add fast path code to handle RX pages. > > Add function to reuse a page in case of allocation or other errors. > Add code to construct the completed SKB with the additional data in > the pages. > > Signed-of

Re: [PATCH 7/8][BNX2]: Enable S/G for jumbo RX.

2007-12-12 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 11:00:11 -0800 > [BNX2]: Enable S/G for jumbo RX. > > If the MTU requires more than 1 page for the SKB, enable the page ring > and calculate the size of the page ring. This will guarantee order-0 > allocation regardless of the MTU s

Re: [PATCH 3/8][BNX2]: Restructure RX ring init. code.

2007-12-12 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 10:59:05 -0800 > [BNX2]: Restructure RX ring init. code. > > Factor out the common functions that will be used to initialize the > normal RX rings and the page rings. > > Change the copybreak constant RX_COPY_THRESH to 128. This sa

Re: [PATCH 5/8][BNX2]: Add init. code to handle RX pages.

2007-12-12 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 10:59:39 -0800 > [BNX2]: Add init. code to handle RX pages. > > Add new fields to keep track of the pages and the page rings. > Add functions to allocate and free pages. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied.

Re: [PATCH 2/8][BNX2]: Restructure RX fast path handling.

2007-12-12 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 10:58:43 -0800 > [BNX2]: Restructure RX fast path handling. > > Add a new function to handle new SKB allocation and to prepare the > completed SKB. This makes it easier to add support for non-linear > SKB. > > Signed-off-by: Micha

Re: [PATCH 1/8][BNX2]: Add ring constants.

2007-12-12 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 10:58:22 -0800 > [BNX2]: Add ring constants. > > Define the various ring constants to make the code cleaner. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied to net-2.6.25 -- To unsubscribe from this list: send the line

Re: [PATCH] netfilter : xt_hashlimit should use time_after_eq()

2007-12-12 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 20:06:47 +0100 > Eric Dumazet wrote: > > Hi David & Patrick > > > > I believe this patch is needed for linux-2.6.24 > > > > Thank you > > > > [PATCH] netfilter : xt_hashlimit should use time_after_eq() > > > > In order to avoid j

Re: [PATCH] XFRM: Display the audited SPI value in host byte order

2007-12-12 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 14:05:42 -0500 > Currently the IPsec protocol SPI values are written to the audit log in > network byte order which is different from almost all other values which > are recorded in host byte order. This patch corrects this inconsistency

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2007-12-12 Thread Andy Gospodarek
On Wed, Dec 12, 2007 at 09:46:55AM -0800, Jay Vosburgh wrote: > Herbert Xu <[EMAIL PROTECTED]> wrote: > > >> diff -puN drivers/net/bonding/bond_sysfs.c~bonding-locking-fix > >> drivers/net/bonding/bond_sysfs.c > >> --- a/drivers/net/bonding/bond_sysfs.c~bonding-locking-fix > >> +++ a/drivers/net/

Re: [PATCH] netfilter : xt_hashlimit should use time_after_eq()

2007-12-12 Thread Patrick McHardy
Eric Dumazet wrote: Hi David & Patrick I believe this patch is needed for linux-2.6.24 Thank you [PATCH] netfilter : xt_hashlimit should use time_after_eq() In order to avoid jiffies wraparound and its effect, special care must be taken when doing comparisons ... Looks good, thanks Eric.

[PATCH] XFRM: Display the audited SPI value in host byte order

2007-12-12 Thread Paul Moore
Currently the IPsec protocol SPI values are written to the audit log in network byte order which is different from almost all other values which are recorded in host byte order. This patch corrects this inconsistency by writing the SPI values to the audit record in host byte order. Signed-off-by:

Re: [PATCH][NETDEV]: remove netif_running() check from myri10ge_poll()

2007-12-12 Thread David Miller
From: Andrew Gallatin <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 13:38:34 -0500 > Remove the bogus netif_running() check from myri10ge_poll(). > > This eliminates any chance that myri10ge_poll() can trigger > an oops by calling netif_rx_complete() and returning > with work_done == budget. > > Si

Re: [PATCH] IPIP: Allow rebinding the tunnel to another interface

2007-12-12 Thread David Miller
From: Michal Schmidt <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 17:29:33 +0100 > On Wed, 12 Dec 2007 17:00:14 +0100 > Patrick McHardy <[EMAIL PROTECTED]> wrote: > > > If you change dev->iflink this should trigger a rtnetlink > > notification. > > OK, I've added netdev_state_change(dev). Here's t

Re: [PATCH] Remove unused define from loopback driver

2007-12-12 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 17:44:54 +0300 > The LOOPBACK_OVERHEAD is not used in this file at all. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Applied to net-2.6.25, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: [PATCH 2.6.25] IPv4: thresholds in fib_trie.c are not modified, make them const

2007-12-12 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 14:05:55 +0300 > -static int halve_threshold = 25; > -static int inflate_threshold = 50; > -static int halve_threshold_root = 15; > -static int inflate_threshold_root = 25; halve_threshold_root and inflate_threshold_root have diffe

Re: "ip neigh show" not showing arp cache entries?

2007-12-12 Thread Eric Dumazet
Chris Friesen a écrit : Eric Dumazet wrote: Chris Friesen a écrit : Is this expected behaviour? Probably not... Still a 2.6.14 kernel ? Yep. Embedded hardware, so I'm unable to test with a more recent kernel. And what is the version of "ip" command you have on this machine ? ip -V You

Re: [PATCH 2.6.25] netns: network namespace was passed into dev_getbyhwaddr but not used

2007-12-12 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 14:05:17 +0300 > netns: network namespace was passed into dev_getbyhwaddr but not used > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Applied. Please always put the subsystem name in the headline in all capitals and surrou

Re: [PATCH] Net: Remove FASTCALL macro

2007-12-12 Thread David Miller
From: Harvey Harrison <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 00:09:03 -0800 > X86_32 was the last user of the FASTCALL macro, now that it > uses regparm(3) by default, this macro expands to nothing. > > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> Applied to net-2.6.25, thanks. -- To u

Re: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice

2007-12-12 Thread David Miller
From: Wang Chen <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 10:35:56 +0800 > [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice > > Since the caller and the upper caller doesn't hod the rtnl semaphore. > We should use unregister_netdev instead of unregister_netdevice. > >

Re: [PATCH 3/3] [IPSEC]: Add ICMP host relookup support

2007-12-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 09:58:01 +0800 > [IPSEC]: Add ICMP host relookup support > > RFC 4301 requires us to relookup ICMP traffic that does not match any > policies using the reverse of its payload. This patch implements this > for ICMP traffic that originate

Re: [RFC] net: napi fix

2007-12-12 Thread Kok, Auke
David Miller wrote: > From: Andrew Gallatin <[EMAIL PROTECTED]> > Date: Wed, 12 Dec 2007 12:29:23 -0500 > >> Is the netif_running() check even required? > > No, it is not. > > When a device is brought down, one of the first things > that happens is that we wait for all pending NAPI polls > to co

Re: [PATCH 2/3] [IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse

2007-12-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 09:58:00 +0800 > [IPSEC]: Added xfrm_decode_session_reverse and xfrmX_policy_check_reverse > > RFC 4301 requires us to relookup ICMP traffic that does not match any > policies using the reverse of its payload. This patch adds the functi

Re: [PATCH 1/3] [IPSEC]: Make xfrm_lookup flags argument a bit-field

2007-12-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 09:57:59 +0800 > [IPSEC]: Make xfrm_lookup flags argument a bit-field > > This patch introduces an enum for bits in the flags argument of xfrm_lookup. > This is so that we can cram more information into it later. > > Since all current u

Re: [RFC] mac80211: clean up frame receive handling

2007-12-12 Thread drago01
On Dec 12, 2007 7:24 PM, Johannes Berg <[EMAIL PROTECTED]> wrote: > [comments welcome. I really need a refresher on what the frame formats > mean but I think I did the right thing with skb->protocol here, I also > think we had a bug with rfc2042 header frames bigger than 15xx bytes and > eth_type_t

[PATCH] netfilter : xt_hashlimit should use time_after_eq()

2007-12-12 Thread Eric Dumazet
Hi David & Patrick I believe this patch is needed for linux-2.6.24 Thank you [PATCH] netfilter : xt_hashlimit should use time_after_eq() In order to avoid jiffies wraparound and its effect, special care must be taken when doing comparisons ... Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]>

[PATCH][NETDEV]: remove netif_running() check from myri10ge_poll()

2007-12-12 Thread Andrew Gallatin
Remove the bogus netif_running() check from myri10ge_poll(). This eliminates any chance that myri10ge_poll() can trigger an oops by calling netif_rx_complete() and returning with work_done == budget. Signed-off-by: Andrew Gallatin <[EMAIL PROTECTED]> diff --git a/drivers/net/myri10ge/myri10ge.c

[RFC] mac80211: clean up frame receive handling

2007-12-12 Thread Johannes Berg
[comments welcome. I really need a refresher on what the frame formats mean but I think I did the right thing with skb->protocol here, I also think we had a bug with rfc2042 header frames bigger than 15xx bytes and eth_type_trans()] This cleans up the frame receive handling. After this patch * EA

Re: "ip neigh show" not showing arp cache entries?

2007-12-12 Thread Chris Friesen
Eric Dumazet wrote: Chris Friesen a écrit : Is this expected behaviour? Probably not... Still a 2.6.14 kernel ? Yep. Embedded hardware, so I'm unable to test with a more recent kernel. Could you send the result of : strace ip neigh show I've attached two strace runs, one of "ip neigh s

[PATCH 1/8][BNX2]: Add ring constants.

2007-12-12 Thread Michael Chan
[BNX2]: Add ring constants. Define the various ring constants to make the code cleaner. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 4e7b46e..dfe50c2 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -468,8 +468,7 @@ bnx2_fr

[PATCH 6/8][BNX2]: Add fast path code to handle RX pages.

2007-12-12 Thread Michael Chan
[BNX2]: Add fast path code to handle RX pages. Add function to reuse a page in case of allocation or other errors. Add code to construct the completed SKB with the additional data in the pages. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c i

[PATCH 7/8][BNX2]: Enable S/G for jumbo RX.

2007-12-12 Thread Michael Chan
[BNX2]: Enable S/G for jumbo RX. If the MTU requires more than 1 page for the SKB, enable the page ring and calculate the size of the page ring. This will guarantee order-0 allocation regardless of the MTU size. Fixup loopback test packet size so that we don't deal with the pages during loopback

[PATCH 8/8][BNX2]: Update version to 1.6.9.

2007-12-12 Thread Michael Chan
[BNX2]: Update version to 1.6.9. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index ae081c8..469d259 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -56,8 +56,8 @@ #define DRV_MODULE_NAME"bnx2" #define PFX DRV

[PATCH 5/8][BNX2]: Add init. code to handle RX pages.

2007-12-12 Thread Michael Chan
[BNX2]: Add init. code to handle RX pages. Add new fields to keep track of the pages and the page rings. Add functions to allocate and free pages. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index db3b750..38e8e31 100644 --- a/drivers/net/

Re: [kvm-devel] [PATCH resent] virtio_net: Fix stalled inbound trafficon early packets

2007-12-12 Thread Christian Borntraeger
Am Mittwoch, 12. Dezember 2007 schrieb Dor Laor: > I think the change below handles the race. Otherwise please detail the > use case. [...] > > @@ -292,6 +292,9 @@ static int virtnet_open(struct net_devic > > return -ENOMEM; > > > > napi_enable(&vi->napi); > > + > > +

[PATCH 3/8][BNX2]: Restructure RX ring init. code.

2007-12-12 Thread Michael Chan
[BNX2]: Restructure RX ring init. code. Factor out the common functions that will be used to initialize the normal RX rings and the page rings. Change the copybreak constant RX_COPY_THRESH to 128. This same constant will be used for the max. size of the linear SKB when pages are used. Copybreak

[PATCH 2/8][BNX2]: Restructure RX fast path handling.

2007-12-12 Thread Michael Chan
[BNX2]: Restructure RX fast path handling. Add a new function to handle new SKB allocation and to prepare the completed SKB. This makes it easier to add support for non-linear SKB. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index dfe50c

[PATCH 0/8][BNX2]: Add S/G jumbo RX support.

2007-12-12 Thread Michael Chan
[BNX2]: Add S/G jumbo RX support. David, 8 patches will follow to implement S/G for jumbo RX packets. Please review for 2.6.25. Thanks. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> --- drivers/net/bnx2.c | 510 +++- drivers/net/bnx2.h | 43 +- drivers/net/bnx2_fw.h | 7034 +++

Re: 2.6.24-rc4-mm1

2007-12-12 Thread Cedric Le Goater
Ilpo Järvinen wrote: > On Wed, 5 Dec 2007, David Miller wrote: > >> From: Reuben Farrelly <[EMAIL PROTECTED]> >> Date: Thu, 06 Dec 2007 17:59:37 +1100 >> >>> On 5/12/2007 4:17 PM, Andrew Morton wrote: - Lots of device IDs have been removed from the e1000 driver and moved over to e1000e

Re: [RFC] net: napi fix

2007-12-12 Thread Andrew Gallatin
David Miller wrote: From: Andrew Gallatin <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 12:29:23 -0500 Is the netif_running() check even required? No, it is not. When a device is brought down, one of the first things that happens is that we wait for all pending NAPI polls to complete, then bloc

Re: [Bugme-new] [Bug 9543] New: RTNL: assertion failed at net/ipv6/addrconf.c (2164)/RTNL: assertion failed at net/ipv4/devinet.c (1055)

2007-12-12 Thread Jay Vosburgh
Herbert Xu <[EMAIL PROTECTED]> wrote: >> diff -puN drivers/net/bonding/bond_sysfs.c~bonding-locking-fix >> drivers/net/bonding/bond_sysfs.c >> --- a/drivers/net/bonding/bond_sysfs.c~bonding-locking-fix >> +++ a/drivers/net/bonding/bond_sysfs.c >> @@ -,8 +,6 @@ static ssize_t bonding_store

Re: [RFC] net: napi fix

2007-12-12 Thread David Miller
From: Andrew Gallatin <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 12:29:23 -0500 > Is the netif_running() check even required? No, it is not. When a device is brought down, one of the first things that happens is that we wait for all pending NAPI polls to complete, then block any new polls from s

[PATCH 8/8] gianfar: Magic Packet and suspend/resume support.

2007-12-12 Thread Scott Wood
Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- Jeff, can you ack this to go through Paul's tree (assuming nothing wrong with it)? drivers/net/gianfar.c | 137 - drivers/net/gianfar.h | 13 +++- drivers/net/gianfar_ethtool.c | 41

Re: [RFC] net: napi fix

2007-12-12 Thread Andrew Gallatin
[I apologize for loosing threading, I'm replying from the archives] > The problem is that the driver is doing a NAPI completion and > re-enabling chip interrupts with work_done == weight, and that is > illegal. The only time at least myri10ge will do this is due to the !netif_running(netdev) che

Re: RFC: igb: Intel 82575 gigabit ethernet driver (take #2)

2007-12-12 Thread Kok, Auke
Kok, Auke wrote: > All, > > here is the second version of the igb (82575) ethernet controller driver. This > driver was previously posted 2007-07-13. Many comments received were > addressed: > > - removed indirection wrappers in the same way as e1000e and ixgbe. > - cleaned up largely against sp

Re: [PATCH 8/8] [PATCH v2] [CCID3]: Interface CCID3 code with newer Loss Intervals Database

2007-12-12 Thread Gerrit Renker
| > +static struct kmem_cache *tfrc_lh_slab __read_mostly;/* <=== */ | | Yup, this one, is introduced as above but is not initialized at the | module init routine, please see, it should be OK and we can move on: | | http://git.kernel.org/?p=linux/kernel/git/acme/net-2.6.25.git;a=commitdiff

Re: [PATCH 8/8] [PATCH v2] [CCID3]: Interface CCID3 code with newer Loss Intervals Database

2007-12-12 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 12, 2007 at 04:56:32PM +, Gerrit Renker escreveu: > | This time around I'm not doing any reordering, just trying to use your > | patches as is, but adding this patch as-is produces a kernel that will > | crash, no? > | > | > The loss history and the RX/TX packet history slabs are a

Re: [RFC] ehea: kdump support using new shutdown hook

2007-12-12 Thread Dave Jones
On Wed, Dec 12, 2007 at 05:53:43PM +0100, Thomas Klein wrote: > +static void ehea_update_adapter_handles(struct ehea_adapter *adapter) > +{ > +int i, k; > +int j = 0; > + > +memset(adapter->res_handles, sizeof(adapter->res_handles), 0); arguments wrong way around. Dave

Re: [PATCHES 0/7]: DCCP patches for 2.6.25

2007-12-12 Thread David Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Wed, 12 Dec 2007 14:36:46 -0200 > Please consider pulling from: > > master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25 Pulled and pushed out to net-2.6.25, thanks! -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 8/8] [PATCH v2] [CCID3]: Interface CCID3 code with newer Loss Intervals Database

2007-12-12 Thread Gerrit Renker
| This time around I'm not doing any reordering, just trying to use your | patches as is, but adding this patch as-is produces a kernel that will | crash, no? | | > The loss history and the RX/TX packet history slabs are all created in | > tfrc.c using the three different __init routines of the dc

[RFC] ehea: kdump support using new shutdown hook

2007-12-12 Thread Thomas Klein
This patch adds kdump support using the new PPC crash shutdown hook to the ehea driver. The driver now keeps a list of firmware handles which have to be freed in case of a crash. The crash handler does the minimum required: it frees the firmware resource handles plus broadcast/multicast registratio

Re: "ip neigh show" not showing arp cache entries?

2007-12-12 Thread Eric Dumazet
Chris Friesen a écrit : I retested it on an x86 machine and am seeing similar problems. First, "arp" gives the arp table as expected: [EMAIL PROTECTED]:/tftpboot/cnp/0-0-5-0/0-0-5-0> arp -n Address HWtype HWaddress Flags MaskIface 172.24.0.9 ether

Re: [PATCH] iproute2: support dotted-quad netmask notation.

2007-12-12 Thread Stephen Hemminger
On Wed, 12 Dec 2007 12:55:13 +0100 Andreas Henriksson <[EMAIL PROTECTED]> wrote: > On Tue, Dec 11, 2007 at 05:14:06PM -0800, Stephen Hemminger wrote: > > On Sun, 09 Dec 2007 18:10:22 +0100 > > Andreas Henriksson <[EMAIL PROTECTED]> wrote: > > > I think both previous patches where broken on big-end

[PATCH/RFC] [POWERPC] Add fixed-phy support for fs_enet

2007-12-12 Thread Jochen Friedrich
This patch adds support to use the fixed-link property of an ethernet node to fs_enet for the CONFIG_PPC_CPM_NEW_BINDING case. Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git

Re: [PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of net_rx_action

2007-12-12 Thread Stephen Hemminger
On Wed, 12 Dec 2007 07:20:34 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Tue, 11 Dec 2007 21:39:39 -0800 > > > On Wed, 12 Dec 2007 13:01:27 +0900 > > "Joonwoo Park" <[EMAIL PROTECTED]> wrote: > > > > > [NETDEV]: tehuti Fix possible ca

[PATCH 3/7] [TFRC]: Ringbuffer to track loss interval history

2007-12-12 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> A ringbuffer-based implementation of loss interval history is easier to maintain, allocate, and update. The `swap' routine to keep the RX history sorted is due to and was written by Arnaldo Carvalho de Melo, simplifying an earlier macro-based variant. Deta

[PATCH 7/7] [TFRC]: Remove previous loss intervals implementation

2007-12-12 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]> Signed-off-by: Ian McDonald <[EMAIL PROTECTED]> Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> --- net/dccp/ccids/lib/loss_interval.c | 266 net/dccp/ccids/l

[PATCH 6/7] [CCID3]: Interface CCID3 code with newer Loss Intervals Database

2007-12-12 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> This hooks up the TFRC Loss Interval database with CCID 3 packet reception. In addition, it makes the CCID-specific computation of the first loss interval (which requires access to all the guts of CCID3) local to ccid3.c. The patch also fixes an omission in

[PATCHES 0/7]: DCCP patches for 2.6.25

2007-12-12 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25 Best Regards, - Arnaldo b/net/dccp/ccids/ccid3.c |2 b/net/dccp/ccids/ccid3.h |5 b/net/dccp/ccids/lib/loss_interval.c | 161 ++- b

  1   2   >