2007/12/13, David Miller <[EMAIL PROTECTED]>: > From: "Joonwoo Park" <[EMAIL PROTECTED]> > Date: Wed, 12 Dec 2007 13:01:27 +0900 > > > Any time your trying to make a caller "happy" by adjusting > a return value forcefully, it's a hack. > > And I stated this in another reply about this issue. > > Please do not fix the problem this way. > > The correct way to fix this is, if we did process a full > "weight" or work, we should not netif_rx_complete() and > we should not re-enable chip interrupts. > > Instead we should return the true "work_done" value and > allow the caller to thus poll us one more time. >
Thanks so much for your advice. I agree, returning work_done itself exactly. I will rework for these drivers. Thanks. Joonwoo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
