* Andrew Morton wrote:
> On Mon, 3 Dec 2007 09:35:11 +0100 Thierry Reding <[EMAIL PROTECTED]> wrote:
>
> > In cases where more than a single PHY is found on the MDIO bus, the kernel
> > will print a warning that this method is missing for each PHY device that
> > is not attached to a networking de
NAK. You have changed the control flow of the algorithm and the underlying
data structure. Originally it had been an array of pointers, and this had
been a design decision right from the first submissions in March. From I
of
http://www.erg.abdn.ac.uk/users/gerrit/dccp/notes/ccid3_packet_reception/
From: Kazunori MIYAZAWA <[EMAIL PROTECTED]>
Date: Tue, 04 Dec 2007 15:23:01 +0900
> Herbert Xu wrote:
> > I'd prefer to put this in XFRM_SPI_SKB_CB instead because the xfrm
> > layer shouldn't really rely on dst->ops structures except on entry
> > and exit, like this:
> >
> > [IPSEC]: Use the cor
Herbert Xu wrote:
On Tue, Dec 04, 2007 at 02:28:36PM +0900, Kazunori MIYAZAWA wrote:
Hi Herbert,
This is the patch to fix IPv6 IPsec input.
Signed-off-by: Kazunori MIYAZAWA <[EMAIL PROTECTED]>
Good catch! Thanks.
diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
index 96f42c1..da
On Tue, Dec 04, 2007 at 12:39:43PM +0900, Kazunori MIYAZAWA wrote:
>
> I found that you directly pass the address family (AF_INET) to
> xfrm_state_lookup
> in xfrm_input.
>
> I guess it may result the bug.
>
> Is it correct?
Yes sorry, I didn't test IPv6. Ironic because all this work is for
th
On Tue, Dec 04, 2007 at 02:28:36PM +0900, Kazunori MIYAZAWA wrote:
> Hi Herbert,
>
> This is the patch to fix IPv6 IPsec input.
>
> Signed-off-by: Kazunori MIYAZAWA <[EMAIL PROTECTED]>
Good catch! Thanks.
> diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
> index 96f42c1..da3c963 100
On Mon, 3 Dec 2007 09:35:11 +0100 Thierry Reding <[EMAIL PROTECTED]> wrote:
> In cases where more than a single PHY is found on the MDIO bus, the kernel
> will print a warning that this method is missing for each PHY device that
> is not attached to a networking device.
>
> Signed-off-by: Thierry
Hi Herbert,
This is the patch to fix IPv6 IPsec input.
Signed-off-by: Kazunori MIYAZAWA <[EMAIL PROTECTED]>
---
net/xfrm/xfrm_input.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
index 96f42c1..da3c963 100644
--- a/net/x
On Tue, Dec 04, 2007 at 11:50:55AM +0800, Wang Chen wrote:
>
> > #include
> > #include
> > +#include
>
> It's no need to include smp.h?
We need it for smp_processor_id. Well we needed it before too but
there's probably some implicit inclusion which has made it work.
It's better to declare t
Herbert Xu said the following on 2007-12-3 21:17:
> On Mon, Dec 03, 2007 at 10:54:35PM +1100, Herbert Xu wrote:
> diff --git a/include/net/snmp.h b/include/net/snmp.h
> index ea206bf..9444b54 100644
> --- a/include/net/snmp.h
> +++ b/include/net/snmp.h
> @@ -23,6 +23,7 @@
>
> #include
> #inclu
Hello Herbert,
We have a trouble of IPv6 IPsec input process with your net-2.6.25 tree.
We can not receive IPsec packets.
I found that you directly pass the address family (AF_INET) to xfrm_state_lookup
in xfrm_input.
I guess it may result the bug.
Is it correct?
Best regards,
--
Kazunori Miy
Turns out we're freeing the skb when we detect CRC error, but we're
not clearing out info->skb. We could either clear it and have the stack
reallocate it, or just leave it and the rx ring refill code will reuse
the one that was allocated.
Reusing a freed skb obviously caused some nasty crashes of
Peter Korsgaard said the following on 2007-12-3 21:47:
>> "Wang" == Wang Chen <[EMAIL PROTECTED]> writes:
>
> Hi,
>
> Wang> + len = skb->len;
> Wang>netif_rx(skb);
> dev-> stats.rx_packets++;
> Wang> - dev->stats.rx_bytes += skb->len;
> Wang> + dev->stats.rx_bytes
ID AssigneeSummary
2283[EMAIL PROTECTED] (net forcedeth) NETDEV WATCHDOG: eth1: transmit
timed out...
2776[EMAIL PROTECTED] (net dmfe) Davicom 9102AF only works in 10 Mbps
3156[EMAIL PROTECTED] (net de2104x) Kernel panic with de2104x t
Some of these are old and maybe already fixed?
ID Owner Description
2803[EMAIL PROTECTED] isa modem detected but does not initialize
4206[EMAIL PROTECTED] NAT/Masquerade not working
4595[EMAIL PROTECTED] Error inserting ebt_ulog
4809[EMAI
On Mon, Dec 03, 2007 at 01:10:57PM +0300, Pavel Emelyanov wrote:
> The register_ip_vs_scheduler() checks for the scheduler with the
> same name under the read-locked __ip_vs_sched_lock, then drops,
> takes it for writing and puts the scheduler in list.
>
> This is racy, since we can have a race wi
On Mon, Dec 03, 2007 at 01:04:53PM +0300, Pavel Emelyanov wrote:
> In case we load lblc or lblcr module we can leak some sysctl
> tables if the call to register_ip_vs_scheduler() fails.
This looks correct to me.
> I've looked at the register_ip_vs_scheduler() code and saw, that
> the only reason
Greetings,
On 03/12/2007, Stephen Hemminger <[EMAIL PROTECTED]> wrote:
> On Mon, 3 Dec 2007 15:59:23 -0800
> "Shao Liu" <[EMAIL PROTECTED]> wrote:
> > And also a question, why the samples when SACK is active are outliers?
>
> Any sample with SACK is going to mean a loss or reordering has occurred.
Prevent deadlock in sky2 recovery logic. sky2_down calls napi_synchronize
which gets stuck if napi was already disabled.
Fix by rearranging slightly and not calling napi_disable until after
both ports are stopped. The napi_disable probably is being overly
paranoid, but it is safe now.
Signed-off
On Mon, 3 Dec 2007 15:59:23 -0800
"Shao Liu" <[EMAIL PROTECTED]> wrote:
> Hi Stephen and Lachlan,
>
> Thanks for the discussion. The gradual aging is surely an option. And
> another possibility is that, we compute the RTT just before congestion
> notification, which ideally, represent the full qu
On Mon, Dec 03, 2007 at 07:14:26PM -0500, Hideo AOKI wrote:
>
> Let me try to use sk_forward_alloc at first, while percpu storage
> is an interesting idea.
Actually I don't think sk_forward_alloc would work for UDP because
it runs lockless (unlike TCP which is run under a the socket lock).
So it'
Eric Dumazet wrote:
> Herbert Xu a écrit :
>> However, I'm still a little concerned about the effect of two more
>> atomic op's per packet that we're adding here. Hang on a sec, that
>> should've been Dave's line since atomic ops are cheap on x86 :)
>>
>> But seriously, it's not so much that we ha
Herbert Xu wrote:
> On Wed, Nov 28, 2007 at 01:52:59PM -0500, Hideo AOKI wrote:
>> +static inline int sk_wmem_schedule(struct sock *sk, int size)
>> +{
>> +if (sk->sk_type == SOCK_STREAM)
>> +return sk_stream_wmem_schedule(sk, size);
>> +else if (sk->sk_type == SOCK_DGRAM)
>> +
Hi Stephen and Lachlan,
Thanks for the discussion. The gradual aging is surely an option. And
another possibility is that, we compute the RTT just before congestion
notification, which ideally, represent the full queueing delay + propagation
delay. We can compute the average of the last M such val
Begin forwarded message:
Date: Mon, 3 Dec 2007 11:23:27 -0800 (PST)
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Subject: [Bug 9493] New: routing table bug or feature adding/replacing/deleting
routes
http://bugzilla.kernel.org/show_bug.cgi?id=9493
Summary: routing table bug or f
Greetings Stephen,
Thanks. We'll have to play with the rate of ageing. I used the slower ageing
if (ca->cnt_rtt > 3) {
u64 mean_rtt = ca->sum_rtt;
do_div (mean_rtt, ca->cnt_rtt);
if (ca->max_rtt > mean_rtt)
ca->max
On Wed, 28 Nov 2007 21:26:12 -0800
"Shao Liu" <[EMAIL PROTECTED]> wrote:
> Hi Stephen and Lachlan,
>
> Thanks for pointing out and fixing this bug.
>
> For the max RTT problem, I have considered it also and I have some idea on
> improve it. I also have some other places to improve. I will summar
On 12/3/07, David Woodhouse <[EMAIL PROTECTED]> wrote:
> From: Jon Smirl <[EMAIL PROTECTED]>
>
> The mpc5200 fec driver is corrupting memory. This patch fixes two bugs
> where the wrong skb was being referenced.
What does it take to get this patch into the kernel? I've been posting
it since Nov 9.
From: Jon Smirl <[EMAIL PROTECTED]>
The mpc5200 fec driver is corrupting memory. This patch fixes two bugs
where the wrong skb was being referenced.
Signed-off-by: Jon Smirl <[EMAIL PROTECTED]>
Acked-by: Domen Puncer <[EMAIL PROTECTED]>
Signed-off-by: Grant Likely <[EMAIL PROTECTED]>
Signed-off-b
On Thu, Nov 22, 2007 at 12:27:47PM +0800, Herbert Xu wrote:
> On Tue, Nov 20, 2007 at 08:29:21PM -0800, David Miller wrote:
> >
> > During this time Herbert Xu (CC:'d) will take care of both the net-2.6
> > stable tree and the net-2.6.25 devel tree.
>
> For this duration please use the net-2.6.25
Add function qe_clock_source() which takes a string containing the name of a
QE clock source (as is typically found in device trees) and returns the
matching enum qe_clock value.
Update booting-without-of.txt to indicate that the UCC properties rx-clock
and tx-clock are deprecated and replaced wit
Updates the ucc_geth device driver to check the new rx-clock-name and
tx-clock-name properties first. If present, it uses the new function
qe_clock_source() to obtain the clock source. Otherwise, it checks the
deprecated rx-clock and tx-clock properties.
Update the device trees for 832x, 836x, a
This patch set adds a new property to make specifying QE clock sources
easier, adds a function to help parse the property, and updates the ucc_geth
driver to take advantage of all this.
Patch #1 is an arch/powerpc patch meant for Kumar's for-2.6.25 branch.
Patch #2 is a netdev patch, so it's eith
Ben Greear wrote:
Eric W. Biederman wrote:
Patrick McHardy <[EMAIL PROTECTED]> writes:
Ben Greear wrote:
I have a binary module that uses dev_get_by_name...it's sort of a
bridge-like
thing and
needs user-space to tell it which device to listen for packets on...
This code doesn't need
Patrick McHardy wrote:
That sounds like it would also be possible using rtnetlink. You could
send out a notification whenever you switch the active buffer and have
userspace listen to these and replace the inactive one.
Also, I think you will need a larger cache than 4-8k if you are running
h
Eric W. Biederman wrote:
Patrick McHardy <[EMAIL PROTECTED]> writes:
Ben Greear wrote:
I have a binary module that uses dev_get_by_name...it's sort of a bridge-like
thing and
needs user-space to tell it which device to listen for packets on...
This code doesn't need or care about name
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Mon, 03 Dec 2007 11:03:38 -0700
> Based on my experience with in-tree code and the few glimpses I
> have gotten of out of tree code the reason the out of tree code broke
> is because it is doing very questionable things.
Calling dev_get_by_foo() w
Romano Giannetti <[EMAIL PROTECTED]> writes:
> Please pardon me for jumping in; I am not a kernel developer, but I try
> to help with debugging whenever I can (and it's not just hand-waving, I
> helped to track down a couple of nasty bugs on MMC or ACPI EC,
> recently). And I am an engineer and IA
Patrick McHardy <[EMAIL PROTECTED]> writes:
> Ben Greear wrote:
>> I have a binary module that uses dev_get_by_name...it's sort of a bridge-like
>> thing and
>> needs user-space to tell it which device to listen for packets on...
>>
>> This code doesn't need or care about name-spaces, so I don't s
Ariane Keller wrote:
Patrick McHardy wrote:
I dislike using anything besides rtnetlink for qdisc configuration.
The only way to transfer arbitary amounts of data over netlink would
be to spread the data over multiple messages. But then again, you're
using kmalloc and only seem to allocate 4k, s
Looks good to me.
Acked-by: "Eric W. Biederman" <[EMAIL PROTECTED]>
Eric
"Denis V. Lunev" <[EMAIL PROTECTED]> writes:
> you right, how about this?
>
> Eric W. Biederman wrote:
>> "Denis V. Lunev" <[EMAIL PROTECTED]> writes:
>>
>>> This patch removes some unneeded includes for net_namespace.h
Am Montag, 3. Dezember 2007 14:34 schrieb Ilpo Järvinen:
> On Mon, 3 Dec 2007, Wolfgang Walter wrote:
> > with kernel 2.6.23.8 we saw a
> >
> > KERNEL: assertion ((int)tcp_packets_in_flight(tp) >= 0) failed at
> > net/ipv4/tcp_input.c (1292)
>
> Is this the only message? Are there any Leak printout
| > | > static inline void ccid3_hc_rx_update_s(struct ccid3_hc_rx_sock
*hcrx, int len)
| > | > {
| > | > if (likely(len > 0))/* don't update on empty
packets (e.g. ACKs) */
| > | > hcrx->ccid3hcrx_s =
tfrc_ewma(hcrx->ccid3hcrx_s, len,
On Mon, 03 Dec 2007 09:24:15 +0100
Romano Giannetti <[EMAIL PROTECTED]> wrote:
>
>
> On Sat, 2007-12-01 at 22:34 -0500, Mark Lord wrote:
> > Stephen Hemminger wrote:.
> > >>
> > > I spoke too soon earlier, ndiswrapper builds and loads against
> > > current 2.6.24-rc3. Vmware and proprietary VPN
Lukas Hejtmanek wrote:
> On Tue, Nov 27, 2007 at 10:23:00AM -0800, Kok, Auke wrote:
>> can you see if your problem goes away with this patch?
>
> I cannot test it right now but friend of mine has the same card with 2.6.23.1
> kernel. it does not. he also tried module 7.6.12 from source fourge, you
Em Mon, Dec 03, 2007 at 01:49:47PM +, Gerrit Renker escreveu:
> | > Are you suggesting using netdev exclusively or in addition to [EMAIL
> PROTECTED]
> |
> | Well, since at least one person that has contributed significantly in
> | the past has said he can't cope with traffic on netdev, we ca
AFAIS the net.ipv4.conf. , all and default sysctls should
work like this when changed (besides changing the value itself):
: optionally do smth else
all : walk devices
default : walk devices
The proc handler for net.ipv4.conf.all works like this:
: flush rt cache
all : walk device
AFAIS these two entries should do the same thing - change the
forwarding state on ipv4_devconf and on all the devices.
I propose to merge the handlers together using ctl paths.
The inet_forward_change() is static after this and I move
it higher to make code organized like
rather than mixing it
| > Are you suggesting using netdev exclusively or in addition to [EMAIL
PROTECTED]
|
| Well, since at least one person that has contributed significantly in
| the past has said he can't cope with traffic on netdev, we can CC
| [EMAIL PROTECTED]
I have a similar problem with the traffic but agree
> "Wang" == Wang Chen <[EMAIL PROTECTED]> writes:
Hi,
Wang> +len = skb->len;
Wang> netif_rx(skb);
dev-> stats.rx_packets++;
Wang> -dev->stats.rx_bytes += skb->len;
Wang> +dev->stats.rx_bytes += len;
Why not simply update the stats before calling netif_rx
On Mon, 3 Dec 2007, Wolfgang Walter wrote:
> with kernel 2.6.23.8 we saw a
>
> KERNEL: assertion ((int)tcp_packets_in_flight(tp) >= 0) failed at
> net/ipv4/tcp_input.c (1292)
Is this the only message? Are there any Leak printouts?
Any tweaking done to TCP related sysctls?
And for completeness,
On 03-12-2007 12:40, Laszlo Attila Toth wrote:
> Jarek Poplawski írta:
>> Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
>>
>>> In do_setlink() a single ntification is sent at the end of the function
>>> if any modification occured. If the address has been changed, another
>>> notification is se
On Mon, Dec 03, 2007 at 10:54:35PM +1100, Herbert Xu wrote:
>
> Hmm, wasn't someone else talking about a non-atomic version of atomic
> ops lately (i.e., atomic with respect to the local CPU only)? Perhaps
> this is the killer app for it :)
Never mind, we already have that in local_t and as Alexey
Hello.
Patrick McHardy wrote:
> No news on that. I'm also a bit sceptical if adding all this complexity
> and overhead would really be worth it (considering only netfilter) just
> to use the owner match and UID/GID matching. It wouldn't even be
> accurate because there is not 1:1 mapping of socket
Em Mon, Dec 03, 2007 at 08:35:12AM +, Gerrit Renker escreveu:
> Hi Arnaldo,
>
> hank you for going through this. I have just backported your recent patches
> of 2.6.25
> to the DCCP/CCID4/Faster Restart test tree at
> git://eden-feed.erg.abdn.ac.uk/dccp_exp {dccp,ccid4,dccp_fr}
> as pe
On Mon, 2007-03-12 at 20:21 +1100, Herbert Xu wrote:
> Sorry for the late response Jamal. I've been too busy to give
> this issue proper thought. It's still in my mailbox so I will
> respond to it once things quiten down a little.
I totaly empathize - take your time.
The point brought up on v6
you right, how about this?
Eric W. Biederman wrote:
> "Denis V. Lunev" <[EMAIL PROTECTED]> writes:
>
>> This patch removes some unneeded includes for net_namespace.h to speed up
>> compilation.
>>
>> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
>>
>> diff --git a/include/net/pkt_cls.h b/incl
Jarek Poplawski írta:
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
The do_setlink function is protected by rtnl, additional locks are unnecessary,
and the set_operstate() function is called from protected parts. Locks removed
from both functions.
It doesn't look like in accordance with a
"Denis V. Lunev" <[EMAIL PROTECTED]> writes:
> This patch removes some unneeded includes for net_namespace.h to speed up
> compilation.
>
> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
>
> diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
> index f285de6..28b7f25 100644
> --- a/inclu
On Mon, Dec 03, 2007 at 02:49:12PM +0300, Alexey Kuznetsov wrote:
> On Mon, Dec 03, 2007 at 10:39:35PM +1100, Herbert Xu wrote:
> > So we need to fix this, and whatever the fix is will probably render
> > the BH/USER distinction obsolete.
>
> Hmm, I would think opposite. USER (or generic) is expen
On Mon, Dec 03, 2007 at 10:39:35PM +1100, Herbert Xu wrote:
> So we need to fix this, and whatever the fix is will probably render
> the BH/USER distinction obsolete.
Hmm, I would think opposite. USER (or generic) is expensive variant,
BH is lite. No?
Alexey
--
To unsubscribe from this list: send
Jarek Poplawski írta:
Laszlo Attila Toth wrote, On 11/29/2007 05:11 PM:
In do_setlink() a single ntification is sent at the end of the function
if any modification occured. If the address has been changed, another
notification is sent.
...
@@ -858,6 +859,7 @@ static int do_setlink(struct n
On Mon, Dec 03, 2007 at 03:19:35PM +0800, Wang Chen wrote:
>
> System calls should be USER. So change the BH to USER for
> UDP*_INC_STATS_BH().
>
> Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
I've rearragned it so that we the new INC_STATS call is USER in the
first patch. Otherwise it's all in
A ringbuffer-based implementation of loss interval history is easier to
maintain, allocate, and update.
Details:
* access to the Loss Interval Records via macro wrappers (with safety checks);
* simplified, on-demand allocation of entries (no extra memory consumption on
lossless links); cache
In addition, it makes two corrections too the code:
1. The receiver of a half-connection does not set window counter values;
only the sender sets window counters [RFC 4342, sections 5 and 8.1].
2. The computation of X_recv does currently not conform to TFRC/RFC 3448,
since this specifica
This provides a new, self-contained and generic RX history service for TFRC
based protocols.
Details:
* new data structure, initialisation and cleanup routines;
* allocation of dccp_rx_hist entries local to packet_history.c,
as a service exported by the dccp_tfrc_lib module.
* interface to a
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
---
net/dccp/ccids/lib/loss_interval.c |9 ++
net/dccp/ccids/lib/packet_history.c | 162 ---
net/dccp/ccids/lib/packet_history.h | 84 --
3 files
This patch changes the tfrc_lib module in the following manner:
(1) a dedicated tfrc_module source file (this is later populated
with TX/RX hist and LI Database routines);
(2) a dedicated tfrc_pr_debug macro with toggle switch `tfrc_debug'.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
This hooks up the TFRC Loss Interval database with CCID 3 packet reception.
In addition, it makes the CCID-specific computation of the first loss
interval (which requires access to all the guts of CCID3) local to ccid3.c.
The patch also fixes an omission in the DCCP code, that of a default /
fallb
I am re-submitting the original patch set which Arnaldo referred to, due to:
1/ It has been reworked to patch/compile against the 2.6.25 tree, which lead
to a few changes (not conceptual in nature).
2/ Patch #7 in Arnaldo's set says that this patch set introduced some bugs.
Please
This makes the ipv6.ko smaller and creates the ground needed
for net namespaces support in ipv6.ko ssctls.
Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
---
diff --git a/net/ipv6/sysctl_net_ipv6.c b/net/ipv6/sysctl_net_ipv6.c
index 227efa7..0b5bec3 100644
--- a/net/ipv6/sysctl_net_ipv6.c
++
Since this file is enclosed with the #ifdef CONFIG_SYSCTL/#endif
pair, it's OK to move this CONFIG_ into a Makefile.
Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
---
diff --git a/net/ipv6/Makefile b/net/ipv6/Makefile
index 5ffa980..24f3aa0 100644
--- a/net/ipv6/Makefile
+++ b/net/ipv6/Make
On Sun, Dec 02, 2007 at 06:45:44PM +0200, Ilpo Järvinen wrote:
> Should get the skb from the same queue. I had it first elsewhere
> and missed this change while moving.
>
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
Applied to net-2.6.25. Thanks Ilpo!
--
Visit Openswan at http://www.opens
Hi Matt.
On Sun, Dec 02, 2007 at 10:50:59PM -0600, Matt Mackall ([EMAIL PROTECTED])
wrote:
> > Distributed storage documentation.
> >
> > Algorithms used in the system, userspace interfaces
> > (sysfs dirs and files), design and implementation details
> > are described here.
>
> Can you give us
While testing the mcs7780 based IrDA USB dongle I've stumbled upon
memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in
irlmp_register_link and should probably be freed in irlmp_unregister_link().
Signed-off-by: Hinko Kocevar <[EMAIL PROTECTED]>
Signed-off-by: Samuel Ortiz <[EMA
Pavel Emelyanov <[EMAIL PROTECTED]> writes:
> Eric W. Biederman wrote:
>> Pavel Emelyanov <[EMAIL PROTECTED]> writes:
>>
>>> They include the whole file, but it is already compiled
>>> out when SYSCTL=n, since it is obj-$(CONFIG_SYSCTL) target
>>> in the Makefile.
>>
>> Pavel thanks for sending
On Thu, 2007-11-29 at 21:57 +1100, Herbert Xu wrote:
> On Mon, Nov 26, 2007 at 09:02:08PM +0100, Johannes Berg wrote:
> > sungem's gem_reset_task() will unconditionally try to disable NAPI even
> > when it's called while the interface is not operating and hence the NAPI
> > struct isn't enabled. M
Herbert Xu said the following on 2007-12-3 18:11:
> Please send driver patches to Jeff Garzik <[EMAIL PROTECTED]>.
>
Sorry. Resend the patch.
After netif_rx(), skb will be freed. So get the
skb->len before netif_rx().
Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
---
smc911x.c |5 +++--
1 f
On Mon, Dec 03, 2007 at 03:59:09PM +0800, Wang Chen wrote:
> After netif_rx(), skb will be freed. So get the
> skb->len before netif_rx().
>
> Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
Please send driver patches to Jeff Garzik <[EMAIL PROTECTED]>.
Thanks,
--
Visit Openswan at http://www.open
The register_ip_vs_scheduler() checks for the scheduler with the
same name under the read-locked __ip_vs_sched_lock, then drops,
takes it for writing and puts the scheduler in list.
This is racy, since we can have a race window between the lock
being re-locked for writing.
The fix is to search th
In case we load lblc or lblcr module we can leak some sysctl
tables if the call to register_ip_vs_scheduler() fails.
I've looked at the register_ip_vs_scheduler() code and saw, that
the only reason to fail is the name collision, so I think that
with some 3rd party schedulers this becomes a relevan
On Tue, Nov 27, 2007 at 10:23:00AM -0800, Kok, Auke wrote:
> can you see if your problem goes away with this patch?
I cannot test it right now but friend of mine has the same card with 2.6.23.1
kernel. it does not. he also tried module 7.6.12 from source fourge, your patch
did not help. Moreover,
On Sun, Dec 02, 2007 at 07:07:26PM -0500, Andrew Gallatin wrote:
>
> That was my first thought as well, but it turns out that
> when lro_gen_skb() is called via the out1 label, mac_hdr_len
> may not be known. It seemed simplest and cleanest to just
> make it a field in lro_mgr.
Fair enough.
Che
On Thu, Nov 29, 2007 at 03:49:34PM -0500, jamal wrote:
> Herbert,
>
> This is a simplified version of one of your earlier patches that never
> made it in. I liked it so much that i reduced it to this and infact
> given the cycles today, tested it (with transport and tunnel mode
> only;->).
Sorry
Patrick McHardy wrote:
Ariane Keller wrote:
Thanks for your comments!
I'd like to better understand your dislike of the current
implementation of the data transfer from user space to kernel space.
Is it the fact that we use configfs?
I think, we had already a discussion about this (and we
This patch removes some unneeded includes for net_namespace.h to speed up
compilation.
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
index f285de6..28b7f25 100644
--- a/include/net/pkt_cls.h
+++ b/include/net/pkt_cls.h
@@ -2,7 +2,6 @@
Herbert Xu wrote:
> On Thu, Nov 29, 2007 at 04:01:25PM +0300, Pavel Emelyanov wrote:
>> @@ -863,13 +861,13 @@ int inet_diag_register(const struct inet_diag_handler
>> *h)
>> if (type >= INET_DIAG_GETSOCK_MAX)
>> goto out;
>>
>> -spin_lock(&inet_diag_register_lock);
>> +
Eric W. Biederman wrote:
> Pavel Emelyanov <[EMAIL PROTECTED]> writes:
>
>> They include the whole file, but it is already compiled
>> out when SYSCTL=n, since it is obj-$(CONFIG_SYSCTL) target
>> in the Makefile.
>
> Pavel thanks for sending these patches. Might I ask
> for some level of acknow
On 01-12-2007 21:27, Michael Buesch wrote:
> On Saturday 01 December 2007 20:00:23 Arnaldo Carvalho de Melo wrote:
>> Em Sat, Dec 01, 2007 at 12:45:32PM -0500, John W. Linville escreveu:
>>> On Sat, Dec 01, 2007 at 03:17:44PM -0200, Arnaldo Carvalho de Melo wrote:
Sonics Silicon Backplane supp
On Sat, 2007-12-01 at 22:34 -0500, Mark Lord wrote:
> Stephen Hemminger wrote:.
> >>
> > I spoke too soon earlier, ndiswrapper builds and loads against current
> > 2.6.24-rc3. Vmware and proprietary VPN software probably do not. Once again
> > I don't
> > give a damn, but the enterprise distro v
Hi Arnaldo,
hank you for going through this. I have just backported your recent patches of
2.6.25
to the DCCP/CCID4/Faster Restart test tree at
git://eden-feed.erg.abdn.ac.uk/dccp_exp {dccp,ccid4,dccp_fr}
as per subsequent message.
|do, so please consider moving DCCP discussion t
Patrick McHardy wrote:
> Adrian Bunk wrote:
>> On Sun, Dec 02, 2007 at 09:03:56PM +0100, Patrick McHardy wrote:
>>
>>> For all I care binary modules can break, but frankly I don't see
>>> how encapsulating a couple of structures and pointers in a new
>>> structure and adding a new argument to exist
In cases where more than a single PHY is found on the MDIO bus, the kernel
will print a warning that this method is missing for each PHY device that
is not attached to a networking device.
Signed-off-by: Thierry Reding <[EMAIL PROTECTED]>
---
drivers/net/phy/mdio_bus.c | 19 ++-
On 12/3/07, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote:
> WARNING: After reading some messages from Ingo Molnar on lkml I think we
> should really
> trim the number of lists we use for kernel development. And since I
> moved
> back to using mutt for reading e-mails, some
After netif_rx(), skb will be freed. So get the
skb->len before netif_rx().
Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
---
smc911x.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.24.rc3.org/drivers/net/smc911x.c 2007-11-19 12:38:05.0
+0800
+++ linux-2.6
95 matches
Mail list logo
