On Mon, Dec 03, 2007 at 03:19:35PM +0800, Wang Chen wrote: > > System calls should be USER. So change the BH to USER for > UDP*_INC_STATS_BH(). > > Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
I've rearragned it so that we the new INC_STATS call is USER in the first patch. Otherwise it's all in net-2.6.25 now. BTW, thanks to Gerrit's note I took a look at the underlying code for the _BH/_USER stuff. It's in fact totally broken when PREEMPT is on. It relies on the fact that process-context kernel code does not get preempted by other process-context kernel code or for that matter migrate to other CPUs, neither of which is true with PREEMPT on. So we need to fix this, and whatever the fix is will probably render the BH/USER distinction obsolete. Any takers? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
