David Miller said the following on 2007-11-21 9:39:
> From: Andi Kleen <[EMAIL PROTECTED]>
> Date: Tue, 20 Nov 2007 15:05:18 +0100
>
>> On Tue, Nov 20, 2007 at 12:29:45AM -0500, Bill Fink wrote:
>>> While I agree with your analysis that it could be worked around,
>>> who knows how all the various
On Mon, Nov 26, 2007 at 08:14:12PM +0300, Pavel Emelyanov wrote:
> This function seems too big for inlining. Indeed, it saves
> half-a-kilo when uninlined:
>
> add/remove: 1/0 grow/shrink: 0/7 up/down: 195/-719 (-524)
> function old new delta
> sk_stream_a
Hi Stephen and Lachlan,
Thanks for pointing out and fixing this bug.
For the max RTT problem, I have considered it also and I have some idea on
improve it. I also have some other places to improve. I will summarize all
my new ideas and send you an update. For me to change it, could you please
giv
Tetsuo Handa <[EMAIL PROTECTED]> writes:
> Hello.
>
> James Morris wrote:
>> From memory, one approach under discussion was to add netfilter hooks to
>> the transport layer, which could be invoked correctly by each type of
>> protocol when the target process is selected.
>>
>> If this is done f
Yes.
Roland Dreier wrote:
OK, applied 1 and 2...
> Note: this change requires 5.0 firmware.
I assume the change to the cxgb3 FW versions is pending in a net
driver change for 2.6.25?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECT
OK, applied 1 and 2...
> Note: this change requires 5.0 firmware.
I assume the change to the cxgb3 FW versions is pending in a net
driver change for 2.6.25?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at h
On Wed, Nov 28, 2007 at 03:55:19PM +0200, Ian Brown wrote:
>
> no need to cache this entry ? because as I understand it , next
> sk_buff with the same dest IP will have to get this same
> dst_entry (the head of the list). So why not cache this head of the
> list of dst_entries ?
It's not in the ro
On Wed, Nov 28, 2007 at 08:54:10PM -0600, Olof Johansson wrote:
> The patches are:
[...]
I got the order wrong above, the actual one is:
1/12 pasemi_mac: RX/TX ring management cleanup
2/12 pasemi_mac: Move register definitions to include/asm-powerpc
3/12 pasemi: DMA engine management library
4/1
pasemi_mac: Don't enable RX/TX without a link (if possible)
Don't enable RX/TX of packets until we have a link, since there's a chance
we'll just get RX frame errors, etc.
The case where we don't have a PHY we can't do much about: Just enable
it and deal with errors as they come in.
Signed-off-
pasemi_mac: Print warning when not attaching to a PHY
Print a warning on the console when not connecting to a phy for an interface.
It turns out to be a pretty common problem when someone gets the MDIO info
wrong in their device tree, resulting in the macs running at a fixed 1Gbit FD.
Signed-off-
pasemi_mac: Remove SKB copy/recycle logic
It doesn't really buy us much, since copying is about as expensive
as the allocation in the first place. Just remove it for now.
Signed-off-by: Olof Johansson <[EMAIL PROTECTED]>
---
drivers/net/pasemi_mac.c | 25 +++--
1 file ch
pasemi_mac: SKB unmap optimization
Avoid touching skb_shinfo() in the unmap path, since it turns out to
normally cause cache misses and delays. instead, save number of fragments
in the TX_RING_INFO structures since that's all that's needed anyway.
Signed-off-by: Olof Johansson <[EMAIL PROTECTED]
pasemi_mac: Improve RX interrupt mitigation
Currently the receive side interrupts will go off on the reception of
a packet, NAPI will poll the ring and keep polling as long as there's
a decent amount of packets to receive.
This is less than optimal, especially for LRO where it's better if we
have
pasemi_mac: Software-based LRO support
Implement LRO for pasemi_mac. Pretty straightforward.
Signed-off-by: Olof Johansson <[EMAIL PROTECTED]>
---
drivers/net/Kconfig |1
drivers/net/pasemi_mac.c | 53 +++
drivers/net/pasemi_mac.h |5
pasemi_mac: Fix TX cleaning
This is a bit awkward. We don't have a timer-delayed interrupt on TX
complete, but we have a count threshold. So set that reasonably high
(32 packets), and schedule the NAPI poll when it goes off. Also bump a
regular timer that will take care of rotting packets for the
pasemi_mac: performance tweaks
* Seems like we do better with a smaller RX ring, probably because chances of
still having the SKB cached are better
* Const-ify variables to get better code generation and fewer reloads
* Move prefetching around a little, and try to prefetch the whole SKB
* Set NE
pasemi_mac: Convert to new dma library
Convert the pasemi_mac driver to the new platform global DMA manaagement
library. This also does a couple of other minor cleanups w.r.t. channel
management.
Signed-off-by: Olof Johansson <[EMAIL PROTECTED]>
---
drivers/net/pasemi_mac.c | 480 +
pasemi: DMA engine management library
Introduce a DMA management library to manage the various DMA resources
on the PA Semi SoCs. Since several drivers need to allocate these shared
resources, provide some abstractions as well as allocation/free functions
for channels, etc.
Signed-off-by: Olof J
pasemi_mac: Move register definitions to include/asm-powerpc
Move the common register formats and descriptor layouts from
drivers/net/pasemi_mac.h to include/asm-poewrpc/pasemi_dma.h
Previously only the ethernet driver was using them, but other drivers
are coming up that will also use them, so it
pasemi_mac: RX/TX ring management cleanup
Prepare a bit for supporting multiple TX queues by cleaning up some
of the ring management and shuffle things around a bit.
Signed-off-by: Olof Johansson <[EMAIL PROTECTED]>
---
drivers/net/pasemi_mac.c | 277 --
Hi,
The following series contains driver updates for 2.6.25, together with a
couple of patches that introduces a library for abstracting DMA channel
allocation and access.
While the DMA stuff (patches 5 and 6) isn't really netdev material, the
driver updates depend on them, and it'd just be easie
The cancel_delayed_work_sync has moved into ilw_cancel_deferred_work.
Thanks Zhu Yi.
[net/wireless/iwlwifi] : iwlwifi 4965 Fix race conditional panic.
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/wireless/iwlwifi/iwl4965-base.c
b/drivers/net/wireless/iwlwifi/iwl49
2007/11/29, Zhu Yi <[EMAIL PROTECTED]>:
>
> Good catch. But it will be better if you add it into
> iwl_cancel_deferred_work().
>
Thanks.
I agree with you.
Actually, I considered it, but I was afraid of side effect.
Anyway, I'm attaching a new one.
Thanks.
Joonwoo
[net/wireless/iwlwifi] : iwlw
On Wed, 2007-11-28 at 14:06 -0600, Mike Christie wrote:
> Anil Veerabhadrappa wrote:
> >
> Which ones were they exactly? I think JamesB wanted only common
> transport values in the transport class. If it is driver specific then
> it should go on the host or target or device with t
>The previous code returned '\n' (that is, a single empty line)
>from most files, with one exception (xmit_hash_policy), where
>it returned 'NA\n'. This patch consolidates each file to return
>nothing at all if not applicable, not even a '\n'.
>
>I find this behaviour more usual, more useful, mor
On Wed, 2007-11-28 at 19:41 +0900, Joonwoo Park wrote:
> [net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic.
>
> Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
> ---
> diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c
> b/drivers/net/wireless/iwlwifi/iwl3945-base.c
> index 4
=?utf-8?q?Ferenc_W=C3=A1gner?= wrote:
Signed-off-by: Ferenc Wágner <[EMAIL PROTECTED]>
Acked-by: Randy Dunlap <[EMAIL PROTECTED]>
Thanks.
---
Randy Dunlap <[EMAIL PROTECTED]> writes:
drivers/net/bonding/bond_sysfs.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff -
Lachlan Andrew wrote:
Thanks Stephen.
A related problem (largely due to the published algorithm itself) is
that Illinois is very aggressive when it over-estimates the maximum
RTT.
At high load (say 200Mbps and 200ms RTT), a backlog of packets builds
up just after a loss, causing the RTT estimat
Thanks Stephen.
A related problem (largely due to the published algorithm itself) is
that Illinois is very aggressive when it over-estimates the maximum
RTT.
At high load (say 200Mbps and 200ms RTT), a backlog of packets builds
up just after a loss, causing the RTT estimate to become large. This
Signed-off-by: Ferenc Wágner <[EMAIL PROTECTED]>
---
Randy Dunlap <[EMAIL PROTECTED]> writes:
> Wagner Ferenc wrote:
>> Randy Dunlap <[EMAIL PROTECTED]> writes:
>>
>>> Patches 1 & 3 use
>>>
>>> if (res) statement;
>>>
>>> but the preferred form is
>>>
>>> if (res)
>>> statement
Lachlan Andrew observed that my TCP-Illinois implementation uses the
beta value incorrectly:
The parameter beta in the paper specifies the amount to decrease
*by*: that is, on loss,
W <- W - beta*W
but in tcp_illinois_ssthresh() uses beta as the amount
to decrease *to*: W <-
When using larger MTU's sky2 driver changes from allocating one
data area, to using multiple pages. The threshold for this was based on
a heuristic where the cost of a single allocation is bigger than one
page. Since the allocator has changed, this heuristic is now incorrect;
instead just make the
For compatiablity with sk98lin, make sure and set same values
in serial mode register.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
Please apply for 2.6.24 (upstream-fixes) after the previous group
of skge patches (1.13)
--- a/drivers/net/skge.c2007-11-28 09:27:02.0 -0
The code to change MTU doesn't correctly handle all the chip variations
and requirements for restarting. On Genesis chips changing MTU would just
cause receiver to hang.
Use a simpler approach of just taking link down/up if needed.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
Please
The sky2 driver was not aligning the IP header on receive buffers.
This workaround is only needed on hardware with broken FIFO, newer chips
without FIFO can just DMA to unaligned address.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
Please apply for 2.6.25 this is not urgent.
--- a/d
The VIA veloicty driver needs the following to allow changing MTU when down.
The buffer size needs to be computed when device is brought up, not when
device is initialized. This also fixes a bug where the buffer size was
computed differently on change_mtu versus initial setting.
Signed-off-by: St
- whitespaces vs tabs
- use 80 cols
- use if_mii
- use netdev_priv
- remove useless cast to void *
- PCI device id does not need to be globally available
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>
---
drivers/net/r6040.c | 33 +
include/linux/pci_ids.
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>
---
drivers/net/r6040.c | 103 +--
1 files changed, 50 insertions(+), 53 deletions(-)
diff --git a/drivers/net/r6040.c b/drivers/net/r6040.c
index 6a6329e..a106add 100644
--- a/drivers/net/r6040.c
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>
---
drivers/net/r6040.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/r6040.c b/drivers/net/r6040.c
index a106add..71aa478 100644
--- a/drivers/net/r6040.c
+++ b/drivers/net/r6040.c
@@ -674,7 +674,7 @@ stati
drivers/net/r6040.c: In function 'rx_buf_alloc':
drivers/net/r6040.c:262: warning: passing argument 2 of 'pci_map_single' makes
pointer from integer without a cast
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>
---
drivers/net/r6040.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(
Please pull from branch 'r6040' in repository
git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git r6040
to get the changes below.
Distance from 'netdev-2.6-upstream' (02e063b58b7c7084bae3d599c54dcf26c8efa9b7)
---
Just a reminder: the following fix should (IMO) be considered for
2.6.24. The first patch does indeed fix the OOPS on MTU however
subsequent MTU changes still OOPS. The below fixes that. I've been
using both patches for over a week and they work just great. I noticed
that the first fix made 2.6.24
Couldn't find one of these on the lists...
PATCH 2.6.24-rc3-mm1: bnx2x depends on ZLIB_INFLATE
The bnx2x module depends on the zlib_inflate functions. The
build will fail if ZLIB_INFLATE has not been selected manually
or by building another module that automatically selects it.
Modify BNX2X co
Chris Leech wrote:
> Christoph Hellwig wrote:
>
>> I just did a very quick glance over the tree. Some extremly highlevel
>> comments to start with before actually starting the source review:
>>
>
> Thanks for taking a look Christoph
>
>
>> - why do you need your own libcrc? lib/crc32.
Anil Veerabhadrappa wrote:
Which ones were they exactly? I think JamesB wanted only common
transport values in the transport class. If it is driver specific then
it should go on the host or target or device with the scsi_host_template
attrs.
It's a chicken & egg issue to put "port mapper"
This kind of sucks, and prevents the Fedora installer from using the
device for network installs...
[EMAIL PROTECTED] phy]# iwconfig eth0
Warning: Driver for device eth0 has been compil
On Wed, 2007-11-28 at 10:47 -0800, Brandeburg, Jesse wrote:
>
> > The side effect is that I removed the assignments to the netdev
> > fields mem_start, mem_end and base_addr, which are totally useless
> > for PCI devices.
>
> also, concerning this, ifconfig shows the output of these variables, I
Jeff Garzik wrote:
Kok, Auke wrote:
David Acker wrote:
What is the status of this patch?
Jeff merged it in netdev-2.6#upstream so it is queued for 2.6.25.
However, we could consider pushing this patch to 2.6.24 since it's a
valid fix.
Andrew has also been carrying this patch in -mm for a wh
Kok, Auke wrote:
David Acker wrote:
What is the status of this patch? Is there anything folks would like me
to do in order to move it forward? As an FYI, my company has been using
this patch since I posted it and so far we have not had any problems
with it.
-Ack
Jeff merged it in netdev-2.6
David Acker wrote:
> What is the status of this patch? Is there anything folks would like me
> to do in order to move it forward? As an FYI, my company has been using
> this patch since I posted it and so far we have not had any problems
> with it.
> -Ack
Jeff merged it in netdev-2.6#upstream s
What is the status of this patch? Is there anything folks would like me to do in order to move it forward? As an FYI,
my company has been using this patch since I posted it and so far we have not had any problems with it.
-Ack
Auke Kok wrote:
From: David Acker <[EMAIL PROTECTED]>
On the syst
This patch adds UDP memory usage accounting in IPv4.
Cc: Satoshi Oshima <[EMAIL PROTECTED]>
signed-off-by: Hideo Aoki <[EMAIL PROTECTED]>
---
af_inet.c | 30 +-
ip_output.c | 49 ++---
udp.c | 16 ++
This patch introduces datagram memory accounting functions. Owing to
call memory schedule functions from IP layer, sk_wmem_schedule() is
also added.
Cc: Satoshi Oshima <[EMAIL PROTECTED]>
signed-off-by: Hideo Aoki <[EMAIL PROTECTED]>
---
include/net/sock.h | 31 +++
This patch adds sysctl parameters for customizing UDP memory accounting:
/proc/sys/net/ipv4/udp_mem
/proc/sys/net/ipv4/udp_rmem_min
/proc/sys/net/ipv4/udp_wmem_min
Udp_mem indicates number of pages which can be used for all UDP sockets.
Each UDP packet is dropped, when the number of
This patch introduces sndbuf size check before memory allocation for
send buffer.
signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]>
signed-off-by: Hideo Aoki <[EMAIL PROTECTED]>
---
ip_output.c |5 +
1 file changed, 5 insertions(+)
diff -pruN net-2.6/net/ipv4/ip_output.c
net-2.6-udp-ta
Hello,
This is the latest patch set of UDP memory accounting and limitation.
I implemented memory schedule functions for datagram protocols
like stream protocols. Moreover, to call memory schedule functions
from IP layer, I added a wrapper function, sk_wmem_schedule(), as
I proposed last week:
h
Benjamin Herrenschmidt wrote:
> The e1000 driver stores the content of the PCI resources into
> unsigned long's before ioremapping. This breaks on 32 bits
> platforms that support 64 bits MMIO resources such as ppc 44x.
>
> This fixes it by removing those temporary variables and passing
> directly
On Wed, 28 Nov 2007 10:26:36 -0700
[EMAIL PROTECTED] (Eric W. Biederman) wrote:
> Christian Borntraeger <[EMAIL PROTECTED]> writes:
>
> > Am Mittwoch, 28. November 2007 schrieb Frans Pop:
> > [...]
> >> During boot I get the following oops in the Hercules emulator.
> >> 2.6.22 runs fine on Hercul
Christian Borntraeger <[EMAIL PROTECTED]> writes:
> Am Mittwoch, 28. November 2007 schrieb Frans Pop:
> [...]
>> During boot I get the following oops in the Hercules emulator.
>> 2.6.22 runs fine on Hercules; I've not tried .23 on it.
> [...]
>> cut here !
>> kernel BUG a
Christoph Hellwig wrote:
I just did a very quick glance over the tree. Some extremly highlevel
comments to start with before actually starting the source review:
Thanks for taking a look Christoph
- why do you need your own libcrc? lib/crc32.c has a crc32_le
We shouldn't, but we may want
This helps to allow the Fedora installer to use the built-in Ethernet on
the Efika for a network install.
Signed-off-by: David Woodhouse <[EMAIL PROTECTED]>
--- a/drivers/net/fec_mpc52xx.c
+++ b/drivers/net/fec_mpc52xx.c
@@ -971,6 +971,8 @@ mpc52xx_fec_probe(struct of_device *op, const struct
of
On Sun, 2007-11-18 at 20:49 -0500, Jon Smirl wrote:
> On 11/9/07, Grant Likely <[EMAIL PROTECTED]> wrote:
> > On 11/9/07, Domen Puncer <[EMAIL PROTECTED]> wrote:
> > > On 09/11/07 00:31 -0500, Jon Smirl wrote:
> > > > This is the reason I couldn't get user space started or connect to my
> > > > nf
Hi,
I have made the following changes to our off-tree 2.6.22 smsc911x
driver, to make it run on 2.6.24-rc2. However the NAPI poll function
does not get called after an rx irq. Can you comment on what's wrong?
Thanks,
Bahadir
diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c
index b7f
On Wednesday 28 November 2007 17:48:17 Adrian Bunk wrote:
> On Wed, Nov 28, 2007 at 12:06:45AM +0100, Andi Kleen wrote:
> > On Tue, Nov 27, 2007 at 03:00:22PM -0800, Stephen Hemminger wrote:
> >...
> > > of a modular ipv6 is flawed.
> >
> > Modules that cannot be unloaded are still useful. Standa
No it doesn't. besides napi_disable and napi_synchronize are identical.
I was trying to disarm interrupts this way too.
The patch I did send yesterday is the only cure so-far but I don't if
it's 100% bullet proof either.
I was stress-testing it patch but ran into new problems...(schedul
On Wed, 28 Nov 2007, Ilpo Järvinen wrote:
> @@ -1575,7 +1575,7 @@ tcp_sacktag_write_queue(struct sock *sk, struct sk_buff
> *ack_skb, u32 prior_snd_
> continue;
> }
>
> - if (!before(start_seq, tcp_highest_sack_seq(tp))) {
> + if (tp->
On Wed, Nov 28, 2007 at 12:06:45AM +0100, Andi Kleen wrote:
> On Tue, Nov 27, 2007 at 03:00:22PM -0800, Stephen Hemminger wrote:
>...
> > of a modular ipv6 is flawed.
>
> Modules that cannot be unloaded are still useful. Standard case: Distributions
> like to offer an option to not use ipv6 becau
Would this fix it?
--- a/drivers/net/e1000/e1000_main.c2007-11-15 21:13:12.0 -0800
+++ b/drivers/net/e1000/e1000_main.c2007-11-28 08:37:03.0 -0800
@@ -630,10 +630,10 @@ e1000_down(struct e1000_adapter *adapter
* reschedule our watchdog timer */
set_bit(__E1
Wagner Ferenc wrote:
Randy Dunlap <[EMAIL PROTECTED]> writes:
On Wed, 28 Nov 2007 01:49:54 +0100 =?utf-8?q?Ferenc_W=C3=A1gner?= wrote:
Patches 1 & 3 use
if (res) statement;
but the preferred form is
if (res)
statement;
Even if this style was already used in
AF_RXRPC uses the crypto services, so should depend on or select CRYPTO.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
net/rxrpc/Kconfig |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/rxrpc/Kconfig b/net/rxrpc/Kconfig
index e662f1d..0d3103c 100644
--- a/net/r
AF_RXRPC uses the crypto services, so should depend on or select CRYPTO.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
net/rxrpc/Kconfig |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/rxrpc/Kconfig b/net/rxrpc/Kconfig
index e662f1d..0d3103c 100644
--- a/net/r
1) Skip condition used to be wrong way around which made SACK
processing very broken, missed many blocks because of that.
2) Use highest_sack advancement only if some skbs are already
sacked because otherwise tcp_write_queue_next may move things
too far (occurs mainly with GSO). The other similar
Thanks!
I had though about this in the last two days and a half, and there is
still something which I cannot
understand and it bothers me (while trying vainlesly to sleep).
I am talking about IPV4:
- Can anyone explain in 2-3 sentences what is the reason that there
is no need for caching
dst_en
On 21-11-2007 23:13, Bernard Pidoux wrote:
...
> [ INFO: inconsistent lock state ]
>
> The error seems to reside around ax25_disconnect+0x46/0xaf [ax25] that
> is called when an AX25 connect timeout or a connection failure occurs.
> Connect timeout is probably activating
> ax25_std_heartbeat_expi
Stephen Hemminger writes:
> It is considered a driver bug in 2.6.24 to call netif_rx_complete (clear
> NAPI_STATE_SCHED)
> and do a full quota. That bug already had to be fixed in other drivers,
> look like e1000 has same problem.
From what I see the problem is not related to ->poll. But i
Kok, Auke writes:
>
> Robert, please give that patch a try (it fixes a crash that I had here as
> well)
> and let us know if it works for you.
No it doesn't cure the problem I've reported
Cheers.
--ro
BTW. You can try to verify the probl
This patch includes the PSPacer (Precise Software Pacer) qdisc
module, which achieves precise transmission bandwidth control.
You can find more information at the project web page
(http://www.gridmpi.org/gridtcp.jsp).
Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]>
---
include/linux/pkt_sched.h
This patch includes the PSPacer (Precise Software Pacer) qdisc
module, which achieves precise transmission bandwidth control.
You can find more information at the project web page
(http://www.gridmpi.org/gridtcp.jsp).
Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]>
---
include/linux/pkt_sched.h
This patch includes the PSPacer (Precise Software Pacer) qdisc
tc part, which achieves precise transmission bandwidth control.
You can find more information at the project web page
(http://www.gridmpi.org/gridtcp.jsp).
Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]>
---
include/linux/pkt_sched.
This patch includes the man page of the PSPacer (Precise Software
Pacing) qdisc module.
Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]>
---
man/man8/tc-psp.8 | 166 +
1 files changed, 166 insertions(+), 0 deletions(-)
create mode 100644 man/
Hi all,
This is the 3rd version of PSPacer patches.
PSPacer (Precise Software Pacer) is a qdisc module which realizes
precise transmission bandwidth control. It makes bursty traffic which is
often generated by TCP smooth without any special hardware.
For your information, please see my previous
Hi.
Avaid provided test application, so bug got fixed.
IPv6 addrconf removes ipv6 inner device from netdev each time cmu
changes and new value is less than IPV6_MIN_MTU (1280 bytes).
When mtu is changed and new value is greater than IPV6_MIN_MTU,
it does not add ipv6 addresses and inner device ba
iwl_pci_remove can be called before delayed work queue is completed or not
called at init module, so delayed init_alive_start can
have 'image' as NULL.
It can be happened while putting module down right next it up.
I was able to make panic by :
#while [ 1 ]; modprobe -r iwlx945; modprobe iwlx945;
I think 4965 may suffer it too, but I could not test.
Thanks
Joonwoo
[net/wireless/iwlwifi] : iwlwifi 4965 Fix race conditional panic.
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/wireless/iwlwifi/iwl4965-base.c
b/drivers/net/wireless/iwlwifi/iwl4965-base.c
index
The
if (statement)
WARN_ON(1);
looks much better as
WARN_ON(statement);
Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
---
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 61ead1d..e41f4b9 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-s
Ryousei Takano wrote:
Hi Patrick,
+struct tc_psp_qopt
+{
+ __u32 defcls;
+ __u32 rate;
+};
What unit is rate measured in?
'rate' is the transmission rate in bytes per sec.
So wouldn't it make sense to use u64 then for 10GBit networks?
I decided to use u32 after tc_ratespe
Dear Andrew:
Thanks very much for your test.
Yes, you can fix it.
If you have any problem that we can help, please feel free to mail me or Tim.
Thnaks.
Best Regards,
Sten
=
E-mail Confidentiality Notice
The inform
Randy Dunlap <[EMAIL PROTECTED]> writes:
> On Wed, 28 Nov 2007 01:49:54 +0100 =?utf-8?q?Ferenc_W=C3=A1gner?= wrote:
>
> Patches 1 & 3 use
>
> if (res) statement;
>
> but the preferred form is
>
> if (res)
> statement;
>
> Even if this style was already used in the source
88 matches
Mail list logo
