Re: netconsole=y and rtl8139=m

2007-11-19 Thread Mike Frysinger
On Nov 20, 2007 2:17 AM, Jan Engelhardt <[EMAIL PROTECTED]> wrote: > I get this during boot: > > [ 40.821740] netconsole: eth1 doesn't exist, aborting. > > Given that CONFIG_NETCONSOLE=y and CONFIG_8139TOO=m, I can imagine. > Is there a way to get this working without making 8139TOO=y or > NETCON

Re: [PATCH, take2] netfilter : struct xt_table_info diet

2007-11-19 Thread Patrick McHardy
Simon Horman wrote: From: Eric Dumazet <[EMAIL PROTECTED]> Instead of using a big array of NR_CPUS entries, we can compute the size needed at runtime, using nr_cpu_ids This should save some ram (especially on David's machines where NR_CPUS=4096 : 32 KB can be saved per table, and 64KB for dynam

Re: [PATCH, take2] netfilter : struct xt_table_info diet

2007-11-19 Thread Patrick McHardy
Herbert Xu wrote: Simon Horman <[EMAIL PROTECTED]> wrote: @@ -269,9 +269,12 @@ struct xt_table_info unsigned int underflow[NF_INET_NUMHOOKS]; /* ipt_entry tables: one per CPU */ - char *entries[NR_CPUS]; + /* Note : this field MUST be the last one, see XT_TABLE_INFO

Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0

2007-11-19 Thread David Miller
From: Bill Fink <[EMAIL PROTECTED]> Date: Tue, 20 Nov 2007 00:16:07 -0500 > On Mon, 19 Nov 2007, Alexey Kuznetsov wrote: > > > 2. What's about your suggestion, I thought about this and I am going to > > agree. > > > >Arguments, which convinced me are: > > > >- arping still works. > >

Re: [PATCH 54/59] net/irda: Add missing "space"

2007-11-19 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 17:53:41 -0800 > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH 56/59] net/sunrpc: Add missing "space"

2007-11-19 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 17:53:43 -0800 > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH 55/59] net/sctp: Add missing "space"

2007-11-19 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 17:53:42 -0800 > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH 50/59] net/bridge: Add missing "space"

2007-11-19 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 17:53:37 -0800 > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH 53/59] net/ipv6: Add missing "space"

2007-11-19 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 17:53:40 -0800 > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH 52/59] net/ipv4: Add missing "space"

2007-11-19 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 17:53:39 -0800 > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH 51/59] net/dccp: Add missing "space"

2007-11-19 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 17:53:38 -0800 > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/ma

Re: [patch 06/22] NET: DM9000: Use kthread to probe MII status when device open

2007-11-19 Thread Christoph Hellwig
> +static void dm9000_start_thread(struct net_device *dev) > +{ > + board_info_t *db = (board_info_t *) dev->priv; > + > + /* Create a thread to keep track of the state of the phy > + * as we do not get an interrupt when the PHY state changes. > + * > + * Note, we do not abor

Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

2007-11-19 Thread Simon Horman
On Mon, Nov 19, 2007 at 11:18:44PM -0800, Joe Perches wrote: > On Tue, 2007-11-20 at 16:06 +0900, Simon Horman wrote: > > On Mon, Nov 19, 2007 at 10:40:12PM -0800, Joe Perches wrote: > > > Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET > > > macros to inline functions ipv4_is_(__be32 ad

Re: Problem with sysctl_tcp_congestion_control function

2007-11-19 Thread David Miller
From: "Sam Jansen" <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 16:25:16 -0800 > sysctl_tcp_congestion_control seems to have a bug that prevents it from > actually calling the tcp_set_default_congestion_control function. This is not > so apparent because it does not return an error and generally the

Re: [PATCH net-2.6 (2nd try)] [TCP] MTUprobe: fix potential sk_send_head corruption

2007-11-19 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 16:15:54 +0200 (EET) > [PATCH] [TCP] MTUprobe: fix potential sk_send_head corruption > > When the abstraction functions got added, conversion here was > made incorrectly. As a result, the skb may end up pointing > to skb which got i

Async crypto support in IPsec

2007-11-19 Thread Jesper Bengtsson
Hi, I'm investigating IPsec with hw-accelerated encryption, using the AXIS crisv32 built-in crypto accelerator. The crisv32 crypto accelerator does however require asynchronous crypto support in crypto API and IPsec stack. I've seen that async crypto support made it's way into the crypto API in 2

Re: [PATCH] Compact sk_stream_mem_schedule() code

2007-11-19 Thread David Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 17:30:59 -0200 > Em Mon, Nov 19, 2007 at 03:13:44PM +0300, Pavel Emelyanov escreveu: > > This function references sk->sk_prot->xxx for many times. > > It turned out, that there's so many code in it, that gcc > > cannot alwa

Re: [PATCH 1/2] virtio: fix net driver loop case where we fail to restart

2007-11-19 Thread Simon Horman
On Mon, Nov 19, 2007 at 11:20:15AM +1100, Rusty Russell wrote: > skb is only NULL the first time around: it's more correct to test for > being under-budget. > > Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> That looks better to me. Acked-by: Simon Horman <[EMAIL PROTECTED]> > diff -r 2a94425

Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

2007-11-19 Thread Joe Perches
On Tue, 2007-11-20 at 16:06 +0900, Simon Horman wrote: > On Mon, Nov 19, 2007 at 10:40:12PM -0800, Joe Perches wrote: > > Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET > > macros to inline functions ipv4_is_(__be32 addr) > > Adds some type safety and arguably some readability > > No ch

Re: [PATCH][net-2.6.25][NETNS] make netns cleanup to run in a separate workqueue

2007-11-19 Thread David Miller
From: Kirill Korotaev <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 14:08:49 +0300 > Acked-By: Kirill Korotaev <[EMAIL PROTECTED]> I've applied this patch, thanks everyone. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordom

netconsole=y and rtl8139=m

2007-11-19 Thread Jan Engelhardt
Hi, I get this during boot: [ 40.821740] netconsole: eth1 doesn't exist, aborting. Given that CONFIG_NETCONSOLE=y and CONFIG_8139TOO=m, I can imagine. Is there a way to get this working without making 8139TOO=y or NETCONSOLE=m? thanks, Jan - To unsubscribe from this list: send the line "

Re: [PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

2007-11-19 Thread Simon Horman
On Mon, Nov 19, 2007 at 10:40:12PM -0800, Joe Perches wrote: > Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET > macros to inline functions ipv4_is_(__be32 addr) > > Adds some type safety and arguably some readability > > No change in compiled image size > > Signed-off-by: Joe Perches

Re: [PATCH, take2] netfilter : struct xt_table_info diet

2007-11-19 Thread Herbert Xu
Simon Horman <[EMAIL PROTECTED]> wrote: > > @@ -269,9 +269,12 @@ struct xt_table_info >unsigned int underflow[NF_INET_NUMHOOKS]; > >/* ipt_entry tables: one per CPU */ > - char *entries[NR_CPUS]; > + /* Note : this field MUST be the last one, see XT_TABLE_INFO_SZ */ > +

Re: [PATCH 52/59] net/ipv4: Add missing "space"

2007-11-19 Thread Simon Horman
On Mon, Nov 19, 2007 at 05:53:39PM -0800, Joe Perches wrote: > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Acked-by: Simon Horman <[EMAIL PROTECTED]> > --- > net/ipv4/ipvs/ip_vs_core.c |2 +- > net/ipv4/netfilter/iptable_raw.c |2 +- > 2 files changed, 2 insertions(+), 2 dele

Re: [PATCH][IPVS] Relax the module get/put in ip_vs_app.c

2007-11-19 Thread David Miller
From: Simon Horman <[EMAIL PROTECTED]> Date: Tue, 20 Nov 2007 11:28:18 +0900 > On Mon, Nov 19, 2007 at 12:58:14PM +0300, Pavel Emelyanov wrote: > > Both try_module_get/module_put already handle the module == NULL > > case, so no need in manual checking. > > > > This patch fits both net-2.6 and ne

Re: [PATCH][PKTGEN] Fix double unlock of xfrm_state->lock

2007-11-19 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 12:47:00 +0300 > The pktgen_output_ipsec() function can unlock this lock twice > due to merged error and plain paths. Remove one of the calls > to spin_unlock. > > Other possible solution would be to place "return 0" right > after

Re: [PATCH] tun: use iov_length()

2007-11-19 Thread David Miller
From: Akinobu Mita <[EMAIL PROTECTED]> Date: Sat, 17 Nov 2007 22:55:00 +0900 > Use iov_length() instead of tun's homemade iov_total(). > > Cc: Maxim Krasnyansky <[EMAIL PROTECTED]> > Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> Applied, thank you. - To unsubscribe from this list: send the lin

Re: [2.6 patch] net/core/request_sock.c: remove unused exports

2007-11-19 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sat, 17 Nov 2007 12:58:48 +0100 > This patch removes the following unused EXPORT_SYMBOL's: > - reqsk_queue_alloc > - __reqsk_queue_destroy > - reqsk_queue_destroy > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Applied to net-2.6.25, thanks Adrian.

[PATCH net-2.6.25 4/4] net/netfilter - Convert IP4 address class macros to inline functions

2007-11-19 Thread Joe Perches
Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions is_ip4_[type](__be32 addr) Adds some type safety and arguably some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/netfilter/xt_pkttype.c |2 +- 1 file

[PATCH net-2.6.25 3/4] net/ipv4 - Convert IP4 address class macros to inline functions

2007-11-19 Thread Joe Perches
Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_(__be32 addr) Adds some type safety and arguably some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/ipv4/arp.c |2 +- net/ipv4/datag

Re: [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to workqueue

2007-11-19 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Sat, 17 Nov 2007 10:41:47 +0100 > [PATCH] IPV4 : Move ip route cache flush (secret_rebuild) from softirq to > workqueue > > Every 600 seconds (ip_rt_secret_interval), a softirq flush of the whole > ip route cache is triggered. On loaded machines, this

[PATCH net-2.6.25 2/4] net/core - Convert IP4 address class macros to inline functions

2007-11-19 Thread Joe Perches
Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_(__be32 addr) Adds some type safety and arguably some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/core/netpoll.c |2 +- net/core/pktgen.c

[PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions

2007-11-19 Thread Joe Perches
Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_(__be32 addr) Adds some type safety and arguably some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- include/linux/in.h | 45 +++

[PATCH net-2.6.25 0/4] Convert IP4 address class macros to inline functions

2007-11-19 Thread Joe Perches
Change LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_(__be32 addr) Adds some type safety and arguably some readability No change in compiled image size Signed-off-by: Joe Perches <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubs

Re: [PATCH 6/6 net-2.6.25][RAW] Consolidate proc interface (v2)

2007-11-19 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Fri, 16 Nov 2007 18:06:16 +0300 > Both ipv6/raw.c and ipv4/raw.c use the seq files to walk > through the raw sockets hash and show them. > > The "walking" code is rather huge, but is identical in both > cases. The difference is the hash table to wal

Re: [PATCH 5/6 net-2.6.25][RAW] Consolidate proto->unhash callback

2007-11-19 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Fri, 16 Nov 2007 17:15:46 +0300 > Same as the ->hash one, this is easily consolidated. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [

Re: [PATCH 3/6 net-2.6.25][RAW] Introduce raw_hashinfo structure

2007-11-19 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Fri, 16 Nov 2007 17:12:31 +0300 > The ipv4/raw.c and ipv6/raw.c contain many common code (most > of which is proc interface) which can be consolidated. > > Most of the places to consolidate deal with the raw sockets > hashtable, so introduce a struc

Re: [PATCH 4/6 net-2.6.25][RAW] Consolidate proto->hash callback

2007-11-19 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Fri, 16 Nov 2007 17:14:20 +0300 > Having the raw_hashinfo it's easy to consolidate the > raw[46]_hash functions. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe ne

Re: [PATCH 2.6.25 6/6] net: consolidate net namespace related proc files creation

2007-11-19 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Thu, 15 Nov 2007 19:01:50 +0300 > net: consolidate net namespace related proc files creation > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Also applied, thanks a lot. - To unsubscribe fr

Re: [PATCH 1/6 net-2.6.25] IPv4 RAW: Compact the API for the kernel

2007-11-19 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Fri, 16 Nov 2007 17:05:59 +0300 > The raw sockets functions are explicitly used from > inside the kernel in two places: > > 1. in ip_local_deliver_finish to intercept skb-s > 2. in icmp_error > > For this purposes many functions and even data stru

Re: [PATCH 2/6 net-2.6.25] IPv6 RAW: Compact the API for the kernel

2007-11-19 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Fri, 16 Nov 2007 17:08:37 +0300 > Same as in the previous patch for ipv4, compact the > API and hide hash table and rwlock inside the raw.c > file. > > Plus fix some "bad" places from checkpatch.pl point > of view (assignments inside if()). > > Si

Re: [PATCH 2.6.25 5/6] net: Make AF_UNIX per network namespace safe (v2)

2007-11-19 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Thu, 15 Nov 2007 19:00:41 +0300 > Because of the global nature of garbage collection, and because of the > cost of per namespace hash tables unix_socket_table has been kept > global. With a filter added on lookups so we don't see sockets from > the

Re: [PATCH 2.6.25 4/6] net: Make AF_PACKET handle multiple network namespaces

2007-11-19 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Thu, 15 Nov 2007 18:59:54 +0300 > This is done by making packet_sklist_lock and packet_sklist per > network namespace and adding an additional filter condition on > received packets to ensure they came from the proper network > namespace. > > Chang

Re: [PATCH 2.6.25 3/6] net: Make the netlink methods in rtnetlink handle multiple network namespaces

2007-11-19 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Thu, 15 Nov 2007 18:58:36 +0300 > From: Eric W. Biederman <[EMAIL PROTECTED]> > > After the previous prep work this just consists of removing checks > limiting the code to work in the initial network namespace, and > updating rtmsg_ifinfo so we can

Re: [PATCH 2.6.25 2/6] net: Make rtnetlink infrastructure network namespace aware (v3)

2007-11-19 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Thu, 15 Nov 2007 18:57:41 +0300 > After this patch none of the netlink callback support anything > except the initial network namespace but the rtnetlink infrastructure > now handles multiple network namespaces. > > Changes from v2: > - IPv6 addrla

Re: [PATCH 2.6.25 1/6] net: Modify all rtnetlink methods to only work in the initial namespace (v2)

2007-11-19 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Thu, 15 Nov 2007 18:56:48 +0300 > Before I can enable rtnetlink to work in all network namespaces > I need to be certain that something won't break. So this > patch deliberately disables all of the rtnletlink methods in everything > except the init

Re: [PATCH, take2] netfilter : struct xt_table_info diet

2007-11-19 Thread Simon Horman
From: Eric Dumazet <[EMAIL PROTECTED]> Instead of using a big array of NR_CPUS entries, we can compute the size needed at runtime, using nr_cpu_ids This should save some ram (especially on David's machines where NR_CPUS=4096 : 32 KB can be saved per table, and 64KB for dynamically allocated ones

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-19 Thread Herbert Xu
On Tue, Nov 20, 2007 at 02:25:23PM +0800, Wang Chen wrote: > > I want to wait for more suggestions until make such patch. > Because this solution leads to troubles with some apps, such as NFS. > (http://bugzilla.kernel.org/show_bug.cgi?id=6660#c2) Well that's easy. Just get NFS to increment the c

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-19 Thread Wang Chen
David Miller said the following on 2007-11-20 14:15: > From: Bill Fink <[EMAIL PROTECTED]> > Date: Tue, 20 Nov 2007 00:29:45 -0500 > >> But the best approach seems to be just not to count >> it in the first place until tha application has actually received >> the packet, since as Herbert pointed o

Re: [PATCH] LRO ack aggregation

2007-11-19 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 20 Nov 2007 14:09:18 +0800 > David Miller <[EMAIL PROTECTED]> wrote: > > > > Fundamentally, I really don't like this change, it batches to the > > point where it begins to erode the natural ACK clocking of TCP, and I > > therefore am very likely to r

Re: [PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions

2007-11-19 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 21:59:58 -0800 > > I'm dropping these patches for now. > > Is the use of "is_ip4_" not "ipv4_is_" > your reason to drop the patches? Yes. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH] Time-based RFC 4122 UUID generator

2007-11-19 Thread Andrew Morton
On Sun, 18 Nov 2007 20:38:21 +0100 Helge Deller <[EMAIL PROTECTED]> wrote: > Andrew, > > could you please consider adding this patch to your 2.6.25 patch series? please cc netdev on networking-related things > This is the third version of the patch in which I cleaned up and fixed quite > some

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-19 Thread David Miller
From: Bill Fink <[EMAIL PROTECTED]> Date: Tue, 20 Nov 2007 00:29:45 -0500 > But the best approach seems to be just not to count > it in the first place until tha application has actually received > the packet, since as Herbert pointed out, that's what the RFC > actually specifies for the meaning o

Re: [PATCH] LRO ack aggregation

2007-11-19 Thread Herbert Xu
David Miller <[EMAIL PROTECTED]> wrote: > > Fundamentally, I really don't like this change, it batches to the > point where it begins to erode the natural ACK clocking of TCP, and I > therefore am very likely to revert it before merging to Linus. Perhaps make it a tunable that defaults to off? Ch

Re: [RFC PATCH 09/10] [TCP]: Rewrite SACK block processing & sack_recv_cache use

2007-11-19 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Fri, 16 Nov 2007 15:44:40 +0200 (EET) > Besides the log(n) search for which patches already exists, only O(new > information) scan start..end range would be necessary. Or had you > something else in mind (I'm not that sure what the "ideas", in plur

Re: [MACVLAN 02/02]: Allow setting mac address while device is up

2007-11-19 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 15 Nov 2007 16:54:32 +0100 (MET) > [MACVLAN]: Allow setting mac address while device is up > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> I'll apply this to net-2.6.25 as well, thanks! - To unsubscribe from this list: send the line "un

Re: [PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions

2007-11-19 Thread Joe Perches
On Mon, 2007-11-19 at 21:46 -0800, David Miller wrote: > I would also change the names, it's a better idea to prefix the > names with a namespace for the stuff being operated on, therefore > I'd prefer names like "ipv4_is_loopback()" etc. I used: +static inline bool is_ip4_loopback(__be32 addr)

Re: [MACVLAN 01/02]: Remove unnecessary IFF_UP check

2007-11-19 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 15 Nov 2007 16:54:30 +0100 (MET) > [MACVLAN]: Remove unnecessary IFF_UP check > > Only devices that are UP are in the hash, so macvlan_broadcast() doesn't > need to check for IFF_UP. > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Appl

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier

2007-11-19 Thread David Miller
From: Francois Romieu <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 23:11:19 +0100 > Rainer Jochem <[EMAIL PROTECTED]> : > [...] > > --- net/ipv4/ipconfig.c.orig2007-11-14 09:16:15.800566536 +0100 > > +++ net/ipv4/ipconfig.c 2007-11-14 10:34:22.471219274 +0100 > > @@ -139,6 +139,8 @@ __be

Re: [PATCH 1/5] powerpc: document rgmii-rxid and rgmii-txid phy-connection-types

2007-11-19 Thread Kumar Gala
On Mon, 5 Nov 2007, Kim Phillips wrote: > A h/w bug requires we program the PHY in RGMII mode for internal delay > on the receive or transmit side only; document the new property values. > > Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> > --- > Documentation/powerpc/booting-without-of.txt |

Re: [PATCH 5/5] powerpc: handle mpc8360 rev. 2.1 RGMII timing erratum

2007-11-19 Thread Kumar Gala
On Mon, 5 Nov 2007, Kim Phillips wrote: > if on a rev. 2.1, adjust UCC clock and data timing characteristics > as specified in the rev.2.1 erratum #2. > > Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> > --- > arch/powerpc/platforms/83xx/mpc836x_mds.c | 31 ++-- > 1 fil

Re: [patch 2/2] ipvs: Create synced connections with their real state

2007-11-19 Thread David Miller
From: Simon Horman <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 10:24:41 -0800 > With this patch the synced connections are created with their real state, > which can be changed on the next synchronizations if necessary. This way > on fail-over all the connections will be treated according to their

Re: [patch 1/2] ipvs: Flag synced connections and expose them in proc

2007-11-19 Thread David Miller
From: Simon Horman <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 10:24:40 -0800 > From: Rumen Bogdanovski <[EMAIL PROTECTED]> > > This patch labels the sync-created connections with IP_VS_CONN_F_SYNC > flag and creates /proc/net/ip_vs_conn_sync to enable monitoring of the > origin of the connections

Re: [patch 3/3] IPVS: Move remaining sysctl handlers over to CTL_UNNUMBERED

2007-11-19 Thread David Miller
From: Simon Horman <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 10:06:18 -0800 > Switch the remaining IPVS sysctl entries over to to use CTL_UNNUMBERED, > I stronly doubt that anyone is using the sys_sysctl interface to > these variables. > > Cc: Eric W. Biederman <[EMAIL PROTECTED]> > Cc: Wensong

Re: [patch 2/3] IPVS: Fix sysctl warnings about missing strategy in schedulers

2007-11-19 Thread David Miller
From: Simon Horman <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 10:06:17 -0800 > sysctl table check failed: /net/ipv4/vs/lblc_expiration .3.5.21.19 Missing > strategy > [...] > sysctl table check failed: /net/ipv4/vs/lblcr_expiration .3.5.21.20 Missing > strategy > > Switch these entried over to

Re: [patch 1/3] IPVS: Fix sysctl warnings about missing strategy

2007-11-19 Thread David Miller
From: Simon Horman <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 10:06:16 -0800 > From: Christian Borntraeger <[EMAIL PROTECTED]> > > Running the latest git code I get the following messages during boot: > sysctl table check failed: /net/ipv4/vs/drop_entry .3.5.21.4 Missing strategy > [...]

Re: [PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions

2007-11-19 Thread David Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 08:53:13 -0800 > Maybe I'm more used to hex, but I personally don't think those are > more readable. It replaces 1-line macroes with 4-line functions, and > I think more vgrepping to pick out the relevant constant data. Yes, the reada

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-19 Thread Bill Fink
On Mon, 19 Nov 2007, David Miller wrote: > From: Andi Kleen <[EMAIL PROTECTED]> > Date: Mon, 19 Nov 2007 16:29:33 +0100 > > > > > > > > > > > All of our options suck, we just have to choose the least sucking one > > > > > and right now to me that's decrementing the counter as much as I > > > > >

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

2007-11-19 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Thu, 8 Nov 2007 04:30:10 +0100 > @davem: > > Please look at net/ipv4/arp.c:arp_process() > > Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or > CONFIG_NETDEV_1=y will not be handled correctly there? > > And the best solution is t

Re: Please pull 'upstream-davem' branch of wireless-2.6

2007-11-19 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Tue, 6 Nov 2007 22:08:53 -0500 > Individual patches are available here: > > > http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-davem ... > > Mattias Nissler (1): > mac80211: Accept auto txpower setting >

Re: [PATCH 1/1]: SAs created although tmpl->optional set

2007-11-19 Thread Joy Latten
>Heh I made the same mistake when I first read this piece of >code too :) The optional flag isn't saying that it doesn't need >to be protected, but rather that the SA may not be present on >input. It's only used for IPComp where we may skip the IPComp >if the data is not compressible. > >In other

Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (was: Strange behavior in arp probe reply, bug or feature?)

2007-11-19 Thread Bill Fink
On Mon, 19 Nov 2007, Alexey Kuznetsov wrote: > Hello! > > > Is there a reason that the target hardware address isn't the target > > hardware address? > > It is bound only to the fact that linux uses protocol address > of the machine, which responds. It would be highly confusing > (more than conf

Re: [PATCH] LRO ack aggregation

2007-11-19 Thread David Miller
From: Andrew Gallatin <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 11:11:55 -0400 > I've attached a patch which adds support to inet_lro for aggregating > pure acks. I've applied this patch to net-2.6.25... but! This needs some serious thinking. What this patch ends up doing is creating big stret

[PATCH] Add packet filtering based on process\'s security context.

2007-11-19 Thread Tetsuo Handa
This patch allows LSM modules filter incoming connections/datagrams based on the process's security context who is attempting to pick up. There are already hooks to filter incoming connections/datagrams based on the socket's security context, but these hooks are not applicable when one wants to do

Re: [PATCH 09/11] netpoll: ethernet devices only

2007-11-19 Thread Stephen Hemminger
On Mon, 19 Nov 2007 19:55:15 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Sat, 03 Nov 2007 11:43:23 -0700 > > > Netpoll only works on Ethernet devices, so check during setup > > rather than just failing silently later. > > > > Signed-o

Re: [PATCH 06/11] netpoll: remove dev_name for npinfo

2007-11-19 Thread Stephen Hemminger
On Mon, 19 Nov 2007 19:47:50 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Sat, 03 Nov 2007 11:43:20 -0700 > > > The device name was only in npinfo for netconsole target > > configuration, so move it to netconsole. Netconsole only > > n

Re: [PATCH 11/11] netpoll: rx use RCU

2007-11-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Sat, 03 Nov 2007 11:43:25 -0700 > Get rid of rx_lock and use Read-Copy-Update to make sure > that netpoll info and rx handle are not used after free. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Please also respin this one too, thanks

Re: [PATCH 10/11] netpoll: rx optimization

2007-11-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Sat, 03 Nov 2007 11:43:24 -0700 > This patch makes netpoll work for non-NAPI devices that call > netif_receive_skb. Devices are allowed to call netif_receive_skb > if they are receiving packets in softirq (ie in tasklet). > One side effect of this

Re: [PATCH 09/11] netpoll: ethernet devices only

2007-11-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Sat, 03 Nov 2007 11:43:23 -0700 > Netpoll only works on Ethernet devices, so check during setup > rather than just failing silently later. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > --- a/net/core/netpoll.c 2007-11-03 11:05

Re: [PATCH 08/11] netpoll: NETPOLL_TRAP configuration change

2007-11-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Sat, 03 Nov 2007 11:43:22 -0700 > --- a/drivers/net/Kconfig 2007-11-03 11:30:57.0 -0700 > +++ b/drivers/net/Kconfig 2007-11-03 11:30:59.0 -0700 > @@ -3118,8 +3118,8 @@ config NETCONSOLE_DYNAMIC > config NETPOLL > def_

[PATCH] ibm_newemac: Fix possible lockup on close

2007-11-19 Thread Benjamin Herrenschmidt
It's a bad idea to call flush_scheduled_work from within a netdev->stop because the linkwatch will occasionally take the rtnl lock from a workqueue context, and thus that can deadlock. This reworks things a bit in that area to avoid the problem. Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTE

Re: [PATCH 07/11] netpoll: get rid of name parameter

2007-11-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Sat, 03 Nov 2007 11:43:21 -0700 > The name was being stored and used only for error messages. > The same effect can be had by just passing it in where needed during > config. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> The whole worl

Re: [PATCH 06/11] netpoll: remove dev_name for npinfo

2007-11-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Sat, 03 Nov 2007 11:43:20 -0700 > The device name was only in npinfo for netconsole target > configuration, so move it to netconsole. Netconsole only > needs the value during config, so no need to do all > the device name tracking etc.. > > Make

Re: [PATCH 05/11] netpoll: dont need rx_flags

2007-11-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Sat, 03 Nov 2007 11:43:19 -0700 > The rx_flags variable is redundant. Turning rx on/off is done > via setting the rx_np pointer. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Not all of these transformations are equivalent, and as a re

Re: [PATCH 04/11] netpoll: alternative implementation of dropping

2007-11-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Sat, 03 Nov 2007 11:43:18 -0700 > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied to net-2.6.25, but I gave the changelog a more descriptive headline: [NETPOLL]: Kill NETPOLL_RX_DROP, set but never tested. Thanks. - To unsub

Re: [PATCH 03/11] netpoll: no need to store local_mac

2007-11-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Sat, 03 Nov 2007 11:43:17 -0700 > The local_mac is managed by the network device, no need to > keep a spare copy and all the management problems that could > cause. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied to net-2.6.25, t

Re: [PATCH 02/11] netpoll: netpoll_poll cleanup

2007-11-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Sat, 03 Nov 2007 11:43:16 -0700 > Restructure code slightly to improve readability: > * dereference device once > * change obvious while() loop > * let poll_napi() handle null list itself > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTE

Re: [PATCH 01/11] netpoll: use skb_queue_purge

2007-11-19 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Sat, 03 Nov 2007 11:43:15 -0700 > Use standard route for flushing queue. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied to net-2.6.25, thanks! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH][IPVS] Relax the module get/put in ip_vs_app.c

2007-11-19 Thread Simon Horman
On Mon, Nov 19, 2007 at 12:58:14PM +0300, Pavel Emelyanov wrote: > Both try_module_get/module_put already handle the module == NULL > case, so no need in manual checking. > > This patch fits both net-2.6 and net-2.6.25. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Thanks, that looks fi

Re: reproducible cxgb kernel panic in FC8 kernel 2.6.23.1-49

2007-11-19 Thread Ben Greear
Divy Le Ray wrote: Ben Greear wrote: This panic happens (almost?) immediately after starting TCP traffic between the cxgb nic on this system and another. We also got at least one crash on a custom/tainted 2.6.20.12 kernel, but it would run for at least a few minutes at ~1Gbps first. I think m

[PATCH 54/59] net/irda: Add missing "space"

2007-11-19 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/irda/iriap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/irda/iriap.c b/net/irda/iriap.c index dc5e34a..a86a5d8 100644 --- a/net/irda/iriap.c +++ b/net/irda/iriap.c @@ -928,7 +928,7 @@ void iriap_call_indicat

[PATCH 52/59] net/ipv4: Add missing "space"

2007-11-19 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/ipv4/ipvs/ip_vs_core.c |2 +- net/ipv4/netfilter/iptable_raw.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ipvs/ip_vs_core.c b/net/ipv4/ipvs/ip_vs_core.c index 20c884a..8fba202 100644 --- a/net

[PATCH 56/59] net/sunrpc: Add missing "space"

2007-11-19 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/sunrpc/auth_gss/auth_gss.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c index 53995af..22906b8 100644 --- a/net/sunrpc/auth_gss/auth_gss.c +++ b/net/

[PATCH 51/59] net/dccp: Add missing "space"

2007-11-19 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/dccp/ccids/lib/loss_interval.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/dccp/ccids/lib/loss_interval.c b/net/dccp/ccids/lib/loss_interval.c index 40ad428..d26b88d 100644 --- a/net/dccp/ccids/lib/loss_inte

[PATCH 53/59] net/ipv6: Add missing "space"

2007-11-19 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/ipv6/addrconf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 1bd8d81..567664e 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -967,7 +967,7 @@ int ipv6

[PATCH 55/59] net/sctp: Add missing "space"

2007-11-19 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/sctp/sm_statefuns.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index 5ebbe80..b8bbb96 100644 --- a/net/sctp/sm_statefuns.c +++ b/net/sctp/sm_statefuns.c @@ -1146

[PATCH 50/59] net/bridge: Add missing "space"

2007-11-19 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/bridge/netfilter/ebt_among.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/bridge/netfilter/ebt_among.c b/net/bridge/netfilter/ebt_among.c index 392d877..6436d30 100644 --- a/net/bridge/netfilter/ebt_among.c ++

[PATCH 36/59] drivers/net: Add missing "space"

2007-11-19 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/3c507.c |4 ++-- drivers/net/amd8111e.c |4 ++-- drivers/net/at1700.c|2 +- drivers/net/pppol2tp.c |2 +- drivers/net/qla3xxx.c |2 +- drivers/net/rrunner.c |2 +- drivers/net/s2io.c |6 +

[PATCH 33/59] drivers/net/sk98lin: Add missing "space"

2007-11-19 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/sk98lin/skgepnmi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sk98lin/skgepnmi.c b/drivers/net/sk98lin/skgepnmi.c index b36dd9a..678659f 100644 --- a/drivers/net/sk98lin/skgepnmi.c +++ b/driv

[PATCH 34/59] drivers/net/wan: Add missing "space"

2007-11-19 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/wan/wanxl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c index 8e320b7..ad8c865 100644 --- a/drivers/net/wan/wanxl.c +++ b/drivers/net/wan/wanxl.c @@ -743,

  1   2   >