On Mon, 19 Nov 2007 19:47:50 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote:
> From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Sat, 03 Nov 2007 11:43:20 -0700 > > > The device name was only in npinfo for netconsole target > > configuration, so move it to netconsole. Netconsole only > > needs the value during config, so no need to do all > > the device name tracking etc.. > > > > Make functions for common code for instantiation and > > start up. > > > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > Sigh... > > return -EUNTESTED; > > In netpoll_parse_options() np->dev isn't setup yet, so if you had > tested this patch you would have gotten an immediate OOPS. Sorry, I missed the boot up case, I was testing with modprobe and dyanmic reconfig stuff. Places that store the name (and then get confused by renames) are one of the lingering mis-features of the whole network device infrastructure. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
