Re: [PATCH] NET : rt_check_expire() can take a long time, add a cond_resched()

2007-11-14 Thread Herbert Xu
Andi Kleen <[EMAIL PROTECTED]> wrote: > > A cheaper change might have been to just limit the number of buckets > scanned. Actually the whole point of moving it out to process context is so that we don't have to worry about keeping track of the number of buckets since deciding on how many buckets t

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-11-14 Thread Oliver Hartkopp
Stephen Hemminger wrote: >> +#ifdef CONFIG_CAN_DEBUG_CORE >> +extern void can_debug_skb(struct sk_buff *skb); >> +extern void can_debug_cframe(const char *msg, struct can_frame *cframe); >> +#define DBG(fmt, args...) (DBG_VAR & 1 ? printk( \ >> +KERN_DEBUG DBG_P

Re: [PATCH] NET : rt_check_expire() can take a long time, add a cond_resched()

2007-11-14 Thread Andi Kleen
Eric Dumazet <[EMAIL PROTECTED]> writes: > > Using a "if (need_resched())" test before calling "cond_resched();" is > necessary to avoid spending too much time doing the resched check. The only difference between cond_resched() and if (need_resched()) cond_resched() is one function call less and o

[PATCH 01/01] iproute2-2.6.23: RFC4214 Support (v2.2)

2007-11-14 Thread Templin, Fred L
From: Fred L. Templin <[EMAIL PROTECTED]> This patch includes support for the Intra-Site Automatic Tunnel Addressing Protocol (ISATAP) per RFC4214. The following diffs are specific to the iproute2-2.6.23 software distribution. This message includes the full and patchable diff text; please use thi

[PATCH 01/01] ipv6: RFC4214 Support (v2.2)

2007-11-14 Thread Templin, Fred L
From: Fred L. Templin <[EMAIL PROTECTED]> This patch includes support for the Intra-Site Automatic Tunnel Addressing Protocol (ISATAP) per RFC4214. It uses the SIT module, and is configured using extensions to the "iproute2" utility. The following diffs are specific to the Linux 2.6.24-rc2 kernel

Re: Moderated list

2007-11-14 Thread Rene Herman
On 15-11-07 00:23, David Miller wrote: From: Takashi Iwai <[EMAIL PROTECTED]> BTW, I also prefer keeping the name [EMAIL PROTECTED] It's been so. That's fine with me, I've changed it [EMAIL PROTECTED] Great, thanks. Jaroslav -- given that this list won't need moderation I'd consider it

Re: [alsa-devel] [BUG] New Kernel Bugs

2007-11-14 Thread Rene Herman
On 15-11-07 05:16, Bron Gondwana wrote: Totally unrelated - I sent something to the kolab mailing list a couple [ ... ] I'm sure if I had something that I considered worth informing the ALSA project of, I'd be wary of spending the same effort writing a good post knowing it may be dropped in

Re: [PATCH] NET: Officially deprecate "ether=" in favour of "netdev=".

2007-11-14 Thread Robert P. J. Day
On Wed, 14 Nov 2007, Stephen Hemminger wrote: ... relevant patch snipped ... > Why bother. I would removing it? i tried that once, and a number of people promptly had kittens over the thought of simply yanking a working kernel parameter without giving everyone at least a year's notice. rday ==

Re: [PATCH] NET: Officially deprecate "ether=" in favour of "netdev=".

2007-11-14 Thread Stephen Hemminger
Robert P. J. Day wrote: Given that it's well established that the "ether=" kernel parameter is deprecated in favour of the newer "netdev=", might as well make it official. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- Documentation/feature-removal-schedule.txt |6 ++ Documen

Re: [alsa-devel] [BUG] New Kernel Bugs

2007-11-14 Thread Bron Gondwana
On Wed, Nov 14, 2007 at 12:46:24PM +0100, Rene Herman wrote: > On 14-11-07 11:07, David Miller wrote: > > Added Jaroslav and Takashi to the already extensive CC > >> From: Russell King <[EMAIL PROTECTED]> > >>> So, when are you creating a replacement alsa-devel mailing list on >>> vger? That's

[PATCH] NET: Officially deprecate "ether=" in favour of "netdev=".

2007-11-14 Thread Robert P. J. Day
Given that it's well established that the "ether=" kernel parameter is deprecated in favour of the newer "netdev=", might as well make it official. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- Documentation/feature-removal-schedule.txt |6 ++ Documentation/kernel-parameters.

net-2.6.25 rebased...

2007-11-14 Thread David Miller
Since Linus sucked in all of my fixes a few moments ago I took the opportunity to rebase the net-2.6.25 tree. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] via-velocity: don't oops on MTU change.

2007-11-14 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 19:38:44 -0800 > Simple mtu change when device is down. > Fix http://bugzilla.kernel.org/show_bug.cgi?id=9382. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied. Thanks for looking at this bug so quickly Stephen.

Re: Please pull 'fixes-davem' branch of wireless-2.6

2007-11-14 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 21:51:50 -0500 > Here are a few fixes for 2.6.24. I don't think there is anything > controversial here. ... > The following changes since commit dbeeb816e805091e7cfc03baf36dc40b4adb2bbd: > Linus Torvalds (1): > Linux 2

[PATCH] via-velocity: don't oops on MTU change.

2007-11-14 Thread Stephen Hemminger
Simple mtu change when device is down. Fix http://bugzilla.kernel.org/show_bug.cgi?id=9382. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/via-velocity.c2007-10-22 09:38:11.0 -0700 +++ b/drivers/net/via-velocity.c2007-11-14 19:34:30.0 -0800

Re: network interface state

2007-11-14 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 15 Nov 2007 10:11:35 +0800 > David Miller <[EMAIL PROTECTED]> wrote: > > > >> BTW, is it possible to send both these requests out before starting to > >> read the results? This would reduce the amount of code quite a bit. > > > > Unfortunately, tha

Re: [Bugme-new] [Bug 9382] New: etting MTU > 1500 on card "cold" sigsegs the "ip" program and produces an OOPS.

2007-11-14 Thread Andrew Morton
On Wed, 14 Nov 2007 19:11:38 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9382 > >Summary: etting MTU > 1500 on card "cold" sigsegs the "ip" > program and produces an OOPS. >Product: Drivers >Version: 2.5

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Neil Brown
On Tuesday November 13, [EMAIL PROTECTED] wrote: > On Tuesday 13 November 2007 07:08, Mark Lord wrote: > > Ingo Molnar wrote: > > .. > > > > > This is all QA-101 that _cannot be argued against on a rational basis_, > > > it's just that these sorts of things have been largely ignored for > > > years

Please pull 'fixes-davem' branch of wireless-2.6

2007-11-14 Thread John W. Linville
Dave, Here are a few fixes for 2.6.24. I don't think there is anything controversial here. Thanks, John --- Individual patches are available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/fixes-davem/ --- The following changes since commit dbeeb816e80509

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Neil Brown
On Wednesday November 14, [EMAIL PROTECTED] wrote: > On Wed, Nov 14, 2007 at 09:38:20AM -0800, Randy Dunlap wrote: > > On Wed, 14 Nov 2007 15:08:47 +0100 Ingo Molnar wrote: > > > so please stop this "too busy and too noisy" nonsense already. It was > > > nonsense 10 years ago and it's nonsense tod

Re: network interface state

2007-11-14 Thread Herbert Xu
David Miller <[EMAIL PROTECTED]> wrote: > >> BTW, is it possible to send both these requests out before starting to >> read the results? This would reduce the amount of code quite a bit. > > Unfortunately, that won't work. Like datagram protocols, > netlink assumes one message per sendmsg() call

Re: [PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions

2007-11-14 Thread Joe Perches
Sorry, evolution died sending my mail and I didn't fully read the "recovered" mail before hitting send. Here's a more readable one. - On Wed, 2007-11-14 at 08:53 -0800, David Stevens wrote: > Maybe I'm more used to hex, but I personally don't think those are > more readable. It replaces

Re: [PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions

2007-11-14 Thread Joe Perches
On Wed, 2007-11-14 at 08:53 -0800, David Stevens wrote: > Maybe I'm more used to hex, but I personally don't think those are > more readable. It replaces 1-line macroes with 4-line functions, and > I think more vgrepping to pick out the relevant constant data. The rfcs generally use decimal octet

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Nick Piggin
On Thursday 15 November 2007 12:11, Herbert Xu wrote: > On Wed, Nov 14, 2007 at 05:03:25PM -0800, Christoph Lameter wrote: > > Well this is likely the result of the SLUB regression. If you allocate an > > order 1 page then the zone locks need to be taken. SLAB queues the a Yeah, it appears this is

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Simon Horman
On Wed, Nov 14, 2007 at 06:25:00PM -0700, Eric W. Biederman wrote: > Simon Horman <[EMAIL PROTECTED]> writes: > > > On Thu, Nov 15, 2007 at 02:38:32AM +0200, Julian Anastasov wrote: > > > > Hi Julian, > > > >> On Tue, 13 Nov 2007, Simon Horman wrote: > > > > [snip] > > > >> > As for the commented

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Eric W. Biederman
Simon Horman <[EMAIL PROTECTED]> writes: > On Thu, Nov 15, 2007 at 02:38:32AM +0200, Julian Anastasov wrote: > > Hi Julian, > >> On Tue, 13 Nov 2007, Simon Horman wrote: > > [snip] > >> > As for the commented out entries. They are supposed to be exposed by >> > some other means - I believe the thi

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Simon Horman
On Thu, Nov 15, 2007 at 02:38:32AM +0200, Julian Anastasov wrote: Hi Julian, > On Tue, 13 Nov 2007, Simon Horman wrote: [snip] > > As for the commented out entries. They are supposed to be exposed by > > some other means - I believe the thinking was to comply with the don't > > expose stuff in

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Eric W. Biederman
Julian Anastasov <[EMAIL PROTECTED]> writes: > I assume /proc/sys is still valid place, only sysctl interface > is scheduled for removal. Yes. The ascii versions of the sysctls that show up in /proc/sys are definitely still valid. > So, as long as these entries are not > accessible from s

Re: [PATCH] Fix warning for token-ring from sysctl checker

2007-11-14 Thread Eric W. Biederman
Olof Johansson <[EMAIL PROTECTED]> writes: > On Wed, Nov 14, 2007 at 08:45:28AM -0800, Randy Dunlap wrote: >> On Wed, 14 Nov 2007 08:56:20 -0700 Eric W. Biederman wrote: >> >> > David Miller <[EMAIL PROTECTED]> writes: >> > >> > > From: Olof Johansson <[EMAIL PROTECTED]> >> > > Date: Tue, 13 Nov

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Herbert Xu
On Wed, Nov 14, 2007 at 05:03:25PM -0800, Christoph Lameter wrote: > > Well this is likely the result of the SLUB regression. If you allocate an > order 1 page then the zone locks need to be taken. SLAB queues the a > couple of higher order pages and can so serve a couple of requests without >

Re: [PATCH 2/5] accounting unit and variable

2007-11-14 Thread Herbert Xu
On Wed, Nov 14, 2007 at 06:30:51PM -0500, Hideo AOKI wrote: > > +#define SK_DATAGRAM_MEM_QUANTUM ((unsigned int)PAGE_SIZE) > + > +static inline int sk_datagram_pages(int amt) > +{ > + /* Cast to unsigned as an optimization, since amt is always > positive. */ > + return DIV_ROUND_UP((unsign

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Christoph Lameter
On Wed, 14 Nov 2007, David Miller wrote: > > As a result, we may allocate more than a page of data in the > > non-TSO case when exactly one page is desired. Well this is likely the result of the SLUB regression. If you allocate an order 1 page then the zone locks need to be taken. SLAB queues th

Re: [PATCH] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Julian Anastasov
Hello, On Tue, 13 Nov 2007, Simon Horman wrote: > > > Running the latest git code I get the following messages during boot: > > > sysctl table check failed: /net/ipv4/vs/drop_entry .3.5.21.4 Missing > > > strategy > > > [...] > > > sysctl table check failed: /net/ipv4/vs/

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread David Miller
From: Nick Piggin <[EMAIL PROTECTED]> Date: Thu, 15 Nov 2007 11:21:36 +1100 > On Thursday 15 November 2007 10:46, David Miller wrote: > > From: Herbert Xu <[EMAIL PROTECTED]> > > Date: Wed, 14 Nov 2007 19:48:44 +0800 > > > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > > > Applied and I'll q

Re: [PATCH] Fix warning for token-ring from sysctl checker

2007-11-14 Thread Olof Johansson
On Wed, Nov 14, 2007 at 08:45:28AM -0800, Randy Dunlap wrote: > On Wed, 14 Nov 2007 08:56:20 -0700 Eric W. Biederman wrote: > > > David Miller <[EMAIL PROTECTED]> writes: > > > > > From: Olof Johansson <[EMAIL PROTECTED]> > > > Date: Tue, 13 Nov 2007 01:23:13 -0600 > > > > > >> As seen when booti

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Nick Piggin
On Thursday 15 November 2007 10:46, David Miller wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Wed, 14 Nov 2007 19:48:44 +0800 > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > Applied and I'll queue it up for -stable too. Good result. Thanks, everyone! - To unsubscribe from this list

Re: network interface state

2007-11-14 Thread David Miller
From: Ulrich Drepper <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 16:12:28 -0800 > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > David Miller wrote: > > Most daemons handle this by listening for events on the netlink > > socket, but I understand how that might not be practical for > > glibc.

Re: network interface state

2007-11-14 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 David Miller wrote: > Most daemons handle this by listening for events on the netlink > socket, but I understand how that might not be practical for > glibc. Right, this cannot work. I have no inner loop which I can control. I cannot install a liste

Re: [PATCH 2/2][INET] Move the reqsk_queue_yank_listen_sk from header

2007-11-14 Thread Simon Horman
On Wed, Nov 14, 2007 at 09:11:06PM +0300, Pavel Emelyanov wrote: > This function is used in the net/core/request_sock.c only. > No need in keeping it in the header file. I feel like I am missing something here, but doesn't __reqsk_queue_destroy() in include/net/request_sock.h use reqsk_queue_yank

Re: [PATCH] NET : rt_check_expire() can take a long time, add a cond_resched()

2007-11-14 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 22:34:13 +0100 > On commit 39c90ece7565f5c47110c2fa77409d7a9478bd5b we converted > rt_check_expire() from softirq to workqueue, allowing the function to perform > all work it was supposed to do. > > When the IP route cache is big, rt

Re: [PATCH 1/2][INET] Fix potential kfree on vmalloc-ed area of request_sock_queue

2007-11-14 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 20:42:38 +0100 > On Wed, 14 Nov 2007 21:08:29 +0300 > Pavel Emelyanov <[EMAIL PROTECTED]> wrote: > > > The request_sock_queue's listen_opt is either vmalloc-ed or > > kmalloc-ed depending on the number of table entries. Thus it > > is

Re: [PATCH] Use sockfd_lookup_light in the rest of the net/socket.c

2007-11-14 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 19:42:18 +0300 > Some time ago a sockfd_lookup_light was introduced and > most of the socket.c file was patched to use it. However > two routines were left - sys_sendto and sys_recvfrom. > > Patch them as well, since this helper doe

Re: Re : Oops preceded by WARNING: at net/ipv4/tcp_input.c:1571 tcp_remove_reno_sacks()

2007-11-14 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 15:32:58 +0200 (EET) > [PATCH] [TCP] FRTO: Clear frto_highmark only after process_frto that uses it > > I broke this in commit 3de96471bd7fb76406e975ef6387abe3a0698149. > tcp_process_frto should always see a valid frto_highmark. An

Re: [PATCH] Remove notifier block from chain when register_netdevice_notifier fails

2007-11-14 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 21:37:17 +0800 > Acked-by: Herbert Xu <[EMAIL PROTECTED]> Indeed, good catch, patch applied. Thanks! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info a

Re: [PATCH] Use sockfd_lookup_light in the rest of the net/socket.c

2007-11-14 Thread Simon Horman
On Wed, Nov 14, 2007 at 07:42:18PM +0300, Pavel Emelyanov wrote: > Some time ago a sockfd_lookup_light was introduced and > most of the socket.c file was patched to use it. However > two routines were left - sys_sendto and sys_recvfrom. > > Patch them as well, since this helper does exactly what >

Re: [PATCH] powerpc: Fix fs_enet module build

2007-11-14 Thread David Miller
From: Jochen Friedrich <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 12:59:33 +0100 > I know it's ugly, however, module building is completely > broken right now and I just want to provide a quick and > ugly fix until both that ppc->powerpc transition and the > new binding transition are over. Noone

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 19:48:44 +0800 > [TCP]: Fix size calculation in sk_stream_alloc_pskb > > We round up the header size in sk_stream_alloc_pskb so that > TSO packets get zero tail room. Unfortunately this rounding > up is not coordinated with the select_s

Re: [PATCH 2/5] accounting unit and variable

2007-11-14 Thread Hideo AOKI
Hideo AOKI wrote: David Miller wrote: From: Hideo AOKI <[EMAIL PROTECTED]> Date: Tue, 13 Nov 2007 22:27:13 -0500 Herbert Xu wrote: On Mon, Oct 29, 2007 at 05:23:10PM -0400, Hideo AOKI wrote: +#define SK_DATAGRAM_MEM_QUANTUM ((int)PAGE_SIZE) + +static inline int sk_datagram_pages(int amt) +

Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode

2007-11-14 Thread Kok, Auke
Patrick McHardy wrote: > Kok, Auke wrote: >> Patrick McHardy wrote: >>> Kok, Auke wrote: Patrick McHardy wrote: > I already posted a patch for this, not sure what happened to it. > Auke, any news on merging the secondary unicast address support? I dropped the ball on that one

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Daniel Barkalow
On Tue, 13 Nov 2007, Theodore Tso wrote: > There are two parts to this. One is a Ubuntu development kernel which > we can give to large numbers of people to expand our testing pool. > But if we don't do a better job of responding to bug reports that > would be generated by expanded testing this w

Re: network interface state

2007-11-14 Thread David Miller
From: Ulrich Drepper <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 12:59:52 -0800 > Just FYI, with the current getaddrinfo code it is even more critical to > get to a point where I can cache network interface information and query > the kernel whether it changed. We now have to read the RTM_GETADDR

Re: Null pointer dereference in nf_nat_move_storage(), kernel 2.6.23.1

2007-11-14 Thread Chuck Ebbert
On 11/14/2007 01:03 PM, Chuck Ebbert wrote: [adding proper address for netfilter; oops has been debugged down to file and line number bewlow] > https://bugzilla.redhat.com/show_bug.cgi?id=259501#c14 > > BUG: unable to handle kernel NULL pointer dereference at virtual address > 064 > print

Re: Moderated list

2007-11-14 Thread David Miller
From: Takashi Iwai <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 10:47:39 +0100 > I think alsa-user can stay as is. It's no place for dragging many > other addresses like alsa-devel. > > BTW, I also prefer keeping the name [EMAIL PROTECTED] It's been so. That's fine with me, I've changed it [EMAI

RE: [PATCH 2.6.24 1/1]S2io: Support for add/delete/store/restore ethernet addresses

2007-11-14 Thread Ramkrishna Vepa
Got it. Thanks, Ram > -Original Message- > From: David Miller [mailto:[EMAIL PROTECTED] > Sent: Wednesday, November 14, 2007 2:56 PM > To: Ramkrishna Vepa > Cc: Sreenivasa Honnur; netdev@vger.kernel.org; [EMAIL PROTECTED]; support > Subject: Re: [PATCH 2.6.24 1/1]S2io: Support for add/dele

Re: [PATCH 2.6.24 1/1]S2io: Support for add/delete/store/restore ethernet addresses

2007-11-14 Thread David Miller
From: "Ramkrishna Vepa" <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 15:57:23 -0500 > [Ram] The version numbers are different for the 2 patches. Was the MSI-X > leak bug fix applied prior to resubmission (we had swapped the version > numbers on the patches for resubmission). > > [PATCH 2.6.24 1/1]S

Re: [PATCH] ipconfig.c : implement DHCP Class-identifier

2007-11-14 Thread Francois Romieu
Rainer Jochem <[EMAIL PROTECTED]> : [...] > --- net/ipv4/ipconfig.c.orig 2007-11-14 09:16:15.800566536 +0100 > +++ net/ipv4/ipconfig.c 2007-11-14 10:34:22.471219274 +0100 > @@ -139,6 +139,8 @@ __be32 ic_servaddr = NONE;/* Boot serve > __be32 root_server_addr = NONE; /* Address

[PATCH, take2] netfilter : struct xt_table_info diet

2007-11-14 Thread Eric Dumazet
Hi David & Patrick Please find an updated version of this patch, against net-2.6.25 (relax the check against sizes of loaded tables, using a divide by num_possible_cpus() in place of NR_CPUS) Thank you [PATCH] netfilter : struct xt_table_info diet Instead of using a big array of NR_CPUS en

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-11-14 Thread Stephen Hemminger
On Wed, 14 Nov 2007 13:13:41 +0100 Urs Thuermann <[EMAIL PROTECTED]> wrote: > This patch adds the CAN core functionality but no protocols or drivers. > No protocol implementations are included here. They come as separate > patches. Protocol numbers are already in include/linux/can.h. > > Signed

[PATCH] NET : rt_check_expire() can take a long time, add a cond_resched()

2007-11-14 Thread Eric Dumazet
On commit 39c90ece7565f5c47110c2fa77409d7a9478bd5b we converted rt_check_expire() from softirq to workqueue, allowing the function to perform all work it was supposed to do. When the IP route cache is big, rt_check_expire() can take a long time to run. (default settings : 20% of the hash table

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Randy Dunlap
On Wed, 14 Nov 2007 21:37:37 +0100 Ingo Molnar wrote: > ok, then you conceded it by not replying to it? good ;-) No, I don't intend to carry on this discussion, but I appreciate the smiley. --- ~Randy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [patch 0/3] IPVS: Use CTL_UNNUMBERED

2007-11-14 Thread Eric W. Biederman
Simon Horman <[EMAIL PROTECTED]> writes: > Hi, > > this series of three patches, the first of which is by > Christian Borntraeger, switches IPVS over to use CTL_UNNUMBERED, > removing a lot of unused cruft. Acked-by: "Eric W. Biederman" <[EMAIL PROTECTED]> Looks sane to me. Eric - To unsubscribe

network interface state

2007-11-14 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Just FYI, with the current getaddrinfo code it is even more critical to get to a point where I can cache network interface information and query the kernel whether it changed. We now have to read the RTM_GETADDR tables for every lookup. It was more l

RE: [PATCH 2.6.24 1/1]S2io: Support for add/delete/store/restore ethernet addresses

2007-11-14 Thread Ramkrishna Vepa
> > Scheduling for the 2.6.25 merge window is fine. Curious - why did you > > have to remove the driver version? We use it to keep track of our > > changes submitted. > > Because it conflicted with the driver version bump you did > for the MSI-X leak bug fix. [Ram] The version numbers are differe

Re: [BUG] New Kernel Bugs

2007-11-14 Thread david
On Wed, 14 Nov 2007, Ingo Molnar wrote: Dumping even more crap on lkml is not the answer. that "crap" that i'd like to see dumped upon lkml would be netdev traffic mainly - most of the other kernel development lists (and i'm subscribed to many of them) are low-traffic. netdev is the main reaso

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Ingo Molnar
* James Bottomley <[EMAIL PROTECTED]> wrote: > On Wed, 2007-11-14 at 11:56 -0800, David Miller wrote: > > From: Ingo Molnar <[EMAIL PROTECTED]> > > Date: Wed, 14 Nov 2007 15:08:47 +0100 > > > > > In fact this thread is the very example: David points out that on netdev > > > some of those bugs w

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Ingo Molnar
* David Miller <[EMAIL PROTECTED]> wrote: > From: Ingo Molnar <[EMAIL PROTECTED]> > Date: Wed, 14 Nov 2007 15:08:47 +0100 > > > In fact this thread is the very example: David points out that on netdev > > some of those bugs were already discussed and resolved. Had it been all > > on lkml we'd

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Ingo Molnar
* Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Wed, 14 Nov 2007 21:16:39 +0100 Ingo Molnar wrote: > > > countered by the underlined sentences above, just in case you missed > > it. > > I didn't miss your claim. ok, then you conceded it by not replying to it? good ;-) Ingo - To unsubs

Re: skb processing in SMP kernel

2007-11-14 Thread Stephen Hemminger
On Wed, 14 Nov 2007 21:14:37 +0100 Marek Kierdelewicz <[EMAIL PROTECTED]> wrote: > Hi there, > > I'm looking at file /usr/src/linux/net/core/dev.c > function "int netif_rx(struct sk_buff *skb)" > and following line: > > queue = &__get_cpu_var(softnet_data); > > Is it possible to put skb into t

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Randy Dunlap
On Wed, 14 Nov 2007 21:16:39 +0100 Ingo Molnar wrote: > countered by the underlined sentences above, just in case you missed it. I didn't miss your claim. --- ~Randy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [stable] [PATCH 1/2] forcedeth new mcp79 device ids

2007-11-14 Thread Andrew Morton
On Wed, 14 Nov 2007 10:55:53 -0800 Greg KH <[EMAIL PROTECTED]> wrote: > On Wed, Nov 07, 2007 at 04:58:09PM -0500, Ayaz Abdulla wrote: > > This patch adds new device ids for mcp79 devices. > > > > Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> > > I do not see these patches in Linus's tree yet.

skb processing in SMP kernel

2007-11-14 Thread Marek Kierdelewicz
Hi there, I'm looking at file /usr/src/linux/net/core/dev.c function "int netif_rx(struct sk_buff *skb)" and following line: queue = &__get_cpu_var(softnet_data); Is it possible to put skb into the queue of another CPU then the one servicing the interrupt? (Disclaimer: Yeah, I know it's probabl

Re: [PATCH 05/05] ipv6: RFC4214 Support (3)

2007-11-14 Thread Vlad Yasevich
Stephen Hemminger wrote: > David Miller wrote: >> From: Stephen Hemminger <[EMAIL PROTECTED]> >> Date: Tue, 13 Nov 2007 12:53:12 -0800 >> >> >>> On Fri, 09 Nov 2007 16:35:59 -0800 >>> osprey67 <[EMAIL PROTECTED]> wrote: >>> >>> From: Fred L. Templin <[EMAIL PROTECTED]> This mes

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Ingo Molnar
* Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Wed, 14 Nov 2007 15:08:47 +0100 Ingo Molnar wrote: > > > > > * Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > > > > (and this is in no way directed at the networking folks - it holds > > > > for all of us. I have one main complaint about networkin

Re: [BUG] New Kernel Bugs

2007-11-14 Thread James Bottomley
On Wed, 2007-11-14 at 11:56 -0800, David Miller wrote: > From: Ingo Molnar <[EMAIL PROTECTED]> > Date: Wed, 14 Nov 2007 15:08:47 +0100 > > > In fact this thread is the very example: David points out that on netdev > > some of those bugs were already discussed and resolved. Had it been all > > on

Re: [PATCH 2.6.24 1/1]S2io: Support for add/delete/store/restore ethernet addresses

2007-11-14 Thread David Miller
From: "Ramkrishna Vepa" <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 11:47:34 -0500 > Scheduling for the 2.6.25 merge window is fine. Curious - why did you > have to remove the driver version? We use it to keep track of our > changes submitted. Because it conflicted with the driver version bump you

Re: [BUG] New Kernel Bugs

2007-11-14 Thread David Miller
From: Ingo Molnar <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 15:08:47 +0100 > In fact this thread is the very example: David points out that on netdev > some of those bugs were already discussed and resolved. Had it been all > on lkml we'd all be aware of it. That's a rediculious argument. One

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Russell King
On Wed, Nov 14, 2007 at 01:24:48PM +, Pavel Machek wrote: > Hi! > > > > Suspend to RAM resume hangs on a tickless (NO_HZ) kernel > > > http://bugzilla.kernel.org/show_bug.cgi?id=9275 > > > Kernel: 2.6.23 > > > This is HP notebook nc6320 T2400 945GM > > > > No response from developers > > May

Re: [stable] [NET] random : secure_tcp_sequence_number should not assume CONFIG_KTIME_SCALAR

2007-11-14 Thread Greg KH
On Tue, Nov 13, 2007 at 02:41:19PM +0100, Eric Dumazet wrote: > I discovered one other incorrect use of .tv64 (coming from me, I must > confess) > > I guess this patch is needed for 2.6.24 and stable (2.6.22 & 2.6.23) > > Thank you Thanks for sending this to stable@, but David does a great job o

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Russell King
On Wed, Nov 14, 2007 at 02:07:06AM -0800, David Miller wrote: > From: Russell King <[EMAIL PROTECTED]> > Date: Wed, 14 Nov 2007 09:55:07 + > > > On Tue, Nov 13, 2007 at 05:55:51PM -0800, David Miller wrote: > > > I've created [EMAIL PROTECTED] > > > > By doing so you've just said (implicitly)

Re: [PATCH 1/2][INET] Fix potential kfree on vmalloc-ed area of request_sock_queue

2007-11-14 Thread Eric Dumazet
On Wed, 14 Nov 2007 21:08:29 +0300 Pavel Emelyanov <[EMAIL PROTECTED]> wrote: > The request_sock_queue's listen_opt is either vmalloc-ed or > kmalloc-ed depending on the number of table entries. Thus it > is expected to be handled properly on free, which is done in > the reqsk_queue_destroy(). >

Re: [stable] [PATCH 1/2] forcedeth new mcp79 device ids

2007-11-14 Thread Greg KH
On Wed, Nov 07, 2007 at 04:58:09PM -0500, Ayaz Abdulla wrote: > This patch adds new device ids for mcp79 devices. > > Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> I do not see these patches in Linus's tree yet. Have they just not made it for some reason? thanks, greg k-h - To unsubscribe fro

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Christoph Lameter
On Wed, 14 Nov 2007, David Miller wrote: > > Still interested to know why SLAB didn't see the same thing... > > Yes, I wonder why too. I bet objects just got packed differently. The objects are packed tightly in SLUB and SLUB can allocate smaller objects (minimum is 8 SLAB mininum is 32). On

[patch 1/2] ipvs: Flag synced connections and expose them in proc

2007-11-14 Thread Simon Horman
From: Rumen Bogdanovski <[EMAIL PROTECTED]> This patch labels the sync-created connections with IP_VS_CONN_F_SYNC flag and creates /proc/net/ip_vs_conn_sync to enable monitoring of the origin of the connections, if they are local or created by the synchronization. Signed-off-by: Rumen G. Bogdano

[patch 0/2] ipvs: Expose synced connections in proc

2007-11-14 Thread Simon Horman
Two patches from Rumen Bogdanovski to enhance the connection synchronisation code. Dave, please consider for inclusion, they have been aired on lvs-devel. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line "unsubscribe n

[patch 2/2] ipvs: Create synced connections with their real state

2007-11-14 Thread Simon Horman
With this patch the synced connections are created with their real state, which can be changed on the next synchronizations if necessary. This way on fail-over all the connections will be treated according to their actual state, causing no scheduling problems (the active and the nonactive connect

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Kok, Auke
Denys Vlasenko wrote: > On Wednesday 14 November 2007 00:27, Adrian Bunk wrote: >> You missed the following in my email: >> "we slowly scare them away due to the many bug reports without any >> reaction." >> >> The problem is that bug reports take time. If you go away from easy >> things like comp

Re: [BUG] New Kernel Bugs

2007-11-14 Thread J. Bruce Fields
On Wed, Nov 14, 2007 at 09:38:20AM -0800, Randy Dunlap wrote: > On Wed, 14 Nov 2007 15:08:47 +0100 Ingo Molnar wrote: > > so please stop this "too busy and too noisy" nonsense already. It was > > nonsense 10 years ago and it's nonsense today. In 10 years the kernel > > grew from a 1 million lines

[PATCH 2/2][INET] Move the reqsk_queue_yank_listen_sk from header

2007-11-14 Thread Pavel Emelyanov
This function is used in the net/core/request_sock.c only. No need in keeping it in the header file. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/include/net/request_sock.h b/include/net/request_sock.h index 0a954ee..e80b53f 100644 --- a/include/net/request_sock.h +++ b/in

[PATCH 1/2][INET] Fix potential kfree on vmalloc-ed area of request_sock_queue

2007-11-14 Thread Pavel Emelyanov
The request_sock_queue's listen_opt is either vmalloc-ed or kmalloc-ed depending on the number of table entries. Thus it is expected to be handled properly on free, which is done in the reqsk_queue_destroy(). However the error path in inet_csk_listen_start() calls the lite version of reqsk_queu

[patch 1/3] IPVS: Fix sysctl warnings about missing strategy

2007-11-14 Thread Simon Horman
From: Christian Borntraeger <[EMAIL PROTECTED]> Running the latest git code I get the following messages during boot: sysctl table check failed: /net/ipv4/vs/drop_entry .3.5.21.4 Missing strategy [...] sysctl table check failed: /net/ipv4/vs/drop_packet .3.5.21.5 Missing strategy [...

[patch 3/3] IPVS: Move remaining sysctl handlers over to CTL_UNNUMBERED

2007-11-14 Thread Simon Horman
Switch the remaining IPVS sysctl entries over to to use CTL_UNNUMBERED, I stronly doubt that anyone is using the sys_sysctl interface to these variables. Cc: Eric W. Biederman <[EMAIL PROTECTED]> Cc: Wensong Zhang <[EMAIL PROTECTED]> Cc: Julian Anastasov <[EMAIL PROTECTED]> Cc: Christian Borntraeg

[patch 0/3] IPVS: Use CTL_UNNUMBERED

2007-11-14 Thread Simon Horman
Hi, this series of three patches, the first of which is by Christian Borntraeger, switches IPVS over to use CTL_UNNUMBERED, removing a lot of unused cruft. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To unsubscribe from this list: send the line "unsubscribe

[patch 2/3] IPVS: Fix sysctl warnings about missing strategy in schedulers

2007-11-14 Thread Simon Horman
sysctl table check failed: /net/ipv4/vs/lblc_expiration .3.5.21.19 Missing strategy [...] sysctl table check failed: /net/ipv4/vs/lblcr_expiration .3.5.21.20 Missing strategy Switch these entried over to use CTL_UNNUMBERED as clearly the sys_syscal portion wasn't working. This is along the same

Re: [PATCH] bonding: Documentation update

2007-11-14 Thread Rick Jones
12. Configuring Bonding for Maximum Throughput == @@ -1684,7 +1757,7 @@ balance-rr: This mode is the only mode that will permit a single interfaces. It is therefore the only mode that will allow a single TCP/IP stream to utilize more t

Null pointer dereference in nf_nat_move_storage(), kernel 2.6.23.1

2007-11-14 Thread Chuck Ebbert
https://bugzilla.redhat.com/show_bug.cgi?id=259501#c14 BUG: unable to handle kernel NULL pointer dereference at virtual address 064 printing eip: f8ae1087 *pde = 39644067 Oops: [#1] SMP CPU:1 EIP:0060:[]Not tainted VLI EFLAGS: 00010202 (2.6.23.1-21.fc7 #1) EIP is at

Re: [PATCH] netfilter : struct xt_table_info diet

2007-11-14 Thread Eric Dumazet
On Wed, 14 Nov 2007 18:19:41 +0100 Patrick McHardy <[EMAIL PROTECTED]> wrote: > [netfilter-devel CCed] > > Eric Dumazet wrote: > > Hi David & Patrick > > > > Please find a patch against net-2.6.25 > > > > Thank you > > > > > > [PATCH] netfilter : struct xt_table_info diet > > > > Instead of

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Randy Dunlap
On Wed, 14 Nov 2007 15:08:47 +0100 Ingo Molnar wrote: > > * Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > > (and this is in no way directed at the networking folks - it holds > > > for all of us. I have one main complaint about networking: the > > > separate netdev list is a bad idea - network

Re: [PATCH] netfilter : struct xt_table_info diet

2007-11-14 Thread Patrick McHardy
[netfilter-devel CCed] Eric Dumazet wrote: > Hi David & Patrick > > Please find a patch against net-2.6.25 > > Thank you > > > [PATCH] netfilter : struct xt_table_info diet > > Instead of using a big array of NR_CPUS entries, we can compute the size > needed at runtime, using nr_cpu_ids > >

Re: [PATCH 05/25] NFS: eliminate NIPQUAD(clp->cl_addr.sin_addr)

2007-11-14 Thread Chuck Lever
YOSHIFUJI Hideaki / 吉藤英明 wrote: In article <[EMAIL PROTECTED]> (at Tue, 13 Nov 2007 13:31:27 -0500), Chuck Lever <[EMAIL PROTECTED]> says: clp->rpc_ops->version, - NIPQUAD(clp->cl_addr.sin_addr), - ntohs(clp->cl_addr.sin_port), +

Re: [PATCH net-2.6.25 1/4] include - Convert IP4 address class macros to inline functions

2007-11-14 Thread David Stevens
Maybe I'm more used to hex, but I personally don't think those are more readable. It replaces 1-line macroes with 4-line functions, and I think more vgrepping to pick out the relevant constant data. +-DLS - To unsubscribe from this list: send the li

  1   2   >