Re: [PATCH] net: Saner thash_entries default with much memory

2007-10-29 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Fri, 26 Oct 2007 17:34:17 +0200 > On Fri, Oct 26, 2007 at 05:21:31PM +0200, Jean Delvare wrote: > > I propose 2 millions of entries as the arbitrary high limit. This > > It's probably still far too large. I agree. Perhaps a better number is something o

Re: [PATCH] rpc_rdma: we need to cast u64 to unsigned long long for printing

2007-10-29 Thread David Miller
From: Stephen Rothwell <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 16:12:40 +1100 > as some architectures have unsigned long for u64. > > net/sunrpc/xprtrdma/rpc_rdma.c: In function 'rpcrdma_create_chunks': > net/sunrpc/xprtrdma/rpc_rdma.c:222: warning: format '%llx' expects type 'long > long uns

Re: [PATCH] pegasos_eth.c: Fix compile error over MV643XX_ defines

2007-10-29 Thread Luis R. Rodriguez
On 10/29/07, Dale Farnsworth <[EMAIL PROTECTED]> wrote: > On Mon, Oct 29, 2007 at 05:27:29PM -0400, Luis R. Rodriguez wrote: > > This commit made an incorrect assumption: > > -- > > Author: Lennert Buytenhek <[EMAIL PROTECTED]> > > Date: Fri Oct 19 04:10:10 2007 +0200 > > > > mv643xx_eth: Mo

Re: [RFC 1/2] [IPV6] ADDRCONF: Preparation for configurable address selection policy with ifindex.

2007-10-29 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 14:52:37 +0900 (JST) > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> What is the substance of this change? Please add a description of this to the changelog entry as currently the description is far too brief and va

Re: [RFC 2/2] [IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.

2007-10-29 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 14:52:54 +0900 (JST) > diff --git a/include/linux/if_addrlabel.h b/include/linux/if_addrlabel.h > new file mode 100644 > index 000..66978a5 > --- /dev/null > +++ b/include/linux/if_addrlabel.h > @@ -0,0 +1,55 @@ > +/* >

[RFC 2/2] [IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.

2007-10-29 Thread YOSHIFUJI Hideaki / 吉藤英明
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- include/linux/if_addrlabel.h | 55 include/linux/rtnetlink.h|7 + include/net/addrconf.h |8 + net/ipv6/Makefile|1 + net/ipv6/addrconf.c | 40 +--- net/ipv6/addrlabel.c | 566

[RFC 1/2] [IPV6] ADDRCONF: Preparation for configurable address selection policy with ifindex.

2007-10-29 Thread YOSHIFUJI Hideaki / 吉藤英明
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- net/ipv6/addrconf.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 348bd8d..8b408b7 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -877,7

[RFC 0/2] [IPV6] ADDRCONF: IPv6 configurable Default Address Selection support (TAKE 2)

2007-10-29 Thread YOSHIFUJI Hideaki / 吉藤英明
This is the 2nd RFC for supporting configurable IPv6 Default Address Selection policy (RFC3484) based on 2.6.24-rc1. This is intended for 2.6.25. Major changes: - Use rtnetlink instead of ioctl/procfs. - Use RCU. Git tree is available at the branch named 2.6.24-rc1-addrlabel-20071

Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops

2007-10-29 Thread Jens Axboe
On Tue, Oct 30 2007, Herbert Xu wrote: > On Mon, Oct 29, 2007 at 09:16:27PM +0100, Jens Axboe wrote: > > On Fri, Oct 26 2007, Herbert Xu wrote: > > > [CRYPTO] tcrypt: Move sg_init_table out of timing loops > > > > > > This patch moves the sg_init_table out of the timing loops for hash > > > algori

Re: [0/11] Merge bundle creation and other misc fixes/clean-ups

2007-10-29 Thread Herbert Xu
On Mon, Oct 29, 2007 at 10:06:35PM -0700, David Miller wrote: > > I did a review of these patches and these look fine. Thanks! > Please resubmit this and the 3-patch input interfamily > fix set when I open up the net-2.6.25 tree. > > I'll probably open up net-2.6.25 approximately one week > from

[PATCH] rpc_rdma: we need to cast u64 to unsigned long long for printing

2007-10-29 Thread Stephen Rothwell
as some architectures have unsigned long for u64. net/sunrpc/xprtrdma/rpc_rdma.c: In function 'rpcrdma_create_chunks': net/sunrpc/xprtrdma/rpc_rdma.c:222: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'u64' net/sunrpc/xprtrdma/rpc_rdma.c:234: warning: forma

Re: [patch] net: avoid race between netpoll and network fast path

2007-10-29 Thread Matt Mackall
On Mon, Oct 29, 2007 at 09:26:11PM -0700, David Miller wrote: > From: Tina Yang <[EMAIL PROTECTED]> > Date: Tue, 16 Oct 2007 22:46:30 -0700 > > > The precise race is > > 1) net_rx_action get the dev from poll_list > > 2) at the same time, netpoll poll_napi() get a hold of the poll lock

Re: [0/11] Merge bundle creation and other misc fixes/clean-ups

2007-10-29 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 24 Oct 2007 00:02:17 +0800 > This series of patches fixes the bug where the bundle creation > code treats IPv6 routes as IPv4 or vice versa. > > I think this is suitable for 2.6.25. > > They do fix bugs but I don't think any of them are serious eno

Re: [PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP out-going statistics

2007-10-29 Thread David Miller
From: Mitsuru Chinen <[EMAIL PROTECTED]> Date: Fri, 26 Oct 2007 10:59:28 +0900 > While displaying ICMP out-going statistics as Out counters in > /proc/net/snmp, the memory location for ICMP in-coming statistics > was referred by mistake. > > Acked-by: David L Stevens <[EMAIL PROTECTED]> > Signed

Re: MD5 signature pool race bug?

2007-10-29 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 25 Oct 2007 11:36:12 -0700 > Looking at this bug report: > http://bugzilla.kernel.org/show_bug.cgi?id=9173 ... > It looks like there may be a race between the tricky allocate per-cpu pool > and free-per-cpu pool logic. IMHO the pool ma

Re: BUG in sys_socketpair

2007-10-29 Thread David Miller
From: Chuck Ebbert <[EMAIL PROTECTED]> Date: Thu, 25 Oct 2007 14:44:52 -0400 > On 10/25/2007 10:11 AM, Rich Paul wrote: > > In 2.6.23, there seems to be a minor bug in sys_socketpair. When the > > calls to sock_alloc_fd fail, it aborts the routine, but it returns the > > variable err, which is no

Re: [PATCH 5/5] introduce udp_rmem and udp_wmem

2007-10-29 Thread Bill Fink
On Mon, 29 Oct 2007, Hideo AOKI wrote: > This patch added /proc/sys/net/udp_rmem and /proc/sys/net/udp_rmem. > Each UDP packet is drooped when the number of pages for socket buffer > is beyond the limit and the socket already consumes minimum buffer. I think you meant /proc/sys/net/ipv4/udp_{r,w}

Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

2007-10-29 Thread Neil Brown
On Monday October 22, [EMAIL PROTECTED] wrote: > Here is a second missing part of the IPv6 support in NFS server code > concerning knfd syscall interface. > It updates write_getfd and write_getfd to accept IPv6 addresses. Sorry for not replying to this earlier - I saw the Oct 12 post and thought

Re: [patch] net: avoid race between netpoll and network fast path

2007-10-29 Thread David Miller
From: Tina Yang <[EMAIL PROTECTED]> Date: Tue, 16 Oct 2007 22:46:30 -0700 > The precise race is > 1) net_rx_action get the dev from poll_list > 2) at the same time, netpoll poll_napi() get a hold of the poll lock > and calls ->poll(), remove dev from the poll list >

Re: Configuring the same IP on multiple addresses

2007-10-29 Thread Brian Haley
David Miller wrote: From: David Miller <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 15:25:59 -0700 (PDT) Can you guys please just state upfront what virtualization issue is made more difficult by features you want to remove? Sorry, I mentioned "virtualization" because that's been the largest ma

Re: drivers/net/sunhme.c patch

2007-10-29 Thread David Miller
From: Tom Southerland <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 19:53:52 -0600 > This patch provides a unique mac address for all interfaces > for the Sun QFE card (non-sparc). It takes the base mac from > the first interface and increments the mac address for the > other interfaces. > > It sti

drivers/net/sunhme.c patch

2007-10-29 Thread Tom Southerland
This patch provides a unique mac address for all interfaces for the Sun QFE card (non-sparc). It takes the base mac from the first interface and increments the mac address for the other interfaces. It still preserves the 'macaddr' parameter so if desired, it can still be used. Before patching:

Fwd: Bug with tun0 and VLAN

2007-10-29 Thread Bruno Clermont
Hi, I previously contacted tun driver maintainer about a bug I found and he suggested me to forward this to you. so, look like there is a bug in the kernel when the VLAN code is dealing with an interface like the tun interface. see forwarded my original mail and Max reply. thanks! -- Fo

Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops

2007-10-29 Thread Herbert Xu
On Mon, Oct 29, 2007 at 09:16:27PM +0100, Jens Axboe wrote: > On Fri, Oct 26 2007, Herbert Xu wrote: > > [CRYPTO] tcrypt: Move sg_init_table out of timing loops > > > > This patch moves the sg_init_table out of the timing loops for hash > > algorithms so that it doesn't impact on the speed test re

Re: [PATCH] inet: race in wait for connect.

2007-10-29 Thread Stephen Hemminger
On Mon, 29 Oct 2007 15:38:42 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Mon, 29 Oct 2007 14:37:14 -0700 > > > On Mon, 29 Oct 2007 19:29:06 -0200 > > "Arnaldo Carvalho de Melo" <[EMAIL PROTECTED]> wrote: > > > > > Em Mon, Oct 29, 2007

Re: [PATCH] pegasos_eth.c: Fix compile error over MV643XX_ defines

2007-10-29 Thread Lennert Buytenhek
On Mon, Oct 29, 2007 at 05:27:29PM -0400, Luis R. Rodriguez wrote: > This commit made an incorrect assumption: > -- > Author: Lennert Buytenhek <[EMAIL PROTECTED]> > Date: Fri Oct 19 04:10:10 2007 +0200 > > mv643xx_eth: Move ethernet register definitions into private header > > Mo

Re: Configuring the same IP on multiple addresses

2007-10-29 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 15:25:59 -0700 (PDT) > Can you guys please just state upfront what virtualization > issue is made more difficult by features you want to remove? Sorry, I mentioned "virtualization" because that's been the largest majority of the cases

Re: drivers/net/sunhme.c patch

2007-10-29 Thread David Miller
From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 23:12:25 +0100 (CET) > The question was more like: if I put in a QFE (that was acquired together > with a SUN E250) into x86, would I get duplicate MACs? (Would be strange - > I would have supposed the OF on the card is independent.)

Re: [PATCH] inet: race in wait for connect.

2007-10-29 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 14:37:14 -0700 > On Mon, 29 Oct 2007 19:29:06 -0200 > "Arnaldo Carvalho de Melo" <[EMAIL PROTECTED]> wrote: > > > Em Mon, Oct 29, 2007 at 01:52:22PM -0700, Stephen Hemminger escreveu: > > > Fix possible race while waiting for conn

Re: [PATCH] pegasos_eth.c: Fix compile error over MV643XX_ defines

2007-10-29 Thread Dale Farnsworth
On Mon, Oct 29, 2007 at 05:27:29PM -0400, Luis R. Rodriguez wrote: > This commit made an incorrect assumption: > -- > Author: Lennert Buytenhek <[EMAIL PROTECTED]> > Date: Fri Oct 19 04:10:10 2007 +0200 > > mv643xx_eth: Move ethernet register definitions into private header > > Mov

Re: [bug, 2.6.24-rc1] sysfs: duplicate filename 'eth0' can not be created

2007-10-29 Thread David Miller
From: Ingo Molnar <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 22:17:46 +0100 > > hm, this seems to have popped up in the last few days, never had it > before: > > sysfs: duplicate filename 'eth0' can not be created > WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() I checked in a change from

Re: Configuring the same IP on multiple addresses

2007-10-29 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 14:03:37 -0400 > So, I am looking for technical reasons why this is permitted. I am looking for a technical reason why you find a need to discover this feature and want the remove it :-) Can you guys please just state upfront what vi

Re: drivers/net/sunhme.c patch

2007-10-29 Thread Jan Engelhardt
On Oct 29 2007 15:10, David Miller wrote: >> On Oct 29 2007 08:54, Tom Southerland wrote: >> > >> > This patch provides a unique mac address for all interfaces >> > for the Sun QFE card (non-sparc). It takes the base mac from >> > the first interface and increments the mac address for the >> > ot

Re: drivers/net/sunhme.c patch

2007-10-29 Thread David Miller
From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 16:11:18 +0100 (CET) > > On Oct 29 2007 08:54, Tom Southerland wrote: > > > > This patch provides a unique mac address for all interfaces > > for the Sun QFE card (non-sparc). It takes the base mac from > > the first interface and i

[PATCH][RFC] Add support for the RDC R6040 Fast Ethernet controller

2007-10-29 Thread Florian Fainelli
This patch adds support for the RDC R6040 MAC we can find in the RDC R-321x System-on-chips. This driver really needs improvements especially on the NAPI part which probably does not fully use the new NAPI structure. You will need the RDC PCI identifiers if you want to test this driver which are

Re: [bug, 2.6.24-rc1] sysfs: duplicate filename 'eth0' can not be created

2007-10-29 Thread Rick Jones
Jeff Garzik wrote: Ingo Molnar wrote: hm, this seems to have popped up in the last few days, never had it before: sysfs: duplicate filename 'eth0' can not be created WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Call Trace: [] sysfs_add_one+0x54/0xbd [] sysfs_create_link+0xc6/0x

Re: [bug, 2.6.24-rc1] sysfs: duplicate filename 'eth0' can not be created

2007-10-29 Thread Ingo Molnar
* Stephen Hemminger <[EMAIL PROTECTED]> wrote: > Already fixed post 2.6.24-rc1 > > commit c8d90dca3211966ba5189e0f3d4bccd558d9ae08 > Author: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Fri Oct 26 03:53:42 2007 -0700 > > [NET] dev_change_name: ignore changes to same name ah, nice - that

Re: [bug, 2.6.24-rc1] sysfs: duplicate filename 'eth0' can not be created

2007-10-29 Thread Stephen Hemminger
On Mon, 29 Oct 2007 22:17:46 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > hm, this seems to have popped up in the last few days, never had it > before: > > sysfs: duplicate filename 'eth0' can not be created > WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() > > Call Trace: >[] sys

Re: [PATCH] inet: race in wait for connect.

2007-10-29 Thread Stephen Hemminger
On Mon, 29 Oct 2007 19:29:06 -0200 "Arnaldo Carvalho de Melo" <[EMAIL PROTECTED]> wrote: > Em Mon, Oct 29, 2007 at 01:52:22PM -0700, Stephen Hemminger escreveu: > > Fix possible race while waiting for connections in accept. I don't > > know of a test case that could reproduce this directly. > > >

Re: [bug, 2.6.24-rc1] sysfs: duplicate filename 'eth0' can not be created

2007-10-29 Thread Jeff Garzik
Ingo Molnar wrote: hm, this seems to have popped up in the last few days, never had it before: sysfs: duplicate filename 'eth0' can not be created WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Call Trace: [] sysfs_add_one+0x54/0xbd [] sysfs_create_link+0xc6/0x11d [] device_rena

Re: [PATCH] inet: race in wait for connect.

2007-10-29 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 29, 2007 at 01:52:22PM -0700, Stephen Hemminger escreveu: > Fix possible race while waiting for connections in accept. I don't > know of a test case that could reproduce this directly. > > The state of the socket should be checked before checking the queue. > If the socket has left the

[PATCH 3/5] memory accounting

2007-10-29 Thread Hideo AOKI
This patch adds UDP memory usage accounting in IPv4. -- Hideo Aoki Hitachi Computer Products (America) Inc. Signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]> Signed-off-by: Hideo Aoki <[EMAIL PROTECTED]> af_inet.c | 30 +- ip_output.c | 25

[PATCH 5/5] introduce udp_rmem and udp_wmem

2007-10-29 Thread Hideo AOKI
This patch added /proc/sys/net/udp_rmem and /proc/sys/net/udp_rmem. Each UDP packet is drooped when the number of pages for socket buffer is beyond the limit and the socket already consumes minimum buffer. -- Hideo Aoki Hitachi Computer Products (America) Inc. Cc: Satoshi Oshima <[EMAIL PROTECTE

[PATCH 2/5] accounting unit and variable

2007-10-29 Thread Hideo AOKI
This patch introduces global variable for UDP memory accounting. The unit is page. -- Hideo Aoki Hitachi Computer Products (America) Inc. Signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]> Signed-off-by: Hideo Aoki <[EMAIL PROTECTED]> include/net/sock.h |7 +++ include/net/udp.h |2

[PATCH 4/5] memory limitation by using udp_mem

2007-10-29 Thread Hideo AOKI
This patch introduces memory limitation for UDP. -- Hideo Aoki Hitachi Computer Products (America) Inc. Signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]> Signed-off-by: Hideo Aoki <[EMAIL PROTECTED]> Documentation/networking/ip-sysctl.txt |6 include/net/udp.h |

[PATCH] pegasos_eth.c: Fix compile error over MV643XX_ defines

2007-10-29 Thread Luis R. Rodriguez
This commit made an incorrect assumption: -- Author: Lennert Buytenhek <[EMAIL PROTECTED]> Date: Fri Oct 19 04:10:10 2007 +0200 mv643xx_eth: Move ethernet register definitions into private header Move the mv643xx's ethernet-related register definitions from include/linux/mv643x

[PATCH 1/5] fix send buffer check

2007-10-29 Thread Hideo AOKI
This patch introduces sndbuf size check before memory allocation for send buffer. -- Hideo Aoki Hitachi Computer Products (America) Inc. Signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]> Signed-off-by: Hideo Aoki <[EMAIL PROTECTED]> ip_output.c |5 + 1 file changed, 5 insertions(+) di

[PATCH 0/5] UDP memory accounting and limitation (take 6)

2007-10-29 Thread Hideo AOKI
Hello, This is the latest patch set of UDP memory accounting and limitation. The number of pages for socket buffer is limited up to /proc/sys/net/ipv4/udp_mem. I removed the minimal limit number to use the feature from the former patch set (take5). And udp_init() is introduced to calculate defau

[bug, 2.6.24-rc1] sysfs: duplicate filename 'eth0' can not be created

2007-10-29 Thread Ingo Molnar
hm, this seems to have popped up in the last few days, never had it before: sysfs: duplicate filename 'eth0' can not be created WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Call Trace: [] sysfs_add_one+0x54/0xbd [] sysfs_create_link+0xc6/0x11d [] device_rename+0x175/0x1d6 []

dn_route.c momentarily exiting RCU read-side critical section

2007-10-29 Thread Paul E. McKenney
Hello! net/decnet/dn_route.c in dn_rt_cache_get_next() is as follows: static struct dn_route *dn_rt_cache_get_next(struct seq_file *seq, struct dn_route *rt) { struct dn_rt_cache_iter_state *s = rcu_dereference(seq->private); rt = rt->u.dst.dn_next; while(!rt) {

[PATCH] nf_nat_h323.c unneeded rcu_dereference() calls

2007-10-29 Thread Paul E. McKenney
Hello! While reviewing rcu_dereference() uses, I came across a number of cases where I couldn't see how the rcu_dereference() helped. One class of cases is where the variable is never subsequently dereferenced, so that patches like the following one would be appropriate. So, what am I missing he

Fw: [PATCH] [IPv4] SNMP: Refer correct memory location to display ICMP out-going statistics

2007-10-29 Thread David Stevens
Dave, I didn't see a response for this one... in case it fell through the cracks. Just want to make sure my bone-headed error doesn't hang around too long. :-) +-DLS - Forwarded by David Stevens/Beaverton/IBM on 10/29/2007 01:51 PM ---

[PATCH] inet: race in wait for connect.

2007-10-29 Thread Stephen Hemminger
Fix possible race while waiting for connections in accept. I don't know of a test case that could reproduce this directly. The state of the socket should be checked before checking the queue. If the socket has left the TCP_LISTEN state, then the accept queue is no longer valid. Signed-off-by: Ste

Re: Configuring the same IP on multiple addresses

2007-10-29 Thread David Stevens
> For v6, there are plenty of operational reasons to not allow this. You really > turn unicast into anycast when you do this and there are special rules to > be followed. I don't see it that way. The only "problem" I can think of offhand is that you can't use a multi-interface address t

Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops

2007-10-29 Thread Jens Axboe
On Fri, Oct 26 2007, Herbert Xu wrote: > [CRYPTO] tcrypt: Move sg_init_table out of timing loops > > This patch moves the sg_init_table out of the timing loops for hash > algorithms so that it doesn't impact on the speed test results. Wouldn't it be better to just make sg_init_one() call sg_init_

Re: Configuring the same IP on multiple addresses

2007-10-29 Thread Vlad Yasevich
David Stevens wrote: > [EMAIL PROTECTED] wrote on 10/29/2007 11:03:37 AM: > >> So, I am looking for technical reasons why this is permitted. > > Vlad, > Is there a technical reason to disallow it? Rather than > anticipate all the possible uses for a machine, it's, of course, > generally b

Re: [PATCH 2/2] netdrvr/ibmlana: move away from legacy MCA API

2007-10-29 Thread Jeff Garzik
Jan Engelhardt wrote: On Oct 29 2007 15:33, Jeff Garzik wrote: +#if 0 /* info available elsewhere, but this is kept for reference */ It is available in the git history, yes, is it still needed for reference? it's there to see if anyone complains at its removal :) +static short ibmlana_ada

Re: [PATCH 2/2] netdrvr/ibmlana: move away from legacy MCA API

2007-10-29 Thread Jan Engelhardt
On Oct 29 2007 15:33, Jeff Garzik wrote: > >+#if 0 /* info available elsewhere, but this is kept for reference */ It is available in the git history, yes, is it still needed for reference? >+static short ibmlana_adapter_ids[] __initdata = { >+ IBM_LANA_ID, >+ 0x >+}; >+ >+static c

Re: Configuring the same IP on multiple addresses

2007-10-29 Thread David Stevens
[EMAIL PROTECTED] wrote on 10/29/2007 11:03:37 AM: > So, I am looking for technical reasons why this is permitted. Vlad, Is there a technical reason to disallow it? Rather than anticipate all the possible uses for a machine, it's, of course, generally better to restrict only the things yo

[PATCH 1/2] netdrvr/ibmlana: modularization cleanup

2007-10-29 Thread Jeff Garzik
* move alloc_netdev() call, register_netdev() call, and associated failure cleanup into ibmlana_probe() * move per-net_device cleanup into ibmlana_remove_one() Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/net/ibmlana.c | 109 + 1 f

[PATCH 2/2] netdrvr/ibmlana: move away from legacy MCA API

2007-10-29 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/net/ibmlana.c | 119 + 1 files changed, 51 insertions(+), 68 deletions(-) diff --git a/drivers/net/ibmlana.c b/drivers/net/ibmlana.c index 006d0d7..188c0a9 100644 --- a/drivers/net/ibmlana.

Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

2007-10-29 Thread Brian Haley
Hi Aurelien, This is a combination of your two patches into one, cleaned-up with all my complaints. I also added an ipv6_addr_set_v4mapped() inline after someone else here convinced me it gets rid of a lot of cruft from the code. The DCCP, etc. code can be cleaned-up later if this gets accep

Re: [Bugme-new] [Bug 9260] New: tipc_config.h is not installed when doing "make headers_install"

2007-10-29 Thread Andrew Morton
On Mon, 29 Oct 2007 09:10:26 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9260 > >Summary: tipc_config.h is not installed when doing "make > headers_install" >Product: Other >Version: 2.5 > KernelVer

Configuring the same IP on multiple addresses

2007-10-29 Thread Vlad Yasevich
Hi All Does anyone have a reason why Linux allows one to configure the same IP or IPv6 address on multiple interfaces? For IPv4, since linux implements a weak host model, assigning duplicate addresses doesn't make any sense, since the addresses really belong to the host and not the interface. Fo

Re: [PATCH] pcnet: fix sparse triviality

2007-10-29 Thread Kok, Auke
Jeff Garzik wrote: > Auke Kok wrote: >> Since data can never exceed u32, it can't even be larger than >> LONG_MAX/HZ. >> >> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> >> Cc: [EMAIL PROTECTED] >> --- >> > Two comments: > > 1) I would prefer to pick a sane limit, like "1 day". The unit of > 'data'

kernel panic removing devices from a teql queuing discipline

2007-10-29 Thread Chuck Ebbert
https://bugzilla.redhat.com/show_bug.cgi?id=219488 Still happening in 2.6.22.9: BUG: unable to handle kernel paging request at virtual address 66696674 printing eip: d098d4de *pde = Oops: [#1] SMP last sysfs file: /class/net/lo/ifindex Modules linked in: sch_teql netconsole autofs

[PATCH 4/4] ixgbe: minor sparse fixes

2007-10-29 Thread Auke Kok
From: Stephen Hemminger <[EMAIL PROTECTED]> Make strings const if possible, and fix includes so forward definitions are seen. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgbe/ixgbe.h |2 +- drivers/net/ixgbe/ixgbe_8

[PATCH 1/4] e1000e: fix sparse warnings

2007-10-29 Thread Auke Kok
From: Stephen Hemminger <[EMAIL PROTECTED]> Fix sparse warnings from e1000e driver in net-2.6.24. Added a sparse fix for module param arrays which can have int values but only the array index needs to be unsigned. --Auke Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Auke Ko

netdev@vger.kernel.org

2007-10-29 Thread Auke Kok
From: Roel Kluin <[EMAIL PROTECTED]> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/82571.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000e/82571.c b/drivers/net/e1000e/82571.c index cf

[PATCH 3/4] e1000: sparse warnings fixes

2007-10-29 Thread Auke Kok
From: Stephen Hemminger <[EMAIL PROTECTED]> Fix sparse warnings and problems from e1000 driver. Added a sparse fix for the module param array index -- Auke Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000.h |

[PATCH 2/4] ixgb: fix sparse warnings

2007-10-29 Thread Auke Kok
From: Stephen Hemminger <[EMAIL PROTECTED]> Fix sparse warnings in ixgb driver for net-2.6.24. Added a sparse fix for invalid declaration using non-constant value in ixgb_set_multi. Added a fix for the module param array index and allows int params in the array. --Auke Signed-off-by: Stephen Hem

Re: last git: BUG: unable to handle kernel paging request at virtual address 92184900

2007-10-29 Thread Giacomo Catenazzi
Andrew Morton wrote: > On Tue, 23 Oct 2007 21:04:20 +0200 Giacomo Catenazzi <[EMAIL PROTECTED]> > wrote: > >> Oct 23 20:20:05 catee kernel: BUG: unable to handle kernel paging request at >> virtual address 92184900 > > Is this still happening in the latest Linus tree? > > If so, please send so

Re: [E1000-devel] e1000 and ICH9 hardware

2007-10-29 Thread Kok, Auke
David A. Ranch wrote: >>> e1000 is being frozen in time as "pre-PCI Express e1000's". >> > Asking the question a different way, will the current e1000 driver > continue to get new features, performance / power / optimization tweaks, > etc. or is most of the primary development be moving only o

Re: [E1000-devel] e1000 and ICH9 hardware

2007-10-29 Thread David A. Ranch
>e1000 is being frozen in time as "pre-PCI Express e1000's". Asking the question a different way, will the current e1000 driver continue to get new features, performance / power / optimization tweaks, etc. or is most of the primary development be moving only on the e1000e kit? --David -

Re: [PATCH] skye/skge: sparse fix - data can't ever be bigger than LONG_MAX / HZ

2007-10-29 Thread Jeff Garzik
Stephen Hemminger wrote: Since these all use ethtool, shouldn't the checks be put into ethtool_phys_id rather than having the driver check? Seems quite reasonable to me. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTEC

Re: [PATCH v4.3] FEC - fast ethernet controller for mpc52xx

2007-10-29 Thread Grant Likely
On 10/29/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Domen Puncer wrote: > > drivers/net/Kconfig | 24 > > drivers/net/Makefile |4 > > drivers/net/fec_mpc52xx.c | 1112 > > ++ > > drivers/net/fec_mpc52xx.h | 313 +

Re: [PATCH] skye/skge: sparse fix - data can't ever be bigger than LONG_MAX / HZ

2007-10-29 Thread Stephen Hemminger
On Mon, 29 Oct 2007 06:05:14 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Auke Kok wrote: > > Trivial replacement - use INT_MAX instead here. > > > > Signed-off-by: Auke Kok <[EMAIL PROTECTED]> > > Cc: [EMAIL PROTECTED] > > --- > > > > drivers/net/sk98lin/skethtool.c |4 ++-- > > drivers/

Re: [2.6 patch] remove Documentation/networking/net-modules.txt

2007-10-29 Thread Pekka Pietikainen
On Wed, Oct 24, 2007 at 06:25:03PM +0200, Adrian Bunk wrote: > According to git, the only one who touched this file during the last > 5 years was me when removing drivers... That's not the only obsolete thing there: > ncsa-telnet > - notes on how NCSA telnet (DOS) breaks with MTU discovery

Re: e1000 and ICH9 hardware

2007-10-29 Thread Jeff Garzik
Daniel Drake wrote: Are there any plans to add ICH9 support to the e1000 driver (I note there is a patch floating around), or is the intention that ICH9 users all move to e1000e? They all should use e1000e. Further, in 2.6.25 or so, some e1000 PCI IDs will be moved to e1000e, and support rem

e1000 and ICH9 hardware

2007-10-29 Thread Daniel Drake
Hi, Are there any plans to add ICH9 support to the e1000 driver (I note there is a patch floating around), or is the intention that ICH9 users all move to e1000e? Just wondering which approach to take in terms of getting this hardware supported in Gentoo's 2.6.23 kernels. Thanks! Daniel -

Re: Oops in 2.6.21-rc4, 2.6.23

2007-10-29 Thread Jarek Poplawski
On Mon, Oct 29, 2007 at 01:41:47AM -0700, David Miller wrote: > From: Jarek Poplawski <[EMAIL PROTECTED]> > Date: Mon, 29 Oct 2007 09:42:32 +0100 > > > I hope you've found this by yourself by now, but: > > > > 1. These are warnings only - not oopses. > > 2. It seems this patch you've found to be

Re: [PATCH] proc_fs.h redux

2007-10-29 Thread Arnaldo Carvalho de Melo
Em Sun, Oct 28, 2007 at 09:44:41AM +0100, Sam Ravnborg escreveu: > > > > As a general rule, I think it better to use includes > > than use naked forward declarations. > > Quite the opposite - at least in the kernel source. > The general rule is that a .h file shall include the > .h files which co

Re: [UDP6]: Restore sk_filter optimisation

2007-10-29 Thread Herbert Xu
On Mon, Oct 29, 2007 at 03:33:20PM +0900, Mitsuru Chinen wrote: > Hello Herbert, > > Let me ask a question about this patch. > After this patch was applied, 2 of the protocol stack behaviors were > changed when it receives a UDP datagram with broken checksum: > > 1. udp6InDatagrams is incremente

Re: IPVS: use proper timeout instead of fixed value

2007-10-29 Thread Andy Gospodarek
On Mon, Oct 29, 2007 at 04:05:55PM +0900, Simon Horman wrote: > From: Andy Gospodarek <[EMAIL PROTECTED]> > > Instead of using the default timeout of 3 minutes, this uses the timeout > specific to the protocol used for the connection. The 3 minute timeout > seems somewhat arbitrary (though I know

Re: [PATCH] ucc_geth: add support for netpoll

2007-10-29 Thread Anton Vorontsov
On Mon, Oct 29, 2007 at 02:12:07PM +0800, Li Yang-r58472 wrote: [...] > > > > +#ifdef CONFIG_NET_POLL_CONTROLLER > > > > +/* > > > > + * Polling 'interrupt' - used by things like netconsole to send > > > > +skbs > > > > + * without having to re-enable interrupts. It's not called while > > > > + *

Re: HFSC dangerous behaviour (not a bug)

2007-10-29 Thread Denys
After thinking about that, i can say only thanks. I like your idea, and it is better to avoid mistakes and missed traffic, then have a lot of complaints from users "why my shaper not working well". And seems i will try to switch to HFSC. Thanks for explanation. On Mon, 29 Oct 2007 11:55:31 +010

Re: HFSC dangerous behaviour (not a bug)

2007-10-29 Thread Patrick McHardy
Denys wrote: Additionally, it doesn't show rate in stats (so it is difficult to measure, how much is really using each class). qdisc hfsc 1: root default 200 Sent 1392761062 bytes 965768 pkt (dropped 52, overlimits 1620539 requeues 0) rate 0bit 0pps backlog 0b 0p requeues 0 Thats what rate

Re: HFSC dangerous behaviour (not a bug)

2007-10-29 Thread Patrick McHardy
Denys wrote: Hi All During testing i found very strange thing. After applying even example shaper: http://linux-ip.net/tc/hfsc.en/ - [...] --- I had all traffic on eth0 stopped. Tried on br0 - same result. Even ARP becoming non-functional. After specifying correct de

RE: [PATCH 2.6.24 1/1]S2io: Support for add/delete/store/restore ethernet addresses

2007-10-29 Thread Sreenivasa Honnur
Jeff, Is this patch reviewed/applied? -srini -Original Message- From: Sreenivasa Honnur [mailto:[EMAIL PROTECTED] Sent: Friday, October 19, 2007 11:23 AM To: [EMAIL PROTECTED]; netdev@vger.kernel.org Cc: support Subject: [PATCH 2.6.24 1/1]S2io: Support for add/delete/store/restore ether

Re: [PATCH] Fix ethernet multicast for ucc_geth.

2007-10-29 Thread Jeff Garzik
Joakim Tjernlund wrote: From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17 00:00:00 2001 From: Joakim Tjernlund <[EMAIL PROTECTED]> Date: Wed, 17 Oct 2007 11:01:44 +0200 Subject: [PATCH] Fix ethernet multicast for ucc_geth. hw_add_addr_in_hash() already swaps byte order, don't do it in u

RE: [PATCH] Fix ethernet multicast for ucc_geth.

2007-10-29 Thread Li Yang-r58472
> > @@ -2255,19 +2253,10 @@ static void > ucc_geth_set_multi(struct net_device *dev) > > if (!(dmi->dmi_addr[0] & 1)) > > continue; > > > > - /* The address in dmi_addr is LSB first, > > -

Re: [PATCH] Fix ethernet multicast for ucc_geth.

2007-10-29 Thread Jeff Garzik
Joakim Tjernlund wrote: From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17 00:00:00 2001 From: Joakim Tjernlund <[EMAIL PROTECTED]> Date: Wed, 17 Oct 2007 11:01:44 +0200 Subject: [PATCH] Fix ethernet multicast for ucc_geth. hw_add_addr_in_hash() already swaps byte order, don't do it in u

Re: [PATCH] skye/skge: sparse fix - data can't ever be bigger than LONG_MAX / HZ

2007-10-29 Thread Jeff Garzik
Auke Kok wrote: Trivial replacement - use INT_MAX instead here. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] --- drivers/net/sk98lin/skethtool.c |4 ++-- drivers/net/skge.c |8 drivers/net/sky2.c |8 3 files changed,

Re: [PATCH] pcnet: fix sparse triviality

2007-10-29 Thread Jeff Garzik
Auke Kok wrote: Since data can never exceed u32, it can't even be larger than LONG_MAX/HZ. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] --- drivers/net/pcnet32.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/pcnet32.c b/drivers/ne

Re: IPVS: use proper timeout instead of fixed value

2007-10-29 Thread David Miller
From: Simon Horman <[EMAIL PROTECTED]> Date: Mon, 29 Oct 2007 17:59:23 +0900 > On Mon, Oct 29, 2007 at 01:35:15AM -0700, David Miller wrote: > > From: Simon Horman <[EMAIL PROTECTED]> > > Date: Mon, 29 Oct 2007 16:05:55 +0900 (JST) > > > > > From: Andy Gospodarek <[EMAIL PROTECTED]> > > > > > >

Re: [PATCH v4.3] FEC - fast ethernet controller for mpc52xx

2007-10-29 Thread Jeff Garzik
Domen Puncer wrote: On 26/10/07 07:18 -0700, Dale Farnsworth wrote: On Fri, Oct 26, 2007 at 01:59:09PM +0200, Domen Puncer wrote: +static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id) +{ + struct net_device *dev = dev_id; + struct mpc52xx_fec_priv *priv = netdev_priv(d

Re: [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing MSI-X local entry memories when vector allocation fails

2007-10-29 Thread Jeff Garzik
Sivakumar Subramani wrote: - Fixed memory leak by freeing MSI-X local entry memories when vector allocation fails in s2io_add_isr. - Added two utility functions do_rem_msix_isr and do_rem_inta_isr to eliminate code duplication. Signed-off-by: Veena Parat <[EMAIL PROTECTED]> Signed-off-by: Ramkri

Re: [PATCH 00/04] pull request for 'upstream-jeff' branch

2007-10-29 Thread Jeff Garzik
Francois Romieu wrote: Please pull from branch 'upstream-jeff' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git upstream-jeff to get the changes below. Distance from 'master' (96fd4cd3e40e240f0c385af87f58e74da8b7099a) --

Re: Please pull 'fixes-jgarzik' branch of wireless-2.6

2007-10-29 Thread Jeff Garzik
John W. Linville wrote: Jeff, A few fixes for 2.6.24... Thanks, John --- Individual patches available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/fixes-jgarzik --- The following changes since commit c9927c2bf4f45bb85e8b502ab3fb79ad6483c244: Linus T

Re: [PATCH] ehea: add kexec support

2007-10-29 Thread Jeff Garzik
Jan-Bernd Themann wrote: eHEA resources that are allocated via H_CALLs have a unique identifier each. These identifiers are necessary to free the resources. A reboot notifier is used to free all eHEA resources before the indentifiers get lost, i.e before kexec starts a new kernel. Signed-off-by:

  1   2   >