Re: networking crash in current mainline: sk_filter_delayed_uncharge()

2007-10-18 Thread Andrew Morton
On Thu, 18 Oct 2007 23:11:27 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Thu, 18 Oct 2007 23:09:48 -0700 > > > > > powerpc mac G5 > > config: http://userweb.kernel.org/~akpm/config-g5.txt > > screenshot: http://userweb.kernel.org/~akpm/ds

Re: networking crash in current mainline: sk_filter_delayed_uncharge()

2007-10-18 Thread Andrew Morton
On Thu, 18 Oct 2007 23:09:48 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > > powerpc mac G5 > config: http://userweb.kernel.org/~akpm/config-g5.txt > screenshot: http://userweb.kernel.org/~akpm/dsc5.jpg > > It does this shortly after bringing up eth0 (tg3), in dhclient. > - To unsubscr

[PATCH 2.6.24 1/1]S2io: Support for add/delete/store/restore ethernet addresses

2007-10-18 Thread Sreenivasa Honnur
- Support to add/delete/store/restore 64 and 128 Ethernet addresses for Xframe I and Xframe II respectively. Signed-off-by: Sreenivasa Honnur <[EMAIL PROTECTED]> --- diff -urpN org/drivers/net/s2io.c patch_1/drivers/net/s2io.c --- org/drivers/net/s2io.c 2007-09-26 00:01:14.0 +0530 ++

Re: networking crash in current mainline: sk_filter_delayed_uncharge()

2007-10-18 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 23:09:48 -0700 > > powerpc mac G5 > config: http://userweb.kernel.org/~akpm/config-g5.txt > screenshot: http://userweb.kernel.org/~akpm/dsc5.jpg > > It does this shortly after bringing up eth0 (tg3), in dhclient. Try this: >Fro

networking crash in current mainline: sk_filter_delayed_uncharge()

2007-10-18 Thread Andrew Morton
powerpc mac G5 config: http://userweb.kernel.org/~akpm/config-g5.txt screenshot: http://userweb.kernel.org/~akpm/dsc5.jpg It does this shortly after bringing up eth0 (tg3), in dhclient. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PRO

Re: [PATCH] [Bug 9187] ir-functions.c:(.text+0xbce18): undefined reference to `input_event'

2007-10-18 Thread Randy Dunlap
On Thu, 18 Oct 2007 22:02:22 -0700 (PDT) David Miller wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > Date: Thu, 18 Oct 2007 21:53:50 -0700 > > > [EMAIL PROTECTED] wrote:] > > > > > > > > From: Randy Dunlap <[EMAIL PROTECTED]> > > > > Drivers that use lro functions should depend on INET, ot

Re: Throughput Bug?

2007-10-18 Thread Bill Fink
On Thu, 18 Oct 2007, Matthew Faulkner wrote: > Hey all > > I'm using netperf to perform TCP throughput tests via the localhost > interface. This is being done on a SMP machine. I'm forcing the > netperf server and client to run on the same core. However, for any > packet sizes below 523 the throu

Re: [NET]: Fix possible dev_deactivate race condition

2007-10-18 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 19 Oct 2007 13:36:24 +0800 > [NET]: Fix possible dev_deactivate race condition > > The function dev_deactivate is supposed to only return when > all outstanding transmissions have completed. Unfortunately > it is possible for store operations in th

[NET]: Fix possible dev_deactivate race condition

2007-10-18 Thread Herbert Xu
On Fri, Oct 19, 2007 at 12:20:25PM +0800, Herbert Xu wrote: > > In fact this bug exists elsewhere too. For example, the network > stack does this in net/sched/sch_generic.c: > > /* Wait for outstanding qdisc_run calls. */ > while (test_bit(__LINK_STATE_QDISC_RUNNING, &dev->state)) >

Re: [PATCH] [Bug 9187] ir-functions.c:(.text+0xbce18): undefined reference to `input_event'

2007-10-18 Thread David Miller
From: Randy Dunlap <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 21:53:50 -0700 > [EMAIL PROTECTED] wrote:] > > > > From: Randy Dunlap <[EMAIL PROTECTED]> > > Drivers that use lro functions should depend on INET, otherwise they > may not link correctly. Let's not select INET. Select should be u

Re: [PATCH] ip: justification for local port range robustness

2007-10-18 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 08:30:30 -0700 > > Justification of the Stephen Hemminger's patches, commit numbers > > 06393009000779b00a558fd2f280882cc7dc2008 > > 227b60f5102cda4e4ab792b526a59c8cb20cd9f8 > > > > 1. Allows using a port range of one single

Re: [PACKET]: Kill unused pg_vec_endpage() function

2007-10-18 Thread David Miller
Applied, thanks! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Please pull 'fixes-davem' branch of wireless-2.6

2007-10-18 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 18:08:59 -0400 > Another one for 2.6.24... Pulled, thanks John! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majo

Re: [PATCH] NAPI: kconfig prompt and deleted doc file

2007-10-18 Thread David Miller
From: Randy Dunlap <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 17:16:20 -0700 > From: Randy Dunlap <[EMAIL PROTECTED]> > > - make the kconfig NAPI option prompt consistent across all net drivers > (other than EXPERIMENTAL; can it now be removed also, or is the new > napi_struct implementation

Re: [PATCH] net: QoS/Sched as menuconfig

2007-10-18 Thread David Miller
From: Randy Dunlap <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 19:28:22 -0700 > From: Randy Dunlap <[EMAIL PROTECTED]> > > Convert "QoS and/or fair queueing" to menuconfig. > This makes it easy for someone to disable all sub-options with > one config symbol. > > Signed-off-by: Randy Dunlap <[EMAI

Re: [PATCH 0/4] Fix race between sk_filter reassign and sk_clone()

2007-10-18 Thread David Miller
From: Olof Johansson <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 21:29:47 -0500 > So, looks like rcu_dereference() returned NULL. I don't know the > filter code at all, but it seems like it might be a valid case? > sk_detach_filter() seems to handle a NULL sk_filter, at least. > > > So, this need

[PATCH] [Bug 9187] ir-functions.c:(.text+0xbce18): undefined reference to `input_event'

2007-10-18 Thread Randy Dunlap
[EMAIL PROTECTED] wrote:] From: Randy Dunlap <[EMAIL PROTECTED]> Drivers that use lro functions should depend on INET, otherwise they may not link correctly. Let's not select INET. Select should be used only for library-like code, not to enable subsystems. ERROR: "lro_flush_all" [drivers/ne

Re: broken PCNET32 in 2.6.24 requires experimental PCNET32_NAPI?

2007-10-18 Thread David Miller
From: Erez Zadok <[EMAIL PROTECTED]> Date: Fri, 19 Oct 2007 00:33:09 -0400 > Call Trace: > [] show_trace_log_lvl+0x1a/0x2f > [] show_stack_log_lvl+0x9b/0xa3 > [] show_registers+0x1b4/0x285 > [] die+0x100/0x21d > [] do_page_fault+0x434/0x515 > [] error_code+0x6a/0x70 > [] sock_setsockopt+0x4

Re: broken PCNET32 in 2.6.24 requires experimental PCNET32_NAPI?

2007-10-18 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Jeff Garzik writes: > Erez Zadok wrote: > > I'm using Linus's git tree as of commit > > d85714d81cc0408daddb68c10f7fd69eafe7c213. I built that kernel under vmware > > workstation 6.0.1 which emulates a pcnet32 nic. When I only turn on > > CONFIG_PCNET32, my network

Re: [PATCH 5/8] [MV643XX_ETH] Remove SHARED_REGS register address bias

2007-10-18 Thread Roland Dreier
> +static void __iomem *mv643xx_eth_base; > +return readl(((void __iomem *)mv643xx_eth_base) + offset); Given the declaration of mv643xx_eth_base as void __iomem * already, I don't understand why you need the cast to the same type here (and elsewhere in the driver). - R. - To unsubscribe

[PATCH] net: QoS/Sched as menuconfig

2007-10-18 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Convert "QoS and/or fair queueing" to menuconfig. This makes it easy for someone to disable all sub-options with one config symbol. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- net/sched/Kconfig | 10 +++--- 1 file changed, 3 insertions(+), 7 d

Re: [PATCH 0/4] Fix race between sk_filter reassign and sk_clone()

2007-10-18 Thread Olof Johansson
On Wed, Oct 17, 2007 at 09:23:02PM -0700, David Miller wrote: [...] > > The same problem exists for detaching filter (SO_DETACH_FILTER). > > > > The proposed fix consists of 3 preparation patches and the fix itself. > > > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> > > Looks good, appli

[PATCH 8/8] [MV643XX_ETH] Remove unused register defines

2007-10-18 Thread Lennert Buytenhek
Most of the register defines in drivers/net/mv643xx_eth.h aren't used at all. Nuke them -- we can always re-add them if/when we need them, and meanwhile, they unnecessarily clutter up the header file. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> Acked-by: Tzachi Perelstein <[EMAIL PROTECT

[PATCH 7/8] [MV643XX_ETH] Clean up mv643xx_eth.h

2007-10-18 Thread Lennert Buytenhek
Apply the following cleanups to drivers/net/mv643xx_eth.h: * Change "#define" to "#define". * Fix comment block style. * Wrap lines to fit in 80 columns. * Change "foo<<1" to "foo << 1". * Align addresses in the same column. * Parenthesize macro arguments. * Replace "(1<<24) | (1<<23) | (1<<22)" ty

[PATCH 6/8] [MV643XX_ETH] Remove MV643XX_ETH_ register prefix

2007-10-18 Thread Lennert Buytenhek
Now that all register address and bit defines are in private namespace (drivers/net/mv643xx_eth.h), we can safely remove the MV643XX_ETH_ prefix to conserve horizontal space. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> Acked-by: Tzachi Perelstein <[EMAIL PROTECTED]> Index: linux-2.6/driv

[PATCH 5/8] [MV643XX_ETH] Remove SHARED_REGS register address bias

2007-10-18 Thread Lennert Buytenhek
Start counting mv643xx_eth register addresses from zero, instead of from 0x2000 (MV643XX_ETH_SHARED_REGS.) Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> Acked-by: Tzachi Perelstein <[EMAIL PROTECTED]> Index: linux-2.6/drivers/net/mv643xx_eth.c ==

[PATCH 4/8] [MV643XX_ETH] Enable use on Orion platforms

2007-10-18 Thread Lennert Buytenhek
Allow Orion ARM platforms to use the mv643xx_eth driver. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> Acked-by: Tzachi Perelstein <[EMAIL PROTECTED]> Index: linux-2.6/drivers/net/Kconfig === --- linux-2.6.orig/drivers/net/Kco

[PATCH 3/8] [MV643XX_ETH] Disable RX/TX byte swapping on little-endian systems

2007-10-18 Thread Lennert Buytenhek
On little-endian systems, configure the SDMA unit with MV643XX_ETH_BLM_RX_NO_SWAP and MV643XX_ETH_BLM_TX_NO_SWAP. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> Acked-by: Tzachi Perelstein <[EMAIL PROTECTED]> Index: linux-2.6/drivers/net/mv643xx_eth.h ===

[PATCH 2/8] [MV643XX_ETH] Move ethernet register definitions into private header

2007-10-18 Thread Lennert Buytenhek
Move the mv643xx's ethernet-related register definitions from include/linux/mv643xx.h into drivers/net/mv643xx_eth.h, since they aren't of any use outside the ethernet driver. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> Acked-by: Tzachi Perelstein <[EMAIL PROTECTED]> Index: linux-2.6/dri

[PATCH 1/8] [MV643XX_ETH] Split off mv643xx_eth platform device data

2007-10-18 Thread Lennert Buytenhek
The mv643xx ethernet silicon block is also found in a couple of other Marvell chips. As a first step towards splitting off the mv643xx_eth bits from the rest of the mv643xx bits, this patch splits the mv643xx ethernet platform device data struct in linux/mv643xx.h off into linux/mv643xx_eth.h, and

[PATCH 0/8] [MV643XX_ETH] Add Orion support, and assorted cleanups

2007-10-18 Thread Lennert Buytenhek
This patch series adds support for the Orion's ethernet MAC (which is the same MAC as in the Discovery 643xx) to the mv643xx_eth driver, and performs various random cleanups all over the driver. Patches 1-3 are cleanups necessary to be able to support Orion. Patch 4 enables mv643xx_eth for ARCH_O

[PATCH] zd1211rw: fix a double include

2007-10-18 Thread John W. Linville
From: Holger Schurig <[EMAIL PROTECTED]> This patch removes all double includes of the same file. This makes scripts/checkincludes.pl happy. Signed-off-by: Holger Schurig <[EMAIL PROTECTED]> Signed-off-by: John W. Linville <[EMAIL PROTECTED]> --- Jeff, I missed the zd1211rw hunk of the "double in

Re: [PATCH,RFC] Marvell Orion SoC ethernet driver

2007-10-18 Thread Lennert Buytenhek
On Thu, Oct 18, 2007 at 03:15:36AM +0200, Lennert Buytenhek wrote: > > > +#define PORT_CONF0x400 > > > +#define PORT_CONF_EXT0x404 > > > +#define PORT_MAC_LO 0x414 > > > +#define PORT_MAC_HI 0x418 > > > +#define PORT_SDMA0x41c >

Re: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings

2007-10-18 Thread David Miller
From: Emil Medve <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 17:15:13 -0500 > drivers/net/ucc_geth.c: In function 'ucc_geth_startup': > drivers/net/ucc_geth.c:2614: warning: assignment makes integer from pointer > without a cast > drivers/net/ucc_geth.c:2651: warning: assignment makes integer from

[PATCH] NAPI: kconfig prompt and deleted doc file

2007-10-18 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> - make the kconfig NAPI option prompt consistent across all net drivers (other than EXPERIMENTAL; can it now be removed also, or is the new napi_struct implementation now EXPERIMENTAL ?) - remove comment about the now-deleted NAPI_HOWTO.txt file - clean u

[PATCH] [POWERPC] ucc_geth: Eliminate compile warnings

2007-10-18 Thread Emil Medve
drivers/net/ucc_geth.c: In function 'ucc_geth_startup': drivers/net/ucc_geth.c:2614: warning: assignment makes integer from pointer without a cast drivers/net/ucc_geth.c:2651: warning: assignment makes integer from pointer without a cast Signed-off-by: Emil Medve <[EMAIL PROTECTED]> --- This pa

Please pull 'fixes-jgarzik' branch of wireless-2.6

2007-10-18 Thread John W. Linville
Jeff, Some bug fixes for 2.6.24. There is also a USB ID for rt2x00, a one-liner -- it would seem like a bug fix if you owned that device. :-) Thanks, John --- Individual patches are available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/fixes-jgarzik --

Please pull 'fixes-davem' branch of wireless-2.6

2007-10-18 Thread John W. Linville
Dave, Another one for 2.6.24... Thanks, John --- Individual patch available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/fixes-davem --- The following changes since commit 52f095ee88d8851866bc7694ab991ca5abf21d5e: Pavel Emelyanov (1): [IPV6]:

[PATCH 06/13] r8169: use the existing symbolic name of vendor PCI ID 0x1259

2007-10-18 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 951c56e..c290aa5 100644 --- a/drivers/net/r8169.c +++ b/drivers/ne

[PATCH 04/13] r8169: MSI support

2007-10-18 Thread Francois Romieu
It is currently limited to the tested 0x8136 and 0x8168. 8169sb/8110sb ought to handle it as well where they support MSI. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> Tester-Cc: Rolf Eike Beer <[EMAIL PROTECTED]> --- drivers/net/r8169.c | 50

[PATCH 03/13] r8169: convert bitfield to plain enum mask

2007-10-18 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 9c11087..16ecba1 100644 --- a/drivers/net/r8169.c +++

[PATCH 08/13] r8169: remove dead wood

2007-10-18 Thread Francois Romieu
Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c | 66 +- 1 files changed, 2 insertions(+), 64 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 9deda50..3a3ba79

[PATCH 09/13] r8169: make room for more phy init changes

2007-10-18 Thread Francois Romieu
The code is reworked to easily add phy-dependant init changes. No change of behavior should be noticed. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c | 56 -- 1 files changed, 31 inse

[PATCH 12/13] r8169: update the phy init for the 8168C

2007-10-18 Thread Francois Romieu
The values have been updated between version 8.002.00 and version 8.003.00 of Realtek's r8168 driver. This modification syncs the 8168C with version 8.003.00. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c |2 ++ 1 files changed,

[PATCH 05/13] r8169: remove private net_device_stats structure

2007-10-18 Thread Francois Romieu
Use net_device_stats in the net_device structure. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c | 34 +- 1 files changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/net/r8169.c b/drivers

[PATCH 13/13] r8169: more phy init for the 8168

2007-10-18 Thread Francois Romieu
Realtek's r8168 driver version 8.003.00 adds new init sequences (they do not appear in version 8.002.00). Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c | 34 ++ 1 files changed, 34 insertions(+), 0 d

[PATCH 10/13] r8169: phy init for the 8168

2007-10-18 Thread Francois Romieu
The values have been extracted from Realtek's r8168 driver version 8.002.00. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c | 52 +++ 1 files changed, 52 insertions(+), 0 deletions(-)

[PATCH 11/13] r8169: phy init cleanup

2007-10-18 Thread Francois Romieu
Consistent use of hexadecimal. No change of behavior otherwise. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/ne

[PATCH 07/13] r8169: add MAC identifiers

2007-10-18 Thread Francois Romieu
The identifiers have been extracted from Realtek's drivers: - version 8.002.00 of the r8168 driver - version 6.002.00 of the r8169 driver - version 1.002.00 of the r8101 driver 1. RTL_GIGA_MAC_VER_17 (8168Bf) is isolated from RTL_GIGA_MAC_VER_12 (8168Be) Both are still handled the same in rtl81

[PATCH 01/13] r8169: add KERN_DEBUG to dprintk (trivial)

2007-10-18 Thread Francois Romieu
- prefix dprintk with KERN_DEBUG - fix a bug with existing use of dprintk (PFX KERN_INFO PFX) Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> Cc: Edward Hsu <[EMAIL PROTECTED]> --- drivers/net/r8169.c |5 +++-- 1 files changed, 3 insertions(+)

Re: broken PCNET32 in 2.6.24 requires experimental PCNET32_NAPI?

2007-10-18 Thread Jeff Garzik
Erez Zadok wrote: I'm using Linus's git tree as of commit d85714d81cc0408daddb68c10f7fd69eafe7c213. I built that kernel under vmware workstation 6.0.1 which emulates a pcnet32 nic. When I only turn on CONFIG_PCNET32, my network interface doesn't seem to come up fully: my dhcp server sees a requ

[PATCH 00/13] r8169: pull request for 'upstream-jeff' branch

2007-10-18 Thread Francois Romieu
Please pull from branch 'upstream-jeff' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git upstream-jeff to get the changes below. Following mails on netdev describe each patch. Distance from 'master' (d85714d81cc0408daddb68c10f7fd69eafe7c213) ---

broken PCNET32 in 2.6.24 requires experimental PCNET32_NAPI?

2007-10-18 Thread Erez Zadok
I'm using Linus's git tree as of commit d85714d81cc0408daddb68c10f7fd69eafe7c213. I built that kernel under vmware workstation 6.0.1 which emulates a pcnet32 nic. When I only turn on CONFIG_PCNET32, my network interface doesn't seem to come up fully: my dhcp server sees a request, offers an IP ad

[PATCH] trivial - QUICC UCC driver - remove buggy and unused vdbg macro

2007-10-18 Thread Joe Perches
remove buggy and unused vdbg macro Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/drivers/net/ucc_geth_mii.c b/drivers/net/ucc_geth_mii.c index df884f0..a4b481c 100644 --- a/drivers/net/ucc_geth_mii.c +++ b/drivers/net/ucc_geth_mii.c @@ -46,13 +46,6 @@ #include "ucc_geth_mii.h" #in

Re: [PATCH] pcnet32: fix non-napi packet reception

2007-10-18 Thread Lennart Sorensen
On Wed, Oct 17, 2007 at 05:04:01PM -0700, Don Fry wrote: > I have no objections myself. It has been slowly moving that direction. > First with the napi implementation, default off, labeled experimental. > Then removing experimental and then making the default on. > > If any other user of the pcne

[PATCH] phy/bitbang: missing MODULE_LICENSE

2007-10-18 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Missing MODULE_LICENSE(), loading this module taints the kernel. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/net/phy/mdio-bitbang.c |2 ++ 1 file changed, 2 insertions(+) --- linux-2.6.23-git7.orig/drivers/net/phy/mdio-bitbang.c +++ lin

[2/3] Distributed storage. Network state machine.

2007-10-18 Thread Evgeniy Polyakov
Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/block/dst/kst.c b/drivers/block/dst/kst.c new file mode 100644 index 000..b0608c9 --- /dev/null +++ b/drivers/block/dst/kst.c @@ -0,0 +1,1606 @@ +/* + * 2007+ Copyright (c) Evgeniy Polyakov <[EMAIL PROTECTED]> + * All rig

[3/3] Distributed storage. Documentation and algorithms.

2007-10-18 Thread Evgeniy Polyakov
Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/Documentation/dst/algorithms.txt b/Documentation/dst/algorithms.txt new file mode 100644 index 000..1437a6a --- /dev/null +++ b/Documentation/dst/algorithms.txt @@ -0,0 +1,115 @@ +Each storage by itself is just a set of contiguou

[1/3] Distributed storage. Core files.

2007-10-18 Thread Evgeniy Polyakov
Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/block/Makefile b/drivers/block/Makefile index dd88e33..fcf042d 100644 --- a/drivers/block/Makefile +++ b/drivers/block/Makefile @@ -29,3 +29,4 @@ obj-$(CONFIG_VIODASD) += viodasd.o obj-$(CONFIG_BLK_DEV_SX8) += s

[0/3] Distributed storage. Mirror algo extension for automatic recovery.

2007-10-18 Thread Evgeniy Polyakov
Hi. I'm pleased to announce sixth release of the distributed storage subsystem, which allows to form a storage on top of remote and local nodes, which in turn can be exported to another storage as a node to form tree-like storages. This release includes mirroring algorithm extension, which allows

Re: [PATCH v3 0/4] FEC - fast ethernet controller for mpc52xx

2007-10-18 Thread Jeff Garzik
Grant Likely wrote: On 10/15/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Domen Puncer wrote: Hello! If there are no objections, I would like to get this merged when bestcomm goes in (any time now?). It's split into four parts: 1 - device tree 2 - small bestcomm change 3 - the actual driver 4 -

Re: [PATCH 1/2] r8169 - trivial fixes - add KERN_DEBUG to dprintk

2007-10-18 Thread Francois Romieu
Joe Perches <[EMAIL PROTECTED]> : > Prefix dprintk with KERN_DEBUG > Fix a bug with existing use of dprintk (PFX KERN_INFO PFX) > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Ok, I will add #1 and #2 to the next submission to Jeff. -- Ueimor - To unsubscribe from this list: send the line "u

[PATCH 1/2] r8169 - trivial fixes - add KERN_DEBUG to dprintk

2007-10-18 Thread Joe Perches
Prefix dprintk with KERN_DEBUG Fix a bug with existing use of dprintk (PFX KERN_INFO PFX) Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 419c00c..9c11087 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -44,7 +44,8 @@

[PATCH 2/2] r8169 - trivial fix - printk(PFX KERN_...) to printk(KERN_ PFX...)

2007-10-18 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 419c00c..9c11087 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -2310,7 +2311,7 @@ static void rtl8169_reinit_task(struct work_struct *work) ret = rtl8169_open(dev);

Re: e100 problems in .23rc8 ?

2007-10-18 Thread Chuck Ebbert
On 10/18/2007 01:59 PM, Kok, Auke wrote: > David Mack wrote: >> It appears that the needed e100 fix made it into the Fedora >> 2.6.23.1-23.fc8 kernel. Boots reliably now. >> >> Huge thanks and great work, guys. > > > DaveJ, I didn't push anything upstream. Can you verify this now works? > We di

Re: e100 problems in .23rc8 ?

2007-10-18 Thread Kok, Auke
David Mack wrote: > It appears that the needed e100 fix made it into the Fedora > 2.6.23.1-23.fc8 kernel. Boots reliably now. > > Huge thanks and great work, guys. DaveJ, I didn't push anything upstream. Can you verify this now works? Auke > > Dave > >> -Original Message- >> From: K

RE: e100 problems in .23rc8 ?

2007-10-18 Thread David Mack
It appears that the needed e100 fix made it into the Fedora 2.6.23.1-23.fc8 kernel. Boots reliably now. Huge thanks and great work, guys. Dave > -Original Message- > From: Kok, Auke [mailto:[EMAIL PROTECTED] > Sent: Friday, October 12, 2007 10:05 AM > To: Herbert Xu > Cc: David Mack; Da

Re: bizarre network timing problem

2007-10-18 Thread Rick Jones
Felix von Leitner wrote: the packet trace was a bit too cooked perhaps, but there were indications that at times the TCP window was going to zero - perhaps something with window updates or persist timers? Does TCP use different window sizes on loopback? Why is this not happening on ethernet?

Re: Throughput Bug?

2007-10-18 Thread Rick Jones
Matthew Faulkner wrote: Hey all I'm using netperf to perform TCP throughput tests via the localhost interface. This is being done on a SMP machine. I'm forcing the netperf server and client to run on the same core. However, for any packet sizes below 523 the throughput is much lower compared to

Re: multicast: bug or "feature"

2007-10-18 Thread Vlad Yasevich
Vlad Yasevich wrote: > We've been trying to field some questions regarding multicast > behavior and one such behavior has stumped us. > > I've reproduced the following behavior on 2.6.23. > > The application opens 2 sockets. One socket is the receiver > and it simply binds to 0.0.0.0:2000 and jo

[PACKET]: Kill unused pg_vec_endpage() function

2007-10-18 Thread Patrick McHardy
[PACKET]: Kill unused pg_vec_endpage() function The conversion to vm_insert_page() left this unused function behind, remove it. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index e11000a..d093650 100644 --- a/net/packet/af_packet

Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-18 Thread Maciej W. Rozycki
On Thu, 18 Oct 2007, Oleg Nesterov wrote: > If we can't just cancel the work, can't we do something like > > if (cancel_work_sync(w)) > w->func(w); > > instead? We do an equivalent of this -- all that we care about that w->func(w) would do is enable_irq() and the rest we w

Throughput Bug?

2007-10-18 Thread Matthew Faulkner
Hey all I'm using netperf to perform TCP throughput tests via the localhost interface. This is being done on a SMP machine. I'm forcing the netperf server and client to run on the same core. However, for any packet sizes below 523 the throughput is much lower compared to the throughput when the pa

Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-18 Thread Oleg Nesterov
On 10/18, Jarek Poplawski wrote: > > +/** > + * flush_work_sync - block until a work_struct's callback has terminated ^^^ Hmm... > + * Similar to cancel_work_sync() but will only busy wait (without cancel) > + * if the work is

Re: [PATCH] ip: justification for local port range robustness

2007-10-18 Thread Stephen Hemminger
On Thu, 18 Oct 2007 16:27:37 +0200 Anton Arapov <[EMAIL PROTECTED]> wrote: > Hi! > > There is a justifying patch for Stephen's patches. Stephen's patches > disallows using a port range of one single port and brakes the meaning > of the 'remaining' variable, in some places it has different meani

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-18 Thread Maciej W. Rozycki
On Thu, 18 Oct 2007, Jarek Poplawski wrote: > Technically until free_irq returns a handler should respond to calls > and with proper hardware it should have no problem with checking if > it's its interrupt, even after disabling this hardware, because of > possible races. Well, the hardirq handle

Re: [RFC] remove netpoll receive code

2007-10-18 Thread Stephen Hemminger
On Thu, 18 Oct 2007 00:02:44 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 17 Oct 2007 23:28:38 -0700 (PDT) David Miller <[EMAIL PROTECTED]> > wrote: > > > From: Stephen Hemminger <[EMAIL PROTECTED]> > > Date: Wed, 17 Oct 2007 13:21:31 -0700 > > > > > I propose that we take out all t

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-10-18 Thread Jarek Poplawski
On Thu, Oct 18, 2007 at 12:30:35PM +0100, Maciej W. Rozycki wrote: > On Wed, 17 Oct 2007, Jarek Poplawski wrote: > > > I'm not sure free_irq() should maintain the depth count - rather warn > > on not zero. But, IMHO, any activity on freed irq seems suspicious to > > me (and doesn't look like very

[PATCH] ip: justification for local port range robustness

2007-10-18 Thread Anton Arapov
Hi! There is a justifying patch for Stephen's patches. Stephen's patches disallows using a port range of one single port and brakes the meaning of the 'remaining' variable, in some places it has different meaning. My patch gives back the sense of 'remaining' variable. It should mean how many por

RE: [PATCH] Fix ethernet multicast for ucc_geth.

2007-10-18 Thread Li Yang-r58472
> -Original Message- > From: Joakim Tjernlund [mailto:[EMAIL PROTECTED] > Sent: Wednesday, October 17, 2007 5:06 PM > To: Netdev; Li Yang-r58472 > Subject: [PATCH] Fix ethernet multicast for ucc_geth. > > >From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17 > 00:00:00 2001 > From: J

Re: [PATCH v3 0/4] FEC - fast ethernet controller for mpc52xx

2007-10-18 Thread Grant Likely
On 10/15/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Domen Puncer wrote: > > Hello! > > > > If there are no objections, I would like to get this merged > > when bestcomm goes in (any time now?). > > > > It's split into four parts: > > 1 - device tree > > 2 - small bestcomm change > > 3 - the actua

Re: about multiple network interface

2007-10-18 Thread Evgeniy Polyakov
On Thu, Oct 18, 2007 at 09:06:40PM +0800, wit ([EMAIL PROTECTED]) wrote: > Hi all, > >Sorry, I don't know if this is the right mail list. I got the > following question: >I have a e100 card and a e1000 card. Whenever I boot the system, I > found the eth0 matches the e1000 card, and the eth

Re: BUG: unable to handle kernel NULL pointer dereference at virtual address 000000b0

2007-10-18 Thread Krzysztof Oledzki
On Thu, 18 Oct 2007, Patrick McHardy wrote: Krzysztof Oledzki wrote: Hum, you are using IPT_TPROXY thing, which is not in linux-2.6.22.9 It is only compiled in, not used at the moment. But at least the previous version (before those patches posted a week ago) touches the routing code in e

about multiple network interface

2007-10-18 Thread wit
Hi all, Sorry, I don't know if this is the right mail list. I got the following question: I have a e100 card and a e1000 card. Whenever I boot the system, I found the eth0 matches the e1000 card, and the eth2 matches the other. How can I force the eth0 to match the e100 card and the eth2 to

[PATCH] Fix again the fl6_sock_lookup() fixed locking

2007-10-18 Thread Pavel Emelyanov
YOSHIFUJI fairly pointed out, that the users increment should be done under the ip6_sk_fl_lock not to give IPV6_FL_A_PUT a chance to put this count to zero and release the flowlabel. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Cc: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- diff --git a/net

Re: [PATCH] Fix again the fl6_sock_lookup() fixed locking

2007-10-18 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 16:36:58 +0400 > YOSHIFUJI fairly pointed out, that the users increment should > be done under the ip6_sk_fl_lock not to give IPV6_FL_A_PUT a > chance to put this count to zero and release the flowlabel. > > Signed-off-by: Pavel Eme

Re: [PATCH 2/3] Lost locking in fl6_sock_lookup

2007-10-18 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 16:22:49 +0400 > Oops. You're right here :( I looked at the ip6_fl_lock > and messed it with the ip6_sk_fl_lock. > > Should I resend the whole patch, or just make an > incremental one? Please make an incremental one. And hurry, I

Re: [PATCH 2/3] Lost locking in fl6_sock_lookup

2007-10-18 Thread Pavel Emelyanov
David Miller wrote: > From: Pavel Emelyanov <[EMAIL PROTECTED]> > Date: Thu, 18 Oct 2007 15:53:52 +0400 > >> This routine scans the ipv6_fl_list whose update is >> protected with the socket lock and the ip6_sk_fl_lock. >> >> Since the socket lock is not taken in the lookup, use >> the other one. >

Re: [PATCH 3/3] Fix race in ipv6_flowlabel_opt() when inserting two labels

2007-10-18 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 15:59:14 +0400 > In the IPV6_FL_A_GET case the hash is checked for flowlabels > with the given label. If it is not found, the lock, protecting > the hash, is dropped to be re-get for writing. After this a > newly allocated entry is

Re: [PATCH 2/3] Lost locking in fl6_sock_lookup

2007-10-18 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 15:53:52 +0400 > This routine scans the ipv6_fl_list whose update is > protected with the socket lock and the ip6_sk_fl_lock. > > Since the socket lock is not taken in the lookup, use > the other one. > > Signed-off-by: Pavel Emely

Re: [PATCH 1/3] Lost locking when inserting a flowlabel in ipv6_fl_list

2007-10-18 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 15:51:41 +0400 > The new flowlabels should be inserted into the sock list > under the ip6_sk_fl_lock. This was lost in one place. > > This list is naturally protected with the socket lock, but > the fl6_sock_lookup() is called witho

Re: [PATCH 2/3] Lost locking in fl6_sock_lookup

2007-10-18 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 16:11:58 +0400 > YOSHIFUJI Hideaki wrote: > > In article <[EMAIL PROTECTED]> (at Thu, 18 Oct 2007 15:53:52 +0400), Pavel > > Emelyanov <[EMAIL PROTECTED]> says: > > > >> This routine scans the ipv6_fl_list whose update is > >> prot

Re: [PATCH 2/3] Lost locking in fl6_sock_lookup

2007-10-18 Thread Pavel Emelyanov
YOSHIFUJI Hideaki wrote: > In article <[EMAIL PROTECTED]> (at Thu, 18 Oct 2007 15:53:52 +0400), Pavel > Emelyanov <[EMAIL PROTECTED]> says: > >> This routine scans the ipv6_fl_list whose update is >> protected with the socket lock and the ip6_sk_fl_lock. > >> struct ip6_flowlabel *f

Re: [Bugme-new] [Bug 9174] New: linux-2.6.23-git11 kernel panic

2007-10-18 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 12:58:42 +0200 > Patrick McHardy wrote: > > Andrew Morton wrote: > >> On Wed, 17 Oct 2007 07:36:16 -0700 (PDT) > >> [EMAIL PROTECTED] wrote: > >> > >>> http://bugzilla.kernel.org/show_bug.cgi?id=9174 > >>> > >>>Summary: l

Re: [PATCH] [TCP]: Remove lost_retrans zero special cases

2007-10-18 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 18 Oct 2007 14:07:42 +0300 (EEST) > Dave, please put this one to net-2.6 and forget the other patch with > title "[TCP]: Add highest_sack_end_seq check back...", it would just > add another (wrong) zero special case back (they won't conflict wit

Re: [PATCH 2/3] Lost locking in fl6_sock_lookup

2007-10-18 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 18 Oct 2007 15:53:52 +0400), Pavel Emelyanov <[EMAIL PROTECTED]> says: > This routine scans the ipv6_fl_list whose update is > protected with the socket lock and the ip6_sk_fl_lock. > struct ip6_flowlabel *fl = sfl->fl; > if (fl

[PATCH 3/3] Fix race in ipv6_flowlabel_opt() when inserting two labels

2007-10-18 Thread Pavel Emelyanov
In the IPV6_FL_A_GET case the hash is checked for flowlabels with the given label. If it is not found, the lock, protecting the hash, is dropped to be re-get for writing. After this a newly allocated entry is inserted, but no checks are performed to catch a classical SMP race, when the conflicting

[PATCH 2/3] Lost locking in fl6_sock_lookup

2007-10-18 Thread Pavel Emelyanov
This routine scans the ipv6_fl_list whose update is protected with the socket lock and the ip6_sk_fl_lock. Since the socket lock is not taken in the lookup, use the other one. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/ipv6/ip6_flowlabel.c b/net/ipv6/ip6_flowlabel.c

[PATCH 1/3] Lost locking when inserting a flowlabel in ipv6_fl_list

2007-10-18 Thread Pavel Emelyanov
The new flowlabels should be inserted into the sock list under the ip6_sk_fl_lock. This was lost in one place. This list is naturally protected with the socket lock, but the fl6_sock_lookup() is called without it, so another protection is required. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED

Re: BUG: unable to handle kernel NULL pointer dereference at virtual address 000000b0

2007-10-18 Thread Patrick McHardy
Krzysztof Oledzki wrote: Hum, you are using IPT_TPROXY thing, which is not in linux-2.6.22.9 It is only compiled in, not used at the moment. But at least the previous version (before those patches posted a week ago) touches the routing code in exactly that function. - To unsubscribe from this

  1   2   >