YOSHIFUJI Hideaki wrote:
> In article <[EMAIL PROTECTED]> (at Thu, 18 Oct 2007 15:53:52 +0400), Pavel
> Emelyanov <[EMAIL PROTECTED]> says:
>
>> This routine scans the ipv6_fl_list whose update is
>> protected with the socket lock and the ip6_sk_fl_lock.
>
>> struct ip6_flowlabel *fl = sfl->fl;
>> if (fl->label == label) {
>> + read_unlock_bh(&ip6_sk_fl_lock);
>> fl->lastuse = jiffies;
>> atomic_inc(&fl->users);
>> return fl;
>
> We should increment fl->users within the critical section, shouldn't we?
Not necessary. The users is more than zero (because it is
linked in the sock's list) so garbage collector won't catch
it in any way.
Thanks,
Pavel
> --yoshfuji
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
