Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
to receive the following updates:
drivers/net/pcmcia/3c589_cs.c |2 +-
drivers/net/r8169.c | 14 +-
drivers/net/sky2.c| 37 +++
On Sep 24, 2007, at 13:32:23, Lennart Sorensen wrote:
On Fri, Sep 21, 2007 at 11:37:52PM +0100, Denys Vlasenko wrote:
But I compile net/* into bzImage. I like netbooting :)
Isn't it possible to netboot with an initramfs image? I am pretty
sure I have seen some systems do exactly that.
Yea
Stephen Hemminger wrote:
> On Mon, 24 Sep 2007 18:55:38 +0200
> Patrick McHardy <[EMAIL PROTECTED]> wrote:
>
>>Eric W. Biederman wrote:
>>
>>>A really good fix would be to remove the binary side and then to
>>>modify brnf_sysctl_call_tables to allocate a temporary ctl_table and
>>>integer on the s
Stephen Hemminger wrote:
Be more selective about when to enable the ram buffer watchdog code.
It is unnecessary on XL A3 or later revs, and with Yukon FE
the buffer is so small (4K) that the watchdog detects false positives.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
applied
-
To u
Stephen Hemminger wrote:
One more snippet of PHY initialization required for FE+ chips.
Discovered in latest sk98lin 10.21.1.3 driver.
Please apply to 2.6.23.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
One more snippet of PHY initialization required for FE+ chips.
Discovered in latest sk98lin 10.21.1.3 driver.
Please apply to 2.6.23.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/drivers/net/sky2.c2007-09-24 09:10:36.0 -0700
+++ b/drivers/net/sky2.c2007-09-
> > I really just need to put my nose to the grindstone and get the
> > patches together and to the list...stay tuned.
> >
> > Thanks,
> > -PJ Waskiewicz
> > -
>
>
> Since we are redoing this, is there any way to make the whole
> TX path more lockless? The existing model seems to be more
> o
On Mon, 24 Sep 2007 16:47:06 -0700
"Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> wrote:
> > On Mon, 2007-24-09 at 15:57 -0700, Waskiewicz Jr, Peter P wrote:
> >
> > > I've looked at that as a candidate to use. The lock for
> > enqueue would
> > > be needed when actually placing the skb into the
jamal wrote:
If the intel folks will accept the patch i'd really like to kill
the e1000 LLTX interface.
If I understood DaveM correctly, it is sounding like we want to
deprecate all of use LLTX on "real" hardware? If so, several such
projects might be considered, as well as possibly simplif
> On Mon, 2007-24-09 at 15:57 -0700, Waskiewicz Jr, Peter P wrote:
>
> > I've looked at that as a candidate to use. The lock for
> enqueue would
> > be needed when actually placing the skb into the
> appropriate software
> > queue for the qdisc, so it'd be quick.
>
> The enqueue is easy to c
On Mon, 2007-24-09 at 15:57 -0700, Waskiewicz Jr, Peter P wrote:
> I've looked at that as a candidate to use. The lock for enqueue would
> be needed when actually placing the skb into the appropriate software
> queue for the qdisc, so it'd be quick.
The enqueue is easy to comprehend. The single
> The one thing that seems obvious is to use
> dev->hard_prep_xmit() in the patches i posted to select the
> xmit ring. You should be able to do figure out the txmit ring
> without holding any lock.
I've looked at that as a candidate to use. The lock for enqueue would
be needed when actually
I have updated the driver howto to match the patches i posted yesterday.
attached.
cheers,
jamal
Heres the begining of a howto for driver authors.
The intended audience for this howto is people already
familiar with netdevices.
1.0 Netdevice Pre-requisites
--
For
jamal wrote:
> On Mon, 2007-24-09 at 00:00 -0700, Kok, Auke wrote:
>
>> that's bad to begin with :) - please send those separately so I can
>> fasttrack them
>> into e1000e and e1000 where applicable.
>
> Ive been CCing you ;-> Most of the changes are readability and
> reusability with the batch
On Mon, 2007-24-09 at 12:12 -0700, Waskiewicz Jr, Peter P wrote:
> Hi Jamal,
> I've been (slowly) working on resurrecting the original design
> of my multiqueue patches to address this exact issue of the queue_lock
> being a hot item. I added a queue_lock to each queue in the subqueue
> str
On Mon, 2007-24-09 at 00:00 -0700, Kok, Auke wrote:
> that's bad to begin with :) - please send those separately so I can fasttrack
> them
> into e1000e and e1000 where applicable.
Ive been CCing you ;-> Most of the changes are readability and
reusability with the batching.
> But yes, I'm very
The bug http://bugzilla.kernel.org/show_bug.cgi?id=5731
describes an issue where write() can't be used to generate a zero-length
datagram (but send, and sendto do work).
I think the following is needed:
--- a/net/socket.c 2007-08-20 09:54:28.0 -0700
+++ b/net/socket.c 2007-09-24
Hi David
Can you please pull the following changes since commit
a41d3015c11a4e864b95cb57f579f2d8f40cd41b:
David S. Miller (1):
Revert "PCI: disable MSI by default on systems with Serverworks HT1000
chips"
which are available in the git repository at:
[EMAIL PROTECTED]:/pub/scm/linu
The existing OF glue code was crufty and broken. Rather than fix it, it
will be removed, and the ethernet driver now talks to the device tree
directly.
The old, non-CONFIG_PPC_CPM_NEW_BINDING code can go away once CPM
platforms are dropped from arch/ppc (which will hopefully be soon), and
existin
[Sorry about the duplicate mail, Thomas: I got the netdev address
wrong on the first try.]
lockdep reported a circular dependency between cb_mutex and
genl_mutex, as follows:
-> #1 (nlk->cb_mutex){--..}:
[] __lock_acquire+0x9c8/0xb98
[] lock_acquire+0x5d/0x75
[] __mutex_lock_
Joe Perches <[EMAIL PROTECTED]> writes:
> I'd prefer something like this, which removes the unnecessary
> kmalloc/kfree pairs or the equivalent conversions to functions.
I have changed this to a static buffer. Since this is only in
#ifdef CONFIG_CAN_DEBUG_CORE, it shouldn't hurt.
> #define can_
> I have submitted this before; but here it is again.
> Against net-2.6.24 from yesterday for this and all following patches.
>
>
> cheers,
> jamal
Hi Jamal,
I've been (slowly) working on resurrecting the original design
of my multiqueue patches to address this exact issue of the queue_
Rick Jones wrote:
Perf-wise, you could clone the skbs up front, then deliver them to
the nic in a tight loop. This would mitigate the added overhead
introduced by calling skb_clone() in the loop doing transmits...
That only works if you are sending a small number of skbs. You can't
pre-clon
Perf-wise, you could clone the skbs up front, then deliver them to the
nic in a tight loop. This would mitigate the added overhead
introduced by calling skb_clone() in the loop doing transmits...
That only works if you are sending a small number of skbs. You can't
pre-clone several minutes w
From: Steve Wise <[EMAIL PROTECTED]>
Date: Mon, 24 Sep 2007 08:54:13 -0500
> I think pktgen should be cloning the skbs using skb_clone(). Then it
> will work for all devices, eh?
The problem is that skb_clone() is (relatively) expensive and
pktgen is trying to just grab a reference to the SKB i
On Fri, Sep 21, 2007 at 11:37:52PM +0100, Denys Vlasenko wrote:
> But I compile net/* into bzImage. I like netbooting :)
Isn't it possible to netboot with an initramfs image? I am pretty sure
I have seen some systems do exactly that.
--
Len Sorensen
-
To unsubscribe from this list: send the line
On Wed, 2007-09-19 at 12:54 -0700, David Miller wrote:
> Applied to net-2.6.24, thanks Joe!
Here is a patch that adds some type safety to print_mac
by using a struct print_mac_buf * instead of char *.
It also reduces the defconfig vmlinux size by 8 bytes.
Signed-off-by: Joe Perches <[EMAIL PROT
On Mon, 24 Sep 2007 15:41:54 +0100 (BST) "Maciej W. Rozycki" <[EMAIL
PROTECTED]> wrote:
> On Fri, 21 Sep 2007, Andrew Morton wrote:
>
> > > A driver model and phylib update.
> >
> > akpm:/usr/src/25> diffstat patches/git-net.patch | tail -n 1
> > 1013 files changed, 187667 insertions(+), 2358
On Mon, 24 Sep 2007 17:37:00 +0200
Moni Shoua <[EMAIL PROTECTED]> wrote:
> Allow to enslave devices when the bonding device is not up. Over the
> discussion
> held at the previous post this seemed to be the most clean way to go, where it
> is not expected to cause instabilities.
>
> Normally, th
When bonding enslaves non Ethernet devices it takes pointers to functions
in the module that owns the slaves. In this case it becomes unsafe
to keep the bonding master registered after last slave was unenslaved
because we don't know if the pointers are still valid. Destroying the bond
when slav
Update the "don't change MAC of slaves" functionality added in
previous changes to be a generic option, rather than something tied to IB
devices, as it's occasionally useful for regular ethernet devices as well.
Adds "fail_over_mac" option (which is automatically enabled for IB
slaves), ap
Delay sending a gratuitous_arp when LINK_STATE_LINKWATCH_PENDING bit
in dev->state field is on. This improves the chances for the arp packet to
be transmitted.
Signed-off-by: Moni Shoua
---
drivers/net/bonding/bond_main.c | 24 +---
drivers/net/bonding/bonding.h |1 +
Hi,
Steve Wise writes:
> I think pktgen should be cloning the skbs using skb_clone(). Then it
> will work for all devices, eh?
pktgen assumes for "fastpath" sending exclusive ownership of
the skb. And does a skb_get to avoid final skb destruction so
the same skb can be sent over and over
bonding sometimes uses Ethernet constants (such as MTU and address length) which
are not good when it enslaves non Ethernet devices (such as InfiniBand).
Signed-off-by: Moni Shoua
---
drivers/net/bonding/bond_main.c |3 ++-
drivers/net/bonding/bond_sysfs.c | 10 --
drivers/net/bon
Steve Wise wrote:
Ben Greear wrote:
Steve Wise wrote:
I think pktgen should be cloning the skbs using skb_clone(). Then
it will work for all devices, eh?
That might work, but it would decrease performance slightly (or,
increase CPU load at least).
Perf-wise, you could clone the skbs up fro
Allow to enslave devices when the bonding device is not up. Over the discussion
held at the previous post this seemed to be the most clean way to go, where it
is not expected to cause instabilities.
Normally, the bonding driver is UP before any enslavement takes place.
Once a netdevice is UP, the
This patch allows for enslaving netdevices which do not support
the set_mac_address() function. In that case the bond mac address is the one
of the active slave, where remote peers are notified on the mac address
(neighbour) change by Gratuitous ARP sent by bonding when fail-over occurs
(this is al
This patch changes some of the bond netdevice attributes and functions
to be that of the active slave for the case of the enslaved device not being
of ARPHRD_ETHER type. Basically it overrides those setting done by
ether_setup(),
which are netdevice **type** dependent and hence might be not approp
When the bonding device senses a carrier loss of its active slave it replaces
that slave with a new one. In between the times when the carrier of an IPoIB
device goes down and ipoib_neigh is destroyed, it is possible that the
bonding driver will send a packet on a new slave that uses an old ipoib_n
IPoIB uses a two layer neighboring scheme, such that for each struct neighbour
whose device is an ipoib one, there is a struct ipoib_neigh buddy which is
created on demand at the tx flow by an ipoib_neigh_alloc(skb->dst->neighbour)
call.
When using the bonding driver, neighbours are created by the
This patch series is the sixth version (see below link to V5) of the
suggested changes to the bonding driver so it would be able to support
non ARPHRD_ETHER netdevices for its High-Availability (active-backup) mode.
Patches 1-8 were originally submitted in V5 and patch 9 is an addition by Jay.
Ben Greear wrote:
Steve Wise wrote:
I think pktgen should be cloning the skbs using skb_clone(). Then it
will work for all devices, eh?
That might work, but it would decrease performance slightly (or,
increase CPU load at least).
Perf-wise, you could clone the skbs up front, then deliver th
On Fri, 21 Sep 2007, Andrew Morton wrote:
> > A driver model and phylib update.
>
> akpm:/usr/src/25> diffstat patches/git-net.patch | tail -n 1
> 1013 files changed, 187667 insertions(+), 23587 deletions(-)
>
> Sorry, but raising networking patches against Linus's crufty
> old mainline tree j
Steve Wise wrote:
I think pktgen should be cloning the skbs using skb_clone(). Then it
will work for all devices, eh?
That might work, but it would decrease performance slightly (or,
increase CPU load at least).
Maybe a new option: multi_clone
Ben
--
Ben Greear <[EMAIL PROTECTED]>
Candela
Roland Dreier wrote:
> > The action in bonding to a detach of slave is to unregister the master
> (see patch 10).
> > This can't be done from the context of unregister_netdevice itself (it is
> protected by rtnl_lock).
>
> I'm confused. Your patch has:
>
> > + ipoib_slave_detach(cp
I think pktgen should be cloning the skbs using skb_clone(). Then it
will work for all devices, eh?
Ben Greear wrote:
jamal wrote:
On Sun, 2007-23-09 at 12:55 -0500, Steve Wise wrote:
Its a hack that breaks cxgb3 because cxgb3 uses the skb->cb area for
each skb passed down. So cxgb3 is
On (22/09/07 12:24), Satyam Sharma didst pronounce:
>
>
> On Thu, 20 Sep 2007, Satyam Sharma wrote:
> >
> > BTW ppc64_defconfig didn't quite like 2.6.23-rc6-mm1 either ...
> > IIRC I got build failures in:
>
> > drivers/net/spider_net.c
>
>
> [PATCH -mm] spider_net: Misc build fixes after rec
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
Previously a number of cases in TCP SACK processing fail to take
advantage of costly stored information in sack_recv_cache. Most
importantly expected events such as cumulative ACK, new hole
ACKs and first ACK after RTO fall to this categor
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
---
include/linux/snmp.h | 20 +++
net/ipv4/proc.c | 20 +++
net/ipv4/tcp_input.c | 52 +++--
3 files
From: David S. Miller <[EMAIL PROTECTED]>
It is difficult to break out the inner-logic of
tcp_sacktag_write_queue() into worker functions because
so many local variables get updated in-place.
Start to overcome this by creating a structure block
of state variables that can be passed around into
wo
From: David S. Miller <[EMAIL PROTECTED]>
Worker function that implements the main logic of
the inner-most loop of tcp_sacktag_write_queue().
Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
Acked-by: Ilpo Järvinen <[EMAIL PROTECTED]>
---
net/ipv4/tcp_input.c | 213 ++-
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
It is going to replace the sack fastpath hint quite soon... :-)
Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
---
include/linux/tcp.h |6 --
include/net/tcp.h | 13 +
net/ipv4/tcp_input.c | 12 ++
Hi all,
After couple of wrong-wayed before/after()s and one infinite
loopy version, here's the current trial version of a sacktag
cache usage recode
Two first patches come from tcp-2.6 (rebased and rotated).
This series apply cleanly only on top of the other three patch
series I posted earl
On Mon, 24 Sep 2007, Herbert Xu wrote:
On Sun, Sep 23, 2007 at 11:18:58PM +0200, Krzysztof Oledzki wrote:
Thank you for the information. Is there any easy way to turn them on? I
need it for LVS.
Do you really need it?
Yes. I would like to use a LVS redirector as both a client and a direc
I previously added checking to position that is rather poor as
state has already been adjusted quite a bit. Re-placing it above
all state changes should be more robust though the return should
never ever get executed regardless of its place :-).
Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
---
In case of ACK reordering, the SACK block might be valid in it's
time but is already obsoleted since we've received another kind
of confirmation about arrival of the segments through snd_una
advancement of an earlier packet.
I didn't bother to build distinguishing of valid and invalid
SACK blocks
Hi Dave,
Here are some minor tweaks to recent net-2.6.24 changes, more or
less mandatory. The first one is the most important one because
if the not-supposed-to-happen case occurs, TCP would be left to
an inconsistent state. As regards the second, I'm fine with
either way. The third one's MIB for
Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
---
include/linux/snmp.h |1 +
net/ipv4/proc.c |1 +
net/ipv4/tcp_input.c |1 +
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/linux/snmp.h b/include/linux/snmp.h
index d8fd3ec..89f0c2b 100644
--- a/include/l
From: Roy Zang <[EMAIL PROTECTED]>
Clean up redundant PHY write line for ULi526x Ethernet
Driver.
Signed-off-by: Roy Zang <[EMAIL PROTECTED]>
---
drivers/net/tulip/uli526x.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/tulip/uli526x.c b/drivers/net/tulip/u
Thanks for your replies.
We contacted Arris (manufacturer of our CMTS) about this issue with
links to relevant parts of specification about minimum size of VLAN
tagged frames and it seems they'll acknowledge the problem and fix it in
next firmware.
Meantime i tried different suggestions posted th
On Mon, 24 Sep 2007 10:15:01 +0200 Olaf Hering <[EMAIL PROTECTED]> wrote:
> Fix compilation after incomplete struct net_device changes.
yup, thanks, Kamalesh Babulal has already sent in an identical
patch.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a messag
Fix compilation after incomplete struct net_device changes.
Signed-off-by: Olaf Hering <[EMAIL PROTECTED]>
---
drivers/net/mace.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/drivers/net/mace.c
+++ b/drivers/net/mace.c
@@ -633,7 +633,7 @@ static void mace_set_multicas
jamal wrote:
> On Sun, 2007-23-09 at 12:36 -0700, Kok, Auke wrote:
>
>> please be reminded that we're going to strip down e1000 and most of the
>> features
>> should go into e1000e, which has much less hardware workarounds. I'm still
>> reluctant to putting in new stuff in e1000 - I really want t
63 matches
Mail list logo
