Re: [PATCH RESEND] 2.6.22.6 networking [ipv4]: fix wrong destination when reply packetes

2007-09-20 Thread lepton
Now icmp_reply is only called by icmp_echo and icmp_timestamp ip_send_reply is only called by tcp_v4_send_reset and tcp_v4_send_ack I think in all situations the ip_hdr(skb)->saddr is set and should be the destination of reply packets. If using rt->rt_src as destination is correct in some situati

bind and O_NONBLOCK

2007-09-20 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Some time back Alan asked about adding O_NONBLOCK support to bind in the POSIX spec. I brought this up and the following text will be in the next revision of the POSIX spec: === If the socket address cannot be assigned immediately

[PATCH] E1000: Do not allow requeue of freed skb

2007-09-20 Thread Krishna Kumar
Returning BUSY will make qdisc_restart enqueue the skb which was already freed. The bad skb was correctly freed and we should return NETDEV_TX_OK. Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]> --- diff -ruNp a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c --- a/drivers/net/e1000e/ne

Re: [PATCH RESEND] 2.6.22.6 networking [ipv4]: fix wrong destination when reply packetes

2007-09-20 Thread David Stevens
I'm not sure why it's using rt_src here, but there are relevant cases that your description doesn't cover. For example, what happens if the source is not set in the original packet? Does NAT affect this? You quote RFC text for ICMP echo and the case where the receiving machine is the final desti

Re: [PATCH 3/3 Rev4] Initialize and fill IPv6 route age

2007-09-20 Thread Varun Chandramohan
Krishna Kumar2 wrote: > Varun Chandramohan <[EMAIL PROTECTED]> wrote on 09/20/2007 08:59:03 > PM: > > >> @@ -2123,6 +2131,7 @@ static int rt6_fill_node(struct sk_buff >> { >> struct rtmsg *rtm; >> struct nlmsghdr *nlh; >> + struct timeval tv; >> long expires; >> u32 table; >>

Re: [PATCH 3/3 Rev4] Initialize and fill IPv6 route age

2007-09-20 Thread Krishna Kumar2
Varun Chandramohan <[EMAIL PROTECTED]> wrote on 09/20/2007 08:59:03 PM: > @@ -2123,6 +2131,7 @@ static int rt6_fill_node(struct sk_buff > { > struct rtmsg *rtm; > struct nlmsghdr *nlh; > + struct timeval tv; > long expires; > u32 table; > > @@ -2186,6 +2195,11 @@ static int rt6_

[PATCH RESEND] 2.6.22.6 networking [ipv4]: fix wrong destination when reply packetes

2007-09-20 Thread lepton
Hi, This is a resend of this patch with more details. I'd like it can be accepted this time. The problem: In icmp_reply and ip_send_reply function, we now use rt->rt_src as destination to send out packets. For packets received in loopback device, this is wrong sometimes. Here is an

Re: Please pull 'iwlwifi' branch of wireless-2.6

2007-09-20 Thread John W. Linville
On Fri, Sep 21, 2007 at 09:20:30AM +0800, Zhu Yi wrote: > On Wed, 2007-09-19 at 11:13 +0100, Christoph Hellwig wrote: > > it really needs to be moved into a directory of it's own. > > It used to be... John? Fine by me -- I guess I misinterpreted the some other statements to make me think we wante

Re: bnx2 dirver's firmware images

2007-09-20 Thread Michael Chan
On Thu, 2007-09-20 at 15:49 +0100, Denys Vlasenko wrote: > > > Please test these two patches. > I updated them according to your comments. > > I've only tested patch #1. It worked after some minor modifications below. > > > > > > plain text > document > attachment > (linux-2.6.23- > rc6

Re: Please pull 'iwlwifi' branch of wireless-2.6

2007-09-20 Thread Zhu Yi
On Wed, 2007-09-19 at 11:13 +0100, Christoph Hellwig wrote: > it really needs to be moved into a directory of it's own. It used to be... John? > The useless per-file CFLAGS need to go most places can trivially > be made unconditional anyway. OK. > The depends on m for CONFIG_IWL4965 and CONFIG_

Re: [PATCH 6/9] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-09-20 Thread Scott Wood
On Fri, Sep 21, 2007 at 10:08:41AM +1000, Stephen Rothwell wrote: > On Thu, 20 Sep 2007 17:01:21 -0500 Scott Wood <[EMAIL PROTECTED]> wrote: > > > > +++ b/drivers/net/fs_enet/fs_enet-main.c > > @@ -44,12 +44,18 @@ > > #include > > #include > > > > +#ifdef CONFIG_PPC_CPM_NEW_BINDING > > +#incl

Re: [PATCH 6/9] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-09-20 Thread Stephen Rothwell
On Thu, 20 Sep 2007 17:01:21 -0500 Scott Wood <[EMAIL PROTECTED]> wrote: > > +++ b/drivers/net/fs_enet/fs_enet-main.c > @@ -44,12 +44,18 @@ > #include > #include > > +#ifdef CONFIG_PPC_CPM_NEW_BINDING > +#include Hmm, didn't I already ask you to change this to linux/of_platform.h? > +++ b/

Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

2007-09-20 Thread Andrew Morton
On Wed, 19 Sep 2007 15:38:19 +0100 (BST) "Maciej W. Rozycki" <[EMAIL PROTECTED]> wrote: > Keep track of disable_irq_nosync() invocations and call enable_irq() the > right number of times if work has been cancelled that would include them. > > Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]>

Re: [PATCH] forcedeth: power down phy when interface is down

2007-09-20 Thread Ayaz Abdulla
It seems that you are powering down the phy even if WOL is enabled. Secondly, can you powerdown the phy at the same time you start performing autoneg restart? Ed Swierk wrote: Bring the physical link down when the interface is down, by placing the PHY in power-down state. This mirrors the be

Re: e1000 driver and samba

2007-09-20 Thread Bruce Cole
If you look for it on the Realtek cards, there had been sporadic Nissues up to late 2005. The solution posted universally was 'change card'. Yes, that *was* the common recommendation. But recently I narrowed down the realtek performance problem most commonly seen with samba (but also applicable

Re: [PATCH] e1000: Add device IDs of blade version of the 82571 quad port

2007-09-20 Thread Kok, Auke
Jeff Garzik wrote: > Auke Kok wrote: >> This blade-specific board form factor is identical to the 82571EB >> board. >> >> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> >> --- >> >> drivers/net/e1000/e1000_ethtool.c |1 + >> drivers/net/e1000/e1000_hw.c |1 + >> drivers/net/e1000/e1000_h

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-20 Thread Joe Perches
On Fri, 2007-09-21 at 01:05 +0200, Thomas Graf wrote: > What exactly is the advantage of this? It makes the kernel image smaller and has consistency, typechecking and sparse advantages. print_mac(char *buf, const u8 *addr) print_ip(char *buf, __be32 addr) print_ipv6(char *buf, const u8 *addr) Cu

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-20 Thread Thomas Graf
* Joe Perches <[EMAIL PROTECTED]> 2007-09-19 23:53 > In the same vein as print_mac, the implementations > introduce declaration macros: > DECLARE_IP_BUF(var) > DECLARE_IPV6_BUF(var) > and functions: > print_ip > print_ipv6 > print_ipv6_nofmt > > IPV4 Use: > > D

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-20 Thread Nagendra Tomar
--- Davide Libenzi <[EMAIL PROTECTED]> wrote: > That's not what POLLOUT means in the Unix meaning. POLLOUT indicates the > ability to write, and it is not meant as to signal every time a packet > (skb) is sent on the wire (and the buffer released). Aren't they both the same ? Everytime an inc

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-20 Thread Davide Libenzi
On Thu, 20 Sep 2007, Nagendra Tomar wrote: > > --- Davide Libenzi <[EMAIL PROTECTED]> wrote: > > > Looking back at it, I think the current TCP code is right, once you look > > at the "event" to be a output buffer full->with_space transition. > > If you drop an fd inside epoll with EPOLLOUT|EPOL

Re: [PATCH] sky2: be more selective about FIFO watchdog

2007-09-20 Thread Stephen Hemminger
On Thu, 20 Sep 2007 17:46:01 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > On Thu, 20 Sep 2007 16:51:13 -0400 > > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > >> Stephen Hemminger wrote: > >>> Be more selective about when to enable the ram buffer watchdog code. > >>>

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-20 Thread Nagendra Tomar
--- Davide Libenzi <[EMAIL PROTECTED]> wrote: > > Unfortunately f_op->poll() does not let the caller to specify the events > it's interested in, that would allow to split send/recevie wait queues and > better detect read/write cases. > The detection of a waitqueue_active(->sk_wr_sleep) would w

Re: Pull request for 'r8169-for-jeff-20070919' branch

2007-09-20 Thread Sylvain Le Gall
Hello, On Thu, Sep 20, 2007 at 05:26:40PM -0400, Chuck Ebbert wrote: > On 09/20/2007 04:44 PM, Francois Romieu wrote: > > Chuck Ebbert <[EMAIL PROTECTED]> : > > [...] > >> People are still reporting hangs with this card in 2.6.22.6, are there > >> any fixes appropriate for that? > > > > $ grep 2.

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-20 Thread Nagendra Tomar
--- Davide Libenzi <[EMAIL PROTECTED]> wrote: > Looking back at it, I think the current TCP code is right, once you look > at the "event" to be a output buffer full->with_space transition. > If you drop an fd inside epoll with EPOLLOUT|EPOLLET and you get an event > (free space on the output bu

[PATCH 6/9] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-09-20 Thread Scott Wood
The existing OF glue code was crufty and broken. Rather than fix it, it will be removed, and the ethernet driver now talks to the device tree directly. The old, non-CONFIG_PPC_CPM_NEW_BINDING code can go away once CPM platforms are dropped from arch/ppc (which will hopefully be soon), and existin

[PATCH 9/9] fs_enet: sparse fixes

2007-09-20 Thread Scott Wood
Mostly a bunch of __iomem annotations. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c | 16 +- drivers/net/fs_enet/fs_enet.h | 30 +- drivers/net/fs_enet/mac-fcc.c | 60 --- drivers/net/f

[PATCH 4/9] fs_enet: mac-fcc: Eliminate __fcc-* macros.

2007-09-20 Thread Scott Wood
These macros accomplish nothing other than defeating type checking. This patch also fixes one instance of the wrong register size being used that was revealed by enabling type checking. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/fs_enet/mac-fcc.c | 25 ---

[PATCH 7/9] Generic bitbanged MDIO library

2007-09-20 Thread Scott Wood
Previously, bitbanged MDIO was only supported in individual hardware-specific drivers. This code factors out the higher level protocol implementation, reducing the hardware-specific portion to functions setting direction, data, and clock. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers

[PATCH 8/9] fs_enet: Convert mii-bitbang to use the generic bitbang MDIO code.

2007-09-20 Thread Scott Wood
Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/fs_enet/mii-bitbang.c | 270 - 1 files changed, 54 insertions(+), 216 deletions(-) diff --git a/drivers/net/fs_enet/mii-bitbang.c b/drivers/net/fs_enet/mii-bitbang.c index 2b9c44c..5732890 100644 -

[PATCH 3/9] fs_enet: Don't share the interrupt.

2007-09-20 Thread Scott Wood
This driver can't handle an interrupt immediately after request_irq (making it fail with CONFIG_DEBUG_SHIRQ), and has unshared interrupts on all hardware I'm aware of. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c |2 +- 1 files changed, 1 insertions(+),

[PATCH 1/9] fs_enet: Whitespace cleanup.

2007-09-20 Thread Scott Wood
Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c | 85 --- drivers/net/fs_enet/fs_enet.h |4 +- drivers/net/fs_enet/mac-fcc.c |1 - drivers/net/fs_enet/mii-bitbang.c |3 - drivers/net/fs_enet/mii-fec.c

[PATCH 5/9] fs_enet: Align receive buffers.

2007-09-20 Thread Scott Wood
At least some hardware driven by this driver needs receive buffers to be aligned on a 16-byte boundary. This usually happens by chance, but it breaks if slab debugging is enabled. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c | 21 +++-- d

[PATCH 0/9] fs enet and mdio bitbang patches

2007-09-20 Thread Scott Wood
Changes since previous patchset: - Changed mdio_bitbang_ to mdiobb_, as requested. - Separated mii bitbang conversion to generic MDIO bitbang library from the of_platform conversion. - Added register read-backs to flush the writes in mdio bitbang clients. - Fixed a couple minor issues. Jeff, pl

[PATCH 2/9] fs_enet: Include linux/string.h from linux/fs_enet_pd.h

2007-09-20 Thread Scott Wood
It is needed for strstr(). Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- include/linux/fs_enet_pd.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/fs_enet_pd.h b/include/linux/fs_enet_pd.h index 543cd3c..815c6f9 100644 --- a/include/linux/fs_enet_pd.h +

Re: [PATCH] sky2: be more selective about FIFO watchdog

2007-09-20 Thread Jeff Garzik
Stephen Hemminger wrote: On Thu, 20 Sep 2007 16:51:13 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Stephen Hemminger wrote: Be more selective about when to enable the ram buffer watchdog code. It is unnecessary on XL A3 or later revs, and with Yukon FE the buffer is so small (4K) that the watc

Re: [PATCH] e1000: Add device IDs of blade version of the 82571 quad port

2007-09-20 Thread Jeff Garzik
Auke Kok wrote: This blade-specific board form factor is identical to the 82571EB board. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_ethtool.c |1 + drivers/net/e1000/e1000_hw.c |1 + drivers/net/e1000/e1000_hw.h |1 + drivers/net/e1000/e1000_m

Re: [PATCH] sky2: be more selective about FIFO watchdog

2007-09-20 Thread Stephen Hemminger
On Thu, 20 Sep 2007 16:51:13 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > Be more selective about when to enable the ram buffer watchdog code. > > It is unnecessary on XL A3 or later revs, and with Yukon FE > > the buffer is so small (4K) that the watchdog detects fa

[PATCH 1/2 revised] David Miller's rbtree patches for 2.6.22.6

2007-09-20 Thread Tom Quetchenbach
> Patch 1: David Miller's red-black tree code, tweaked for 2.6.22.6, > with some bugfixes oops... The original patch can cause a kernel panic if tcp_sacktag_write_queue is called when the write queue is empty. Use this one instead. -Tom --- diff -ur linux-2.6.22.6/include/linux/skbuff.h linux-

Re: Pull request for 'r8169-for-jeff-20070919' branch

2007-09-20 Thread Chuck Ebbert
On 09/20/2007 04:44 PM, Francois Romieu wrote: > Chuck Ebbert <[EMAIL PROTECTED]> : > [...] >> People are still reporting hangs with this card in 2.6.22.6, are there >> any fixes appropriate for that? > > $ grep 2.6.22.6 ~/Mail/linux/bugs/pending > $ grep 2.6.22.6 ~/Mail/romieu > [nothing besides

Re: [patch 1/1] revert "8139too: clean up I/O remapping"

2007-09-20 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 16:58:43 -0400 > [EMAIL PROTECTED] wrote: > > From: Andrew Morton <[EMAIL PROTECTED]> > > > > Revert git-netdev-all's 9ee6b32a47b9abc565466a9c3b127a5246b452e5. Michal > > was > > getting oopses. > > > > Cc: Michal Piotrowski <[EMAIL

Re: [patch 1/1] revert "8139too: clean up I/O remapping"

2007-09-20 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Andrew Morton <[EMAIL PROTECTED]> Revert git-netdev-all's 9ee6b32a47b9abc565466a9c3b127a5246b452e5. Michal was getting oopses. Cc: Michal Piotrowski <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: David S. Miller" <[EMAIL PROTECTED]> Signed-off-by: An

Re: [PATCH] ucc_geth: remove unnecessary asm/ocp.h include from ucc_geth_mii.c

2007-09-20 Thread Timur Tabi
Timur Tabi wrote: ucc_geth_mii.c includes , but it never needed it. With commit 2f6c9d961081dc7b109eb19166244bcb2a5dfc28, the asm-powerpc => asm-ppc link is removed, and so ucc_geth_mii.c can no longer include include/asm-ppc/ocp.h, so the compile fails. This patch removes the #include line.

Re: [PATCH] sky2: be more selective about FIFO watchdog

2007-09-20 Thread Jeff Garzik
Stephen Hemminger wrote: Be more selective about when to enable the ram buffer watchdog code. It is unnecessary on XL A3 or later revs, and with Yukon FE the buffer is so small (4K) that the watchdog detects false positives. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> With all the sky

Re: Pull request for 'r8169-for-jeff-20070919' branch

2007-09-20 Thread Francois Romieu
Chuck Ebbert <[EMAIL PROTECTED]> : [...] > People are still reporting hangs with this card in 2.6.22.6, are there > any fixes appropriate for that? $ grep 2.6.22.6 ~/Mail/linux/bugs/pending $ grep 2.6.22.6 ~/Mail/romieu [nothing besides Sylvain's success with 2.6.22.6 + the r8169 test driver] $ le

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-20 Thread Thomas Gleixner
On Thu, 2007-09-20 at 13:06 -0700, Joe Perches wrote: > On Thu, 2007-09-20 at 20:43 +0200, Urs Thuermann wrote: > > +#define DBG(...) (debug & 1 ? \ > > + (printk(KERN_DEBUG "can-%s %s: ", \ > > + IDENT, __func__), printk(args)) : 0)

Re: Please pull 'nl80211' branch of wireless-2.6

2007-09-20 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 15:12:45 -0400 > This patch adds the basic nl80211 infrastructure. I've pulled this into net-2.6.24 and pushed back out. Thanks John! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message t

Re: net-2.6.24 plans

2007-09-20 Thread John W. Linville
On Wed, Sep 19, 2007 at 05:07:00PM -0400, John W. Linville wrote: > On Tue, Sep 18, 2007 at 09:27:52PM -0400, John W. Linville wrote: > > On Mon, Sep 17, 2007 at 11:23:28PM -0400, John W. Linville wrote: > > > On Mon, Sep 17, 2007 at 04:49:29PM -0700, Andrew Morton wrote: > > > > On Mon, 17 Sep 200

Re: Pull request for 'r8169-for-jeff-20070919' branch

2007-09-20 Thread Chuck Ebbert
On 09/19/2007 03:56 PM, Francois Romieu wrote: > Please pull from branch 'r8169-for-jeff-20070919' in repository > People are still reporting hangs with this card in 2.6.22.6, are there any fixes appropriate for that? - To unsubscribe from this list: send the line "unsubscribe netdev" in the bod

Re: [PATCH 2/7] CAN: Add PF_CAN core module

2007-09-20 Thread Joe Perches
On Thu, 2007-09-20 at 20:43 +0200, Urs Thuermann wrote: > +#define DBG(...) (debug & 1 ? \ > + (printk(KERN_DEBUG "can-%s %s: ", \ > + IDENT, __func__), printk(args)) : 0) > +#define DBG_FRAME(args...) (debug & 2 ? can_debug_cframe(ar

[PATCH] sky2: be more selective about FIFO watchdog

2007-09-20 Thread Stephen Hemminger
Be more selective about when to enable the ram buffer watchdog code. It is unnecessary on XL A3 or later revs, and with Yukon FE the buffer is so small (4K) that the watchdog detects false positives. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-09-19 1

Re: 2.6.23-rc6-mm1

2007-09-20 Thread Andrew Morton
On Thu, 20 Sep 2007 21:42:44 +0530 "Kamalesh Babulal" <[EMAIL PROTECTED]> wrote: > ... > > > i have tested the change with cross compiler for power405 with the same > > .config > > with which the build problem is solved, but the build fails with another > > error > > > > CC [M] drivers/net/mace

Please pull 'nl80211' branch of wireless-2.6

2007-09-20 Thread John W. Linville
Dave, This patch adds the basic nl80211 infrastructure. Thanks! John --- Patch is available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/nl80211/0001-nl80211-add-netlink-interface-to-cfg80211.patch --- The following changes since commit 0d4cbb5e7f60b2f1

[git patches] net driver fixes

2007-09-20 Thread Jeff Garzik
This includes the sky2 update that you and sch discussed. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/myri10ge/myri10ge.c |3 + drivers/net/phy/phy.c |

Re: [PATCH 9/9] [TCP]: Avoid clearing sacktag hint in trivial situations

2007-09-20 Thread Ilpo Järvinen
On Thu, 20 Sep 2007, David Miller wrote: > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > Date: Thu, 20 Sep 2007 15:17:52 +0300 > > > There's no reason to clear the sacktag skb hint when small part > > of the rexmit queue changes. Account changes (if any) instead when > > fragmenting/collapsing. RTO

[PATCH 6/7] CAN: Add maintainer entries

2007-09-20 Thread Urs Thuermann
This patch adds entries in the CREDITS and MAINTAINERS file for CAN. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- CREDITS | 16 MAINTAINERS |9 + 2 files changed, 25 insertions(+) Index: net-2.6.24/CRE

[PATCH 4/7] CAN: Add broadcast manager (bcm) protocol

2007-09-20 Thread Urs Thuermann
This patch adds the CAN broadcast manager (bcm) protocol. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/bcm.h | 65 + net/can/Kconfig | 28 net/can/Makefile|3 net/can/bcm.c | 1784 +++

[PATCH 0/7] CAN: Add new PF_CAN protocol family, try #7

2007-09-20 Thread Urs Thuermann
Hello Dave, hello Patrick, this is the seventh post of the patch series that adds the PF_CAN protocol family for the Controller Area Network. Since our last post we have changed the following: * Changes suggested by Patrick: - protect proto_tab[] by a lock. - add _rcu to some hlist traversal

[PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-20 Thread Urs Thuermann
This patch adds the virtual CAN bus (vcan) network driver. The vcan device is just a loopback device for CAN frames, no real CAN hardware is involved. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- drivers/net/Makefile |1 drivers

[PATCH 7/7] CAN: Add documentation

2007-09-20 Thread Urs Thuermann
This patch adds documentation for the PF_CAN protocol family. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- Documentation/networking/00-INDEX |2 Documentation/networking/can.txt | 635 ++ 2 file

[PATCH 3/7] CAN: Add raw protocol

2007-09-20 Thread Urs Thuermann
This patch adds the CAN raw protocol. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/can/raw.h | 31 + net/can/Kconfig | 26 + net/can/Makefile|3 net/can/raw.c | 828 ++

[PATCH 1/7] CAN: Allocate protocol numbers for PF_CAN

2007-09-20 Thread Urs Thuermann
This patch adds a protocol/address family number, ARP hardware type, ethernet packet type, and a line discipline number for the SocketCAN implementation. Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> --- include/linux/if_arp.h |1 + inc

Re: [git patches] net driver updates

2007-09-20 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 03:26:10 -0400 > Please pull from the 'upstream' branch of > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream > > to receive the following changes: Pulled into net-2.6.24 and pushed out, thanks Jeff! - To uns

Re: [PATCH 9/9] [TCP]: Avoid clearing sacktag hint in trivial situations

2007-09-20 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 15:17:52 +0300 > There's no reason to clear the sacktag skb hint when small part > of the rexmit queue changes. Account changes (if any) instead when > fragmenting/collapsing. RTO/FRTO do not touch SACKED_ACKED bits so > no need to d

Re: [PATCH 8/9] [TCP]: Enable SACK enhanced FRTO (RFC4138) by default

2007-09-20 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 15:17:51 +0300 > Most of the description that follows comes from my mail to > netdev (some editing done): ... > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Applied, thanks Ilpo! - To unsubscribe from this list: send the line "

Re: [PATCH 6/9] [TCP] FRTO: Improve interoperability with other undo_marker users

2007-09-20 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 15:17:49 +0300 > Basically this change enables it, previously other undo_marker > users were left with nothing. Reverse undo_marker logic > completely to get it set right in CA_Loss. On the other hand, > when spurious RTO is detected

Re: [PATCH 7/9] [TCP] FRTO: Update sysctl documentation

2007-09-20 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 15:17:50 +0300 > Since the SACK enhanced FRTO was added, the code has been > under test numerous times so remove "experimental" claim > from the documentation. Also be a bit more verbose about > the usage. > > Signed-off-by: Ilpo Jä

Re: [PATCH 5/9] [TCP]: Cleanup tcp_tso_acked and tcp_clean_rtx_queue

2007-09-20 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 15:17:48 +0300 > Implements following cleanups: > - Comment re-placement (CodingStyle) > - tcp_tso_acked() local (wrapper-like) variable removal > (readability) > - __-types removed (IMHO they make local variables jumpy looking >

Re: [PATCH 4/9] [TCP]: Move accounting from tso_acked to clean_rtx_queue

2007-09-20 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 15:17:47 +0300 > The accounting code is pretty much the same, so it's a shame > we do it in two places. > > I'm not too sure if added fully_acked check in MTU probing is > really what we want perhaps the added end_seq could be used

Re: [PATCH 3/9] [TCP]: clear_all_retrans_hints prefixed by tcp_

2007-09-20 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 15:17:46 +0300 > In addition, fix its function comment spacing. > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Applied. > -/*from STCP */ > -static inline void clear_all_retrans_hints(struct tcp_sock *tp){ > +/* from STCP */

Re: [PATCH 1/9] [TCP]: Maintain highest_sack accurately to the highest skb

2007-09-20 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 15:17:44 +0300 > In general, it should not be necessary to call tcp_fragment for > already SACKed skbs, but it's better to be safe than sorry. And > indeed, it can be called from sacktag when a DSACK arrives or > some ACK (with SACK)

Re: [PATCH 2/9] [TCP]: Make fackets_out accurate

2007-09-20 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 15:17:45 +0300 > Substraction for fackets_out is unconditional when snd_una > advances, thus there's no need to do it inside the loop. Just > make sure correct bounds are honored. > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-20 Thread Maciej W. Rozycki
ication of `sed' by myself. Sorry for the noise. Maciej patch-netdev-2.6.23-rc6-20070920-sb1250-mac-typedef-9 diff -up --recursive --new-file linux-netdev-2.6.23-rc6-20070920.macro/drivers/net/sb1250-mac.c linux-netdev-2.6.23-rc6-20070920/drivers/net/sb1250-mac.c --- linux-netdev-2

Re: [Bug, PATCH and another Bug] Was: Fix refcounting problem with netif_rx_reschedule()

2007-09-20 Thread David Miller
From: Krishna Kumar2 <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 11:24:01 +0530 > Ran 4/16/64 thread iperf on latest bits with this patch and no issues after > 30 mins. I used to > consistently get the bug within 1-2 mins with just 4 threads prior to this > patch. > > Tested-by: Krishna Kumar <[EM

Re: [PATCH: 2.6.13-15-SMP 3/3] network: concurrently run softirq network code on SMP

2007-09-20 Thread Stephen Hemminger
On Thu, 20 Sep 2007 21:04:16 +0800 "john ye" <[EMAIL PROTECTED]> wrote: > Bottom Softirq Implementation. John Ye, 2007.08.27 > > Why this patch: > Make kernel be able to concurrently execute softirq's net code on SMP > system. > Takes full advantages of SMP to handle more packets and greatly rai

Re: [Bug, PATCH and another Bug] Was: Fix refcounting problem with netif_rx_reschedule()

2007-09-20 Thread David Miller
From: Krishna Kumar2 <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 10:48:15 +0530 > About the "list deletion occurs", isn't the race I mentioned still present? > If done < budget, the driver does netif_rx_complete (at which time some > other cpu can add this NAPI to their list). But the first cpu mig

Re: [PATCH 2.6.23][BNX2]: Add PHY workaround for 5709 A1.

2007-09-20 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 11:07:13 -0700 > [BNX2]: Add PHY workaround for 5709 A1. > > Add the DIS_EARLY_DAC PHY workaround for 5709 A1. Without it, link > sometimes does not come up. > > Update version to 1.6.5. > > Signed-off-by: Michael Chan <[EMAIL PRO

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-20 Thread Davide Libenzi
On Thu, 20 Sep 2007, Eric Dumazet wrote: > Does it means that with your patch each ACK on a ET managed socket will > trigger an epoll event ? > > Maybe your very sensitive high throuput appication needs to set a flag or > something at socket level to ask for such a behavior. > > The default sh

Re: [PATCH: 2.6.13-15-SMP 3/3] network: concurrently run softirq network code on SMP

2007-09-20 Thread David Miller
The whole reason the queues are per-cpu is so that we do not have to touch remote processor state nor use locks of any kind whatsoever. With multi-queue networking cards becoming more and more available, which will split up the packet workload in hardware across all available cpus, there is less

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-20 Thread Ilpo Järvinen
On Thu, 20 Sep 2007, Joe Perches wrote: > On Thu, 2007-09-20 at 07:55 -0700, Randy Dunlap wrote: > > How large are the patches if you posted them for review instead > > of just referencing gits for them? (which cuts down on review > > possibilities) > > The v4 is ~130kb, the v6 ~35kb. > > There

Re: [PATCH 2.6.23-rc6 Resending] NETWORKING : Edge Triggered EPOLLOUT events get missed for TCP sockets

2007-09-20 Thread Davide Libenzi
On Wed, 19 Sep 2007, Nagendra Tomar wrote: > The tcp_check_space() function calls tcp_new_space() only if the > SOCK_NOSPACE bit is set in the socket flags. This is causing Edge Triggered > EPOLLOUT events to be missed for TCP sockets, as the ep_poll_callback() > is not called from the wakeup rou

Re: net-2.6.24 plans

2007-09-20 Thread John W. Linville
On Thu, Sep 20, 2007 at 04:50:52PM +0200, Johannes Berg wrote: > On Thu, 2007-09-20 at 10:17 -0400, John W. Linville wrote: > > > > 2) ATMEL USB driver > > > > These are both really new. I think I'll transfer them to my > > wireless-2.6 tree, but still hold them back at least until 2.6.25. > >

[PATCH 2.6.23][BNX2]: Add PHY workaround for 5709 A1.

2007-09-20 Thread Michael Chan
[BNX2]: Add PHY workaround for 5709 A1. Add the DIS_EARLY_DAC PHY workaround for 5709 A1. Without it, link sometimes does not come up. Update version to 1.6.5. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 854d80c..66eed22 100644 ---

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

2007-09-20 Thread Jeff Garzik
Maciej W. Rozycki wrote: On Thu, 20 Sep 2007, Jeff Garzik wrote: You may be pleased (or less so) to hear that the version of sb1250-mac.c in your tree does not even build (because of 42d53d6be113f974d8152979c88e1061b953bd12) and the patch below does not address it. I ran out of time in the eve

Re: [PATCH 2/3] netlink: the temp variable name max is ambiguous

2007-09-20 Thread rae l
On 9/17/07, David Miller <[EMAIL PROTECTED]> wrote: > From: Denis Cheng <[EMAIL PROTECTED]> > Date: Sun, 2 Sep 2007 03:45:58 +0800 > > > with the macro max provided by , so changed its name to a > > more proper one: limit > > > > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> > > Not strictly nec

Re: [PATCH 1/2] net/: all net/ cleanup with ARRAY_SIZE

2007-09-20 Thread rae l
On 9/17/07, David Miller <[EMAIL PROTECTED]> wrote: > From: Denis Cheng <[EMAIL PROTECTED]> > Date: Sun, 2 Sep 2007 18:30:17 +0800 > > > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> > > You already submitted the net/ipv4/af_inet.c case > seperately, so I had to remove it from this patch for > it

Re: [PATCH]: Preliminary release of Sun Neptune driver

2007-09-20 Thread Ariel Hendel
Thanks Dave for your preliminary posting of the driver. I am copying Matheos Worku. Matheos is intimately familiar with the Neptune/NIU family of devices and their respective drivers. Not only he can be a good reviewer, he can also clarify issues around naming and so on. I agree that Neptune i

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-20 Thread Johannes Berg
On Thu, 2007-09-20 at 11:37 -0500, Larry Finger wrote: > You're on. BTW, I will let you be the primary tester of "[PATCH] fix softmac > lockdep reports" that > Johannes posted earlier today. I see you were CC'd. I plan on testing it with > bcm43xx, but I won't > get to it for a couple of days.

Re: Please pull 'z1211' branch of wireless-2.6

2007-09-20 Thread Larry Finger
Daniel Drake wrote: > John W. Linville wrote: >> If you are determined not to have it in 2.6.24 then I will relent. >> I will also suggest that Larry start sending any softmac bugs to >> you... :-) > > That's fine. You're on. BTW, I will let you be the primary tester of "[PATCH] fix softmac loc

Re: [PATCH] RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery.

2007-09-20 Thread Roland Dreier
> Roland - can you please queue this up for 2.6.24? Done, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V5 2/11] IB/ipoib: Notify the world before doing unregister

2007-09-20 Thread Roland Dreier
> +ipoib_slave_detach(cpriv->dev); > unregister_netdev(cpriv->dev); Maybe you already answered this before, but I'm still not clear why this notifier call can't just be added to the start of unregister_netdevice(), so we can avoid having driver needing to know anything a

[PATCH][MIPS][7/7] AR7: ethernet

2007-09-20 Thread Matteo Croce
Driver for the cpmac 100M ethernet driver. Jeff, here is the meat ;) Signed-off-by: Matteo Croce <[EMAIL PROTECTED]> Signed-off-by: Eugene Konev <[EMAIL PROTECTED]> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 6a0863e..28ba0dc 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kco

Re: wrong arp query with policy routing

2007-09-20 Thread Chuck Ebbert
> Is there a way to force linux to make an arp > probe with the source ip belonging to the > same subnet requesting ip? Umm, arp_filter? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/

Re: [LARTC] ifb and ppp

2007-09-20 Thread Patrick McHardy
Frithjof Hammer wrote: >>Sorry, I didnt follow the thread - what is the goal to be achieved with >>the setup? > > > A simple ingress shaping on ppp0 (PPPOE DSL line). I want to replace my old > imq ingress shaper in favor of ifb. My former script used iptables marks to > classify the packets.

[PATCH 2/3 Rev4] Initilize and populate age field

2007-09-20 Thread Varun Chandramohan
The age field is filled with the current time at the time of creation of the route. When the routes are dumped then the age value stored in the route structure is subtracted from the current time value and the difference is the age expressed in secs. Signed-off-by: Varun Chandramohan <[EMAIL PRO

[PATCH 3/3 Rev4] Initialize and fill IPv6 route age

2007-09-20 Thread Varun Chandramohan
The age field of the ipv6 route structures are initilized with the current timeval at the time of route creation. When the route dump is called the route age value stored in the structure is subtracted from the present timeval and the difference is passed on as the route age. Signed-off-by: Varu

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-20 Thread Joe Perches
On Thu, 2007-09-20 at 07:55 -0700, Randy Dunlap wrote: > How large are the patches if you posted them for review instead > of just referencing gits for them? (which cuts down on review > possibilities) The v4 is ~130kb, the v6 ~35kb. There is a gitweb available at: print_ip: http://repo.or.cz/w

[PATCH 1/3 Rev4] New attribute RTA_AGE

2007-09-20 Thread Varun Chandramohan
A new attribute RTA_AGE is added for the age value to be exported to userlevel using netlink Signed-off-by: Varun Chandramohan <[EMAIL PROTECTED]> --- include/linux/rtnetlink.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/rtnetlink.h b/include/linux/rtne

[PATCH 0/3 Rev-4] Age Entry For IPv4 & IPv6 Route Table

2007-09-20 Thread Varun Chandramohan
Hi Dave, Thanks for the comment. I have created another patch set as you have suggested. Your Comments: In avoiding the age initialization at routing cache insertion time, you make the value provided totally inaccurate and essentially useless especially the very first time the value is ask

Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6

2007-09-20 Thread Randy Dunlap
On Wed, 19 Sep 2007 23:53:31 -0700 Joe Perches wrote: > In the same vein as print_mac, the implementations > introduce declaration macros: > DECLARE_IP_BUF(var) > DECLARE_IPV6_BUF(var) > and functions: > print_ip > print_ipv6 > print_ipv6_nofmt > > IPV4 Use: > >

Re: net-2.6.24 plans

2007-09-20 Thread Johannes Berg
On Thu, 2007-09-20 at 10:17 -0400, John W. Linville wrote: > > 2) ATMEL USB driver > > These are both really new. I think I'll transfer them to my > wireless-2.6 tree, but still hold them back at least until 2.6.25. Also, atmel isn't even ported to mac80211 yet, is it? > > 3) NL80211 > > I ne

  1   2   >