From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Thu, 20 Sep 2007 15:17:52 +0300
> There's no reason to clear the sacktag skb hint when small part > of the rexmit queue changes. Account changes (if any) instead when > fragmenting/collapsing. RTO/FRTO do not touch SACKED_ACKED bits so > no need to discard SACK tag hint at all. > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Applied, and I followed it up with this coding style fixlet. Thanks! commit e3723ad866a1e0690f3bc32443180ec1f6657f4a Author: David S. Miller <[EMAIL PROTECTED]> Date: Thu Sep 20 11:40:37 2007 -0700 [TCP]: Minor coding style fixup. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> diff --git a/include/net/tcp.h b/include/net/tcp.h index 07b1faa..991ccdc 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -1067,14 +1067,16 @@ static inline void tcp_mib_init(void) } /* from STCP */ -static inline void tcp_clear_retrans_hints_partial(struct tcp_sock *tp) { +static inline void tcp_clear_retrans_hints_partial(struct tcp_sock *tp) +{ tp->lost_skb_hint = NULL; tp->scoreboard_skb_hint = NULL; tp->retransmit_skb_hint = NULL; tp->forward_skb_hint = NULL; } -static inline void tcp_clear_all_retrans_hints(struct tcp_sock *tp) { +static inline void tcp_clear_all_retrans_hints(struct tcp_sock *tp) +{ tcp_clear_retrans_hints_partial(tp); tp->fastpath_skb_hint = NULL; } - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html