Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-09 Thread Eric W. Biederman
Krishna Kumar2 <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote on 09/09/2007 02:45:34 AM: > > Hi Eric, > >> +static int register_pernet_operations(struct list_head *list, >> + struct pernet_operations *ops) >> +{ >> >> +out: >> + return error; >> + >> +out_undo: >> + /*

sh: add support for ax88796 and 93cx6 to highlander boards

2007-09-09 Thread Magnus Damm
sh: add support for ax88796 and 93cx6 to highlander boards This patch adds eeprom support to the ax88796 driver together with a platform device for highlander boards. The 93cx6 driver is hooked up to the ax88796 driver and is used to read out the mac address from the on board eeprom. The pin confi

Re: 2.6.23-rc4-mm1: e1000e napi lockup

2007-09-09 Thread Kok, Auke
Jiri Slaby wrote: Kok, Auke napsal(a): Jiri Slaby wrote: I still have problems with the driver. When I do `ip link set eth0 up', ksoftirq runs with 100 % cpu time, so I think you endlessly re-schedule some timer (or the new napi layer?) something changed in the logic and e1000e apparently does

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-09 Thread Eric W. Biederman
"Paul E. McKenney" <[EMAIL PROTECTED]> writes: >> I know I cannot use get_net for the reference in in /proc because >> otherwise I could not release the network namespace unless I was to >> unmount the filesystem, which is not a desirable property. >> >> I think I can change the idiom to: >> >>

Re: 2.6.23-rc4-mm1: e1000e napi lockup

2007-09-09 Thread Jiri Slaby
Kok, Auke napsal(a): > Jiri Slaby wrote: >> I still have problems with the driver. When I do `ip link set eth0 >> up', ksoftirq >> runs with 100 % cpu time, so I think you endlessly re-schedule some >> timer (or >> the new napi layer?) > > something changed in the logic and e1000e apparently does

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-09 Thread Krishna Kumar2
Eric W. Biederman wrote on 09/09/2007 02:45:34 AM: Hi Eric, > +static int register_pernet_operations(struct list_head *list, > + struct pernet_operations *ops) > +{ > > +out: > + return error; > + > +out_undo: > + /* If I have an error cleanup all namespaces I initialized */

Re: [RFC 0/3] rfkill

2007-09-09 Thread Dmitry Torokhov
Hi Ivo, On Saturday 08 September 2007 11:10, Ivo van Doorn wrote: > Hi Dmitry, > > I have a few rfkill related patches for which I would prefer if you to could > take a look at before I send them for inclusion. > Looks good, feel free to add Acked-by: Dmitry Torokhov <[EMAIL PROTECTED

Re: [IPv6] BUG: NULL pointer dereference in(?) ip6_flush_pending_frames

2007-09-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 10 Sep 2007 00:24:00 +0200), Bernhard Schmidt <[EMAIL PROTECTED]> says: > I'm running a public Teredo relay (IPv4-to-IPv6 migration protocol) > using Miredo. Every once in a while (a few minutes to days after > daemon restart) it becomes unusable and I see

Re: 2.6.23-rc4-mm1: e1000e napi lockup

2007-09-09 Thread Kok, Auke
Jiri Slaby wrote: On 09/07/2007 09:19 AM, Jiri Slaby wrote: Hi, I found a regression in 2.6.23-rc4-mm1 (since -rc3-mm1) in e1000e driver. napi_disable(&adapter->napi) in e1000_probe freezes the kernel on boot. Ok, after these changes: diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e10

Re: [PATCH] e100: timer power saving

2007-09-09 Thread Arjan van de Ven
Auke Kok wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> Since E100 timer is 2HZ, use rounding to make timer occur on the correct boundary. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> given that I was about to send out exactly this same

[IPv6] BUG: NULL pointer dereference in(?) ip6_flush_pending_frames

2007-09-09 Thread Bernhard Schmidt
Hi, I'm running a public Teredo relay (IPv4-to-IPv6 migration protocol) using Miredo. Every once in a while (a few minutes to days after daemon restart) it becomes unusable and I see the following kernel message: BUG: unable to handle kernel NULL pointer dereference at virtual address 008c p

Re: ne driver crashes when unloaded in 2.6.22.6

2007-09-09 Thread Chris Rankin
--- Dan Williams <[EMAIL PROTECTED]> wrote: > Offhand question, does your ne2000 card support carrier detection? Err... there is a /sys/class/net/eth0/carrier entry (I think - not in front of that machine right now). IIRC it said "1" when I read it. Cheers, Chris ___

Re: ne driver crashes when unloaded in 2.6.22.6

2007-09-09 Thread Dan Williams
On Sun, 2007-09-09 at 20:46 +0100, Chris Rankin wrote: > Hi, > > While trying to get my NE2000 ISA card working with NetworkManager and Linux > 2.6.22.6, I > discovered that the ne module will cause the kernel to oops when it is > unloaded. The problem is > that the module's clean-up function tr

[PATCH resend] Fix a lock problem in generic phy code

2007-09-09 Thread Hans-Jürgen Koch
I already sent this patch on August, 31. I never got an answer, so here it is again. Lock debugging finds a problem in phy.c and phy_device.c: [    3.42] = [    3.42] [ INFO: inconsistent lock state ] [    3.42] 2.6.23-rc3-mm1 #21 [    3.42] --

Question about NAT-T and PF_KEY...

2007-09-09 Thread Stjepan Gros
Hi all, I'm having problems telling the kernel to do ESP-in-UDP encapsulation. Outgoing direction seems to work, but the incoming packets on the other side are passed to ikev2 daemon instead of kernel decapsulating them. The only strange thing I'm noticing for now is the difference between setkey

Re: [-mm patch] unexport raise_softirq_irqoff

2007-09-09 Thread Christoph Hellwig
On Sun, Sep 09, 2007 at 10:25:44PM +0200, Adrian Bunk wrote: > On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.23-rc3-mm1: > >... > > git-net.patch > >... > > git trees > >... > > raise_softirq_irqoff no longer has any modular user. > > Signed-off-by:

[-mm patch] net/sctp/socket.c: make 3 variables static

2007-09-09 Thread Adrian Bunk
On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: >... > Changes since 2.6.23-rc3-mm1: >... > git-net.patch >... > git trees >... This patch makes the following needlessly globalvariables static: - sctp_memory_pressure - sctp_memory_allocated - sctp_sockets_allocated Signed-off-by:

[-mm patch] make tcp_splice_data_recv() static

2007-09-09 Thread Adrian Bunk
On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: >... > Changes since 2.6.23-rc3-mm1: >... > git-block.patch >... > git trees >... tcp_splice_data_recv() can become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 233aefd2a215430c16bd02eca06fb8a4b6079f7a diff --git a/n

[2.6 patch] make sctp_addto_param() static

2007-09-09 Thread Adrian Bunk
sctp_addto_param() can become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/net/sctp/structs.h |1 net/sctp/sm_make_chunk.c | 39 ++--- 2 files changed, 20 insertions(+), 20 deletions(-) 38f8064114b9e89a6a911b2e3625a41cdb477bcd dif

[-mm patch] really unexport do_softirq

2007-09-09 Thread Adrian Bunk
On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: >... > Changes since 2.6.23-rc3-mm1: >... > git-net.patch >... > git trees >... This hydra had more than one head... Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- arch/i386/kernel/irq.c|2 -- arch/powerpc/kernel/irq.

[-mm patch] unexport raise_softirq_irqoff

2007-09-09 Thread Adrian Bunk
On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: >... > Changes since 2.6.23-rc3-mm1: >... > git-net.patch >... > git trees >... raise_softirq_irqoff no longer has any modular user. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- eff0407b63757cdd4164a0bdde0313e8f154b6dc diff

ne driver crashes when unloaded in 2.6.22.6

2007-09-09 Thread Chris Rankin
Hi, While trying to get my NE2000 ISA card working with NetworkManager and Linux 2.6.22.6, I discovered that the ne module will cause the kernel to oops when it is unloaded. The problem is that the module's clean-up function tries to unregister a platform driver unconditionally, although the pl

[PATCH] iproute2: patches from Debian.

2007-09-09 Thread Andreas Henriksson
Hello Stephen Hemminger and the rest of the people on the nevdev list! I'm posting a bunch of patches for iproute2. A few I've written myself and have a Signed-off-by with my name in them, the others I've picked up from the iproute package in Debian. I tried my best to add a decent description, re

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-09-09 Thread Arjan van de Ven
On Sun, 9 Sep 2007 19:02:54 +0100 Denys Vlasenko <[EMAIL PROTECTED]> wrote: > Why is all this fixation on "volatile"? I don't think > people want "volatile" keyword per se, they want atomic_read(&x) to > _always_ compile into an memory-accessing instruction, not register > access. and ... why is

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-09-09 Thread Denys Vlasenko
On Friday 17 August 2007 17:48, Linus Torvalds wrote: > > On Fri, 17 Aug 2007, Nick Piggin wrote: > > > > That's not obviously just taste to me. Not when the primitive has many > > (perhaps, the majority) of uses that do not require said barriers. And > > this is not solely about the code generat

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-09 Thread Paul E. McKenney
On Sun, Sep 09, 2007 at 04:04:45AM -0600, Eric W. Biederman wrote: > "Paul E. McKenney" <[EMAIL PROTECTED]> writes: > > > On Sat, Sep 08, 2007 at 03:15:34PM -0600, Eric W. Biederman wrote: > >> > >> This is the basic infrastructure needed to support network > >> namespaces. This infrastructure i

Re: r8169: slow samba performance

2007-09-09 Thread Francois Romieu
David Madsen <[EMAIL PROTECTED]> : > >Does "acceptable" mean that there is a noticeable difference when compared > >to the patch based on a busy-waiting loop ? > > I noticed a somewhat significant difference between patch #0002 and a > busy wait loop with ndelay(10). Write performance was equivale

Re: wither bounds checking for networking sysctls

2007-09-09 Thread Eric W. Biederman
Rick Jones <[EMAIL PROTECTED]> writes: > Stephen Hemminger wrote: >> On Thu, 30 Aug 2007 18:09:17 -0700 >> Rick Jones <[EMAIL PROTECTED]> wrote: >> >> >>> While messing about with "sysctl_tcp_rto_min" I went back and forth a bit as >>> to whether there should have been bounds checking (as did some

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-09 Thread FUJITA Tomonori
On Sat, 8 Sep 2007 13:00:36 +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Sat, Sep 08, 2007 at 07:32:27AM -0400, Jeff Garzik wrote: > > FUJITA Tomonori wrote: > > >Yeah, iommu code ignores the lld limitations (the problem is that the > > >lld limitations are in request_queue and iommu co

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-09 Thread Eric W. Biederman
Eric Dumazet <[EMAIL PROTECTED]> writes: > > Nice work Eric ! Thanks. > "struct net" is not a very descriptive name imho, why dont stick "ns" or > "namespace" somewhere ? My fingers rebelled, and struct net seems to be sufficiently descriptive. However that is a cosmetic detail and if there is a

Bluetooth patches for 2.6.23-rc5

2007-09-09 Thread Marcel Holtmann
Hi Dave, here are four additional patches that should go into 2.6.23 before its final release. Please pull and send them to Linus. Regards Marcel Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git This will update the following files: drivers/

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-09 Thread Eric W. Biederman
"Paul E. McKenney" <[EMAIL PROTECTED]> writes: > On Sat, Sep 08, 2007 at 03:15:34PM -0600, Eric W. Biederman wrote: >> >> This is the basic infrastructure needed to support network >> namespaces. This infrastructure is: >> - Registration functions to support initializing per network >> namespa

Re: 2.6.23-rc4-mm1: e1000e napi lockup

2007-09-09 Thread Jiri Slaby
On 09/07/2007 09:19 AM, Jiri Slaby wrote: > Hi, > > I found a regression in 2.6.23-rc4-mm1 (since -rc3-mm1) in e1000e driver. > napi_disable(&adapter->napi) in e1000_probe freezes the kernel on boot. Ok, after these changes: diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c i

Re: [PATCH 03/16] net: Basic network namespace infrastructure.

2007-09-09 Thread Eric Dumazet
Eric W. Biederman a écrit : This is the basic infrastructure needed to support network namespaces. This infrastructure is: - Registration functions to support initializing per network namespace data when a network namespaces is created or destroyed. - struct net. The network namespace data s

Re: r8169: slow samba performance

2007-09-09 Thread David Madsen
>Does "acceptable" mean that there is a noticeable difference when compared >to the patch based on a busy-waiting loop ? I noticed a somewhat significant difference between patch #0002 and a busy wait loop with ndelay(10). Write performance was equivalent in both cases as should be the case. Read

[PATCH net-2.6.24] cxgb3 - napi update

2007-09-09 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Embed napi_struct directly into sge_qset. Use napi_schedule/napi_complete. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h| 20 +++--- drivers/net/cxgb3/cxgb3_main.c | 57 ++ drivers/net