[PATCH 14/11] cxgb3 - CQ context operations time out too soon.

2007-08-22 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Currently, the driver only tries up to 5 times (5us) to get the results of a CQ context operation. Testing has shown the chip can take as much as 50us to return the response on SG_CONTEXT_CMD operations. So we up the retry count to 100 to cover high loads.

[PATCH 13/11] cxgb3 - Set the CQ_ERR bit in CQ contexts.

2007-08-22 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> The cxgb3 driver is incorrectly configuring the HW CQ context for CQ's that use overflow-avoidance. Namely the RDMA control CQ. This results in a bad DMA from the device to bus address 0. The solution is to set the CQ_ERR bit in the context for these types

[PATCH 12/11] cxgb3 - remove false positive in xgmac workaround

2007-08-22 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Qualify toggling of xgmac tx enable with not getting pause frames, we might not make forward progress because the peer is sending lots of pause frames. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |1 + drivers/net/cxg

[PATCH 0/3] cxgb3 driver update

2007-08-22 Thread Divy Le Ray
Hi Jeff, I'm submitting three more patches for inclusion in netdev#upstream. These patches are built over the series I resent yesterday night. The patch numbering reflects the stacking. Here is a brief description: - avoid false positives in the xgmac hang workaround - Properly set the CQ_ER

Re: [PATCH] improved xfrm_audit_log() patch

2007-08-22 Thread David Miller
From: Joy Latten <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 20:29:17 -0500 > On Wed, 2007-08-22 at 12:51 -0700, David Miller wrote: > > From: David Miller <[EMAIL PROTECTED]> > > Date: Tue, 21 Aug 2007 00:24:05 -0700 (PDT) > > > > > Looks good, applied to net-2.6.24, thanks Joy. > > > > Somethin

Re: [PATCH] ucc_geth: kill unused include

2007-08-22 Thread David Gibson
On Wed, Aug 22, 2007 at 09:51:03PM -0500, Kumar Gala wrote: > The ucc_geth_mii code is based on the gianfar_mii code that use to include > ocp.h. ucc never need this and it causes issues when we want to kill > arch/ppc includes from arch/powerpc. > > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]>

[PATCH] ucc_geth: kill unused include

2007-08-22 Thread Kumar Gala
The ucc_geth_mii code is based on the gianfar_mii code that use to include ocp.h. ucc never need this and it causes issues when we want to kill arch/ppc includes from arch/powerpc. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- Jeff, if you issue with this for 2.6.23, I'd prefer to push this

Re: [PATCH 1/10 Rev4] [Doc] HOWTO Documentation for batching

2007-08-22 Thread Krishna Kumar2
Hi Randy, Thanks for your suggestions. Will clean up those changes. - KK Randy Dunlap <[EMAIL PROTECTED]> wrote on 08/22/2007 09:20:13 PM: > On Wed, 22 Aug 2007 13:58:58 +0530 Krishna Kumar wrote: > > > Add Documentation describing batching skb xmit capability. > > > > Signed-off-by: Krishna Ku

Re: [PATCH 10/10 Rev4] [E1000] Implement batching

2007-08-22 Thread Krishna Kumar2
Hi Auke, "Kok, Auke" <[EMAIL PROTECTED]> wrote on 08/22/2007 08:09:31 PM: > Krishna, > > while I appreciate the patch I would have preferred a patch to e1000e. Not only > does the e1000e driver remove a lot of the workarounds for old silicon, it is > also a good way for us to move the current e10

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-22 Thread Krishna Kumar2
David Miller <[EMAIL PROTECTED]> wrote on 08/22/2007 02:44:40 PM: > From: Krishna Kumar2 <[EMAIL PROTECTED]> > Date: Wed, 22 Aug 2007 12:33:04 +0530 > > > Does turning off batching solve that problem? What I mean by that is: > > batching can be disabled if a TSO device is worse for some cases. > >

Re: [PATCH] improved xfrm_audit_log() patch

2007-08-22 Thread Joy Latten
On Wed, 2007-08-22 at 12:51 -0700, David Miller wrote: > From: David Miller <[EMAIL PROTECTED]> > Date: Tue, 21 Aug 2007 00:24:05 -0700 (PDT) > > > Looks good, applied to net-2.6.24, thanks Joy. > > Something is still buggered up in this patch, you can't add this local > "audit_info" variable unc

Re: [PATCH] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes

2007-08-22 Thread Stephen Rothwell
Hi Olof, On Wed, 22 Aug 2007 09:12:48 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote: > > -static unsigned int read_iob_reg(struct pasemi_mac *mac, unsigned int reg) > +static inline unsigned int read_iob_reg(struct pasemi_mac *mac, unsigned int > reg) ^^ For static functions in C f

[PATCH] IOAT: ioatdma needs to to play nice in a multi-dma-client world

2007-08-22 Thread Shannon Nelson
Now that the DMA engine has a multi-client interface, fix the ioatdma driver to play along. At the same time, remove a couple of unnecessary reads and writes. Signed-off-by: Shannon Nelson <[EMAIL PROTECTED]> --- drivers/dma/ioatdma.c | 18 -- 1 files changed, 4 insertions(+),

Re: [RFC] remove obsolete shaper code

2007-08-22 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:58:54 -0700 > This driver is obsolete, and fixing it for adding upcoming changes > to make hard_header_ops > is problematic because it changes the underlying device handles. > > The driver has been superseded by iproute2/traffi

[RFC] remove obsolete shaper code

2007-08-22 Thread Stephen Hemminger
This driver is obsolete, and fixing it for adding upcoming changes to make hard_header_ops is problematic because it changes the underlying device handles. The driver has been superseded by iproute2/traffic control for a long time. Let's kill it. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED

Re: [RFT] sky2: yukon-ec-u phy power problems

2007-08-22 Thread Kevin E
--- Stephen Hemminger <[EMAIL PROTECTED]> wrote: > The sky2 driver clears some bits in the PHY control > register, that cause > the PHY interface to get changed. Some of these > deal with voltage and power > savings as well. This may explain some of the > failures on Gigabyte DS-3 motherboard. >

Re: [RFC] Wild and crazy ideas involving struct sk_buff

2007-08-22 Thread James Morris
On Wed, 22 Aug 2007, Paul Moore wrote: > > Don't forget Rusty's skb reservation patches from 1999... > > I'm guessing those would probably need to be forward ported just a teensy > weensy bit ;) The point being that the idea has been around since last century and has never gone anywhere :-)

Re: [RFC] Wild and crazy ideas involving struct sk_buff

2007-08-22 Thread Paul Moore
On Wednesday, August 22 2007 6:09:36 pm James Morris wrote: > On Wed, 22 Aug 2007, David Miller wrote: > > From: Paul Moore <[EMAIL PROTECTED]> > > Date: Wed, 22 Aug 2007 17:26:36 -0400 > > > > > Was it just a thought, or was there some actual design/code/patchset > > > to go along with it that des

Re: eHEA driver issues from net-2.6.24

2007-08-22 Thread Andrew Theurer
David Miller wrote: From: Andrew Theurer <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:03 -0500 Thanks for finally getting to test this, I thought nobody would test this until it got merged into 2.6.24 :-/ kernel BUG at include/linux/netdevice.h:318! enter ? for help [cf613e40] c

Re: [PATCH][VIA-RHINE]: Fix CONFIG_VIA_RHINE_NAPI usage

2007-08-22 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 22, 2007 at 02:58:55PM -0700, David Miller escreveu: > From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> > Date: Wed, 22 Aug 2007 18:46:59 -0300 > > > Hi David, > > > > napi is broken here, with this patch at least I can isolate this > > breakage and boot the machine with a non-n

Re: [RFC] Wild and crazy ideas involving struct sk_buff

2007-08-22 Thread James Morris
On Wed, 22 Aug 2007, David Miller wrote: > From: Paul Moore <[EMAIL PROTECTED]> > Date: Wed, 22 Aug 2007 17:26:36 -0400 > > > Was it just a thought, or was there some actual design/code/patchset > > to go along with it that described the idea? > > It was a thought mentioned at the first two netc

Re: [RFC] Wild and crazy ideas involving struct sk_buff

2007-08-22 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 22, 2007 at 02:36:27PM -0700, David Miller escreveu: > From: Paul Moore <[EMAIL PROTECTED]> > Date: Wed, 22 Aug 2007 17:26:36 -0400 > > > Was it just a thought, or was there some actual design/code/patchset > > to go along with it that described the idea? > > It was a thought mentione

Re: eHEA driver issues from net-2.6.24

2007-08-22 Thread David Miller
From: Andrew Theurer <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:03 -0500 Thanks for finally getting to test this, I thought nobody would test this until it got merged into 2.6.24 :-/ > kernel BUG at include/linux/netdevice.h:318! > enter ? for help > [cf613e40] c03fe394 .net

Re: [PATCH][VIA-RHINE]: Fix CONFIG_VIA_RHINE_NAPI usage

2007-08-22 Thread David Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 18:46:59 -0300 > Hi David, > > napi is broken here, with this patch at least I can isolate this > breakage and boot the machine with a non-napi via-rhine driver. > > Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PR

eHEA driver issues from net-2.6.24

2007-08-22 Thread Andrew Theurer
In testing the new NAPI improvements on ehea, I get the following: kernel BUG at include/linux/netdevice.h:318! cpu 0x1: Vector: 700 (Program Check) at [cf613ac0] pc: d0091054: .ehea_poll+0x1e8/0x1334 [ehea] lr: c03fe394: .net_rx_action+0x1b8/0x254 sp: cf6

[PATCH][VIA-RHINE]: Fix CONFIG_VIA_RHINE_NAPI usage

2007-08-22 Thread Arnaldo Carvalho de Melo
Hi David, napi is broken here, with this patch at least I can isolate this breakage and boot the machine with a non-napi via-rhine driver. Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> diff --git a/drivers/net/via-rhine.c b/drivers/net/via-rhine.c index 8f4cf82..4cecd06 100

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-22 Thread Adrian Bunk
On Tue, Aug 21, 2007 at 06:51:16PM -0400, [EMAIL PROTECTED] wrote: > On Tue, 21 Aug 2007 09:16:43 PDT, "Paul E. McKenney" said: > > > I agree that instant gratification is hard to come by when synching > > up compiler and kernel versions. Nonetheless, it should be possible > > to create APIs that

Re: [RFC] Wild and crazy ideas involving struct sk_buff

2007-08-22 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 17:26:36 -0400 > Was it just a thought, or was there some actual design/code/patchset > to go along with it that described the idea? It was a thought mentioned at the first two netconfs, but it went nowhere because the more we discussed

Re: [RFC] Wild and crazy ideas involving struct sk_buff

2007-08-22 Thread Paul Moore
On Wednesday, August 22 2007 5:20:05 pm Thomas Graf wrote: > * Paul Moore <[EMAIL PROTECTED]> 2007-08-22 16:31 > > > We're currently talking about several different ideas to solve the > > problem, including leveraging the sk_buff.secmark field, and one of the > > ideas was to add an additional fiel

Re: [RFC] Wild and crazy ideas involving struct sk_buff

2007-08-22 Thread Paul Moore
On Wednesday, August 22 2007 5:08:05 pm David Miller wrote: > From: Paul Moore <[EMAIL PROTECTED]> > Date: Wed, 22 Aug 2007 16:31:34 -0400 > > > We're currently talking about several different ideas to solve the > > problem, including leveraging the sk_buff.secmark field, and one of the > > ideas w

Re: [RFC] Wild and crazy ideas involving struct sk_buff

2007-08-22 Thread Thomas Graf
* Paul Moore <[EMAIL PROTECTED]> 2007-08-22 16:31 > We're currently talking about several different ideas to solve the problem, > including leveraging the sk_buff.secmark field, and one of the ideas was to > add an additional field to the sk_buff structure. Knowing how well that idea > would go

Re: [PATCH 4/7] fs_enet: mac-fcc: Eliminate __fcc-* macros.

2007-08-22 Thread Scott Wood
Vitaly Bordug wrote: -#define W8(_p, _m, _v) __fcc_out8(&(_p)->_m, (_v)) -#define R8(_p, _m) __fcc_in8(&(_p)->_m) +#define W8(_p, _m, _v) out_8(&(_p)->_m, (_v)) +#define R8(_p, _m) in_8(&(_p)->_m) #define S8(_p, _m, _v) W8(_p, _m, R8(_p, _m) | (_v)) #define C8(_p, _m, _v) W8(_p, _m, R8(

Re: [PATCH 6/7 v2] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-08-22 Thread Scott Wood
Vitaly Bordug wrote: yes, wrong snippet what about #ifdef CONFIG_CPM2 +r = fs_enet_mdio_bb_init(); + if (r != 0) + goto out_mdio_bb; +#endif +#ifdef CONFIG_8xx + r = fs_enet_mdio_fec_init(); + if (r != 0) + goto out_mdio_fec; +#endif We had to pray and hope that 8xx would only have

net-2.6.24 rebased

2007-08-22 Thread David Miller
I needed to pull out the xfrm auditing patch, and I had been meaning to combine the NAPI struct patch with all the little bug fixes we've accumulated. Also, as mentioned here throughout the day, I've also added Thomas Graf's xfrm_user cleanups and Stephen Hemminger's netdevice docbook additions.

Re: [PATCH 4/7] fs_enet: mac-fcc: Eliminate __fcc-* macros.

2007-08-22 Thread Vitaly Bordug
On Fri, 17 Aug 2007 12:54:02 -0500 Scott Wood wrote: > These macros accomplish nothing other than defeating type checking. > > This patch also fixes one instance of the wrong register size being > used that was revealed by enabling type checking. > > Signed-off-by: Scott Wood <[EMAIL PROTECTED]>

Re: [RFC] Wild and crazy ideas involving struct sk_buff

2007-08-22 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:31:34 -0400 > We're currently talking about several different ideas to solve the problem, > including leveraging the sk_buff.secmark field, and one of the ideas was to > add an additional field to the sk_buff structure. Knowing how

Re: [PATCH 2/7] fs_enet: Whitespace cleanup.

2007-08-22 Thread Vitaly Bordug
On Fri, 17 Aug 2007 12:53:59 -0500 Scott Wood wrote: > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> Acked-by: Vitaly Bordug <[EMAIL PROTECTED]> > --- > drivers/net/fs_enet/fs_enet-main.c | 85 > --- > drivers/net/fs_enet/fs_enet.h |4 +- > drivers/net/

Re: [PATCH 16/16] [XFRM] netlink: Inline attach_encap_tmpl(), attach_sec_ctx(), and attach_one_addr()

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:54 +0200 > These functions are only used once and are a lot easier to understand if > inlined directly into the function. > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Also applied. Thanks for doing all of this work Thomas!

Re: [PATCH 13/16] [XFRM] netlink: Use nlattr instead of rtattr

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:51 +0200 > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/ma

Re: [PATCH 14/16] [XFRM] netlink: Use nla_memcpy() in xfrm_update_ae_params()

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:52 +0200 > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/ma

Re: [PATCH 15/16] [XFRM] netlink: Remove dependency on rtnetlink

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:53 +0200 > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/ma

Re: [PATCH 12/16] [XFRM] netlink: Rename attribyte array from xfrma[] to attrs[]

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:50 +0200 > Increases readability a lot. > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied. I named it like this to mean "XFRM Attributes" :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: [PATCH 6/7 v2] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-08-22 Thread Vitaly Bordug
On Tue, 21 Aug 2007 11:47:41 -0500 Scott Wood <[EMAIL PROTECTED]> wrote: > Vitaly Bordug wrote: > > On Fri, 17 Aug 2007 13:17:18 -0500 > > Scott Wood wrote: > > > > > >>The existing OF glue code was crufty and broken. Rather than fix > >>it, it will be removed, and the ethernet driver now talks

Re: [PATCH 10/16] [XFRM] netlink: Establish an attribute policy

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:48 +0200 > Adds a policy defining the minimal payload lengths for all the attributes > allowing for most attribute validation checks to be removed from in > the middle of the code path. Makes updates more consistent as many format

Re: [PATCH 11/16] [XFRM] netlink: Enhance indexing of the attribute array

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:49 +0200 > nlmsg_parse() puts attributes at array[type] so the indexing > method can be simpilfied by removing the obscuring "- 1". > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send

Re: [PATCH 08/16] [XFRM] netlink: Use nlmsg_new() and type-safe size calculation helpers

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:46 +0200 > Moves all complex message size calculation into own inlined helper > functions and makes use of the type-safe netlink interface. > > Using nlmsg_new() simplifies the calculation itself as it takes care > of the netlink

Re: [PATCH 09/16] [XFRM] netlink: Use nlmsg_parse() to parse attributes

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:47 +0200 > Uses nlmsg_parse() to parse the attributes. This actually changes > behaviour as unknown attributes (type > MAXTYPE) no longer cause > an error. Instead unknown attributes will be ignored henceforth > to keep older kerne

Re: [PATCH 07/16] [XFRM] netlink: Clear up some of the CONFIG_XFRM_SUB_POLICY ifdef mess

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:45 +0200 > Moves all of the SUB_POLICY ifdefs related to the attribute size > calculation into a function. > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe ne

Re: [PATCH 06/16] [XFRM] netlink: Move algorithm length calculation to its own function

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:44 +0200 > Adds alg_len() to calculate the properly padded length of an > algorithm attribute to simplify the code. > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsub

Re: [PATCH 04/16] [XFRM] netlink: Use nlmsg_broadcast() and nlmsg_unicast()

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:42 +0200 > This simplifies successful return codes from >0 to 0. > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH 05/16] [XFRM] netlink: Use nla_put()/NLA_PUT() variantes

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:43 +0200 > Also makes use of copy_sec_ctx() in another place and removes > duplicated code. > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

[RFC] Wild and crazy ideas involving struct sk_buff

2007-08-22 Thread Paul Moore
Over in LSM/SELinux land there has been a lot of talk recently about how to deal with loopback and forwarded traffic, specifically, how to preserve the sender's security label on those two types of traffic. Yes, there is the existing sk_buff.secmark field but that is already being used for some

[PATCH 2/2] Net: ath5k, remove sysctls

2007-08-22 Thread Jiri Slaby
ath5k, remove sysctls Syscalls were buggy and defunct in later kernels (due to sysctl check). Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 069bfbe93facb3468f579568434d18f1268a487c tree 87c19ebf2c91d9fb07f1847adcb6098f2235eaaa parent b01c0e9a02b248c3e2f2923da9728ba2c3961dee author Jir

[PATCH 1/2] Net: ath5k, no printk after STA->IBSS switch

2007-08-22 Thread Jiri Slaby
ath5k, no printk after STA->IBSS switch If STA->IBSS switch was done, but beacon_update weas not called so far, do not emit a warning about non-existent skbuf. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit b01c0e9a02b248c3e2f2923da9728ba2c3961dee tree c3e10a57aed39698f20c346679854aa3a

Re: [PATCH] netdevice: kernel docbook addition

2007-08-22 Thread Randy Dunlap
On Wed, 22 Aug 2007 12:33:14 -0700 Stephen Hemminger wrote: > Add more kernel doc's for part of the network device API. > This is only a start, and needs more work. > > Applies against net-2.6.24 Thanks! --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - T

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-22 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 10:09:37 -0700 > Should it be any more or less worrysome than small packet > performance (eg the TCP_RR stuff I posted recently) being rather > worse with TSO enabled than with it disabled? That, like any such thing shown by the batching

Re: [PATCH] improved xfrm_audit_log() patch

2007-08-22 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Tue, 21 Aug 2007 00:24:05 -0700 (PDT) > Looks good, applied to net-2.6.24, thanks Joy. Something is still buggered up in this patch, you can't add this local "audit_info" variable unconditionally to these functions, and alternatively you also can't add

Re: [PATCH 03/16] [XFRM] netlink: Use nlmsg_data() instead of NLMSG_DATA()

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:41 +0200 > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kerne

Re: r8169: slow samba performance

2007-08-22 Thread Bruce Cole
Shane wrote: On Wed, Aug 22, 2007 at 09:39:47AM -0700, Bruce Cole wrote: Shane, join the crowd :) Try the fix I just re-posted over here: Bruce, gigabit speeds thanks for the pointer. This fix works well for me though I just added the three or so lines in the elseif statement as it r

Re: [PATCH 01/16] [XFRM] netlink: Use nlmsg_put() instead of NLMSG_PUT()

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:39 +0200 > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/ma

[PATCH] xfrm: export sysctl_xfrm_acq_expires

2007-08-22 Thread Neil Horman
Hey all- I had noticed that an extra sysctl for xfrm had been added while back (specifically sysctl_xfrm_acq_expires). Unlike its related sysctl's however, this was never exported so that out-of-tree modules could access it, and I thought it would be a good idea if it was. This patch hand

Re: [PATCH 02/16] [XFRM] netlink: Use nlmsg_end() and nlmsg_cancel()

2007-08-22 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 16:55:40 +0200 > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/ma

Re: [PATCH] netdevice: kernel docbook addition

2007-08-22 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 12:33:14 -0700 > Add more kernel doc's for part of the network device API. > This is only a start, and needs more work. > > Applies against net-2.6.24 > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks Step

Re: [PATCH] xfrm: export sysctl_xfrm_acq_expires

2007-08-22 Thread David Miller
From: Neil Horman <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 15:42:02 -0400 > Hey all- > I had noticed that an extra sysctl for xfrm had been added while back > (specifically sysctl_xfrm_acq_expires). Unlike its related sysctl's however, > this was never exported so that out-of-tree modules

Re: [RFC IPROUTE]: Add flow classifier support

2007-08-22 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 10:46:15 -0700 > On Wed, 30 May 2007 11:42:01 +0200 > Patrick McHardy <[EMAIL PROTECTED]> wrote: > > > The iproute patch for the flow classifier. > > > > > > This patch is on hold since the netlink changes haven't made it upstr

Re: [PATCH] AH4: Update IPv4 options handling to conform to RFC 4302.

2007-08-22 Thread David Miller
From: Nick Bowler <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 10:22:53 -0400 > In testing our ESP/AH offload hardware, I discovered an issue with how AH > handles mutable fields in IPv4. RFC 4302 (AH) states the following on the > subject: > > For IPv4, the entire option is viewed as a un

Re: [PATCH] santize tc_ematch headers

2007-08-22 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 22 Aug 2007 10:18:38 -0700 > The headers in tc_ematch are used by iproute2, so these headers > should be processed. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks Stephen. - To unsubscribe from this list: send the l

[PATCH] netdevice: kernel docbook addition

2007-08-22 Thread Stephen Hemminger
Add more kernel doc's for part of the network device API. This is only a start, and needs more work. Applies against net-2.6.24 Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/Documentation/DocBook/kernel-api.tmpl 2007-08-21 15:43:37.0 -0700 +++ b/Documentation/DocBook/ke

[ANNOUNCE] iproute2-2.6.23-rc3

2007-08-22 Thread Stephen Hemminger
There have been a lot of changes for 2.6.23, so here is a test release of iproute2 that should capture all the submitted patches http://developer.osdl.org/shemminger/iproute2/download/iproute2-2.6.23-rc3.tar.gz Johannes Berg (1): show multicast groups PJ Waskiewicz (1): iproute2: sc

Re: [RFC IPROUTE]: Add flow classifier support

2007-08-22 Thread Stephen Hemminger
On Wed, 30 May 2007 11:42:01 +0200 Patrick McHardy <[EMAIL PROTECTED]> wrote: > The iproute patch for the flow classifier. > > This patch is on hold since the netlink changes haven't made it upstream yet. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line

[PATCH] santize tc_ematch headers

2007-08-22 Thread Stephen Hemminger
The headers in tc_ematch are used by iproute2, so these headers should be processed. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/linux/Kbuild |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/Kbuild b/include/linux/Kbuild index ad7f71a..81

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-22 Thread Rick Jones
David Miller wrote: I think the jury is still out, but seeing TSO perform even slightly worse with the batching changes in place would be very worrysome. This applies to both throughput and cpu utilization. Should it be any more or less worrysome than small packet performance (eg the TCP_RR st

Re: Oops in e100_up

2007-08-22 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 22, 2007 at 09:35:04AM -0700, Kok, Auke escreveu: > Gerrit Renker wrote: > >With the davem-2.6.24 tree I get the following Oops in the e100 driver > >(cribbed from console): > > > >Code: 6c ff ff ff 8b 48 0c ba 01 00 00 00 89 f0 e8 1b f2 ff ff c7 86 9c 00 > >00 00 > > 01 00 00 00

r8169: slow samba performance

2007-08-22 Thread Bruce Cole
Just upgraded a motherboard and it came with an onboard Realtek card which appears to use the r8169 driver. The machine is a samba server and when serving files to a local Linux or Windows client, I only get approx 40-60 kbps. Write performance is fine though, in the tens of mbps and scp, nfs,

Re: Oops in e100_up

2007-08-22 Thread Kok, Auke
Gerrit Renker wrote: With the davem-2.6.24 tree I get the following Oops in the e100 driver (cribbed from console): Code: 6c ff ff ff 8b 48 0c ba 01 00 00 00 89 f0 e8 1b f2 ff ff c7 86 9c 00 00 00 01 00 00 00 e9 4e ff ff ff 89 d0 e8 b3 f8 0b 00 eb 8e <0f> 0b eb fe 55 89 e5 56 53 83

[PATCH] [-MM] e1000e: incorporate napi_struct changes from net-2.6.24.git

2007-08-22 Thread Auke Kok
This incorporates the new napi_struct changes into e1000e. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/e1000.h |2 ++ drivers/net/e1000e/netdev.c | 37 ++--- 2 files changed, 20 insertions(+), 19 deletions(-) diff --git a/drivers/net

Re: [2.6.20.17 review 35/58] forcedeth bug fix: realtek phy

2007-08-22 Thread Willy Tarreau
On Wed, Aug 22, 2007 at 11:56:42AM -0400, Chuck Ebbert wrote: > On 08/22/2007 05:39 AM, Willy Tarreau wrote: > > This patch contains errata fixes for the realtek phy. It only renamed the > > defines to be phy specific. > > > > Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> > > Signed-off-by: Greg

Re: [PATCH 1/10 Rev4] [Doc] HOWTO Documentation for batching

2007-08-22 Thread Randy Dunlap
On Wed, 22 Aug 2007 13:58:58 +0530 Krishna Kumar wrote: > Add Documentation describing batching skb xmit capability. > > Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]> > --- > batching_skb_xmit.txt | 78 > ++ > 1 files changed, 78 insertions(+

[PATCH 07/16] [XFRM] netlink: Clear up some of the CONFIG_XFRM_SUB_POLICY ifdef mess

2007-08-22 Thread Thomas Graf
Moves all of the SUB_POLICY ifdefs related to the attribute size calculation into a function. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2

[PATCH 04/16] [XFRM] netlink: Use nlmsg_broadcast() and nlmsg_unicast()

2007-08-22 Thread Thomas Graf
This simplifies successful return codes from >0 to 0. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 16:13:57.0 +0200 +++

[PATCH 03/16] [XFRM] netlink: Use nlmsg_data() instead of NLMSG_DATA()

2007-08-22 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 16:12:20.0 +0200 +++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21 16:13:57

[PATCH 15/16] [XFRM] netlink: Remove dependency on rtnetlink

2007-08-22 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:36:59.0 +0200 +++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21 17:37:18

[PATCH 13/16] [XFRM] netlink: Use nlattr instead of rtattr

2007-08-22 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:34:29.0 +0200 +++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21 17:35:13

[PATCH 05/16] [XFRM] netlink: Use nla_put()/NLA_PUT() variantes

2007-08-22 Thread Thomas Graf
Also makes use of copy_sec_ctx() in another place and removes duplicated code. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 16:15

[PATCH 11/16] [XFRM] netlink: Enhance indexing of the attribute array

2007-08-22 Thread Thomas Graf
nlmsg_parse() puts attributes at array[type] so the indexing method can be simpilfied by removing the obscuring "- 1". Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/

[PATCH 10/16] [XFRM] netlink: Establish an attribute policy

2007-08-22 Thread Thomas Graf
Adds a policy defining the minimal payload lengths for all the attributes allowing for most attribute validation checks to be removed from in the middle of the code path. Makes updates more consistent as many format errors are recognised earlier, before any changes have been attempted. Signed-off-

[PATCH 14/16] [XFRM] netlink: Use nla_memcpy() in xfrm_update_ae_params()

2007-08-22 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:35:13.0 +0200 +++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21 17:36:59

[PATCH 06/16] [XFRM] netlink: Move algorithm length calculation to its own function

2007-08-22 Thread Thomas Graf
Adds alg_len() to calculate the properly padded length of an algorithm attribute to simplify the code. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c

[PATCH 12/16] [XFRM] netlink: Rename attribyte array from xfrma[] to attrs[]

2007-08-22 Thread Thomas Graf
Increases readability a lot. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 17:34:10.0 +0200 +++ net-2.6.24/net/xfrm/xfrm_

[PATCH 02/16] [XFRM] netlink: Use nlmsg_end() and nlmsg_cancel()

2007-08-22 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-21 16:10:34.0 +0200 +++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21 16:12:20

[PATCH 16/16] [XFRM] netlink: Inline attach_encap_tmpl(), attach_sec_ctx(), and attach_one_addr()

2007-08-22 Thread Thomas Graf
These functions are only used once and are a lot easier to understand if inlined directly into the function. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_

[PATCH 09/16] [XFRM] netlink: Use nlmsg_parse() to parse attributes

2007-08-22 Thread Thomas Graf
Uses nlmsg_parse() to parse the attributes. This actually changes behaviour as unknown attributes (type > MAXTYPE) no longer cause an error. Instead unknown attributes will be ignored henceforth to keep older kernels compatible with more recent userspace tools. Signed-off-by: Thomas Graf <[EMAIL P

[PATCH 08/16] [XFRM] netlink: Use nlmsg_new() and type-safe size calculation helpers

2007-08-22 Thread Thomas Graf
Moves all complex message size calculation into own inlined helper functions and makes use of the type-safe netlink interface. Using nlmsg_new() simplifies the calculation itself as it takes care of the netlink header length by itself. Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.

[PATCH 00/16] xfrm netlink interface cleanups

2007-08-22 Thread Thomas Graf
This patchset converts the xfrm netlink bits over to the type safe netlink interface and does some cleanups. xfrm_user.c | 1041 1 file changed, 433 insertions(+), 608 deletions(-) - To unsubscribe from this list: send the line "unsubs

[PATCH 01/16] [XFRM] netlink: Use nlmsg_put() instead of NLMSG_PUT()

2007-08-22 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.24/net/xfrm/xfrm_user.c === --- net-2.6.24.orig/net/xfrm/xfrm_user.c2007-08-20 17:09:48.0 +0200 +++ net-2.6.24/net/xfrm/xfrm_user.c 2007-08-21 16:10:34

[PATCH] [07/10] pasemi_mac: Enable LLTX

2007-08-22 Thread Olof Johansson
Enable LLTX on pasemi_mac: we're already doing sufficient locking in the driver to enable it. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c === --- mainline.orig/drivers/net/pasemi_mac.c

[PATCH] [04/10] pasemi_mac: Fix memcpy amount for short receives

2007-08-22 Thread Olof Johansson
Fix up memcpy for short receives. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c === --- mainline.orig/drivers/net/pasemi_mac.c +++ mainline/drivers/net/pasemi_mac.c @@ -516,9 +516,7 @@ st

[PATCH] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes

2007-08-22 Thread Olof Johansson
Move away from using the pci config access functions for simple register access. Our device has all of the registers in the config space (hey, from the hardware point of view it looks reasonable :-), so we need to somehow get to it. Newer firmwares have it in the device tree such that we can just

[PATCH] [06/10] pasemi_mac: Batch up TX buffer frees

2007-08-22 Thread Olof Johansson
Postpone pci unmap and skb free of the transmitted buffers to outside of the tx ring lock, batching them up 32 at a time. Also increase the count threshold to 128. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c =

[PATCH] [08/10] pasemi_mac: Fix TX ring wrap checking

2007-08-22 Thread Olof Johansson
The old logic didn't detect full (tx) ring cases properly, causing overruns and general badness. Clean it up a bit and abstract out the ring size checks, always making sure to leave 1 slot open. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: mainline/drivers/net/pasemi_mac.c ==

  1   2   >