On Wed, 2007-08-22 at 12:51 -0700, David Miller wrote: > From: David Miller <[EMAIL PROTECTED]> > Date: Tue, 21 Aug 2007 00:24:05 -0700 (PDT) > > > Looks good, applied to net-2.6.24, thanks Joy. > > Something is still buggered up in this patch, you can't add this local > "audit_info" variable unconditionally to these functions, and > alternatively you also can't add a bunch of ifdefs to xfrm_user.c to > cover it up either. > I wonder if I am subconsciously trying to break a record or something! My apologies as time is valuable.
I mean to get this right. My rationale for using audit_info was to reduce amount of arguments to xfrm_audit_log(). However, I now like it better when I just called xfrm_audit_log(NETLINK_CB(skb).loginuid, NETLINK_CB(skb).sid, ...). User determines where/how to get loginuid and secid and nothing happens when AUDIT not configured. But would make xfrm_audit_log() have 7 arguments instead of 6. My alternative is to remove xfrm_get_auditinfo() out of the #ifdef CONFIG_AUDITSYSCALL and always fill in audit_info regardless if AUDIT is configured or not. Less calls to xfrm_audit_log() but perhaps unnecessary info when AUDIT not configured. Would first solution be acceptable? Joy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
