Re: [patch]support for USB autosuspend in the asix driver

2007-08-13 Thread David Brownell
On Monday 13 August 2007, Jeff Garzik wrote: > Oliver Neukum wrote: > > Hi, > > > > this implements support for USB autosuspend in the asix USB ethernet > > driver. > > > > Regards > > Oliver > > Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> > > David, does this look OK to you

[git patches] net driver fixes

2007-08-13 Thread Jeff Garzik
Minor stuff except for the xen-netfront fix. e1000 change is an adds-pci-ids-only change. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: MAINTAINERS |6 ++

Re: [PATCH] e1000: Add device IDs of new 82571 board variants

2007-08-13 Thread Jeff Garzik
Auke Kok wrote: This patch adds support for 2 new board variants: - A Quad port fiber 82571 board - A blade version of the 82571 quad copper board Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_ethtool.c |2 ++ drivers/net/e1000/e1000_hw.c |5 + driver

Re: [PATCH] xen-netfront: remove dead code

2007-08-13 Thread Jeff Garzik
Jeremy Fitzhardinge wrote: This patch removes some residual dead code left over from removing the "flip" receive mode. This patch doesn't change the generated output at all, since gcc already realized it was dead. This resolves the "regression" reported by Adrian. Signed-off-by: Jeremy Fitzhar

Re: [PATCH] xen-netfront: Avoid deref'ing skbafter it is potentially freed.

2007-08-13 Thread Jeff Garzik
Jeremy Fitzhardinge wrote: xennet_tx_bug_gc can free the skb before we use it, so make sure we don't. Jeff, this is -rc material. Signed-off-by: Keir Fraser <[EMAIL PROTECTED]> Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> applied - To unsubscrib

Re: [PATCH] drivers/net/3c505: Convert to generic boolean

2007-08-13 Thread Jeff Garzik
Richard Knutsson wrote: Convert to generic boolean Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. Sent 2007-05-01, no replys applied - To unsubscribe from this list: send the line "un

Re: drivers/net/tokenring/3c359.c

2007-08-13 Thread Jeff Garzik
Surya Prabhakar N wrote: Hi, Replacing kmalloc with kzalloc and cleaning up memset in drivers/net/tokenring/3c359.c Signed-off-by: Surya Prabhakar <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTE

Re: [PATCH] drivers/net/tokenring: Convert to generic boolean

2007-08-13 Thread Jeff Garzik
Richard Knutsson wrote: Convert to generic boolean Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. Sent 2007-05-01, no replys applied - To unsubscribe from this list: send the line "un

Re: [patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet

2007-08-13 Thread Brice Goglin
Jeff Garzik wrote: > [EMAIL PROTECTED] wrote: >> From: "Peter Oruba" <[EMAIL PROTECTED]> >> >> These driver changes incorporate the proposed PCI-X / PCI-Express >> read byte >> count interface. Reading and setting those valuse doesn't take place >> "manually", instead wrapping functions are called

Re: [PATCH 12/13] cxgb3 - log and clear PEX errors

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Clear pciE PEX errors late at module load time. Log details when PEX errors occur. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) ACK 10-12

Re: [PATCH 13/13] cxgb3 - test MSI capabilities

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Check that the HW in really in MSI/MSI-X mode when it was succesfully enabled. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c | 42 drivers/net/cxgb3/regs.h

Re: [PATCH 9/13] cxgb3 - Update internal memory management

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Set PM1 internal memory to round robin mode Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> why? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 8/13] cxgb3 - log adapter derial number

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Log HW serial number when cxgb3 module is loaded. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |2 ++ drivers/net/cxgb3/cxgb3_main.c |6 -- drivers/net/cxgb3/t3_hw.c |3 ++- 3 fi

Re: [PATCH 4/13] cxgb3 - use immediate data for offload Tx

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Send small TX_DATA work requests as immediate data even when there are fragments. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/sge.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) n

Re: [PATCH 5/13] cxgb3 - Expose HW memory page info

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Let the RDMA driver get HW page info to work around HW issues. Assign explicit enum values. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> "HW issues" -- you need to go into far more detail, when adding a new interface. what hw issues

Re: [PATCH 6/24] make atomic_read() behave consistently on frv

2007-08-13 Thread Nick Piggin
Chris Snook wrote: David Howells wrote: Chris Snook <[EMAIL PROTECTED]> wrote: cpu_relax() contains a barrier, so it should do the right thing. For non-smp architectures, I'm concerned about interacting with interrupt handlers. Some drivers do use atomic_* operations. I'm not sure that

Re: [PATCH 3/13] cxgb3 - SGE doorbell overflow warning

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Log doorbell Fifo overflow Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h |8 drivers/net/cxgb3/sge.c |4 2 files changed, 12 insertions(+), 0 deletions(-) ACK, but not applied since

Re: [PATCH 2/13] cxgb3 - Update rx coalescing length

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Set max Rx coalescing length to 12288 Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/cxgb3/common.h b/drivers/net/cxgb3

Re: [PATCH 6/24] make atomic_read() behave consistently on frv

2007-08-13 Thread Nick Piggin
Paul E. McKenney wrote: On Mon, Aug 13, 2007 at 01:15:52PM +0800, Herbert Xu wrote: Paul E. McKenney <[EMAIL PROTECTED]> wrote: On Sat, Aug 11, 2007 at 08:54:46AM +0800, Herbert Xu wrote: Chris Snook <[EMAIL PROTECTED]> wrote: cpu_relax() contains a barrier, so it should do the right thing

Re: [PATCH 1/13] cxgb3 - MAC workaround update

2007-08-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Update the MAC workaround to deal with switches that do not honor pause frames. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |1 + drivers/net/cxgb3/xgmac.c | 22 +++--- 2 files ch

Re: [patch 17/18] 3c59x: fix duplex configuration

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Steffen Klassert <[EMAIL PROTECTED]> A special sequence of ifconfig up/down and plug/unplug the cable can break the duplex configuration of the driver. Setting vp->mii.full_duplex = vp->full_duplex in vortex_up should fix this. Addresses Bug 8575 3c59x duplex con

Re: [patch 18/18] 3c59x maintainer

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Steffen Klassert <[EMAIL PROTECTED]> Add 3c59x maintainer. Signed-off-by: Steffen Klassert <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+) diff -puN MAINTAINERS~add-3c59x-maint

Re: [patch 13/18] natsemi: fix netdev error acounting

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Andrew Morton <[EMAIL PROTECTED]> When a detailed netdev error is counted, we also must account for it in the aggregated error count. Addresses http://bugzilla.kernel.org/show_bug.cgi?id=8106 Cc: Tim Hockin <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]>

Re: [patch 15/18] drivers/net: remove superfluous memset

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Mariusz Kozlowski <[EMAIL PROTECTED]> This patch covers something like this: dev = alloc_*dev(... ... priv = netdev_priv(dev); memset(priv, 0, sizeof(*priv)); The memset() here is superfluous. alloc_netdev() uses kzalloc() to allocate needed memory so the

Re: [patch 12/18] e1000: #if 0 two functions

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Adrian Bunk <[EMAIL PROTECTED]> e1000_{read,write}_pci_cfg() are no longer used. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: Auke Kok <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_hw.h |2 -- driver

Re: [patch 09/18] Clean up duplicate includes in drivers/net/

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Jesper Juhl <[EMAIL PROTECTED]> This patch cleans up duplicate includes in drivers/net/ Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> Acked-by: "John W. Linville" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/atl1

Re: [patch 10/18] ax88796 printk fixes

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Andrew Morton <[EMAIL PROTECTED]> drivers/net/ax88796.c: In function `ax_probe': drivers/net/ax88796.c:825: warning: size_t format, different type arg (arg 4) drivers/net/ax88796.c:825: warning: size_t format, different type arg (arg 5) resource_size_t isn't size_

Re: [patch 08/18] 3c59x: check return of pci_enable_device()

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Mark Hindley <[EMAIL PROTECTED]> Check return of pci_enable_device in vortex_up(). Signed-off-by: Mark Hindley <[EMAIL PROTECTED]> Acked-by: Steffen Klassert <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/3c59x.c |8

Re: [patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: "Peter Oruba" <[EMAIL PROTECTED]> These driver changes incorporate the proposed PCI-X / PCI-Express read byte count interface. Reading and setting those valuse doesn't take place "manually", instead wrapping functions are called to allow quirks for some PCI bridge

Re: [PATCH 1/1] Use the pause counter to avoid a needless device reset

2007-08-13 Thread Jeff Garzik
Brice Goglin wrote: Use the pause counter to avoid a needless device reset, and print a message telling the admin that our link partner is flow controlling us down to 0 pkts/sec. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c | 25 ++---

Re: [patch 04/18] via-rhine: disable rx_copybreak on archs that don't allow unaligned DMA access

2007-08-13 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Dustin Marquess <[EMAIL PROTECTED]> Patch to disable the rx_copybreak feature on hardware architectures that don't allow unaligned DMA access. #ifdef code taken from tulip_core.c. Problem pointed out by Ivan Kokshaysky. Signed-off-by: Dustin Marquess <[EMAIL PRO

Re: [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation

2007-08-13 Thread Jeff Garzik
applied the ethtool part of this - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/6] e1000e: error handling for pci_map_single calls.

2007-08-13 Thread Jeff Garzik
Auke Kok wrote: index d14cc4b..0e80406 100644 --- a/drivers/net/e1000e/ethtool.c +++ b/drivers/net/e1000e/ethtool.c @@ -1042,6 +1044,10 @@ static int e1000_setup_desc_rings(struct e1000_adapter *adapter) tx_ring->buffer_info[i].dma = pci_map_single(pdev, s

Re: [PATCH 2/6] e1000e: remove namespace collisions with e1000

2007-08-13 Thread Jeff Garzik
Auke Kok wrote: To prevent future collisions we rename all extern's from e1000_ to e1000e_*. The list of changed symbols was taken from e1000.h Compile tested with CONFIG_E1000=y and CONFIG_E1000E=y. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/82571.c | 129 ++

Re: [PATCH 1/6] e1000e: Fix header includes [v2]

2007-08-13 Thread Jeff Garzik
Auke Kok wrote: Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/82571.c |4 drivers/net/e1000e/e1000.h |7 --- drivers/net/e1000e/es2lan.c |5 + drivers/net/e1000e/ethtool.c |3 ++- drivers/net/e1000e/hw.h |2 ++ drivers/net/e1000e/i

Re: [PATCH 2.6.24]S2io: Enhance device error/alarm handling

2007-08-13 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Added support to poll for entire set of device errors and alarms. - Optimized interrupt routine fast path. - Removed the unused variable, intr_type, in device private structure. Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PR

Re: [PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment

2007-08-13 Thread Jeff Garzik
Mariusz Kozlowski wrote: Hello, Unpatched version does sth like this: dev = alloc_etherdev(... private = netdev_priv(dev); ... dev->priv = private; which doesn't make much sense (does it?) because this is done in alloc_netdev() already. struct net_device *alloc_netdev(... { ...

Re: [PATCH 2.6.23 1/3]S2IO: Making MSIX as default intr_type

2007-08-13 Thread Jeff Garzik
applied 1-3 to #upstream (2.6.23), but we'll want to look into why NAPI and MSI-X aren't playing well for you. especially look at NAPI changes in net-2.6.24. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More m

[PATCH 3/3] /drivers/net ucc_geth ioremap balancing/returncode check (resend)

2007-08-13 Thread Scott Thompson
resending patchset against 2.6.23-rc3 for /drivers/net ioremap balancing / return check, previous patchset contained wordwrap errors: corrects: --sbus_ioremap return unchecked. --ioremap function unchecked --function failure cases did not clean up ioremap'd values. lne390.c -- believe

Re: [patch]support for USB autosuspend in the asix driver

2007-08-13 Thread Jeff Garzik
Oliver Neukum wrote: Hi, this implements support for USB autosuspend in the asix USB ethernet driver. Regards Oliver Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> David, does this look OK to you? I never saw much comment from anybody, and cannot really comment on

[PATCH 2/3] /drivers/net myri_sbus.c ioremap balancing/returncode check (resend)

2007-08-13 Thread Scott Thompson
resending patchset against 2.6.23-rc3 for /drivers/net ioremap balancing / return check, previous patchset contained wordwrap errors: corrects: --sbus_ioremap return unchecked. --ioremap function unchecked --function failure cases did not clean up ioremap'd values. lne390.c -- believe

[PATCH 1/3] /drivers/net ioremap balancing/returncode check (resend)

2007-08-13 Thread Scott Thompson
resending patchset against 2.6.23-rc3 for /drivers/net ioremap balancing / return check, previous patchset contained wordwrap errors: corrects: --sbus_ioremap return unchecked. --ioremap function unchecked --function failure cases did not clean up ioremap'd values. lne390.c -- believe

[PATCH] drivers/net/3c505: Convert to generic boolean

2007-08-13 Thread Richard Knutsson
Convert to generic boolean Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. Sent 2007-05-01, no replys diff --git a/drivers/net/3c505.c b/drivers/net/3c505.c index e985a85..acede30 100644 -

[PATCH] drivers/net/tokenring: Convert to generic boolean

2007-08-13 Thread Richard Knutsson
Convert to generic boolean Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. Sent 2007-05-01, no replys diff --git a/drivers/net/tokenring/ibmtr.c b/drivers/net/tokenring/ibmtr.c index 1e895

Re: [PATCH] xen-netfront: Avoid deref'ing skbafter it is potentially freed.

2007-08-13 Thread Jesper Juhl
On Monday 13 August 2007 21:54:37 Jeremy Fitzhardinge wrote: > xennet_tx_bug_gc can free the skb before we use it, so make sure we don't. > > Jeff, this is -rc material. > > Signed-off-by: Keir Fraser <[EMAIL PROTECTED]> > Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> > Cc: Jeff Garzik <

Re: Problem with semantics?

2007-08-13 Thread Andi Kleen
Shay Goikhman <[EMAIL PROTECTED]> writes: > Dear Linux maintainers, > > I'm doing : > > setsockopt(s, SO_RCVTIMEO, t1 ); // set time-out > t1 on socket while block receiving on it > select(,,, &fd_set_including(s), .., &errs, t2); // block till > receive or ti

Re: Distributed storage.

2007-08-13 Thread Daniel Phillips
On Monday 13 August 2007 02:12, Jens Axboe wrote: > > It is a system wide problem. Every block device needs throttling, > > otherwise queues expand without limit. Currently, block devices > > that use the standard request library get a slipshod form of > > throttling for free in the form of limit

Re: [PATCH RFC]: napi_struct V5

2007-08-13 Thread Roland Dreier
> > Could you explain why this is unfair? > > The simple answer is the core attempts DRR scheduling (search for the > paper by Varghese et al for more details) > If you have multiple users of a resource (network interfaces in this > case), then the quantum defines their weight. If you use

Re: [PATCH 2.6.23] cxgb3 - Fix dev->priv usage

2007-08-13 Thread David Miller
From: Divy Le Ray <[EMAIL PROTECTED]> Date: Mon, 13 Aug 2007 12:33:04 -0700 > From: Divy Le Ray <[EMAIL PROTECTED]> > > cxgb3 used netdev_priv() and dev->priv for different purposes. > In 2.6.23, netdev_priv() == dev->priv, cxgb3 needs a fix. > This patch is a partial backport of Dave Miller's ch

Re: [patch 27/28] Introduce U16_MAX and U32_MAX

2007-08-13 Thread David Miller
From: Satyam Sharma <[EMAIL PROTECTED]> Date: Mon, 13 Aug 2007 20:59:09 +0530 (IST) > On Fri, 10 Aug 2007, David Miller wrote: > > > 2) The reiserfs definition is going to define an equivalent > >value, so just adding an #undef and still letting reiserfs > >override is wrong. Why put a c

Re: [PATCH 2/4] Net: mac80211, remove bitfields from struct ieee80211_txrx_data

2007-08-13 Thread Jiri Slaby
Johannes Berg napsal(a): > On Sun, 2007-08-12 at 15:08 +0200, Jiri Slaby wrote: > >> -unsigned int fragmented:1; /* whether the MSDU was fragmented */ >> +/* whether the MSDU was fragmented */ >> +#define IEEE80211_TXRXD_FRAGMENTED BIT(0) >> +#define IEEE80211_TXRXD_TXUNICAST

Re: [PATCH 1/4] Net: mac80211, remove bitfields from struct ieee80211_tx_packet_data

2007-08-13 Thread Jiri Slaby
Johannes Berg napsal(a): > On Sun, 2007-08-12 at 15:08 +0200, Jiri Slaby wrote: > >> +if (control->flags & IEEE80211_TXCTL_REQ_TX_STATUS) >> +pkt_data->flags |= IEEE80211_TXPD_REQ_TX_STATUS; >> +if (control->flags & IEEE80211_TXCTL_DO_NOT_ENCRYPT) >> +pkt_data->flag

[PATCH] xen-netfront: Avoid deref'ing skbafter it is potentially freed.

2007-08-13 Thread Jeremy Fitzhardinge
xennet_tx_bug_gc can free the skb before we use it, so make sure we don't. Jeff, this is -rc material. Signed-off-by: Keir Fraser <[EMAIL PROTECTED]> Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> diff -r 8bfc43f6d1b0 drivers/net/xen-netfront.c --- a/d

[PATCH 2.6.23] cxgb3 - Fix dev->priv usage

2007-08-13 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> cxgb3 used netdev_priv() and dev->priv for different purposes. In 2.6.23, netdev_priv() == dev->priv, cxgb3 needs a fix. This patch is a partial backport of Dave Miller's changes in the net-2.6.24 git branch. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> -

Re: Realtek r8168 slow outbound transfer - potential fix/workaround

2007-08-13 Thread Bruce Cole
David Gundersen <[EMAIL PROTECTED]> : > Now, on to my workaround. Putting a spin style wait like the following > in front of the line above seemed to solve the problem for me: > > > if (RTL_R8(TxPoll) & NPQ) { > for (i = 20; i > 0; i--) { > if (!(RTL_R8(TxPoll) & NPQ)) >break; >

Re: [patch 27/28] Introduce U16_MAX and U32_MAX

2007-08-13 Thread Satyam Sharma
On Mon, 13 Aug 2007, Satyam Sharma wrote: > Hi David, > > > On Fri, 10 Aug 2007, David Miller wrote: > [...] > > 1) The reiserfs definition is better, it is _type_ based. > >Please use (~(__u16)0) and (~(__u32)0), respectively. > > Hmm, in that case ((__u16)0x) and ((__u32)0x)

Re: [2/2] 2.6.23-rc3: known regressions with patches

2007-08-13 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.23-rc3 with patches available. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Adrian Bunk9

Re: [3/4] 2.6.23-rc3: known regressions

2007-08-13 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.23-rc3. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Adrian Bunk9 Andi Kleen

Re: [PATCH] [5/2many] MAINTAINERS - 3CR990 NETWORK DRIVER

2007-08-13 Thread Dave Dillow
On Sun, 2007-08-12 at 23:21 -0700, [EMAIL PROTECTED] wrote: > Add file pattern to MAINTAINER entry > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Acked-by: Dave Dillow <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PR

Re: [PATCH] [70/2many] MAINTAINERS - ARPD SUPPORT

2007-08-13 Thread Alan Cox
On Mon, 13 Aug 2007 10:04:19 -0700 Joe Perches <[EMAIL PROTECTED]> wrote: > On Mon, 2007-08-13 at 17:35 +0100, Alan Cox wrote: > > I wouldn't add a pattern for this. > > Back to:ARPD SUPPORT > P:Jonathan Layes > L:netdev@vger.kernel.org > S:Maintained > > > Actually I think the entir

Re: RealTek 8169 support question

2007-08-13 Thread Chuck Lever
Francois Romieu wrote: Chuck Lever <[EMAIL PROTECTED]> : [...] Not yet. I wanted to check with "the Maintainer" to see if it was worth trying. :-) The last time I tried a kernel build on one of these It is worth trying. FYI: I tested a 2.6.23-rc2 kernel over the weekend, and the NICs wor

Disabling 64-bit DMA on atl1?

2007-08-13 Thread Chris Snook
Jeff -- Can we please get Luca's patch merged for 2.6.23? The bug is a data corrupter, and the workaround doesn't cost us much. Both Jay and I have already acked it. http://lkml.org/lkml/2007/6/25/293 We'll do it "the right way" once Atheros tracks it down with hardware analyzers, but fo

Re: [PATCH] [459/2many] MAINTAINERS - SPIDERNET NETWORK DRIVER for CELL

2007-08-13 Thread Joe Perches
On Mon, 2007-08-13 at 10:45 -0500, Linas Vepstas wrote: > Note quite right. spider-pic is not part of spider_net. SPIDERNET NETWORK DRIVER for CELL P: Linas Vepstas M: [EMAIL PROTECTED] L: netdev@vger.kernel.org S: Supported F: Documentation/networking/spider_net.txt F:

Problem with semantics?

2007-08-13 Thread Shay Goikhman
Dear Linux maintainers, I'm doing : setsockopt(s, SO_RCVTIMEO, t1 ); // set time-out t1 on socket while block receiving on it select(,,, &fd_set_including(s), .., &errs, t2); // block till receive or time-out t 2 jointly on a set of sockets Apparently, I co

Re: [PATCH] [70/2many] MAINTAINERS - ARPD SUPPORT

2007-08-13 Thread Joe Perches
On Mon, 2007-08-13 at 17:35 +0100, Alan Cox wrote: > I wouldn't add a pattern for this. Back to:ARPD SUPPORT P: Jonathan Layes L: netdev@vger.kernel.org S: Maintained > Actually I think the entire thing is a > bad idea but thats another matter. Of course it's not an end-all soluti

Re: PROBLEM: 2.6.23-rc "NETDEV WATCHDOG: eth0: transmit timed out"

2007-08-13 Thread Francois Romieu
(netdev Cced) Karl Meyer <[EMAIL PROTECTED]> : [...] > I am having trouble with the 2.6.23 kernel. With all versions since > 2.6.23-rc1 I have trouble with my network connection. When using the > network over a certain level (just browsing the web seems not to be > enough) e.g. when installing pac

Re: [PATCH] [70/2many] MAINTAINERS - ARPD SUPPORT

2007-08-13 Thread Alan Cox
On Mon, 13 Aug 2007 08:46:06 -0700 Joe Perches <[EMAIL PROTECTED]> wrote: > On Mon, 2007-08-13 at 11:49 +0100, Alan Cox wrote: > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 90c1b81..ac2226b 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -697,6 +697,7 @@ ARPD SUPPORT > >

Re: [KJ] replacing kmalloc with kzalloc in drivers/net/sb1250-mac.c

2007-08-13 Thread Robert P. J. Day
On Mon, 13 Aug 2007, Surya Prabhakar N wrote: > Hi, >Replacing kmalloc with kzalloc and cleaning up memset in > drivers/net/sb1250-mac.c > > > Signed-off-by: Surya Prabhakar <[EMAIL PROTECTED]> > --- > > diff --git a/drivers/net/sb1250-mac.c b/drivers/net/sb1250-mac.c > index e7fdcf1..2dca5a7

Re: possible BUG while using CUPS

2007-08-13 Thread Udo van den Heuvel
Michal Piotrowski wrote: > On 11/08/07, Udo van den Heuvel <[EMAIL PROTECTED]> wrote: >> Using Cups 1.2.12 on Linux 2.6.22.1. (...) >> I clikc that link and hear the ping-ping of the BUG: > > This is very interesting. Can you reproduce this bug? I think so. (at least: I have seen it before: click

Re: [PATCH] [70/2many] MAINTAINERS - ARPD SUPPORT

2007-08-13 Thread Joe Perches
On Mon, 2007-08-13 at 11:49 +0100, Alan Cox wrote: > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 90c1b81..ac2226b 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -697,6 +697,7 @@ ARPD SUPPORT > > P: Jonathan Layes > > L: netdev@vger.kernel.org > > S: Maintained > > +F: net/ipv4/

Re: [PATCH] [459/2many] MAINTAINERS - SPIDERNET NETWORK DRIVER for CELL

2007-08-13 Thread Linas Vepstas
On Sun, Aug 12, 2007 at 11:36:42PM -0700, [EMAIL PROTECTED] wrote: > Add file pattern to MAINTAINER entry > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > diff --git a/MAINTAINERS b/MAINTAINERS > index b616562..fa8fb1c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4377,6 +4377,9 @@ P

Re: possible BUG while using CUPS

2007-08-13 Thread Michal Piotrowski
Hi Udo, On 11/08/07, Udo van den Heuvel <[EMAIL PROTECTED]> wrote: > Using Cups 1.2.12 on Linux 2.6.22.1. > Managing a printer from a Win2K workstation via the http interface. > I am at: http://box:631/printers > I click Set as default. > I see: > 426 Upgrade Required > > You must access this page

Re: [patch 27/28] Introduce U16_MAX and U32_MAX

2007-08-13 Thread Satyam Sharma
Hi David, On Fri, 10 Aug 2007, David Miller wrote: > From: [EMAIL PROTECTED] > Date: Fri, 10 Aug 2007 14:12:10 -0700 > > > From: Satyam Sharma <[EMAIL PROTECTED]> > > > > ... in kernel.h and clean up home-grown macros elsewhere in the tree. > > > > Leave out the one in reiserfs_fs.h as it is

Re: [PATCH] [3/2many] MAINTAINERS - 3C359 NETWORK DRIVER

2007-08-13 Thread Arjan van de Ven
Hi, please in the future send just one patch for this; there's no real reason to split this up this finegrained... - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

What does -EIOCBQUEUED do?

2007-08-13 Thread Tetsuo Handa
Hello. There are several locations that handle -EIOCBQUEUED error code. According to include/linux/errno.h , it seems this code is NFS related and caller will receive completion event later. But I couldn't figure out where is the beginning point and what is happening. What functions are called be

Re: drivers/net/tokenring/3c359.c

2007-08-13 Thread Alan Cox
On Mon, 13 Aug 2007 15:43:30 +0530 Surya Prabhakar N <[EMAIL PROTECTED]> wrote: > Hi, >Replacing kmalloc with kzalloc and cleaning up memset in > drivers/net/tokenring/3c359.c > > > Signed-off-by: Surya Prabhakar <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> - To unsubscribe f

Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code

2007-08-13 Thread Neil Horman
On Mon, Aug 13, 2007 at 09:24:00AM -0400, Vlad Yasevich wrote: > Dave, Neil > > Sorry about that. Not sure what happened to that patch. Here is > the good patch with witespace cleanups. > > -vlad > Thank you Vlad, that looks much better. Not sure what happened either Regards Neil -- /*

Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code

2007-08-13 Thread Vlad Yasevich
Dave, Neil Sorry about that. Not sure what happened to that patch. Here is the good patch with witespace cleanups. -vlad -- SCTP: Rewrite of sctp buffer management code This patch introduces autotuning to the sctp buffer management code similar to the TCP. The buffer space can be grown if t

Re: [PATCH] [374/2many] MAINTAINERS - PCNET32 NETWORK DRIVER

2007-08-13 Thread Hans-Jürgen Koch
Am Montag 13 August 2007 09:18 schrieb Al Viro: > On Sun, Aug 12, 2007 at 11:46:49PM -0700, Joe Perches wrote: > > On Sun, 2007-08-12 at 23:36 -0700, David Miller wrote: > > > Ok, 374 patches is just rediculious. > > > > > > So many patches eats up an enormous amount of mailing list resources, > >

[kj] is_power_of_2 in net/core/neighbour.c

2007-08-13 Thread vignesh babu
Replacing n & (n - 1) for power of 2 check by is_power_of_2(n) Signed-off-by: vignesh babu <[EMAIL PROTECTED]> --- diff --git a/net/core/neighbour.c b/net/core/neighbour.c index ca2a153..f7de8f2 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -33,6 +33,7 @@ #include #include #

Re: Block device throttling [Re: Distributed storage.]

2007-08-13 Thread Daniel Phillips
On Monday 13 August 2007 05:18, Evgeniy Polyakov wrote: > > Say you have a device mapper device with some physical device > > sitting underneath, the classic use case for this throttle code. > > Say 8,000 threads each submit an IO in parallel. The device mapper > > mapping function will be called

Re: [PATCH] [504/2many] MAINTAINERS - USB PEGASUS DRIVER

2007-08-13 Thread Petko Manolov
On Sun, 12 Aug 2007, [EMAIL PROTECTED] wrote: Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index d822865..fc87fa7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4764,6 +4764,7 @@ L:[EMAIL PROTECTED] L: n

[kj] is_power_of_2 in net/pcmcia/pcnet_cs.c

2007-08-13 Thread vignesh babu
Replacing n & (n - 1) for power of 2 check by is_power_of_2(n) Signed-off-by: vignesh babu <[EMAIL PROTECTED]> --- diff --git a/drivers/net/pcmcia/pcnet_cs.c b/drivers/net/pcmcia/pcnet_cs.c index 63de89e..d23bf6e 100644 --- a/drivers/net/pcmcia/pcnet_cs.c +++ b/drivers/net/pcmcia/pcnet_cs.c @@ -36

Re: [RFD] Layering: Use-Case Composers (was: DRBD - what is it, anyways? [compare with e.g. NBD + MD raid])

2007-08-13 Thread David Greaves
[EMAIL PROTECTED] wrote: Would this just be relevant to network devices or would it improve support for jostled usb and sata hot-plugging I wonder? good question, I suspect that some of the error handling would be similar (for devices that are unreachable not haning the system for example), b

Re: [PATCH 1/4] Net: mac80211, remove bitfields from struct ieee80211_tx_packet_data

2007-08-13 Thread Johannes Berg
On Sun, 2007-08-12 at 15:08 +0200, Jiri Slaby wrote: > + if (control->flags & IEEE80211_TXCTL_REQ_TX_STATUS) > + pkt_data->flags |= IEEE80211_TXPD_REQ_TX_STATUS; > + if (control->flags & IEEE80211_TXCTL_DO_NOT_ENCRYPT) > + pkt_data->flags |= IEEE80211_TXPD_DO_NOT_EN

Re: [PATCH 2/4] Net: mac80211, remove bitfields from struct ieee80211_txrx_data

2007-08-13 Thread Johannes Berg
On Sun, 2007-08-12 at 15:08 +0200, Jiri Slaby wrote: > - unsigned int fragmented:1; /* whether the MSDU was fragmented */ > + /* whether the MSDU was fragmented */ > +#define IEEE80211_TXRXD_FRAGMENTED BIT(0) > +#define IEEE80211_TXRXD_TXUNICASTBIT(1) > +#define IEEE8

Re: Block device throttling [Re: Distributed storage.]

2007-08-13 Thread Evgeniy Polyakov
On Mon, Aug 13, 2007 at 05:18:14AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > > If limit is for > > 1gb of pending block io, and system has for example 2gbs of ram (or > > any other resonable parameters), then there is no way we can deadlock > > in allocation, since it will not force pag

Re: Block device throttling [Re: Distributed storage.]

2007-08-13 Thread Evgeniy Polyakov
On Mon, Aug 13, 2007 at 04:18:03AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > > No. Since all requests for virtual device end up in physical devices, > > which have limits, this mechanism works. Virtual device will > > essentially call either generic_make_request() for new physical > > de

Re: Block device throttling [Re: Distributed storage.]

2007-08-13 Thread Daniel Phillips
On Monday 13 August 2007 05:04, Evgeniy Polyakov wrote: > On Mon, Aug 13, 2007 at 04:04:26AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > > On Monday 13 August 2007 01:14, Evgeniy Polyakov wrote: > > > > Oops, and there is also: > > > > > > > > 3) The bio throttle, which is supposed to prev

Re: [PATCH] [374/2many] MAINTAINERS - PCNET32 NETWORK DRIVER

2007-08-13 Thread Jiri Kosina
On Sun, 12 Aug 2007, David Miller wrote: > Ok, 374 patches is just rediculious. > So many patches eats up an enormous amount of mailing list resources, > and for these patches in particular there are few reasons to split them > up at all. The fact that the split up landed you at 300+ patches is

Re: Block device throttling [Re: Distributed storage.]

2007-08-13 Thread Evgeniy Polyakov
On Mon, Aug 13, 2007 at 04:04:26AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > On Monday 13 August 2007 01:14, Evgeniy Polyakov wrote: > > > Oops, and there is also: > > > > > > 3) The bio throttle, which is supposed to prevent deadlock, can > > > itself deadlock. Let me see if I can reme

Re: Distributed storage.

2007-08-13 Thread Daniel Phillips
On Monday 13 August 2007 04:03, Evgeniy Polyakov wrote: > On Mon, Aug 13, 2007 at 03:12:33AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > > > This is not a very good solution, since it requires all users of > > > the bios to know how to free it. > > > > No, only the specific ->endio needs t

Re: Block device throttling [Re: Distributed storage.]

2007-08-13 Thread Daniel Phillips
On Monday 13 August 2007 01:23, Evgeniy Polyakov wrote: > On Sun, Aug 12, 2007 at 10:36:23PM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > > (previous incomplete message sent accidentally) > > > > On Wednesday 08 August 2007 02:54, Evgeniy Polyakov wrote: > > > On Tue, Aug 07, 2007 at 10:55:

Re: Block device throttling [Re: Distributed storage.]

2007-08-13 Thread Daniel Phillips
On Monday 13 August 2007 01:14, Evgeniy Polyakov wrote: > > Oops, and there is also: > > > > 3) The bio throttle, which is supposed to prevent deadlock, can > > itself deadlock. Let me see if I can remember how it goes. > > > > * generic_make_request puts a bio in flight > > * the bio gets pas

Re: Distributed storage.

2007-08-13 Thread Evgeniy Polyakov
On Mon, Aug 13, 2007 at 03:12:33AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > > This is not a very good solution, since it requires all users of the > > bios to know how to free it. > > No, only the specific ->endio needs to know that, which is set by the > bio owner, so this knowledge

Re: [PATCH] [70/2many] MAINTAINERS - ARPD SUPPORT

2007-08-13 Thread Alan Cox
On Sun, 12 Aug 2007 23:23:36 -0700 [EMAIL PROTECTED] wrote: > Add file pattern to MAINTAINER entry > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > diff --git a/MAINTAINERS b/MAINTAINERS > index 90c1b81..ac2226b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -697,6 +697,7 @@ ARPD SUPP

Re: Distributed storage.

2007-08-13 Thread Daniel Phillips
On Monday 13 August 2007 03:22, Jens Axboe wrote: > I never compared the bio to struct page, I'd obviously agree that > shrinking struct page was a worthy goal and that it'd be ok to uglify > some code to do that. The same isn't true for struct bio. I thought I just said that. Regards, Daniel -

Re: Distributed storage.

2007-08-13 Thread Jens Axboe
On Mon, Aug 13 2007, Daniel Phillips wrote: > On Monday 13 August 2007 03:06, Jens Axboe wrote: > > On Mon, Aug 13 2007, Daniel Phillips wrote: > > > Of course not. Nothing I said stops endio from being called in the > > > usual way as well. For this to work, endio just needs to know that > > > o

Re: Distributed storage.

2007-08-13 Thread Daniel Phillips
On Monday 13 August 2007 03:06, Jens Axboe wrote: > On Mon, Aug 13 2007, Daniel Phillips wrote: > > Of course not. Nothing I said stops endio from being called in the > > usual way as well. For this to work, endio just needs to know that > > one call means "end" and the other means "destroy", thi

drivers/net/tokenring/3c359.c

2007-08-13 Thread Surya Prabhakar N
Hi, Replacing kmalloc with kzalloc and cleaning up memset in drivers/net/tokenring/3c359.c Signed-off-by: Surya Prabhakar <[EMAIL PROTECTED]> --- diff --git a/drivers/net/tokenring/3c359.c b/drivers/net/tokenring/3c359.c index 9f1b6ab..d36dd53 100644 --- a/drivers/net/tokenring/3c359.c +++ b

  1   2   >