Re: [PATCH 1/4] Net: mac80211, remove bitfields from struct ieee80211_tx_packet_data

[Johannes Berg]

On Sun, 2007-08-12 at 15:08 +0200, Jiri Slaby wrote:

> +     if (control->flags & IEEE80211_TXCTL_REQ_TX_STATUS)
> +             pkt_data->flags |= IEEE80211_TXPD_REQ_TX_STATUS;
> +     if (control->flags & IEEE80211_TXCTL_DO_NOT_ENCRYPT)
> +             pkt_data->flags |= IEEE80211_TXPD_DO_NOT_ENCRYPT;
> +     if (control->flags & IEEE80211_TXCTL_REQUEUE)
> +             pkt_data->flags |= IEEE80211_TXPD_REQUEUE;
> +     if (control->type == IEEE80211_IF_TYPE_MGMT)
> +             pkt_data->flags |= IEEE80211_TXPD_MGMT_IFACE;

This looks weird. Can't we just use the same flags?

johannes

signature.asc
Description: This is a digitally signed message part