[PATCH 0/13] cxgb3 - driver updates

2007-08-10 Thread divy
Hi Jeff, I'm submitting a patch series for inclusion in netdev#upstream. Here is a brief description: - MAC hang workaround update - Modify max HW Rx coalescing size - Log SGE doorbell Fifo overflow - Use Tx immediate data for offload packets whenever possible - RDMA

[PATCH 13/13] cxgb3 - test MSI capabilities

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Check that the HW in really in MSI/MSI-X mode when it was succesfully enabled. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c | 42 drivers/net/cxgb3/regs.h |4 2 f

[PATCH 12/13] cxgb3 - log and clear PEX errors

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Clear pciE PEX errors late at module load time. Log details when PEX errors occur. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/net/cxgb3/t

[PATCH 11/13] cxgb3 - Firmware update

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Update firmware version Allow the driver to be up and running with older FW image Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |2 +- drivers/net/cxgb3/cxgb3_main.c |9 + drivers/net/cxgb3/t3_hw.c |

[PATCH 6/13] cxgb3 - tighten checks on TID values

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Enforce validity checks on connection ids Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_defs.h| 20 ++-- drivers/net/cxgb3/cxgb3_offload.c | 28 +++- 2 files changed, 41 insertions

[PATCH 10/13] cxgb3 - engine microcode update

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Load microcode engine when the interface is configured up. Bump up version to 1.1.0. Allow the driver to be and running with older microcode images. Allow ethtool to log the microcode version. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/c

[PATCH 7/13] cxgb3 - Fatal error update

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Stop the MAC when a fatal error is detected. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxg

[PATCH 8/13] cxgb3 - log adapter derial number

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Log HW serial number when cxgb3 module is loaded. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |2 ++ drivers/net/cxgb3/cxgb3_main.c |6 -- drivers/net/cxgb3/t3_hw.c |3 ++- 3 files changed, 8 insert

[PATCH 9/13] cxgb3 - Update internal memory management

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Set PM1 internal memory to round robin mode Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h |2 ++ drivers/net/cxgb3/t3_hw.c |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/cxgb3/regs.h

[PATCH 3/13] cxgb3 - SGE doorbell overflow warning

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Log doorbell Fifo overflow Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h |8 drivers/net/cxgb3/sge.c |4 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/net/cxgb3/regs.h b/drivers/

[PATCH 4/13] cxgb3 - use immediate data for offload Tx

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Send small TX_DATA work requests as immediate data even when there are fragments. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/sge.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/ne

[PATCH 5/13] cxgb3 - Expose HW memory page info

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Let the RDMA driver get HW page info to work around HW issues. Assign explicit enum values. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_ctl_defs.h | 52 +--- drivers/net/cxgb3/cxgb3_offload.c

[PATCH 1/13] cxgb3 - MAC workaround update

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Update the MAC workaround to deal with switches that do not honor pause frames. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |1 + drivers/net/cxgb3/xgmac.c | 22 +++--- 2 files changed, 12 insertions(

[PATCH 2/13] cxgb3 - Update rx coalescing length

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Set max Rx coalescing length to 12288 Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/cxgb3/common.h b/drivers/net/cxgb3/common.h index c46c2

Re: [PATCH 1/24] make atomic_read() behave consistently on alpha

2007-08-10 Thread Valdis . Kletnieks
On Sat, 11 Aug 2007 02:38:40 +0200, Segher Boessenkool said: > >> That means GCC cannot compile Linux; it already optimises > >> some accesses to scalars to smaller accesses when it knows > >> it is allowed to. Not often though, since it hardly ever > >> helps in the cost model it employs. > > > >

Re: [PATCH 6/24] make atomic_read() behave consistently on frv

2007-08-10 Thread Paul E. McKenney
On Sat, Aug 11, 2007 at 08:54:46AM +0800, Herbert Xu wrote: > Chris Snook <[EMAIL PROTECTED]> wrote: > > > > cpu_relax() contains a barrier, so it should do the right thing. For > > non-smp architectures, I'm concerned about interacting with interrupt > > handlers. Some drivers do use atomic_*

Re: [PATCH] b44-ssb: Fix the SSB dependency hell

2007-08-10 Thread Adrian Bunk
On Sat, Aug 11, 2007 at 02:57:36AM +0200, Johannes Berg wrote: > On Sat, 2007-08-11 at 02:43 +0200, Adrian Bunk wrote: > > > -ENOMENUCONFIGPATCH > > Has anybody decided how it could possibly even look like anyhow? It > should be fixed, but nobody has a plan. The simplest idea would be that an op

Re: [PATCH 6/24] make atomic_read() behave consistently on frv

2007-08-10 Thread Herbert Xu
Chris Snook <[EMAIL PROTECTED]> wrote: > > cpu_relax() contains a barrier, so it should do the right thing. For > non-smp architectures, I'm concerned about interacting with interrupt > handlers. Some drivers do use atomic_* operations. What problems with interrupt handlers? Access to int/lon

Re: [PATCH] b44-ssb: Fix the SSB dependency hell

2007-08-10 Thread Johannes Berg
On Sat, 2007-08-11 at 02:43 +0200, Adrian Bunk wrote: > -ENOMENUCONFIGPATCH Has anybody decided how it could possibly even look like anyhow? It should be fixed, but nobody has a plan. > That's horrible - you shouldn't force the user to manually enable three > options. Well, akpm says: "select

Re: [PATCH 1/24] make atomic_read() behave consistently on alpha

2007-08-10 Thread Segher Boessenkool
That means GCC cannot compile Linux; it already optimises some accesses to scalars to smaller accesses when it knows it is allowed to. Not often though, since it hardly ever helps in the cost model it employs. Please give an example code snippet + gcc version + arch to back this up. u

Re: [stable] [RFT] sky2: backport patch

2007-08-10 Thread Greg KH
On Tue, Aug 07, 2007 at 05:14:15PM -0400, Stephen Hemminger wrote: > Any volunteers to test this, it has a backport for the three main stability > patches: > 1. carrier management > 2. lost irq timer > 3. rechecking for packets in poll > 4. overlength packet hang. > > I am away from any sky2

Re: [PATCH 1/24] make atomic_read() behave consistently on alpha

2007-08-10 Thread Herbert Xu
On Sat, Aug 11, 2007 at 02:38:40AM +0200, Segher Boessenkool wrote: > >>That means GCC cannot compile Linux; it already optimises > >>some accesses to scalars to smaller accesses when it knows > >>it is allowed to. Not often though, since it hardly ever > >>helps in the cost model it employs. > >

Re: [PATCH] b44-ssb: Fix the SSB dependency hell

2007-08-10 Thread Adrian Bunk
On Sat, Aug 11, 2007 at 02:08:21AM +0200, Michael Buesch wrote: > This fixes the SSB dependency hell and introduces some > fake-options that only give some advice on what to select. > > We live with these fake options only until menuconfig is able > to tell more about needed dependencies and how t

Re: [PATCH 1/24] make atomic_read() behave consistently on alpha

2007-08-10 Thread Segher Boessenkool
That means GCC cannot compile Linux; it already optimises some accesses to scalars to smaller accesses when it knows it is allowed to. Not often though, since it hardly ever helps in the cost model it employs. Please give an example code snippet + gcc version + arch to back this up. u

Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code

2007-08-10 Thread Neil Horman
On Fri, Aug 10, 2007 at 04:37:59PM -0700, David Miller wrote: > From: Neil Horman <[EMAIL PROTECTED]> > Date: Fri, 10 Aug 2007 19:01:26 -0400 > > > Thanks for applying this Dave, but something seems to have occured during > > your > > application. The commitdiff: > > http://git.kernel.org/?p=lin

Re: [PATCH 9/24] make atomic_read() behave consistently on ia64

2007-08-10 Thread Paul Mackerras
Chris Snook writes: > I'll do this for the whole patchset. Stay tuned for the resubmit. Could you incorporate Segher's patch to turn atomic_{read,set} into asm on powerpc? Segher claims that using asm is really the only reliable way to ensure that gcc does what we want, and he seems to have a p

[PATCH] b44-ssb: Fix the SSB dependency hell

2007-08-10 Thread Michael Buesch
This fixes the SSB dependency hell and introduces some fake-options that only give some advice on what to select. We live with these fake options only until menuconfig is able to tell more about needed dependencies and how to resolve them. Cc: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Mich

Re: [PATCH 1/24] make atomic_read() behave consistently on alpha

2007-08-10 Thread Herbert Xu
On Fri, Aug 10, 2007 at 10:07:27PM +0200, Segher Boessenkool wrote: > > That means GCC cannot compile Linux; it already optimises > some accesses to scalars to smaller accesses when it knows > it is allowed to. Not often though, since it hardly ever > helps in the cost model it employs. Please g

net-2.6.24 being rebased...

2007-08-10 Thread David Miller
Because of the SCTP patch messup, I'm rebasing the net-2.6.24 tree in order to dike that patch out. Sorry for any inconvenience this might cause :-/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vge

Re: [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation

2007-08-10 Thread Andrew Morton
On Sat, 11 Aug 2007 00:52:38 +0200 "Logix -" <[EMAIL PROTECTED]> wrote: > On 8/11/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > > [akpm: this is a previously-nacked patch, but the problem is real] > > > > I think I'll drop the whole patch. I've been nursing the thing along for > > 1.5 ye

Re: [patch 27/28] Introduce U16_MAX and U32_MAX

2007-08-10 Thread Andrew Morton
On Fri, 10 Aug 2007 15:38:19 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: [EMAIL PROTECTED] > Date: Fri, 10 Aug 2007 14:12:10 -0700 > > > From: Satyam Sharma <[EMAIL PROTECTED]> > > > > ... in kernel.h and clean up home-grown macros elsewhere in the tree. > > > > Leave out the on

Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code

2007-08-10 Thread David Miller
From: Neil Horman <[EMAIL PROTECTED]> Date: Fri, 10 Aug 2007 19:01:26 -0400 > Thanks for applying this Dave, but something seems to have occured during your > application. The commitdiff: > http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.24.git;a=commitdiff;h=e20e5d698dcccd2e84ee2e1e482b0

RE: [PATCH 9/24] make atomic_read() behave consistently on ia64

2007-08-10 Thread Luck, Tony
> Here are the functions in which they occur in the object file. You > may have to chase down some inlining to find the function that > actually uses atomic_*(). Ignore this ... Andreas' patch was only two lines so I thought I'd "save time" by just hand-editing the source over on my build machine.

Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

2007-08-10 Thread Rick Jones
David Miller wrote: From: Ben Greear <[EMAIL PROTECTED]> Date: Fri, 10 Aug 2007 15:40:02 -0700 For GSO on output, is there a generic fallback for any driver that does not specifically implement GSO? Absolutely, in fact that's mainly what it's there for. I don't think there is any issue. T

Re: [PATCH 9/24] make atomic_read() behave consistently on ia64

2007-08-10 Thread Chris Snook
Linus Torvalds wrote: On Fri, 10 Aug 2007, Luck, Tony wrote: Here are the functions in which they occur in the object file. You may have to chase down some inlining to find the function that actually uses atomic_*(). Could you just make the "atomic_read()" and "atomic_set()" functions be inl

RE: [PATCH 9/24] make atomic_read() behave consistently on ia64

2007-08-10 Thread Linus Torvalds
On Fri, 10 Aug 2007, Luck, Tony wrote: > > Here are the functions in which they occur in the object file. You > may have to chase down some inlining to find the function that > actually uses atomic_*(). Could you just make the "atomic_read()" and "atomic_set()" functions be inline functions in

Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code

2007-08-10 Thread Neil Horman
On Fri, Aug 10, 2007 at 03:06:25PM -0700, David Miller wrote: > From: Vlad Yasevich <[EMAIL PROTECTED]> > Date: Fri, 10 Aug 2007 16:46:03 -0400 > > > This patch introduces autotuning to the sctp buffer management code > > similar to the TCP. The buffer space can be grown if the advertised > > rec

RE: [PATCH 9/24] make atomic_read() behave consistently on ia64

2007-08-10 Thread Luck, Tony
> Possibly. Either that or we've uncovered some latent bugs. Maybe a > combination of the two. Can you list those 19 changes so we can evaluate them? Here are the functions in which they occur in the object file. You may have to chase down some inlining to find the function that actually uses

Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

2007-08-10 Thread David Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Fri, 10 Aug 2007 15:40:02 -0700 > For GSO on output, is there a generic fallback for any driver that > does not specifically implement GSO? Absolutely, in fact that's mainly what it's there for. I don't think there is any issue. The knob is there via e

Re: [NET]: Share correct feature code between bridging and bonding

2007-08-10 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 9 Aug 2007 11:36:01 +0800 > Hi Dave: > > [NET]: Share correct feature code between bridging and bonding > > http://bugzilla.kernel.org/show_bug.cgi?id=8797 shows that the > bonding driver may produce bogus combinations of the checksum > flags and S

Re: [PATCH 9/24] make atomic_read() behave consistently on ia64

2007-08-10 Thread Chris Snook
Luck, Tony wrote: Use atomic64_read to read an atomic64_t. Thanks Andreas! Chris: This bug is why the 8-byte loads got changed to 4-byte + sign-extend by your change to atomic_read(). I figured as much. Thanks for confirming this. With this applied together with shuffling the volatile fro

Re: RealTek 8169 support question

2007-08-10 Thread Chuck Lever
Francois Romieu wrote: Chuck Lever <[EMAIL PROTECTED]> : [...] I just bought a new Jetway mainboard with a pair of RTL 8169 NICs. Mini-ITX J7F4 ? Yes. I wanted a low-power DSL router that will support IPv6 and have a familiar GUI. Have your tried 2.6.23-git-latest or at least a post 2.6

Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

2007-08-10 Thread Ben Greear
David Miller wrote: From: Ben Greear <[EMAIL PROTECTED]> I believe LRO is going to have to be disabled for routing/bridging, so the stack will probably need to become aware of it at some point... The packet will be GSO'd on output I believe, so it won't break anything. Alternatively, we cou

Re: [patch 27/28] Introduce U16_MAX and U32_MAX

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:10 -0700 > From: Satyam Sharma <[EMAIL PROTECTED]> > > ... in kernel.h and clean up home-grown macros elsewhere in the tree. > > Leave out the one in reiserfs_fs.h as it is in the userspace-visible part > of that header. Still, #undef the (equ

Re: [patch 28/28] Introduce strtol_check_range()

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:10 -0700 > From: Satyam Sharma <[EMAIL PROTECTED]> > > Callers (especially "store" functions for sysfs or configfs attributes) > that want to convert an input string to a number may often also want to > check for simple input sanity or allowabl

Re: [patch 26/28] netconsole: Support dynamic reconfiguration using configfs

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:09 -0700 > From: Satyam Sharma <[EMAIL PROTECTED]> > > Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. > > This patch introduces support for dynamic reconfiguration (adding, removing > and/or modifying parameters of netconsole targ

Re: [patch 25/28] netconsole: Support multiple logging targets

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:07 -0700 > From: Satyam Sharma <[EMAIL PROTECTED]> > > Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. > > This patch introduces support for multiple targets, independent of > CONFIG_NETCONSOLE_DYNAMIC -- this is useful even in the

Re: [patch 24/28] netconsole: Introduce netconsole_netdev_notifier

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:06 -0700 > From: Satyam Sharma <[EMAIL PROTECTED]> > > Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. > > To update fields of underlying netpoll structure at runtime on corresponding > NETDEV_CHANGEADDR or NETDEV_CHANGENAME notifi

RE: [PATCH 9/24] make atomic_read() behave consistently on ia64

2007-08-10 Thread Luck, Tony
> Use atomic64_read to read an atomic64_t. Thanks Andreas! Chris: This bug is why the 8-byte loads got changed to 4-byte + sign-extend by your change to atomic_read(). With this applied together with shuffling the volatile from the declaration to the usage (in both atomic_read() and atomic_set()

Re: [patch 21/28] netconsole: Use netif_running() in write_msg()

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:04 -0700 > From: Satyam Sharma <[EMAIL PROTECTED]> > > Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. > > Avoid unnecessarily disabling interrupts and calling netpoll_send_udp() if the > corresponding local interface is not up. >

Re: [patch 22/28] netconsole: Add some useful tips to documentation

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:05 -0700 > From: Satyam Sharma <[EMAIL PROTECTED]> > > Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. > > Add some useful general-purpose tips. Also suggest solution for the frequent > problem of console loglevel set too low nume

Re: [patch 23/28] netconsole: Introduce netconsole_target

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:05 -0700 > From: Satyam Sharma <[EMAIL PROTECTED]> > > Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. > > Introduce a wrapper structure over netpoll to represent logging targets > configured in netconsole. This will get extended

Re: [patch 20/28] netconsole: Simplify boot/module option setup logic

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:03 -0700 > From: Satyam Sharma <[EMAIL PROTECTED]> > > Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. > > Presently, boot/module parameters are set up quite differently for the case of > built-in netconsole (__setup() -> obsolete_

Re: [patch 19/28] netconsole: Remove bogus check

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:03 -0700 > From: Satyam Sharma <[EMAIL PROTECTED]> > > Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. > > The (!np.dev) check in write_msg() is bogus (always false), because: np.dev is > set by netpoll_setup(), which is called by

Re: [patch 18/28] netconsole: Cleanups, codingstyle, prettyfication

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:01 -0700 > From: Satyam Sharma <[EMAIL PROTECTED]> > > Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. > > (1) Remove unwanted headers. > (2) Mark __init and __exit as appropriate. > (3) Various trivial codingstyle and prettificati

Re: [patch 16/28] drivers/net/irda/irda-usb.c: mostly kmalloc + memset conversion to k[cz]alloc

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:00 -0700 > From: Mariusz Kozlowski <[EMAIL PROTECTED]> > > drivers/net/irda/irda-usb.c | 59694 -> 59541 (-153 bytes) > drivers/net/irda/irda-usb.o | 170588 -> 169256 (-1332 bytes) > > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > Cc

Re: [patch 17/28] drivers/atm/iphase.c: mostly kmalloc + memset conversion to kzalloc

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:12:01 -0700 > From: Mariusz Kozlowski <[EMAIL PROTECTED]> > > drivers/atm/iphase.c | 111508 -> 111431 (-77 bytes) > drivers/atm/iphase.o | 254740 -> 254260 (-480 bytes) > > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > Signed-off-by: A

Re: RealTek 8169 support question

2007-08-10 Thread Francois Romieu
Chuck Lever <[EMAIL PROTECTED]> : [...] > I just bought a new Jetway mainboard with a pair of RTL 8169 NICs. Mini-ITX J7F4 ? > After installing Fedora 7, and upgrading to 2.6.22.1-41.fc7, I still > can't get either of the NICs to recognize a link beat from my switch. > > lspci -v output: > >

BUG: when using 'brctl stp'

2007-08-10 Thread Daniel K.
I get this on the latest GIT, it was also present shortly after -rc1. I have not tested with earlier kernels. # brctl stp br0 on [ 169.672008] BUG: sleeping function called from invalid context at kernel/mutex.c:86 [ 169.672532] in_atomic():1, irqs_disabled():0 [ 169.672832] [ 169.672832] C

Re: [patch 15/28] drivers/net/wan/hdlc_fr.c: kmalloc + memset conversion to kzalloc

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:58 -0700 > From: Mariusz Kozlowski <[EMAIL PROTECTED]> > > drivers/net/wan/hdlc_fr.c | 31260 -> 31223 (-37 bytes) > drivers/net/wan/hdlc_fr.o | 144872 -> 144728 (-144 bytes) > > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > Acked-by

Re: [patch 14/28] dccp: fix memory leak and clean up style - dccp_feat_empty_confirm()

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:57 -0700 > From: Jesper Juhl <[EMAIL PROTECTED]> > > There's a memory leak in net/dccp/feat.c::dccp_feat_empty_confirm(). If we > hit the 'default:' case of the 'switch' statement, then we return without > freeing 'opt', thus leaking 'struct d

Re: [patch 12/28] fib_trie: cleanup

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:56 -0700 > From: Stephen Hemminger <[EMAIL PROTECTED]> > > Try this out: > * replace macro's with inlines > * get rid of places doing multiple evaluations of NODE_PARENT > > [EMAIL PROTECTED]: rcu_dereference wants an lval] > Cc: "Da

Re: [patch 13/28] fib_trie: macro cleanup

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:57 -0700 > From: Stephen Hemminger <[EMAIL PROTECTED]> > > This patch converts the messy macro for MASK_PFX to inline function > and expands TKEY_GET_MASK in the one place it is used. > > Cc: "David S. Miller" <[EMAIL PROTECTED]> > Signed-off-

Re: [patch 10/28] Clean up duplicate includes in net/xfrm/

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:54 -0700 > From: Jesper Juhl <[EMAIL PROTECTED]> > > This patch cleans up duplicate includes in > net/xfrm/ > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Applied to net-2.6, thanks

Re: [patch 11/28] fix theoretical ccids_{read,write}_lock() race

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:55 -0700 > From: Oleg Nesterov <[EMAIL PROTECTED]> > > Make sure that spin_unlock_wait() is properly ordered wrt atomic_inc(). > > (akpm: can't we convert this code to use rwlocks?) > > Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> > Cc: A

Re: [patch 08/28] Clean up duplicate includes in net/sunrpc/

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:53 -0700 > From: Jesper Juhl <[EMAIL PROTECTED]> > > This patch cleans up duplicate includes in > net/sunrpc/ > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > Cc: Trond Myklebust <[EMAIL PROTECTED]> > Cc: Neil Brown <[EMAIL PROTECTED

Re: [patch 09/28] Clean up duplicate includes in net/tipc/

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:54 -0700 > From: Jesper Juhl <[EMAIL PROTECTED]> > > This patch cleans up duplicate includes in > net/tipc/ > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Applied to net-2.6, thanks

Re: [patch 07/28] Clean up duplicate includes in net/sched/

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:53 -0700 > From: Jesper Juhl <[EMAIL PROTECTED]> > > This patch cleans up duplicate includes in > net/sched/ > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Applied to net-2.6, thank

Re: [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation

2007-08-10 Thread Andrew Morton
On Fri, 10 Aug 2007 17:13:49 -0400 Benjamin LaHaise <[EMAIL PROTECTED]> wrote: > On Fri, Aug 10, 2007 at 02:05:13PM -0700, [EMAIL PROTECTED] wrote: > > Also added a "disable_autoneg" module argument to completely disable > > autoneg on all cards using this driver. > ... > > [akpm: this is a previo

Re: [patch 04/28] Clean up duplicate includes in net/atm/

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:51 -0700 > From: Jesper Juhl <[EMAIL PROTECTED]> > > This patch cleans up duplicate includes in > net/atm/ > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > Cc: Chas Williams <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL

Re: [patch 05/28] Clean up duplicate includes in net/ipv4/

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:52 -0700 > From: Jesper Juhl <[EMAIL PROTECTED]> > > This patch cleans up duplicate includes in > net/ipv4/ > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Applied to net-2.6 - To un

Re: [patch 06/28] Clean up duplicate includes in net/ipv6/

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:52 -0700 > From: Jesper Juhl <[EMAIL PROTECTED]> > > This patch cleans up duplicate includes in > net/ipv6/ > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Applied to net-2.6, thanks

Re: [patch 03/28] Clean up duplicate includes in drivers/atm/

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:50 -0700 > From: Jesper Juhl <[EMAIL PROTECTED]> > > This patch cleans up duplicate includes in > drivers/atm/ > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > Cc: Chas Williams <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EM

Re: [patch 02/28] ip_auto_config fix

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:49 -0700 > From: Andrew Morton <[EMAIL PROTECTED]> > > Davem said (in February!): :-) > Signed-off-by: Joakim Tjernlund <[EMAIL PROTECTED]> > Cc: "David S. Miller" <[EMAIL PROTECTED]> > Cc: Trond Myklebust <[EMAIL PROTECTED]> > > Signed-off-

Re: [patch 01/28] fore200e_param_bs_queue() must be __devinit

2007-08-10 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 14:11:48 -0700 > From: Adrian Bunk <[EMAIL PROTECTED]> > > WARNING: drivers/built-in.o(.text+0x6203bb): Section mismatch: reference to > .init.text:fore200e_param_bs_queue (between 'fore200e_initialize' and > 'fore200e_monitor_putc') > > Signed-of

Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

2007-08-10 Thread David Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Fri, 10 Aug 2007 14:11:24 -0700 > Jeff Garzik wrote: > > > This patch copies Auke in adding NETIF_F_LRO. Is that just for > > temporary merging, or does the net core really not touch it at all? > > > > Because, logically, if NETIF_F_LRO exists nowhere

Re: [PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code

2007-08-10 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Fri, 10 Aug 2007 16:46:03 -0400 > This patch introduces autotuning to the sctp buffer management code > similar to the TCP. The buffer space can be grown if the advertised > receive window still has room. This might happen if small message > sizes ar

Re: [PATCH 9/24] make atomic_read() behave consistently on ia64

2007-08-10 Thread Andreas Schwab
"Luck, Tony" <[EMAIL PROTECTED]> writes: >> That's distressing. I'm about to resubmit with a volatile cast in >> atomic_set as well, since people expect that behavior and I've been >> shown a legitimate case where it could matter. Does the assembly look >> right with that cast in atomic_set()

Re: [PATCH RFC]: napi_struct V5

2007-08-10 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Fri, 10 Aug 2007 09:55:07 -0400 > On Thu, 2007-09-08 at 09:58 -0700, Roland Dreier wrote: > > > Could you explain why this is unfair? > > The simple answer is the core attempts DRR scheduling (search for the > paper by Varghese et al for more details) > If

Re: [patch 04/18] via-rhine: disable rx_copybreak on archs that don't allow unaligned DMA access

2007-08-10 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : > From: Dustin Marquess <[EMAIL PROTECTED]> > > Patch to disable the rx_copybreak feature on hardware architectures that > don't allow unaligned DMA access. > > #ifdef code taken from tulip_core.c. Problem pointed out by Ivan > Kokshaysky. Color me confus

Re: [PATCH net-2.6.24] [TCP]: Update comment about highest_sack validity

2007-08-10 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Fri, 10 Aug 2007 14:30:46 +0300 (EEST) > > This stale info came from the original idea, which proved to be > unnecessarily complex, sacked_out > 0 is easy to do and that when > it's going to be needed anyway (it _can_ be valid also when > sacked_out

RealTek 8169 support question

2007-08-10 Thread Chuck Lever
Hello Francois- I just bought a new Jetway mainboard with a pair of RTL 8169 NICs. After installing Fedora 7, and upgrading to 2.6.22.1-41.fc7, I still can't get either of the NICs to recognize a link beat from my switch. lspci -v output: 00:09.0 Ethernet controller: Realtek Semiconductor Co

Re: 2.6.23-rc2-mm2

2007-08-10 Thread Eric W. Biederman
Andrew Morton <[EMAIL PROTECTED]> writes: > There seems to be rather a lot of damage here. > > I assume that the sysctl changes are what caused the netfilter oopses. > > - nf_conntrack_init() calls nf_conntrack_expect_init() which fails due to > sysctl problems. In particular sysctl_check_tab

RE: [PATCH 9/24] make atomic_read() behave consistently on ia64

2007-08-10 Thread Luck, Tony
> That's distressing. I'm about to resubmit with a volatile cast in > atomic_set as well, since people expect that behavior and I've been > shown a legitimate case where it could matter. Does the assembly look > right with that cast in atomic_set() as well? No. With the casts to volatile in

[patch 09/18] Clean up duplicate includes in drivers/net/

2007-08-10 Thread akpm
From: Jesper Juhl <[EMAIL PROTECTED]> This patch cleans up duplicate includes in drivers/net/ Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> Acked-by: "John W. Linville" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_main.c |

[patch 26/28] netconsole: Support dynamic reconfiguration using configfs

2007-08-10 Thread akpm
From: Satyam Sharma <[EMAIL PROTECTED]> Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. This patch introduces support for dynamic reconfiguration (adding, removing and/or modifying parameters of netconsole targets at runtime) using a userspace interface exported via configfs. Documen

[patch 17/18] 3c59x: fix duplex configuration

2007-08-10 Thread akpm
From: Steffen Klassert <[EMAIL PROTECTED]> A special sequence of ifconfig up/down and plug/unplug the cable can break the duplex configuration of the driver. Setting vp->mii.full_duplex = vp->full_duplex in vortex_up should fix this. Addresses Bug 8575 3c59x duplex configuration broken http://bu

[patch 14/18] uli526x: add suspend and resume routines

2007-08-10 Thread akpm
From: Rafael J. Wysocki <[EMAIL PROTECTED]> Add suspend/resume support to the uli526x network driver (tested on x86_64, with "Ethernet controller: ALi Corporation M5263 Ethernet Controller, rev 40"). This patch is based on the suspend/resume code in the tg3 driver. Signed-off-by: Rafael J. Wysoc

[patch 12/18] e1000: #if 0 two functions

2007-08-10 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> e1000_{read,write}_pci_cfg() are no longer used. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Cc: Auke Kok <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_hw.h |2 -- drivers/net/e1000/e1000_main.c |

[patch 13/18] natsemi: fix netdev error acounting

2007-08-10 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> When a detailed netdev error is counted, we also must account for it in the aggregated error count. Addresses http://bugzilla.kernel.org/show_bug.cgi?id=8106 Cc: Tim Hockin <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Chongfeng Hu <[EMAIL PR

[patch 25/28] netconsole: Support multiple logging targets

2007-08-10 Thread akpm
From: Satyam Sharma <[EMAIL PROTECTED]> Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. This patch introduces support for multiple targets, independent of CONFIG_NETCONSOLE_DYNAMIC -- this is useful even in the default case and (including the infrastructure introduced in previous patc

[patch 20/28] netconsole: Simplify boot/module option setup logic

2007-08-10 Thread akpm
From: Satyam Sharma <[EMAIL PROTECTED]> Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. Presently, boot/module parameters are set up quite differently for the case of built-in netconsole (__setup() -> obsolete_checksetup() -> netpoll_parse_options() -> strlen(config) == 0 in init_netc

[patch 23/28] netconsole: Introduce netconsole_target

2007-08-10 Thread akpm
From: Satyam Sharma <[EMAIL PROTECTED]> Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. Introduce a wrapper structure over netpoll to represent logging targets configured in netconsole. This will get extended with other members in further patches. This is done independent of the (to

[patch 24/28] netconsole: Introduce netconsole_netdev_notifier

2007-08-10 Thread akpm
From: Satyam Sharma <[EMAIL PROTECTED]> Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. To update fields of underlying netpoll structure at runtime on corresponding NETDEV_CHANGEADDR or NETDEV_CHANGENAME notifications. ioctl(SIOCSIFHWADDR or SIOCSIFNAME) could be used to change the h

[patch 16/18] net/tulip/xircom_cb.c: remove superfulous priv assignment

2007-08-10 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> It does dev = alloc_etherdev(... private = netdev_priv(dev); ... dev->priv = private; which doesn't make much sense (does it?) because this is done in alloc_netdev() already. struct net_device *alloc_netdev(... { ... if (sizeof_priv)

[patch 21/28] netconsole: Use netif_running() in write_msg()

2007-08-10 Thread akpm
From: Satyam Sharma <[EMAIL PROTECTED]> Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. Avoid unnecessarily disabling interrupts and calling netpoll_send_udp() if the corresponding local interface is not up. Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]> Acked-by: Keiichi Kii <[EMA

[patch 18/18] 3c59x maintainer

2007-08-10 Thread akpm
From: Steffen Klassert <[EMAIL PROTECTED]> Add 3c59x maintainer. Signed-off-by: Steffen Klassert <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- MAINTAINERS |6 ++ 1 files changed, 6 insertions(+) diff -puN MAINTAINERS~add-3c59x-maintainer MAINTAINERS --- a/MAI

[patch 11/18] drivers/net/cxgb3/xgmac.c: remove dead code

2007-08-10 Thread akpm
From: Adrian Bunk <[EMAIL PROTECTED]> This patch removes dead code ("tx_xcnt" can never be != 0 at this place) spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/cxgb3/xgmac.c |5 + 1 files cha

[patch 22/28] netconsole: Add some useful tips to documentation

2007-08-10 Thread akpm
From: Satyam Sharma <[EMAIL PROTECTED]> Based upon initial work by Keiichi Kii <[EMAIL PROTECTED]>. Add some useful general-purpose tips. Also suggest solution for the frequent problem of console loglevel set too low numerically (i.e. for high priority messages only) on the sender. Signed-off-

[patch 15/18] drivers/net: remove superfluous memset

2007-08-10 Thread akpm
From: Mariusz Kozlowski <[EMAIL PROTECTED]> This patch covers something like this: dev = alloc_*dev(... ... priv = netdev_priv(dev); memset(priv, 0, sizeof(*priv)); The memset() here is superfluous. alloc_netdev() uses kzalloc() to allocate needed memory so there is no need to zero the p

  1   2   3   >