From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 9 Aug 2007 11:36:01 +0800
> Hi Dave: > > [NET]: Share correct feature code between bridging and bonding > > http://bugzilla.kernel.org/show_bug.cgi?id=8797 shows that the > bonding driver may produce bogus combinations of the checksum > flags and SG/TSO. > > For example, if you bond devices with NETIF_F_HW_CSUM and > NETIF_F_IP_CSUM you'll end up with a bonding device that > has neither flag set. If both have TSO then this produces > an illegal combination. > > The bridge device on the other hand has the correct code to > deal with this. > > In fact, the same code can be used for both. So this patch > moves that logic into net/core/dev.c and uses it for both > bonding and bridging. > > In the process I've made small adjustments such as only > setting GSO_ROBUST if at least one constituent device > supports it. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Applied, thanks a lot for fixing this bug Herbert! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
