Re: Proposed interface for per-packet mesh-ttl

2007-07-27 Thread Stephen Hemminger
On Fri, 27 Jul 2007 18:22:22 -0400 Dan Williams <[EMAIL PROTECTED]> wrote: > On Fri, 2007-07-27 at 20:56 +0100, Christoph Hellwig wrote: > > On Tue, Jul 03, 2007 at 12:29:24PM -0700, Javier Cardona wrote: > > > I'm currently working on per-packet mesh ttl. My plan is to register > > > new mesh so

[PATCH] forcedeth: mac address correct

2007-07-27 Thread Ayaz Abdulla
Resending: In older chipsets, the mac address was stored in reversed order. However, in newer chipsets, the mac address is in correct order. This patch takes those newer chipsets into account and does not rely on a special bit setup by BIOS'. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> ---

Re: [PATCH] forcedeth: mac address correct

2007-07-27 Thread Simon Arlott
On 27/07/07 04:33, Ayaz Abdulla wrote: > In older chipsets, the mac address was stored in reversed order. > However, in newer chipsets, the mac address is in correct order. This > patch takes those newer chipsets into account and does not rely on a > special bit setup by BIOS'. > > Signed-Off-By:

[PATCH] forcedeth: mac address correct

2007-07-27 Thread Ayaz Abdulla
In older chipsets, the mac address was stored in reversed order. However, in newer chipsets, the mac address is in correct order. This patch takes those newer chipsets into account and does not rely on a special bit setup by BIOS'. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> --- old/drivers

Re: D-Link DFE-580TX 4 port NIC problems

2007-07-27 Thread Mario Doering
On Fri, 27 Jul 2007 14:08:09 +0200 Clemens Koller <[EMAIL PROTECTED]> wrote: > Hi, Mario! > > Mario Doering schrieb: > > Hello, > > > > are there any news or questions on this issue? > > Can you try the latest kernel to see if the same problem > persists? > Is there any kernel version where it

Re: Proposed interface for per-packet mesh-ttl

2007-07-27 Thread Dan Williams
On Fri, 2007-07-27 at 20:56 +0100, Christoph Hellwig wrote: > On Tue, Jul 03, 2007 at 12:29:24PM -0700, Javier Cardona wrote: > > I'm currently working on per-packet mesh ttl. My plan is to register > > new mesh sockopts through netfilter. The user interface will be: > > NACK. Drivers should ne

[PATCH 1/2] HW VLAN filtering control (resend)

2007-07-27 Thread Mitch Williams
Add support to the VLAN subsystem for enabling/disabling hardware VLAN filtering at runtime. This is useful for debugging purposes. The existing vconfig utility can be used without modification. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.22.1-clean/inclu

[PATCH 2/2] HW VLAN filtering control (resend)

2007-07-27 Thread Mitch Williams
Add support to e1000 for enabling/disabling hardware VLAN filtering at runtime. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.22.1-clean/drivers/net/e1000/e1000_main.c linux-2.6.22.1/drivers/net/e1000/e1000_main.c --- linux-2.6.22.1-clean/drivers/net/e1000/e1

[PATCH 0/2] HW VLAN filtering control (resend)

2007-07-27 Thread Mitch Williams
This patchset adds the capability to disable hardware VLAN filtering at runtime via the existing vconfig utility. It's useful for debugging purposes. The first patch modifies the VLAN subsystem to define the flag, and to support passing the flag on to the base driver. The second patch modifies e

Re: [PATCH 0/2] HW VLAN filtering control

2007-07-27 Thread Mitch Williams
On Fri, 2007-07-27 at 14:06 -0700, Ben Greear wrote: > This looks fine to me. > > Ben > Grr. Except that Evolution mangled them. I'll have to repost. -Mitch - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

RFC/Progress update: e1000e pci-express -only e1000 driver

2007-07-27 Thread Kok, Auke
All, Here's a short update on progress with e1000e, the future pci-express -only version of the current e1000 driver. Since about a month ago, a lot has changed so I'd like to keep everyone posted on progress and solicit ideas. What happened since I posted "e1000new" ? Here's a summary: * e

Re: [PATCH 0/2] HW VLAN filtering control

2007-07-27 Thread Ben Greear
Mitch Williams wrote: This patchset adds the capability to disable hardware VLAN filtering at runtime via the existing vconfig utility. It's useful for debugging purposes. The first patch modifies the VLAN subsystem to define the flag, and to support passing the flag on to the base driver. The

Re: [2/3] 2.6.23-rc1: known regressions v2

2007-07-27 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.23-rc1. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Adrian Bunk6 Andi Kleen

[PATCH 2/2] HW VLAN filtering control

2007-07-27 Thread Mitch Williams
Add support to e1000 for enabling/disabling hardware VLAN filtering at runtime. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.22.1-clean/drivers/net/e1000/e1000_main.c linux-2.6.22.1/drivers/net/e1000/e1000_main.c --- linux-2.6.22.1-clean/drivers/net/e1000/e10

[PATCH 1/2] HW VLAN filtering control

2007-07-27 Thread Mitch Williams
Add support to the VLAN subsystem for enabling/disabling hardware VLAN filtering at runtime. This is useful for debugging purposes. The existing vconfig utility can be used without modification. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.22.1-clean/inclu

[PATCH 0/2] HW VLAN filtering control

2007-07-27 Thread Mitch Williams
This patchset adds the capability to disable hardware VLAN filtering at runtime via the existing vconfig utility. It's useful for debugging purposes. The first patch modifies the VLAN subsystem to define the flag, and to support passing the flag on to the base driver. The second patch modifies e

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-27 Thread Michael Buesch
On Friday 27 July 2007 22:12:49 Andrew Morton wrote: > On Fri, 27 Jul 2007 21:43:59 +0200 > Michael Buesch <[EMAIL PROTECTED]> wrote: > > > > Sure, but why is the locking interruptible rather than plain old > > > mutex_lock()? > > > > Hm, well. We hold this mutex for several seconds, as writing t

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-27 Thread Andrew Morton
On Fri, 27 Jul 2007 21:43:59 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: > > Sure, but why is the locking interruptible rather than plain old > > mutex_lock()? > > Hm, well. We hold this mutex for several seconds, as writing takes > this long. So I simply thought it was worth allowing the wai

RE: [PATCH 1/1]ixgbe: Driver for Intel 82598 based 10GbE PCI Express family of adapters

2007-07-27 Thread Veeraiyan, Ayyappan
>-Original Message- >From: Jeff Garzik [mailto:[EMAIL PROTECTED] >Veeraiyan, Ayyappan wrote: >> So, with driver/device supporting multiple Tx and Rx queues, I think, it >> would be very useful to have ethtool interface to manage the number of >> Tx and Rx queues of the interface. > > >Absol

Re: [PATCH 1/1]ixgbe: Driver for Intel 82598 based 10GbE PCI Express family of adapters

2007-07-27 Thread Jeff Garzik
Veeraiyan, Ayyappan wrote: So, with driver/device supporting multiple Tx and Rx queues, I think, it would be very useful to have ethtool interface to manage the number of Tx and Rx queues of the interface. Absolutely! ethtool patches welcome :) git://git.kernel.org/pub/scm/network/ethtool/et

Re: Proposed interface for per-packet mesh-ttl

2007-07-27 Thread Christoph Hellwig
On Tue, Jul 03, 2007 at 12:29:24PM -0700, Javier Cardona wrote: > I'm currently working on per-packet mesh ttl. My plan is to register > new mesh sockopts through netfilter. The user interface will be: NACK. Drivers should never add sockopt, and drivers should not abuse netfilter hooks. - To un

Re: [RFC 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-07-27 Thread Andrew Gallatin
Jan-Bernd Themann wrote: > On Wednesday 25 July 2007 19:17, Andrew Gallatin wrote: >> 3) Padded frames. >> >> I may be missing something, but I don't see where you >> either strip padding from frames or reject padded frames. >> (see the pskb_trim_rcsum() in net/ipv4/ip_input.c:ip_rcv() >> > I th

RE: [PATCH 1/1]ixgbe: Driver for Intel 82598 based 10GbE PCI Express family of adapters

2007-07-27 Thread Veeraiyan, Ayyappan
>-Original Message- >From: Jeff Garzik [mailto:[EMAIL PROTECTED] > >Stephen Hemminger wrote: >> Using module parameter for per device settings is bad idea. >> Please extend existing interfaces like ethtool, etc rather than >committing >> to a bad inflexible API. > > >I agreed with Stephen's

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-27 Thread Michael Buesch
On Friday 27 July 2007 21:38:53 Andrew Morton wrote: > > > > +static ssize_t ssb_pci_attr_sprom_show(struct device *pcidev, > > > > + struct device_attribute *attr, > > > > + char *buf) > > > > +{ > > > > + struct pci_d

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-27 Thread Michael Buesch
On Friday 27 July 2007 21:21:20 John W. Linville wrote: > On Fri, Jul 27, 2007 at 06:57:20PM +0200, Michael Buesch wrote: > > The Sonics Silicon Backplane is a mini-bus used on > > various Broadcom chips and embedded devices. > > Devices using the SSB include b44, bcm43xx and various > > Broadcom b

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-27 Thread Andrew Morton
On Fri, 27 Jul 2007 21:30:48 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: > > ERROR: "foo * bar" should be "foo *bar" > > #4156: FILE: drivers/ssb/ssb_private.h:119: > > +extern struct ssb_bus * ssb_pci_dev_to_bus(struct pci_dev *pdev); > > > > are worth addressing. > > Well, I intentionally

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-27 Thread John W. Linville
On Fri, Jul 27, 2007 at 06:57:20PM +0200, Michael Buesch wrote: > The Sonics Silicon Backplane is a mini-bus used on > various Broadcom chips and embedded devices. > Devices using the SSB include b44, bcm43xx and various > Broadcom based wireless routers. > A b44 and bcm43xx port and a SSB based OH

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-27 Thread Michael Buesch
On Friday 27 July 2007 21:03:18 Andrew Morton wrote: > On Fri, 27 Jul 2007 18:57:20 +0200 > Michael Buesch <[EMAIL PROTECTED]> wrote: > > > The Sonics Silicon Backplane is a mini-bus used on > > various Broadcom chips and embedded devices. > > Devices using the SSB include b44, bcm43xx and various

Re: sk98lin for 2.6.23-rc1

2007-07-27 Thread Daniel J Blueman
> If anyone still has hang issues with sky2, please send me the hardware > information (lspci, dmesg output), and capture the debugfs state after hang. > > At present the known open skge, sky2 issues are: [snip] There is still this active issue which I believe is orthogonal from the interrupt hang

Re: [PATCH] Merge the Sonics Silicon Backplane subsystem

2007-07-27 Thread Andrew Morton
On Fri, 27 Jul 2007 18:57:20 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: > The Sonics Silicon Backplane is a mini-bus used on > various Broadcom chips and embedded devices. > Devices using the SSB include b44, bcm43xx and various > Broadcom based wireless routers. > A b44 and bcm43xx port and

[PATCH] netxen: drop redudant spinlock

2007-07-27 Thread Dhananjay Phadke
Some leftover code that makes use of adapter->lock in tx_timeout function, which resets the interface under this lock. In close() when the workqueue is flushed, prints the warning about sleeping with interrupts disabled (when spinlock debug is enabled). The lock was required with private netxen IOC

RE: [FIX] NET: Fix sch_api and sch_prio to properly set and detect the root qdisc

2007-07-27 Thread Waskiewicz Jr, Peter P
> From: Patrick McHardy [mailto:[EMAIL PROTECTED] > Sent: Tuesday, July 24, 2007 5:36 PM > To: Waskiewicz Jr, Peter P > Cc: [EMAIL PROTECTED]; netdev@vger.kernel.org > Subject: Re: [FIX] NET: Fix sch_api and sch_prio to properly > set and detect the root qdisc > [...] > Both look good, thanks. >

Re: D-Link DFE-580TX 4 port NIC problems

2007-07-27 Thread adi
On Fri, Jul 27, 2007 at 02:08:09PM +0200, Clemens Koller wrote: > Can you try the latest kernel to see if the same problem > persists? > Is there any kernel version where it was working fine? In my case, this is 'problem' occur when I do run snmpd on the same machine, and I saw that snmpd doing so

Re: [PATCH 4/4] l2cap: don't mangle cmd.len

2007-07-27 Thread Marcel Holtmann
Hi Al, > Since nobody uses it after we convert it to host-endian, > no need to do that at all. At that point l2cap is endian-clean. > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Marcel Holtmann <[EMAIL PROTECTED]> Regards Marcel - To unsubscribe from this list: send the line

Re: [PATCH 3/4] pass (host-endian) cmd length as explicit argument to l2cap_conf_req()

2007-07-27 Thread Marcel Holtmann
Hi All, > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Marcel Holtmann <[EMAIL PROTECTED]> Regards Marcel - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-inf

Re: [PATCH 1/4] fix endianness bug in l2cap_sock_listen()

2007-07-27 Thread Marcel Holtmann
Hi Al, > We loop through psm values, calling __l2cap_get_sock_by_addr(psm, ...) > until we get NULL; then we set ->psm of our socket to htobs(psm). > IOW, we find unused psm value and put it into our socket. So far, so > good, but... __l2cap_get_sock_by_addr() compares its argument with > ->psm

Re: [PATCH 2/4] l2cap: endianness annotations

2007-07-27 Thread Marcel Holtmann
Hi Al, > no code changes, just documenting existing types > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Marcel Holtmann <[EMAIL PROTECTED]> Regards Marcel - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More ma

Re: [PATCH 1/1]ixgbe: Driver for Intel 82598 based 10GbE PCI Express family of adapters

2007-07-27 Thread Jeff Garzik
Stephen Hemminger wrote: Using module parameter for per device settings is bad idea. Please extend existing interfaces like ethtool, etc rather than committing to a bad inflexible API. I agreed with Stephen's comments here. In general, net driver policy is to use ethtool (per-interface granu

Re: sk98lin for 2.6.23-rc1

2007-07-27 Thread Stephen Hemminger
On Fri, 27 Jul 2007 08:58:45 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > If anyone still has hang issues with sky2, please send me the hardware > > information (lspci, dmesg output), and capture the debugfs state after hang. > > > > At present the known open skge,

Re: [RFC 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-07-27 Thread Jeff Garzik
Just to chime in... In general, I like where this LRO effort is going, and I really appreciate you guys working on it. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.or

Re: sk98lin for 2.6.23-rc1

2007-07-27 Thread Jeff Garzik
Stephen Hemminger wrote: If anyone still has hang issues with sky2, please send me the hardware information (lspci, dmesg output), and capture the debugfs state after hang. At present the known open skge, sky2 issues are: Did you add Chris Stromsoe's skge-hangs problem to the list? Je

[PATCH 4/4] l2cap: don't mangle cmd.len

2007-07-27 Thread Al Viro
Since nobody uses it after we convert it to host-endian, no need to do that at all. At that point l2cap is endian-clean. Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- net/bluetooth/l2cap.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/net/bluetooth/l2cap.c b/net/blue

[PATCH 3/4] pass (host-endian) cmd length as explicit argument to l2cap_conf_req()

2007-07-27 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- net/bluetooth/l2cap.c | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c index 09126bf..03309d2 100644 --- a/net/bluetooth/l2cap.c +++ b/net/bluetooth/l2cap.c @@

[PATCH 2/4] l2cap: endianness annotations

2007-07-27 Thread Al Viro
no code changes, just documenting existing types Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- include/net/bluetooth/l2cap.h | 50 net/bluetooth/l2cap.c | 27 +++-- 2 files changed, 39 insertions(+), 38 deletions(-) diff --gi

[PATCH 1/4] fix endianness bug in l2cap_sock_listen()

2007-07-27 Thread Al Viro
We loop through psm values, calling __l2cap_get_sock_by_addr(psm, ...) until we get NULL; then we set ->psm of our socket to htobs(psm). IOW, we find unused psm value and put it into our socket. So far, so good, but... __l2cap_get_sock_by_addr() compares its argument with ->psm of sockets. IOW,

Re: [RFC 0/1] lro: Generic Large Receive Offload for TCP traffic

2007-07-27 Thread Jan-Bernd Themann
Hi Drew, thanks a lot for your good feedback. See comments below. I'll try to provide an updated version next week. It would be nice if you could post a patch for your driver once we have addressed the issues you mentioned. Then we would have the eHEA driver for the SKB interface, and your driver

Re: D-Link DFE-580TX 4 port NIC problems

2007-07-27 Thread Clemens Koller
Hi, Mario! Mario Doering schrieb: Hello, are there any news or questions on this issue? Can you try the latest kernel to see if the same problem persists? Is there any kernel version where it was working fine? On Wed, 9 May 2007 03:27:00 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: On W

Re: D-Link DFE-580TX 4 port NIC problems

2007-07-27 Thread Mario Doering
Hello, are there any news or questions on this issue? Mario. On Wed, 9 May 2007 03:27:00 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 9 May 2007 12:01:42 +0200 Mario Doering <[EMAIL PROTECTED]> > wrote: > > > Hello, > > > > we have a D-Link DFE-580TX 4 port network card in our

source interface ping bug ?

2007-07-27 Thread nano bug
Hello there, I'm facing the following issue : when I try to ping using source interface instead of a source ip address the ping utility starts to send arp requests instead of icmp requests though the ip address I'm pinging it's not in the subnets directly connected to my linux box. I've noticed th

Re: Multicast issues with RTL8110SC in r8169.c

2007-07-27 Thread Glen Gray
Francois Romieu wrote: Glen Gray <[EMAIL PROTECTED]> : Hey Francois, I've CC'd the netdev list as requested Your PR is not lost (nor are the pending ones btw...). I'm simply trying to find a real explanation for https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242572 Ah, apologies. When

Re: sk98lin for 2.6.23-rc1

2007-07-27 Thread Stephen Hemminger
If anyone still has hang issues with sky2, please send me the hardware information (lspci, dmesg output), and capture the debugfs state after hang. At present the known open skge, sky2 issues are: 1) Skge doesn't work with dual port fiber 2) Sky2 (and vendor sk98lin) don't work on some MSI mother

[RFT 4/4] fib_trie: whitespace cleanup

2007-07-27 Thread Stephen Hemminger
Try and be consistent with whitespace and line wrapping. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2007-07-27 08:57:53.0 +0100 +++ b/net/ipv4/fib_trie.c 2007-07-27 08:57:54.0 +0100 @@ -154,7 +154,8 @@ struct trie { }; static voi

[RFT 2/4] fib_trie: convert macros to inline

2007-07-27 Thread Stephen Hemminger
Get rid of some of the macro's in this code. If only used once, just expand the usage in that spot. Otherwise convert to inline. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2007-07-27 08:00:30.0 +0100 +++ b/net/ipv4/fib_trie.c 2007-07-27 08:41

[RFT 1/4] fib_trie: use inline for node_parent references

2007-07-27 Thread Stephen Hemminger
The use of macro's for set/referencing node parent causes issues with the rcu macros. Convert them to inline and fix a couple of spots where node_parent() was being called multiple times which added unneeded barriers. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c

[RFT 3/4] fib_trie: fix sparse warnings

2007-07-27 Thread Stephen Hemminger
There were a couple of places where sparse found declarations that covered earlier declarations. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/net/ipv4/fib_trie.c 2007-07-27 08:41:46.0 +0100 +++ b/net/ipv4/fib_trie.c 2007-07-27 08:47:05.0 +0100 @@ -651,7 +

[RFT 0/4] fib_trie cleanup patches

2007-07-27 Thread Stephen Hemminger
Here is a slightly revised version of the FIB trie cleanup patches. I don't have a machine with anywhere near enough routes to test this, so would someone with many routes give it a go and make sure nothing got busted in the process. -- - To unsubscribe from this list: send the line "unsubscrib