Add HOWTO documentation on what batching is, how to implement drivers to use
it, and how users can enable/disable batching.
Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
---
Batching_skb_API.txt | 91 +++
1 files changed, 91 insertions(+)
diff
On Thu, 19 Jul 2007 18:35:04 +0200,
Michal Piotrowski <[EMAIL PROTECTED]> wrote:
> FS
>
> Subject : AFS compile broken
> References : http://lkml.org/lkml/2007/7/19/218
> Last known good : ?
> Submitter : Meelis Roos <[EMAIL PROTECTED]>
> Caused-By : ?
> Handled-By :
Hi Dave, Roland, everyone,
In May, I had proposed creating an API for sending 'n' skbs to a driver to
reduce lock overhead, DMA operations, and specific to drivers that have
completion notification like IPoIB - reduce completion handling ("[RFC] New
driver API to speed up small packets xmits" @
ht
IPoIB Multicast and CM changes for batching support.
Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
---
ipoib_cm.c| 13 +
ipoib_multicast.c |4 ++--
2 files changed, 11 insertions(+), 6 deletions(-)
diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_cm.c
new/drivers/i
Add batching support to IPoIB post_send and TX completion handler.
Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
---
ipoib_ib.c | 233 -
1 files changed, 187 insertions(+), 46 deletions(-)
diff -ruNp org/drivers/infiniband/ulp/ipoib
net/sched/sch_generic.c changes to support batching. Adds a batch
aware function (get_skb) to get skbs to send.
Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
---
sch_generic.c | 94 +++---
1 files changed, 71 insertions(+), 23 deletions(-)
IPoIB header file changes.
Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
---
ipoib.h |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib.h
new/drivers/infiniband/ulp/ipoib/ipoib.h
--- org/drivers/infiniband/ulp/ipoib/ipoib.h
Support to turn on/off batching from /sys.
Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
---
net-sysfs.c | 70
1 files changed, 70 insertions(+)
diff -ruNp org/net/core/net-sysfs.c new/net/core/net-sysfs.c
--- org/net/core/net-sys
Networking include file changes for batching.
Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
---
linux/netdevice.h | 10 ++
net/pkt_sched.h |6 +++---
2 files changed, 13 insertions(+), 3 deletions(-)
diff -ruNp org/include/linux/netdevice.h new/include/linux/netdevice.h
--- or
Add a IPoIB batching xmit handler.
Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
---
ipoib_main.c | 215 +--
1 files changed, 210 insertions(+), 5 deletions(-)
diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_main.c
new/drivers/infini
On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug <[EMAIL PROTECTED]> wrote:
>
> device_bind_driver() error code returning has been fixed.
> release() function has been written, so that to free resources
> in correct way; the release path is now clean.
>
> Before the rework, it used to cause
Can someone help to assess suggested in the bugzilla? The author found
that ibmtr_cs works fine in 64 but mode, and config parameters suggest
it doesn't.
Thanks!
-- Forwarded message --
From: [EMAIL PROTECTED] <[EMAIL PROTECTED]>
Date: Jul 19, 2007 8:43 PM
Subject: [Bug 7133] ibmt
On Thu, Jul 19, 2007 at 09:10:26PM -0500, Steven J. Hill wrote:
> Dale Farnsworth wrote:
> >
> > You have replaced the use of the global PHY spinlock with a per-port
> > spinlock.
> > However, the SMI register is shared by all ports. The global lock is
> > needed to prevent simultaneous updates
On 7/20/07, David Miller <[EMAIL PROTECTED]> wrote:
Please don't quote a big huge patch just to say one sentence that
doesn't apply to any particular specific part of a patch.
That's wastes bandwidth, annoys people you might actually want
a response from, and is bad netiquette in general.
Thank
>From ehea_start_xmit in ehea_main.c we have:
if (unlikely(atomic_read(&pr->swqe_avail) <= 1)) {
spin_lock_irqsave(&pr->netif_queue, flags);
if (unlikely(atomic_read(&pr->swqe_avail) <= 1)) {
pr->p_stats.queue_stopped++;
netif_sto
From: "rae l" <[EMAIL PROTECTED]>
Date: Fri, 20 Jul 2007 09:51:05 +0800
> Is there any more comments on this?
Please don't quote a big huge patch just to say one sentence that
doesn't apply to any particular specific part of a patch.
That's wastes bandwidth, annoys people you might actually want
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Dale Farnsworth wrote:
>
> You have replaced the use of the global PHY spinlock with a per-port spinlock.
> However, the SMI register is shared by all ports. The global lock is
> needed to prevent simultaneous updates of the register by drivers for
>
On 7/18/07, Denis Cheng <[EMAIL PROTECTED]> wrote:
- removed three function declarations from header file to mark them static,
- reduced one file
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
---
this one is just merging by concatenating, and I'll try to adjust some
function definitions' order
On 7/20/07, Paul Clements <[EMAIL PROTECTED]> wrote:
Denis Cheng wrote:
> this memcpy looks so strange, in fact it's merely a pointer dereference,
> so I change the parameter's type to refer it more directly,
> this could make the memcpy not needed anymore.
>
> in the function nbd_read_stat where
On Thu, 19 Jul 2007, Joy Latten wrote:
> --- linux-2.6.22/include/linux/audit.h2007-07-19 13:17:22.0
> -0500
> +++ linux-2.6.22.patch/include/linux/audit.h 2007-07-19 13:21:29.0
> -0500
> @@ -108,10 +108,7 @@
> #define AUDIT_MAC_CIPSOV4_DEL1408/* NetLabel: d
Jeff Garzik wrote:
Kok, Auke wrote:
http://foo-projects.org/~sofar/igb.patch [558K]
http://foo-projects.org/~sofar/igb.patch.bz2 [98K]
Just took a look at this.
This has the same problem as in the other thread -- huge internal API --
except this time, the problem is emphasi
Use constants already provided by the kernel for ethernet related lengths.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_hw.h |5 -
drivers/net/atl1/atl1_main.c | 13 +++--
2 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/net/a
The DMA engine setup contains a typo that can result in an incorrect
dmaw_block setting.
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1
s/dam/dma
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_hw.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_hw.h b/drivers/net/atl1/atl1_hw.h
index 100c09c..f0d7e82 100644
--- a/drivers/net/atl1/atl1_hw.h
+++ b/drivers/
Change the threshold number of descriptors used to trigger CMB writes.
The vendor reports that under certain conditions this will reduce the
number of unnecessary tx interrupts and improve rx performance.
This change is lifted directly from vendor version 1.2.40.2 of the L1
driver.
Signed-off-by:
Please accept the following patches for the atl1 driver. Thanks.
atl1: use kernel provided ethernet length constants
atl1: fix typo in dma_req_block
atl1: change cmb write threshold
atl1: fix typo in DMA engine setup
atl1: change tpd_avail function name
drivers/net/atl1/atl1_hw.h |9 ++---
Change tpd_avail() to atl1_tpd_avail().
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
index fd1e156..79d60e1 100644
--- a/drive
andrei radulescu-banu wrote:
During debugging, I noticed that dev_queue_xmit() is called twice for tx vlan
frames. This results in a frame being passed twice to a packet socket bound to
'any' interface. If the packet socket is bound to a specific interface, though,
it will get only one copy of
This patch modifies xfrm_audit_log() such that it
can accomodate auditing other ipsec events
besides add/delete of an SA or SPD entry.
This is a small change to accomodate updating
ipsec protocol to RFCs 4301, 4302 and 4303 which
require auditing some ipsec events if auditing
is available. Plea
On Thu, 19 Jul 2007, Simon Arlott wrote:
> On 19/07/07 17:19, Robert P. J. Day wrote:
> > On Thu, 19 Jul 2007, Randy Dunlap wrote:
> >> I think that Stefan means a patch to the kconfig source code,
> >> not the the Kconfig files. Good luck. I'd still like to see it.
> >
> > yes, i understand wha
On 19/07/07 17:19, Robert P. J. Day wrote:
> On Thu, 19 Jul 2007, Randy Dunlap wrote:
>> I think that Stefan means a patch to the kconfig source code,
>> not the the Kconfig files. Good luck. I'd still like to see it.
>
> yes, i understand what he wanted now. as a first step (that
> theoretical
During debugging, I noticed that dev_queue_xmit() is called twice for tx vlan
frames. This results in a frame being passed twice to a packet socket bound to
'any' interface. If the packet socket is bound to a specific interface, though,
it will get only one copy of the tx frame, which is good.
From: Gabriel C <[EMAIL PROTECTED]>
Date: Thu, 19 Jul 2007 14:29:53 +0200
> Hello ,
>
> I noticed on current git this warning in net/ipv4/inetpeer.c
>
> ...
>
> CC net/ipv4/inetpeer.o
> net/ipv4/inetpeer.c: In function 'unlink_from_pool':
> net/ipv4/inetpeer.c:297: warning: the address o
On Jul 18, 2007, at 1:35 AM, Andy Fleming wrote:
phy_read() returns a negative number if there's an error, but the
error-checking code in the Vitesse driver's config_intr function
triggers if phy_read() returns non-zero. Correct that.
Signed-off-by: Andy Fleming <[EMAIL PROTECTED]>
Jeff,
C
On Thu, 19 Jul 2007 15:16:33 -0400, John W. Linville wrote:
> On Sun, Jul 15, 2007 at 03:08:22PM +0100, Daniel Drake wrote:
> > zd1211rw and bcm43xx are interested in being notified when ERP IE conditions
> > change, so that they can reprogram a register which affects how control
> > frames
> > ar
Joakim Koskela wrote:
On Thursday 19 July 2007 17:46:42 Patrick McHardy wrote:
And these two? Also look like bugfixes ..
Well yes if we're using interfamily anywhere. D'you think they deserve a patch
for themselves?
Yes, that looks worth it. And it will help reduce the size of
On Sun, Jul 15, 2007 at 03:08:22PM +0100, Daniel Drake wrote:
> zd1211rw and bcm43xx are interested in being notified when ERP IE conditions
> change, so that they can reprogram a register which affects how control frames
> are transmitted.
>
> This patch adds an interface similar to the one that
On Sun, Jul 15, 2007 at 03:07:39PM +0100, Daniel Drake wrote:
> Similarly to CTS protection, whether short preambles are used for 802.11b
> transmissions should be a per-subif setting, not device global.
>
> For STAs, this patch makes short preamble handling automatic based on the ERP
> IE. For AP
On Thu, 19 Jul 2007 11:20:43 -0700 (PDT)
andrei radulescu-banu <[EMAIL PROTECTED]> wrote:
> > [Ben] If tcpdump and/or bridging needs to disable the hw-accel, then it can
> explicitly do so by some API. That is better than overloading
> the promisc flag in my opinion.
>
> I guess I could be pe
Hi,
On Thursday 19 July 2007, Michal Piotrowski wrote:
> Unclassified
>
> Subject : disk error loop (panic?) ide_do_rw_disk-bad
> References : http://lkml.org/lkml/2007/7/17/467
> Last known good : ?
> Submitter : Giacomo Catenazzi <[EMAIL PROTECTED]>
> Caused-By : ?
>
On Thursday 19 July 2007 17:46:42 Patrick McHardy wrote:
> > -
> > + if (xfrm[i]->props.mode != XFRM_MODE_TRANSPORT) {
> > + encap_family = xfrm[i]->props.family;
> > + if (encap_family == AF_INET) {
> > + remote.in = (struct i
Ragner Magalhaes wrote:
> ext Brian King wrote:
>> Ragner Magalhaes wrote:
>>> here also, as above ...
+ if (data && (dev->features & NETIF_F_IP_CSUM))
+ return 0;
+ if (!data && !(dev->features & NETIF_F_IP_CSUM))
+ return 0;
>> This change would make the li
On 16/07/07 14:01, Patrick McHardy wrote:
> Simon Arlott wrote:
>Changing an existing route:
># ip -6 r show 2002::/16
>2002::/16 dev sit0 metric 1024 expires 4482618sec mtu 1480 advmss 7140
>hoplimit 4294967295
># ip -6 r change 2002::/16 dev sit0 mtu 1280
>RTNETLINK answ
> [Ben] If tcpdump and/or bridging needs to disable the hw-accel, then it can
explicitly do so by some API. That is better than overloading
the promisc flag in my opinion.
I guess I could be persuaded in the end. But let me still play devil advocate.
The semantics of 'promiscuous', in my opin
ext Brian King wrote:
> Ragner Magalhaes wrote:
>> ext Brian King wrote:
>>
>>> +
>>> +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
>>> +{
>>> + struct ibmveth_adapter *adapter = dev->priv;
>>> +
>> Why do not to do
>>
>> if ((data && adapter->rx_csum) || (!data && !adapt
Hey Francois,
I've CC'd the netdev list as requested, however, I'm not signed up to
this list so please include my email address directly in any replies. Thanks
Francois Romieu wrote:
I'm in a particularly sticky situation in relation to the latest
kernels and multicast. And I need some help
Ragner Magalhaes wrote:
> ext Brian King wrote:
>
>> +
>> +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
>> +{
>> +struct ibmveth_adapter *adapter = dev->priv;
>> +
>
> Why do not to do
>
> if ((data && adapter->rx_csum) || (!data && !adapter->rx_csum))
>
>> [Andrei] VLAN_TX_SKB_CB() is perfect for that.
> [Patrick, Stephen] No its not. Its only legal to use while something has
> ownership
of the skb. Between VLAN devices and real devices qdiscs are
free to use it.
All right, using VLAN_TX_SKB_CB() is a bad idea. In that case, we need to amend
t
Denis Cheng wrote:
this memcpy looks so strange, in fact it's merely a pointer dereference,
so I change the parameter's type to refer it more directly,
this could make the memcpy not needed anymore.
in the function nbd_read_stat where nbd_find_request is only once called,
the parameter served sh
Hi Michal;
19 Tem 2007 Per tarihinde, Michal Piotrowski şunları yazmıştı:
> Block layer
>
> Subject : bsg.c:(.init.text+0x43d): undefined reference to
> `scsi_register_interface' References :
> http://lkml.org/lkml/2007/7/16/343
> Last known good : ?
> Submitter : Larry Finger
ext Brian King wrote:
> +
> +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
> +{
> + struct ibmveth_adapter *adapter = dev->priv;
> +
Why do not to do
if ((data && adapter->rx_csum) || (!data && !adapter->rx_csum))
return 0;
less two lines.
> +
On Wed, 2007-07-18 at 01:35, Andy Fleming wrote:
> phy_read() returns a negative number if there's an error, but the
> error-checking code in the Vitesse driver's config_intr function
> triggers if phy_read() returns non-zero. Correct that.
>
> Signed-off-by: Andy Fleming <[EMAIL PROTECTED]>
> --
On 7/19/07, rae l <[EMAIL PROTECTED]> wrote:
On 7/19/07, Paul Clements <[EMAIL PROTECTED]> wrote:
> Could you name "n" as "tmp" (as in the previous code) so that it's clear
> that's only a temporary variable. Other than that, this looks good.
Sure. I just use the name "n" as in the declaration of
andrei radulescu-banu wrote:
[Ben] I think a better method would be to allow disabling VLAN HW accel for a
NIC with ethtool.
This requires changes to ethtool and e1000 driver, +other drivers. It is a
handy thing to have. I don't view it as a solution to tcpdump - or to the vlan
bridging
On Thu, 2007-07-19 at 15:24 +0200, patric wrote:
>
> Just a hypothetical question. If the 2 network cards starts the
> autonegotiation would it be possible that they get into a loop where
> they are chasing each others state? Maybe a fix could be to add a sleep
> of a random length that would
Hi all,
Here is a list of some known regressions in 2.6.22-git
with patches available.
Feel free to add new regressions/remove fixed etc.
http://kernelnewbies.org/known_regressions
List of Aces
NameRegressions fixed since 21-Jun-2007
Adrian Bunk3
andrei radulescu-banu wrote:
> The consensus seems to be that skb's need to carry vlan accelerated tags in
> their cb's, on rx as well as tx. VLAN_TX_SKB_CB() is perfect for that.
No its not. Its only legal to use while something has ownership
of the skb. Between VLAN devices and real devices qd
On Thu, 19 Jul 2007 17:19:19 +0200
Olaf Kirch <[EMAIL PROTECTED]> wrote:
> On Thursday 12 July 2007 04:33, David Miller wrote:
> > I'll add merge your patch with a target of 2.6.23
> >
> > If you really want, after this patch has sat in 2.6.23 for a while
> > and got some good testing, we can con
On Thu, 19 Jul 2007, Randy Dunlap wrote:
> On Thu, 19 Jul 2007 05:25:30 -0400 (EDT) Robert P. J. Day wrote:
>
> > On Thu, 19 Jul 2007, Stefan Richter wrote:
> >
> > > Robert P. J. Day wrote:
> > > > On Thu, 19 Jul 2007, Adrian Bunk wrote:
> > > >
> > > > ...
> > > >> I would consider it more ugly
On Thu, 19 Jul 2007 08:47:01 -0700 (PDT)
andrei radulescu-banu <[EMAIL PROTECTED]> wrote:
> The consensus seems to be that skb's need to carry vlan accelerated tags in
> their cb's, on rx as well as tx. VLAN_TX_SKB_CB() is perfect for that.
>
> > [Patrick] On the TX path, it could simply use the
One additional thought: with the proposed changes in my prev message, the
driver can be set to hw vlan accelerated mode, even if no vlan interfaces are
configured. We would not have to switch hw vlan accelerated mode anymore, when
vlan interfaces are created or destroyed.
_
On Thu, 19 Jul 2007, Bill Fink wrote:
Hi John,
On Wed, 18 Jul 2007, [EMAIL PROTECTED] wrote:
On Wed, 18 Jul 2007, Francois Romieu wrote:
[EMAIL PROTECTED] <[EMAIL PROTECTED]> :
[...]
Anyone have any suggestions for solving this problem?
Try 2.6.23-rc1 when it is published or apply again
On 7/19/07, Paul Clements <[EMAIL PROTECTED]> wrote:
Could you name "n" as "tmp" (as in the previous code) so that it's clear
that's only a temporary variable. Other than that, this looks good.
Sure. I just use the name "n" as in the declaration of
list_for_each_entry_safe in the header file
I'
The consensus seems to be that skb's need to carry vlan accelerated tags in
their cb's, on rx as well as tx. VLAN_TX_SKB_CB() is perfect for that.
> [Patrick] On the TX path, it could simply use the CB, but this is actually
also wrong (for both macvlan and real devices) since qdiscs have
ownershi
> > Just to make it clear: Is this message an error, or a
> warning or just
> > for information?
> > Could you explain a bit please.
>
>
> Its a debugging message nowadays (NETDEBUG). I was mostly interested
> in this since I changed the IPsec MTU calculation in 2.6.22 and it
> might have been a
Add handlers for get_tso and get_ufo to prevent errors being printed
by ethtool.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/net/ibmveth.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_get_tso drivers
Add ethtool hooks to ibmveth to retrieve driver statistics.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/net/ibmveth.c | 53 +++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_driver_
This patchset enables TCP checksum offload support for IPV4
on ibmveth. This completely eliminates the generation and checking of
the checksum for packets that are completely virtual and never
touch a physical network. A simple TCP_STREAM netperf run on
a virtual network with maximum mtu set yield
This patch adds the appropriate ethtool hooks to allow for enabling/disabling
of hypervisor assisted checksum offload for TCP.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/net/ibmveth.c | 120 +++-
linux-2.6-bjking1/drivers/net/ibmveth
Stephen Hemminger <[EMAIL PROTECTED]> writes:
> Not at runtime, acceleration is always on if you compile kernel with vlan
> support. That is a design mistake as far as I can tell.
I think so.
>> However seeing unknown tags on master device (with tcpdump etc)
>> would certainly be useful.
>
> On
On Thu, 19 Jul 2007 05:25:30 -0400 (EDT) Robert P. J. Day wrote:
> On Thu, 19 Jul 2007, Stefan Richter wrote:
>
> > Robert P. J. Day wrote:
> > > On Thu, 19 Jul 2007, Adrian Bunk wrote:
> > >
> > > ...
> > >> I would consider it more ugly to special case this and that in the
> > >> kconfig code w
On 7/19/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote:
On Thu, Jul 19, 2007 at 02:38:31AM -0700, Andrew Morton ([EMAIL PROTECTED])
wrote:
> > > is very wrong if both ASYNC_TX_KMAP_DST and ASYNC_TX_KMAP_SRC can ever be
> > > set. We'll end up using the same kmap slot for both src add dest and w
On Thu, 19 Jul 2007 16:23:48 +0200
Krzysztof Halasa <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger <[EMAIL PROTECTED]> writes:
>
> > 1) non-accelerated device
> > * all frames show in promiscious mode
> > * tag is part of the frame that shows up
> >in tcpdump, and then gets strip
On Thursday 12 July 2007 04:33, David Miller wrote:
> I'll add merge your patch with a target of 2.6.23
>
> If you really want, after this patch has sat in 2.6.23 for a while
> and got some good testing, we can consider a submission for -stable.
Okay, those of you who followed the discussion on l
Denis Cheng wrote:
Thus the traverse of the loop may delete nodes, use the safe version.
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
---
drivers/block/nbd.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index c129510..
On Thu, 19 Jul 2007 16:23:48 +0200
Krzysztof Halasa <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger <[EMAIL PROTECTED]> writes:
>
> > 1) non-accelerated device
> > * all frames show in promiscious mode
> > * tag is part of the frame that shows up
> >in tcpdump, and then gets strip
Joakim Koskela wrote:
> static int xfrm4_beet_output(struct xfrm_state *x, struct sk_buff *skb)
> {
[... ipv4 handling, looks fine ...]
> +#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE)
> + int delta = sizeof(struct ipv6hdr) - sizeof(struct iphdr);
> + u8 proto
On Thu, Jul 19, 2007 at 05:02:04AM +, Steven J. Hill wrote:
> Fix long standing panic with regards to descriptors and locking.
>
> Signed-off-by: Steven J. Hill <[EMAIL PROTECTED]>
> ---
>
> diff -ur linux-2.6.22.1/drivers/net/mv643xx_eth.c
> linux-2.6.22.1-rci/drivers/net/mv643xx_eth.c
> --
On Thu, Jul 19, 2007 at 04:56:51AM +, Steven J. Hill wrote:
> Get rid of global PHY spinlock.
You have replaced the use of the global PHY spinlock with a per-port spinlock.
However, the SMI register is shared by all ports. The global lock is
needed to prevent simultaneous updates of the regis
Stephen Hemminger <[EMAIL PROTECTED]> writes:
> 1) non-accelerated device
> * all frames show in promiscious mode
> * tag is part of the frame that shows up
>in tcpdump, and then gets stripped by the 8021q module.
Sure. It's IMHO good and working, modulo the tag being removed
on
On Thu, Jul 19, 2007 at 04:55:36AM +, Steven J. Hill wrote:
> Fix the TX bytes statistics counter to, um, actually count.
>
> Signed-off-by: Steven J. Hill <[EMAIL PROTECTED]>
> ---
> --- linux-2.6.22.1/drivers/net/mv643xx_eth.c 2007-07-18 21:51:49.0
> -0500
> +++ linux-2.6.22.1-rci
On Thu, Jul 19, 2007 at 04:53:31AM +, Steven J. Hill wrote:
> Add main 642xx support to 'drivers/net/mv643xx_eth.c' file.
As Christoph said, this quantity of ifdefs really hurt the
maintainability. Refactoring is needed. Also, since in arch/powerpc
we want to have a single kernel support bot
On Thu, Jul 19, 2007 at 04:54:45AM +, Steven J. Hill wrote:
> Fix 'mv643xx_eth_tx_timeout_task' function prototype.
>
> Signed-off-by: Steven J. Hill <[EMAIL PROTECTED]>
> ---
>
> --- linux-2.6.22.1/drivers/net/mv643xx_eth.c 2007-07-18 21:45:13.0
> -0500
> +++ linux-2.6.22.1-rci/dri
Hi,
I already sent this two days ago, but I have the feeling it was
overlooked or filtered because of a large attachment.
If I try to boot 2.6.21.6, 2.6.22.1 or 2.6.22-git8 the system completely
hangs when init tries to bring up my r8169-based NIC. Not even the
keyboard lights are working anymor
Hi all,
Here's once again a corrected version of the patch adding support for
ipv4/ipv6 interfamily addressing for the ipsec BEET (Bound End-to-End
Tunnel) mode, as specified by the ietf draft found at:
http://www.ietf.org/internet-drafts/draft-nikander-esp-beet-mode-07.txt
The previous implemen
Stephen Hemminger wrote:
> On Thu, 19 Jul 2007 15:28:46 +0200
> Krzysztof Halasa <[EMAIL PROTECTED]> wrote:
>
>>>Your suggestion of disabling VLAN acceleration in promiscous
>>>mode sounds like a reasonable solution until then ..
>>
>>From a user perspective:
>>
>>I'm not sure promiscous mode is r
Robert P. J. Day wrote:
> i *did* submit a preliminary patch once upon a time, and it
> (predictably) went nowhere.
A patch which pulls the word "experimental" into prompts or adds a
dedicated directive for tagging of options? Can't find it in archives.
--
Stefan Richter
-=-=-=== -=== =--==
On Thu, 19 Jul 2007 15:28:46 +0200
Krzysztof Halasa <[EMAIL PROTECTED]> wrote:
> Patrick McHardy <[EMAIL PROTECTED]> writes:
>
> > Your suggestion of disabling VLAN acceleration in promiscous
> > mode sounds like a reasonable solution until then ..
>
> From a user perspective:
>
> I'm not sure
Jeff Garzik wrote:
> Brian King wrote:
>> This patchset enables TCP checksum offload support for IPV4
>> on ibmveth. This completely eliminates the generation and checking of
>> the checksum for packets that are completely virtual and never
>> touch a physical network. A simple TCP_STREAM netperf r
Neil Horman wrote:
On Thu, Jul 19, 2007 at 04:49:13PM +0530, pradeep singh wrote:
CCing: netdev
On 7/19/07, patric <[EMAIL PROTECTED]> wrote:
Hi,
To start with, i'm not sure if this should go to the dev or user list,
but i'll start here..
I'm currently running a nfsroot via a Broa
Patrick McHardy <[EMAIL PROTECTED]> writes:
> Your suggestion of disabling VLAN acceleration in promiscous
> mode sounds like a reasonable solution until then ..
>From a user perspective:
I'm not sure promiscous mode is related to the problem.
Tcpdump without promiscous mode makes perfect sense.
Sami Farin wrote:
On Thu, Jul 19, 2007 at 00:58:44 +0200, Patrick McHardy wrote:
Let me repeat again before we get in an endless discussion
again - I will NACK these patches until we have a solution
that works for all qdiscs.
I googled for
"Accurate packet scheduling for ATM" mchardy
a
Arkadiusz Miskiewicz wrote:
On Thursday 19 of July 2007, Patrick McHardy wrote:
OK I see what the problem is. The loopback device is statically
allocated, so it doesn't have any room for the subqueues reserved.
The easiest fix would be to use egress_subqueue[1] in struct
net_device, but I th
Patrick McHardy wrote:
> Gabriel C wrote:
>
>> Hello ,
>>
>> I noticed on current git this warning in net/ipv4/inetpeer.c
>>
>
> Yeah, I have no idea why the gcc people thought that this was
> something worth warning about. Especially since explicitly
> checking for != NULL silences the war
Gabriel C wrote:
Hello ,
I noticed on current git this warning in net/ipv4/inetpeer.c
Yeah, I have no idea why the gcc people thought that this was
something worth warning about. Especially since explicitly
checking for != NULL silences the warning again.
[IPV4]: Fix inetpeer gcc-4.2 warning
On Thu, Jul 19, 2007 at 00:58:44 +0200, Patrick McHardy wrote:
> Sami Farin wrote:
> > I had used tcatm patch with 2.6.16 kernel and I was
> > happy with it.
> > Now I patched Linux kernel 2.6.22 and iproute-2.6.22
> > for tcatm. Seems to work (TM). Only HTB tested.
>
>
> Let me repeat again be
Hello ,
I noticed on current git this warning in net/ipv4/inetpeer.c
...
CC net/ipv4/inetpeer.o
net/ipv4/inetpeer.c: In function 'unlink_from_pool':
net/ipv4/inetpeer.c:297: warning: the address of 'stack' will always
evaluate as 'true'
net/ipv4/inetpeer.c:297: warning: the address of 'st
On Thursday 19 of July 2007, Patrick McHardy wrote:
> Patrick McHardy wrote:
> > Arkadiusz Miskiewicz wrote:
> CONFIG_NETDEVICES_MULTIQUEUE=y
> >>>
> >>>Does it go away if you disable this option?
> >>
> >>Yes, it goes away after disabling this.
> >
> > I don't see a bug in the code itself, may
On Thu, Jul 19, 2007 at 04:49:13PM +0530, pradeep singh wrote:
> CCing: netdev
>
> On 7/19/07, patric <[EMAIL PROTECTED]> wrote:
> >Hi,
> >
> >
> >To start with, i'm not sure if this should go to the dev or user list,
> >but i'll start here..
> >
> >
> >I'm currently running a nfsroot via a Broadc
CCing: netdev
On 7/19/07, patric <[EMAIL PROTECTED]> wrote:
Hi,
To start with, i'm not sure if this should go to the dev or user list,
but i'll start here..
I'm currently running a nfsroot via a Broadcom NetXtreme 1000-SX card
(BCM5701) and i have a big problem with the tg3 drivers autonegot
1 - 100 of 139 matches
Mail list logo
