Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-07-11 Thread OBATA Noboru
From: "Ian McDonald" <[EMAIL PROTECTED]> Subject: [MaybeSpam] Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable Date: Tue, 26 Jun 2007 10:18:46 +1200 > On 6/26/07, OBATA Noboru <[EMAIL PROTECTED]> wrote: > > From: OBATA Noboru <[EMAIL PROTECTED]> > > > > Make TCP_RTO_MAX a variable, and allo

Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-07-11 Thread OBATA Noboru
From: Rick Jones <[EMAIL PROTECTED]> Subject: Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable Date: Mon, 25 Jun 2007 15:29:26 -0700 > Ian McDonald wrote: > > On 6/26/07, OBATA Noboru <[EMAIL PROTECTED]> wrote: > > > >> From: OBATA Noboru <[EMAIL PROTECTED]> > >> > >> Make TCP_RTO_MAX a va

Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-07-11 Thread OBATA Noboru
Hi, Stephen. Thank you for your comments. I will fix them and re-send the patch for 2.6.22. From: Stephen Hemminger <[EMAIL PROTECTED]> Subject: Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable Date: Mon, 25 Jun 2007 09:07:48 -0700 > > diff -uprN -X a/Documentation/dontdiff > > linux-2.

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Stefan Richter
Yinghai Lu wrote: > Stefan Richter wrote: >> Yinghai Lu wrote: >>> original default is -1, and this patch just try to use parent's node as >>> default. >> >> But in many cases, the patch does so at a time when the parent is not >> yet known. > then it will use -1. Yes. The patch does nothing for

Re: iproute2 2.6.22-070710 , mp_ematch.y:11: unrecognized: %error-verbose , ...

2007-07-11 Thread Stephen Hemminger
On Wed, 11 Jul 2007 20:38:43 -0700 (PDT) "Mr. James W. Laferriere" <[EMAIL PROTECTED]> wrote: > Hello Stephen (& All) , Maybe next build of the tarball one could tar > up the base directory name as well . ie: iproute2-2.6.22-070710/ . > The error below while being (quite probably) m

re: iproute2 2.6.22-070710 , mp_ematch.y:11: unrecognized: %error-verbose , ...

2007-07-11 Thread Mr. James W. Laferriere
Hello Stephen (& All) , Maybe next build of the tarball one could tar up the base directory name as well . ie: iproute2-2.6.22-070710/ . The error below while being (quite probably) manually correctable isn't something I'd expect to see in a release . Twyl , JimL ps: I am n

Re: [PATCH 2.6] SoftMAC : fix duplicate display of channel in scan

2007-07-11 Thread Dan Williams
On Tue, 2007-07-10 at 14:25 -0500, Larry Finger wrote: > Jean, > > Jean Tourrilhes wrote: > > Hi, > > > > SoftMAC output the channel twice in the scan output. It should > > display frequency and channel, but only once for each. > >

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Yinghai Lu
Stefan Richter wrote: Yinghai Lu wrote: original default is -1, and this patch just try to use parent's node as default. But in many cases, the patch does so at a time when the parent is not yet known. then it will use -1. YH - To unsubscribe from this list: send the line "unsubscribe netdev

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Stefan Richter
Yinghai Lu wrote: > original default is -1, and this patch just try to use parent's node as > default. But in many cases, the patch does so at a time when the parent is not yet known. -- Stefan Richter -=-=-=== -=== -==-- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "

Re: [5/5][TG3]: Update version to 3.78.

2007-07-11 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 16:32:37 -0700 > [TG3]: Update version to 3.78. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Also applied, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL P

Re: [4/5][TG3]: Add missing NVRAM strapping.

2007-07-11 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 16:32:25 -0700 > [TG3]: Add missing NVRAM strapping. > > This patch adds a missing NVRAM strapping for 5755 devices. > > Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. - T

Re: [3/5][TG3]: Enable auto MDI.

2007-07-11 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 16:32:15 -0700 > [TG3]: Enable auto MDI. > > This patch adds automatic MDI crossover support when autonegotiation is > turned off. Automatic MDI crossover allows link to be established > without the use of a crossover cable. > > Si

Re: [2/5][TG3]: Fix the polarity bit.

2007-07-11 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 16:32:07 -0700 > [TG3]: Fix the polarity bit. > > For most pre-5705 devices, multiple link interrupts were being generated > for a single physical link change. The source of the interrupts was > determined to be unnecessary toggling

Re: [1/5][TG3]: Fix irq_sync race condition.

2007-07-11 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 16:31:45 -0700 > [TG3]: Fix irq_sync race condition. > > Gagan Arneja <[EMAIL PROTECTED]> pointed out that tg3_reset_task() > could potentially race with another thread calling tg3_full_lock() > such as the ethtool_set_xxx() function

Re: [NET_SCHED]: ematch: module autoloading

2007-07-11 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 20:01:32 +0200 > [NET_SCHED]: ematch: module autoloading > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Applied, thanks Patrick. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message t

Re: [VLAN 02/04]: Fix MAC address handling

2007-07-11 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 19:54:18 +0200 > Patrick McHardy wrote: > > [VLAN]: Fix MAC address handling > > > > +static void vlan_sync_address(struct net_device *dev, > > + struct net_device *vlandev) > > +{ > > + struct vlan_dev_inf

Re: [PATCH] tcp: tcp probe wraparound handling and other changes

2007-07-11 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 10:51:15 -0700 > Switch from formatting messages in probe routine and copying with kfifo, > to using a small circular queue of information and formatting on read. > This avoids wraparound issues with kfifo, and saves one copy. >

Re: [RTNETLINK 04/04]: rtnl_link: allow specifying initial device address

2007-07-11 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 19:38:19 +0200 (MEST) > [RTNETLINK]: rtnl_link: allow specifying initial device address > > Drivers need to validate the initial addresses in their netlink attribute > validation function or manually reject them if they can't suppor

Re: [RTNETLINK 03/04]: rtnl_link API simplification

2007-07-11 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 19:38:17 +0200 (MEST) > [RTNETLINK]: rtnl_link API simplification > > All drivers need to unregister their devices in the module unload function. > While doing so they must hold the rtnl and atomically unregister the > rtnl_link ops

Re: [VLAN 02/04]: Fix MAC address handling

2007-07-11 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 19:38:16 +0200 (MEST) > [VLAN]: Fix MAC address handling > > The VLAN MAC address handling is broken in multiple ways. When the address > differs when setting it, the real device is put in promiscous mode twice, > but never taken ou

Re: [ETH 01/04]: Validate address in eth_mac_addr

2007-07-11 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 19:38:14 +0200 (MEST) > [ETH]: Validate address in eth_mac_addr > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: Bluetooth patches for 2.6.23

2007-07-11 Thread David Miller
From: Marcel Holtmann <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 10:09:23 +0200 > Please pull from > > > git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git Pulled, thanks Marcel. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a m

Re: Races in net_rx_action vs netpoll?

2007-07-11 Thread David Miller
From: Olaf Kirch <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 09:41:37 +0200 > On Wednesday 11 July 2007 07:44, David Miller wrote: > > > +#ifdef CONFIG_NETPOLL > > > + /* Prevent race with netpoll - yes, this is a kludge. > > > + * But at least it doesn't penalize the non-netpoll > > > + * code p

Re: O_CLOEXEC patches

2007-07-11 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Mon, 9 Jul 2007 14:54:41 -0700 > A couple of patches here which affect networking. Please review... No objections to the networking bits: Acked-by: David S. Miller <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netde

Re: [PATCH resend] rewrite AF_UNIX garbage collector, fixes race

2007-07-11 Thread David Miller
From: Miklos Szeredi <[EMAIL PROTECTED]> Date: Wed, 04 Jul 2007 11:49:41 +0200 > Throw out the old mark & sweep garbage collector and put in a > refcounting cycle detecting one. > > The old one had a race with recvmsg, that resulted in false positives > and hence data loss. The old algorithm ope

Re: sky2 hangs without any messages

2007-07-11 Thread Stephen Hemminger
On Wed, 11 Jul 2007 23:55:29 +0100 "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > > > > > > Please try again with post 2.6.22 git version (1.16)? > > > > Reproduced with 2.6.22 w/ sky2 1.16 from git. We observe this > > characteristic failure on the NFS server (always around 2-3GB of > > transmit

Re: [2.6.23 PATCH 14/18] dm: netlink add to core

2007-07-11 Thread Mike Anderson
Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 11 Jul 2007 22:01:59 +0100 > Alasdair G Kergon <[EMAIL PROTECTED]> wrote: > > > From: Mike Anderson <[EMAIL PROTECTED]> > > > > This patch adds support for the dm_path_event dm_send_event funtions which > > create and send netlink attribute event

Re: d80211 deadlock with wpa_supplicant and rmmod

2007-07-11 Thread John W. Linville
On Thu, Jul 12, 2007 at 12:17:35AM +0100, seventh guardian wrote: > Hello, > First of all I'm fairly new to this list (in all, this is my first > message), so please be gentle.. I promise I will try not to waste your > precious time. > > >I believe we have a deadlock in d80211. > > I have it too.

RE: [RFC 2/2] shrink size of scatterlist on common i386/x86-64

2007-07-11 Thread Williams, Mitch A
Muli Ben-Yehuda wrote: >> Net result: zilch. No performance increase, no noticeable CPU >> utilization >> benefits. Nothing. So I dropped it. > >Do you have pointers to the patches perchance? Muli, I've been looking for this code and it looks like it's gone. I was using a Power5 system that

Re: [2.6.23 PATCH 13/18] dm: netlink

2007-07-11 Thread Mike Anderson
Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 11 Jul 2007 22:01:37 +0100 > Alasdair G Kergon <[EMAIL PROTECTED]> wrote: > > > From: Mike Anderson <[EMAIL PROTECTED]> > > > > This patch adds a dm-netlink skeleton support to the Makefile, and the dm > > directory. > > > > ... > > > > +confi

[PATCH] spidernet: enable poll() before registering interrupts

2007-07-11 Thread Arnd Bergmann
We must not call netif_poll_enable after enabling interrupts, because an interrupt might come in and set the __LINK_STATE_RX_SCHED bit before we get to clear that bit again. If that happens, the next call to the ->poll() function will oops. Signed-off-by: Arnd Bergmann <[EMAIL PROTECTED]> --- This

Re: d80211 deadlock with wpa_supplicant and rmmod

2007-07-11 Thread seventh guardian
Hello, First of all I'm fairly new to this list (in all, this is my first message), so please be gentle.. I promise I will try not to waste your precious time. I believe we have a deadlock in d80211. I have it too. But I'm using iwl3945 driver, in-kernel mac80211, and a gentoo kernel (basicall

Re: sky2 hangs without any messages

2007-07-11 Thread Daniel J Blueman
On 11/07/07, Daniel J Blueman <[EMAIL PROTECTED]> wrote: On 11/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > On Wed, 11 Jul 2007 22:39:49 +0100 > "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > > > On 11/07/07, Daniel J Blueman <[EMAIL PROTECTED]> wrote: > > > > > On 05/07/07, Stephen Hem

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-07-11 Thread Patrick McHardy
Oliver Hartkopp wrote: > Hi Patrick, > > what's your opinion about my reply to your remark? > > Should we just change the module parameter from "loopback" to > "loopbacktest" to make the test intention obvious? > Or should we remove the loopback test functionality? I'll look into it tommorrow,

[5/5][TG3]: Update version to 3.78.

2007-07-11 Thread Michael Chan
[TG3]: Update version to 3.78. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 0d40f9d..3245f16 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -64,8 +64,8 @@ #define DRV_MODULE_NAME"tg3" #define PFX DRV_MODULE

[4/5][TG3]: Add missing NVRAM strapping.

2007-07-11 Thread Michael Chan
[TG3]: Add missing NVRAM strapping. This patch adds a missing NVRAM strapping for 5755 devices. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 4f59e5c..0d40f9d 100644 --- a/drivers/net/tg3.c

[3/5][TG3]: Enable auto MDI.

2007-07-11 Thread Michael Chan
[TG3]: Enable auto MDI. This patch adds automatic MDI crossover support when autonegotiation is turned off. Automatic MDI crossover allows link to be established without the use of a crossover cable. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]>

[2/5][TG3]: Fix the polarity bit.

2007-07-11 Thread Michael Chan
[TG3]: Fix the polarity bit. For most pre-5705 devices, multiple link interrupts were being generated for a single physical link change. The source of the interrupts was determined to be unnecessary toggling of the MAC link polarity bit. This patch changes the way the link polarity bit gets conf

[1/5][TG3]: Fix irq_sync race condition.

2007-07-11 Thread Michael Chan
[TG3]: Fix irq_sync race condition. Gagan Arneja <[EMAIL PROTECTED]> pointed out that tg3_reset_task() could potentially race with another thread calling tg3_full_lock() such as the ethtool_set_xxx() functions. This may trigger the BUG_ON() in tg3_irq_quiesce() or cause the irq_sync flag to be ou

Re: sky2 hangs without any messages

2007-07-11 Thread Daniel J Blueman
On 11/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Wed, 11 Jul 2007 22:39:49 +0100 "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > On 11/07/07, Daniel J Blueman <[EMAIL PROTECTED]> wrote: > > > > On 05/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > > > > Well, it didn't fix my

Re: [PATCH 0/5] more about numa_node with struct device

2007-07-11 Thread Yinghai Lu
On 7/11/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: On Tue, Jul 10, 2007 at 04:52:19PM -0700, Yinghai Lu wrote: > these are revised or new patch with numa_node in struct device in addition to Do you have a pointer to a background posting why you want all this? http://lkml.org/lkml/2007/6/

Re: sky2 hangs without any messages

2007-07-11 Thread Stephen Hemminger
On Wed, 11 Jul 2007 22:39:49 +0100 "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > On 11/07/07, Daniel J Blueman <[EMAIL PROTECTED]> wrote: > > > > On 05/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > > > > Well, it didn't fix my test, but it made it better. The following > > > > > seem

Re: sky2 hangs without any messages

2007-07-11 Thread Daniel J Blueman
On 11/07/07, Daniel J Blueman <[EMAIL PROTECTED]> wrote: > > On 05/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > > Well, it didn't fix my test, but it made it better. The following seemed > > > to work longer... > > > > > > --- a/drivers/net/sky2.c2007-07-05 09:09:45.0

Re: [2.6.23 PATCH 14/18] dm: netlink add to core

2007-07-11 Thread Andrew Morton
On Wed, 11 Jul 2007 22:01:59 +0100 Alasdair G Kergon <[EMAIL PROTECTED]> wrote: > From: Mike Anderson <[EMAIL PROTECTED]> > > This patch adds support for the dm_path_event dm_send_event funtions which > create and send netlink attribute events. > > ... > > --- linux.orig/drivers/md/dm-netlink.c

Re: [2.6.23 PATCH 13/18] dm: netlink

2007-07-11 Thread Andrew Morton
On Wed, 11 Jul 2007 22:01:37 +0100 Alasdair G Kergon <[EMAIL PROTECTED]> wrote: > From: Mike Anderson <[EMAIL PROTECTED]> > > This patch adds a dm-netlink skeleton support to the Makefile, and the dm > directory. > > ... > > +config DM_NETLINK > + bool "DM netlink events (EXPERIMENTAL)" >

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Yinghai Lu
Greg KH wrote: On Wed, Jul 11, 2007 at 12:54:58PM +0200, Stefan Richter wrote: Yinghai Lu wrote: --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -547,6 +547,8 @@ static void klist_children_put(struct klist_node *n) void device_initialize(struct device *dev) { + int node; +

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread James Morris
On Wed, 11 Jul 2007, David Miller wrote: > > One remaining corner case is NFS/IPv6 root, whereby userland won't have > > a chance to start before the network, and hence may miss the solicited > > RA. Or would it? By default, the next unsolicited RA can be anytime > > from now to after 10 minute

Re: [PATCH 1/5] try parent numa_node at first before using default

2007-07-11 Thread Greg KH
On Wed, Jul 11, 2007 at 12:54:58PM +0200, Stefan Richter wrote: > Yinghai Lu wrote: > > --- a/drivers/base/core.c > > +++ b/drivers/base/core.c > > @@ -547,6 +547,8 @@ static void klist_children_put(struct klist_node *n) > > > > void device_initialize(struct device *dev) > > { > > + int node;

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread David Miller
From: Rémi_Denis-Courmont <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 19:19:11 +0300 > Le mercredi 11 juillet 2007, David Stevens a écrit : > > That sounds like a good idea to me (FWIW), > > though I also still think a simple raw-socket > > application would do it just fine, possibly with >

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread David Miller
From: Christian Borntraeger <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 12:54:24 +0200 > Am Mittwoch, 11. Juli 2007 schrieb Pavel Emelianov: > > drivers/net/veth.c | 452 > > include/net/veth.h | 14 + > > I know, I am late in the game, but wont the name collide somewhat with > drivers/ne

Re: [Cbe-oss-dev] [PATCH] spidernet: don't use debug flag

2007-07-11 Thread Linas Vepstas
On Wed, Jul 11, 2007 at 04:57:38PM +0900, Ishizaki Kou wrote: [...] > I need more investigation. Please drop the patch. OK. --linas p.s. I tested ifdown/ifup, and didn't see any problems. Does your bug happen immediately, or does it take many attempts to trigger it? - To unsubscribe from this

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-07-11 Thread Oliver Hartkopp
Hi Patrick, what's your opinion about my reply to your remark? Should we just change the module parameter from "loopback" to "loopbacktest" to make the test intention obvious? Or should we remove the loopback test functionality? Regards, Oliver Oliver Hartkopp wrote: > Patrick McHardy wrote: >

Re: Fwd: r8169 driver supporting the 8167 dev ID

2007-07-11 Thread Francois Romieu
Jonathan Larsen <[EMAIL PROTECTED]> : > I got git installed on my dev box. i went to my linux source dir and ran, > git init > git add . > git format-patch v2.6.18..v2.6.23-rc1 -- drivers/net/r8169.c > > and i got an error > fatal: bad revision 'v2.6.18..v2.6.23-rc1' > > what did i do wrong? im

Re: Linux 2.6.22: Leak r=1 1

2007-07-11 Thread Chuck Ebbert
On 07/11/2007 01:40 PM, Sami Farin wrote: > That's right, so descriptive is the new Linux kernel 2.6.22. > Took a while to grep what is "leaking". > You didn't post that: $ find . -type f | xargs grep "Leak r=" /dev/null ./net/ipv4/tcp_input.c: printk(KERN_DEBUG "Leak r=%u %d\n",

Linux 2.6.22: Leak r=1 1

2007-07-11 Thread Sami Farin
That's right, so descriptive is the new Linux kernel 2.6.22. Took a while to grep what is "leaking". Linux safari.finland.fbi 2.6.22-cfs-v19 #3 SMP Tue Jul 10 00:22:25 EEST 2007 i686 i686 i386 GNU/Linux Just normal Internet usage, azureus for example =) I think this is easy to trigger. But that

Re: [PATCH] IPROUTE2: Fix bug in display of ipv6 cloned/cached routes

2007-07-11 Thread Patrick McHardy
Sridhar Samudrala wrote: > This patch fixes a bug in the 'ip' command to display > IPv6 cloned routes. > ip -6 route ls cache > returns empty even when there are cloned routes because of > of a missing else in print_route() routine. Looks good. The ip6_multiple_tables case seems to be missing

[PATCH] IPROUTE2: Fix bug in display of ipv6 cloned/cached routes

2007-07-11 Thread Sridhar Samudrala
This patch fixes a bug in the 'ip' command to display IPv6 cloned routes. ip -6 route ls cache returns empty even when there are cloned routes because of of a missing else in print_route() routine. Thanks Sridhar Signed-off-by: Sridhar Samudrala <[EMAIL PROTECTED]> diff --git a/ip/iproute

Re: [VLAN 02/04]: Fix MAC address handling

2007-07-11 Thread Patrick McHardy
Ben Greear wrote: >> Patrick McHardy wrote: >> >>> [VLAN]: Fix MAC address handling > The new patch looks good to me..though this is some tricky code > so I might have missed something... Thanks Ben. I'm pretty sure the new one is fine. Definitely not worse than before :) - To unsubscribe fro

Re: [Bugme-new] [Bug 8736] New: New TC deadlock scenario

2007-07-11 Thread Patrick McHardy
Andrew Morton wrote: >>http://bugzilla.kernel.org/show_bug.cgi?id=8736 >> >>Here is another scenario I bumped onto - qdisc_watchdog_cancel() and >>qdisc_restart() deadlock. >> >>CPU#0 >>qdisc_watchdog() fires and gets dev->queue_lock >>qdisc_run()...qdisc_restart()... >>-> releases dev->queue_lock

Re: [PATCH][RFC] network splice receive v3

2007-07-11 Thread Jens Axboe
On Wed, Jul 11 2007, Joel Becker wrote: > On Wed, Jul 11, 2007 at 11:19:27AM +0200, Jens Axboe wrote: > > Subject: [PATCH] splice: don't assume regular pages in splice_to_pipe() > > > > Allow caller to pass in a release function, there might be > > other resources that need releasing as well. Need

Re: [Bugme-new] [Bug 8736] New: New TC deadlock scenario

2007-07-11 Thread Andrew Morton
On Wed, 11 Jul 2007 08:45:12 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8736 > >Summary: New TC deadlock scenario >Product: Networking >Version: 2.5 > KernelVersion: 2.6.22 > Platform: All > OS/Versi

Re: [PATCH][RFC] network splice receive v3

2007-07-11 Thread Joel Becker
On Wed, Jul 11, 2007 at 11:19:27AM +0200, Jens Axboe wrote: > Subject: [PATCH] splice: don't assume regular pages in splice_to_pipe() > > Allow caller to pass in a release function, there might be > other resources that need releasing as well. Needed for > network receive. > > diff --git a/fs/spl

Re: [VLAN 02/04]: Fix MAC address handling

2007-07-11 Thread Ben Greear
Patrick McHardy wrote: Patrick McHardy wrote: [VLAN]: Fix MAC address handling +static void vlan_sync_address(struct net_device *dev, + struct net_device *vlandev) +{ + struct vlan_dev_info *vlan = VLAN_DEV_INFO(vlandev); + + if (!compare_ether_addr(vlan-

[PATCH 2.6.23] iw_cxgb3: remove the cm_id reference on listen failures.

2007-07-11 Thread Steve Wise
iw_cxgb3: remove the cm_id reference on listen failures. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_cm.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.

[NET_SCHED]: ematch: module autoloading

2007-07-11 Thread Patrick McHardy
[NET_SCHED]: ematch: module autoloading Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit daa5d0f76104559af6718688e0e37ff9fda9ea6a tree 78efa14a3dda378a4b9dbc88ff5e1108671a4028 parent 5ff8523dfdac610944d1f85f54e30cd96dc6104b author Patrick McHardy <[EMAIL PROTECTED]> Wed, 11 Jul 2007

Re: [VLAN 02/04]: Fix MAC address handling

2007-07-11 Thread Patrick McHardy
Patrick McHardy wrote: > [VLAN]: Fix MAC address handling > > +static void vlan_sync_address(struct net_device *dev, > + struct net_device *vlandev) > +{ > + struct vlan_dev_info *vlan = VLAN_DEV_INFO(vlandev); > + > + if (!compare_ether_addr(vlan->real_dev_addr,

[PATCH] tcp: tcp probe wraparound handling and other changes

2007-07-11 Thread Stephen Hemminger
Switch from formatting messages in probe routine and copying with kfifo, to using a small circular queue of information and formatting on read. This avoids wraparound issues with kfifo, and saves one copy. Also make sure to state correct license, rather than copying off some other driver I start

[VLAN 02/04]: Fix MAC address handling

2007-07-11 Thread Patrick McHardy
[VLAN]: Fix MAC address handling The VLAN MAC address handling is broken in multiple ways. When the address differs when setting it, the real device is put in promiscous mode twice, but never taken out again. Additionally it doesn't resync when the real device's address is changed and needlessly p

[RTNETLINK 03/04]: rtnl_link API simplification

2007-07-11 Thread Patrick McHardy
[RTNETLINK]: rtnl_link API simplification All drivers need to unregister their devices in the module unload function. While doing so they must hold the rtnl and atomically unregister the rtnl_link ops as well. This makes the rtnl_link_unregister function that takes the rtnl itself completely usele

[RTNETLINK 04/04]: rtnl_link: allow specifying initial device address

2007-07-11 Thread Patrick McHardy
[RTNETLINK]: rtnl_link: allow specifying initial device address Drivers need to validate the initial addresses in their netlink attribute validation function or manually reject them if they can't support this. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 2b73b83f72018cea40557afa

[RTNETLINK 00/04]: rtnl_link improvements

2007-07-11 Thread Patrick McHardy
These patches simplify the rtnl_link API and add support for specifying the initial device address. The rtnl_link patches depend on the VLAN fix because I didn't want to build on top of the broken address handling. Please apply, thanks. drivers/net/dummy.c | 61 --

[ETH 01/04]: Validate address in eth_mac_addr

2007-07-11 Thread Patrick McHardy
[ETH]: Validate address in eth_mac_addr Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 690fb4dbafa9f60f8cb520d5def544580107b3a4 tree ded62c0fcd8497b5cf9459213e1579cc700abb39 parent 99d24edeb6abc6ca3a0d0fbdb83c664c04403c8c author Patrick McHardy <[EMAIL PROTECTED]> Wed, 11 Jul 2007

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Patrick McHardy
Pavel Emelianov wrote: > OK. I'll try to make the generic call. Could you please send me the > patches with IFLA_ADDRESS support for booth kernel and ip utility. I'll send the kernel patches seperately in a few minutes. iproute doesn't need any further patches. - To unsubscribe from this list: se

Re: ata and netdev (was Re: -mm merge plans for 2.6.23)

2007-07-11 Thread Dan Faerch
Andrew Morton wrote: drivers-net-ns83820c-add-paramter-to-disable-auto.patch: See comments in changelog: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc6/2.6.22-rc6-mm1/broken-out/drivers-net-ns83820c-add-paramter-to-disable-auto.patch Dan, Ben: is there any prospect of

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread Vlad Yasevich
Rémi Denis-Courmont wrote: > Le mercredi 11 juillet 2007, David Stevens a écrit : >> That sounds like a good idea to me (FWIW), >> though I also still think a simple raw-socket >> application would do it just fine, possibly with >> no kernel modification at all. >> But since the ker

Re: [git patches] net driver updates

2007-07-11 Thread Chris Stromsoe
On Wed, 11 Jul 2007, Jiri Kosina wrote: On Tue, 10 Jul 2007, Jeff Garzik wrote: Various minor updates. The only thing of note is sk98lin driver removal. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus This is pro

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread Rémi Denis-Courmont
Le mercredi 11 juillet 2007, David Stevens a écrit : > That sounds like a good idea to me (FWIW), > though I also still think a simple raw-socket > application would do it just fine, possibly with > no kernel modification at all. > But since the kernel wouldn't be maintaining > the

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread David Stevens
> Since you asked for another idea, how about using netlink to send _validated_ RA > information to interested parties? > > -vlad That sounds like a good idea to me (FWIW), though I also still think a simple raw-socket application would do it just fine, possibly with no kernel modificati

Re: sky2 hangs without any messages

2007-07-11 Thread Daniel J Blueman
On 11/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Wed, 11 Jul 2007 11:15:20 +0100 "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > On 05/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > Well, it didn't fix my test, but it made it better. The following seemed > > to work longer.

Re: ethtool locking

2007-07-11 Thread Stephen Hemminger
On Wed, 11 Jul 2007 11:58:08 +0100 Ben Dooks <[EMAIL PROTECTED]> wrote: > I am currently upgrading the DM9000 network driver to support > ethtool for items such as controlling the MII interface and > have the following question about locking with the ethtool > interface: > > Most devices use an o

Re: sky2 hangs without any messages

2007-07-11 Thread Stephen Hemminger
On Wed, 11 Jul 2007 11:15:20 +0100 "Daniel J Blueman" <[EMAIL PROTECTED]> wrote: > On 05/07/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > Well, it didn't fix my test, but it made it better. The following seemed > > to work longer... > > > > --- a/drivers/net/sky2.c2007-07-05 09:09:

[RFC 2/3] lro: Kconfig and Makefile

2007-07-11 Thread Jan-Bernd Themann
Kconfig and Makefile changes for LRO Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- net/ipv4/Kconfig |9 + net/ipv4/Makefile |1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig index 010fbb2..25279f4 100644 --- a/net

[RFC 1/3] lro: Generic LRO for TCP traffic

2007-07-11 Thread Jan-Bernd Themann
Large Receive Offload (tcp) Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- include/linux/inet_lro.h | 107 net/ipv4/inet_lro.c | 311 ++ 2 files changed, 418 insertions(+), 0 deletions(-) create mode 100644 include/lin

[RFC 3/3] lro: LRO support for eHEA

2007-07-11 Thread Jan-Bernd Themann
LRO support for eHEA Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |9 +++- drivers/net/ehea/ehea_main.c | 102 +++--- 2 files changed, 104 insertions(+), 7 deletions(-) diff --git a/drivers/net/ehea/ehea.h b/driver

[RFC 0/3] lro: Generic Large Receive Offload for TCP traffic

2007-07-11 Thread Jan-Bernd Themann
Generic Large Receive Offload proposal After some discussions on the mailing list concerning our LRO approach, we agreed to provide a generic LRO patch. The algorithm is based on the version we developed for eHEA. The performance improvements we observed were significant. The LRO functionality is

[PATCH 1/1] eHEA: Introducing support vor DLPAR memory add

2007-07-11 Thread Thomas Klein
This patch adds support for DLPAR memory add to the eHEA driver. To detect whether memory was added the driver uses its own memory mapping table and checks for kernel addresses whether they're located in already known memory sections. If not the function ehea_rereg_mrs() is triggered which performs

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread Vlad Yasevich
Rémi Denis-Courmont wrote: > On Wednesday 11 July 2007 15:29:16 YOSHIFUJI Hideaki / 吉藤英明 wrote: >> In article <[EMAIL PROTECTED]> (at Tue, 10 Jul 2007 > 21:11:17 +0300), Remi Denis-Courmont <[EMAIL PROTECTED]> says: >>> ICMPv6 Router Advertisements may now contain informations that is >>> mostly o

Re: [Bugme-new] [Bug 8724] New: Unaligned acess in udp_recvmsg() on EV56

2007-07-11 Thread Ivan Kokshaysky
On Sun, Jul 08, 2007 at 03:29:35PM -0700, Andrew Morton wrote: > > This problem does NOT seem to affect my Tsunami/Shark (EV68AL) box running > > the > > same kernel version on the same LAN. Not sure if it's CPU generation > > related > > (EV5 vs EV6), or if it's the NIC (via_rhine on the EV5 vs

[NET]: gen_estimator deadlock fix

2007-07-11 Thread Ranko Zivojnovic
Fixes ABBA deadlock noted by Patrick McHardy <[EMAIL PROTECTED]>: > There is at least one ABBA deadlock, est_timer() does: > read_lock(&est_lock) > spin_lock(e->stats_lock) (which is dev->queue_lock) > > and qdisc_destroy calls htb_destroy under dev->queue_lock, which > calls htb_destroy_class, th

Re: No network on Asus P5B (r8169)

2007-07-11 Thread Clemens Brunner
Francois Romieu wrote: > Does your setup exclude the "wake up" issue described in > http://gentoo-wiki.com/HARDWARE_RTL8168 ? You're right, that was the problem! With the "wake up on LAN" option enabled in Windows, networking is working perfectly in Linux (32 bit and 64 bit). Which leaves only o

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Pavel Emelianov
Patrick McHardy wrote: > Pavel Emelianov wrote: >> Patrick McHardy wrote: >> >>> Mhh doing it later means dealing with compatibility issues, which >>> is why I'm asking now. We currently support IFLA_NAME, IFLA_MTU, >> >> Oh, I see. >> >> >>> IFLA_TXQLEN, IFLA_WEIGTH, IFLA_OPERSTATE and IFLA_LINKMO

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread David Stevens
I think #2 in your list is the right choice, and that has nothing to do with adding a non-standard option (which I completely agree is a bad idea). It looked like you're just checking if the machine is acting as a router or not and if it comes from a link-local address; is that right? Of course,

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Patrick McHardy
Pavel Emelianov wrote: > Patrick McHardy wrote: > >>Mhh doing it later means dealing with compatibility issues, which >>is why I'm asking now. We currently support IFLA_NAME, IFLA_MTU, > > > Oh, I see. > > >>IFLA_TXQLEN, IFLA_WEIGTH, IFLA_OPERSTATE and IFLA_LINKMODE, and >>with my patch additi

Re: Fwd: r8169 driver supporting the 8167 dev ID

2007-07-11 Thread Jonathan Larsen
I got git installed on my dev box. i went to my linux source dir and ran, git init git add . git format-patch v2.6.18..v2.6.23-rc1 -- drivers/net/r8169.c and i got an error fatal: bad revision 'v2.6.18..v2.6.23-rc1' what did i do wrong? im sure im missing something easy. On 7/10/07, Jonathan

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Pavel Emelianov
Patrick McHardy wrote: > Pavel Emelianov wrote: >> Patrick McHardy wrote: >> >>> Pavel Emelianov wrote: >>> +static const struct nla_policy veth_policy[VETH_INFO_MAX + 1] = { + [VETH_INFO_MAC] = { .type = NLA_BINARY, .len = ETH_ALEN }, + [VETH_INFO_PEER]= { .type =

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Patrick McHardy
Pavel Emelianov wrote: > Patrick McHardy wrote: > >>Pavel Emelianov wrote: >> >>>+static const struct nla_policy veth_policy[VETH_INFO_MAX + 1] = { >>>+[VETH_INFO_MAC] = { .type = NLA_BINARY, .len = ETH_ALEN }, >>>+[VETH_INFO_PEER]= { .type = NLA_STRING }, >>>+[VETH_INF

[IPROUTE]: Fix meta ematch usage of 0 values

2007-07-11 Thread Patrick McHardy
[IPROUTE]: Fix meta ematch usage of 0 values em_meta doesn't send 0 values to the kernel. breaking matching on them and resulting in "Missing value TLV" messages on dump. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> diff --git a/tc/em_meta.c b/tc/em_meta.c index 5fc0c59..b727422 100644 ---

Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Pavel Emelianov
Patrick McHardy wrote: > Pavel Emelianov wrote: >> +static const struct nla_policy veth_policy[VETH_INFO_MAX + 1] = { >> +[VETH_INFO_MAC] = { .type = NLA_BINARY, .len = ETH_ALEN }, >> +[VETH_INFO_PEER]= { .type = NLA_STRING }, >> +[VETH_INFO_PEER_MAC]= { .type = NLA_

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread Rémi Denis-Courmont
On Wednesday 11 July 2007 15:29:16 YOSHIFUJI Hideaki / 吉藤英明 wrote: > In article <[EMAIL PROTECTED]> (at Tue, 10 Jul 2007 21:11:17 +0300), Remi Denis-Courmont <[EMAIL PROTECTED]> says: > > ICMPv6 Router Advertisements may now contain informations that is > > mostly of interest to userland. This cur

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 10 Jul 2007 21:11:17 +0300), Remi Denis-Courmont <[EMAIL PROTECTED]> says: > ICMPv6 Router Advertisements may now contain informations that is > mostly of interest to userland. This currently mostly consists of > recursive DNS server addresses (though one s

  1   2   >