* Deepak Saxena <[EMAIL PROTECTED]> wrote:
> This was found around the 2.6.10 timeframe when testing with the -rt
> patch and I believe is still is an issue. irttp_dup() does a memcpy()
> of the tsap_cb structure causing the spinlock protecting various
> fields in the structure to be duped. T
On Tue, 20 Mar 2007 21:23:52 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote:
> Well it causes additional problems. We had some cases where it was really
> hard to distingush garbage and the true call chain.
yes, for some reason the naive backtraces seem to have got messier and messier
over
the years
Thomas Graf wrote:
> Changes netlink_rcv_skb() to skip netlink controll messages and don't
> pass them on to the message handler.
>
> Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
>
> Index: net-2.6.22/net/netlink/af_netlink.c
> ===
Linus Torvalds wrote:
On Tue, 20 Mar 2007, Zachary Amsden wrote:
Actually, I was thinking the irq handlers would just not mess around with
eflags on the stack, just call the chip to ack the interrupt and re-enable
hardware interrupts when they left, since that is free anyway with the iret.
On Tue, 20 Mar 2007, Zachary Amsden wrote:
>
> Actually, I was thinking the irq handlers would just not mess around with
> eflags on the stack, just call the chip to ack the interrupt and re-enable
> hardware interrupts when they left, since that is free anyway with the iret.
No can do. Think l
Linus Torvalds wrote:
On Tue, 20 Mar 2007, Zachary Amsden wrote:
void local_irq_restore(int enabled)
{
pda.intr_mask = enabled;
/*
* note there is a window here where softirqs are not processed by
* the interrupt handler, but that is not a problem, since it will
* get done h
In article <[EMAIL PROTECTED]> (at Wed, 21 Mar 2007 01:06:03 +0100), Thomas
Graf <[EMAIL PROTECTED]> says:
> -static int
> -inet6_rtm_deladdr(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg)
> +static int nl_addr_del(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg)
> {
> struct i
This patch adds a new interface to register rtnetlink message
handlers replacing the exported rtnl_links[] array which
required many message handlers to be exported unnecessarly.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/include/net/rtnetlink.h
=
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/net/bridge/br.c
===
--- net-2.6.22.orig/net/bridge/br.c 2007-03-20 23:53:20.0 +0100
+++ net-2.6.22/net/bridge/br.c 2007-03-21 00:52:42.0 +0100
@@ -4
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/net/core/fib_rules.c
===
--- net-2.6.22.orig/net/core/fib_rules.c2007-03-20 23:53:21.0
+0100
+++ net-2.6.22/net/core/fib_rules.c 2007-03-21 00:52:30
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/include/net/neighbour.h
===
--- net-2.6.22.orig/include/net/neighbour.h 2007-03-20 23:53:20.0
+0100
+++ net-2.6.22/include/net/neighbour.h 2007-03-21 00:52
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/include/net/ip6_fib.h
===
--- net-2.6.22.orig/include/net/ip6_fib.h 2007-03-20 23:53:20.0
+0100
+++ net-2.6.22/include/net/ip6_fib.h2007-03-21 00:52:4
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/net/sched/cls_api.c
===
--- net-2.6.22.orig/net/sched/cls_api.c 2007-03-20 23:53:20.0 +0100
+++ net-2.6.22/net/sched/cls_api.c 2007-03-21 00:52:36.0
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/net/sched/act_api.c
===
--- net-2.6.22.orig/net/sched/act_api.c 2007-03-20 23:53:20.0 +0100
+++ net-2.6.22/net/sched/act_api.c 2007-03-21 00:52:37.0
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/include/net/dn_fib.h
===
--- net-2.6.22.orig/include/net/dn_fib.h2007-03-20 23:53:20.0
+0100
+++ net-2.6.22/include/net/dn_fib.h 2007-03-21 00:52:38
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/net/core/rtnetlink.c
===
--- net-2.6.22.orig/net/core/rtnetlink.c2007-03-21 00:52:26.0
+0100
+++ net-2.6.22/net/core/rtnetlink.c 2007-03-21 00:52:28
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/net/core/rtnetlink.c
===
--- net-2.6.22.orig/net/core/rtnetlink.c2007-03-21 00:52:30.0
+0100
+++ net-2.6.22/net/core/rtnetlink.c 2007-03-21 00:52:43
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/include/net/ip_fib.h
===
--- net-2.6.22.orig/include/net/ip_fib.h2007-03-20 23:53:20.0
+0100
+++ net-2.6.22/include/net/ip_fib.h 2007-03-21 00:52:33
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/include/net/sch_generic.h
===
--- net-2.6.22.orig/include/net/sch_generic.h 2007-03-20 23:53:20.0
+0100
+++ net-2.6.22/include/net/sch_generic.h2007-0
Introduces an interface to register rtnetlink message handlers
and converts all users of rtnl_links[].
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 20 Mar 2007, Zachary Amsden wrote:
>
> void local_irq_restore(int enabled)
> {
>pda.intr_mask = enabled;
>/*
> * note there is a window here where softirqs are not processed by
> * the interrupt handler, but that is not a problem, since it will
> * get done here in th
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/net/ipv4/tcp_westwood.c
===
--- net-2.6.22.orig/net/ipv4/tcp_westwood.c 2007-03-20 23:53:19.0
+0100
+++ net-2.6.22/net/ipv4/tcp_westwood.c 2007-03-21 01:10
Leftover from dynamic multicast groups allocation work.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6/net/netlink/af_netlink.c
===
--- net-2.6.orig/net/netlink/af_netlink.c 2007-01-23 14:09:34.0
+0100
+
netlink_rcv_skb() is changed to skip messages which don't have the
NLM_F_REQUEST bit to avoid every netlink family having to perform this
check on their own.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/net/netlink/af_netlink.c
=
Changes netlink_rcv_skb() to skip netlink controll messages and don't
pass them on to the message handler.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/net/netlink/af_netlink.c
===
--- net-2.6.22.orig/net/netlink/
Matt Mackall wrote:
> On Tue, Mar 20, 2007 at 09:31:58AM -0700, Jeremy Fitzhardinge wrote:
>
>> Linus Torvalds wrote:
>>
>>> On Tue, 20 Mar 2007, Eric W. Biederman wrote:
>>>
>>>
If that is the case. In the normal kernel what would
the "the oops, we got an interrupt cod
Converts westwood and vegas netlink code to use the typesafe
interface, removes an unused varaible, and move some netlink
queue management code into the generic layer.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo i
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/net/ipv4/tcp_vegas.c
===
--- net-2.6.22.orig/net/ipv4/tcp_vegas.c2007-03-20 23:53:19.0
+0100
+++ net-2.6.22/net/ipv4/tcp_vegas.c 2007-03-21 01:10:15
Jeremy Fitzhardinge wrote:
Zachary Amsden wrote:
I think Jeremy's idea was to have interrupt handlers leave interrupts
disabled on exit if pda.intr_mask was set. In which case, they would
bypass all work and we could never get preempted.
Yes, I was worried that if we left the isr with
Implements a unified, protocol independant rules dumping function
which is capable of both, dumping a specific protocol family or
all of them. This speeds up dumping as less lookups are required.
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6.22/net/core/fib_rules.c
===
Linus Torvalds writes:
> We should just do this natively. There's been several tests over the years
> saying that it's much more efficient to do sti/cli as a simple store, and
> handling the "oops, we got an interrupt while interrupts were disabled" as
> a special case.
>
> I have this dim mem
On Tue, Mar 20, 2007 at 03:08:19PM -0800, Zachary Amsden wrote:
> Matt Mackall wrote:
> >I don't know that you need an xchg there. If you're still on the same
> >CPU, it should all be nice and causal even across an interrupt handler.
> >So it could be:
> >
> > pda.intr_mask = 0; /* intr_pending c
On Tue, 20 Mar 2007, Andi Kleen wrote:
>
> Linus is worried about the unwinder crashing -- that wouldn't help with that.
And to make it clear: this is not a theoretical worry. It happened many
times over the months the unwinder was in.
It was supposed to help debugging, but it made bugs that
A while back I reported that I sometimes saw double and triple
SAs being created. The patch to check for protocol when deleting
larval SA removed one obstacle in that I no longer see triple SAs.
Now, once in a while double SAs. I think I have figured out the
second obstacle.
The initiator instal
On Tue, 20 Mar 2007, Andi Kleen wrote:
> On Tue, Mar 20, 2007 at 11:49:39AM -0700, Linus Torvalds wrote:
> >
> > the thing is, I'd rather see a long backtrace that is hard to decipher but
> > that *never* *ever* causes any additional problems, over a pretty one.
>
> Well it causes additional
From: Dale Farnsworth <[EMAIL PROTECTED]>
mv643xx_eth_shutdown is needed for kexec.
Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]>
---
drivers/net/mv643xx_eth.c | 14 ++
1 file changed, 14 insertions(+)
Index: linux-2.6-powerpc-df/drivers/net/mv643xx_eth.c
===
From: "Michael S. Tsirkin" <[EMAIL PROTECTED]>
Date: Tue, 20 Mar 2007 18:02:17 +0200
> David, Alexey, what do you think about this patch? Is it right?
> Could this patch be considered for 2.6.21?
>
> Acked-by: Michael S. Tsirkin <[EMAIL PROTECTED]>
I plan to apply it and merge.
-
To unsubscribe
Zachary Amsden wrote:
> I think Jeremy's idea was to have interrupt handlers leave interrupts
> disabled on exit if pda.intr_mask was set. In which case, they would
> bypass all work and we could never get preempted.
Yes, I was worried that if we left the isr without actually handling the
interru
In article <[EMAIL PROTECTED]> (at Tue, 20 Mar 2007 15:16:40 -0700), Sridhar
Samudrala <[EMAIL PROTECTED]> says:
> On Tue, 2007-03-20 at 10:19 +0100, YOSHIFUJI Hideaki / 吉藤英明 wrote:
> > Hello.
> >
> > Recent 2.6.21-git kernels do not respond to ping6 queries
> > to our own (local) link-local add
For the common "(struct nlmsghdr *)skb->data" sequence, so that we reduce the
number of direct accesses to skb->data and for consistency with all the other
cast skb member helpers.
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
drivers/connector/connector.c |2 +-
drive
For the common "(struct nlmsghdr *)skb->data" sequence, so that we reduce the
number of direct accesses to skb->data and for consistency with all the other
cast skb member helpers.
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
drivers/connector/connector.c |2 +-
drive
The patch follows the following recommendation made in an erratum to RFC 4342:
"Senders MAY additionally make use of other available RTT measurements,
including those from the initial Request-Response packet exchange."
It implements larger initial windows with regard to this inital RTT measu
Function:
-
This patch acquires the RTT of the initial SYN (Request/Response) exchange
and stores it in an unused field of dccp_sock.
Purpose:
The purpose is primarily to provide an initial RTT sample for CCIDs. CCID 3
in particular benefits from such a sample; using the RTT o
This clears the following sparc64 build warnings:
1) warning: format "%ld" expects type "long int", but argument 3 has type
"suseconds_t"
2) warning: format "%llu" expects type "long long unsigned int", but argument
3 has type "__u64"
Fixed by using typecast to unsigned. This is argued to be sa
The CCID 3 and TFRC specs (RFC 4342, RFC 3448, draft-3448bis) make frequent
reference to the computation of the RFC-3390 initial sending rate:
1. Initial sending rate when RTT is known (RFC 4342, p. 6)
2. Response to Idle/Application-Limited periods (RFC 4342, 5.1)
This warrants putting the c
This updates the code with regard to handling idle and application-limited
periods as specified in [RFC 4342, 5.1].
Background:
--
The current code does not conform with this, it implements TFRC as per RFC
3448, 4.4:
"If the sender has been idle since this nofeedback timer has been se
A recurring problem, in particular in the CCID code, is that RTT samples
from packets with timestamp echo and elapsed time options need to be taken.
This service is provided via a new function dccp_sample_rtt in this patch.
Furthermore, to protect against `insane' RTT samples, the sampled value
is
This replaces the existing occurrences of RTT sampling with
the use of the new function dccp_sample_rtt.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/ccids/ccid3.c | 42 +
This adds more detail in the wait_for_ccid packet scheduling loop.
In particular, it informs about (i) when delay is used and (ii) why
a packet is discarded.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[E
This updates the documentation on CCID3-specific options.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Acked-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
Documentation/networking/dccp.txt | 10 ++
1 files changed, 10 insertions
This adds a few more fields of interest to /proc/net/dccpprobe, the following
output ensues:
1 2 3 4 5 6 7 8910 11
sec.usec src:sport dst:dport size s rtt p X_calc X_recv X
t_ipi
Also made the formatting consistent.
S
Currently debugging output (when configured) is automatically enabled when
DCCP modules are compiled into the kernel rather than built as loadable modules.
This is not necessary, since the module parameters in this case become kernel
commandline parameters, e.g. DCCP or CCID3 debug output can be en
This fixes a bug which uses an invalid comparison.
The bug resulted in the use of invalid loss intervals.
Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
Acked-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/ccids/lib/loss_interval.c
This adds a few debugging statements to ccid3.c
Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/ccids/ccid3.c | 13 -
1 files changed, 12 insertions(+), 1 deleti
This:
1. removes a race condition in the access to the scheduled send time t_nom
which
results from allowing asynchronous r/w access to t_nom without locks;
2. updates the inter-packet interval t_ipi = s/X when `s' changes, following a
suggestion by Ian McDonald.
Signed-off-by: Gerrit
Since CCID3 avoids sending 0-byte data packets (cf. ccid3_hc_tx_send_packet),
testing for zero-payload length, as performed by ccid3_hc_tx_update_s, is
redundant - hence removed by this patch.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Acked-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-b
No code change at all.
This splits ccid3.c into a RX and a TX section, so that the file has an
organisation similar to the other ones (e.g. packet_history.{h,c}).
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Acked-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[E
This improves the slow-start phase by using the MSS
(as suggested in RFC 4342, sec. 5) instead of the packet size s.
Also figured out that __u32 is ample resource enough.
After applying, I got the following in the logs:
ccid3_hc_tx_packet_recv: client(f7421700), s=6, MSS=1424, w_init=4380,
R_s
The follows48 relation identifies whether 48-bit sequence number
x is the direct successor of y. Currently, it does not handle cases
of the following type correctly:
follows48(0x(prefix)1LL, 0x(prefix)0LL)
where prefix is an arbitrary hex sequence of up to 7 digits.
This is fixed
This removes two ambiguities in employing the new definition of before48,
following the analysis on
http://www.mail-archive.com/dccp@vger.kernel.org/msg01295.html
(1) Updating GSR when P.seqno >= S.SWL
With the old definition we did not update when P.seqno and S.SWL are 2^47
apart. To
Matt Mackall wrote:
I don't know that you need an xchg there. If you're still on the same
CPU, it should all be nice and causal even across an interrupt handler.
So it could be:
pda.intr_mask = 0; /* intr_pending can't get set after this */
Why not? Oh, I see. intr_mask is inverted for
This patch
* organizes the sequence arithmetic functions into one corner of dccp.h
* performs a small modification of dccp_set_seqno to make it more widely
reusable
(now it is safe to use any number, since it performs modulo-2^48 assignment)
* adds functions and generic macros for 48-bit seq
Problem:
Using dccp_delta_seqno(a, b) produces unusable results when -- by accident
or coincidence -- sequence number b precedes a. If e.g. a and b are merely
reordered and have a distance 1, their delta_seqno is 2^48-1, which would
indicate a loss of 2^48-2 packets.
Fix:
The f
Problem:
before48(a, b) returns the same as before48(b, a) for all a, b which
are 2^47 apart (modulo-2^48). The reason is that the difference a-b is used
and `true' is returned whenever 2^47 <= a-b <= 2^48-1. This has the
disadvantage that a positive difference a-b = 2^47 can not be di
Reducing the number of skb->data direct accesses.
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
drivers/net/forcedeth.c | 18 +++---
1 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index 442f10e..423
This patch
* organizes the sequence arithmetic functions into one corner of dccp.h
* performs a small modification of dccp_set_seqno to make it more widely
reusable
(now it is safe to use any number, since it performs modulo-2^48 assignment)
* adds functions and generic macros for 48-bit seq
I did it just in alloc_skb_from_cache, forgot __alloc_skb, fixed now.
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/core/skbuff.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index c274ea3..d7d2dc3 100644
On Tue, Mar 20, 2007 at 09:31:58AM -0700, Jeremy Fitzhardinge wrote:
> Linus Torvalds wrote:
> > On Tue, 20 Mar 2007, Eric W. Biederman wrote:
> >
> >> If that is the case. In the normal kernel what would
> >> the "the oops, we got an interrupt code do?"
> >> I assume it would leave interrupts
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
drivers/atm/idt77252.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
index 20f2a3a..057efbc 100644
--- a/drivers/atm/idt77252.c
+++ b/drivers/atm/idt77252.c
@@
At that point it is equivalent to what was being used, skb->end - skb->data,
and the need is clearly the one skb_tailroom satisfies.
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
drivers/net/wan/lmc/lmc_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --g
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
include/net/netlink.h|2 +-
net/core/wireless.c |2 +-
net/decnet/dn_route.c|3 ++-
net/decnet/dn_table.c|3 ++-
net/ipv4/inet_diag.c |
So that we reduce the number of direct accesses to skb->data.
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/ipv6/netfilter/ip6_tables.c |2 +-
net/ipv6/netfilter/nf_conntrack_reasm.c |5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/net
Leftover from the nlmsg_trim cset.
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/sched/sch_atm.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c
index 53060e6..0cc3c9b 100644
--- a/net/sched/sch_atm.c
+++ b/n
Not used anywhere and defined inside __KERNEL__, Thomas acked this on irc.
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
include/linux/netlink.h | 12
1 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/include/linux/netlink.h b/include/linux/netlink.h
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
include/linux/skbuff.h |1 -
net/core/skbuff.c | 14 --
2 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 4803e4d..155f0e6 100644
--- a/include
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
include/linux/skbuff.h |1 -
net/core/skbuff.c | 14 --
2 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 4803e4d..155f0e6 100644
--- a/include
Hi David,
Sorry to disturb you in your spam mining journey, Zelda is nice at
times,
but real life is better another times, spam aside, take some ham: please
consider
pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22
As soon as the new AC-adapter comes to
Zacco a écrit :
Hi,
David Miller wrote:
From: Zacco <[EMAIL PROTECTED]>
Date: Tue, 20 Mar 2007 00:10:19 +0100
As you recommended, I used oprofile and it turned out that the
__udp4_lib_lookup function spent most of the time. There is a udp
hash table and the sockets are sought based on the
On Tue, 2007-03-20 at 09:58 -0600, Eric W. Biederman wrote:
> Looking at the above code snippet. I guess it is about time to
> merge our per_cpu and pda variables...
Indeed, thanks for the prod. Now 2.6.21-rc4-mm1 is out, I'll resend the
patches.
Cheers,
Rusty.
-
To unsubscribe from this list
On 3/20/07, Thomas Graf <[EMAIL PROTECTED]> wrote:
sch_atm.c:(.text+0x380ed): undefined reference to `nlmsg_trim'
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c
index 53060e6..daa1644 100644
--- a/net/sched/sch_atm.c
+++ b/net/sched/sch_atm
Alan Cox <[EMAIL PROTECTED]> wrote:
> - recvmsg not supporting MSG_TRUNC is rather weird and really ought to be
> fixed one day as its useful to find out the sizeof message pending when
> combined with MSG_PEEK
Hmmm... I hadn't considered that. I assumed MSG_TRUNC not to be useful as
arbitraril
On Tue, 2007-03-20 at 10:19 +0100, YOSHIFUJI Hideaki / 吉藤英明 wrote:
> Hello.
>
> Recent 2.6.21-git kernels do not respond to ping6 queries
> to our own (local) link-local address. Now bisecting...
The following patch seems to be the cause for this regression.
[IPV6] ROUTE: Do not route packets t
Alan Cox <[EMAIL PROTECTED]> wrote:
> > (*) SOCK_RPC has been removed. AF_RXRPC sockets now simply ignore the
> > "type" argument to socket().
>
> This is also incorrect
Sigh.
And what would you have me do? There *isn't* an appropriate SOCK_xxx constant
available, and you won't let me ad
Jeremy Fitzhardinge wrote:
Yeah, disable interrupts, and set a flag that the fake "sti" can test, and
just return without doing anything.
(You may or may not also need to do extra work to Ack the hardware
interrupt etc, which may be irq-controller specific. Once the CPU has
accepted the inte
sch_atm.c:(.text+0x380ed): undefined reference to `nlmsg_trim'
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c
index 53060e6..daa1644 100644
--- a/net/sched/sch_atm.c
+++ b/net/sched/sch_atm.c
@@ -12,8 +12,8 @@
#include
#include
#include
Hi,
David Miller wrote:
From: Zacco <[EMAIL PROTECTED]>
Date: Tue, 20 Mar 2007 00:10:19 +0100
As you recommended, I used oprofile and it turned out that the
__udp4_lib_lookup function spent most of the time. There is a udp hash
table and the sockets are sought based on the 7 LSBs of the de
Hi Deepak,
On Tue, Mar 20, 2007 at 12:22:33PM -0700, Deepak Saxena wrote:
> This was found around the 2.6.10 timeframe when testing with the -rt patch
> and I believe is still is an issue. irttp_dup() does a memcpy() of the
> tsap_cb
> structure causing the spinlock protecting various fields in
The SAA9730 driver doesn't quite grok what the difference between an ioport
and memory mapped I/O is. It just happened to work on the one Linux
system the SAA9730 happens to spend it's misserable existence on.
drivers/net/saa9730.c: In function 'evm_saa9730_enable_lan_int':
drivers/net/saa9730.c:
On Mon, Mar 19, 2007 at 03:43:11PM -0700, Deepak Saxena wrote:
> +#ifdef CONFIG_SBMAC_COALESCE
Not your patch's fault but ... CONFIG_SBMAC_COALESCE is being defined
in sb1250-mac.c but the CONFIG_* namespace is reserved for kconfig.
Ralf
-
To unsubscribe from this list: send the line "unsubsc
Instead of hashing the whole Ethernet address, it should be faster
to just use the last 4 bytes. Add a random salt value to the hash
to make it more difficult to construct worst case DoS hash chains.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
net/bridge/br_fdb.c | 17
While in the STP learning state, don't route packets; wait until
forwarding delay has expired. The purpose of the forwarding delay
is to detect loops in the network, and if a brouter started up
and started forwarding, it could cause a flood.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--
Change the bridging hook to be simple function with return value
rather than modifying the skb argument. This could generate better
code and is cleaner.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
include/linux/if_bridge.h |3 ++-
net/bridge/br_input.c | 20 +-
On Tue, Mar 20, 2007 at 09:39:18PM +, Alan Cox wrote:
> > > Because that's really the issue: do you want a "pretty" backtrace, or do
> > > you want one that is rock solid but has some crud in it.
> >
> > I just want an as exact backtrace as possible. I also think
> > that we can make the unwi
> > Because that's really the issue: do you want a "pretty" backtrace, or do
> > you want one that is rock solid but has some crud in it.
>
> I just want an as exact backtrace as possible. I also think
> that we can make the unwinder robust enough.
Any reason you can't put the exact back trace i
Ok quickly going over the code that hasn't made the list
- recvmsg not supporting MSG_TRUNC is rather weird and really ought to be
fixed one day as its useful to find out the sizeof message pending when
combined with MSG_PEEK
- RXRPC_MIN_SECURITY_LEVEL reads into rx->min_sec_level and then if it
Move generic skbuff stuff from XFRM code to generic code so that AF_RXRPC can
use it too.
The kdoc comments I've attached to the functions needs to be checked by whoever
wrote them as I had to make some guesses about the workings of these functions.
Signed-Off-By: David Howells <[EMAIL PROTECTED]
Alan Cox <[EMAIL PROTECTED]> wrote:
> Some of them don't seem to be making it through to the list and are
> dropped each time btw
Yeah. It's a size issue. The fifth patch is a third of a megabyte. The
patches at the URLs should now be updated (I'd forgotten to do that before
sending the emails
This was found around the 2.6.10 timeframe when testing with the -rt patch
and I believe is still is an issue. irttp_dup() does a memcpy() of the tsap_cb
structure causing the spinlock protecting various fields in the structure to be
duped. This works OK in the non-RT case but in the RT case we
> These patches together supply secure client-side RxRPC connectivity as a Linux
> kernel socket family. Only the transport/session side is supplied - the
> presentation side (marshalling the data) is left to the client. Copies of the
> patches can be found here:
Some of them don't seem to be ma
> (*) SOCK_RPC has been removed. AF_RXRPC sockets now simply ignore the "type"
> argument to socket().
This is also incorrect
NAK
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.or
1 - 100 of 164 matches
Mail list logo
