Re: [PATCH 1/5] NetXen: Fix softlock seen on some machines during hardware writes

2007-03-09 Thread Amit Kale
On Friday 09 March 2007 21:56, Stephen Hemminger wrote: > Linsys Contractor Mithlesh Thukral wrote: > > NetXen: This will fix a softlock seen on some machines. > > The reason was too much time was spent waiting for writes to go through. > > > > Signed-off by: Mithlesh Thukral <[EMAIL PROTECTED]> >

Re: [PATCH 0/5] NetXen: Driver bug fixes

2007-03-09 Thread Amit Kale
On Friday 09 March 2007 22:26, Jeff Garzik wrote: > Linsys Contractor Mithlesh Thukral wrote: > > Hi All, > > > > I will be sending updates to NetXen: 1G/10G Ethernet driver in subsequent > > mails. The patches will be with respect to netdev#upstream. > > Are you sure you don't want some of these i

Re: [PATCHES 0/4] simple fixes and cleanups

2007-03-09 Thread David Miller
From: "Arnaldo Carvalho de Melo" <[EMAIL PROTECTED]> Date: Sat, 10 Mar 2007 00:59:36 -0300 > Please consider pulling from: > > master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22.git. Pulled, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" in th

[PATCH 3/4] [TR]: Make tr_type_trans set skb->dev

2007-03-09 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> --- drivers/net/tokenring/3c359.c |4 drivers/net/tokenring/ibmtr.c |1 - drivers/net/tokenring/lanstreamer.c |3 --- drivers/net/tokenring/olympic.c |3 --- drivers/net/tokenring/smctr.c |2 -- d

[PATCH 2/4] [TR]: Use tr_hdr() were appropriate

2007-03-09 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> --- drivers/net/tokenring/lanstreamer.c |6 +++--- drivers/net/tokenring/olympic.c |9 + drivers/s390/net/qeth_main.c|2 +- net/802/tr.c|3 ++- 4 files changed, 11 insertions(+), 9 d

[PATCHES 0/4] simple fixes and cleanups

2007-03-09 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22.git. - Arnaldo - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-i

[PATCH 1/4] [SOCKET]: Export __sock_recv_timestamp

2007-03-09 Thread Arnaldo Carvalho de Melo
Kernel: arch/x86_64/boot/bzImage is ready (#2) MODPOST 1816 modules WARNING: "__sock_recv_timestamp" [net/sctp/sctp.ko] undefined! WARNING: "__sock_recv_timestamp" [net/packet/af_packet.ko] undefined! WARNING: "__sock_recv_timestamp" [net/key/af_key.ko] undefined! WARNING: "__sock_recv_timestamp

PROBLEM: What happend when exceeding allocatable memory for TCP socket buffers?

2007-03-09 Thread Kumiko Ono
Hi, I tried to find out how many TCP connections a server can establish with a simple test program. But when trying 120K connections for receiving 512 bytes message for each connection sequentially, of which sending rate was 15,000 requests/second, the system stops. I suspect the system was re

SSB/b44 build failure

2007-03-09 Thread Randy Dunlap
Hi, In 2.6.21-rc3-mm2, with CONFIG_SSB=y but all other SSB kconfig symbols disabled, I get this (on x86_64): drivers/built-in.o: In function `b44_init': b44.c:(.init.text+0x6e04): undefined reference to `ssb_pcihost_register' b44.c:(.init.text+0x6e2c): undefined reference to `ssb_pcihost_unregist

[PATCH 1/2] S2io: Remove unused variables

2007-03-09 Thread Ramkrishna Vepa
- Remove unused variables from s2io_nic structure - Changed the memory failure printk messages to print only in debug mode - Updated the copyright messages (Resending; due to patch being corrupted) Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]> --- diff -Nurp patch/drivers/net/s2io.c patc

Re: [PATCH 1/2] NET: Multiple queue network device support

2007-03-09 Thread Thomas Graf
* Waskiewicz Jr, Peter P <[EMAIL PROTECTED]> 2007-03-09 15:27 > That's the entire point of this extra locking. enqueue() is going to > put an skb into a band somewhere that maps to some queue, and there is > no way to guarantee the skb I retrieve from dequeue() is headed for the > same queue. The

Re: [PATCH]: double SAs are created when using AH and ESP together

2007-03-09 Thread Joy Latten
On Fri, 2007-03-09 at 19:54 -0500, Eric Paris wrote: > On Fri, 2007-03-09 at 16:20 -0800, David Miller wrote: > > From: Joy Latten <[EMAIL PROTECTED]> > > Date: Fri, 9 Mar 2007 17:14:54 -0600 > > > > > I noticed that in xfrm_state_add we look for the larval SA in a few > > > places without checkin

Re: [PATCH 2/2] [IPV6]: Ensure to truncate result and return full length for sticky options.

2007-03-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 09 Mar 2007 16:15:06 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > > on arch's that don't protect < 0 copy_to_user like i386 does). Here's > > a simple fix ontop of yoshifuji's two changes. Hope that's it ;-) > > copy_to_user() will check it, ac

Re: [PATCH]: double SAs are created when using AH and ESP together

2007-03-09 Thread Joy Latten
On Fri, 2007-03-09 at 16:20 -0800, David Miller wrote: > From: Joy Latten <[EMAIL PROTECTED]> > Date: Fri, 9 Mar 2007 17:14:54 -0600 > > > I noticed that in xfrm_state_add we look for the larval SA in a few > > places without checking for protocol match. So when using both > > AH and ESP, whichev

Re: Fix net-2.6.22 on sparc

2007-03-09 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Sat, 10 Mar 2007 01:56:16 +0100 > I just checked all arches and only sparc{64} have this strange > SO_ values not linear. I wonder why this layout was chosen ? A lot of the API bogosity in the sparc userspace APIs comes from the fact that we mirror

Re: wireless extensions vs. 64-bit architectures

2007-03-09 Thread Jean Tourrilhes
On Fri, Mar 09, 2007 at 03:19:22PM -0800, Jouni Malinen wrote: > On Fri, Mar 09, 2007 at 01:35:31PM -0800, Jean Tourrilhes wrote: > > > It's not as bad as it look like. All userspace programs > > nowadays use either the iwlib or wpa_supplicant. For example, > > NetworkManager gets its stuff th

Re: Fix net-2.6.22 on sparc

2007-03-09 Thread Eric Dumazet
David Miller a écrit : Eric, please look at whole files you are editing :) I'm sure there is probably another case like this or two in the other platform socket ioctl allocations you made. Thanks. commit 9415518744729743b017da2e08a71c5bb0d94108 Author: David S. Miller <[EMAIL PROTECTED]> Date:

Re: [PATCH]: double SAs are created when using AH and ESP together

2007-03-09 Thread Eric Paris
On Fri, 2007-03-09 at 16:20 -0800, David Miller wrote: > From: Joy Latten <[EMAIL PROTECTED]> > Date: Fri, 9 Mar 2007 17:14:54 -0600 > > > I noticed that in xfrm_state_add we look for the larval SA in a few > > places without checking for protocol match. So when using both > > AH and ESP, whichev

Re: [PATCH 2/2] [IPV6]: Ensure to truncate result and return full length for sticky options.

2007-03-09 Thread Chris Wright
* David Miller ([EMAIL PROTECTED]) wrote: > > Ugh, Chris, why is this patch against a copy of ipv6_sockglue.c > that doesn't have the NULL pointer fix applied? > > Nevermind, it's obvious, so I fixed it up by hand, but please > patch against current sources expecially when we're all aware > of ot

Fix net-2.6.22 on sparc

2007-03-09 Thread David Miller
Eric, please look at whole files you are editing :) I'm sure there is probably another case like this or two in the other platform socket ioctl allocations you made. Thanks. commit 9415518744729743b017da2e08a71c5bb0d94108 Author: David S. Miller <[EMAIL PROTECTED]> Date: Fri Mar 9 16:22:52 200

Re: [PATCH 2/2] [IPV6]: Ensure to truncate result and return full length for sticky options.

2007-03-09 Thread Chris Wright
* David Miller ([EMAIL PROTECTED]) wrote: > copy_to_user() will check it, actually, it will make sure that > optval + len doesn't wrap or overlap into kernel space. > > Actually, like sparc64 it BUG's on negative length so we have > to fix this :-) Yeah, I think it's arch dependent (x86_64 for ex

Re: [PATCH]: double SAs are created when using AH and ESP together

2007-03-09 Thread David Miller
From: Joy Latten <[EMAIL PROTECTED]> Date: Fri, 9 Mar 2007 17:14:54 -0600 > I noticed that in xfrm_state_add we look for the larval SA in a few > places without checking for protocol match. So when using both > AH and ESP, whichever one gets added first, deletes the larval SA. > It seems AH alwa

Re: [PATCH 2/2] [IPV6]: Ensure to truncate result and return full length for sticky options.

2007-03-09 Thread David Miller
Ugh, Chris, why is this patch against a copy of ipv6_sockglue.c that doesn't have the NULL pointer fix applied? Nevermind, it's obvious, so I fixed it up by hand, but please patch against current sources expecially when we're all aware of other fixes that have been made to this exact function ove

Re: [PATCH 2/2] [IPV6]: Ensure to truncate result and return full length for sticky options.

2007-03-09 Thread Chris Wright
* David Miller ([EMAIL PROTECTED]) wrote: > From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> > Date: Fri, 09 Mar 2007 10:13:28 +0900 (JST) > > > Bug noticed by Chris Wright <[EMAIL PROTECTED]>. > > > > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > > Applied, thanks a lot. Crud, I sho

Re: wireless extensions vs. 64-bit architectures

2007-03-09 Thread Jouni Malinen
On Fri, Mar 09, 2007 at 01:35:31PM -0800, Jean Tourrilhes wrote: > It's not as bad as it look like. All userspace programs > nowadays use either the iwlib or wpa_supplicant. For example, > NetworkManager gets its stuff through wpa_supplicant, and kdenetwork > uses iwlib. So, in essence, ther

[PATCH]: double SAs are created when using AH and ESP together

2007-03-09 Thread Joy Latten
On Tue, 2007-03-06 at 14:40 -0500, James Morris wrote: On Tue, 6 Mar 2007, Joy Latten wrote: > > > > I saw something similar to this some time ago when testing various > > > failure modes, and discused it with Herbert. > > > > > > IIRC, there's a larval SA which is not torn down properly by Raco

Re: netconsole system freeze when cable unplugged

2007-03-09 Thread Simon Arlott
On 09/03/07 20:42, Francois Romieu wrote: Simon Arlott <[EMAIL PROTECTED]> : When I unplug the cable the system just stops responding to anything, at all. No message is printed to the console when the cable is plugged back in. rtl8139_interrupt (spin_lock(&tp->lock)) -> rtl8139_weird_interrup

RE: [PATCH 1/2] NET: Multiple queue network device support

2007-03-09 Thread Waskiewicz Jr, Peter P
> * Waskiewicz Jr, Peter P <[EMAIL PROTECTED]> > 2007-03-09 11:25 > > > > + } > > > > + } else { > > > > + /* We're not a multi-queue device. */ > > > > + spin_lock(&dev->queue_lock); > > > > + q

Re: [PATCH] spidernet: Fix problem sending IP fragments

2007-03-09 Thread Norbert Eicker
On Friday, 9. March 2007 17:53, Jeff Garzik wrote: > Linas Vepstas wrote: > > Jeff, > > > > Please apply. The rather long patch description is from the submitter, > > Norbert Eicker, I don't know if that's alright, or if I should ask to > > have it trimmed. > > > > Thanks, > > --linas > > > > From:

Re: [PATCH 1/2] NET: Multiple queue network device support

2007-03-09 Thread Thomas Graf
* Waskiewicz Jr, Peter P <[EMAIL PROTECTED]> 2007-03-09 11:25 > > > + } > > > + } else { > > > + /* We're not a multi-queue device. */ > > > + spin_lock(&dev->queue_lock); > > > + q = dev->qdisc; > > > + if (q->

Re: [PATCH] NET : Adding SO_TIMESTAMPNS / SCM_TIMESTAMPNS support

2007-03-09 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 9 Mar 2007 19:39:42 +0100 > [PATCH] NET : Adding SO_TIMESTAMPNS / SCM_TIMESTAMPNS support > > Now that network timestamps use ktime_t infrastructure, we can add a new > SOL_SOCKET sockopt SO_TIMESTAMPNS. > > This command is similar to SO_TIMEST

Re: Fix for ipv6_setsockopt NULL dereference

2007-03-09 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Fri, 09 Mar 2007 23:40:25 +0900 (JST) > In article <[EMAIL PROTECTED]> (at Fri, 9 Mar 2007 15:15:54 +0100), Olaf > Kirch <[EMAIL PROTECTED]> says: > > > I came across this bug in http://bugzilla.kernel.org/show_bug.cgi?id=8155 > : > > Fix

Re: Fix for ipv6_setsockopt NULL dereference

2007-03-09 Thread David Miller
From: Olaf Kirch <[EMAIL PROTECTED]> Date: Fri, 9 Mar 2007 15:15:54 +0100 > I came across this bug in http://bugzilla.kernel.org/show_bug.cgi?id=8155 > > Here's a potential fix. > > Olaf > -- > Olaf Kirch | --- o --- Nous sommes du soleil we love when we play > [EMAIL PROTECTED] |/ | \

Re: [PATCH 1/1][UDP]: Use __skb_pull since we have checked it won't fail with pskb_may_pull

2007-03-09 Thread David Miller
From: "Arnaldo Carvalho de Melo" <[EMAIL PROTECTED]> Date: Fri, 9 Mar 2007 11:07:50 -0300 > Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Applied to net-2.6.22, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED]

Re: 2.6.19/2.6.20 BUG in inet_rtm_newaddr()/__inet_insert_ifa()

2007-03-09 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Fri, 9 Mar 2007 15:30:17 +0300 > On Fri, Mar 09, 2007 at 11:33:33AM +0100, Frank van Maarseveen ([EMAIL > PROTECTED]) wrote: > > Try this: > > > > ip addr add 172.18.12.99/21 dev dummy0 > > ip addr add broadcast 172.18.15.255 dev dummy0 > > Attac

Re: wireless extensions vs. 64-bit architectures

2007-03-09 Thread Jean Tourrilhes
On Thu, Mar 08, 2007 at 11:35:26PM +0100, Johannes Berg wrote: > On Thu, 2007-03-08 at 14:11 -0800, Jean Tourrilhes wrote: > > > First possiblity, we could stick with this band-aid > > permanently. > > It sucks for various reasons, one for example being that I don't even > understand your rec

Re: netconsole system freeze when cable unplugged

2007-03-09 Thread Francois Romieu
Simon Arlott <[EMAIL PROTECTED]> : > When I unplug the cable the system just stops responding to anything, > at all. No message is printed to the console when the cable is plugged > back in. rtl8139_interrupt (spin_lock(&tp->lock)) -> rtl8139_weird_interrupt -> rtl_check_media -> mii_ch

Re: [Bridge] rstp for 2.4 kernel: port state keeps changing

2007-03-09 Thread Stephen Hemminger
On Fri, 9 Mar 2007 15:20:02 -0500 [EMAIL PROTECTED] wrote: > I have downloaded RSTP from this site: > > > http://developer.osdl.org/shemminger/prototypes/rstp-2.4.zip > > That's cool, I didn't know anyone got the old code to work! -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubsc

Re: [Bridge] rstp for 2.4 kernel: port state keeps changing

2007-03-09 Thread Marc . Obbad
I have downloaded RSTP from this site: http://developer.osdl.org/shemminger/prototypes/rstp-2.4.zip -Marc Stephen Hemminger

netconsole system freeze when cable unplugged

2007-03-09 Thread Simon Arlott
When I unplug the cable the system just stops responding to anything, at all. No message is printed to the console when the cable is plugged back in. [0.00] Linux version 2.6.21-rc3 ([EMAIL PROTECTED]) (gcc version 3.4.6 (Gentoo 3.4.6-r1, ssp-3.4.5-1.0, pie-8.7.9)) #3 SMP Fri Mar 9 18:

RE: [PATCH 1/2] NET: Multiple queue network device support

2007-03-09 Thread Waskiewicz Jr, Peter P
> -Original Message- > From: Thomas Graf [mailto:[EMAIL PROTECTED] > Sent: Friday, March 09, 2007 5:41 AM > To: Kok, Auke-jan H > Cc: David Miller; Garzik, Jeff; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org; Waskiewicz Jr, Peter P; > Brandeburg, Jesse; Kok, Auke; Ronciak, John

Re: [NET]: Please revert disallowing zero listen queues

2007-03-09 Thread Vlad Yasevich
David Miller wrote: > From: Rick Jones <[EMAIL PROTECTED]> > Date: Tue, 06 Mar 2007 10:54:00 -0800 > >>> So we're not "disallowing" a backlog argument of zero to >>> listen(). We'll accept that just fine, the only thing that >>> happens is that you'll get what you ask for, that being >>> no conne

Re: rstp for 2.4 kernel: port state keeps changing

2007-03-09 Thread Stephen Hemminger
On Fri, 9 Mar 2007 12:24:40 -0500 [EMAIL PROTECTED] wrote: > > Hi, > > I am using RSTP for 2.4 kernel. RSTP is not in the mainline kernel tree. Please post the patch or a where the source can be downloaded. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the lin

[PATCH] NET : Adding SO_TIMESTAMPNS / SCM_TIMESTAMPNS support

2007-03-09 Thread Eric Dumazet
Hi David This patch is against net-2.6.22 git tree. Thank you [PATCH] NET : Adding SO_TIMESTAMPNS / SCM_TIMESTAMPNS support Now that network timestamps use ktime_t infrastructure, we can add a new SOL_SOCKET sockopt SO_TIMESTAMPNS. This command is similar to SO_TIMESTAMP, but permits transmi

Re: 2.6.19/2.6.20 BUG in inet_rtm_newaddr()/__inet_insert_ifa()

2007-03-09 Thread Frank van Maarseveen
On Fri, Mar 09, 2007 at 03:30:17PM +0300, Evgeniy Polyakov wrote: > On Fri, Mar 09, 2007 at 11:33:33AM +0100, Frank van Maarseveen ([EMAIL > PROTECTED]) wrote: > > Try this: > > > > ip addr add 172.18.12.99/21 dev dummy0 > > ip addr add broadcast 172.18.15.255 dev dummy0 > > Attached patch fixes

Re: about : [NET]: Replace CONFIG_NET_DEBUG with sysctl.

2007-03-09 Thread Stephen Hemminger
This was what the patch was (complete with spulling error)... Covert network warning messages from a compile time to runtime choice. Removes kernel config option and replaces it with new /proc/sys/net/core/warnings. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- Documentation/file

Re: [PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq

2007-03-09 Thread Jeff Garzik
Kok, Auke wrote: Personally, I think this is really really needed. I'm surprised that you already didn't push this considering Andrew pulled this into -mm immediately. Since it affects a fragile area of e1000 for all [e1000] users, I much prefer to err on the side of caution. I have a histo

[git patches] net driver fixes

2007-03-09 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/3c59x.c | 28 - drivers/net/mv643xx_eth.c | 10 -- drive

rstp for 2.4 kernel: port state keeps changing

2007-03-09 Thread Marc . Obbad
Hi, I am using RSTP for 2.4 kernel. I have created a loop between two bridges: P1 --- P1 BR1 BR2 P2 -- P2

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity

2007-03-09 Thread Randy Dunlap
On Fri, 9 Mar 2007 09:19:07 -0500 John W. Linville wrote: > Probably should copy me and [EMAIL PROTECTED] Other than > that, this looks fine to me. I'll queue it up shortly. > > John > > On Fri, Mar 09, 2007 at 01:11:46PM +1100, Tony Breeds wrote: > > On Wed, Mar 07, 2007 at 03:00:57PM -0800,

Re: [PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq

2007-03-09 Thread Kok, Auke
Jeff Garzik wrote: Auke Kok wrote: From: Auke Kok <[EMAIL PROTECTED]> DEBUG_SHIRQ code exposed that e1000 was not ready for incoming interrupts after having called pci_request_irq. This obviously requires us to finish our software setup which assigns the irq handler before we request the irq.

Re: [PATCH] ixgb: Use ARRAY_SIZE macro when appropriate.

2007-03-09 Thread Jeff Garzik
Auke Kok wrote: From: Ahmed S. Darwish <[EMAIL PROTECTED]> Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/ixgb/ixgb_param.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) applied - To unsubscribe from this list

Re: [PATCH 1/2] S2IO: Remove unused variables

2007-03-09 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Remove unused variables from s2io_nic structure - Changed the memory failure printk messages to print only in debug mode - Updated the copyright messages (Resending; forgot to cc netdev) Signed-off-by: Santosh Rastapur <[EMAIL PROTECTED]> patch #1 was corrupted, b

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

2007-03-09 Thread Jeff Garzik
Don Fry wrote: The patch below moves the init_block out of the private struct and only allocates init block with pci_alloc_consistent. This has two effects: 1. Performance increase for non cache coherent machines, because the CPU only data in the private struct are now cached 2. locks are

Re: [PATCH 1/3] e1000: Use ARRAY_SIZE macro when appropriate

2007-03-09 Thread Jeff Garzik
Auke Kok wrote: From: Ahmed S. Darwish <[EMAIL PROTECTED]> A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_ethtool.c |2 +- 1 files changed, 1 insertion

Re: [NET] 3c59x: Fix several modpost warnings

2007-03-09 Thread Jeff Garzik
Ralf Baechle wrote: WARNING: drivers/net/3c59x.o - Section mismatch: reference to .init.text: from .text between 'vortex_eisa_probe' (at offset 0x4580) and 'vortex_eisa_remove' WARNING: drivers/net/3c59x.o - Section mismatch: reference to .init.text: from .text between 'vortex_eisa_probe' (at o

Re: [PATCH 1/2] r8169: revert bogus BMCR reset

2007-03-09 Thread Jeff Garzik
Francois Romieu wrote: Added during bf793295e1090af84972750898bf8470df5e5419 The current code requests a reset but prohibits autoneg, 1000 Mb/s, 100 Mb/s and full duplex. The 8168 does not like it at all. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> --- drivers/net/r8169.c |4 ++-- 1

Re: [PATCH] spidernet: Fix problem sending IP fragments

2007-03-09 Thread Jeff Garzik
Linas Vepstas wrote: Jeff, Please apply. The rather long patch description is from the submitter, Norbert Eicker, I don't know if that's alright, or if I should ask to have it trimmed. Thanks, --linas From: Norbert Eicker <[EMAIL PROTECTED]> I found out that the spidernet-driver is unabl

Re: [Bonding-devel] [PATCH 3/3] bonding: Improve IGMP join processing

2007-03-09 Thread Andy Gospodarek
On Tue, Mar 06, 2007 at 07:21:30PM -0800, David Stevens wrote: > > >Marking the master down would, I believe, issue notifiers that > > > the device has gone down. Various things, network manager sort of > > > applications in particular, listen to those, so I'm not sure it's a > good > > > id

Re: [PATCH 0/5] NetXen: Driver bug fixes

2007-03-09 Thread Jeff Garzik
Linsys Contractor Mithlesh Thukral wrote: Hi All, I will be sending updates to NetXen: 1G/10G Ethernet driver in subsequent mails. The patches will be with respect to netdev#upstream. Are you sure you don't want some of these in #upstream-fixes, queued for 2.6.21-rc? Jeff - To un

Re: [PATCH 1/4] myri10ge: fix error checking and return value in myri10ge_allocate_rings

2007-03-09 Thread Jeff Garzik
Brice Goglin wrote: Fix a missing error check in myri10ge_allocate_rings() and set status to -ENOMEM before all actual allocations so that the error path returns what it should. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> --- drivers/net/myri10ge/myri10ge.c |4 1 file changed, 4 in

Re: [PATCH] mv643xx: Clear pending interrupts before calling request_irq

2007-03-09 Thread Jeff Garzik
Dale Farnsworth wrote: From: Dale Farnsworth <[EMAIL PROTECTED]> Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> Acked-by: Giridhar Pemmasani <[EMAIL PROTECTED]> --- Giri, thank you very much for reporting the problem and confirming the fix. Jeff, please apply. Andrew, this patch supersed

Re: [PATCH] sky2: turn off Rx checksum on bad hardware

2007-03-09 Thread Jeff Garzik
Stephen Hemminger wrote: On Yukon FE, occasional hardware receive checksum errors are seen. An early indication of the problem is single bit differences in the two checksum engines. Use this as a detection mechanism to turn off Rx checksumming. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED

Re: [PATCH] Allow pktgen to work with loopback devices.

2007-03-09 Thread Jeff Garzik
Josh Triplett wrote: pktgen currently only works on network devices with type ARPHRD_ETHER. Add support for the loopback device, type ARPHRD_LOOPBACK. I've tested this on my system, using a modified pktgen.conf-1-1 with s/eth1/lo/g, and it works fine; the network device statistics confirm packe

Re: [NET] netxen: fix warnings

2007-03-09 Thread Jeff Garzik
Ralf Baechle wrote: CC [M] drivers/net/netxen/netxen_nic_hw.o drivers/net/netxen/netxen_nic_hw.c: In function 'netxen_nic_hw_resources': drivers/net/netxen/netxen_nic_hw.c:231: warning: format '%llx' expects type 'long long unsigned int', but argument 2 has type 'dma_addr_t' drivers/net/netxe

Re: [PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq

2007-03-09 Thread Jeff Garzik
Auke Kok wrote: From: Auke Kok <[EMAIL PROTECTED]> DEBUG_SHIRQ code exposed that e1000 was not ready for incoming interrupts after having called pci_request_irq. This obviously requires us to finish our software setup which assigns the irq handler before we request the irq. Signed-off-by: Auke

Re: [PATCH 1/5] NetXen: Fix softlock seen on some machines during hardware writes

2007-03-09 Thread Stephen Hemminger
Linsys Contractor Mithlesh Thukral wrote: NetXen: This will fix a softlock seen on some machines. The reason was too much time was spent waiting for writes to go through. Signed-off by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic.h |1 + drivers/net/netxen

Re: [PATCH 2/5] NetXen: Update the statistics counter for interrupts

2007-03-09 Thread Stephen Hemminger
Linsys Contractor Mithlesh Thukral wrote: NetXen: Update the statistics counter for interrupts which have occured. Signed-off-by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic_main.c |1 + 1 files changed, 1 insertion(+) diff --git a/drivers/net/netxen/netxen_nic_

Re: about : [NET]: Replace CONFIG_NET_DEBUG with sysctl.

2007-03-09 Thread Stephen Hemminger
Eric Dumazet wrote: Hello David and Stephen I see git commit 8e2101a9faab43dcf307d46784a1ede7997fe729 and its potential problems : Here on my x86_64 machine : 806e7520 d rtnl_mutex 806e7538 D net_msg_cost 806e753c D net_msg_burst 806e7540 D net_msg_warn

Re: TSO performance wrt 2.614

2007-03-09 Thread Stephen Hemminger
anandvelu thulasiram wrote: Hi all, I'm working on TCP segmentation Offload and I'm using Linux -2.6.14 kernel for this. I'm getting about a 6x increase in sending by turning off TCP segmentation offload. But When I turn on the TSO my performance is getting degraded. But when I swi

Re: about : [NET]: Replace CONFIG_NET_DEBUG with sysctl.

2007-03-09 Thread Stephen Hemminger
Eric Dumazet wrote: David Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 09 Mar 2007 07:34:15 +0100 I gently ask that any new sysctl is '__read_mostly' tagged. People are lazy because you are so gifted at finding this stuff :-) I seee ;) BTW I missed the patch on n

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity

2007-03-09 Thread John W. Linville
Probably should copy me and [EMAIL PROTECTED] Other than that, this looks fine to me. I'll queue it up shortly. John On Fri, Mar 09, 2007 at 01:11:46PM +1100, Tony Breeds wrote: > On Wed, Mar 07, 2007 at 03:00:57PM -0800, Andrew Morton wrote: > > On Wed, 7 Mar 2007 23:41:16 +0100 > > Adrian Bun

Re: Fix for ipv6_setsockopt NULL dereference

2007-03-09 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 9 Mar 2007 15:15:54 +0100), Olaf Kirch <[EMAIL PROTECTED]> says: > I came across this bug in http://bugzilla.kernel.org/show_bug.cgi?id=8155 : > Fix NULL pointer derefence in ipv6_setsockopt, as described in bug #8155. > > Signed-off-by: [EMAIL PROTECTED]

Fix for ipv6_setsockopt NULL dereference

2007-03-09 Thread Olaf Kirch
I came across this bug in http://bugzilla.kernel.org/show_bug.cgi?id=8155 Here's a potential fix. Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax -- Fix NULL pointer derefence in ipv6_setsockopt,

[PATCH 1/1][UDP]: Use __skb_pull since we have checked it won't fail with pskb_may_pull

2007-03-09 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> --- net/ipv4/udp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index ca35380..1bbf551 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -1002,7 +1002,7 @@ static int udp_encap

Re: [PATCH 2/2] e1000: Implement the new kernel API for multiqueue TX support.

2007-03-09 Thread Thomas Graf
* Kok, Auke <[EMAIL PROTECTED]> 2007-02-08 16:09 > > From: Peter Waskiewicz Jr. <[EMAIL PROTECTED]> > > Several newer e1000 chipsets support multiple RX and TX queues. Most > commonly, 82571's and ESB2LAN support 2 rx and 2 rx queues. > > Signed-off-by: Peter Waskiewicz Jr. <[EMAIL PROTECTED]> >

Re: [PATCH 1/2] NET: Multiple queue network device support

2007-03-09 Thread Thomas Graf
* Kok, Auke <[EMAIL PROTECTED]> 2007-02-08 16:09 > diff --git a/net/core/dev.c b/net/core/dev.c > index 455d589..42b635c 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -1477,6 +1477,49 @@ gso: > skb->tc_verd = SET_TC_AT(skb->tc_verd,AT_EGRESS); > #endif > if (q->enqueue) { >

Re: [Bugme-new] [Bug 8132] New: pptp server lockup in ppp_asynctty_receive()

2007-03-09 Thread Jarek Poplawski
On Fri, Mar 09, 2007 at 11:40:04AM +0300, Yuriy N. Shkandybin wrote: ... > .config is at > http://bugzilla.kernel.org/attachment.cgi?id=10660&action=view > Also all information i've provied was recieved by serial console and it's > not hand writing. > > I've checked logs and right before lockup t

Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error

2007-03-09 Thread Tejun Heo
Hello, Randy Dunlap wrote: >> Erm, before I do that, could somebody explain what >> >> #define HAVE_PCI_REQ_REGIONS 2 >> >> accompanying their declaration is for? I have't found any references to it >> in >> the source. Should I duplicate it for CONFIG_PCI=n case (I guess not)? > > I wouldn

Re: 2.6.19/2.6.20 BUG in inet_rtm_newaddr()/__inet_insert_ifa()

2007-03-09 Thread Evgeniy Polyakov
On Fri, Mar 09, 2007 at 11:33:33AM +0100, Frank van Maarseveen ([EMAIL PROTECTED]) wrote: > Try this: > > ip addr add 172.18.12.99/21 dev dummy0 > ip addr add broadcast 172.18.15.255 dev dummy0 Attached patch fixes the problem. nlmsg_parse() in rtm_to_ifaddr() sucessfully returns zero, but subs

2.6.19/2.6.20 BUG in inet_rtm_newaddr()/__inet_insert_ifa()

2007-03-09 Thread Frank van Maarseveen
Try this: ip addr add 172.18.12.99/21 dev dummy0 ip addr add broadcast 172.18.15.255 dev dummy0 kernel: BUG: unable to handle kernel NULL pointer dereference at virtual address 0004 kernel: printing eip: kernel: c04bc331 kernel: *pde = kernel: Oops: [#1] kernel: SMP kernel: Mo

Re: [Bugme-new] [Bug 8132] New: pptp server lockup in ppp_asynctty_receive()

2007-03-09 Thread Jarek Poplawski
On Fri, Mar 09, 2007 at 11:40:04AM +0300, Yuriy N. Shkandybin wrote: ... > I already have > CONFIG_PROVE_LOCKING=y > # CONFIG_4KSTACKS is not set > .config is at > http://bugzilla.kernel.org/attachment.cgi?id=10660&action=view > Also all information i've provied was recieved by serial console and i

Re: [Bugme-new] [Bug 8132] New: pptp server lockup in ppp_asynctty_receive()

2007-03-09 Thread Yuriy N. Shkandybin
Could this be done with: CONFIG_PROVE_LOCKING = y CONFIG_4KSTACKS = n and, if possible, to send the first full lockdep error message with some lines before it? It would be nice to try to be more exact when hand writing, too. Regards, Jarek P. I already have CONFIG_PROVE_LOCKING=y # CONFIG_4KS

[PATCH 5/5] NetXen: Fix the setup of resources for hardware on multi port cards

2007-03-09 Thread Linsys Contractor Mithlesh Thukral
NetXen: Fix the setup of resources for hardware on multi port cards. Signed-off-by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic_hw.c |8 +--- drivers/net/netxen/netxen_nic_phan_reg.h |6 +++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --

[PATCH 4/5] NetXen: Fix the reading of MAC adddress during probe

2007-03-09 Thread Linsys Contractor Mithlesh Thukral
NetXen: Fix the reading of MAC adddress during probe Signed-off-by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic_main.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c i

[PATCH 3/5] NetXen: Fix the driver for reduced PCIE footprint cards

2007-03-09 Thread Linsys Contractor Mithlesh Thukral
NetXen: Fix the driver for reduced PCIE footprint cards. Signed-off-by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic.h |8 +- drivers/net/netxen/netxen_nic_hdr.h |2 + drivers/net/netxen/netxen_nic_main.c | 30 - 3 files chan

[PATCH 2/5] NetXen: Update the statistics counter for interrupts

2007-03-09 Thread Linsys Contractor Mithlesh Thukral
NetXen: Update the statistics counter for interrupts which have occured. Signed-off-by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic_main.c |1 + 1 files changed, 1 insertion(+) diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main

[PATCH 1/5] NetXen: Fix softlock seen on some machines during hardware writes

2007-03-09 Thread Linsys Contractor Mithlesh Thukral
NetXen: This will fix a softlock seen on some machines. The reason was too much time was spent waiting for writes to go through. Signed-off by: Mithlesh Thukral <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic.h |1 + drivers/net/netxen/netxen_nic_ethtool.c |1 + drivers/net/

[PATCH 0/5] NetXen: Driver bug fixes

2007-03-09 Thread Linsys Contractor Mithlesh Thukral
Hi All, I will be sending updates to NetXen: 1G/10G Ethernet driver in subsequent mails. The patches will be with respect to netdev#upstream. Regards, Mithlesh Thukral - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo