Re: Deadlock in MD5 Signature support

2007-02-20 Thread David Miller
From: "Leigh Brown" <[EMAIL PROTECTED]> Date: Sun, 17 Dec 2006 18:13:06 - (GMT) > It was all going so well, and then it deadlocked. What can be done > about this? Sorry for taking so long about this. The problem is that tcp_md5sig_pool_lock is taken in both software-interrupt and non-softwa

Re: [RFC] split NAPI from network device.

2007-02-20 Thread David Miller
From: Divy Le Ray <[EMAIL PROTECTED]> Date: Tue, 20 Feb 2007 23:39:55 -0800 > I applied the patch to test the chelsio drivers. > The compilation of the forcedeth driver fails if CONFIG_FORCEDETH_NAPI > is not set. > /opt/sources/linux-2.6/drivers/net/forcedeth.c: In function `nv_nic_irq': > /opt/

Re: [PATCH] ehea: dynamic add / remove port

2007-02-20 Thread Jan-Bernd Themann
Hi, > This looks great! Two questions. I would assume that the of_device > results in a "devspec" file in the sysfs directory for the port? Also, yes, that is true. There is a devspec file containing the ofdt path in the port directory. > is there a way to correlate a logical port to an ether

Re: [RFC] split NAPI from network device.

2007-02-20 Thread Divy Le Ray
David Miller wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 13 Dec 2006 15:46:35 -0800 Split off NAPI part from network device, this patch is build tested only! It breaks kernel API for network devices, and only three examples are fixed (skge, sky2, and tg3). 1. Decomposition

Re: iwlwifi warnings

2007-02-20 Thread Randy Dunlap
On Tue, 20 Feb 2007 22:23:21 -0800 Stephen Hemminger wrote: > BUilding with sparse shows lots of warnings. > > > $ make C=1 > Checking kernel compatibility in: > /lib/modules/2.6.20.1/source > * Kernel supports required features for 'tip' version. > Building compatibility version in 'compat

[PATCH 1/2][IPX] Remove outdated information from Kconfig

2007-02-20 Thread Rolf Eike Beer
SPX was removed in early 2.5. How to connect to a Mac or the other OS isn't hard to find out these days. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- commit 0566e9a5f19ca9fe1982e2b4a89aff131cc6525b tree 20b72b4e347a0ff926f82188bb296c2b3a8911f5 parent ce4e52a8be675c1724fa3af503ff1c75478ff

[PATCH 0/2] Remove outdated information from IPX

2007-02-20 Thread Rolf Eike Beer
Who cares about stuff describing what happened in early 2.5 days? Even worse is to reference Kconfig options removed back then. Go, rest in pieces. Eike pgpWbqv7vWWdc.pgp Description: PGP signature

[PATCH 2/2][IPX] Remove ancient changelog

2007-02-20 Thread Rolf Eike Beer
[IPX] Remove ancient changelog Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- commit 6b8afc66b9d6893d3fa292b75769b58539836ff3 tree 9078513bb6727e61aee238da153d9b3358a1d817 parent 0566e9a5f19ca9fe1982e2b4a89aff131cc6525b author Rolf Eike Beer <[EMAIL PROTECTED]> Tue, 20 Feb 2007 19:45:03 +0

Re: [PATCH 1/5][SCTP]: Implement SCTP_FRAGMENT_INTERLEAVE socket option.

2007-02-20 Thread David Miller
From: Sridhar Samudrala <[EMAIL PROTECTED]> Date: Fri, 16 Feb 2007 19:39:43 -0800 > [SCTP]: Implement SCTP_FRAGMENT_INTERLEAVE socket option. Sorry, these patches missed the merge window. Patches 4 and 5 are bug fixes, so I could apply just those if you want me to, just let me know and you don't

Re: [AF_PACKET] remove unnecessary casts

2007-02-20 Thread David Miller
From: Jason Lunz <[EMAIL PROTECTED]> Date: Wed, 14 Feb 2007 18:35:58 -0500 > packet_lookup_frame() always returns tpacket_hdr*, so there's no reason > to return char* and require casting by callers. > > Also, remove a cast of void*. > > Signed-off-by: Jason Lunz <[EMAIL PROTECTED]> Applied, tha

Re: [GIT PULL] IPv6 Updates

2007-02-20 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Thu, 15 Feb 2007 02:35:14 +0900 (JST) > Please consider pulling the following changesets available on the > 2.6.20-net-2.6-20070214-FOR_DAVEM > branch at > > (on top of commit 928ba4169dc1d82c83105831f5ddb5472379b440). Unfortunately,

Re: [TG3]: TSO workaround fixes.

2007-02-20 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 20 Feb 2007 19:50:15 -0800 > [TG3]: TSO workaround fixes. > > 1. Add race condition check after netif_stop_queue(). tg3_tx() runs > without netif_tx_lock and can race with tg3_start_xmit_dma_bug() -> > tg3_tso_bug(). > > 2. Firmware

iwlwifi warnings

2007-02-20 Thread Stephen Hemminger
BUilding with sparse shows lots of warnings. $ make C=1 Checking kernel compatibility in: /lib/modules/2.6.20.1/source * Kernel supports required features for 'tip' version. Building compatibility version in 'compatible/' directory: Copying compatible/ from origin/...done make -C /lib/modules

Re: watchdog timeout panic in e1000 driver

2007-02-20 Thread Kenzo Iwami
Hi, Thank you for your comment. > this looks a lot better than the previous patch!! However, we already have a > state marker for _down_ that we should probably reuse. Can you try the > attached > patch and see if it works for you? It's basically your patch without the > added > remove flag

[TG3]: TSO workaround fixes.

2007-02-20 Thread Michael Chan
[TG3]: TSO workaround fixes. 1. Add race condition check after netif_stop_queue(). tg3_tx() runs without netif_tx_lock and can race with tg3_start_xmit_dma_bug() -> tg3_tso_bug(). 2. Firmware TSO in 5703/5704/5705 also have the same TSO limitation, i.e. they cannot handle TSO heade

Re: skge dysfunction on Amd X2 machine with 4GB memory

2007-02-20 Thread Matti Aarnio
On Mon, Feb 19, 2007 at 11:15:02PM -0800, Chris Wedgwood wrote: > On Sun, Feb 11, 2007 at 04:57:55PM +0200, Matti Aarnio wrote: > > With the skge driver there seems to be some sort of problem to work > > in a system with memory above the 4 GB of PCI address space. > > The chipset (apparently) does

Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check()

2007-02-20 Thread Stephen Hemminger
On Wed, 21 Feb 2007 01:19:41 +0300 Oleg Nesterov <[EMAIL PROTECTED]> wrote: > If del_nbp()->cancel_delayed_work(carrier_check) fails, port_carrier_check() > may run later and access an already freed container (struct net_bridge_port). > > With this patch, carrier_check owns a reference to "struct

[PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check()

2007-02-20 Thread Oleg Nesterov
If del_nbp()->cancel_delayed_work(carrier_check) fails, port_carrier_check() may run later and access an already freed container (struct net_bridge_port). With this patch, carrier_check owns a reference to "struct net_bridge_port", not net_device, so it is always safe to acces the container. port

[PATCH 2/3] chelsio: use C99 style initialization

2007-02-20 Thread Stephen Hemminger
Convert some initialized structures to C99 style. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/chelsio/subr.c | 195 ++--- 1 file changed, 134 insertions(+), 61 deletions(-) --- chelsio.orig/drivers/net/chelsio/subr.c +++ chelsio/

[PATCH 3/3] chelsio: use const for virtual functions

2007-02-20 Thread Stephen Hemminger
There are several uses of _ops structure in this driver that can be converted to const. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/chelsio/common.h|6 +++--- drivers/net/chelsio/cphy.h | 16 +++- drivers/net/chelsio/gmac.h | 10 +++-

[PATCH 1/3] chelsio: remove unused code for 1G boards

2007-02-20 Thread Stephen Hemminger
Some code for Chelsio 1G boards was put in the driver based on the vendor version (minus TOE). Well some of those board versions are only supported with TOE on the vendor driver, so additional dead code was added. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/chelsio/Makef

[PATCH 0/3] chelsio 10G driver cleanups

2007-02-20 Thread Stephen Hemminger
Some janitorial type house cleaning of the Chelsio 10G driver. Remove dead code spotted by Adrian and make iniatialization logic clearer. -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel

Re: [ipw3945-devel] [ANNOUNCE] d80211 based driver for Intel PRO/Wireless 3945ABG

2007-02-20 Thread Pavel Machek
Hi! > >>You can find the new driver, and additional information > >>about it, here: > >> > >> http://intellinuxwireless.org/iwlwifi. > >... > >>You can find that package at: > >> > >> http://intellinuxwireless.org/d80211 > >> > >>Ok. Now... any questions? > > > >Yes... is there merged .git tre

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Ian McDonald
On 2/21/07, bert hubert <[EMAIL PROTECTED]> wrote: I'm trying to figure out which processes have the most impact, I had already killed anything non-essential. But that still leaves 140 pids. Bert That sounds way too many pids. I run a script to shut down processes when I do testing as

[PATCH 12/12] spidernet: maintainership

2007-02-20 Thread Linas Vepstas
Update driver support contact info. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: Jens Osterkamp <[EMAIL PROTECTED]> Cc: Kou Ishizaki <[EMAIL PROTECTED]> MAINTAINERS |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.20-git16/MAINTAINERS =

[PATCH 11/12] spidernet: janitorial, typos

2007-02-20 Thread Linas Vepstas
Janitorial patch. Undo long lines, fix typo in err msg. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: Jens Osterkamp <[EMAIL PROTECTED]> Cc: Kou Ishizaki <[EMAIL PROTECTED]> drivers/net/spider_net.c | 13 +++-- drivers/net/spider_net.h |2 +- 2 files changed, 8 insert

[PATCH 10/12]: spidernet: transmit race

2007-02-20 Thread Linas Vepstas
Multiple threads performing a transmit can race into the spidernet tx ring cleanup code. This puts the relevant check under a lock. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: Jens Osterkamp <[EMAIL PROTECTED]> Cc: Kou Ishizaki <[EMAIL PROTECTED]> drivers/net/spider_net.c |6

[PATCH 8/12] spidernet: separate hardware state from driver state.

2007-02-20 Thread Linas Vepstas
This patch separates the hardware descriptor state from the driver descriptor state, per (old) suggestion from Ben Herrenschmidt. This compiles and boots and seems to work. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: Jens Osterkamp <[EMAIL PROTECTED]> Cc: Kou Ishizaki <[EMAIL PROTECTED

[PATCH 9/12]: spidernet: fix racy double-free of skb

2007-02-20 Thread Linas Vepstas
It appears that under certain circumstances, a race will result in a double-free of an skb. This patch null's out the skb pointer upon the skb free, avoiding the inadvertent deref of bogus data. The next patch fixes the actual race. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: Jens Osterk

[PATCH 7/12] spidernet: move medium variable into card struct

2007-02-20 Thread Linas Vepstas
From: Jens Osterkamp <[EMAIL PROTECTED]> This moves the medium variable into the spidernet card structure. It renames the GMII_ variables to BCM54XX specific ones. Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]> Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> drivers/net/spider_net.c |

[PATCH 6/12] spidernet: remove txram full logging

2007-02-20 Thread Linas Vepstas
From: Ishizaki Kou <[EMAIL PROTECTED]> This patches removes logging for SPIDER_NET_GTMFLLINT interrupts. Since the interrupts are not irregular, and they happen frequently when using 100Mbps network switches. Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> Signed-off-by: Linas Vepstas <[EMAIL PR

[PATCH 5/12] spidernet: spidernet: add support for Celleb

2007-02-20 Thread Linas Vepstas
From: Kou Ishizaki <[EMAIL PROTECTED]> This patch adds or changes some HW specific settings for spider_net on Celleb. Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> drivers/net/Kconfig |2 +- drivers/net/spider_net.c |8 ++

[PATCH 4/12] spidernet: load firmware when open

2007-02-20 Thread Linas Vepstas
From: Kou Ishizaki <[EMAIL PROTECTED]> This patch moves calling init_firmware() from spider_net_probe() to spider_net_open() so as to use the driver by built-in. Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> drivers/net/spider_net.c | 24

[PATCH 3/12] spidernet: autoneg support for Celleb

2007-02-20 Thread Linas Vepstas
From: Kou Ishizaki <[EMAIL PROTECTED]> Add auto negotiation support for Celleb. Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]> Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> drivers/net/spider_net.c | 176 ++- drivers/net/spider_net.h | 1

[PATCH 2/12] spidernet: compile break.

2007-02-20 Thread Linas Vepstas
As of 2.6.20-git4, the spider_net driver does not compile. This appears to be due to some archaic usage involving kobjects. It also fixes a nasty double-free during ifdown of the interface. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> Cc: Jens Osterkamp <[EMAIL PROTECTED]> Cc: Kou Ishizaki

[PATCH 1/12]: sungem_phy: support bcm5461 phy, autoneg.

2007-02-20 Thread Linas Vepstas
From: Jens Osterkamp <[EMAIL PROTECTED]> This version moves the medium variable to the card specific structure and changes the GMII_* to BCM54XX_* #defines. This patch adds improved version of enable_fiber for both the 5421 and the 5461 phy. It is now possible to specify with these wether you wa

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Arjan van de Ven
> I'm trying to figure out which processes have the most impact, I had already > killed anything non-essential. But that still leaves 140 pids. btw if you have systemtap on your system you can see who is doing evil with http://www.fenrus.org/cstop.stp also.. running "vmstat 3" and looking at th

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread bert hubert
On Tue, Feb 20, 2007 at 02:02:00PM -0800, Rick Jones wrote: > The slope appears to be flattening-out the farther out to the right it > goes. Perhaps that is the length of time it takes to take all the > requisite cache misses. The rate of flattening out appears to correlate with the number of

[PATCH 0/12]: spidernet updates

2007-02-20 Thread Linas Vepstas
Jeff, Please apply and forward upstream this patch series. This is the followup to the collision of patches that landed on your doorstep last week. It rolls up the patches from Jens and Kou. --linas - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code

2007-02-20 Thread Adrian Bunk
On Tue, Feb 20, 2007 at 01:31:32PM -0800, Stephen Hemminger wrote: > On Tue, 20 Feb 2007 01:02:14 +0100 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > On Tue, Nov 28, 2006 at 11:47:19PM -0800, Andrew Morton wrote: > > > On Wed, 29 Nov 2006 08:36:09 +0100 > > > Adrian Bunk <[EMAIL PROTECTED]> wrote

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Rick Jones
I measure a huge slope, however. Starting at 1usec for back-to-back system calls, it rises to 2usec after interleaving calls with a count to 20 million. 4usec is hit after 110 million. The graph, with semi-scientific error-bars is on http://ds9a.nl/tmp/recvfrom-usec-vs-wait.png The code to gene

Re: Re: Strange connection slowdown on pcnet32

2007-02-20 Thread Lennart Sorensen
On Mon, Feb 19, 2007 at 06:59:16PM -0500, Lennart Sorensen wrote: > I am also noticing the receive error count going up, and the source is > this code: > > if (status & 0x01) /* Only count a general error at the */ >lp->stats.rx_errors++; /* end of a packet. */ > > It appears this m

Re: 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code

2007-02-20 Thread Stephen Hemminger
On Tue, 20 Feb 2007 01:02:14 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Tue, Nov 28, 2006 at 11:47:19PM -0800, Andrew Morton wrote: > > On Wed, 29 Nov 2006 08:36:09 +0100 > > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > On Mon, Nov 27, 2006 at 10:24:55AM -0800, Stephen Hemminger wrote:

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Stephen Hemminger
On Tue, 20 Feb 2007 21:45:05 +0100 bert hubert <[EMAIL PROTECTED]> wrote: > On Tue, Feb 20, 2007 at 02:40:40PM -0500, Benjamin LaHaise wrote: > > > Make sure your system is idle. Userspace bloat means that *lots* of idle > > activity occurs in between timer ticks on recent distributions -- all

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread bert hubert
On Tue, Feb 20, 2007 at 02:40:40PM -0500, Benjamin LaHaise wrote: > Make sure your system is idle. Userspace bloat means that *lots* of idle > activity occurs in between timer ticks on recent distributions -- all those You hit the nail on the head. I had previously measured with X shut down, b

Re: Extensible hashing and RCU

2007-02-20 Thread Michael K. Edwards
On 2/20/07, Michael K. Edwards <[EMAIL PROTECTED]> wrote: Correct. That's called a "weak hash", and Jenkins is known to be a thoroughly weak hash. That's why you never, ever use it without a salt, and you don't let an attacker inspect the hash output either. Weak in a cryptographic sense, of

Re: Extensible hashing and RCU

2007-02-20 Thread Michael K. Edwards
On 2/20/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: How I like personal insults - it is always fun to read about myself from people who never knew me :) On this occasion, I did not set out to insult you. I set out to suggest an explanation for why cooler and grayer heads than mine are not

Re: skge dysfunction on Amd X2 machine with 4GB memory

2007-02-20 Thread Stephen Hemminger
On Mon, 19 Feb 2007 23:15:02 -0800 Chris Wedgwood <[EMAIL PROTECTED]> wrote: > On Sun, Feb 11, 2007 at 04:57:55PM +0200, Matti Aarnio wrote: > > > With the skge driver there seems to be some sort of problem to work > > in a system with memory above the 4 GB of PCI address space. > > The chipset

Re: Extensible hashing and RCU

2007-02-20 Thread Evgeniy Polyakov
On Tue, Feb 20, 2007 at 08:17:31PM +0100, Eric Dumazet ([EMAIL PROTECTED]) wrote: > I shown your test was bogus. All your claims are just bogus. > I claim your 'true random data' is a joke. rand() in your program is a pure > joke. Care to reread your mail about your true random case with hash ch

Re: Extensible hashing and RCU

2007-02-20 Thread Evgeniy Polyakov
On Tue, Feb 20, 2007 at 11:13:50AM -0800, Michael K. Edwards ([EMAIL PROTECTED]) wrote: > On 2/20/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > >And here are another ones which produce the same hash value. > >Of course searching for pair for jhash('jhash is broken') > >will require more steps,

Re: Extensible hashing and RCU

2007-02-20 Thread Michael K. Edwards
All right, Eric, you and me so clevvah, let's embarrass our own selves designing this thing in public instead of picking on poor Evgeniy. Which would you rather RCU, a 2-left hash or a splay tree? 2-left hash gets you excellent occupation fraction before the first real collision, so you can be ut

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Benjamin LaHaise
On Tue, Feb 20, 2007 at 08:33:20PM +0100, bert hubert wrote: > I'm investigating this further for other system calls. It might be that my > measurements are off, but it appears even a slight delay between calls > incurs a large penalty. Make sure your system is idle. Userspace bloat means that *l

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread bert hubert
On Tue, Feb 20, 2007 at 09:48:59PM +0300, Evgeniy Polyakov wrote: > Likely first overhead related to cache population or gamma-ray radiation. > If it happens only one (it does in my test), then everything is ok I > think. Bert, how frequently you get that long recvfrom()? I have plotted the avera

Re: Extensible hashing and RCU

2007-02-20 Thread Eric Dumazet
On Tuesday 20 February 2007 20:06, Evgeniy Polyakov wrote: > > I added to my 'simulator_plugged_on_real_server' the average cost > > calculation, relative to number of cache line per lookup. > > > > ehash_size=2^20 > > xor hash : > > 386290 sockets, Avg lookup cost=3.2604 cache lines/lookup > > 39

Re: Extensible hashing and RCU

2007-02-20 Thread Michael K. Edwards
On 2/20/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: And here are another ones which produce the same hash value. Of course searching for pair for jhash('jhash is broken') will require more steps, but it is doable. That means that if attacker has a full control over one host, it can create a

Re: Extensible hashing and RCU

2007-02-20 Thread Evgeniy Polyakov
On Tue, Feb 20, 2007 at 07:55:15PM +0100, Eric Dumazet ([EMAIL PROTECTED]) wrote: > On Tuesday 20 February 2007 19:00, Evgeniy Polyakov wrote: > > As you can see, jhash has problems in a really trivial case of 2^16, > > which in local lan is a disaster. The only reason jenkins hash is good > > for

Re: [RFT] sky2 auto negotiation PHY errata

2007-02-20 Thread Rob Sims
On Fri, Feb 02, 2007 at 11:28:46AM -0800, Stephen Hemminger wrote: > This patch does the Marvell errata before auto negotiation > (from drivers/phy/marvell.c). The Yukon II chips have an internal > version of the same PHY, so perhaps this errata is necessary for them > as well. > > For test only,

Re: [RFT] sky2 auto negotiation PHY errata

2007-02-20 Thread Stephen Hemminger
You need the flow control fix and the tx_timeout fix posted for 2.6.20 (stable) and current git tree. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Extensible hashing and RCU

2007-02-20 Thread Eric Dumazet
On Tuesday 20 February 2007 19:00, Evgeniy Polyakov wrote: > As you can see, jhash has problems in a really trivial case of 2^16, > which in local lan is a disaster. The only reason jenkins hash is good > for hashing purposes is that is it more complex than xor one, and thus > it is harder to find

Re: [TIPC] Missing null check in the socket code.

2007-02-20 Thread Max Krasnyansky
Max Krasnyansky wrote: Fixes an oops in the non-blocking mode. Signed-off-by: Max Krasnyansky <[EMAIL PROTECTED]> --- net/tipc/socket.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 2a6a5a6..767f791 100644 --- a/net/tipc/

Re: [TIPC] Properly mask header fields

2007-02-20 Thread Max Krasnyansky
Dave, Alan, Jon, Max Krasnyansky wrote: TIPC code is a bit inconsistent in masking out upper bits of various message fields when packing them into the headers. For the most part things seem to be ok but we happened to hit a corner case in our labs when broadcast counter reached certain value (do

[PATCH 2/3] forcedeth: disable msix

2007-02-20 Thread Ayaz Abdulla
There seems to be an issue when both MSI-X is enabled and NAPI is configured. This patch disables MSI-X until the issue is root caused. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> --- orig/drivers/net/forcedeth.c2007-02-20 03:29:04.0 -0500 +++ new/drivers/net/forcedeth.c 200

[PATCH 3/3] forcedeth: fix checksum feature in mcp65

2007-02-20 Thread Ayaz Abdulla
This patch removes checksum offload feature in mcp65 chipsets as they are not supported in hw. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> --- orig/drivers/net/forcedeth.c2007-02-20 03:30:16.0 -0500 +++ new/drivers/net/forcedeth.c 2007-02-20 03:30:29.0 -0500 @@ -5374,

[PATCH 1/3] forcedeth: fixed missing call in napi poll

2007-02-20 Thread Ayaz Abdulla
The napi poll routine was missing the call to the optimized rx process routine. This patch adds the missing call for the optimized path. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> --- orig/drivers/net/forcedeth.c2007-02-20 03:17:21.0 -0500 +++ new/drivers/net/forcedeth.c 20

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Evgeniy Polyakov
On Tue, Feb 20, 2007 at 01:42:42PM -0500, Josef Sipek ([EMAIL PROTECTED]) wrote: > A better thing would be to use getuid - it turns into just a return with a > memory dereference). I ran it on my 3.06GHz P4 (HT, but only UP kernel), > PREEMPT, HZ=1000... > > 3.290196 0.470588 0.402614 0.396078 0.3

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Josef Sipek
On Tue, Feb 20, 2007 at 07:41:25PM +0300, Evgeniy Polyakov wrote: > On Tue, Feb 20, 2007 at 05:27:14PM +0100, bert hubert ([EMAIL PROTECTED]) > wrote: > > I've done so, with some interesting results. Source on > > http://ds9a.nl/tmp/recvtimings.c - be careful to adjust the '3000' divider > > to yo

[git patches] net driver updates

2007-02-20 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/8139too.c | 40 ++--- drivers/net/hamradio/baycom_epp.c | 13 +-- drivers/net/

Re: Extensible hashing and RCU

2007-02-20 Thread Evgeniy Polyakov
On Tue, Feb 20, 2007 at 08:55:50PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > Here is a dump of possible addr/port pairs which end up badly > distributed: > > 8e363a50:27652 -> c0a80001:20480 > 8e363a50:35529 -> c0a80001:20480 > 8e363a50:40919 -> c0a80001:20480 > 8e363a50:46720 -> c0a80

Re: Extensible hashing and RCU

2007-02-20 Thread Evgeniy Polyakov
On Tue, Feb 20, 2007 at 06:53:59PM +0100, Eric Dumazet ([EMAIL PROTECTED]) wrote: > > > I've attached source code and running script. > > > $ ./run.sh > > > > Yep, of course. > > Your test program is just bogus. artefacts come from your 'random' generator. > > You just increment a counter, assum

Re: [PATCH] ehea: dynamic add / remove port

2007-02-20 Thread John Rose
Hi Jan- > Would that interface be sufficient for the userspace application? This looks great! Two questions. I would assume that the of_device results in a "devspec" file in the sysfs directory for the port? Also, is there a way to correlate a logical port to an ethernet interface (eth0, etc)?

Re: Extensible hashing and RCU

2007-02-20 Thread Evgeniy Polyakov
On Tue, Feb 20, 2007 at 06:20:26PM +0100, Eric Dumazet ([EMAIL PROTECTED]) wrote: > > Hmm, I've just ran following test: > > 1. created 2^20 hash table. > > 2. ran in loop (100*(2^20) iterations) following hashes: > > a. xor hash (const_ip, const_ip, random_word) > > So what ? to attack me you w

Re: Extensible hashing and RCU

2007-02-20 Thread Eric Dumazet
On Tuesday 20 February 2007 18:05, Evgeniy Polyakov wrote: > On Tue, Feb 20, 2007 at 07:59:07PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > > I've attached source code and running script. > > $ ./run.sh > > Yep, of course. Your test program is just bogus. artefacts come from your 'random

[PATCH] ehea: dynamic add / remove port

2007-02-20 Thread Jan-Bernd Themann
Hi, This patch enables dynamic adding / removing of ehea ports by DLPAR tool. It creates a subnode for each logical port in the sysfs. Furthermore, it has attributes that show the associated eth device, the logical port number, and the path in the open firmware device tree. Logical ports can be a

Re: Extensible hashing and RCU

2007-02-20 Thread Eric Dumazet
On Tuesday 20 February 2007 17:59, Evgeniy Polyakov wrote: > On Tue, Feb 20, 2007 at 05:38:19PM +0100, Eric Dumazet ([EMAIL PROTECTED]) wrote: > > > It is secrecy, not security - attacker will check the source and find > > > where constant per-boot value is added and recalculate attack vector - >

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Evgeniy Polyakov
On Tue, Feb 20, 2007 at 08:11:20PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > I would try it today - but it is a bit late in Moscow already - and > there are some things to complete yet. So, tomorrow I will create a patch > and run it, but I seriously doubt that there is _that_ high per-

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Evgeniy Polyakov
On Tue, Feb 20, 2007 at 06:02:32PM +0100, bert hubert ([EMAIL PROTECTED]) wrote: > On Tue, Feb 20, 2007 at 07:41:25PM +0300, Evgeniy Polyakov wrote: > > > It can be recvfrom only problem - syscall overhead on my p4 (core duo, > > debian testing) is bout 300 usec - to test I ran read('dev/zero', &d

Re: Extensible hashing and RCU

2007-02-20 Thread Evgeniy Polyakov
On Tue, Feb 20, 2007 at 07:59:07PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > I've attached source code and running script. > $ ./run.sh Yep, of course. -- Evgeniy Polyakov #include #include #include #include #include #include #include typedef unsigned int u32; typede

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread bert hubert
On Tue, Feb 20, 2007 at 07:41:25PM +0300, Evgeniy Polyakov wrote: > It can be recvfrom only problem - syscall overhead on my p4 (core duo, > debian testing) is bout 300 usec - to test I ran read('dev/zero', &data, > 0) in a loop. nsec I assume? The usec numbers for read(fd, &c, 0) where fd is /d

Re: Extensible hashing and RCU

2007-02-20 Thread Evgeniy Polyakov
On Tue, Feb 20, 2007 at 05:38:19PM +0100, Eric Dumazet ([EMAIL PROTECTED]) wrote: > > It is secrecy, not security - attacker will check the source and find > > where constant per-boot value is added and recalculate attack vector - > > we all were college students, it would be even more fun to crac

Re: [PATCH] Eliminate user-selectable CONFIG_MV643XX_ETH_[012]

2007-02-20 Thread Ralf Baechle
On Tue, Feb 20, 2007 at 11:27:30AM -0500, Jeff Garzik wrote: > >It was a mis-feature that the supported ports were ever user-selectable. > >Which ports the hardware supports should be specified by platform-specific > >code, not by the user. > > > > arch/mips/momentum/jaguar_atx/platform.c | 21 -

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Eric Dumazet
On Tuesday 20 February 2007 17:27, bert hubert wrote: > On Tue, Feb 20, 2007 at 11:50:13AM +0100, Andi Kleen wrote: > > P4s are pretty slow at taking locks (or rather doing atomical operations) > > and there are several of them in this path. You could try it with a UP > > kernel. Actually hotunplug

Re: all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread Evgeniy Polyakov
On Tue, Feb 20, 2007 at 05:27:14PM +0100, bert hubert ([EMAIL PROTECTED]) wrote: > I've done so, with some interesting results. Source on > http://ds9a.nl/tmp/recvtimings.c - be careful to adjust the '3000' divider > to your CPU frequency if you care about absolute numbers! > > These are two group

Re: Extensible hashing and RCU

2007-02-20 Thread Eric Dumazet
On Tuesday 20 February 2007 17:20, Evgeniy Polyakov wrote: > On Tue, Feb 20, 2007 at 05:08:12PM +0100, Eric Dumazet ([EMAIL PROTECTED]) wrote: > > > Adding XOR with constant value does not change distribution. > > > Variable salt will end up with differnet buckets for the same flow. > > > It is fo

Re: [PATCH] Eliminate user-selectable CONFIG_MV643XX_ETH_[012]

2007-02-20 Thread Jeff Garzik
Dale Farnsworth wrote: From: Dale Farnsworth <[EMAIL PROTECTED]> Remove the use of CONFIG_MV643XX_ETH_[012] variables on most platforms. Instead, platform-specific code enables the ports supported by the hardware. After this patch, these config variables are only used in arch/ppc, so also move

Re: [PATCH 2/3] forcedeth: disable msix

2007-02-20 Thread Jeff Garzik
Ayaz Abdulla wrote: There seems to be an issue when both MSI-X is enabled and NAPI is configured. This patch disables MSI-X until the issue is root caused. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> ACK patches 2-3 Will await resend of entire patch series, after patch #1 is updated -

all syscalls initially taking 4usec on a P4? Re: nonblocking UDPv4 recvfrom() taking 4usec @ 3GHz?

2007-02-20 Thread bert hubert
On Tue, Feb 20, 2007 at 11:50:13AM +0100, Andi Kleen wrote: > P4s are pretty slow at taking locks (or rather doing atomical operations) > and there are several of them in this path. You could try it with a UP > kernel. Actually hotunplugging the other virtual CPU should be sufficient > with recent

Re: [PATCH 1/3] forcedeth: fixed missing call in napi poll

2007-02-20 Thread Jeff Garzik
Ayaz Abdulla wrote: The napi poll routine was missing the call to the optimized rx process routine. This patch adds the missing call for the optimized path. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> --- orig/drive

Re: Extensible hashing and RCU

2007-02-20 Thread Evgeniy Polyakov
On Tue, Feb 20, 2007 at 05:08:12PM +0100, Eric Dumazet ([EMAIL PROTECTED]) wrote: > > Adding XOR with constant value does not change distribution. > > Variable salt will end up with differnet buckets for the same flow. > > It is forbidden - it is not the situation created for passwd/des decades >

Re: [PATCH 1/1] Fabric7 VIOC driver source code

2007-02-20 Thread Jeff Garzik
applied to #vioc branch of netdev-2.6.git, which will be merged into #ALL for a period of review and testing. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 1/2] natsemi: Add support for using MII port with no PHY

2007-02-20 Thread Jeff Garzik
Mark Brown wrote: This patch provides code paths which allow the natsemi driver to use the external MII port on the chip but ignore any PHYs that may be attached to it. The link state will be left as it was when the driver started and can be configured via ethtool. Any PHYs that are present can

Re: [HAMRADIO] Replace local random function with random32()

2007-02-20 Thread Jeff Garzik
Ralf Baechle wrote: Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] skge: race with workq and RTNL

2007-02-20 Thread Jeff Garzik
Stephen Hemminger wrote: If a workqueue function that needs RTNL is running when skge_down is called then a deadlock is possible. Fix by only clearing the timer, and handling the flush_scheduled_work on removal. This work queue is only ever used for the old fiber based boards. Signed-off-by: Ste

Re: [PATCH 1/4] r8169: RTNL and flush_scheduled_work deadlock

2007-02-20 Thread Jeff Garzik
Francois Romieu wrote: flush_scheduled_work() in net_device->close has a slight tendency to deadlock with tasks on the workqueue that hold RTNL. rtl8169_close/down simply need the recovery tasks to not meddle with the hardware while the device is going down. Signed-off-by: Francois Romieu <[EMA

Re: watchdog timeout panic in e1000 driver

2007-02-20 Thread Auke Kok
Kenzo Iwami wrote: Hi, I created a patch that uses watchdog_task but fixes the race condition that occurred in old the e1000 driver. I've obtained information about the panic caused by the old e1000 driver using e1000_watchdog_task. According to the crash dump, the panic was caused by a timer_l

Re: Extensible hashing and RCU

2007-02-20 Thread Eric Dumazet
On Tuesday 20 February 2007 16:59, Evgeniy Polyakov wrote: > On Tue, Feb 20, 2007 at 07:49:11AM -0800, Michael K. Edwards ([EMAIL PROTECTED]) wrote: > > On 2/20/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > >Jenkins _does_ have them, I showed tests half a year ago and in this > > >thread too

Re: Extensible hashing and RCU

2007-02-20 Thread Eric Dumazet
On Tuesday 20 February 2007 16:49, Michael K. Edwards wrote: > On 2/20/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > Jenkins _does_ have them, I showed tests half a year ago and in this > > thread too. Actually _any_ hash has them it is just a matter of time > > to find one. > > I think you m

Re: Extensible hashing and RCU

2007-02-20 Thread Evgeniy Polyakov
On Tue, Feb 20, 2007 at 07:49:11AM -0800, Michael K. Edwards ([EMAIL PROTECTED]) wrote: > On 2/20/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > >Jenkins _does_ have them, I showed tests half a year ago and in this > >thread too. Actually _any_ hash has them it is just a matter of time > >to fi

Re: Extensible hashing and RCU

2007-02-20 Thread Michael K. Edwards
On 2/20/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: Jenkins _does_ have them, I showed tests half a year ago and in this thread too. Actually _any_ hash has them it is just a matter of time to find one. I think you misunderstood me. If you are trying to DoS me from outside with a hash coll

[PATCH] [TCP] Cleanup: struct *sock argument renamed: sp -> sk

2007-02-20 Thread Ilpo Järvinen
In general, TCP code uses "sk" for struct sock pointer. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_ipv4.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 0ba74bb..f6793b4 100644

Re: Network: convert network devices to use struct device instead of class_device

2007-02-20 Thread Dmitry Torokhov
On 2/8/07, Greg KH <[EMAIL PROTECTED]> wrote: And it should also alow for proper power management functionality, using the changes that Linus put into the driver core about 8 months ago. Don't worry, I have input patches queued up next for you Dmitry :) Greg, Could you please forward me the

  1   2   >